Track bool-returning and scalar-T-returning HW intrinsics via flags

[Copilot]

Several hardware intrinsics are known to return bool or a scalar T, but consumers (assertionprop, rangecheck, valuenum) tracked them via long ID switches that had to be kept in sync. Replace those with flags on the intrinsic table queryable through HWIntrinsicInfo.

hwintrinsic.h

• Widen HWIntrinsicFlag to uint64_t (arm64 was out of bits in the 32-bit space).
• Add HW_Flag_ReturnsBoolean and HW_Flag_ReturnsScalarT as common flags.
• Add HWIntrinsicInfo::ReturnsBoolean / ReturnsScalarT static APIs, grouped after ReturnsPerElementMask.

hwintrinsiclist*.h

Tag the entries previously enumerated in the consumer switches (skipping HW_Flag_InvalidNodeId entries per the issue):

• xarch: 24 ReturnsBoolean (Vector{128,256,512}_op_{Equality,Inequality}, X86Base.CompareScalar{Ordered,Unordered}*, X86Base/AVXTest{C,Z,NotZAndNotC}) and 8 ReturnsScalarT (Vector{128,256,512}.{GetElement,ToScalar}, X86Base[_X64].Extract).
• arm64: 4 ReturnsBoolean (Vector{64,128}_op_{Equality,Inequality}) and 5 ReturnsScalarT (Vector{64,128}.{GetElement,ToScalar}, AdvSimd.Extract).

Consumer refactors

assertionprop.cpp, rangecheck.cpp, and valuenum.cpp no longer enumerate intrinsic IDs in their GT_HWINTRINSIC / VNF_HWI_* switches. A flag check runs before the remaining switch and preserves prior semantics, e.g.:

if (HWIntrinsicInfo::ReturnsBoolean(id))
{
rangeType = TYP_INT;
range = Range(Limit(Limit::keConstant, 0), Limit(Limit::keConstant, 1));
break;
}
if (HWIntrinsicInfo::ReturnsScalarT(id) && varTypeIsSmall(simdBaseType))
{
rangeType = simdBaseType;
break;
}

For IsVNNeverNegative the scalar-T path keeps its base-type guard (only TYP_UBYTE/TYP_USHORT continue), matching the previous case-by-case behavior. The HW intrinsic checks in IsVNNeverNegative and rangecheck.cpp now use IsVNHWIntrinsicFunc, eliminating the manual VNF_HWI_FIRST/VNF_HWI_LAST range check, the explicit NamedIntrinsic cast, the separate GetVNHWIntrinsicSizeAndBaseType call. Both IsVNHWIntrinsicFunc blocks are correctly wrapped in #if defined(FEATURE_HW_INTRINSICS) / #endif guards.

SVE bool/scalar-T intrinsics are intentionally not tagged here — they were never in the original switches and remain covered by the existing TODO-SVE notes.

[tannergooding]

CC. @EgorBo, the downside of this is that we were out of flag space and so it extends it up to uint64_t.

I think there's likely cleanup possible and we can free up space, but I expect that's more involved and requires careful thought.

[Copilot]

Pull request overview

This PR centralizes knowledge about certain hardware intrinsics that return either a boolean (conceptually TYP_INT in range [0, 1]) or a scalar of the SIMD base type, by encoding that information as flags in the HW intrinsic table and switching consumers over to flag queries.

Changes:

• Widen HWIntrinsicFlag to uint64_t and add common flags for ReturnsBoolean and ReturnsScalarT, exposed via HWIntrinsicInfo.
• Tag relevant xarch/arm64 intrinsic table entries with the new return-shape flags.
• Refactor assertionprop.cpp, rangecheck.cpp, and valuenum.cpp to query HWIntrinsicInfo::{ReturnsBoolean,ReturnsScalarT} instead of maintaining long intrinsic-ID switches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/valuenum.cpp	Uses HW intrinsic return-shape flags to simplify IsVNNeverNegative handling for HWI VNs.
src/coreclr/jit/rangecheck.cpp	Uses HW intrinsic return-shape flags to derive ranges for HWI VNs without ID enumeration.
src/coreclr/jit/assertionprop.cpp	Uses HW intrinsic return-shape flags to derive symbolic integer ranges for GT_HWINTRINSIC.
src/coreclr/jit/hwintrinsiclistxarch.h	Tags xarch intrinsics (equality/test/compare, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsiclistarm64.h	Tags arm64 intrinsics (equality, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsic.h	Widens flag type and adds ReturnsBoolean / ReturnsScalarT APIs on HWIntrinsicInfo.

[Copilot]

Several hardware intrinsics are known to return bool or a scalar T, but consumers (assertionprop, rangecheck, valuenum) tracked them via long ID switches that had to be kept in sync. Replace those with flags on the intrinsic table queryable through HWIntrinsicInfo.

hwintrinsic.h

• Widen HWIntrinsicFlag to uint64_t (arm64 was out of bits in the 32-bit space).
• Add HW_Flag_ReturnsBoolean and HW_Flag_ReturnsScalarT as common flags.
• Add HWIntrinsicInfo::ReturnsBoolean / ReturnsScalarT static APIs, grouped after ReturnsPerElementMask.

hwintrinsiclist*.h

Tag the entries previously enumerated in the consumer switches (skipping HW_Flag_InvalidNodeId entries per the issue):

• xarch: 24 ReturnsBoolean (Vector{128,256,512}_op_{Equality,Inequality}, X86Base.CompareScalar{Ordered,Unordered}*, X86Base/AVXTest{C,Z,NotZAndNotC}) and 8 ReturnsScalarT (Vector{128,256,512}.{GetElement,ToScalar}, X86Base[_X64].Extract).
• arm64: 4 ReturnsBoolean (Vector{64,128}_op_{Equality,Inequality}) and 5 ReturnsScalarT (Vector{64,128}.{GetElement,ToScalar}, AdvSimd.Extract).

Consumer refactors

assertionprop.cpp, rangecheck.cpp, and valuenum.cpp no longer enumerate intrinsic IDs in their GT_HWINTRINSIC / VNF_HWI_* switches. A flag check runs before the remaining switch and preserves prior semantics, e.g.:

if (HWIntrinsicInfo::ReturnsBoolean(id))
{
rangeType = TYP_INT;
range = Range(Limit(Limit::keConstant, 0), Limit(Limit::keConstant, 1));
break;
}
if (HWIntrinsicInfo::ReturnsScalarT(id) && varTypeIsSmall(simdBaseType))
{
rangeType = simdBaseType;
break;
}

For IsVNNeverNegative the scalar-T path keeps its base-type guard (only TYP_UBYTE/TYP_USHORT continue), matching the previous case-by-case behavior. The HW intrinsic checks in IsVNNeverNegative and rangecheck.cpp now use IsVNHWIntrinsicFunc, eliminating the manual VNF_HWI_FIRST/VNF_HWI_LAST range check, the explicit NamedIntrinsic cast, the separate GetVNHWIntrinsicSizeAndBaseType call. Both IsVNHWIntrinsicFunc blocks are correctly wrapped in #if defined(FEATURE_HW_INTRINSICS) / #endif guards.

SVE bool/scalar-T intrinsics are intentionally not tagged here — they were never in the original switches and remain covered by the existing TODO-SVE notes.

[tannergooding]

CC. @EgorBo, the downside of this is that we were out of flag space and so it extends it up to uint64_t.

I think there's likely cleanup possible and we can free up space, but I expect that's more involved and requires careful thought.

[Copilot]

Pull request overview

This PR centralizes knowledge about certain hardware intrinsics that return either a boolean (conceptually TYP_INT in range [0, 1]) or a scalar of the SIMD base type, by encoding that information as flags in the HW intrinsic table and switching consumers over to flag queries.

Changes:

• Widen HWIntrinsicFlag to uint64_t and add common flags for ReturnsBoolean and ReturnsScalarT, exposed via HWIntrinsicInfo.
• Tag relevant xarch/arm64 intrinsic table entries with the new return-shape flags.
• Refactor assertionprop.cpp, rangecheck.cpp, and valuenum.cpp to query HWIntrinsicInfo::{ReturnsBoolean,ReturnsScalarT} instead of maintaining long intrinsic-ID switches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/valuenum.cpp	Uses HW intrinsic return-shape flags to simplify IsVNNeverNegative handling for HWI VNs.
src/coreclr/jit/rangecheck.cpp	Uses HW intrinsic return-shape flags to derive ranges for HWI VNs without ID enumeration.
src/coreclr/jit/assertionprop.cpp	Uses HW intrinsic return-shape flags to derive symbolic integer ranges for GT_HWINTRINSIC.
src/coreclr/jit/hwintrinsiclistxarch.h	Tags xarch intrinsics (equality/test/compare, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsiclistarm64.h	Tags arm64 intrinsics (equality, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsic.h	Widens flag type and adds ReturnsBoolean / ReturnsScalarT APIs on HWIntrinsicInfo.

[Copilot]

Several hardware intrinsics are known to return bool or a scalar T, but consumers (assertionprop, rangecheck, valuenum) tracked them via long ID switches that had to be kept in sync. Replace those with flags on the intrinsic table queryable through HWIntrinsicInfo.

hwintrinsic.h

• Widen HWIntrinsicFlag to uint64_t (arm64 was out of bits in the 32-bit space).
• Add HW_Flag_ReturnsBoolean and HW_Flag_ReturnsScalarT as common flags.
• Add HWIntrinsicInfo::ReturnsBoolean / ReturnsScalarT static APIs, grouped after ReturnsPerElementMask.

hwintrinsiclist*.h

Tag the entries previously enumerated in the consumer switches (skipping HW_Flag_InvalidNodeId entries per the issue):

• xarch: 24 ReturnsBoolean (Vector{128,256,512}_op_{Equality,Inequality}, X86Base.CompareScalar{Ordered,Unordered}*, X86Base/AVXTest{C,Z,NotZAndNotC}) and 8 ReturnsScalarT (Vector{128,256,512}.{GetElement,ToScalar}, X86Base[_X64].Extract).
• arm64: 4 ReturnsBoolean (Vector{64,128}_op_{Equality,Inequality}) and 5 ReturnsScalarT (Vector{64,128}.{GetElement,ToScalar}, AdvSimd.Extract).

Consumer refactors

assertionprop.cpp, rangecheck.cpp, and valuenum.cpp no longer enumerate intrinsic IDs in their GT_HWINTRINSIC / VNF_HWI_* switches. A flag check runs before the remaining switch and preserves prior semantics, e.g.:

if (HWIntrinsicInfo::ReturnsBoolean(id))
{
rangeType = TYP_INT;
range = Range(Limit(Limit::keConstant, 0), Limit(Limit::keConstant, 1));
break;
}
if (HWIntrinsicInfo::ReturnsScalarT(id) && varTypeIsSmall(simdBaseType))
{
rangeType = simdBaseType;
break;
}

For IsVNNeverNegative the scalar-T path keeps its base-type guard (only TYP_UBYTE/TYP_USHORT continue), matching the previous case-by-case behavior. The HW intrinsic checks in IsVNNeverNegative and rangecheck.cpp now use IsVNHWIntrinsicFunc, eliminating the manual VNF_HWI_FIRST/VNF_HWI_LAST range check, the explicit NamedIntrinsic cast, the separate GetVNHWIntrinsicSizeAndBaseType call. Both IsVNHWIntrinsicFunc blocks are correctly wrapped in #if defined(FEATURE_HW_INTRINSICS) / #endif guards.

SVE bool/scalar-T intrinsics are intentionally not tagged here — they were never in the original switches and remain covered by the existing TODO-SVE notes.

[tannergooding]

CC. @EgorBo, the downside of this is that we were out of flag space and so it extends it up to uint64_t.

I think there's likely cleanup possible and we can free up space, but I expect that's more involved and requires careful thought.

[Copilot]

Pull request overview

This PR centralizes knowledge about certain hardware intrinsics that return either a boolean (conceptually TYP_INT in range [0, 1]) or a scalar of the SIMD base type, by encoding that information as flags in the HW intrinsic table and switching consumers over to flag queries.

Changes:

• Widen HWIntrinsicFlag to uint64_t and add common flags for ReturnsBoolean and ReturnsScalarT, exposed via HWIntrinsicInfo.
• Tag relevant xarch/arm64 intrinsic table entries with the new return-shape flags.
• Refactor assertionprop.cpp, rangecheck.cpp, and valuenum.cpp to query HWIntrinsicInfo::{ReturnsBoolean,ReturnsScalarT} instead of maintaining long intrinsic-ID switches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/valuenum.cpp	Uses HW intrinsic return-shape flags to simplify IsVNNeverNegative handling for HWI VNs.
src/coreclr/jit/rangecheck.cpp	Uses HW intrinsic return-shape flags to derive ranges for HWI VNs without ID enumeration.
src/coreclr/jit/assertionprop.cpp	Uses HW intrinsic return-shape flags to derive symbolic integer ranges for GT_HWINTRINSIC.
src/coreclr/jit/hwintrinsiclistxarch.h	Tags xarch intrinsics (equality/test/compare, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsiclistarm64.h	Tags arm64 intrinsics (equality, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsic.h	Widens flag type and adds ReturnsBoolean / ReturnsScalarT APIs on HWIntrinsicInfo.

[Copilot]

Several hardware intrinsics are known to return bool or a scalar T, but consumers (assertionprop, rangecheck, valuenum) tracked them via long ID switches that had to be kept in sync. Replace those with flags on the intrinsic table queryable through HWIntrinsicInfo.

hwintrinsic.h

• Widen HWIntrinsicFlag to uint64_t (arm64 was out of bits in the 32-bit space).
• Add HW_Flag_ReturnsBoolean and HW_Flag_ReturnsScalarT as common flags.
• Add HWIntrinsicInfo::ReturnsBoolean / ReturnsScalarT static APIs, grouped after ReturnsPerElementMask.

hwintrinsiclist*.h

Tag the entries previously enumerated in the consumer switches (skipping HW_Flag_InvalidNodeId entries per the issue):

• xarch: 24 ReturnsBoolean (Vector{128,256,512}_op_{Equality,Inequality}, X86Base.CompareScalar{Ordered,Unordered}*, X86Base/AVXTest{C,Z,NotZAndNotC}) and 8 ReturnsScalarT (Vector{128,256,512}.{GetElement,ToScalar}, X86Base[_X64].Extract).
• arm64: 4 ReturnsBoolean (Vector{64,128}_op_{Equality,Inequality}) and 5 ReturnsScalarT (Vector{64,128}.{GetElement,ToScalar}, AdvSimd.Extract).

Consumer refactors

assertionprop.cpp, rangecheck.cpp, and valuenum.cpp no longer enumerate intrinsic IDs in their GT_HWINTRINSIC / VNF_HWI_* switches. A flag check runs before the remaining switch and preserves prior semantics, e.g.:

if (HWIntrinsicInfo::ReturnsBoolean(id))
{
rangeType = TYP_INT;
range = Range(Limit(Limit::keConstant, 0), Limit(Limit::keConstant, 1));
break;
}
if (HWIntrinsicInfo::ReturnsScalarT(id) && varTypeIsSmall(simdBaseType))
{
rangeType = simdBaseType;
break;
}

For IsVNNeverNegative the scalar-T path keeps its base-type guard (only TYP_UBYTE/TYP_USHORT continue), matching the previous case-by-case behavior. The HW intrinsic checks in IsVNNeverNegative and rangecheck.cpp now use IsVNHWIntrinsicFunc, eliminating the manual VNF_HWI_FIRST/VNF_HWI_LAST range check, the explicit NamedIntrinsic cast, the separate GetVNHWIntrinsicSizeAndBaseType call. Both IsVNHWIntrinsicFunc blocks are correctly wrapped in #if defined(FEATURE_HW_INTRINSICS) / #endif guards.

SVE bool/scalar-T intrinsics are intentionally not tagged here — they were never in the original switches and remain covered by the existing TODO-SVE notes.

[tannergooding]

CC. @EgorBo, the downside of this is that we were out of flag space and so it extends it up to uint64_t.

I think there's likely cleanup possible and we can free up space, but I expect that's more involved and requires careful thought.

[Copilot]

Pull request overview

This PR centralizes knowledge about certain hardware intrinsics that return either a boolean (conceptually TYP_INT in range [0, 1]) or a scalar of the SIMD base type, by encoding that information as flags in the HW intrinsic table and switching consumers over to flag queries.

Changes:

• Widen HWIntrinsicFlag to uint64_t and add common flags for ReturnsBoolean and ReturnsScalarT, exposed via HWIntrinsicInfo.
• Tag relevant xarch/arm64 intrinsic table entries with the new return-shape flags.
• Refactor assertionprop.cpp, rangecheck.cpp, and valuenum.cpp to query HWIntrinsicInfo::{ReturnsBoolean,ReturnsScalarT} instead of maintaining long intrinsic-ID switches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/valuenum.cpp	Uses HW intrinsic return-shape flags to simplify IsVNNeverNegative handling for HWI VNs.
src/coreclr/jit/rangecheck.cpp	Uses HW intrinsic return-shape flags to derive ranges for HWI VNs without ID enumeration.
src/coreclr/jit/assertionprop.cpp	Uses HW intrinsic return-shape flags to derive symbolic integer ranges for GT_HWINTRINSIC.
src/coreclr/jit/hwintrinsiclistxarch.h	Tags xarch intrinsics (equality/test/compare, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsiclistarm64.h	Tags arm64 intrinsics (equality, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsic.h	Widens flag type and adds ReturnsBoolean / ReturnsScalarT APIs on HWIntrinsicInfo.

[Copilot]

Several hardware intrinsics are known to return bool or a scalar T, but consumers (assertionprop, rangecheck, valuenum) tracked them via long ID switches that had to be kept in sync. Replace those with flags on the intrinsic table queryable through HWIntrinsicInfo.

hwintrinsic.h

• Widen HWIntrinsicFlag to uint64_t (arm64 was out of bits in the 32-bit space).
• Add HW_Flag_ReturnsBoolean and HW_Flag_ReturnsScalarT as common flags.
• Add HWIntrinsicInfo::ReturnsBoolean / ReturnsScalarT static APIs, grouped after ReturnsPerElementMask.

hwintrinsiclist*.h

Tag the entries previously enumerated in the consumer switches (skipping HW_Flag_InvalidNodeId entries per the issue):

• xarch: 24 ReturnsBoolean (Vector{128,256,512}_op_{Equality,Inequality}, X86Base.CompareScalar{Ordered,Unordered}*, X86Base/AVXTest{C,Z,NotZAndNotC}) and 8 ReturnsScalarT (Vector{128,256,512}.{GetElement,ToScalar}, X86Base[_X64].Extract).
• arm64: 4 ReturnsBoolean (Vector{64,128}_op_{Equality,Inequality}) and 5 ReturnsScalarT (Vector{64,128}.{GetElement,ToScalar}, AdvSimd.Extract).

Consumer refactors

assertionprop.cpp, rangecheck.cpp, and valuenum.cpp no longer enumerate intrinsic IDs in their GT_HWINTRINSIC / VNF_HWI_* switches. A flag check runs before the remaining switch and preserves prior semantics, e.g.:

if (HWIntrinsicInfo::ReturnsBoolean(id))
{
rangeType = TYP_INT;
range = Range(Limit(Limit::keConstant, 0), Limit(Limit::keConstant, 1));
break;
}
if (HWIntrinsicInfo::ReturnsScalarT(id) && varTypeIsSmall(simdBaseType))
{
rangeType = simdBaseType;
break;
}

For IsVNNeverNegative the scalar-T path keeps its base-type guard (only TYP_UBYTE/TYP_USHORT continue), matching the previous case-by-case behavior. The HW intrinsic checks in IsVNNeverNegative and rangecheck.cpp now use IsVNHWIntrinsicFunc, eliminating the manual VNF_HWI_FIRST/VNF_HWI_LAST range check, the explicit NamedIntrinsic cast, the separate GetVNHWIntrinsicSizeAndBaseType call. Both IsVNHWIntrinsicFunc blocks are correctly wrapped in #if defined(FEATURE_HW_INTRINSICS) / #endif guards.

SVE bool/scalar-T intrinsics are intentionally not tagged here — they were never in the original switches and remain covered by the existing TODO-SVE notes.

[tannergooding]

CC. @EgorBo, the downside of this is that we were out of flag space and so it extends it up to uint64_t.

I think there's likely cleanup possible and we can free up space, but I expect that's more involved and requires careful thought.

[Copilot]

Pull request overview

This PR centralizes knowledge about certain hardware intrinsics that return either a boolean (conceptually TYP_INT in range [0, 1]) or a scalar of the SIMD base type, by encoding that information as flags in the HW intrinsic table and switching consumers over to flag queries.

Changes:

• Widen HWIntrinsicFlag to uint64_t and add common flags for ReturnsBoolean and ReturnsScalarT, exposed via HWIntrinsicInfo.
• Tag relevant xarch/arm64 intrinsic table entries with the new return-shape flags.
• Refactor assertionprop.cpp, rangecheck.cpp, and valuenum.cpp to query HWIntrinsicInfo::{ReturnsBoolean,ReturnsScalarT} instead of maintaining long intrinsic-ID switches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/valuenum.cpp	Uses HW intrinsic return-shape flags to simplify IsVNNeverNegative handling for HWI VNs.
src/coreclr/jit/rangecheck.cpp	Uses HW intrinsic return-shape flags to derive ranges for HWI VNs without ID enumeration.
src/coreclr/jit/assertionprop.cpp	Uses HW intrinsic return-shape flags to derive symbolic integer ranges for GT_HWINTRINSIC.
src/coreclr/jit/hwintrinsiclistxarch.h	Tags xarch intrinsics (equality/test/compare, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsiclistarm64.h	Tags arm64 intrinsics (equality, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsic.h	Widens flag type and adds ReturnsBoolean / ReturnsScalarT APIs on HWIntrinsicInfo.

[Copilot]

Several hardware intrinsics are known to return bool or a scalar T, but consumers (assertionprop, rangecheck, valuenum) tracked them via long ID switches that had to be kept in sync. Replace those with flags on the intrinsic table queryable through HWIntrinsicInfo.

hwintrinsic.h

• Widen HWIntrinsicFlag to uint64_t (arm64 was out of bits in the 32-bit space).
• Add HW_Flag_ReturnsBoolean and HW_Flag_ReturnsScalarT as common flags.
• Add HWIntrinsicInfo::ReturnsBoolean / ReturnsScalarT static APIs, grouped after ReturnsPerElementMask.

hwintrinsiclist*.h

Tag the entries previously enumerated in the consumer switches (skipping HW_Flag_InvalidNodeId entries per the issue):

• xarch: 24 ReturnsBoolean (Vector{128,256,512}_op_{Equality,Inequality}, X86Base.CompareScalar{Ordered,Unordered}*, X86Base/AVXTest{C,Z,NotZAndNotC}) and 8 ReturnsScalarT (Vector{128,256,512}.{GetElement,ToScalar}, X86Base[_X64].Extract).
• arm64: 4 ReturnsBoolean (Vector{64,128}_op_{Equality,Inequality}) and 5 ReturnsScalarT (Vector{64,128}.{GetElement,ToScalar}, AdvSimd.Extract).

Consumer refactors

assertionprop.cpp, rangecheck.cpp, and valuenum.cpp no longer enumerate intrinsic IDs in their GT_HWINTRINSIC / VNF_HWI_* switches. A flag check runs before the remaining switch and preserves prior semantics, e.g.:

if (HWIntrinsicInfo::ReturnsBoolean(id))
{
rangeType = TYP_INT;
range = Range(Limit(Limit::keConstant, 0), Limit(Limit::keConstant, 1));
break;
}
if (HWIntrinsicInfo::ReturnsScalarT(id) && varTypeIsSmall(simdBaseType))
{
rangeType = simdBaseType;
break;
}

For IsVNNeverNegative the scalar-T path keeps its base-type guard (only TYP_UBYTE/TYP_USHORT continue), matching the previous case-by-case behavior. The HW intrinsic checks in IsVNNeverNegative and rangecheck.cpp now use IsVNHWIntrinsicFunc, eliminating the manual VNF_HWI_FIRST/VNF_HWI_LAST range check, the explicit NamedIntrinsic cast, the separate GetVNHWIntrinsicSizeAndBaseType call. Both IsVNHWIntrinsicFunc blocks are correctly wrapped in #if defined(FEATURE_HW_INTRINSICS) / #endif guards.

SVE bool/scalar-T intrinsics are intentionally not tagged here — they were never in the original switches and remain covered by the existing TODO-SVE notes.

[tannergooding]

CC. @EgorBo, the downside of this is that we were out of flag space and so it extends it up to uint64_t.

I think there's likely cleanup possible and we can free up space, but I expect that's more involved and requires careful thought.

[Copilot]

Pull request overview

This PR centralizes knowledge about certain hardware intrinsics that return either a boolean (conceptually TYP_INT in range [0, 1]) or a scalar of the SIMD base type, by encoding that information as flags in the HW intrinsic table and switching consumers over to flag queries.

Changes:

• Widen HWIntrinsicFlag to uint64_t and add common flags for ReturnsBoolean and ReturnsScalarT, exposed via HWIntrinsicInfo.
• Tag relevant xarch/arm64 intrinsic table entries with the new return-shape flags.
• Refactor assertionprop.cpp, rangecheck.cpp, and valuenum.cpp to query HWIntrinsicInfo::{ReturnsBoolean,ReturnsScalarT} instead of maintaining long intrinsic-ID switches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/valuenum.cpp	Uses HW intrinsic return-shape flags to simplify IsVNNeverNegative handling for HWI VNs.
src/coreclr/jit/rangecheck.cpp	Uses HW intrinsic return-shape flags to derive ranges for HWI VNs without ID enumeration.
src/coreclr/jit/assertionprop.cpp	Uses HW intrinsic return-shape flags to derive symbolic integer ranges for GT_HWINTRINSIC.
src/coreclr/jit/hwintrinsiclistxarch.h	Tags xarch intrinsics (equality/test/compare, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsiclistarm64.h	Tags arm64 intrinsics (equality, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsic.h	Widens flag type and adds ReturnsBoolean / ReturnsScalarT APIs on HWIntrinsicInfo.

[Copilot]

Several hardware intrinsics are known to return bool or a scalar T, but consumers (assertionprop, rangecheck, valuenum) tracked them via long ID switches that had to be kept in sync. Replace those with flags on the intrinsic table queryable through HWIntrinsicInfo.

hwintrinsic.h

• Widen HWIntrinsicFlag to uint64_t (arm64 was out of bits in the 32-bit space).
• Add HW_Flag_ReturnsBoolean and HW_Flag_ReturnsScalarT as common flags.
• Add HWIntrinsicInfo::ReturnsBoolean / ReturnsScalarT static APIs, grouped after ReturnsPerElementMask.

hwintrinsiclist*.h

Tag the entries previously enumerated in the consumer switches (skipping HW_Flag_InvalidNodeId entries per the issue):

• xarch: 24 ReturnsBoolean (Vector{128,256,512}_op_{Equality,Inequality}, X86Base.CompareScalar{Ordered,Unordered}*, X86Base/AVXTest{C,Z,NotZAndNotC}) and 8 ReturnsScalarT (Vector{128,256,512}.{GetElement,ToScalar}, X86Base[_X64].Extract).
• arm64: 4 ReturnsBoolean (Vector{64,128}_op_{Equality,Inequality}) and 5 ReturnsScalarT (Vector{64,128}.{GetElement,ToScalar}, AdvSimd.Extract).

Consumer refactors

assertionprop.cpp, rangecheck.cpp, and valuenum.cpp no longer enumerate intrinsic IDs in their GT_HWINTRINSIC / VNF_HWI_* switches. A flag check runs before the remaining switch and preserves prior semantics, e.g.:

if (HWIntrinsicInfo::ReturnsBoolean(id))
{
rangeType = TYP_INT;
range = Range(Limit(Limit::keConstant, 0), Limit(Limit::keConstant, 1));
break;
}
if (HWIntrinsicInfo::ReturnsScalarT(id) && varTypeIsSmall(simdBaseType))
{
rangeType = simdBaseType;
break;
}

For IsVNNeverNegative the scalar-T path keeps its base-type guard (only TYP_UBYTE/TYP_USHORT continue), matching the previous case-by-case behavior. The HW intrinsic checks in IsVNNeverNegative and rangecheck.cpp now use IsVNHWIntrinsicFunc, eliminating the manual VNF_HWI_FIRST/VNF_HWI_LAST range check, the explicit NamedIntrinsic cast, the separate GetVNHWIntrinsicSizeAndBaseType call. Both IsVNHWIntrinsicFunc blocks are correctly wrapped in #if defined(FEATURE_HW_INTRINSICS) / #endif guards.

SVE bool/scalar-T intrinsics are intentionally not tagged here — they were never in the original switches and remain covered by the existing TODO-SVE notes.

[tannergooding]

CC. @EgorBo, the downside of this is that we were out of flag space and so it extends it up to uint64_t.

I think there's likely cleanup possible and we can free up space, but I expect that's more involved and requires careful thought.

[Copilot]

Pull request overview

This PR centralizes knowledge about certain hardware intrinsics that return either a boolean (conceptually TYP_INT in range [0, 1]) or a scalar of the SIMD base type, by encoding that information as flags in the HW intrinsic table and switching consumers over to flag queries.

Changes:

• Widen HWIntrinsicFlag to uint64_t and add common flags for ReturnsBoolean and ReturnsScalarT, exposed via HWIntrinsicInfo.
• Tag relevant xarch/arm64 intrinsic table entries with the new return-shape flags.
• Refactor assertionprop.cpp, rangecheck.cpp, and valuenum.cpp to query HWIntrinsicInfo::{ReturnsBoolean,ReturnsScalarT} instead of maintaining long intrinsic-ID switches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/valuenum.cpp	Uses HW intrinsic return-shape flags to simplify IsVNNeverNegative handling for HWI VNs.
src/coreclr/jit/rangecheck.cpp	Uses HW intrinsic return-shape flags to derive ranges for HWI VNs without ID enumeration.
src/coreclr/jit/assertionprop.cpp	Uses HW intrinsic return-shape flags to derive symbolic integer ranges for GT_HWINTRINSIC.
src/coreclr/jit/hwintrinsiclistxarch.h	Tags xarch intrinsics (equality/test/compare, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsiclistarm64.h	Tags arm64 intrinsics (equality, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsic.h	Widens flag type and adds ReturnsBoolean / ReturnsScalarT APIs on HWIntrinsicInfo.

[Copilot]

Several hardware intrinsics are known to return bool or a scalar T, but consumers (assertionprop, rangecheck, valuenum) tracked them via long ID switches that had to be kept in sync. Replace those with flags on the intrinsic table queryable through HWIntrinsicInfo.

hwintrinsic.h

• Widen HWIntrinsicFlag to uint64_t (arm64 was out of bits in the 32-bit space).
• Add HW_Flag_ReturnsBoolean and HW_Flag_ReturnsScalarT as common flags.
• Add HWIntrinsicInfo::ReturnsBoolean / ReturnsScalarT static APIs, grouped after ReturnsPerElementMask.

hwintrinsiclist*.h

Tag the entries previously enumerated in the consumer switches (skipping HW_Flag_InvalidNodeId entries per the issue):

• xarch: 24 ReturnsBoolean (Vector{128,256,512}_op_{Equality,Inequality}, X86Base.CompareScalar{Ordered,Unordered}*, X86Base/AVXTest{C,Z,NotZAndNotC}) and 8 ReturnsScalarT (Vector{128,256,512}.{GetElement,ToScalar}, X86Base[_X64].Extract).
• arm64: 4 ReturnsBoolean (Vector{64,128}_op_{Equality,Inequality}) and 5 ReturnsScalarT (Vector{64,128}.{GetElement,ToScalar}, AdvSimd.Extract).

Consumer refactors

assertionprop.cpp, rangecheck.cpp, and valuenum.cpp no longer enumerate intrinsic IDs in their GT_HWINTRINSIC / VNF_HWI_* switches. A flag check runs before the remaining switch and preserves prior semantics, e.g.:

if (HWIntrinsicInfo::ReturnsBoolean(id))
{
rangeType = TYP_INT;
range = Range(Limit(Limit::keConstant, 0), Limit(Limit::keConstant, 1));
break;
}
if (HWIntrinsicInfo::ReturnsScalarT(id) && varTypeIsSmall(simdBaseType))
{
rangeType = simdBaseType;
break;
}

For IsVNNeverNegative the scalar-T path keeps its base-type guard (only TYP_UBYTE/TYP_USHORT continue), matching the previous case-by-case behavior. The HW intrinsic checks in IsVNNeverNegative and rangecheck.cpp now use IsVNHWIntrinsicFunc, eliminating the manual VNF_HWI_FIRST/VNF_HWI_LAST range check, the explicit NamedIntrinsic cast, the separate GetVNHWIntrinsicSizeAndBaseType call. Both IsVNHWIntrinsicFunc blocks are correctly wrapped in #if defined(FEATURE_HW_INTRINSICS) / #endif guards.

SVE bool/scalar-T intrinsics are intentionally not tagged here — they were never in the original switches and remain covered by the existing TODO-SVE notes.

[tannergooding]

CC. @EgorBo, the downside of this is that we were out of flag space and so it extends it up to uint64_t.

I think there's likely cleanup possible and we can free up space, but I expect that's more involved and requires careful thought.

[Copilot]

Pull request overview

This PR centralizes knowledge about certain hardware intrinsics that return either a boolean (conceptually TYP_INT in range [0, 1]) or a scalar of the SIMD base type, by encoding that information as flags in the HW intrinsic table and switching consumers over to flag queries.

Changes:

• Widen HWIntrinsicFlag to uint64_t and add common flags for ReturnsBoolean and ReturnsScalarT, exposed via HWIntrinsicInfo.
• Tag relevant xarch/arm64 intrinsic table entries with the new return-shape flags.
• Refactor assertionprop.cpp, rangecheck.cpp, and valuenum.cpp to query HWIntrinsicInfo::{ReturnsBoolean,ReturnsScalarT} instead of maintaining long intrinsic-ID switches.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/valuenum.cpp	Uses HW intrinsic return-shape flags to simplify IsVNNeverNegative handling for HWI VNs.
src/coreclr/jit/rangecheck.cpp	Uses HW intrinsic return-shape flags to derive ranges for HWI VNs without ID enumeration.
src/coreclr/jit/assertionprop.cpp	Uses HW intrinsic return-shape flags to derive symbolic integer ranges for GT_HWINTRINSIC.
src/coreclr/jit/hwintrinsiclistxarch.h	Tags xarch intrinsics (equality/test/compare, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsiclistarm64.h	Tags arm64 intrinsics (equality, GetElement/ToScalar/Extract) with new return-shape flags.
src/coreclr/jit/hwintrinsic.h	Widens flag type and adds ReturnsBoolean / ReturnsScalarT APIs on HWIntrinsicInfo.