[cDAC] Add GetApproxTypeHandle DacDbi API - #128921

Merged
rcj1 merged 19 commits into
mainfrom
copilot/implement-getapproxtypehandle
Jun 24, 2026
Merged

[cDAC] Add GetApproxTypeHandle DacDbi API#128921
rcj1 merged 19 commits into
mainfrom
copilot/implement-getapproxtypehandle

Conversation

CopilotAI commented Jun 2, 2026•
edited by rcj1
Loading

Copy link
Copy Markdown
Contributor

Add this API using a port of the native type-walk logic and a slight tweak to the RuntimeTypeSystem API that determines if something is a reference type.

CopilotAIand others added 2 commits June 2, 2026 15:30
@rcj1
Implement DacDbiImpl.GetApproxTypeHandle in cDAC
9e0b5cd
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
@rcj1
Add DacDbiApproxTypeHandle dump tests
2b5aa4f
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI requested review from Copilot and removed request for CopilotJune 2, 2026 22:45
@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@rcj1
Fix InstantiationApprox to look up open generic typeDef via vmAssembl…
b86eea6
…y+metadataToken
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI requested review from Copilot and removed request for CopilotJune 3, 2026 00:35
CopilotAI changed the title Add DacDbi approximate type handle dump testsAdd GetApproxTypeHandle dump testsJun 3, 2026
CopilotAI requested a review from rcj1June 3, 2026 00:35
CopilotAI review requested due to automatic review settings June 3, 2026 02:46
CopilotAI reviewed Jun 3, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds dump-based coverage for DacDbiImpl.GetApproxTypeHandle by mirroring the existing exact-type-handle dump tests: it enumerates heap objects reachable from GC handles in the ExactTypeHandle debuggee, constructs the flattened DebuggerIPCE_TypeArgData[] tree (a managed port of CordbType::GatherTypeData), round-trips that through GetApproxTypeHandle, and asserts the returned vmTypeHandle matches an independently canonicalized expected MethodTable. To support this, it also adds a managed TypeDataWalk implementation and refactors some type lookup logic into a helper.

Changes:

  • Add a new dump test suite DacDbiApproxTypeHandleDumpTests implementing the right-side “gather type data” flattening and expected-handle canonicalization.
  • Implement managed GetApproxTypeHandle support via a new TypeDataWalk port and supporting helper types.
  • Replace IsObjRef(TypeHandle) usage with a new IsCorElementTypeObjRef(CorElementType) helper across tests, the contract, and documentation.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MethodTableTests.csUpdates objref classification assertions to use IsCorElementTypeObjRef(GetInternalCorElementType(...)).
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csUpdates dump-based RTS “objref consistency” test to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiObjectDumpTests.csUpdates reference-type offset logic to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.csNew dump test covering round-trip behavior for GetApproxTypeHandle across reachable handle objects.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.csNew managed port of the native flattened-type-data walker used by GetApproxTypeHandle.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csAdds DebuggerIPCE_TypeArgData / TypeInfoList and tightens GetApproxTypeHandle signature to a typed pointer.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DbiHelpers.csNew helper for resolving typeDef/typeRef MethodTables from an assembly+token via loader lookup tables.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements managed GetApproxTypeHandle and switches some ref-type checks to IsCorElementTypeObjRef.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReplaces IsObjRef with IsCorElementTypeObjRef implementation used by the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csChanges the contract surface by removing IsObjRef(TypeHandle) and adding IsCorElementTypeObjRef(CorElementType).
docs/design/datacontracts/RuntimeTypeSystem.mdUpdates contract documentation to match the new helper.

Copilot's findings

  • Files reviewed: 11/11 changed files
  • Comments generated: 5

Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs Outdated
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated
@rcj1
Apply suggestions from code review
2fc978b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 3, 2026 03:50
CopilotAI reviewed Jun 3, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 11/11 changed files
  • Comments generated: 7

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs Outdated
Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs Outdated
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md Outdated
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
@rcj1
Apply suggestions from code review
28923d0
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 3, 2026 04:02
CopilotAI reviewed Jun 3, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 11/11 changed files
  • Comments generated: 4

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
rcj1and others added 2 commits June 2, 2026 23:05
@rcj1
Update RuntimeTypeSystem_1.cs
9c85a41
@rcj1
Potential fix for pull request finding
d1fb150
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI reviewed Jun 18, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 11/11 changed files
  • Comments generated: 1

Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI review requested due to automatic review settings June 18, 2026 22:35
CopilotAI reviewed Jun 18, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 11/11 changed files
  • Comments generated: 2

Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@build-analysisbuild-analysisBot mentioned this pull request Jun 19, 2026
Open
3 tasks
CopilotAI review requested due to automatic review settings June 19, 2026 00:05
CopilotAI reviewed Jun 19, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 10/10 changed files
  • Comments generated: 2

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1 marked this pull request as ready for review June 19, 2026 01:20
@rcj1
Potential fix for pull request finding
12d50b1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI reviewed Jun 19, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 10/10 changed files
  • Comments generated: 5

Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs Outdated
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1

rcj1 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

/ba-g known DAC failure

@rcj1
rcj1 merged commit b53e2e0 into mainJun 24, 2026
75 of 77 checks passed
@rcj1
rcj1 deleted the copilot/implement-getapproxtypehandle branch June 24, 2026 13:33
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jun 25, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview7 milestone Jun 25, 2026
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@rcj1
@eiriktsarpalis
[cDAC] Add GetApproxTypeHandle DacDbi API (#128921)
ee34f60
Add this API using a port of the native type-walk logic and a slight
tweak to the RuntimeTypeSystem API that determines if something is a
reference type.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: Rachel Jarvi <rachel.jarvi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot <copilot@github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 26, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1
@max-charlambmax-charlambAwaiting requested review from max-charlamb
@barosiakbarosiakAwaiting requested review from barosiak

Assignees

@rcj1rcj1

Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[cDAC] Add GetApproxTypeHandle DacDbi API - #128921
Merged
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Jun 24, 2026
Merged
[cDAC] Add GetApproxTypeHandle DacDbi API#128921
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Conversation
CopilotAI
commented
Jun 2, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
Add this API using a port of the native type-walk logic and a slight tweak to the RuntimeTypeSystem API that determines if something is a reference type.
CopilotAIand others
added 2 commits
June 2, 2026 15:30
@rcj1
Implement DacDbiImpl.GetApproxTypeHandle in cDAC
9e0b5cd
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
@rcj1
Add DacDbiApproxTypeHandle dump tests
2b5aa4f
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 2, 2026 22:45
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@rcj1
Fix InstantiationApprox to look up open generic typeDef via vmAssembl…
b86eea6
…y+metadataToken
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 3, 2026 00:35
CopilotAI
changed the title
Add DacDbi approximate type handle dump testsAdd GetApproxTypeHandle dump testsJun 3, 2026
CopilotAI
requested a review
from rcj1June 3, 2026 00:35
CopilotAI
review requested due to automatic review settings
June 3, 2026 02:46
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds dump-based coverage for DacDbiImpl.GetApproxTypeHandle by mirroring the existing exact-type-handle dump tests: it enumerates heap objects reachable from GC handles in the ExactTypeHandle debuggee, constructs the flattened DebuggerIPCE_TypeArgData[] tree (a managed port of CordbType::GatherTypeData), round-trips that through GetApproxTypeHandle, and asserts the returned vmTypeHandle matches an independently canonicalized expected MethodTable. To support this, it also adds a managed TypeDataWalk implementation and refactors some type lookup logic into a helper.
Changes:
  • Add a new dump test suite DacDbiApproxTypeHandleDumpTests implementing the right-side “gather type data” flattening and expected-handle canonicalization.
  • Implement managed GetApproxTypeHandle support via a new TypeDataWalk port and supporting helper types.
  • Replace IsObjRef(TypeHandle) usage with a new IsCorElementTypeObjRef(CorElementType) helper across tests, the contract, and documentation.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MethodTableTests.csUpdates objref classification assertions to use IsCorElementTypeObjRef(GetInternalCorElementType(...)).
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csUpdates dump-based RTS “objref consistency” test to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiObjectDumpTests.csUpdates reference-type offset logic to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.csNew dump test covering round-trip behavior for GetApproxTypeHandle across reachable handle objects.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.csNew managed port of the native flattened-type-data walker used by GetApproxTypeHandle.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csAdds DebuggerIPCE_TypeArgData / TypeInfoList and tightens GetApproxTypeHandle signature to a typed pointer.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DbiHelpers.csNew helper for resolving typeDef/typeRef MethodTables from an assembly+token via loader lookup tables.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements managed GetApproxTypeHandle and switches some ref-type checks to IsCorElementTypeObjRef.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReplaces IsObjRef with IsCorElementTypeObjRef implementation used by the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csChanges the contract surface by removing IsObjRef(TypeHandle) and adding IsCorElementTypeObjRef(CorElementType).
docs/design/datacontracts/RuntimeTypeSystem.mdUpdates contract documentation to match the new helper.
Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 5
Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

@rcj1
Apply suggestions from code review
2fc978b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 03:50
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 7
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Outdated

Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
@rcj1
Apply suggestions from code review
28923d0
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 04:02
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 4
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
rcj1and others
added 2 commits
June 2, 2026 23:05
@rcj1
Update RuntimeTypeSystem_1.cs
9c85a41
@rcj1
Potential fix for pull request finding
d1fb150
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 1
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
review requested due to automatic review settings
June 18, 2026 22:35
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 19, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
June 19, 2026 00:05
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
marked this pull request as ready for review
June 19, 2026 01:20
@rcj1
Potential fix for pull request finding
12d50b1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 5
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
commented
Jun 24, 2026

Copy link


Copy Markdown

Contributor
/ba-g known DAC failure
@rcj1
rcj1
merged commit b53e2e0
into
mainJun 24, 2026

75 of 77 checks passed

@rcj1
rcj1
deleted the

copilot/implement-getapproxtypehandle

branch
June 24, 2026 13:33
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 25, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 25, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@rcj1
@eiriktsarpalis
[cDAC] Add GetApproxTypeHandle DacDbi API (#128921)
ee34f60
Add this API using a port of the native type-walk logic and a slight
tweak to the RuntimeTypeSystem API that determines if something is a
reference type.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: Rachel Jarvi <rachel.jarvi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot <copilot@github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 26, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1
@max-charlambmax-charlambAwaiting requested review from max-charlamb
@barosiakbarosiakAwaiting requested review from barosiak

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Add GetApproxTypeHandle DacDbi API - #128921
Merged
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Jun 24, 2026
Merged
[cDAC] Add GetApproxTypeHandle DacDbi API#128921
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Conversation
CopilotAI
commented
Jun 2, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
Add this API using a port of the native type-walk logic and a slight tweak to the RuntimeTypeSystem API that determines if something is a reference type.
CopilotAIand others
added 2 commits
June 2, 2026 15:30
@rcj1
Implement DacDbiImpl.GetApproxTypeHandle in cDAC
9e0b5cd
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
@rcj1
Add DacDbiApproxTypeHandle dump tests
2b5aa4f
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 2, 2026 22:45
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@rcj1
Fix InstantiationApprox to look up open generic typeDef via vmAssembl…
b86eea6
…y+metadataToken
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 3, 2026 00:35
CopilotAI
changed the title
Add DacDbi approximate type handle dump testsAdd GetApproxTypeHandle dump testsJun 3, 2026
CopilotAI
requested a review
from rcj1June 3, 2026 00:35
CopilotAI
review requested due to automatic review settings
June 3, 2026 02:46
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds dump-based coverage for DacDbiImpl.GetApproxTypeHandle by mirroring the existing exact-type-handle dump tests: it enumerates heap objects reachable from GC handles in the ExactTypeHandle debuggee, constructs the flattened DebuggerIPCE_TypeArgData[] tree (a managed port of CordbType::GatherTypeData), round-trips that through GetApproxTypeHandle, and asserts the returned vmTypeHandle matches an independently canonicalized expected MethodTable. To support this, it also adds a managed TypeDataWalk implementation and refactors some type lookup logic into a helper.
Changes:
  • Add a new dump test suite DacDbiApproxTypeHandleDumpTests implementing the right-side “gather type data” flattening and expected-handle canonicalization.
  • Implement managed GetApproxTypeHandle support via a new TypeDataWalk port and supporting helper types.
  • Replace IsObjRef(TypeHandle) usage with a new IsCorElementTypeObjRef(CorElementType) helper across tests, the contract, and documentation.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MethodTableTests.csUpdates objref classification assertions to use IsCorElementTypeObjRef(GetInternalCorElementType(...)).
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csUpdates dump-based RTS “objref consistency” test to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiObjectDumpTests.csUpdates reference-type offset logic to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.csNew dump test covering round-trip behavior for GetApproxTypeHandle across reachable handle objects.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.csNew managed port of the native flattened-type-data walker used by GetApproxTypeHandle.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csAdds DebuggerIPCE_TypeArgData / TypeInfoList and tightens GetApproxTypeHandle signature to a typed pointer.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DbiHelpers.csNew helper for resolving typeDef/typeRef MethodTables from an assembly+token via loader lookup tables.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements managed GetApproxTypeHandle and switches some ref-type checks to IsCorElementTypeObjRef.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReplaces IsObjRef with IsCorElementTypeObjRef implementation used by the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csChanges the contract surface by removing IsObjRef(TypeHandle) and adding IsCorElementTypeObjRef(CorElementType).
docs/design/datacontracts/RuntimeTypeSystem.mdUpdates contract documentation to match the new helper.
Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 5
Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

@rcj1
Apply suggestions from code review
2fc978b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 03:50
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 7
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Outdated

Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
@rcj1
Apply suggestions from code review
28923d0
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 04:02
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 4
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
rcj1and others
added 2 commits
June 2, 2026 23:05
@rcj1
Update RuntimeTypeSystem_1.cs
9c85a41
@rcj1
Potential fix for pull request finding
d1fb150
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 1
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
review requested due to automatic review settings
June 18, 2026 22:35
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 19, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
June 19, 2026 00:05
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
marked this pull request as ready for review
June 19, 2026 01:20
@rcj1
Potential fix for pull request finding
12d50b1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 5
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
commented
Jun 24, 2026

Copy link


Copy Markdown

Contributor
/ba-g known DAC failure
@rcj1
rcj1
merged commit b53e2e0
into
mainJun 24, 2026

75 of 77 checks passed

@rcj1
rcj1
deleted the

copilot/implement-getapproxtypehandle

branch
June 24, 2026 13:33
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 25, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 25, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@rcj1
@eiriktsarpalis
[cDAC] Add GetApproxTypeHandle DacDbi API (#128921)
ee34f60
Add this API using a port of the native type-walk logic and a slight
tweak to the RuntimeTypeSystem API that determines if something is a
reference type.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: Rachel Jarvi <rachel.jarvi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot <copilot@github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 26, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1
@max-charlambmax-charlambAwaiting requested review from max-charlamb
@barosiakbarosiakAwaiting requested review from barosiak

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Add GetApproxTypeHandle DacDbi API - #128921
Merged
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Jun 24, 2026
Merged
[cDAC] Add GetApproxTypeHandle DacDbi API#128921
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Conversation
CopilotAI
commented
Jun 2, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
Add this API using a port of the native type-walk logic and a slight tweak to the RuntimeTypeSystem API that determines if something is a reference type.
CopilotAIand others
added 2 commits
June 2, 2026 15:30
@rcj1
Implement DacDbiImpl.GetApproxTypeHandle in cDAC
9e0b5cd
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
@rcj1
Add DacDbiApproxTypeHandle dump tests
2b5aa4f
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 2, 2026 22:45
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@rcj1
Fix InstantiationApprox to look up open generic typeDef via vmAssembl…
b86eea6
…y+metadataToken
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 3, 2026 00:35
CopilotAI
changed the title
Add DacDbi approximate type handle dump testsAdd GetApproxTypeHandle dump testsJun 3, 2026
CopilotAI
requested a review
from rcj1June 3, 2026 00:35
CopilotAI
review requested due to automatic review settings
June 3, 2026 02:46
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds dump-based coverage for DacDbiImpl.GetApproxTypeHandle by mirroring the existing exact-type-handle dump tests: it enumerates heap objects reachable from GC handles in the ExactTypeHandle debuggee, constructs the flattened DebuggerIPCE_TypeArgData[] tree (a managed port of CordbType::GatherTypeData), round-trips that through GetApproxTypeHandle, and asserts the returned vmTypeHandle matches an independently canonicalized expected MethodTable. To support this, it also adds a managed TypeDataWalk implementation and refactors some type lookup logic into a helper.
Changes:
  • Add a new dump test suite DacDbiApproxTypeHandleDumpTests implementing the right-side “gather type data” flattening and expected-handle canonicalization.
  • Implement managed GetApproxTypeHandle support via a new TypeDataWalk port and supporting helper types.
  • Replace IsObjRef(TypeHandle) usage with a new IsCorElementTypeObjRef(CorElementType) helper across tests, the contract, and documentation.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MethodTableTests.csUpdates objref classification assertions to use IsCorElementTypeObjRef(GetInternalCorElementType(...)).
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csUpdates dump-based RTS “objref consistency” test to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiObjectDumpTests.csUpdates reference-type offset logic to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.csNew dump test covering round-trip behavior for GetApproxTypeHandle across reachable handle objects.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.csNew managed port of the native flattened-type-data walker used by GetApproxTypeHandle.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csAdds DebuggerIPCE_TypeArgData / TypeInfoList and tightens GetApproxTypeHandle signature to a typed pointer.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DbiHelpers.csNew helper for resolving typeDef/typeRef MethodTables from an assembly+token via loader lookup tables.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements managed GetApproxTypeHandle and switches some ref-type checks to IsCorElementTypeObjRef.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReplaces IsObjRef with IsCorElementTypeObjRef implementation used by the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csChanges the contract surface by removing IsObjRef(TypeHandle) and adding IsCorElementTypeObjRef(CorElementType).
docs/design/datacontracts/RuntimeTypeSystem.mdUpdates contract documentation to match the new helper.
Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 5
Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

@rcj1
Apply suggestions from code review
2fc978b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 03:50
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 7
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Outdated

Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
@rcj1
Apply suggestions from code review
28923d0
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 04:02
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 4
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
rcj1and others
added 2 commits
June 2, 2026 23:05
@rcj1
Update RuntimeTypeSystem_1.cs
9c85a41
@rcj1
Potential fix for pull request finding
d1fb150
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 1
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
review requested due to automatic review settings
June 18, 2026 22:35
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 19, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
June 19, 2026 00:05
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
marked this pull request as ready for review
June 19, 2026 01:20
@rcj1
Potential fix for pull request finding
12d50b1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 5
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
commented
Jun 24, 2026

Copy link


Copy Markdown

Contributor
/ba-g known DAC failure
@rcj1
rcj1
merged commit b53e2e0
into
mainJun 24, 2026

75 of 77 checks passed

@rcj1
rcj1
deleted the

copilot/implement-getapproxtypehandle

branch
June 24, 2026 13:33
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 25, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 25, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@rcj1
@eiriktsarpalis
[cDAC] Add GetApproxTypeHandle DacDbi API (#128921)
ee34f60
Add this API using a port of the native type-walk logic and a slight
tweak to the RuntimeTypeSystem API that determines if something is a
reference type.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: Rachel Jarvi <rachel.jarvi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot <copilot@github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 26, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1
@max-charlambmax-charlambAwaiting requested review from max-charlamb
@barosiakbarosiakAwaiting requested review from barosiak

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[cDAC] Add GetApproxTypeHandle DacDbi API - #128921
Merged
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Jun 24, 2026
Merged
[cDAC] Add GetApproxTypeHandle DacDbi API#128921
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Conversation
CopilotAI
commented
Jun 2, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
Add this API using a port of the native type-walk logic and a slight tweak to the RuntimeTypeSystem API that determines if something is a reference type.
CopilotAIand others
added 2 commits
June 2, 2026 15:30
@rcj1
Implement DacDbiImpl.GetApproxTypeHandle in cDAC
9e0b5cd
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
@rcj1
Add DacDbiApproxTypeHandle dump tests
2b5aa4f
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 2, 2026 22:45
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@rcj1
Fix InstantiationApprox to look up open generic typeDef via vmAssembl…
b86eea6
…y+metadataToken
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 3, 2026 00:35
CopilotAI
changed the title
Add DacDbi approximate type handle dump testsAdd GetApproxTypeHandle dump testsJun 3, 2026
CopilotAI
requested a review
from rcj1June 3, 2026 00:35
CopilotAI
review requested due to automatic review settings
June 3, 2026 02:46
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds dump-based coverage for DacDbiImpl.GetApproxTypeHandle by mirroring the existing exact-type-handle dump tests: it enumerates heap objects reachable from GC handles in the ExactTypeHandle debuggee, constructs the flattened DebuggerIPCE_TypeArgData[] tree (a managed port of CordbType::GatherTypeData), round-trips that through GetApproxTypeHandle, and asserts the returned vmTypeHandle matches an independently canonicalized expected MethodTable. To support this, it also adds a managed TypeDataWalk implementation and refactors some type lookup logic into a helper.
Changes:
  • Add a new dump test suite DacDbiApproxTypeHandleDumpTests implementing the right-side “gather type data” flattening and expected-handle canonicalization.
  • Implement managed GetApproxTypeHandle support via a new TypeDataWalk port and supporting helper types.
  • Replace IsObjRef(TypeHandle) usage with a new IsCorElementTypeObjRef(CorElementType) helper across tests, the contract, and documentation.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MethodTableTests.csUpdates objref classification assertions to use IsCorElementTypeObjRef(GetInternalCorElementType(...)).
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csUpdates dump-based RTS “objref consistency” test to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiObjectDumpTests.csUpdates reference-type offset logic to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.csNew dump test covering round-trip behavior for GetApproxTypeHandle across reachable handle objects.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.csNew managed port of the native flattened-type-data walker used by GetApproxTypeHandle.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csAdds DebuggerIPCE_TypeArgData / TypeInfoList and tightens GetApproxTypeHandle signature to a typed pointer.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DbiHelpers.csNew helper for resolving typeDef/typeRef MethodTables from an assembly+token via loader lookup tables.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements managed GetApproxTypeHandle and switches some ref-type checks to IsCorElementTypeObjRef.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReplaces IsObjRef with IsCorElementTypeObjRef implementation used by the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csChanges the contract surface by removing IsObjRef(TypeHandle) and adding IsCorElementTypeObjRef(CorElementType).
docs/design/datacontracts/RuntimeTypeSystem.mdUpdates contract documentation to match the new helper.
Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 5
Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

@rcj1
Apply suggestions from code review
2fc978b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 03:50
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 7
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Outdated

Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
@rcj1
Apply suggestions from code review
28923d0
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 04:02
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 4
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
rcj1and others
added 2 commits
June 2, 2026 23:05
@rcj1
Update RuntimeTypeSystem_1.cs
9c85a41
@rcj1
Potential fix for pull request finding
d1fb150
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 1
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
review requested due to automatic review settings
June 18, 2026 22:35
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 19, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
June 19, 2026 00:05
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
marked this pull request as ready for review
June 19, 2026 01:20
@rcj1
Potential fix for pull request finding
12d50b1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 5
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
commented
Jun 24, 2026

Copy link


Copy Markdown

Contributor
/ba-g known DAC failure
@rcj1
rcj1
merged commit b53e2e0
into
mainJun 24, 2026

75 of 77 checks passed

@rcj1
rcj1
deleted the

copilot/implement-getapproxtypehandle

branch
June 24, 2026 13:33
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 25, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 25, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@rcj1
@eiriktsarpalis
[cDAC] Add GetApproxTypeHandle DacDbi API (#128921)
ee34f60
Add this API using a port of the native type-walk logic and a slight
tweak to the RuntimeTypeSystem API that determines if something is a
reference type.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: Rachel Jarvi <rachel.jarvi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot <copilot@github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 26, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1
@max-charlambmax-charlambAwaiting requested review from max-charlamb
@barosiakbarosiakAwaiting requested review from barosiak

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Add GetApproxTypeHandle DacDbi API - #128921
Merged
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Jun 24, 2026
Merged
[cDAC] Add GetApproxTypeHandle DacDbi API#128921
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Conversation
CopilotAI
commented
Jun 2, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
Add this API using a port of the native type-walk logic and a slight tweak to the RuntimeTypeSystem API that determines if something is a reference type.
CopilotAIand others
added 2 commits
June 2, 2026 15:30
@rcj1
Implement DacDbiImpl.GetApproxTypeHandle in cDAC
9e0b5cd
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
@rcj1
Add DacDbiApproxTypeHandle dump tests
2b5aa4f
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 2, 2026 22:45
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@rcj1
Fix InstantiationApprox to look up open generic typeDef via vmAssembl…
b86eea6
…y+metadataToken
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 3, 2026 00:35
CopilotAI
changed the title
Add DacDbi approximate type handle dump testsAdd GetApproxTypeHandle dump testsJun 3, 2026
CopilotAI
requested a review
from rcj1June 3, 2026 00:35
CopilotAI
review requested due to automatic review settings
June 3, 2026 02:46
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds dump-based coverage for DacDbiImpl.GetApproxTypeHandle by mirroring the existing exact-type-handle dump tests: it enumerates heap objects reachable from GC handles in the ExactTypeHandle debuggee, constructs the flattened DebuggerIPCE_TypeArgData[] tree (a managed port of CordbType::GatherTypeData), round-trips that through GetApproxTypeHandle, and asserts the returned vmTypeHandle matches an independently canonicalized expected MethodTable. To support this, it also adds a managed TypeDataWalk implementation and refactors some type lookup logic into a helper.
Changes:
  • Add a new dump test suite DacDbiApproxTypeHandleDumpTests implementing the right-side “gather type data” flattening and expected-handle canonicalization.
  • Implement managed GetApproxTypeHandle support via a new TypeDataWalk port and supporting helper types.
  • Replace IsObjRef(TypeHandle) usage with a new IsCorElementTypeObjRef(CorElementType) helper across tests, the contract, and documentation.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MethodTableTests.csUpdates objref classification assertions to use IsCorElementTypeObjRef(GetInternalCorElementType(...)).
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csUpdates dump-based RTS “objref consistency” test to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiObjectDumpTests.csUpdates reference-type offset logic to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.csNew dump test covering round-trip behavior for GetApproxTypeHandle across reachable handle objects.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.csNew managed port of the native flattened-type-data walker used by GetApproxTypeHandle.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csAdds DebuggerIPCE_TypeArgData / TypeInfoList and tightens GetApproxTypeHandle signature to a typed pointer.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DbiHelpers.csNew helper for resolving typeDef/typeRef MethodTables from an assembly+token via loader lookup tables.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements managed GetApproxTypeHandle and switches some ref-type checks to IsCorElementTypeObjRef.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReplaces IsObjRef with IsCorElementTypeObjRef implementation used by the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csChanges the contract surface by removing IsObjRef(TypeHandle) and adding IsCorElementTypeObjRef(CorElementType).
docs/design/datacontracts/RuntimeTypeSystem.mdUpdates contract documentation to match the new helper.
Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 5
Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

@rcj1
Apply suggestions from code review
2fc978b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 03:50
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 7
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Outdated

Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
@rcj1
Apply suggestions from code review
28923d0
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 04:02
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 4
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
rcj1and others
added 2 commits
June 2, 2026 23:05
@rcj1
Update RuntimeTypeSystem_1.cs
9c85a41
@rcj1
Potential fix for pull request finding
d1fb150
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 1
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
review requested due to automatic review settings
June 18, 2026 22:35
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 19, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
June 19, 2026 00:05
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
marked this pull request as ready for review
June 19, 2026 01:20
@rcj1
Potential fix for pull request finding
12d50b1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 5
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
commented
Jun 24, 2026

Copy link


Copy Markdown

Contributor
/ba-g known DAC failure
@rcj1
rcj1
merged commit b53e2e0
into
mainJun 24, 2026

75 of 77 checks passed

@rcj1
rcj1
deleted the

copilot/implement-getapproxtypehandle

branch
June 24, 2026 13:33
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 25, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 25, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@rcj1
@eiriktsarpalis
[cDAC] Add GetApproxTypeHandle DacDbi API (#128921)
ee34f60
Add this API using a port of the native type-walk logic and a slight
tweak to the RuntimeTypeSystem API that determines if something is a
reference type.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: Rachel Jarvi <rachel.jarvi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot <copilot@github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 26, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1
@max-charlambmax-charlambAwaiting requested review from max-charlamb
@barosiakbarosiakAwaiting requested review from barosiak

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[cDAC] Add GetApproxTypeHandle DacDbi API - #128921
Merged
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Jun 24, 2026
Merged
[cDAC] Add GetApproxTypeHandle DacDbi API#128921
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Conversation
CopilotAI
commented
Jun 2, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
Add this API using a port of the native type-walk logic and a slight tweak to the RuntimeTypeSystem API that determines if something is a reference type.
CopilotAIand others
added 2 commits
June 2, 2026 15:30
@rcj1
Implement DacDbiImpl.GetApproxTypeHandle in cDAC
9e0b5cd
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
@rcj1
Add DacDbiApproxTypeHandle dump tests
2b5aa4f
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 2, 2026 22:45
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@rcj1
Fix InstantiationApprox to look up open generic typeDef via vmAssembl…
b86eea6
…y+metadataToken
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 3, 2026 00:35
CopilotAI
changed the title
Add DacDbi approximate type handle dump testsAdd GetApproxTypeHandle dump testsJun 3, 2026
CopilotAI
requested a review
from rcj1June 3, 2026 00:35
CopilotAI
review requested due to automatic review settings
June 3, 2026 02:46
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds dump-based coverage for DacDbiImpl.GetApproxTypeHandle by mirroring the existing exact-type-handle dump tests: it enumerates heap objects reachable from GC handles in the ExactTypeHandle debuggee, constructs the flattened DebuggerIPCE_TypeArgData[] tree (a managed port of CordbType::GatherTypeData), round-trips that through GetApproxTypeHandle, and asserts the returned vmTypeHandle matches an independently canonicalized expected MethodTable. To support this, it also adds a managed TypeDataWalk implementation and refactors some type lookup logic into a helper.
Changes:
  • Add a new dump test suite DacDbiApproxTypeHandleDumpTests implementing the right-side “gather type data” flattening and expected-handle canonicalization.
  • Implement managed GetApproxTypeHandle support via a new TypeDataWalk port and supporting helper types.
  • Replace IsObjRef(TypeHandle) usage with a new IsCorElementTypeObjRef(CorElementType) helper across tests, the contract, and documentation.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MethodTableTests.csUpdates objref classification assertions to use IsCorElementTypeObjRef(GetInternalCorElementType(...)).
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csUpdates dump-based RTS “objref consistency” test to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiObjectDumpTests.csUpdates reference-type offset logic to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.csNew dump test covering round-trip behavior for GetApproxTypeHandle across reachable handle objects.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.csNew managed port of the native flattened-type-data walker used by GetApproxTypeHandle.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csAdds DebuggerIPCE_TypeArgData / TypeInfoList and tightens GetApproxTypeHandle signature to a typed pointer.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DbiHelpers.csNew helper for resolving typeDef/typeRef MethodTables from an assembly+token via loader lookup tables.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements managed GetApproxTypeHandle and switches some ref-type checks to IsCorElementTypeObjRef.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReplaces IsObjRef with IsCorElementTypeObjRef implementation used by the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csChanges the contract surface by removing IsObjRef(TypeHandle) and adding IsCorElementTypeObjRef(CorElementType).
docs/design/datacontracts/RuntimeTypeSystem.mdUpdates contract documentation to match the new helper.
Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 5
Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

@rcj1
Apply suggestions from code review
2fc978b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 03:50
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 7
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Outdated

Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
@rcj1
Apply suggestions from code review
28923d0
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 04:02
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 4
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
rcj1and others
added 2 commits
June 2, 2026 23:05
@rcj1
Update RuntimeTypeSystem_1.cs
9c85a41
@rcj1
Potential fix for pull request finding
d1fb150
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 1
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
review requested due to automatic review settings
June 18, 2026 22:35
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 19, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
June 19, 2026 00:05
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
marked this pull request as ready for review
June 19, 2026 01:20
@rcj1
Potential fix for pull request finding
12d50b1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 5
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
commented
Jun 24, 2026

Copy link


Copy Markdown

Contributor
/ba-g known DAC failure
@rcj1
rcj1
merged commit b53e2e0
into
mainJun 24, 2026

75 of 77 checks passed

@rcj1
rcj1
deleted the

copilot/implement-getapproxtypehandle

branch
June 24, 2026 13:33
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 25, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 25, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@rcj1
@eiriktsarpalis
[cDAC] Add GetApproxTypeHandle DacDbi API (#128921)
ee34f60
Add this API using a port of the native type-walk logic and a slight
tweak to the RuntimeTypeSystem API that determines if something is a
reference type.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: Rachel Jarvi <rachel.jarvi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot <copilot@github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 26, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1
@max-charlambmax-charlambAwaiting requested review from max-charlamb
@barosiakbarosiakAwaiting requested review from barosiak

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[cDAC] Add GetApproxTypeHandle DacDbi API - #128921
Merged
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Jun 24, 2026
Merged
[cDAC] Add GetApproxTypeHandle DacDbi API#128921
rcj1 merged 19 commits into
mainfrom 
copilot/implement-getapproxtypehandle
Conversation
CopilotAI
commented
Jun 2, 2026•

edited by rcj1

Loading

Copy link


Copy Markdown

Contributor
Add this API using a port of the native type-walk logic and a slight tweak to the RuntimeTypeSystem API that determines if something is a reference type.
CopilotAIand others
added 2 commits
June 2, 2026 15:30
@rcj1
Implement DacDbiImpl.GetApproxTypeHandle in cDAC
9e0b5cd
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
@rcj1
Add DacDbiApproxTypeHandle dump tests
2b5aa4f
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 2, 2026 22:45
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
@rcj1
Fix InstantiationApprox to look up open generic typeDef via vmAssembl…
b86eea6
…y+metadataToken
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
CopilotAI
requested review from
Copilot
and removed request for
CopilotJune 3, 2026 00:35
CopilotAI
changed the title
Add DacDbi approximate type handle dump testsAdd GetApproxTypeHandle dump testsJun 3, 2026
CopilotAI
requested a review
from rcj1June 3, 2026 00:35
CopilotAI
review requested due to automatic review settings
June 3, 2026 02:46
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds dump-based coverage for DacDbiImpl.GetApproxTypeHandle by mirroring the existing exact-type-handle dump tests: it enumerates heap objects reachable from GC handles in the ExactTypeHandle debuggee, constructs the flattened DebuggerIPCE_TypeArgData[] tree (a managed port of CordbType::GatherTypeData), round-trips that through GetApproxTypeHandle, and asserts the returned vmTypeHandle matches an independently canonicalized expected MethodTable. To support this, it also adds a managed TypeDataWalk implementation and refactors some type lookup logic into a helper.
Changes:
  • Add a new dump test suite DacDbiApproxTypeHandleDumpTests implementing the right-side “gather type data” flattening and expected-handle canonicalization.
  • Implement managed GetApproxTypeHandle support via a new TypeDataWalk port and supporting helper types.
  • Replace IsObjRef(TypeHandle) usage with a new IsCorElementTypeObjRef(CorElementType) helper across tests, the contract, and documentation.
Show a summary per file
FileDescription
src/native/managed/cdac/tests/MethodTableTests.csUpdates objref classification assertions to use IsCorElementTypeObjRef(GetInternalCorElementType(...)).
src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.csUpdates dump-based RTS “objref consistency” test to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiObjectDumpTests.csUpdates reference-type offset logic to use the new helper.
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.csNew dump test covering round-trip behavior for GetApproxTypeHandle across reachable handle objects.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.csNew managed port of the native flattened-type-data walker used by GetApproxTypeHandle.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.csAdds DebuggerIPCE_TypeArgData / TypeInfoList and tightens GetApproxTypeHandle signature to a typed pointer.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DbiHelpers.csNew helper for resolving typeDef/typeRef MethodTables from an assembly+token via loader lookup tables.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.csImplements managed GetApproxTypeHandle and switches some ref-type checks to IsCorElementTypeObjRef.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.csReplaces IsObjRef with IsCorElementTypeObjRef implementation used by the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.csChanges the contract surface by removing IsObjRef(TypeHandle) and adding IsCorElementTypeObjRef(CorElementType).
docs/design/datacontracts/RuntimeTypeSystem.mdUpdates contract documentation to match the new helper.
Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 5
Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

@rcj1
Apply suggestions from code review
2fc978b
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 03:50
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 7
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Outdated

Comment thread...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs
Outdated

Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Outdated

Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
@rcj1
Apply suggestions from code review
28923d0
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
June 3, 2026 04:02
CopilotAI
reviewed
Jun 3, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 4
Comment threaddocs/design/datacontracts/RuntimeTypeSystem.md
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs
rcj1and others
added 2 commits
June 2, 2026 23:05
@rcj1
Update RuntimeTypeSystem_1.cs
9c85a41
@rcj1
Potential fix for pull request finding
d1fb150
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 1
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
CopilotAI
review requested due to automatic review settings
June 18, 2026 22:35
CopilotAI
reviewed
Jun 18, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 11/11 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 19, 2026

Open

3 tasks
CopilotAI
review requested due to automatic review settings
June 19, 2026 00:05
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 2
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
marked this pull request as ready for review
June 19, 2026 01:20
@rcj1
Potential fix for pull request finding
12d50b1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI
reviewed
Jun 19, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings
  • Files reviewed: 10/10 changed files
  • Comments generated: 5
Comment threadsrc/native/managed/cdac/tests/UnitTests/MethodTableTests.cs
Comment threadsrc/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiApproxTypeHandleDumpTests.cs
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs
Outdated

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/TypeDataWalk.cs
Comment thread...d/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs
@rcj1
rcj1
commented
Jun 24, 2026

Copy link


Copy Markdown

Contributor
/ba-g known DAC failure
@rcj1
rcj1
merged commit b53e2e0
into
mainJun 24, 2026

75 of 77 checks passed

@rcj1
rcj1
deleted the

copilot/implement-getapproxtypehandle

branch
June 24, 2026 13:33
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 25, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 25, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@rcj1
@eiriktsarpalis
[cDAC] Add GetApproxTypeHandle DacDbi API (#128921)
ee34f60
Add this API using a port of the native type-walk logic and a slight
tweak to the RuntimeTypeSystem API that determines if something is a
reference type.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: Rachel Jarvi <rachel.jarvi@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot <copilot@github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 26, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1Awaiting requested review from rcj1
@max-charlambmax-charlambAwaiting requested review from max-charlamb
@barosiakbarosiakAwaiting requested review from barosiak

Assignees

@rcj1rcj1
Copilot code reviewCopilot

Labels

area-Diagnostics-coreclr

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@rcj1@noahfalk