Make Condition to not use ConditionalWeakTable by VSadov · Pull Request #129083 · dotnet/runtime

VSadov · 2026-06-06T22:04:22Z

Main motivation is that ManualResetEventSlim uses Monitor.Wait to implement Wait that is:

cancellable
interruptible (in Thread.Interrupt sense) and
aware of synchronization context

Monitor.Wait is a good fit to implement such pattern and should generally perform well enough.

ManualResetEventSlim in turn is used in Task.Wait and some scenarios can wait on Tasks relatively frequently.

In such scenarios using ConditionalWaitTable for Lock->Condition association may have two inconveniences:

it may result in quite a few dependent handles being alive and that can have impact on GC.
In particular because dependent handles currently do not age and need to be revisited in every Gen0, even if both objects referred from the handle may be Gen2 objects.
(we should probably address Consider aging dependent handles the same way as the other kinds of handles. #79062, regardless of this PR)
Allocating an entry in ConditionalWaitTable acquires table-wide lock and on large enough core count may contend.

It seems there is a relatively simple way to arrange Lock->Condition link without involving ConditionalWaitTable, thus why not.

The change also enables Wait/Pulse/PulseAll functionality on Lock, but only internally.
It can be exposed as a public API, but it would be a separate discussion.

Copilot

Pull request overview

This PR refactors how Monitor.Wait/Pulse are implemented by removing the ConditionalWeakTable<object, Condition> mapping and instead associating a Condition directly with the managed Lock used by a sync block. It also updates diagnostics code (DAC/DBI) to discover monitor waiters via the Lock rather than via Monitor’s static table, and updates ManualResetEventSlim to use Lock for its wait/pulse coordination.

Changes:

Replace Monitor’s object→Condition table with Lock-based Wait/Pulse/PulseAll helpers.
Update Lock to store either an AutoResetEvent or a Condition in a single field and lazily create the Condition when needed.
Update ManualResetEventSlim to use Lock and revise waiter-count/state handling; update DAC monitor-wait enumeration accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/libraries/System.Private.CoreLib/src/System/Threading/Monitor.cs	Routes `Wait/Pulse/PulseAll` through the sync-block `Lock` instead of a global `ConditionalWeakTable`.
src/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs	Switches internal wait/pulse lock to `Lock` and rewrites signaled/waiter state manipulation.
src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs	Introduces `_waitEventOrCondition` union field and adds internal `Wait/Pulse/PulseAll` via `Condition`.
src/libraries/System.Private.CoreLib/src/System/Threading/Condition.cs	Refactors waiter bookkeeping and signaling strategy; adds storage for a `Lock`’s wait event.
src/coreclr/vm/corelib.h	Updates binder field list to remove `Monitor.s_conditionTable` and add `Lock._waitEventOrCondition`.
src/coreclr/debug/daccess/dacdbiimpl.cpp	Changes monitor-wait enumeration to locate `Condition` via the sync-block `Lock` field.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

jkotas · 2026-06-07T05:37:26Z

Is there a micro-benchmark that demonstrates the improvement?

VSadov · 2026-06-10T00:50:53Z

@MihuBot benchmark System.Threading

MihuBot · 2026-06-10T01:34:28Z

System.Threading.Tests.Perf_Volatile

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-NRQIIJ : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-NGSIDY : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False PowerPlanMode= IterationTime=250ms
MaxIterationCount=20 MinIterationCount=15 WarmupCount=1
Min=1.124 ns

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
Write_double	Main	1.124 ns	0.0003 ns	1.00	-	NA
Write_double	PR	1.124 ns	0.0002 ns	1.00	-	NA

Read_double	Main	1.126 ns	0.0039 ns	1.00	-	NA
Read_double	PR	1.125 ns	0.0003 ns	1.00	-	NA

System.Threading.Tests.Perf_Timer

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-NRQIIJ : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-NGSIDY : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False PowerPlanMode= IterationTime=250ms
MaxIterationCount=20 MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
ShortScheduleAndDispose	Main	91.70 ns	0.977 ns	1.00	120 B	1.00
ShortScheduleAndDispose	PR	82.42 ns	0.308 ns	0.90	120 B	1.00

LongScheduleAndDispose	Main	82.53 ns	0.976 ns	1.00	120 B	1.00
LongScheduleAndDispose	PR	83.98 ns	0.829 ns	1.02	120 B	1.00

ScheduleManyThenDisposeMany	Main	243,251,019.53 ns	2,833,356.669 ns	1.00	144001288 B	1.00
ScheduleManyThenDisposeMany	PR	242,188,481.40 ns	2,484,566.988 ns	1.00	144001288 B	1.00

ShortScheduleAndDisposeWithFiringTimers	Main	97.65 ns	3.355 ns	1.00	144 B	1.00
ShortScheduleAndDisposeWithFiringTimers	PR	92.94 ns	2.533 ns	0.95	144 B	1.00

SynchronousContention	Main	1,531,794,458.79 ns	31,596,773.598 ns	1.00	1152000776 B	1.00
SynchronousContention	PR	1,323,815,852.74 ns	48,389,218.139 ns	0.86	1152000760 B	1.00

AsynchronousContention	Main	1,143,753,328.80 ns	13,338,983.380 ns	1.00	1344002248 B	1.00
AsynchronousContention	PR	1,375,212,284.55 ns	33,176,643.831 ns	1.20	1344002232 B	1.00

System.Threading.Tests.Perf_ThreadStatic

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
GetThreadStatic	Main	2.489 ns	0.0008 ns	1.00	-	NA
GetThreadStatic	PR	2.490 ns	0.0019 ns	1.00	-	NA

SetThreadStatic	Main	4.397 ns	0.0026 ns	1.00	-	NA
SetThreadStatic	PR	4.400 ns	0.0019 ns	1.00	-	NA

System.Threading.Tests.Perf_ThreadPool

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1 StdDev=0.0297 s
Gen0=38000.0000

Method	Toolchain	WorkItemsPerCore	Mean	Error	Ratio	Allocated	Alloc Ratio
QueueUserWorkItem_WaitCallback_Throughput	Main	20000000	2.119 s	0.0318 s	1.00	610.35 MB	1.00
QueueUserWorkItem_WaitCallback_Throughput	PR	20000000	2.115 s	0.0317 s	1.00	610.35 MB	1.00

System.Threading.Tests.Perf_Thread

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-NRQIIJ : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-NGSIDY : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False PowerPlanMode= IterationTime=250ms
MaxIterationCount=20 MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
CurrentThread	Main	2.760 ns	0.0010 ns	1.00	-	NA
CurrentThread	PR	2.761 ns	0.0011 ns	1.00	-	NA

GetCurrentProcessorId	Main	3.036 ns	0.0029 ns	1.00	-	NA
GetCurrentProcessorId	PR	3.060 ns	0.0297 ns	1.01	-	NA

System.Threading.Tests.Perf_SpinLock

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
EnterExit	Main	4.409 ns	0.0026 ns	1.00	-	NA
EnterExit	PR	4.413 ns	0.0044 ns	1.00	-	NA

TryEnterExit	Main	4.411 ns	0.0045 ns	1.00	-	NA
TryEnterExit	PR	4.409 ns	0.0017 ns	1.00	-	NA

TryEnter_Fail	Main	1.910 ns	0.0011 ns	1.00	-	NA
TryEnter_Fail	PR	1.913 ns	0.0042 ns	1.00	-	NA

System.Threading.Tests.Perf_SemaphoreSlim

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
ReleaseWait	Main	21.51 ns	0.036 ns	1.00	-	NA
ReleaseWait	PR	21.54 ns	0.157 ns	1.00	-	NA

ReleaseWaitAsync	Main	21.04 ns	0.027 ns	1.00	-	NA
ReleaseWaitAsync	PR	20.85 ns	0.055 ns	0.99	-	NA

ReleaseWaitAsync_WithCancellationToken	Main	18,771.65 ns	1,508.351 ns	1.00	584 B	1.00
ReleaseWaitAsync_WithCancellationToken	PR	19,041.39 ns	1,888.110 ns	1.02	584 B	1.00

ReleaseWaitAsync_WithTimeout	Main	18,714.22 ns	1,490.603 ns	1.00	680 B	1.00
ReleaseWaitAsync_WithTimeout	PR	17,459.44 ns	874.799 ns	0.94	680 B	1.00

ReleaseWaitAsync_WithCancellationTokenAndTimeout	Main	19,060.74 ns	911.619 ns	1.00	680 B	1.00
ReleaseWaitAsync_WithCancellationTokenAndTimeout	PR	18,601.40 ns	1,528.630 ns	0.98	680 B	1.00

System.Threading.Tests.Perf_Monitor

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
EnterExit	Main	8.628 ns	0.1177 ns	1.00	-	NA
EnterExit	PR	10.146 ns	0.0306 ns	1.18	-	NA

TryEnterExit	Main	8.699 ns	0.1159 ns	1.00	-	NA
TryEnterExit	PR	8.762 ns	0.0342 ns	1.01	-	NA

System.Threading.Tests.Perf_Lock

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1 StdDev=0.012 ns

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
ReaderWriterLockSlimPerf	Main	12.20 ns	0.013 ns	1.00	-	NA
ReaderWriterLockSlimPerf	PR	12.17 ns	0.014 ns	1.00	-	NA

System.Threading.Tests.Perf_Interlocked

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
Increment_int	Main	2.108 ns	0.0009 ns	1.00	-	NA
Increment_int	PR	2.107 ns	0.0009 ns	1.00	-	NA

Decrement_int	Main	2.109 ns	0.0009 ns	1.00	-	NA
Decrement_int	PR	2.106 ns	0.0010 ns	1.00	-	NA

Increment_long	Main	2.108 ns	0.0013 ns	1.00	-	NA
Increment_long	PR	2.107 ns	0.0006 ns	1.00	-	NA

Decrement_long	Main	2.108 ns	0.0012 ns	1.00	-	NA
Decrement_long	PR	2.108 ns	0.0012 ns	1.00	-	NA

Add_int	Main	2.108 ns	0.0010 ns	1.00	-	NA
Add_int	PR	2.108 ns	0.0008 ns	1.00	-	NA

Add_long	Main	2.108 ns	0.0011 ns	1.00	-	NA
Add_long	PR	2.107 ns	0.0011 ns	1.00	-	NA

Exchange_int	Main	2.185 ns	0.0006 ns	1.00	-	NA
Exchange_int	PR	2.185 ns	0.0006 ns	1.00	-	NA

Exchange_long	Main	2.185 ns	0.0007 ns	1.00	-	NA
Exchange_long	PR	2.186 ns	0.0008 ns	1.00	-	NA

CompareExchange_int	Main	2.394 ns	0.0007 ns	1.00	-	NA
CompareExchange_int	PR	2.394 ns	0.0006 ns	1.00	-	NA

CompareExchange_long	Main	2.394 ns	0.0007 ns	1.00	-	NA
CompareExchange_long	PR	2.395 ns	0.0011 ns	1.00	-	NA

CompareExchange_object_Match	Main	2.489 ns	0.0014 ns	1.00	-	NA
CompareExchange_object_Match	PR	2.395 ns	0.0015 ns	0.96	-	NA

CompareExchange_object_NoMatch	Main	2.489 ns	0.0008 ns	1.00	-	NA
CompareExchange_object_NoMatch	PR	2.398 ns	0.0012 ns	0.96	-	NA

System.Threading.Tests.Perf_EventWaitHandle

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1 Min=19.45 ns

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
Set_Reset	Main	19.48 ns	0.025 ns	1.00	-	NA
Set_Reset	PR	19.49 ns	0.021 ns	1.00	-	NA

System.Threading.Tests.Perf_CancellationToken

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-NRQIIJ : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-NGSIDY : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False PowerPlanMode= IterationTime=250ms
MaxIterationCount=20 MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
RegisterAndUnregister_Serial	Main	24.138 ns	0.1453 ns	1.00	-	NA
RegisterAndUnregister_Serial	PR	23.736 ns	0.3858 ns	0.98	-	NA

Cancel	Main	48.256 ns	0.4052 ns	1.00	192 B	1.00
Cancel	PR	48.049 ns	0.3128 ns	1.00	192 B	1.00

CreateLinkedTokenSource1	Main	27.951 ns	0.3240 ns	1.00	64 B	1.00
CreateLinkedTokenSource1	PR	28.637 ns	0.5653 ns	1.02	64 B	1.00

CreateLinkedTokenSource2	Main	46.560 ns	0.7770 ns	1.00	80 B	1.00
CreateLinkedTokenSource2	PR	44.870 ns	0.4932 ns	0.96	80 B	1.00

CreateLinkedTokenSource3	Main	73.413 ns	1.4567 ns	1.00	128 B	1.00
CreateLinkedTokenSource3	PR	72.403 ns	1.4278 ns	0.99	128 B	1.00

CreateTokenDispose	Main	7.761 ns	0.0516 ns	1.00	48 B	1.00
CreateTokenDispose	PR	7.763 ns	0.0186 ns	1.00	48 B	1.00

CreateRegisterDispose	Main	43.158 ns	0.4251 ns	1.00	192 B	1.00
CreateRegisterDispose	PR	41.951 ns	0.4338 ns	0.97	192 B	1.00

CreateManyRegisterDispose	Main	13.192 ns	0.2554 ns	1.00	-	NA
CreateManyRegisterDispose	PR	13.135 ns	0.2028 ns	1.00	-	NA

CreateManyRegisterMultipleDispose	Main	91.201 ns	0.2628 ns	1.00	-	NA
CreateManyRegisterMultipleDispose	PR	91.477 ns	0.1414 ns	1.00	-	NA

CancelAfter	Main	57.793 ns	0.4665 ns	1.00	144 B	1.00
CancelAfter	PR	58.719 ns	0.6143 ns	1.02	144 B	1.00

System.Threading.Tasks.Tests.Perf_AsyncMethods

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
EmptyAsyncMethodInvocation	Main	5.038 ns	0.0074 ns	1.00	-	NA
EmptyAsyncMethodInvocation	PR	5.028 ns	0.0066 ns	1.00	-	NA

SingleYieldMethodInvocation	Main	143.936 ns	0.9650 ns	1.00	168 B	1.00
SingleYieldMethodInvocation	PR	137.935 ns	0.6620 ns	0.96	168 B	1.00

Yield	Main	76.086 ns	0.7959 ns	1.00	24 B	1.00
Yield	PR	72.520 ns	0.6098 ns	0.95	24 B	1.00

System.Threading.Tasks.ValueTaskPerfTest

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-UXTJFQ : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-WCARJH : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-XVCCJK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HMQJNI : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False PowerPlanMode= IterationTime=250ms
MaxIterationCount=20 MaxWarmupIterationCount=10 MinIterationCount=15
MinWarmupIterationCount=2 WarmupCount=-1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
Await_FromResult	Main	7.622 ns	0.0291 ns	1.00	-	NA
Await_FromResult	PR	7.767 ns	0.0137 ns	1.02	-	NA

Await_FromCompletedTask	Main	13.296 ns	0.0772 ns	1.00	72 B	1.00
Await_FromCompletedTask	PR	13.303 ns	0.1925 ns	1.00	72 B	1.00

Await_FromCompletedValueTaskSource	Main	19.073 ns	0.2003 ns	1.00	72 B	1.00
Await_FromCompletedValueTaskSource	PR	18.853 ns	0.1334 ns	0.99	72 B	1.00

CreateAndAwait_FromResult	Main	7.686 ns	0.0070 ns	1.00	-	NA
CreateAndAwait_FromResult	PR	7.599 ns	0.0045 ns	0.99	-	NA

CreateAndAwait_FromResult_ConfigureAwait	Main	7.586 ns	0.0059 ns	1.00	-	NA
CreateAndAwait_FromResult_ConfigureAwait	PR	7.605 ns	0.0115 ns	1.00	-	NA

CreateAndAwait_FromCompletedTask	Main	9.341 ns	0.0358 ns	1.00	-	NA
CreateAndAwait_FromCompletedTask	PR	9.352 ns	0.0707 ns	1.00	-	NA

CreateAndAwait_FromCompletedTask_ConfigureAwait	Main	10.649 ns	0.1858 ns	1.00	-	NA
CreateAndAwait_FromCompletedTask_ConfigureAwait	PR	9.387 ns	0.1298 ns	0.88	-	NA

CreateAndAwait_FromCompletedValueTaskSource	Main	10.947 ns	0.0313 ns	1.00	-	NA
CreateAndAwait_FromCompletedValueTaskSource	PR	10.938 ns	0.0396 ns	1.00	-	NA

CreateAndAwait_FromYieldingAsyncMethod	Main	246.732 ns	1.8634 ns	1.00	392 B	1.00
CreateAndAwait_FromYieldingAsyncMethod	PR	246.383 ns	3.4310 ns	1.00	392 B	1.00

CreateAndAwait_FromDelayedTCS	Main	18,061.220 ns	1,681.9837 ns	1.00	519 B	1.00
CreateAndAwait_FromDelayedTCS	PR	17,440.193 ns	1,339.9493 ns	0.98	518 B	1.00

Copy_PassAsArgumentAndReturn_FromResult	Main	4.364 ns	0.0019 ns	1.00	-	NA
Copy_PassAsArgumentAndReturn_FromResult	PR	4.642 ns	0.0061 ns	1.06	-	NA

Copy_PassAsArgumentAndReturn_FromTask	Main	8.424 ns	0.1486 ns	1.00	-	NA
Copy_PassAsArgumentAndReturn_FromTask	PR	8.728 ns	0.0030 ns	1.04	-	NA

Copy_PassAsArgumentAndReturn_FromValueTaskSource	Main	11.727 ns	0.0076 ns	1.00	-	NA
Copy_PassAsArgumentAndReturn_FromValueTaskSource	PR	11.910 ns	0.2263 ns	1.02	-	NA

CreateAndAwait_FromCompletedValueTaskSource_ConfigureAwait	Main	10.839 ns	0.0543 ns	1.00	-	NA
CreateAndAwait_FromCompletedValueTaskSource_ConfigureAwait	PR	10.933 ns	0.0833 ns	1.01	-	NA

System.Threading.Channels.Tests.UnboundedChannelPerfTests

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
TryWriteThenTryRead	Main	21.26 ns	0.011 ns	1.00	-	NA
TryWriteThenTryRead	PR	21.27 ns	0.034 ns	1.00	-	NA

WriteAsyncThenReadAsync	Main	29.23 ns	0.076 ns	1.00	-	NA
WriteAsyncThenReadAsync	PR	28.29 ns	0.025 ns	0.97	-	NA

ReadAsyncThenWriteAsync	Main	51.77 ns	4.620 ns	1.00	-	NA
ReadAsyncThenWriteAsync	PR	45.70 ns	0.020 ns	0.89	-	NA

PingPong	Main	3,017,820.16 ns	268,337.188 ns	1.00	1079 B	1.00
PingPong	PR	2,995,050.16 ns	170,307.137 ns	1.00	1081 B	1.00

System.Threading.Channels.Tests.SpscUnboundedChannelPerfTests

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
TryWriteThenTryRead	Main	21.90 ns	0.085 ns	1.00	-	NA
TryWriteThenTryRead	PR	21.29 ns	0.056 ns	0.97	-	NA

WriteAsyncThenReadAsync	Main	34.87 ns	0.050 ns	1.00	-	NA
WriteAsyncThenReadAsync	PR	34.69 ns	0.038 ns	0.99	-	NA

ReadAsyncThenWriteAsync	Main	43.22 ns	0.027 ns	1.00	-	NA
ReadAsyncThenWriteAsync	PR	42.72 ns	0.059 ns	0.99	-	NA

PingPong	Main	2,880,382.89 ns	183,139.833 ns	1.00	1079 B	1.00
PingPong	PR	2,926,050.04 ns	229,088.081 ns	1.02	1079 B	1.00

System.Threading.Channels.Tests.BoundedChannelPerfTests

BenchmarkDotNet v0.16.0-nightly.20260518.1249, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V74 2.60GHz, 1 CPU, 8 logical and 4 physical cores
Memory: 31.34 GB Total, 1.89 GB Available
Job-TPEJOW : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
Job-HKHXHK : .NET 11.0.0 (11.0.0-dev, 42.42.42.42424), X64 RyuJIT x86-64-v4
EvaluateOverhead=False OutlierMode=Default PowerPlanMode=
IterationTime=250ms MaxIterationCount=20 MemoryRandomization=Default
MinIterationCount=15 WarmupCount=1

Method	Toolchain	Mean	Error	Ratio	Allocated	Alloc Ratio
TryWriteThenTryRead	Main	30.64 ns	0.055 ns	1.00	-	NA
TryWriteThenTryRead	PR	30.86 ns	0.015 ns	1.01	-	NA

WriteAsyncThenReadAsync	Main	37.06 ns	0.040 ns	1.00	-	NA
WriteAsyncThenReadAsync	PR	39.90 ns	0.070 ns	1.08	-	NA

ReadAsyncThenWriteAsync	Main	42.11 ns	0.274 ns	1.00	-	NA
ReadAsyncThenWriteAsync	PR	42.30 ns	0.050 ns	1.00	-	NA

PingPong	Main	3,260,739.75 ns	236,075.870 ns	1.00	1081 B	1.00
PingPong	PR	3,259,202.12 ns	244,386.437 ns	1.01	1081 B	1.00

VSadov · 2026-06-10T05:38:51Z

@EgorBot -x64

usingBenchmarkDotNet.Attributes;usingSystem.Threading.Tasks;namespaceSystem.Threading.Tests{publicclassPerf_ManualResetEventSlim_SteadyState{[Params(1_000,100_000)]publicintIterations;[Benchmark]publicvoidPingPong(){varmres1=newManualResetEventSlim(false);varmres2=newManualResetEventSlim(false);Taskt=Task.Run(()=>{for(inti=0;i<Iterations;i++){mres1.Wait();mres1.Reset();mres2.Set();}});for(inti=0;i<Iterations;i++){mres1.Set();mres2.Wait();mres2.Reset();}t.Wait();}}publicclassPerf_ManualResetEventSlim_FirstUseContention{[Params(1,4,16,64)]publicintThreads;[Params(1_000)]publicintOperationsPerThread;[Benchmark]publicvoidParallelFirstBlockingWait(){Task[]tasks=newTask[Threads];varstart=newManualResetEventSlim(false);for(intt=0;t<Threads;t++){tasks[t]=Task.Run(()=>{start.Wait();for(inti=0;i<OperationsPerThread;i++){varmres=newManualResetEventSlim(false);Tasksignaler=Task.Run(()=>mres.Set());mres.Wait();signaler.Wait();}});}start.Set();Task.WaitAll(tasks);}}[MemoryDiagnoser]publicclassPerf_ManualResetEventSlim_GC{[Params(10_000,100_000)]publicintCount;privateManualResetEventSlim[]_events;[GlobalSetup]publicvoidSetup(){_events=newManualResetEventSlim[Count];for(inti=0;i<Count;i++){varmres=newManualResetEventSlim(false);Taskt=Task.Run(()=>mres.Set());mres.Wait();t.Wait();mres.Reset();_events[i]=mres;}GC.Collect();GC.WaitForPendingFinalizers();GC.Collect();}[Benchmark]publicvoidGen0CollectionsWithManyLiveInstances(){for(inti=0;i<100;i++){GC.Collect(0,GCCollectionMode.Forced,blocking:true);}GC.KeepAlive(_events);}}}

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

VSadov · 2026-06-10T20:07:50Z

@MihuBot benchmark System.Buffers

MihuBot · 2026-06-10T22:07:26Z

See benchmark results at https://gist.github.com/MihuBot/63e4f13a5826f3e15a5353d77739f04b

VSadov · 2026-06-10T22:55:28Z

@EgorBot -x64

usingBenchmarkDotNet.Attributes;usingSystem.Threading.Tasks;namespaceSystem.Threading.Tests{[MemoryDiagnoser]publicclassPerf_ManualResetEventSlim_SteadyState{[Params(1_000,100_000)]publicintIterations;[Benchmark]publicvoidPingPong(){varmres1=newManualResetEventSlim(false,0);varmres2=newManualResetEventSlim(false,0);Taskt=Task.Run(()=>{for(inti=0;i<Iterations;i++){mres1.Wait();mres1.Reset();mres2.Set();}});for(inti=0;i<Iterations;i++){mres1.Set();mres2.Wait();mres2.Reset();}t.Wait();}}}

VSadov · 2026-06-10T23:30:45Z

@EgorBot -x64

usingBenchmarkDotNet.Attributes;usingSystem.Threading.Tasks;namespaceSystem.Threading.Tests{[MemoryDiagnoser]publicclassPerf_ManualResetEventSlim_SteadyState{[Params(1_000,100_000)]publicintIterations;[Benchmark]publicvoidPingPong(){varmres1=newManualResetEventSlim(false);varmres2=newManualResetEventSlim(false);Taskt=Task.Run(()=>{for(inti=0;i<Iterations;i++){mres1.Wait();mres1.Reset();mres2.Set();}});for(inti=0;i<Iterations;i++){mres1.Set();mres2.Wait();mres2.Reset();}t.Wait();}}}

VSadov · 2026-06-11T05:49:00Z

Is there a micro-benchmark that demonstrates the improvement?

LLM came out with 3 benchmarks for the impact of this change:

ParallelFirstBlockingWait - to measure the contention effects
Gen0CollectionsWithManyLiveInstances - effect on GC pause
PingPong - effect on throughput of two threads unblocking each other via ManualResetEventSlim

The first two benchmarks are inconclusive. Possibly we do not test for large enough state or with enough concurrency.

The PingPong however shows consistent improvements.

with spinning disabled we see:

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V45 2.60GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 11.0.100-preview.6.26310.110
[Host] : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v4
RatioSD=0.02

Method	Toolchain	Iterations	Mean	Error	Ratio	Allocated	Alloc Ratio
PingPong	PR #129083**	1000	15.97 ms	0.256 ms	1.00	424 B	1.00
PingPong	main	1000	16.34 ms	0.216 ms	1.02	499 B	1.18

PingPong	PR #129083**	100000	1,649.53 ms	24.462 ms	1.00	424 B	1.00
PingPong	main	100000	1,679.25 ms	33.129 ms	1.02	720 B	1.70

Full logs

And even with the default spinning, that shields somewhat from the effects of waiting:

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.4 LTS (Noble Numbat)
AMD EPYC 9V45 2.60GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 11.0.100-preview.6.26310.110
[Host] : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v4

Method	Toolchain	Iterations	Mean	Error	Ratio	Allocated	Alloc Ratio
PingPong	PR #129083**	1000	147.1 μs	2.86 μs	1.00	248 B	1.00
PingPong	main	1000	163.3 μs	2.42 μs	1.11	248 B	1.00

PingPong	PR #129083**	100000	15,097.8 μs	298.71 μs	1.00	252 B	1.00
PingPong	main	100000	16,255.1 μs	324.92 μs	1.08	251 B	1.00

Full logs

VSadov · 2026-06-11T17:55:49Z

I've also run PingPong with [MemoryDiagnoser] and in the forced no-spinning case the PR version allocates clearly less.
(the first table above)

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Main motivation is that `ManualResetEventSlim` uses `Monitor.Wait` to implement `Wait` that is: * cancellable * interruptible (in `Thread.Interrupt` sense) and * aware of synchronization context `Monitor.Wait` is a good fit to implement such pattern and should generally perform well enough. `ManualResetEventSlim` in turn is used in `Task.Wait` and some scenarios can wait on Tasks relatively frequently. In such scenarios using `ConditionalWaitTable` for Lock->Condition association may have two inconveniences: * it may result in quite a few dependent handles being alive and that can have impact on GC. In particular because dependent handles currently do not age and need to be revisited in every Gen0, even if both objects referred from the handle may be Gen2 objects. (we should probably address #79062, regardless of this PR) * Allocating an entry in `ConditionalWaitTable` acquires table-wide lock and on large enough core count may contend. It seems there is a relatively simple way to arrange Lock->Condition link without involving `ConditionalWaitTable`, thus why not. The change also enables `Wait`/`Pulse`/`PulseAll` functionality on `Lock`, but only internally. It can be exposed as a public API, but it would be a separate discussion.

CopilotAI review requested due to automatic review settings June 6, 2026 22:04

Copilotstarted reviewing on behalf of VSadov June 6, 2026 22:04 View session

github-actionsBot added the area-System.Threading label Jun 6, 2026

dotnet-policy-serviceBot assigned VSadov Jun 6, 2026

VSadov added this to the 11.0.0 milestone Jun 6, 2026

CopilotAI reviewed Jun 6, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings June 7, 2026 00:27

Copilotstarted reviewing on behalf of VSadov June 7, 2026 00:27 View session

CopilotAI reviewed Jun 7, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs

VSadov marked this pull request as ready for review June 7, 2026 01:23

CopilotAI review requested due to automatic review settings June 7, 2026 01:23

Copilotstarted reviewing on behalf of VSadov June 7, 2026 01:24 View session

CopilotAI reviewed Jun 7, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/Monitor.cs

VSadov requested a review from jkotas June 7, 2026 04:34

build-analysisBot mentioned this pull request Jun 7, 2026
AF: *(_UNCHECKED_OBJECTREF *)handle == NULL (HndCreateHandle called by getJitHandleForObject) #117138
Open

MihuBot mentioned this pull request Jun 10, 2026
[Benchmark X64] [VSadov] Make Condition to not use ConditionalWeakTable MihuBot/runtime-utils#1961
Open

This was referenced Jun 10, 2026
Benchmarks for dotnet/runtime#129083 (for @VSadov) EgorBot/Benchmarks#243
Open
Benchmarks for dotnet/runtime#129083 (for @VSadov) EgorBot/Benchmarks#244
Open
Benchmarks for dotnet/runtime#129083 (for @VSadov) EgorBot/Benchmarks#245
Open

CopilotAI review requested due to automatic review settings June 10, 2026 05:38

VSadov force-pushed the cobReg branch from 0c0f58a to 62b8a0fCompare June 10, 2026 05:38

Copilotstarted reviewing on behalf of VSadov June 10, 2026 05:38 View session

EgorBot mentioned this pull request Jun 10, 2026
Benchmarks for dotnet/runtime#129083 (for @VSadov) EgorBot/Benchmarks#246
Open

CopilotAI reviewed Jun 10, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs

MihuBot mentioned this pull request Jun 10, 2026
[Benchmark X64] [VSadov] Make Condition to not use ConditionalWeakTable MihuBot/runtime-utils#1965
Open

MihuBot mentioned this pull request Jun 10, 2026
[Benchmark X64] [VSadov] Make Condition to not use ConditionalWeakTable MihuBot/runtime-utils#1966
Open

This was referenced Jun 10, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
[browser][coreCLR] Wasm.Console.Node.Sample - undefined symbol: SystemInteropJS_GetManagedStackTrace #129229
Closed

EgorBot mentioned this pull request Jun 10, 2026
Benchmarks for dotnet/runtime#129083 (for @VSadov) EgorBot/Benchmarks#247
Open

EgorBot mentioned this pull request Jun 10, 2026
Benchmarks for dotnet/runtime#129083 (for @VSadov) EgorBot/Benchmarks#248
Open

build-analysisBot mentioned this pull request Jun 11, 2026
browser-wasm linux Release LibraryTests queues timing out #117974
Open

jkotas reviewed Jun 11, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/Monitor.cs Outdated

jkotas approved these changes Jun 11, 2026
View reviewed changes

jkotas added the tenet-performance Performance related issue label Jun 11, 2026

remove now unused s_conditionTable and corresponding TODO:
7d4cc18

CopilotAI review requested due to automatic review settings June 11, 2026 20:23

Copilotstarted reviewing on behalf of VSadov June 11, 2026 20:24 View session

CopilotAI reviewed Jun 11, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs

remove s_conditionTable in corelib.h as well
339d28c

VSadov enabled auto-merge (squash) June 11, 2026 21:37

This was referenced Jun 11, 2026
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed
TestNativeDigits fails for ur-IN on Apple platforms (xunit v3 exposed previously non-running test) #125933
Closed

VSadov merged commit 63e7364 into dotnet:mainJun 12, 2026
157 of 159 checks passed

VSadov deleted the cobReg branch June 12, 2026 01:37

dotnet-maestroBot mentioned this pull request Jun 12, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7196
Merged

jkotas mentioned this pull request Jun 14, 2026
Optimize and simplify delegate layout #99200
Merged

dotnet-milestone-botBot modified the milestones: 11.0.0, 11.0-preview6 Jun 17, 2026

github-actionsBot locked and limited conversation to collaborators Jul 18, 2026

Uh oh!

Conversation

VSadov commented Jun 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

jkotas commented Jun 7, 2026

Uh oh!

VSadov commented Jun 10, 2026

Uh oh!

MihuBot commented Jun 10, 2026

Uh oh!

VSadov commented Jun 10, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VSadov commented Jun 10, 2026

Uh oh!

MihuBot commented Jun 10, 2026

Uh oh!

VSadov commented Jun 10, 2026

Uh oh!

VSadov commented Jun 10, 2026

Uh oh!

VSadov commented Jun 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VSadov commented Jun 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VSadov commented Jun 6, 2026•
edited
Loading

VSadov commented Jun 11, 2026•
edited
Loading

VSadov commented Jun 11, 2026•
edited
Loading