Skip to content

JIT: Tail-merge robust crossJumpVictim selection - #129141

Merged
EgorBo merged 4 commits into
dotnet:mainfrom
BoyBaykiller:robust-crossJumpVictim
Jun 29, 2026
Merged

JIT: Tail-merge robust crossJumpVictim selection#129141
EgorBo merged 4 commits into
dotnet:mainfrom
BoyBaykiller:robust-crossJumpVictim

Conversation

@BoyBaykiller

@BoyBaykillerBoyBaykiller commented Jun 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Previously, crossJumpVictim selection logic was dependent on the order of candidates which can lead to random diffs.

I removed the early out and added a tie-break which makes it order independent and sets the stage for a follow up zero-diff PR that processes all sets at once.
For the tie-break I used: predBlock->bbNum < crossJumpVictim->bbNum. This actually has few good diffs because it preferences away from BBF_NEEDS_GCPOLL blocks for some reason. I'd be nice to add that as a seperate heuristic instead of being implicitly encoded in the tie-break.

@BoyBaykillerBoyBaykiller changed the title JIT: Robust crossJumpVictimJIT: Tail-merge robust crossJumpVictimJun 8, 2026
@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2026
@BoyBaykillerBoyBaykiller changed the title JIT: Tail-merge robust crossJumpVictimJIT: Tail-merge robust crossJumpVictim selectionJun 9, 2026
This was referenced Jun 9, 2026
Open
Closed
@BoyBaykiller
BoyBaykillerforce-pushed the robust-crossJumpVictim branch from 4ef215d to cba2e61CompareJune 11, 2026 02:17
@BoyBaykiller
* add tie-break
d42fc3c
* don't early out
* make NoGcPoll preference explicit
@BoyBaykiller
* remove explicit isNoGcPoll heuristic
a9d4d53
@BoyBaykiller
BoyBaykillerforce-pushed the robust-crossJumpVictim branch from aa70303 to a9d4d53CompareJune 11, 2026 02:19
This was referenced Jun 11, 2026
Open
Closed
@BoyBaykiller

BoyBaykiller commented Jun 11, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@AndyAyersMS PTAL. Makes the crossJumpVictim selection robust by introducing a tie-break and removing early out. Now, no matter the order of candidates, we always pick the same. This avoids spurious diffs in future changes. In particular, my goal is to follow up with a zero-diff PR that processes all sets at once.

There are some few good diffs from avoiding splitting of from BBF_NEEDS_GCPOLL blocks.

@BoyBaykillerBoyBaykiller mentioned this pull request Jun 13, 2026
Open
AndyAyersMS
AndyAyersMS reviewed Jun 25, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp Outdated
Comment threadsrc/coreclr/jit/fgopt.cpp
AndyAyersMS
AndyAyersMS approved these changes Jun 26, 2026
View reviewed changes

@AndyAyersMSAndyAyersMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorBo can you also review

EgorBo
EgorBo reviewed Jun 29, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp

bool const isNoSplit = stmt == predBlock->firstStmt();
bool const isFallThrough = (predBlock->KindIs(BBJ_ALWAYS) && predBlock->JumpsToNext());
auto getRank = [=]() -> unsigned {

@EgorBoEgorBoJun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand why you wrapped it to a single-use lambda, not a big fan of this approach.

@EgorBo
EgorBo enabled auto-merge (squash) June 29, 2026 19:45
@EgorBo
EgorBo merged commit b6f8d20 into dotnet:mainJun 29, 2026
138 checks passed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jun 30, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview7 milestone Jun 30, 2026
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@BoyBaykiller@eiriktsarpalis
JIT: Tail-merge robustcrossJumpVictimselection (#129141)
8d7f8a2
Previously, `crossJumpVictim` selection logic was dependent on the order
of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order
independent and sets the stage for a follow up zero-diff PR that
processes all sets at once.
For the tie-break I used: `predBlock->bbNum < crossJumpVictim->bbNum`.
This actually has few good diffs because it preferences away from
`BBF_NEEDS_GCPOLL` blocks for some reason. I'd be nice to add that as a
seperate heuristic instead of being implicitly encoded in the tie-break.
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 30, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@BoyBaykiller@EgorBo@AndyAyersMS
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
JIT: Tail-merge robust `crossJumpVictim` selection by BoyBaykiller · Pull Request #129141 · dotnet/runtime · GitHub
Skip to content
JIT: Tail-merge robust crossJumpVictim selection - #129141
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Jun 29, 2026
Merged
JIT: Tail-merge robust crossJumpVictim selection#129141
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Conversation
@BoyBaykiller
@BoyBaykillerBoyBaykiller
commented
Jun 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Previously, crossJumpVictim selection logic was dependent on the order of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order independent and sets the stage for a follow up zero-diff PR that processes all sets at once.

For the tie-break I used: predBlock->bbNum < crossJumpVictim->bbNum. This actually has few good diffs because it preferences away from BBF_NEEDS_GCPOLL blocks for some reason. I'd be nice to add that as a seperate heuristic instead of being implicitly encoded in the tie-break.
@BoyBaykillerBoyBaykiller
changed the title
JIT: Robust crossJumpVictimJIT: Tail-merge robust crossJumpVictimJun 8, 2026
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2026
@BoyBaykillerBoyBaykiller
changed the title
JIT: Tail-merge robust crossJumpVictimJIT: Tail-merge robust crossJumpVictim selectionJun 9, 2026

This was referenced Jun 9, 2026

Open


Closed

@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
4ef215d to
cba2e61CompareJune 11, 2026 02:17
@BoyBaykiller
* add tie-break
d42fc3c
* don't early out
* make NoGcPoll preference explicit
@BoyBaykiller
* remove explicit isNoGcPoll heuristic
a9d4d53
@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
aa70303 to
a9d4d53CompareJune 11, 2026 02:19

This was referenced Jun 11, 2026

Open


Closed

@BoyBaykiller
BoyBaykiller
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@AndyAyersMS PTAL. Makes the crossJumpVictim selection robust by introducing a tie-break and removing early out. Now, no matter the order of candidates, we always pick the same. This avoids spurious diffs in future changes. In particular, my goal is to follow up with a zero-diff PR that processes all sets at once.
There are some few good diffs from avoiding splitting of from BBF_NEEDS_GCPOLL blocks.
@BoyBaykillerBoyBaykiller
mentioned this pull request
Jun 13, 2026
 Open

AndyAyersMS
AndyAyersMS
reviewed
Jun 25, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp
Outdated

Comment threadsrc/coreclr/jit/fgopt.cpp
AndyAyersMS
AndyAyersMS
approved these changes
Jun 26, 2026
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@EgorBo can you also review
EgorBo
EgorBo
reviewed
Jun 29, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp

 bool const isNoSplit = stmt == predBlock->firstStmt();
 bool const isFallThrough = (predBlock->KindIs(BBJ_ALWAYS) && predBlock->JumpsToNext());
 auto getRank = [=]() -> unsigned {
@EgorBoEgorBoJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand why you wrapped it to a single-use lambda, not a big fan of this approach.
@EgorBo
EgorBo
enabled auto-merge (squash)
June 29, 2026 19:45
@EgorBo
EgorBo
merged commit b6f8d20
into
dotnet:mainJun 29, 2026

138 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 30, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 30, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@BoyBaykiller@eiriktsarpalis
JIT: Tail-merge robustcrossJumpVictimselection (#129141)
8d7f8a2
Previously, `crossJumpVictim` selection logic was dependent on the order
of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order
independent and sets the stage for a follow up zero-diff PR that
processes all sets at once.
For the tie-break I used: `predBlock->bbNum < crossJumpVictim->bbNum`.
This actually has few good diffs because it preferences away from
`BBF_NEEDS_GCPOLL` blocks for some reason. I'd be nice to add that as a
seperate heuristic instead of being implicitly encoded in the tie-break.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 30, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@BoyBaykiller@EgorBo@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
JIT: Tail-merge robust `crossJumpVictim` selection by BoyBaykiller · Pull Request #129141 · dotnet/runtime · GitHub
Skip to content
JIT: Tail-merge robust crossJumpVictim selection - #129141
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Jun 29, 2026
Merged
JIT: Tail-merge robust crossJumpVictim selection#129141
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Conversation
@BoyBaykiller
@BoyBaykillerBoyBaykiller
commented
Jun 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Previously, crossJumpVictim selection logic was dependent on the order of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order independent and sets the stage for a follow up zero-diff PR that processes all sets at once.

For the tie-break I used: predBlock->bbNum < crossJumpVictim->bbNum. This actually has few good diffs because it preferences away from BBF_NEEDS_GCPOLL blocks for some reason. I'd be nice to add that as a seperate heuristic instead of being implicitly encoded in the tie-break.
@BoyBaykillerBoyBaykiller
changed the title
JIT: Robust crossJumpVictimJIT: Tail-merge robust crossJumpVictimJun 8, 2026
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2026
@BoyBaykillerBoyBaykiller
changed the title
JIT: Tail-merge robust crossJumpVictimJIT: Tail-merge robust crossJumpVictim selectionJun 9, 2026

This was referenced Jun 9, 2026

Open


Closed

@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
4ef215d to
cba2e61CompareJune 11, 2026 02:17
@BoyBaykiller
* add tie-break
d42fc3c
* don't early out
* make NoGcPoll preference explicit
@BoyBaykiller
* remove explicit isNoGcPoll heuristic
a9d4d53
@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
aa70303 to
a9d4d53CompareJune 11, 2026 02:19

This was referenced Jun 11, 2026

Open


Closed

@BoyBaykiller
BoyBaykiller
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@AndyAyersMS PTAL. Makes the crossJumpVictim selection robust by introducing a tie-break and removing early out. Now, no matter the order of candidates, we always pick the same. This avoids spurious diffs in future changes. In particular, my goal is to follow up with a zero-diff PR that processes all sets at once.
There are some few good diffs from avoiding splitting of from BBF_NEEDS_GCPOLL blocks.
@BoyBaykillerBoyBaykiller
mentioned this pull request
Jun 13, 2026
 Open

AndyAyersMS
AndyAyersMS
reviewed
Jun 25, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp
Outdated

Comment threadsrc/coreclr/jit/fgopt.cpp
AndyAyersMS
AndyAyersMS
approved these changes
Jun 26, 2026
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@EgorBo can you also review
EgorBo
EgorBo
reviewed
Jun 29, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp

 bool const isNoSplit = stmt == predBlock->firstStmt();
 bool const isFallThrough = (predBlock->KindIs(BBJ_ALWAYS) && predBlock->JumpsToNext());
 auto getRank = [=]() -> unsigned {
@EgorBoEgorBoJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand why you wrapped it to a single-use lambda, not a big fan of this approach.
@EgorBo
EgorBo
enabled auto-merge (squash)
June 29, 2026 19:45
@EgorBo
EgorBo
merged commit b6f8d20
into
dotnet:mainJun 29, 2026

138 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 30, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 30, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@BoyBaykiller@eiriktsarpalis
JIT: Tail-merge robustcrossJumpVictimselection (#129141)
8d7f8a2
Previously, `crossJumpVictim` selection logic was dependent on the order
of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order
independent and sets the stage for a follow up zero-diff PR that
processes all sets at once.
For the tie-break I used: `predBlock->bbNum < crossJumpVictim->bbNum`.
This actually has few good diffs because it preferences away from
`BBF_NEEDS_GCPOLL` blocks for some reason. I'd be nice to add that as a
seperate heuristic instead of being implicitly encoded in the tie-break.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 30, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@BoyBaykiller@EgorBo@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
JIT: Tail-merge robust `crossJumpVictim` selection by BoyBaykiller · Pull Request #129141 · dotnet/runtime · GitHub
Skip to content
JIT: Tail-merge robust crossJumpVictim selection - #129141
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Jun 29, 2026
Merged
JIT: Tail-merge robust crossJumpVictim selection#129141
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Conversation
@BoyBaykiller
@BoyBaykillerBoyBaykiller
commented
Jun 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Previously, crossJumpVictim selection logic was dependent on the order of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order independent and sets the stage for a follow up zero-diff PR that processes all sets at once.

For the tie-break I used: predBlock->bbNum < crossJumpVictim->bbNum. This actually has few good diffs because it preferences away from BBF_NEEDS_GCPOLL blocks for some reason. I'd be nice to add that as a seperate heuristic instead of being implicitly encoded in the tie-break.
@BoyBaykillerBoyBaykiller
changed the title
JIT: Robust crossJumpVictimJIT: Tail-merge robust crossJumpVictimJun 8, 2026
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2026
@BoyBaykillerBoyBaykiller
changed the title
JIT: Tail-merge robust crossJumpVictimJIT: Tail-merge robust crossJumpVictim selectionJun 9, 2026

This was referenced Jun 9, 2026

Open


Closed

@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
4ef215d to
cba2e61CompareJune 11, 2026 02:17
@BoyBaykiller
* add tie-break
d42fc3c
* don't early out
* make NoGcPoll preference explicit
@BoyBaykiller
* remove explicit isNoGcPoll heuristic
a9d4d53
@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
aa70303 to
a9d4d53CompareJune 11, 2026 02:19

This was referenced Jun 11, 2026

Open


Closed

@BoyBaykiller
BoyBaykiller
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@AndyAyersMS PTAL. Makes the crossJumpVictim selection robust by introducing a tie-break and removing early out. Now, no matter the order of candidates, we always pick the same. This avoids spurious diffs in future changes. In particular, my goal is to follow up with a zero-diff PR that processes all sets at once.
There are some few good diffs from avoiding splitting of from BBF_NEEDS_GCPOLL blocks.
@BoyBaykillerBoyBaykiller
mentioned this pull request
Jun 13, 2026
 Open

AndyAyersMS
AndyAyersMS
reviewed
Jun 25, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp
Outdated

Comment threadsrc/coreclr/jit/fgopt.cpp
AndyAyersMS
AndyAyersMS
approved these changes
Jun 26, 2026
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@EgorBo can you also review
EgorBo
EgorBo
reviewed
Jun 29, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp

 bool const isNoSplit = stmt == predBlock->firstStmt();
 bool const isFallThrough = (predBlock->KindIs(BBJ_ALWAYS) && predBlock->JumpsToNext());
 auto getRank = [=]() -> unsigned {
@EgorBoEgorBoJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand why you wrapped it to a single-use lambda, not a big fan of this approach.
@EgorBo
EgorBo
enabled auto-merge (squash)
June 29, 2026 19:45
@EgorBo
EgorBo
merged commit b6f8d20
into
dotnet:mainJun 29, 2026

138 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 30, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 30, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@BoyBaykiller@eiriktsarpalis
JIT: Tail-merge robustcrossJumpVictimselection (#129141)
8d7f8a2
Previously, `crossJumpVictim` selection logic was dependent on the order
of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order
independent and sets the stage for a follow up zero-diff PR that
processes all sets at once.
For the tie-break I used: `predBlock->bbNum < crossJumpVictim->bbNum`.
This actually has few good diffs because it preferences away from
`BBF_NEEDS_GCPOLL` blocks for some reason. I'd be nice to add that as a
seperate heuristic instead of being implicitly encoded in the tie-break.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 30, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@BoyBaykiller@EgorBo@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
JIT: Tail-merge robust `crossJumpVictim` selection by BoyBaykiller · Pull Request #129141 · dotnet/runtime · GitHub
Skip to content
JIT: Tail-merge robust crossJumpVictim selection - #129141
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Jun 29, 2026
Merged
JIT: Tail-merge robust crossJumpVictim selection#129141
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Conversation
@BoyBaykiller
@BoyBaykillerBoyBaykiller
commented
Jun 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Previously, crossJumpVictim selection logic was dependent on the order of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order independent and sets the stage for a follow up zero-diff PR that processes all sets at once.

For the tie-break I used: predBlock->bbNum < crossJumpVictim->bbNum. This actually has few good diffs because it preferences away from BBF_NEEDS_GCPOLL blocks for some reason. I'd be nice to add that as a seperate heuristic instead of being implicitly encoded in the tie-break.
@BoyBaykillerBoyBaykiller
changed the title
JIT: Robust crossJumpVictimJIT: Tail-merge robust crossJumpVictimJun 8, 2026
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2026
@BoyBaykillerBoyBaykiller
changed the title
JIT: Tail-merge robust crossJumpVictimJIT: Tail-merge robust crossJumpVictim selectionJun 9, 2026

This was referenced Jun 9, 2026

Open


Closed

@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
4ef215d to
cba2e61CompareJune 11, 2026 02:17
@BoyBaykiller
* add tie-break
d42fc3c
* don't early out
* make NoGcPoll preference explicit
@BoyBaykiller
* remove explicit isNoGcPoll heuristic
a9d4d53
@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
aa70303 to
a9d4d53CompareJune 11, 2026 02:19

This was referenced Jun 11, 2026

Open


Closed

@BoyBaykiller
BoyBaykiller
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@AndyAyersMS PTAL. Makes the crossJumpVictim selection robust by introducing a tie-break and removing early out. Now, no matter the order of candidates, we always pick the same. This avoids spurious diffs in future changes. In particular, my goal is to follow up with a zero-diff PR that processes all sets at once.
There are some few good diffs from avoiding splitting of from BBF_NEEDS_GCPOLL blocks.
@BoyBaykillerBoyBaykiller
mentioned this pull request
Jun 13, 2026
 Open

AndyAyersMS
AndyAyersMS
reviewed
Jun 25, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp
Outdated

Comment threadsrc/coreclr/jit/fgopt.cpp
AndyAyersMS
AndyAyersMS
approved these changes
Jun 26, 2026
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@EgorBo can you also review
EgorBo
EgorBo
reviewed
Jun 29, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp

 bool const isNoSplit = stmt == predBlock->firstStmt();
 bool const isFallThrough = (predBlock->KindIs(BBJ_ALWAYS) && predBlock->JumpsToNext());
 auto getRank = [=]() -> unsigned {
@EgorBoEgorBoJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand why you wrapped it to a single-use lambda, not a big fan of this approach.
@EgorBo
EgorBo
enabled auto-merge (squash)
June 29, 2026 19:45
@EgorBo
EgorBo
merged commit b6f8d20
into
dotnet:mainJun 29, 2026

138 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 30, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 30, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@BoyBaykiller@eiriktsarpalis
JIT: Tail-merge robustcrossJumpVictimselection (#129141)
8d7f8a2
Previously, `crossJumpVictim` selection logic was dependent on the order
of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order
independent and sets the stage for a follow up zero-diff PR that
processes all sets at once.
For the tie-break I used: `predBlock->bbNum < crossJumpVictim->bbNum`.
This actually has few good diffs because it preferences away from
`BBF_NEEDS_GCPOLL` blocks for some reason. I'd be nice to add that as a
seperate heuristic instead of being implicitly encoded in the tie-break.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 30, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@BoyBaykiller@EgorBo@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
JIT: Tail-merge robust `crossJumpVictim` selection by BoyBaykiller · Pull Request #129141 · dotnet/runtime · GitHub
Skip to content
JIT: Tail-merge robust crossJumpVictim selection - #129141
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Jun 29, 2026
Merged
JIT: Tail-merge robust crossJumpVictim selection#129141
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Conversation
@BoyBaykiller
@BoyBaykillerBoyBaykiller
commented
Jun 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Previously, crossJumpVictim selection logic was dependent on the order of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order independent and sets the stage for a follow up zero-diff PR that processes all sets at once.

For the tie-break I used: predBlock->bbNum < crossJumpVictim->bbNum. This actually has few good diffs because it preferences away from BBF_NEEDS_GCPOLL blocks for some reason. I'd be nice to add that as a seperate heuristic instead of being implicitly encoded in the tie-break.
@BoyBaykillerBoyBaykiller
changed the title
JIT: Robust crossJumpVictimJIT: Tail-merge robust crossJumpVictimJun 8, 2026
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2026
@BoyBaykillerBoyBaykiller
changed the title
JIT: Tail-merge robust crossJumpVictimJIT: Tail-merge robust crossJumpVictim selectionJun 9, 2026

This was referenced Jun 9, 2026

Open


Closed

@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
4ef215d to
cba2e61CompareJune 11, 2026 02:17
@BoyBaykiller
* add tie-break
d42fc3c
* don't early out
* make NoGcPoll preference explicit
@BoyBaykiller
* remove explicit isNoGcPoll heuristic
a9d4d53
@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
aa70303 to
a9d4d53CompareJune 11, 2026 02:19

This was referenced Jun 11, 2026

Open


Closed

@BoyBaykiller
BoyBaykiller
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@AndyAyersMS PTAL. Makes the crossJumpVictim selection robust by introducing a tie-break and removing early out. Now, no matter the order of candidates, we always pick the same. This avoids spurious diffs in future changes. In particular, my goal is to follow up with a zero-diff PR that processes all sets at once.
There are some few good diffs from avoiding splitting of from BBF_NEEDS_GCPOLL blocks.
@BoyBaykillerBoyBaykiller
mentioned this pull request
Jun 13, 2026
 Open

AndyAyersMS
AndyAyersMS
reviewed
Jun 25, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp
Outdated

Comment threadsrc/coreclr/jit/fgopt.cpp
AndyAyersMS
AndyAyersMS
approved these changes
Jun 26, 2026
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@EgorBo can you also review
EgorBo
EgorBo
reviewed
Jun 29, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp

 bool const isNoSplit = stmt == predBlock->firstStmt();
 bool const isFallThrough = (predBlock->KindIs(BBJ_ALWAYS) && predBlock->JumpsToNext());
 auto getRank = [=]() -> unsigned {
@EgorBoEgorBoJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand why you wrapped it to a single-use lambda, not a big fan of this approach.
@EgorBo
EgorBo
enabled auto-merge (squash)
June 29, 2026 19:45
@EgorBo
EgorBo
merged commit b6f8d20
into
dotnet:mainJun 29, 2026

138 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 30, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 30, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@BoyBaykiller@eiriktsarpalis
JIT: Tail-merge robustcrossJumpVictimselection (#129141)
8d7f8a2
Previously, `crossJumpVictim` selection logic was dependent on the order
of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order
independent and sets the stage for a follow up zero-diff PR that
processes all sets at once.
For the tie-break I used: `predBlock->bbNum < crossJumpVictim->bbNum`.
This actually has few good diffs because it preferences away from
`BBF_NEEDS_GCPOLL` blocks for some reason. I'd be nice to add that as a
seperate heuristic instead of being implicitly encoded in the tie-break.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 30, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@BoyBaykiller@EgorBo@AndyAyersMS

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
JIT: Tail-merge robust `crossJumpVictim` selection by BoyBaykiller · Pull Request #129141 · dotnet/runtime · GitHub
Skip to content
JIT: Tail-merge robust crossJumpVictim selection - #129141
Merged
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Jun 29, 2026
Merged
JIT: Tail-merge robust crossJumpVictim selection#129141
EgorBo merged 4 commits into
dotnet:mainfrom 
BoyBaykiller:robust-crossJumpVictim
Conversation
@BoyBaykiller
@BoyBaykillerBoyBaykiller
commented
Jun 8, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Previously, crossJumpVictim selection logic was dependent on the order of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order independent and sets the stage for a follow up zero-diff PR that processes all sets at once.

For the tie-break I used: predBlock->bbNum < crossJumpVictim->bbNum. This actually has few good diffs because it preferences away from BBF_NEEDS_GCPOLL blocks for some reason. I'd be nice to add that as a seperate heuristic instead of being implicitly encoded in the tie-break.
@BoyBaykillerBoyBaykiller
changed the title
JIT: Robust crossJumpVictimJIT: Tail-merge robust crossJumpVictimJun 8, 2026
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 8, 2026
@BoyBaykillerBoyBaykiller
changed the title
JIT: Tail-merge robust crossJumpVictimJIT: Tail-merge robust crossJumpVictim selectionJun 9, 2026

This was referenced Jun 9, 2026

Open


Closed

@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
4ef215d to
cba2e61CompareJune 11, 2026 02:17
@BoyBaykiller
* add tie-break
d42fc3c
* don't early out
* make NoGcPoll preference explicit
@BoyBaykiller
* remove explicit isNoGcPoll heuristic
a9d4d53
@BoyBaykiller
BoyBaykillerforce-pushed
the
robust-crossJumpVictim
branch
from
aa70303 to
a9d4d53CompareJune 11, 2026 02:19

This was referenced Jun 11, 2026

Open


Closed

@BoyBaykiller
BoyBaykiller
commented
Jun 11, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@AndyAyersMS PTAL. Makes the crossJumpVictim selection robust by introducing a tie-break and removing early out. Now, no matter the order of candidates, we always pick the same. This avoids spurious diffs in future changes. In particular, my goal is to follow up with a zero-diff PR that processes all sets at once.
There are some few good diffs from avoiding splitting of from BBF_NEEDS_GCPOLL blocks.
@BoyBaykillerBoyBaykiller
mentioned this pull request
Jun 13, 2026
 Open

AndyAyersMS
AndyAyersMS
reviewed
Jun 25, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp
Outdated

Comment threadsrc/coreclr/jit/fgopt.cpp
AndyAyersMS
AndyAyersMS
approved these changes
Jun 26, 2026
View reviewed changes
@AndyAyersMSAndyAyersMS
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@EgorBo can you also review
EgorBo
EgorBo
reviewed
Jun 29, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/fgopt.cpp

 bool const isNoSplit = stmt == predBlock->firstStmt();
 bool const isFallThrough = (predBlock->KindIs(BBJ_ALWAYS) && predBlock->JumpsToNext());
 auto getRank = [=]() -> unsigned {
@EgorBoEgorBoJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand why you wrapped it to a single-use lambda, not a big fan of this approach.
@EgorBo
EgorBo
enabled auto-merge (squash)
June 29, 2026 19:45
@EgorBo
EgorBo
merged commit b6f8d20
into
dotnet:mainJun 29, 2026

138 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 30, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jun 30, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@BoyBaykiller@eiriktsarpalis
JIT: Tail-merge robustcrossJumpVictimselection (#129141)
8d7f8a2
Previously, `crossJumpVictim` selection logic was dependent on the order
of candidates which can lead to random diffs.
I removed the early out and added a tie-break which makes it order
independent and sets the stage for a follow up zero-diff PR that
processes all sets at once.
For the tie-break I used: `predBlock->bbNum < crossJumpVictim->bbNum`.
This actually has few good diffs because it preferences away from
`BBF_NEEDS_GCPOLL` blocks for some reason. I'd be nice to add that as a
seperate heuristic instead of being implicitly encoded in the tie-break.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 30, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@BoyBaykiller@EgorBo@AndyAyersMS