Pre-initialize InvariantCulture such that it can be safely used when creating stack traces by eduardo-vp · Pull Request #129189 · dotnet/runtime

eduardo-vp · 2026-06-09T20:19:53Z

The following assert is being hit when creating the stack trace in the test.

runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureInfo.cs

Lines 444 to 451 in 89cd18a

publicstaticCultureInfoInvariantCulture
{
get
{
Debug.Assert(s_InvariantCultureInfo!=null,"[CultureInfo.InvariantCulture] s_InvariantCultureInfo is null");
returns_InvariantCultureInfo;
}
}

Fixes#129159.

Copilot

Pull request overview

This PR changes CoreCLR startup to proactively run System.Globalization.CultureInfo’s class initializer during AppDomain::SetupSharedStatics(), so CultureInfo.InvariantCulture is initialized before stack trace generation paths might try to use it under extreme memory pressure (avoiding the checked-build assert observed in #129159).

Changes:

During default AppDomain startup, force CultureInfo class initialization via CheckRunClassInitThrowing().
Add a targeted comment documenting the motivation (stack trace creation under high memory pressure).

eduardo-vp · 2026-06-09T20:24:47Z

/azp list

azure-pipelines · 2026-06-09T20:24:54Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional runtime-nativeaot-outerloop runtime-coreclr superpmi-collect-test runtime-diagnostics runtime-interpreter runtime-report-green runtime-coreclr hardware-intrinsics runtime-libraries-interpreter runtime-libraries stress-http-pr runtime-libraries stress-ssl-pr hardware-intrinsics-arm64

eduardo-vp · 2026-06-09T20:29:23Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-06-09T20:29:34Z

Azure Pipelines successfully started running 1 pipeline(s).

eduardo-vp · 2026-06-10T01:55:08Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-06-10T01:55:18Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

eduardo-vp · 2026-06-10T18:45:07Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-06-10T18:45:21Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

eduardo-vp · 2026-06-17T19:26:33Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-06-17T19:26:44Z

Azure Pipelines successfully started running 1 pipeline(s).

eduardo-vp · 2026-06-18T04:12:41Z

/ba-g timeouts only

…creating stack traces (#129189) The following assert is being hit when creating the stack trace in the test. https://github.com/dotnet/runtime/blob/89cd18abdedc793529c655f4d15cd8fad30927a6/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureInfo.cs#L444-L451Fixes#129159. --------- Co-authored-by: Eduardo Velarde <evelardepola@microsoft.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Pre-initialize InvariantCulture
a4ac39c

CopilotAI review requested due to automatic review settings June 9, 2026 20:19

eduardo-vp added the area-VM-coreclr label Jun 9, 2026

Copilotstarted reviewing on behalf of eduardo-vp June 9, 2026 20:20 View session

CopilotAI reviewed Jun 9, 2026
View reviewed changes

build-analysisBot mentioned this pull request Jun 10, 2026
[ci-scan] Test failure: SystemCoreLibDirectory crashes in R2R_Composite (crossgen2 outerloop) #129046
Closed

Move to CreateAppDomainWithManager
fe0e038

build-analysisBot mentioned this pull request Jun 10, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
3 tasks

Fix placement
d26c8ac

CopilotAI review requested due to automatic review settings June 10, 2026 18:38

Copilotstarted reviewing on behalf of eduardo-vp June 10, 2026 18:38 View session

CopilotAI reviewed Jun 10, 2026
View reviewed changes

Merge branch 'main' into fix-129159
e67a9ba

jkotas reviewed Jun 16, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/corhost.cpp Outdated

Make _sLocalizedCountry initialization lazy
d3acfd9

CopilotAI review requested due to automatic review settings June 17, 2026 02:56

Copilotstarted reviewing on behalf of eduardo-vp June 17, 2026 02:56 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs Outdated

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs Outdated

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs Outdated

Apply suggestions from code review
a2ec2a0
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

CopilotAI review requested due to automatic review settings June 17, 2026 19:12

Copilotstarted reviewing on behalf of eduardo-vp June 17, 2026 19:12 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

jkotas approved these changes Jun 18, 2026
View reviewed changes

eduardo-vp merged commit d50582a into dotnet:mainJun 18, 2026
204 of 211 checks passed

dotnet-maestroBot mentioned this pull request Jun 18, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7280
Merged

dotnet-milestone-botBot added this to the 11.0-preview6 milestone Jun 18, 2026

github-actionsBot locked and limited conversation to collaborators Jul 19, 2026

	publicstaticCultureInfoInvariantCulture
	{
	get
	{
	Debug.Assert(s_InvariantCultureInfo!=null,"[CultureInfo.InvariantCulture] s_InvariantCultureInfo is null");
	returns_InvariantCultureInfo;
	}
	}

Uh oh!

Conversation

eduardo-vp commented Jun 9, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

eduardo-vp commented Jun 9, 2026

Uh oh!

azure-pipelinesBot commented Jun 9, 2026

Uh oh!

eduardo-vp commented Jun 9, 2026

Uh oh!

azure-pipelinesBot commented Jun 9, 2026

Uh oh!

eduardo-vp commented Jun 10, 2026

Uh oh!

azure-pipelinesBot commented Jun 10, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

eduardo-vp commented Jun 10, 2026

Uh oh!

azure-pipelinesBot commented Jun 10, 2026

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

eduardo-vp commented Jun 17, 2026

Uh oh!

azure-pipelinesBot commented Jun 17, 2026

Uh oh!

eduardo-vp commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants