Skip to content

[wasm] Delete obsolete wasm console templates and related WASI build tests - #129232

Merged
maraf merged 8 commits into
mainfrom
copilot/delete-wasm-console-templates
Jun 23, 2026
Merged

[wasm] Delete obsolete wasm console templates and related WASI build tests#129232
maraf merged 8 commits into
mainfrom
copilot/delete-wasm-console-templates

Conversation

CopilotAI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

This removes the obsolete wasmconsole and wasiconsole templates and deletes the WASI build-test coverage that existed only to exercise them. The remaining WASM/WASI wiring is updated to reflect the reduced template surface.

  • Template removal

    • Deletes src/mono/wasm/templates/templates/console
    • Deletes src/mono/wasm/templates/templates/wasi-console
  • Test and build cleanup

    • Deletes src/mono/wasi/Wasi.Build.Tests
    • Removes WASI build-test project references and solution entries
    • Clears the WASI build-app job list now that the template-driven test assembly is gone
  • Follow-up reference updates

    • Renames the default WASI runtimeconfig template file to remove the old wasiconsole naming
    • Updates docs and internal comments to describe the remaining browser template accurately
    • Removes stale WASI-template references from path evaluation and shared test helpers

Closes#127822
Closes#102743
Closes#95401

Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
CopilotAI requested review from Copilot and removed request for CopilotJune 10, 2026 12:11
CopilotAI changed the title Delete obsolete wasm console templates and wasi build testsDelete obsolete wasm console templates and related WASI build testsJun 10, 2026
CopilotAI requested a review from marafJune 10, 2026 12:11
@marafmaraf changed the title Delete obsolete wasm console templates and related WASI build tests[wasm] Delete obsolete wasm console templates and related WASI build testsJun 10, 2026
@marafmaraf added arch-wasm WebAssembly architecture os-wasi Related to WASI variant of arch-wasm os-browser Browser variant of arch-wasm labels Jun 10, 2026
@marafmaraf added this to the 11.0.0 milestone Jun 10, 2026
Update PackageFile to reference wasi.runtimeconfig.template.json after the rename from wasiconsole.runtimeconfig.template.json.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 16, 2026 09:53

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete wasmconsole and wasiconsole/WASI console template surface from the mono wasm template pack, and deletes the WASI build-test project that primarily existed to exercise those templates. Updates remaining WASM/WASI build wiring and documentation to reflect the reduced template/test surface.

Changes:

  • Delete the legacy wasm console templates (console, wasi-console) and their template metadata/files.
  • Remove src/mono/wasi/Wasi.Build.Tests and all associated solution/build references.
  • Update remaining WASM/WASI wiring (default runtimeconfig template name, path filters, docs, and small test infra cleanups).

Reviewed changes

Copilot reviewed 44 out of 45 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csprojRemoves stale comment reference to now-deleted WASI build tests.
src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.csUpdates XML doc comment to reflect only the browser template remains.
src/mono/wasm/Wasm.Build.Tests/Common/Template.csRemoves Wasi template enum value to match reduced template surface.
src/mono/wasm/Wasm.Build.Tests/BrowserStructures/SharedBuildPerTestClassFixture.csUpdates TODO comment wording (now broader than WASI).
src/mono/wasm/templates/templates/wasi-console/wasi-console.0.csprojRemoved obsolete WASI console template project file.
src/mono/wasm/templates/templates/wasi-console/README.mdRemoved obsolete WASI console template README.
src/mono/wasm/templates/templates/wasi-console/Properties/AssemblyInfo.csRemoved obsolete WASI console template assembly attribute file.
src/mono/wasm/templates/templates/wasi-console/Program.csRemoved obsolete WASI console template program stub.
src/mono/wasm/templates/templates/wasi-console/.template.config/template.jsonRemoved obsolete WASI console template definition.
src/mono/wasm/templates/templates/console/runtimeconfig.template.jsonRemoved obsolete wasm console runtimeconfig template.
src/mono/wasm/templates/templates/console/README.mdRemoved obsolete wasm console template README.
src/mono/wasm/templates/templates/console/Properties/AssemblyInfo.csRemoved obsolete wasm console template assembly attribute file.
src/mono/wasm/templates/templates/console/Program.csRemoved obsolete wasm console template program stub.
src/mono/wasm/templates/templates/console/main.mjsRemoved obsolete wasm console template JS host file.
src/mono/wasm/templates/templates/console/console.0.csprojRemoved obsolete wasm console template project file.
src/mono/wasm/templates/templates/console/.template.config/template.jsonRemoved obsolete wasm console template definition.
src/mono/wasm/sln/WasmBuild.slnxDrops the removed Wasi.Build.Tests project from the wasm solution.
src/mono/wasi/Wasi.Build.Tests/WasiTemplateTests.csRemoved WASI template-driven build/run tests.
src/mono/wasi/Wasi.Build.Tests/WasiLibraryModeTests.csRemoved WASI library-mode build tests.
src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csprojRemoved WASI build test project file and related test infra wiring.
src/mono/wasi/Wasi.Build.Tests/SharedBuildPerTestClassFixture.csRemoved duplicated fixture from deleted WASI test project.
src/mono/wasi/Wasi.Build.Tests/SdkMissingTests.csRemoved WASI “SDK missing” scenario tests tied to template-driven builds.
src/mono/wasi/Wasi.Build.Tests/RuntimeConfigTests.csRemoved WASI runtimeconfig template test tied to template project layout.
src/mono/wasi/Wasi.Build.Tests/README.mdRemoved WASI build tests documentation.
src/mono/wasi/Wasi.Build.Tests/PInvokeTableGeneratorTests.csRemoved WASI P/Invoke table generator test tied to template project.
src/mono/wasi/Wasi.Build.Tests/InvariantTests.csRemoved WASI invariant globalization/timezone tests tied to template project.
src/mono/wasi/Wasi.Build.Tests/ILStripTests.csRemoved WASI IL strip tests tied to template project.
src/mono/wasi/Wasi.Build.Tests/HttpTests.csRemoved WASI HTTP sample build/run tests tied to template project.
src/mono/wasi/Wasi.Build.Tests/Directory.Build.targetsRemoved WASI build-tests-specific targets file.
src/mono/wasi/Wasi.Build.Tests/Directory.Build.propsRemoved WASI build-tests-specific props file.
src/mono/wasi/Wasi.Build.Tests/data/Workloads.Directory.Build.targetsRemoved workload-mode build-test targets file.
src/mono/wasi/Wasi.Build.Tests/data/Workloads.Directory.Build.propsRemoved workload-mode build-test props file.
src/mono/wasi/Wasi.Build.Tests/data/Local.Directory.Build.targetsRemoved local-mode build-test targets file.
src/mono/wasi/Wasi.Build.Tests/data/Local.Directory.Build.propsRemoved local-mode build-test props file.
src/mono/wasi/Wasi.Build.Tests/BuildTestBase.csRemoved WASI build-test base implementation (template-driven).
src/mono/wasi/Wasi.Build.Tests/BuildPublishTests.csRemoved WASI build/publish coverage that was template-driven.
src/mono/wasi/README.mdUpdates WASI docs to remove template usage guidance and point to samples/manual authoring.
src/mono/wasi/build/WasiApp.targetsRenames default runtimeconfig template reference to the new file name.
src/mono/wasi/build/wasi.runtimeconfig.template.jsonAdds the renamed default WASI runtimeconfig template file.
src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk.pkgprojUpdates package content to include the renamed runtimeconfig template.
src/mono/browser/README.mdUpdates template docs to describe only wasmbrowser remaining.
src/libraries/tests.projRemoves WASI build test project reference from libraries test orchestration.
eng/testing/scenarios/BuildWasiAppsJobsList.txtClears the WASI build-app job list now that the template-driven test assembly is removed.
eng/pipelines/common/evaluate-default-paths.ymlRemoves Wasi.Build.Tests from WASM path evaluation subsets and updates comment text accordingly.
docs/workflow/wasm-documentation.mdUpdates guidance to use Wasm.Build.Tests for browser and samples for WASI validation.

@maraf
maraf marked this pull request as ready for review June 16, 2026 10:02
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 16, 2026 10:03

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 44 out of 45 changed files in this pull request and generated 1 comment.

Comment threadeng/pipelines/common/evaluate-default-paths.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 16, 2026 10:09

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 44 out of 45 changed files in this pull request and generated 1 comment.

Comment threadsrc/mono/wasi/README.md
Remove run-build-tests and submit-wbt-helix targets that reference the deleted Wasi.Build.Tests project.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CopilotAI review requested due to automatic review settings June 18, 2026 12:12

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 45 out of 46 changed files in this pull request and generated 1 comment.

Comment threadsrc/mono/wasi/README.md
@maraf

Copy link
Copy Markdown
Member

/ba-g WBT failure is an unrelated process crash

@maraf
maraf merged commit 34103fc into mainJun 23, 2026
133 of 137 checks passed
@maraf
maraf deleted the copilot/delete-wasm-console-templates branch June 23, 2026 08:43
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
…tests (#129232)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 24, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasmos-wasiRelated to WASI variant of arch-wasm

Projects

None yet

4 participants

@maraf@pavelsavara