Uh oh!
There was an error while loading. Please reload this page.
[cdac] Run DataGenerator tests in CI alongside cDAC unit tests - #129238
Closed
max-charlamb wants to merge 1 commit into
Closed
[cdac] Run DataGenerator tests in CI alongside cDAC unit tests#129238max-charlamb wants to merge 1 commit into
max-charlamb wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the dotnet/runtime build subset infrastructure to include the cDAC DataGenerator test project, and wires that new subset into the existing CLR_Tools_Tests CI leg so these tests run in the same lane as the existing cDAC unit tests.
Changes:
- Add a new build subset
tools.cdacdatageneratorteststhat builds/runs the DataGenerator test project. - Include
tools.cdacdatageneratortestsinAllSubsetsExpansion. - Update
CLR_Tools_Testsbuild args ineng/pipelines/runtime.ymlto run the new subset in CI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/Subsets.props | Adds the tools.cdacdatageneratortests subset and a ProjectToBuild entry for the DataGenerator tests. |
| eng/pipelines/runtime.yml | Extends the CLR_Tools_Tests CI buildArgs to include the new subset. |
Comment on lines
+544
to
+546
| <ItemGroup Condition="$(_subset.Contains('+tools.cdacdatageneratortests+'))"> | ||
| <ProjectToBuild Include="$(SharedNativeRoot)managed\cdac\tests\DataGenerator\Microsoft.Diagnostics.DataContractReader.DataGeneratorTests.csproj" Test="true" Category="tools"/> | ||
| </ItemGroup> |
max-charlambforce-pushed
the
cdac-datagenerator-tests-ci
branch
from
June 10, 2026 15:16
aeab1b4 to
c657933Compare
…ests subset The DataGeneratorTests project (cdac/tests/DataGenerator/) had no subset and was not built or executed in CI. Add it to the existing tools.cdactests subset (which already builds the cDAC UnitTests project) so the DataGenerator tests run on the existing CLR_Tools_Tests CI leg with no separate subset or extra wiring elsewhere. Also override the new Target.ReadNInt abstract method (added in e9e3c8d) on the test-only TestTarget mock so the project compiles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
max-charlambforce-pushed
the
cdac-datagenerator-tests-ci
branch
from
June 10, 2026 15:18
c657933 to
70960fbComparemax-charlamb
commented
Jun 10, 2026
MemberAuthor
Closing -- per discussion, cDAC unit tests + DataGenerator tests should run inside the runtime-diagnostics pipeline rather than main runtime.yml. Rerouting in #129237 or a follow-up. |
Comment on lines
+202
to
+203
| public override TargetNInt ReadNInt(ulong address) | ||
| => new TargetNInt(PointerSize == 8 ? Read<long>(address) : Read<int>(address)); |
Comment on lines
532
to
535
| <ItemGroup Condition="$(_subset.Contains('+tools.cdactests+'))"> | ||
| <ProjectToBuild Include="$(SharedNativeRoot)managed\cdac\tests\UnitTests\Microsoft.Diagnostics.DataContractReader.Tests.csproj" Test="true" Category="tools"/> | ||
| <ProjectToBuild Include="$(SharedNativeRoot)managed\cdac\tests\DataGenerator\Microsoft.Diagnostics.DataContractReader.DataGeneratorTests.csproj" Test="true" Category="tools"/> | ||
| </ItemGroup> |
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was prepared with assistance from GitHub Copilot CLI.
Summary
The cDAC repo has four test projects under
src/native/managed/cdac/tests/:UnitTests/Microsoft.Diagnostics.DataContractReader.Tests.csprojtools.cdactestsCLR_Tools_Tests)DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csprojtools.cdacdumptestsStressTests/Microsoft.Diagnostics.DataContractReader.StressTests.csprojtools.cdacstresstestsDataGenerator/Microsoft.Diagnostics.DataContractReader.DataGeneratorTests.csprojThis PR:
tools.cdacdatageneratortestssubset (mirrors the existingtools.cdac<X>testspattern inSubsets.props).CLR_Tools_TestsCI leg inruntime.ymlso the DataGenerator tests run alongside the cDAC unit tests onlinux_x64 Checkedwhenever coreclr / illink / tools.cdac paths change.No new CI job; tests piggyback on the existing leg.
Files changed
eng/Subsets.props— newtools.cdacdatageneratortestssubset + added toAllSubsetsExpansion.eng/pipelines/runtime.yml— appended+tools.cdacdatageneratorteststo theCLR_Tools_TestsbuildArgs.