JIT: remove getUnboxedEntry and getInstantiatedEntry by hez2010 · Pull Request #129285 · dotnet/runtime

hez2010 · 2026-06-11T12:33:29Z

Cleanup getUnboxedEntry and getInstantiatedEntry and all their usages to make sure we can handle shared generic devirtualization in a uniform manner in the future, once we start seeing combinations of runtime lookups and unboxing stubs.

cc: @jakobbotsch

dotnet-policy-service · 2026-06-11T12:35:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR removes the getUnboxedEntry / getInstantiatedEntry ICorJitInfo host APIs and instead plumbs unboxed-entry information through resolveVirtualMethod, updating the JIT, CoreCLR host, and SuperPMI tooling accordingly.

Changes:

Populate resolvedTokenDevirtualizedUnboxedMethod during devirtualization and update JIT call/unboxing logic to consume it.
Remove getUnboxedEntry and getInstantiatedEntry from the public JIT/EE interface and all generated wrappers/shims.
Update SuperPMI recording/replay infrastructure and bump the JIT/EE versioning GUID.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/jitinterface.cpp	Sets unboxed-entry method handle on devirtualization result.
src/coreclr/inc/corinfo.h	Removes APIs and documents new unboxed resolved-token behavior.
src/coreclr/jit/importercalls.cpp	Switches unboxed-entry transformation logic to use resolved token + signature inspection.
src/coreclr/jit/indirectcalltransformer.cpp	Uses unboxed method handle from resolved token for GDV inline demotion logic.
src/coreclr/jit/inline.h	Removes separate unboxed-entry handle storage; relies on resolved token.
src/coreclr/inc/jiteeversionguid.h	Bumps interface GUID for breaking API change.
src/coreclr/tools/superpmi/**	Removes the two API calls from interception/record/replay and related packet definitions.
src/coreclr/tools/aot/jitinterface/jitinterface_generated.h	Removes callbacks/wrapper methods for the deleted APIs.
src/coreclr/tools/Common/JitInterface/*	Updates thunk generator inputs and managed interop to drop deleted APIs.

hez2010 · 2026-06-12T01:26:20Z

@jakobbotsch CI seems passing, but I guess this will need a pri1 test run to exercise more coverages.

hez2010 · 2026-06-13T04:01:06Z

It seems that spmi gets skipped due to jit-ee interface changes. Trigger a MihuBot to check if it's zero diff.

@MihuBot

hez2010 · 2026-06-13T04:06:39Z

@MihuBot

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

hez2010 · 2026-06-13T06:18:47Z

Zero diff as expected.

hez2010 · 2026-06-18T11:55:24Z

Ping.

jakobbotsch · 2026-06-19T08:30:33Z

so that we no longer need a round-trip between the JIT and EE

I wouldn't say that is the motivation. The main motivation is to make sure we can handle shared generic devirtualization in a uniform manner in the future, once we start seeing combinations of runtime lookups and unboxing stubs.

In general we do not care that much for some extra JIT-EE queries, especially not when it is a result of some real optimization happening.

jakobbotsch

LGTM. Thanks!

jakobbotsch · 2026-06-19T08:43:59Z

/azp run runtime-coreclr outerloop, runtime-coreclr crossgen2, runtime-coreclr crossgen2 outerloop

azure-pipelines · 2026-06-19T08:44:26Z

Azure Pipelines successfully started running 3 pipeline(s).

hez2010 · 2026-06-19T08:46:23Z

so that we no longer need a round-trip between the JIT and EE
I wouldn't say that is the motivation. The main motivation is to make sure we can handle shared generic devirtualization in a uniform manner in the future, once we start seeing combinations of runtime lookups and unboxing stubs.
In general we do not care that much for some extra JIT-EE queries, especially not when it is a result of some real optimization happening.

I've updated the PR description to reflect it.

hez2010 · 2026-06-19T15:40:45Z

Updated the branch to unblock build. @jakobbotsch can you rerun the pri1 tests?

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.

jakobbotsch · 2026-06-19T23:25:34Z

/azp run runtime-coreclr outerloop, runtime-coreclr crossgen2, runtime-coreclr crossgen2 outerloop

azure-pipelines · 2026-06-19T23:25:41Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

jakobbotsch · 2026-06-20T08:14:01Z

/azp run runtime-coreclr outerloop, runtime-coreclr crossgen2, runtime-coreclr crossgen2 outerloop

azure-pipelines · 2026-06-20T08:14:28Z

Azure Pipelines successfully started running 3 pipeline(s).

hez2010 · 2026-06-20T10:50:51Z

All test failures seem to be known.

jakobbotsch · 2026-06-21T20:01:57Z

Can you double check the failure in Test crossgen2-comparison build windows x64 Release for runtime-coreclr crossgen2 outerloop? It looks like running crossgen2 fails on an assembly:

2026-06-20T09:31:31.1171284Z [226:236]: D:\a\_work\1\s\artifacts\bin\crossgen2_inbuild\x64\Release\crossgen2.dll System.Windows.Extensions.dll return code=1 args'D:\a\_work\1\s\dotnet.cmd D:\a\_work\1\s\artifacts\bin\crossgen2_inbuild\x64\Release\crossgen2.dll -r "D:\a\_work\1\s\artifacts\tests\coreclr\windows.x64.Release\Tests\CrossCompileRoot\dlls\*.dll" -O --determinism-stress 6 --map --out D:\a\_work\1\s\artifacts\tests\coreclr\windows.x64.Release\Tests\CrossCompileRoot\log\System.Windows.Extensions.ni.dll --targetos windows --targetarch x64 D:\a\_work\1\s\artifacts\tests\coreclr\windows.x64.Release\Tests\CrossCompileRoot\dlls\System.Windows.Extensions.dll' stdout 'D:\a\_work\1\s\.dotnet

hez2010 · 2026-06-22T01:32:59Z

Can you double check the failure in Test crossgen2-comparison build windows x64 Release for runtime-coreclr crossgen2 outerloop? It looks like running crossgen2 fails on an assembly:

2026-06-20T09:31:31.1171284Z [226:236]: D:\a\_work\1\s\artifacts\bin\crossgen2_inbuild\x64\Release\crossgen2.dll System.Windows.Extensions.dll return code=1 args'D:\a\_work\1\s\dotnet.cmd D:\a\_work\1\s\artifacts\bin\crossgen2_inbuild\x64\Release\crossgen2.dll -r "D:\a\_work\1\s\artifacts\tests\coreclr\windows.x64.Release\Tests\CrossCompileRoot\dlls\*.dll" -O --determinism-stress 6 --map --out D:\a\_work\1\s\artifacts\tests\coreclr\windows.x64.Release\Tests\CrossCompileRoot\log\System.Windows.Extensions.ni.dll --targetos windows --targetarch x64 D:\a\_work\1\s\artifacts\tests\coreclr\windows.x64.Release\Tests\CrossCompileRoot\dlls\System.Windows.Extensions.dll' stdout 'D:\a\_work\1\s\.dotnet

I'm not able to reproduce this build failure in my local environment. I downloaded the artifacts produced by the CI and run crossgen2 with

-r D:\source\repos\runtime\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root\*.dll -O --determinism-stress 6 --map --out D:\source\repos\runtime\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root\log\System.Windows.Extensions.ni.dll --targetos windows --targetarch x64 D:\source\repos\runtime\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root\System.Windows.Extensions.dll

and it produced the assembly normally:

Emitting R2R PE file: D:\source\repos\runtime\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root\log\System.Windows.Extensions.ni.dll
Emitting map file: D:\source\repos\runtime\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root\log\System.Windows.Extensions.ni.map

It seems to be a CI lagging?

jakobbotsch · 2026-06-22T14:35:00Z

I will rerun the job, I looked for a while but I could not find any failures similar to that one.

jakobbotsch · 2026-06-22T15:01:04Z

That test succeeded in a rerun. The other failures are #126819 (crossgen2), #122345 (outerloop), #129046 (crossgen2 outerloop)

jakobbotsch · 2026-06-22T15:54:01Z

/ba-g Failures are known or already fixed

Cleanup `getUnboxedEntry` and `getInstantiatedEntry` and all their usages to make sure we can handle shared generic devirtualization in a uniform manner in the future, once we start seeing combinations of runtime lookups and unboxing stubs.

Cleanup getUnboxedEntry and getInstantiatedEntry
fe25211

CopilotAI review requested due to automatic review settings June 11, 2026 12:33

hez2010 requested a review from MichalStrehovsky as a code owner June 11, 2026 12:33

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 11, 2026

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jun 11, 2026

CopilotAI reviewed Jun 11, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.cpp
Comment threadsrc/coreclr/jit/importercalls.cpp Outdated
Comment threadsrc/coreclr/tools/superpmi/superpmi-shared/methodcontext.h

Check the context directly
852a572

hez2010 mentioned this pull request Jun 12, 2026
Support devirtualization for virtual methods that require an instantiating stub #128702
Merged

MihuBot mentioned this pull request Jun 13, 2026
[JitDiff X64] [hez2010] JIT: remove getUnboxedEntry and getInstantiatedEntry MihuBot/runtime-utils#1967
Open

Merge branch 'main' into unboxing-stub-cleanup
959ad95

CopilotAI review requested due to automatic review settings June 13, 2026 04:06

MihuBot mentioned this pull request Jun 13, 2026
[JitDiff X64] [hez2010] JIT: remove getUnboxedEntry and getInstantiatedEntry MihuBot/runtime-utils#1968
Open

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.cpp
Comment threadsrc/coreclr/tools/superpmi/superpmi-shared/methodcontext.h
Comment threadsrc/coreclr/tools/superpmi/superpmi-shared/methodcontext.h

This was referenced Jun 13, 2026
Multiple Helix work items fail on maccatalyst/tvos CoreCLR Release #126460
Closed
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed

Merge branch 'main' into unboxing-stub-cleanup
872c5dc

jakobbotsch approved these changes Jun 19, 2026
View reviewed changes

build-analysisBot mentioned this pull request Jun 19, 2026
[ci-scan] Build break: crossgen2-comparison hash mismatch on windows x86 (recurrence) #129603
Closed

Merge branch 'main' into unboxing-stub-cleanup
66f0836

CopilotAI review requested due to automatic review settings June 19, 2026 15:40

Copilotstarted reviewing on behalf of hez2010 June 19, 2026 15:40 View session

CopilotAI reviewed Jun 19, 2026
View reviewed changes

Merge branch 'main' into unboxing-stub-cleanup
272667a

build-analysisBot mentioned this pull request Jun 20, 2026
[ci-scan] Test failure: SystemCoreLibDirectory crashes in R2R_Composite (crossgen2 outerloop) #129046
Closed

jakobbotsch approved these changes Jun 22, 2026
View reviewed changes

jakobbotsch merged commit 1a76761 into dotnet:mainJun 22, 2026
232 of 245 checks passed

dotnet-maestroBot mentioned this pull request Jun 23, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7320
Merged

dotnet-milestone-botBot added this to the 11.0-preview6 milestone Jun 23, 2026

github-actionsBot locked and limited conversation to collaborators Jul 24, 2026

Uh oh!

Conversation

hez2010 commented Jun 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Jun 11, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hez2010 commented Jun 12, 2026

Uh oh!

hez2010 commented Jun 13, 2026

Uh oh!

hez2010 commented Jun 13, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hez2010 commented Jun 13, 2026

Uh oh!

hez2010 commented Jun 18, 2026

Uh oh!

jakobbotsch commented Jun 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakobbotsch left a comment

Choose a reason for hiding this comment

Uh oh!

jakobbotsch commented Jun 19, 2026

Uh oh!

azure-pipelinesBot commented Jun 19, 2026

Uh oh!

hez2010 commented Jun 19, 2026

Uh oh!

hez2010 commented Jun 19, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jakobbotsch commented Jun 19, 2026

Uh oh!

azure-pipelinesBot commented Jun 19, 2026

Uh oh!

jakobbotsch commented Jun 20, 2026

Uh oh!

azure-pipelinesBot commented Jun 20, 2026

Uh oh!

hez2010 commented Jun 20, 2026

Uh oh!

jakobbotsch commented Jun 21, 2026

Uh oh!

hez2010 commented Jun 22, 2026

Uh oh!

jakobbotsch commented Jun 22, 2026

Uh oh!

jakobbotsch commented Jun 22, 2026

Uh oh!

jakobbotsch commented Jun 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hez2010 commented Jun 11, 2026•
edited
Loading

jakobbotsch commented Jun 19, 2026•
edited
Loading

hez2010 commented Jun 19, 2026•
edited
Loading