JIT: Fix managed return value debug info for floating-point returns by tommcdon · Pull Request #129321 · dotnet/runtime

tommcdon · 2026-06-12T12:17:19Z

PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0.

Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister).

Found via Visual Studio testing

PR dotnet#128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-06-12T12:18:25Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates managed call return-value debug-info emission in the JIT so that floating-point return values are reported using the FP-specific location kind (VLT_REG_FP) with the expected 0-based FP register index, enabling the debugger to read the return value from the correct FP register.

Changes:

Emit FP return locations using VLT_REG_FP instead of storeVariableInRegisters(REG_FLOATRET, REG_NA) for non-x86 targets.
Encode the FP register as a 0-based index (REG_FLOATRET - REG_FP_FIRST) for debugger consumption.
Add comments documenting the VLT_REG_FP encoding expectation.

siFillRegisterVarLoc was storing the raw JIT register number (e.g., 32 for XMM0) in vlReg.vlrReg when encoding VLT_REG_FP. The DBI expects a 0-based FP register index and adds the platform-specific base (REGISTER_AMD64_XMM0, REGISTER_ARM64_V0, etc.) when converting to CorDebugRegister. Emit (GetRegNum() - REG_FP_FIRST) so the DBI computes the correct register. Also fix eeDispVar to reconstruct the full register number when displaying VLT_REG_FP entries in JIT dumps, and add genIsValidIntReg asserts to storeVariableInRegisters to catch misuse for non-integer register types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

psiBegProlog was passing XMM/V register numbers through storeVariableInRegisters which unconditionally encodes as VLT_REG (integer register type). Route FP parameters to VLT_REG_FP with a 0-based FP register index instead. For SysV x64 mixed struct passing (GPR + XMM), drop the XMM register from VLT_REG_REG encoding since the debug info protocol cannot represent mixed integer/FP register pairs. Add genIsValidIntReg asserts to storeVariableInRegisters to guard against future misuse with non-integer registers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

…g-info

On Linux x64 (SysV ABI) and RISC-V, structs can be returned in a mix of int and float registers (e.g. ValueTuple<double, int> returns in XMM0 + RAX). The VLT_REG_REG encoding only supports integer registers, so storeVariableInRegisters asserts genIsValidIntReg on these platforms. Skip recording managed return value info for multi-reg returns that involve float registers, since the encoding cannot represent them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

…g-info

Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

tommcdon · 2026-06-18T21:11:09Z

/ba-g issues are unrelated

…129321) PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Found via Visual Studio testing --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… x64 (#129992) Adds managed-return-value (MRV) debug-info encoding for value-class returns that live in two registers. Additionally, this change implements CordbJITILFrame::GetNativeVariable for x86 x87 FP-stack return/local variables (missed scenario from #129321) Fixes#129344 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tommcdon · 2026-06-12T12:17:19Z

PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0.

Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister).

Found via Visual Studio testing

PR dotnet#128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-06-12T12:18:25Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates managed call return-value debug-info emission in the JIT so that floating-point return values are reported using the FP-specific location kind (VLT_REG_FP) with the expected 0-based FP register index, enabling the debugger to read the return value from the correct FP register.

Changes:

Emit FP return locations using VLT_REG_FP instead of storeVariableInRegisters(REG_FLOATRET, REG_NA) for non-x86 targets.
Encode the FP register as a 0-based index (REG_FLOATRET - REG_FP_FIRST) for debugger consumption.
Add comments documenting the VLT_REG_FP encoding expectation.

siFillRegisterVarLoc was storing the raw JIT register number (e.g., 32 for XMM0) in vlReg.vlrReg when encoding VLT_REG_FP. The DBI expects a 0-based FP register index and adds the platform-specific base (REGISTER_AMD64_XMM0, REGISTER_ARM64_V0, etc.) when converting to CorDebugRegister. Emit (GetRegNum() - REG_FP_FIRST) so the DBI computes the correct register. Also fix eeDispVar to reconstruct the full register number when displaying VLT_REG_FP entries in JIT dumps, and add genIsValidIntReg asserts to storeVariableInRegisters to catch misuse for non-integer register types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

psiBegProlog was passing XMM/V register numbers through storeVariableInRegisters which unconditionally encodes as VLT_REG (integer register type). Route FP parameters to VLT_REG_FP with a 0-based FP register index instead. For SysV x64 mixed struct passing (GPR + XMM), drop the XMM register from VLT_REG_REG encoding since the debug info protocol cannot represent mixed integer/FP register pairs. Add genIsValidIntReg asserts to storeVariableInRegisters to guard against future misuse with non-integer registers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

…g-info

On Linux x64 (SysV ABI) and RISC-V, structs can be returned in a mix of int and float registers (e.g. ValueTuple<double, int> returns in XMM0 + RAX). The VLT_REG_REG encoding only supports integer registers, so storeVariableInRegisters asserts genIsValidIntReg on these platforms. Skip recording managed return value info for multi-reg returns that involve float registers, since the encoding cannot represent them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

…g-info

Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

tommcdon · 2026-06-18T21:11:09Z

/ba-g issues are unrelated

…129321) PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Found via Visual Studio testing --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… x64 (#129992) Adds managed-return-value (MRV) debug-info encoding for value-class returns that live in two registers. Additionally, this change implements CordbJITILFrame::GetNativeVariable for x86 x87 FP-stack return/local variables (missed scenario from #129321) Fixes#129344 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tommcdon · 2026-06-12T12:17:19Z

PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0.

Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister).

Found via Visual Studio testing

PR dotnet#128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-06-12T12:18:25Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates managed call return-value debug-info emission in the JIT so that floating-point return values are reported using the FP-specific location kind (VLT_REG_FP) with the expected 0-based FP register index, enabling the debugger to read the return value from the correct FP register.

Changes:

Emit FP return locations using VLT_REG_FP instead of storeVariableInRegisters(REG_FLOATRET, REG_NA) for non-x86 targets.
Encode the FP register as a 0-based index (REG_FLOATRET - REG_FP_FIRST) for debugger consumption.
Add comments documenting the VLT_REG_FP encoding expectation.

siFillRegisterVarLoc was storing the raw JIT register number (e.g., 32 for XMM0) in vlReg.vlrReg when encoding VLT_REG_FP. The DBI expects a 0-based FP register index and adds the platform-specific base (REGISTER_AMD64_XMM0, REGISTER_ARM64_V0, etc.) when converting to CorDebugRegister. Emit (GetRegNum() - REG_FP_FIRST) so the DBI computes the correct register. Also fix eeDispVar to reconstruct the full register number when displaying VLT_REG_FP entries in JIT dumps, and add genIsValidIntReg asserts to storeVariableInRegisters to catch misuse for non-integer register types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

psiBegProlog was passing XMM/V register numbers through storeVariableInRegisters which unconditionally encodes as VLT_REG (integer register type). Route FP parameters to VLT_REG_FP with a 0-based FP register index instead. For SysV x64 mixed struct passing (GPR + XMM), drop the XMM register from VLT_REG_REG encoding since the debug info protocol cannot represent mixed integer/FP register pairs. Add genIsValidIntReg asserts to storeVariableInRegisters to guard against future misuse with non-integer registers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

…g-info

On Linux x64 (SysV ABI) and RISC-V, structs can be returned in a mix of int and float registers (e.g. ValueTuple<double, int> returns in XMM0 + RAX). The VLT_REG_REG encoding only supports integer registers, so storeVariableInRegisters asserts genIsValidIntReg on these platforms. Skip recording managed return value info for multi-reg returns that involve float registers, since the encoding cannot represent them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

…g-info

Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

tommcdon · 2026-06-18T21:11:09Z

/ba-g issues are unrelated

…129321) PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Found via Visual Studio testing --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… x64 (#129992) Adds managed-return-value (MRV) debug-info encoding for value-class returns that live in two registers. Additionally, this change implements CordbJITILFrame::GetNativeVariable for x86 x87 FP-stack return/local variables (missed scenario from #129321) Fixes#129344 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tommcdon · 2026-06-12T12:17:19Z

PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0.

Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister).

Found via Visual Studio testing

PR dotnet#128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-06-12T12:18:25Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates managed call return-value debug-info emission in the JIT so that floating-point return values are reported using the FP-specific location kind (VLT_REG_FP) with the expected 0-based FP register index, enabling the debugger to read the return value from the correct FP register.

Changes:

Emit FP return locations using VLT_REG_FP instead of storeVariableInRegisters(REG_FLOATRET, REG_NA) for non-x86 targets.
Encode the FP register as a 0-based index (REG_FLOATRET - REG_FP_FIRST) for debugger consumption.
Add comments documenting the VLT_REG_FP encoding expectation.

siFillRegisterVarLoc was storing the raw JIT register number (e.g., 32 for XMM0) in vlReg.vlrReg when encoding VLT_REG_FP. The DBI expects a 0-based FP register index and adds the platform-specific base (REGISTER_AMD64_XMM0, REGISTER_ARM64_V0, etc.) when converting to CorDebugRegister. Emit (GetRegNum() - REG_FP_FIRST) so the DBI computes the correct register. Also fix eeDispVar to reconstruct the full register number when displaying VLT_REG_FP entries in JIT dumps, and add genIsValidIntReg asserts to storeVariableInRegisters to catch misuse for non-integer register types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

psiBegProlog was passing XMM/V register numbers through storeVariableInRegisters which unconditionally encodes as VLT_REG (integer register type). Route FP parameters to VLT_REG_FP with a 0-based FP register index instead. For SysV x64 mixed struct passing (GPR + XMM), drop the XMM register from VLT_REG_REG encoding since the debug info protocol cannot represent mixed integer/FP register pairs. Add genIsValidIntReg asserts to storeVariableInRegisters to guard against future misuse with non-integer registers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

…g-info

On Linux x64 (SysV ABI) and RISC-V, structs can be returned in a mix of int and float registers (e.g. ValueTuple<double, int> returns in XMM0 + RAX). The VLT_REG_REG encoding only supports integer registers, so storeVariableInRegisters asserts genIsValidIntReg on these platforms. Skip recording managed return value info for multi-reg returns that involve float registers, since the encoding cannot represent them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

…g-info

Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

tommcdon · 2026-06-18T21:11:09Z

/ba-g issues are unrelated

…129321) PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Found via Visual Studio testing --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… x64 (#129992) Adds managed-return-value (MRV) debug-info encoding for value-class returns that live in two registers. Additionally, this change implements CordbJITILFrame::GetNativeVariable for x86 x87 FP-stack return/local variables (missed scenario from #129321) Fixes#129344 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tommcdon · 2026-06-12T12:17:19Z

PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0.

Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister).

Found via Visual Studio testing

PR dotnet#128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-06-12T12:18:25Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates managed call return-value debug-info emission in the JIT so that floating-point return values are reported using the FP-specific location kind (VLT_REG_FP) with the expected 0-based FP register index, enabling the debugger to read the return value from the correct FP register.

Changes:

Emit FP return locations using VLT_REG_FP instead of storeVariableInRegisters(REG_FLOATRET, REG_NA) for non-x86 targets.
Encode the FP register as a 0-based index (REG_FLOATRET - REG_FP_FIRST) for debugger consumption.
Add comments documenting the VLT_REG_FP encoding expectation.

siFillRegisterVarLoc was storing the raw JIT register number (e.g., 32 for XMM0) in vlReg.vlrReg when encoding VLT_REG_FP. The DBI expects a 0-based FP register index and adds the platform-specific base (REGISTER_AMD64_XMM0, REGISTER_ARM64_V0, etc.) when converting to CorDebugRegister. Emit (GetRegNum() - REG_FP_FIRST) so the DBI computes the correct register. Also fix eeDispVar to reconstruct the full register number when displaying VLT_REG_FP entries in JIT dumps, and add genIsValidIntReg asserts to storeVariableInRegisters to catch misuse for non-integer register types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

psiBegProlog was passing XMM/V register numbers through storeVariableInRegisters which unconditionally encodes as VLT_REG (integer register type). Route FP parameters to VLT_REG_FP with a 0-based FP register index instead. For SysV x64 mixed struct passing (GPR + XMM), drop the XMM register from VLT_REG_REG encoding since the debug info protocol cannot represent mixed integer/FP register pairs. Add genIsValidIntReg asserts to storeVariableInRegisters to guard against future misuse with non-integer registers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

…g-info

On Linux x64 (SysV ABI) and RISC-V, structs can be returned in a mix of int and float registers (e.g. ValueTuple<double, int> returns in XMM0 + RAX). The VLT_REG_REG encoding only supports integer registers, so storeVariableInRegisters asserts genIsValidIntReg on these platforms. Skip recording managed return value info for multi-reg returns that involve float registers, since the encoding cannot represent them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

…g-info

Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

tommcdon · 2026-06-18T21:11:09Z

/ba-g issues are unrelated

…129321) PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Found via Visual Studio testing --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… x64 (#129992) Adds managed-return-value (MRV) debug-info encoding for value-class returns that live in two registers. Additionally, this change implements CordbJITILFrame::GetNativeVariable for x86 x87 FP-stack return/local variables (missed scenario from #129321) Fixes#129344 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tommcdon · 2026-06-12T12:17:19Z

PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0.

Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister).

Found via Visual Studio testing

PR dotnet#128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-06-12T12:18:25Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates managed call return-value debug-info emission in the JIT so that floating-point return values are reported using the FP-specific location kind (VLT_REG_FP) with the expected 0-based FP register index, enabling the debugger to read the return value from the correct FP register.

Changes:

Emit FP return locations using VLT_REG_FP instead of storeVariableInRegisters(REG_FLOATRET, REG_NA) for non-x86 targets.
Encode the FP register as a 0-based index (REG_FLOATRET - REG_FP_FIRST) for debugger consumption.
Add comments documenting the VLT_REG_FP encoding expectation.

siFillRegisterVarLoc was storing the raw JIT register number (e.g., 32 for XMM0) in vlReg.vlrReg when encoding VLT_REG_FP. The DBI expects a 0-based FP register index and adds the platform-specific base (REGISTER_AMD64_XMM0, REGISTER_ARM64_V0, etc.) when converting to CorDebugRegister. Emit (GetRegNum() - REG_FP_FIRST) so the DBI computes the correct register. Also fix eeDispVar to reconstruct the full register number when displaying VLT_REG_FP entries in JIT dumps, and add genIsValidIntReg asserts to storeVariableInRegisters to catch misuse for non-integer register types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

psiBegProlog was passing XMM/V register numbers through storeVariableInRegisters which unconditionally encodes as VLT_REG (integer register type). Route FP parameters to VLT_REG_FP with a 0-based FP register index instead. For SysV x64 mixed struct passing (GPR + XMM), drop the XMM register from VLT_REG_REG encoding since the debug info protocol cannot represent mixed integer/FP register pairs. Add genIsValidIntReg asserts to storeVariableInRegisters to guard against future misuse with non-integer registers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

…g-info

On Linux x64 (SysV ABI) and RISC-V, structs can be returned in a mix of int and float registers (e.g. ValueTuple<double, int> returns in XMM0 + RAX). The VLT_REG_REG encoding only supports integer registers, so storeVariableInRegisters asserts genIsValidIntReg on these platforms. Skip recording managed return value info for multi-reg returns that involve float registers, since the encoding cannot represent them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

…g-info

Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

tommcdon · 2026-06-18T21:11:09Z

/ba-g issues are unrelated

…129321) PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Found via Visual Studio testing --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… x64 (#129992) Adds managed-return-value (MRV) debug-info encoding for value-class returns that live in two registers. Additionally, this change implements CordbJITILFrame::GetNativeVariable for x86 x87 FP-stack return/local variables (missed scenario from #129321) Fixes#129344 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tommcdon · 2026-06-12T12:17:19Z

PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0.

Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister).

Found via Visual Studio testing

PR dotnet#128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-06-12T12:18:25Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates managed call return-value debug-info emission in the JIT so that floating-point return values are reported using the FP-specific location kind (VLT_REG_FP) with the expected 0-based FP register index, enabling the debugger to read the return value from the correct FP register.

Changes:

Emit FP return locations using VLT_REG_FP instead of storeVariableInRegisters(REG_FLOATRET, REG_NA) for non-x86 targets.
Encode the FP register as a 0-based index (REG_FLOATRET - REG_FP_FIRST) for debugger consumption.
Add comments documenting the VLT_REG_FP encoding expectation.

siFillRegisterVarLoc was storing the raw JIT register number (e.g., 32 for XMM0) in vlReg.vlrReg when encoding VLT_REG_FP. The DBI expects a 0-based FP register index and adds the platform-specific base (REGISTER_AMD64_XMM0, REGISTER_ARM64_V0, etc.) when converting to CorDebugRegister. Emit (GetRegNum() - REG_FP_FIRST) so the DBI computes the correct register. Also fix eeDispVar to reconstruct the full register number when displaying VLT_REG_FP entries in JIT dumps, and add genIsValidIntReg asserts to storeVariableInRegisters to catch misuse for non-integer register types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

psiBegProlog was passing XMM/V register numbers through storeVariableInRegisters which unconditionally encodes as VLT_REG (integer register type). Route FP parameters to VLT_REG_FP with a 0-based FP register index instead. For SysV x64 mixed struct passing (GPR + XMM), drop the XMM register from VLT_REG_REG encoding since the debug info protocol cannot represent mixed integer/FP register pairs. Add genIsValidIntReg asserts to storeVariableInRegisters to guard against future misuse with non-integer registers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

…g-info

On Linux x64 (SysV ABI) and RISC-V, structs can be returned in a mix of int and float registers (e.g. ValueTuple<double, int> returns in XMM0 + RAX). The VLT_REG_REG encoding only supports integer registers, so storeVariableInRegisters asserts genIsValidIntReg on these platforms. Skip recording managed return value info for multi-reg returns that involve float registers, since the encoding cannot represent them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

…g-info

Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

tommcdon · 2026-06-18T21:11:09Z

/ba-g issues are unrelated

…129321) PR #128479 introduced emitting managed return values as native vars but used storeVariableInRegisters(REG_FLOATRET, REG_NA) for float returns, which sets vlType=VLT_REG (integer register). The DBI then fails to read the return value because it looks in an integer register instead of XMM0. Fix by using VLT_REG_FP with a 0-based FP register index, which is what the DBI's VLT_REG_FP handler expects (it adds REGISTER_AMD64_XMM0 to convert to CorDebugRegister). Found via Visual Studio testing --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… x64 (#129992) Adds managed-return-value (MRV) debug-info encoding for value-class returns that live in two registers. Additionally, this change implements CordbJITILFrame::GetNativeVariable for x86 x87 FP-stack return/local variables (missed scenario from #129321) Fixes#129344 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

tommcdon added this to the 11.0.0 milestone Jun 12, 2026

tommcdon requested a review from jakobbotsch June 12, 2026 12:17

tommcdon self-assigned this Jun 12, 2026

CopilotAI review requested due to automatic review settings June 12, 2026 12:17

tommcdon added the area-Diagnostics-coreclr label Jun 12, 2026

Copilotstarted reviewing on behalf of tommcdon June 12, 2026 12:17 View session

CopilotAI reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

steveisok approved these changes Jun 12, 2026
View reviewed changes

tannergooding reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

tommcdon mentioned this pull request Jun 12, 2026
Managed Return Value debug info cannot encode multi-register floating-point return values #129344
Closed

tommcdon enabled auto-merge (squash) June 12, 2026 19:52

jakobbotsch approved these changes Jun 12, 2026
View reviewed changes

tommcdon disabled auto-merge June 12, 2026 20:22

tommcdon enabled auto-merge (squash) June 12, 2026 20:28

tommcdon disabled auto-merge June 13, 2026 01:33

CopilotAI review requested due to automatic review settings June 13, 2026 03:06

Copilotstarted reviewing on behalf of tommcdon June 13, 2026 03:06 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp

build-analysisBot mentioned this pull request Jun 13, 2026
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
4cb51e1
…g-info

tommcdon enabled auto-merge (squash) June 17, 2026 15:06

jakobbotsch approved these changes Jun 17, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings June 17, 2026 21:43

Copilotstarted reviewing on behalf of tommcdon June 17, 2026 21:44 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp

tommcdonand others added 2 commits June 18, 2026 04:27

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
72b31e3
…g-info

Add TODO comments linking to tracking issuedotnet#129344
b2720a8
Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings June 18, 2026 14:06

Copilotstarted reviewing on behalf of tommcdon June 18, 2026 14:06 View session

rcj1 approved these changes Jun 18, 2026
View reviewed changes

CopilotAI reviewed Jun 18, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jakobbotsch approved these changes Jun 18, 2026
View reviewed changes

tommcdon merged commit b9d5c9f into dotnet:mainJun 18, 2026
110 of 128 checks passed

dotnet-maestroBot mentioned this pull request Jun 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7293
Merged

dotnet-milestone-botBot modified the milestones: 11.0.0, 11.0-preview6 Jun 19, 2026

tommcdon mentioned this pull request Jun 29, 2026
Add MRV debug info for multi-register FP/mixed struct returns on Unix x64 #129992
Merged

github-actionsBot locked and limited conversation to collaborators Jul 20, 2026

tommcdon added this to the 11.0.0 milestone Jun 12, 2026

tommcdon requested a review from jakobbotsch June 12, 2026 12:17

tommcdon self-assigned this Jun 12, 2026

CopilotAI review requested due to automatic review settings June 12, 2026 12:17

tommcdon added the area-Diagnostics-coreclr label Jun 12, 2026

Copilotstarted reviewing on behalf of tommcdon June 12, 2026 12:17 View session

CopilotAI reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

steveisok approved these changes Jun 12, 2026
View reviewed changes

tannergooding reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

tommcdon mentioned this pull request Jun 12, 2026
Managed Return Value debug info cannot encode multi-register floating-point return values #129344
Closed

tommcdon enabled auto-merge (squash) June 12, 2026 19:52

jakobbotsch approved these changes Jun 12, 2026
View reviewed changes

tommcdon disabled auto-merge June 12, 2026 20:22

tommcdon enabled auto-merge (squash) June 12, 2026 20:28

tommcdon disabled auto-merge June 13, 2026 01:33

CopilotAI review requested due to automatic review settings June 13, 2026 03:06

Copilotstarted reviewing on behalf of tommcdon June 13, 2026 03:06 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp

build-analysisBot mentioned this pull request Jun 13, 2026
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
4cb51e1
…g-info

tommcdon enabled auto-merge (squash) June 17, 2026 15:06

jakobbotsch approved these changes Jun 17, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings June 17, 2026 21:43

Copilotstarted reviewing on behalf of tommcdon June 17, 2026 21:44 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp

tommcdonand others added 2 commits June 18, 2026 04:27

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
72b31e3
…g-info

Add TODO comments linking to tracking issuedotnet#129344
b2720a8
Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings June 18, 2026 14:06

Copilotstarted reviewing on behalf of tommcdon June 18, 2026 14:06 View session

rcj1 approved these changes Jun 18, 2026
View reviewed changes

CopilotAI reviewed Jun 18, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jakobbotsch approved these changes Jun 18, 2026
View reviewed changes

tommcdon merged commit b9d5c9f into dotnet:mainJun 18, 2026
110 of 128 checks passed

dotnet-maestroBot mentioned this pull request Jun 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7293
Merged

dotnet-milestone-botBot modified the milestones: 11.0.0, 11.0-preview6 Jun 19, 2026

tommcdon mentioned this pull request Jun 29, 2026
Add MRV debug info for multi-register FP/mixed struct returns on Unix x64 #129992
Merged

github-actionsBot locked and limited conversation to collaborators Jul 20, 2026

tommcdon added this to the 11.0.0 milestone Jun 12, 2026

tommcdon requested a review from jakobbotsch June 12, 2026 12:17

tommcdon self-assigned this Jun 12, 2026

CopilotAI review requested due to automatic review settings June 12, 2026 12:17

tommcdon added the area-Diagnostics-coreclr label Jun 12, 2026

Copilotstarted reviewing on behalf of tommcdon June 12, 2026 12:17 View session

CopilotAI reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

steveisok approved these changes Jun 12, 2026
View reviewed changes

tannergooding reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

tommcdon mentioned this pull request Jun 12, 2026
Managed Return Value debug info cannot encode multi-register floating-point return values #129344
Closed

tommcdon enabled auto-merge (squash) June 12, 2026 19:52

jakobbotsch approved these changes Jun 12, 2026
View reviewed changes

tommcdon disabled auto-merge June 12, 2026 20:22

tommcdon enabled auto-merge (squash) June 12, 2026 20:28

tommcdon disabled auto-merge June 13, 2026 01:33

CopilotAI review requested due to automatic review settings June 13, 2026 03:06

Copilotstarted reviewing on behalf of tommcdon June 13, 2026 03:06 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp

build-analysisBot mentioned this pull request Jun 13, 2026
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
4cb51e1
…g-info

tommcdon enabled auto-merge (squash) June 17, 2026 15:06

jakobbotsch approved these changes Jun 17, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings June 17, 2026 21:43

Copilotstarted reviewing on behalf of tommcdon June 17, 2026 21:44 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp

tommcdonand others added 2 commits June 18, 2026 04:27

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
72b31e3
…g-info

Add TODO comments linking to tracking issuedotnet#129344
b2720a8
Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings June 18, 2026 14:06

Copilotstarted reviewing on behalf of tommcdon June 18, 2026 14:06 View session

rcj1 approved these changes Jun 18, 2026
View reviewed changes

CopilotAI reviewed Jun 18, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jakobbotsch approved these changes Jun 18, 2026
View reviewed changes

tommcdon merged commit b9d5c9f into dotnet:mainJun 18, 2026
110 of 128 checks passed

dotnet-maestroBot mentioned this pull request Jun 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7293
Merged

dotnet-milestone-botBot modified the milestones: 11.0.0, 11.0-preview6 Jun 19, 2026

tommcdon mentioned this pull request Jun 29, 2026
Add MRV debug info for multi-register FP/mixed struct returns on Unix x64 #129992
Merged

github-actionsBot locked and limited conversation to collaborators Jul 20, 2026

tommcdon added this to the 11.0.0 milestone Jun 12, 2026

tommcdon requested a review from jakobbotsch June 12, 2026 12:17

tommcdon self-assigned this Jun 12, 2026

CopilotAI review requested due to automatic review settings June 12, 2026 12:17

tommcdon added the area-Diagnostics-coreclr label Jun 12, 2026

Copilotstarted reviewing on behalf of tommcdon June 12, 2026 12:17 View session

CopilotAI reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

steveisok approved these changes Jun 12, 2026
View reviewed changes

tannergooding reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

tommcdon mentioned this pull request Jun 12, 2026
Managed Return Value debug info cannot encode multi-register floating-point return values #129344
Closed

tommcdon enabled auto-merge (squash) June 12, 2026 19:52

jakobbotsch approved these changes Jun 12, 2026
View reviewed changes

tommcdon disabled auto-merge June 12, 2026 20:22

tommcdon enabled auto-merge (squash) June 12, 2026 20:28

tommcdon disabled auto-merge June 13, 2026 01:33

CopilotAI review requested due to automatic review settings June 13, 2026 03:06

Copilotstarted reviewing on behalf of tommcdon June 13, 2026 03:06 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp

build-analysisBot mentioned this pull request Jun 13, 2026
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
4cb51e1
…g-info

tommcdon enabled auto-merge (squash) June 17, 2026 15:06

jakobbotsch approved these changes Jun 17, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings June 17, 2026 21:43

Copilotstarted reviewing on behalf of tommcdon June 17, 2026 21:44 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp

tommcdonand others added 2 commits June 18, 2026 04:27

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
72b31e3
…g-info

Add TODO comments linking to tracking issuedotnet#129344
b2720a8
Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings June 18, 2026 14:06

Copilotstarted reviewing on behalf of tommcdon June 18, 2026 14:06 View session

rcj1 approved these changes Jun 18, 2026
View reviewed changes

CopilotAI reviewed Jun 18, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jakobbotsch approved these changes Jun 18, 2026
View reviewed changes

tommcdon merged commit b9d5c9f into dotnet:mainJun 18, 2026
110 of 128 checks passed

dotnet-maestroBot mentioned this pull request Jun 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7293
Merged

dotnet-milestone-botBot modified the milestones: 11.0.0, 11.0-preview6 Jun 19, 2026

tommcdon mentioned this pull request Jun 29, 2026
Add MRV debug info for multi-register FP/mixed struct returns on Unix x64 #129992
Merged

github-actionsBot locked and limited conversation to collaborators Jul 20, 2026

tommcdon added this to the 11.0.0 milestone Jun 12, 2026

tommcdon requested a review from jakobbotsch June 12, 2026 12:17

tommcdon self-assigned this Jun 12, 2026

CopilotAI review requested due to automatic review settings June 12, 2026 12:17

tommcdon added the area-Diagnostics-coreclr label Jun 12, 2026

Copilotstarted reviewing on behalf of tommcdon June 12, 2026 12:17 View session

CopilotAI reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

steveisok approved these changes Jun 12, 2026
View reviewed changes

tannergooding reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

tommcdon mentioned this pull request Jun 12, 2026
Managed Return Value debug info cannot encode multi-register floating-point return values #129344
Closed

tommcdon enabled auto-merge (squash) June 12, 2026 19:52

jakobbotsch approved these changes Jun 12, 2026
View reviewed changes

tommcdon disabled auto-merge June 12, 2026 20:22

tommcdon enabled auto-merge (squash) June 12, 2026 20:28

tommcdon disabled auto-merge June 13, 2026 01:33

CopilotAI review requested due to automatic review settings June 13, 2026 03:06

Copilotstarted reviewing on behalf of tommcdon June 13, 2026 03:06 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp

build-analysisBot mentioned this pull request Jun 13, 2026
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
4cb51e1
…g-info

tommcdon enabled auto-merge (squash) June 17, 2026 15:06

jakobbotsch approved these changes Jun 17, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings June 17, 2026 21:43

Copilotstarted reviewing on behalf of tommcdon June 17, 2026 21:44 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp

tommcdonand others added 2 commits June 18, 2026 04:27

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
72b31e3
…g-info

Add TODO comments linking to tracking issuedotnet#129344
b2720a8
Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings June 18, 2026 14:06

Copilotstarted reviewing on behalf of tommcdon June 18, 2026 14:06 View session

rcj1 approved these changes Jun 18, 2026
View reviewed changes

CopilotAI reviewed Jun 18, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jakobbotsch approved these changes Jun 18, 2026
View reviewed changes

tommcdon merged commit b9d5c9f into dotnet:mainJun 18, 2026
110 of 128 checks passed

dotnet-maestroBot mentioned this pull request Jun 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7293
Merged

dotnet-milestone-botBot modified the milestones: 11.0.0, 11.0-preview6 Jun 19, 2026

tommcdon mentioned this pull request Jun 29, 2026
Add MRV debug info for multi-register FP/mixed struct returns on Unix x64 #129992
Merged

github-actionsBot locked and limited conversation to collaborators Jul 20, 2026

tommcdon added this to the 11.0.0 milestone Jun 12, 2026

tommcdon requested a review from jakobbotsch June 12, 2026 12:17

tommcdon self-assigned this Jun 12, 2026

CopilotAI review requested due to automatic review settings June 12, 2026 12:17

tommcdon added the area-Diagnostics-coreclr label Jun 12, 2026

Copilotstarted reviewing on behalf of tommcdon June 12, 2026 12:17 View session

CopilotAI reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

steveisok approved these changes Jun 12, 2026
View reviewed changes

tannergooding reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

tommcdon mentioned this pull request Jun 12, 2026
Managed Return Value debug info cannot encode multi-register floating-point return values #129344
Closed

tommcdon enabled auto-merge (squash) June 12, 2026 19:52

jakobbotsch approved these changes Jun 12, 2026
View reviewed changes

tommcdon disabled auto-merge June 12, 2026 20:22

tommcdon enabled auto-merge (squash) June 12, 2026 20:28

tommcdon disabled auto-merge June 13, 2026 01:33

CopilotAI review requested due to automatic review settings June 13, 2026 03:06

Copilotstarted reviewing on behalf of tommcdon June 13, 2026 03:06 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp

build-analysisBot mentioned this pull request Jun 13, 2026
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
4cb51e1
…g-info

tommcdon enabled auto-merge (squash) June 17, 2026 15:06

jakobbotsch approved these changes Jun 17, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings June 17, 2026 21:43

Copilotstarted reviewing on behalf of tommcdon June 17, 2026 21:44 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp

tommcdonand others added 2 commits June 18, 2026 04:27

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
72b31e3
…g-info

Add TODO comments linking to tracking issuedotnet#129344
b2720a8
Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings June 18, 2026 14:06

Copilotstarted reviewing on behalf of tommcdon June 18, 2026 14:06 View session

rcj1 approved these changes Jun 18, 2026
View reviewed changes

CopilotAI reviewed Jun 18, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jakobbotsch approved these changes Jun 18, 2026
View reviewed changes

tommcdon merged commit b9d5c9f into dotnet:mainJun 18, 2026
110 of 128 checks passed

dotnet-maestroBot mentioned this pull request Jun 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7293
Merged

dotnet-milestone-botBot modified the milestones: 11.0.0, 11.0-preview6 Jun 19, 2026

tommcdon mentioned this pull request Jun 29, 2026
Add MRV debug info for multi-register FP/mixed struct returns on Unix x64 #129992
Merged

github-actionsBot locked and limited conversation to collaborators Jul 20, 2026

tommcdon added this to the 11.0.0 milestone Jun 12, 2026

tommcdon requested a review from jakobbotsch June 12, 2026 12:17

tommcdon self-assigned this Jun 12, 2026

CopilotAI review requested due to automatic review settings June 12, 2026 12:17

tommcdon added the area-Diagnostics-coreclr label Jun 12, 2026

Copilotstarted reviewing on behalf of tommcdon June 12, 2026 12:17 View session

CopilotAI reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

steveisok approved these changes Jun 12, 2026
View reviewed changes

tannergooding reviewed Jun 12, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

tommcdon mentioned this pull request Jun 12, 2026
Managed Return Value debug info cannot encode multi-register floating-point return values #129344
Closed

tommcdon enabled auto-merge (squash) June 12, 2026 19:52

jakobbotsch approved these changes Jun 12, 2026
View reviewed changes

tommcdon disabled auto-merge June 12, 2026 20:22

tommcdon enabled auto-merge (squash) June 12, 2026 20:28

tommcdon disabled auto-merge June 13, 2026 01:33

CopilotAI review requested due to automatic review settings June 13, 2026 03:06

Copilotstarted reviewing on behalf of tommcdon June 13, 2026 03:06 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp

build-analysisBot mentioned this pull request Jun 13, 2026
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
4cb51e1
…g-info

tommcdon enabled auto-merge (squash) June 17, 2026 15:06

jakobbotsch approved these changes Jun 17, 2026
View reviewed changes

CopilotAI review requested due to automatic review settings June 17, 2026 21:43

Copilotstarted reviewing on behalf of tommcdon June 17, 2026 21:44 View session

CopilotAI reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/codegencommon.cpp

jkotas reviewed Jun 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp

tommcdonand others added 2 commits June 18, 2026 04:27

Merge branch 'main' into dev/tommcdon/fix-mrv-float-return-value-debu…
72b31e3
…g-info

Add TODO comments linking to tracking issuedotnet#129344
b2720a8
Add references to dotnet#129344 at both locations where mixed int/float multi-reg returns are unsupported in VarLoc encoding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings June 18, 2026 14:06

Copilotstarted reviewing on behalf of tommcdon June 18, 2026 14:06 View session

rcj1 approved these changes Jun 18, 2026
View reviewed changes

CopilotAI reviewed Jun 18, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/scopeinfo.cpp
Comment threadsrc/coreclr/jit/codegencommon.cpp

jakobbotsch approved these changes Jun 18, 2026
View reviewed changes

tommcdon merged commit b9d5c9f into dotnet:mainJun 18, 2026
110 of 128 checks passed

dotnet-maestroBot mentioned this pull request Jun 19, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7293
Merged

dotnet-milestone-botBot modified the milestones: 11.0.0, 11.0-preview6 Jun 19, 2026

tommcdon mentioned this pull request Jun 29, 2026
Add MRV debug info for multi-register FP/mixed struct returns on Unix x64 #129992
Merged

github-actionsBot locked and limited conversation to collaborators Jul 20, 2026

Uh oh!

Conversation

tommcdon commented Jun 12, 2026

Uh oh!

dotnet-policy-serviceBot commented Jun 12, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tommcdon commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

tommcdon commented Jun 12, 2026

Uh oh!

dotnet-policy-serviceBot commented Jun 12, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment