Skip to content

Fix illumox-x64 build with gcc and clang - #129322

Merged
janvorli merged 11 commits into
dotnet:mainfrom
am11:feature/port/illumos-native-build2
Jun 15, 2026
Merged

Fix illumox-x64 build with gcc and clang#129322
janvorli merged 11 commits into
dotnet:mainfrom
am11:feature/port/illumos-native-build2

Conversation

@am11

@am11am11 commented Jun 12, 2026

Copy link
Copy Markdown
Member

First, our default build is failing with solaris gcc 13, so couple of fixes for those are included (jit, gcenv etc.). Then it includes clang fixes.

For the first time, cross building runtime repo for illumos-x64 with llvm-toolchain has succeeded. It has two issues which I've reported upstream with minimal repro and workarounds:

For the first one I am adding a workaround in configurecompiler.cmake (if (CMAKE_C_COMPILER_ID MATCHES "GNU") condition). For the second one the hack goes in toolchain.cmake which I am skipping from this PR as I'm running trials to slim it down a bit (current state: https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).

Together the clang build succeeds on Azure Linux cross environment same as rest of the platforms (freebsd, openbsd, haiku).

Note that the gcc build requires another fix upstream dotnet/dotnet#7206, which I recently broke while fixing sccsid which got broken after we started to use --gc-sections linker option liberally.

@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 12, 2026
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jun 12, 2026
@am11am11 added area-PAL-coreclr only for closed issues os-SunOS SunOS, currently not officially supported and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jun 12, 2026
@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@am11

am11 commented Jun 12, 2026

Copy link
Copy Markdown
MemberAuthor

cc @gwr, @AustinWise, I know you guys were looking for clang-based crossbuild at some point. While working on OpenBSD bringup, I figured some internal things out for illumos.

If someone could take care of llvm side of patching, that would help. 🙂

am11
am11 commented Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
@akoeplinger

akoeplinger commented Jun 12, 2026

Copy link
Copy Markdown
Member

build failure looks related

jakobbotsch
jakobbotsch reviewed Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.h Outdated
janvorli
janvorli reviewed Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Comment threadsrc/native/libs/System.Native/pal_process.c
jakobbotsch
jakobbotsch approved these changes Jun 12, 2026
View reviewed changes

@jakobbotschjakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT part LGTM

janvorli
janvorli reviewed Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_signal.c
This was referenced Jun 13, 2026
Open
Closed
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jun 14, 2026
Closed
@build-analysisbuild-analysisBot mentioned this pull request Jun 14, 2026
Closed
@am11
am11 requested a review from janvorliJune 15, 2026 11:14
@build-analysisbuild-analysisBot mentioned this pull request Jun 15, 2026
Closed
@am11

am11 commented Jun 15, 2026

Copy link
Copy Markdown
MemberAuthor

Windows timeout failures are unrelated to the changes here.

@janvorli

janvorli commented Jun 15, 2026

Copy link
Copy Markdown
Member

/ba-g windows builds timeouts unrelated to this change and seems to happen on multiple PRs.

@janvorli
janvorli merged commit 9ce1cb9 into dotnet:mainJun 15, 2026
199 of 208 checks passed
@am11
am11 deleted the feature/port/illumos-native-build2 branch June 15, 2026 21:56
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jun 16, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview6 milestone Jun 17, 2026
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@am11@eiriktsarpalis
Fix illumox-x64 build with gcc and clang (#129322)
9d53908
First, our default build is failing with solaris gcc 13, so couple of
fixes for those are included (jit, gcenv etc.). Then it includes clang
fixes.
For the first time, cross building runtime repo for illumos-x64 with
llvm-toolchain has succeeded. It has two issues which I've reported
upstream with minimal repro and workarounds:
* llvm assembler (llvm-mc):
llvm/llvm-project#202953
* LLVM linker (lld): llvm/llvm-project#202963
For the first one I am adding a workaround in configurecompiler.cmake
(`if (CMAKE_C_COMPILER_ID MATCHES "GNU")` condition). For the second one
the hack goes in toolchain.cmake which I am skipping from this PR as I'm
running trials to slim it down a bit (current state:
https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same
as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream
dotnet/dotnet#7206, which I recently broke while
fixing sccsid which got broken after we started to use `--gc-sections`
linker option liberally.
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
+1 more reviewer
@gwrgwrgwr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-SunOSSunOS, currently not officially supported

Projects

None yet

Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@am11@akoeplinger@janvorli@gwr@jakobbotsch
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix illumox-x64 build with gcc and clang by am11 · Pull Request #129322 · dotnet/runtime · GitHub
Skip to content
Fix illumox-x64 build with gcc and clang - #129322
Merged
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Jun 15, 2026
Merged
Fix illumox-x64 build with gcc and clang#129322
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Conversation
@am11
@am11am11
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
First, our default build is failing with solaris gcc 13, so couple of fixes for those are included (jit, gcenv etc.). Then it includes clang fixes.
For the first time, cross building runtime repo for illumos-x64 with llvm-toolchain has succeeded. It has two issues which I've reported upstream with minimal repro and workarounds:
For the first one I am adding a workaround in configurecompiler.cmake (if (CMAKE_C_COMPILER_ID MATCHES "GNU") condition). For the second one the hack goes in toolchain.cmake which I am skipping from this PR as I'm running trials to slim it down a bit (current state: https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream dotnet/dotnet#7206, which I recently broke while fixing sccsid which got broken after we started to use --gc-sections linker option liberally.
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 12, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 12, 2026
@am11am11
added

area-PAL-coreclr
only for closed issues
os-SunOS
SunOS, currently not officially supported
and removed

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Jun 12, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@am11
am11
commented
Jun 12, 2026

Copy link


Copy Markdown

MemberAuthor
cc @gwr, @AustinWise, I know you guys were looking for clang-based crossbuild at some point. While working on OpenBSD bringup, I figured some internal things out for illumos.
If someone could take care of llvm side of patching, that would help. 🙂
am11
am11
commented
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
@akoeplinger
akoeplinger
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
build failure looks related
jakobbotsch
jakobbotsch
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.h
Outdated

janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Comment threadsrc/native/libs/System.Native/pal_process.c
jakobbotsch
jakobbotsch
approved these changes
Jun 12, 2026
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT part LGTM
janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_signal.c

This was referenced Jun 13, 2026

Open


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@am11
am11
requested a review
from janvorliJune 15, 2026 11:14
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 15, 2026

Closed

@am11
am11
commented
Jun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Windows timeout failures are unrelated to the changes here.
@janvorli
janvorli
commented
Jun 15, 2026

Copy link


Copy Markdown

Member
/ba-g windows builds timeouts unrelated to this change and seems to happen on multiple PRs.
@janvorli
janvorli
merged commit 9ce1cb9
into
dotnet:mainJun 15, 2026

199 of 208 checks passed

@am11
am11
deleted the

feature/port/illumos-native-build2

branch
June 15, 2026 21:56
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 17, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@am11@eiriktsarpalis
Fix illumox-x64 build with gcc and clang (#129322)
9d53908
First, our default build is failing with solaris gcc 13, so couple of
fixes for those are included (jit, gcenv etc.). Then it includes clang
fixes.
For the first time, cross building runtime repo for illumos-x64 with
llvm-toolchain has succeeded. It has two issues which I've reported
upstream with minimal repro and workarounds:
* llvm assembler (llvm-mc):
llvm/llvm-project#202953
* LLVM linker (lld): llvm/llvm-project#202963
For the first one I am adding a workaround in configurecompiler.cmake
(`if (CMAKE_C_COMPILER_ID MATCHES "GNU")` condition). For the second one
the hack goes in toolchain.cmake which I am skipping from this PR as I'm
running trials to slim it down a bit (current state:
https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same
as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream
dotnet/dotnet#7206, which I recently broke while
fixing sccsid which got broken after we started to use `--gc-sections`
linker option liberally.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

+1 more reviewer

@gwrgwrgwr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-SunOSSunOS, currently not officially supported

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@am11@akoeplinger@janvorli@gwr@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix illumox-x64 build with gcc and clang by am11 · Pull Request #129322 · dotnet/runtime · GitHub
Skip to content
Fix illumox-x64 build with gcc and clang - #129322
Merged
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Jun 15, 2026
Merged
Fix illumox-x64 build with gcc and clang#129322
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Conversation
@am11
@am11am11
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
First, our default build is failing with solaris gcc 13, so couple of fixes for those are included (jit, gcenv etc.). Then it includes clang fixes.
For the first time, cross building runtime repo for illumos-x64 with llvm-toolchain has succeeded. It has two issues which I've reported upstream with minimal repro and workarounds:
For the first one I am adding a workaround in configurecompiler.cmake (if (CMAKE_C_COMPILER_ID MATCHES "GNU") condition). For the second one the hack goes in toolchain.cmake which I am skipping from this PR as I'm running trials to slim it down a bit (current state: https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream dotnet/dotnet#7206, which I recently broke while fixing sccsid which got broken after we started to use --gc-sections linker option liberally.
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 12, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 12, 2026
@am11am11
added

area-PAL-coreclr
only for closed issues
os-SunOS
SunOS, currently not officially supported
and removed

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Jun 12, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@am11
am11
commented
Jun 12, 2026

Copy link


Copy Markdown

MemberAuthor
cc @gwr, @AustinWise, I know you guys were looking for clang-based crossbuild at some point. While working on OpenBSD bringup, I figured some internal things out for illumos.
If someone could take care of llvm side of patching, that would help. 🙂
am11
am11
commented
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
@akoeplinger
akoeplinger
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
build failure looks related
jakobbotsch
jakobbotsch
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.h
Outdated

janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Comment threadsrc/native/libs/System.Native/pal_process.c
jakobbotsch
jakobbotsch
approved these changes
Jun 12, 2026
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT part LGTM
janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_signal.c

This was referenced Jun 13, 2026

Open


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@am11
am11
requested a review
from janvorliJune 15, 2026 11:14
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 15, 2026

Closed

@am11
am11
commented
Jun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Windows timeout failures are unrelated to the changes here.
@janvorli
janvorli
commented
Jun 15, 2026

Copy link


Copy Markdown

Member
/ba-g windows builds timeouts unrelated to this change and seems to happen on multiple PRs.
@janvorli
janvorli
merged commit 9ce1cb9
into
dotnet:mainJun 15, 2026

199 of 208 checks passed

@am11
am11
deleted the

feature/port/illumos-native-build2

branch
June 15, 2026 21:56
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 17, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@am11@eiriktsarpalis
Fix illumox-x64 build with gcc and clang (#129322)
9d53908
First, our default build is failing with solaris gcc 13, so couple of
fixes for those are included (jit, gcenv etc.). Then it includes clang
fixes.
For the first time, cross building runtime repo for illumos-x64 with
llvm-toolchain has succeeded. It has two issues which I've reported
upstream with minimal repro and workarounds:
* llvm assembler (llvm-mc):
llvm/llvm-project#202953
* LLVM linker (lld): llvm/llvm-project#202963
For the first one I am adding a workaround in configurecompiler.cmake
(`if (CMAKE_C_COMPILER_ID MATCHES "GNU")` condition). For the second one
the hack goes in toolchain.cmake which I am skipping from this PR as I'm
running trials to slim it down a bit (current state:
https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same
as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream
dotnet/dotnet#7206, which I recently broke while
fixing sccsid which got broken after we started to use `--gc-sections`
linker option liberally.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

+1 more reviewer

@gwrgwrgwr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-SunOSSunOS, currently not officially supported

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@am11@akoeplinger@janvorli@gwr@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix illumox-x64 build with gcc and clang by am11 · Pull Request #129322 · dotnet/runtime · GitHub
Skip to content
Fix illumox-x64 build with gcc and clang - #129322
Merged
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Jun 15, 2026
Merged
Fix illumox-x64 build with gcc and clang#129322
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Conversation
@am11
@am11am11
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
First, our default build is failing with solaris gcc 13, so couple of fixes for those are included (jit, gcenv etc.). Then it includes clang fixes.
For the first time, cross building runtime repo for illumos-x64 with llvm-toolchain has succeeded. It has two issues which I've reported upstream with minimal repro and workarounds:
For the first one I am adding a workaround in configurecompiler.cmake (if (CMAKE_C_COMPILER_ID MATCHES "GNU") condition). For the second one the hack goes in toolchain.cmake which I am skipping from this PR as I'm running trials to slim it down a bit (current state: https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream dotnet/dotnet#7206, which I recently broke while fixing sccsid which got broken after we started to use --gc-sections linker option liberally.
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 12, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 12, 2026
@am11am11
added

area-PAL-coreclr
only for closed issues
os-SunOS
SunOS, currently not officially supported
and removed

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Jun 12, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@am11
am11
commented
Jun 12, 2026

Copy link


Copy Markdown

MemberAuthor
cc @gwr, @AustinWise, I know you guys were looking for clang-based crossbuild at some point. While working on OpenBSD bringup, I figured some internal things out for illumos.
If someone could take care of llvm side of patching, that would help. 🙂
am11
am11
commented
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
@akoeplinger
akoeplinger
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
build failure looks related
jakobbotsch
jakobbotsch
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.h
Outdated

janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Comment threadsrc/native/libs/System.Native/pal_process.c
jakobbotsch
jakobbotsch
approved these changes
Jun 12, 2026
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT part LGTM
janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_signal.c

This was referenced Jun 13, 2026

Open


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@am11
am11
requested a review
from janvorliJune 15, 2026 11:14
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 15, 2026

Closed

@am11
am11
commented
Jun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Windows timeout failures are unrelated to the changes here.
@janvorli
janvorli
commented
Jun 15, 2026

Copy link


Copy Markdown

Member
/ba-g windows builds timeouts unrelated to this change and seems to happen on multiple PRs.
@janvorli
janvorli
merged commit 9ce1cb9
into
dotnet:mainJun 15, 2026

199 of 208 checks passed

@am11
am11
deleted the

feature/port/illumos-native-build2

branch
June 15, 2026 21:56
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 17, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@am11@eiriktsarpalis
Fix illumox-x64 build with gcc and clang (#129322)
9d53908
First, our default build is failing with solaris gcc 13, so couple of
fixes for those are included (jit, gcenv etc.). Then it includes clang
fixes.
For the first time, cross building runtime repo for illumos-x64 with
llvm-toolchain has succeeded. It has two issues which I've reported
upstream with minimal repro and workarounds:
* llvm assembler (llvm-mc):
llvm/llvm-project#202953
* LLVM linker (lld): llvm/llvm-project#202963
For the first one I am adding a workaround in configurecompiler.cmake
(`if (CMAKE_C_COMPILER_ID MATCHES "GNU")` condition). For the second one
the hack goes in toolchain.cmake which I am skipping from this PR as I'm
running trials to slim it down a bit (current state:
https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same
as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream
dotnet/dotnet#7206, which I recently broke while
fixing sccsid which got broken after we started to use `--gc-sections`
linker option liberally.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

+1 more reviewer

@gwrgwrgwr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-SunOSSunOS, currently not officially supported

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@am11@akoeplinger@janvorli@gwr@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix illumox-x64 build with gcc and clang by am11 · Pull Request #129322 · dotnet/runtime · GitHub
Skip to content
Fix illumox-x64 build with gcc and clang - #129322
Merged
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Jun 15, 2026
Merged
Fix illumox-x64 build with gcc and clang#129322
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Conversation
@am11
@am11am11
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
First, our default build is failing with solaris gcc 13, so couple of fixes for those are included (jit, gcenv etc.). Then it includes clang fixes.
For the first time, cross building runtime repo for illumos-x64 with llvm-toolchain has succeeded. It has two issues which I've reported upstream with minimal repro and workarounds:
For the first one I am adding a workaround in configurecompiler.cmake (if (CMAKE_C_COMPILER_ID MATCHES "GNU") condition). For the second one the hack goes in toolchain.cmake which I am skipping from this PR as I'm running trials to slim it down a bit (current state: https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream dotnet/dotnet#7206, which I recently broke while fixing sccsid which got broken after we started to use --gc-sections linker option liberally.
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 12, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 12, 2026
@am11am11
added

area-PAL-coreclr
only for closed issues
os-SunOS
SunOS, currently not officially supported
and removed

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Jun 12, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@am11
am11
commented
Jun 12, 2026

Copy link


Copy Markdown

MemberAuthor
cc @gwr, @AustinWise, I know you guys were looking for clang-based crossbuild at some point. While working on OpenBSD bringup, I figured some internal things out for illumos.
If someone could take care of llvm side of patching, that would help. 🙂
am11
am11
commented
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
@akoeplinger
akoeplinger
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
build failure looks related
jakobbotsch
jakobbotsch
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.h
Outdated

janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Comment threadsrc/native/libs/System.Native/pal_process.c
jakobbotsch
jakobbotsch
approved these changes
Jun 12, 2026
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT part LGTM
janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_signal.c

This was referenced Jun 13, 2026

Open


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@am11
am11
requested a review
from janvorliJune 15, 2026 11:14
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 15, 2026

Closed

@am11
am11
commented
Jun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Windows timeout failures are unrelated to the changes here.
@janvorli
janvorli
commented
Jun 15, 2026

Copy link


Copy Markdown

Member
/ba-g windows builds timeouts unrelated to this change and seems to happen on multiple PRs.
@janvorli
janvorli
merged commit 9ce1cb9
into
dotnet:mainJun 15, 2026

199 of 208 checks passed

@am11
am11
deleted the

feature/port/illumos-native-build2

branch
June 15, 2026 21:56
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 17, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@am11@eiriktsarpalis
Fix illumox-x64 build with gcc and clang (#129322)
9d53908
First, our default build is failing with solaris gcc 13, so couple of
fixes for those are included (jit, gcenv etc.). Then it includes clang
fixes.
For the first time, cross building runtime repo for illumos-x64 with
llvm-toolchain has succeeded. It has two issues which I've reported
upstream with minimal repro and workarounds:
* llvm assembler (llvm-mc):
llvm/llvm-project#202953
* LLVM linker (lld): llvm/llvm-project#202963
For the first one I am adding a workaround in configurecompiler.cmake
(`if (CMAKE_C_COMPILER_ID MATCHES "GNU")` condition). For the second one
the hack goes in toolchain.cmake which I am skipping from this PR as I'm
running trials to slim it down a bit (current state:
https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same
as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream
dotnet/dotnet#7206, which I recently broke while
fixing sccsid which got broken after we started to use `--gc-sections`
linker option liberally.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

+1 more reviewer

@gwrgwrgwr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-SunOSSunOS, currently not officially supported

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@am11@akoeplinger@janvorli@gwr@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix illumox-x64 build with gcc and clang by am11 · Pull Request #129322 · dotnet/runtime · GitHub
Skip to content
Fix illumox-x64 build with gcc and clang - #129322
Merged
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Jun 15, 2026
Merged
Fix illumox-x64 build with gcc and clang#129322
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Conversation
@am11
@am11am11
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
First, our default build is failing with solaris gcc 13, so couple of fixes for those are included (jit, gcenv etc.). Then it includes clang fixes.
For the first time, cross building runtime repo for illumos-x64 with llvm-toolchain has succeeded. It has two issues which I've reported upstream with minimal repro and workarounds:
For the first one I am adding a workaround in configurecompiler.cmake (if (CMAKE_C_COMPILER_ID MATCHES "GNU") condition). For the second one the hack goes in toolchain.cmake which I am skipping from this PR as I'm running trials to slim it down a bit (current state: https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream dotnet/dotnet#7206, which I recently broke while fixing sccsid which got broken after we started to use --gc-sections linker option liberally.
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 12, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 12, 2026
@am11am11
added

area-PAL-coreclr
only for closed issues
os-SunOS
SunOS, currently not officially supported
and removed

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Jun 12, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@am11
am11
commented
Jun 12, 2026

Copy link


Copy Markdown

MemberAuthor
cc @gwr, @AustinWise, I know you guys were looking for clang-based crossbuild at some point. While working on OpenBSD bringup, I figured some internal things out for illumos.
If someone could take care of llvm side of patching, that would help. 🙂
am11
am11
commented
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
@akoeplinger
akoeplinger
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
build failure looks related
jakobbotsch
jakobbotsch
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.h
Outdated

janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Comment threadsrc/native/libs/System.Native/pal_process.c
jakobbotsch
jakobbotsch
approved these changes
Jun 12, 2026
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT part LGTM
janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_signal.c

This was referenced Jun 13, 2026

Open


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@am11
am11
requested a review
from janvorliJune 15, 2026 11:14
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 15, 2026

Closed

@am11
am11
commented
Jun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Windows timeout failures are unrelated to the changes here.
@janvorli
janvorli
commented
Jun 15, 2026

Copy link


Copy Markdown

Member
/ba-g windows builds timeouts unrelated to this change and seems to happen on multiple PRs.
@janvorli
janvorli
merged commit 9ce1cb9
into
dotnet:mainJun 15, 2026

199 of 208 checks passed

@am11
am11
deleted the

feature/port/illumos-native-build2

branch
June 15, 2026 21:56
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 17, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@am11@eiriktsarpalis
Fix illumox-x64 build with gcc and clang (#129322)
9d53908
First, our default build is failing with solaris gcc 13, so couple of
fixes for those are included (jit, gcenv etc.). Then it includes clang
fixes.
For the first time, cross building runtime repo for illumos-x64 with
llvm-toolchain has succeeded. It has two issues which I've reported
upstream with minimal repro and workarounds:
* llvm assembler (llvm-mc):
llvm/llvm-project#202953
* LLVM linker (lld): llvm/llvm-project#202963
For the first one I am adding a workaround in configurecompiler.cmake
(`if (CMAKE_C_COMPILER_ID MATCHES "GNU")` condition). For the second one
the hack goes in toolchain.cmake which I am skipping from this PR as I'm
running trials to slim it down a bit (current state:
https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same
as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream
dotnet/dotnet#7206, which I recently broke while
fixing sccsid which got broken after we started to use `--gc-sections`
linker option liberally.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

+1 more reviewer

@gwrgwrgwr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-SunOSSunOS, currently not officially supported

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@am11@akoeplinger@janvorli@gwr@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix illumox-x64 build with gcc and clang by am11 · Pull Request #129322 · dotnet/runtime · GitHub
Skip to content
Fix illumox-x64 build with gcc and clang - #129322
Merged
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Jun 15, 2026
Merged
Fix illumox-x64 build with gcc and clang#129322
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Conversation
@am11
@am11am11
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
First, our default build is failing with solaris gcc 13, so couple of fixes for those are included (jit, gcenv etc.). Then it includes clang fixes.
For the first time, cross building runtime repo for illumos-x64 with llvm-toolchain has succeeded. It has two issues which I've reported upstream with minimal repro and workarounds:
For the first one I am adding a workaround in configurecompiler.cmake (if (CMAKE_C_COMPILER_ID MATCHES "GNU") condition). For the second one the hack goes in toolchain.cmake which I am skipping from this PR as I'm running trials to slim it down a bit (current state: https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream dotnet/dotnet#7206, which I recently broke while fixing sccsid which got broken after we started to use --gc-sections linker option liberally.
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 12, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 12, 2026
@am11am11
added

area-PAL-coreclr
only for closed issues
os-SunOS
SunOS, currently not officially supported
and removed

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Jun 12, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@am11
am11
commented
Jun 12, 2026

Copy link


Copy Markdown

MemberAuthor
cc @gwr, @AustinWise, I know you guys were looking for clang-based crossbuild at some point. While working on OpenBSD bringup, I figured some internal things out for illumos.
If someone could take care of llvm side of patching, that would help. 🙂
am11
am11
commented
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
@akoeplinger
akoeplinger
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
build failure looks related
jakobbotsch
jakobbotsch
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.h
Outdated

janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Comment threadsrc/native/libs/System.Native/pal_process.c
jakobbotsch
jakobbotsch
approved these changes
Jun 12, 2026
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT part LGTM
janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_signal.c

This was referenced Jun 13, 2026

Open


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@am11
am11
requested a review
from janvorliJune 15, 2026 11:14
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 15, 2026

Closed

@am11
am11
commented
Jun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Windows timeout failures are unrelated to the changes here.
@janvorli
janvorli
commented
Jun 15, 2026

Copy link


Copy Markdown

Member
/ba-g windows builds timeouts unrelated to this change and seems to happen on multiple PRs.
@janvorli
janvorli
merged commit 9ce1cb9
into
dotnet:mainJun 15, 2026

199 of 208 checks passed

@am11
am11
deleted the

feature/port/illumos-native-build2

branch
June 15, 2026 21:56
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 17, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@am11@eiriktsarpalis
Fix illumox-x64 build with gcc and clang (#129322)
9d53908
First, our default build is failing with solaris gcc 13, so couple of
fixes for those are included (jit, gcenv etc.). Then it includes clang
fixes.
For the first time, cross building runtime repo for illumos-x64 with
llvm-toolchain has succeeded. It has two issues which I've reported
upstream with minimal repro and workarounds:
* llvm assembler (llvm-mc):
llvm/llvm-project#202953
* LLVM linker (lld): llvm/llvm-project#202963
For the first one I am adding a workaround in configurecompiler.cmake
(`if (CMAKE_C_COMPILER_ID MATCHES "GNU")` condition). For the second one
the hack goes in toolchain.cmake which I am skipping from this PR as I'm
running trials to slim it down a bit (current state:
https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same
as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream
dotnet/dotnet#7206, which I recently broke while
fixing sccsid which got broken after we started to use `--gc-sections`
linker option liberally.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

+1 more reviewer

@gwrgwrgwr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-SunOSSunOS, currently not officially supported

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@am11@akoeplinger@janvorli@gwr@jakobbotsch

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Fix illumox-x64 build with gcc and clang by am11 · Pull Request #129322 · dotnet/runtime · GitHub
Skip to content
Fix illumox-x64 build with gcc and clang - #129322
Merged
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Jun 15, 2026
Merged
Fix illumox-x64 build with gcc and clang#129322
janvorli merged 11 commits into
dotnet:mainfrom 
am11:feature/port/illumos-native-build2
Conversation
@am11
@am11am11
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
First, our default build is failing with solaris gcc 13, so couple of fixes for those are included (jit, gcenv etc.). Then it includes clang fixes.
For the first time, cross building runtime repo for illumos-x64 with llvm-toolchain has succeeded. It has two issues which I've reported upstream with minimal repro and workarounds:
For the first one I am adding a workaround in configurecompiler.cmake (if (CMAKE_C_COMPILER_ID MATCHES "GNU") condition). For the second one the hack goes in toolchain.cmake which I am skipping from this PR as I'm running trials to slim it down a bit (current state: https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream dotnet/dotnet#7206, which I recently broke while fixing sccsid which got broken after we started to use --gc-sections linker option liberally.
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 12, 2026
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 12, 2026
@am11am11
added

area-PAL-coreclr
only for closed issues
os-SunOS
SunOS, currently not officially supported
and removed

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Jun 12, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
@am11
am11
commented
Jun 12, 2026

Copy link


Copy Markdown

MemberAuthor
cc @gwr, @AustinWise, I know you guys were looking for clang-based crossbuild at some point. While working on OpenBSD bringup, I figured some internal things out for illumos.
If someone could take care of llvm side of patching, that would help. 🙂
am11
am11
commented
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_process.c
@akoeplinger
akoeplinger
commented
Jun 12, 2026

Copy link


Copy Markdown

Member
build failure looks related
jakobbotsch
jakobbotsch
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.h
Outdated

janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/unix/gcenv.unix.cpp
Comment threadsrc/native/libs/System.Native/pal_process.c
jakobbotsch
jakobbotsch
approved these changes
Jun 12, 2026
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT part LGTM
janvorli
janvorli
reviewed
Jun 12, 2026
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_signal.c

This was referenced Jun 13, 2026

Open


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Jun 14, 2026

Closed

@am11
am11
requested a review
from janvorliJune 15, 2026 11:14
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 15, 2026

Closed

@am11
am11
commented
Jun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Windows timeout failures are unrelated to the changes here.
@janvorli
janvorli
commented
Jun 15, 2026

Copy link


Copy Markdown

Member
/ba-g windows builds timeouts unrelated to this change and seems to happen on multiple PRs.
@janvorli
janvorli
merged commit 9ce1cb9
into
dotnet:mainJun 15, 2026

199 of 208 checks passed

@am11
am11
deleted the

feature/port/illumos-native-build2

branch
June 15, 2026 21:56
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jun 16, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview6 milestone
Jun 17, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@am11@eiriktsarpalis
Fix illumox-x64 build with gcc and clang (#129322)
9d53908
First, our default build is failing with solaris gcc 13, so couple of
fixes for those are included (jit, gcenv etc.). Then it includes clang
fixes.
For the first time, cross building runtime repo for illumos-x64 with
llvm-toolchain has succeeded. It has two issues which I've reported
upstream with minimal repro and workarounds:
* llvm assembler (llvm-mc):
llvm/llvm-project#202953
* LLVM linker (lld): llvm/llvm-project#202963
For the first one I am adding a workaround in configurecompiler.cmake
(`if (CMAKE_C_COMPILER_ID MATCHES "GNU")` condition). For the second one
the hack goes in toolchain.cmake which I am skipping from this PR as I'm
running trials to slim it down a bit (current state:
https://github.com/am11/runtime/blob/67046c0cf095c5d7888c797226fe736156b5e04c/eng/common/cross/toolchain.cmake#L227-L307).
Together the clang build succeeds on Azure Linux cross environment same
as rest of the platforms (freebsd, openbsd, haiku).
Note that the gcc build requires another fix upstream
dotnet/dotnet#7206, which I recently broke while
fixing sccsid which got broken after we started to use `--gc-sections`
linker option liberally.
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 18, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
@janvorlijanvorlijanvorli approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

+1 more reviewer

@gwrgwrgwr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-SunOSSunOS, currently not officially supported

Projects


None yet


Milestone

11.0-preview6

Development

Successfully merging this pull request may close these issues.

5 participants

@am11@akoeplinger@janvorli@gwr@jakobbotsch