Add ActiveIssue for all named key tests to mitigate invalid memory access by vcsjones · Pull Request #129367 · dotnet/runtime

vcsjones · 2026-06-13T14:09:14Z

This adds an ActiveIssue to all functional members of OpenSslNamedKeysTests because they are very likely the source of memory corruption that is showing in #129339.

Disable the tests for now so that CI is stable while permanent fixes are investigated.

…cess

dotnet-policy-service · 2026-06-13T14:10:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates OpenSslNamedKeysTests by adding ActiveIssue annotations to skip many of the named key functional tests while issue #129339 (segfault/memory corruption in System.Security.Cryptography.Tests) is investigated, aiming to keep CI stable.

Changes:

Added [ActiveIssue("https://github.com/dotnet/runtime/issues/129339")] to most test methods in OpenSslNamedKeysTests.manual.cs to disable them.
Left some tests in the same class still runnable (e.g., argument/URI validation tests), despite the stated intent to disable the suite.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs	Adds `ActiveIssue` skips to many named key tests to mitigate suspected CI instability from #129339.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 2

…quire manually running

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

vcsjones · 2026-06-13T18:46:17Z

/ba-g timeout on unrelated platform; test only changes to disable some problematic tests.

Freeing an OSSL_LIB_CTX is a somewhat complicated task. It registers per-thread callbacks to mutate thread-local state. Other OpenSSL APIs, like random number generation, also have thread-local state. In the case of the random number generator, it registered a thread data destructor to clean up random state when the thread is shutting down. This, in turn, sees that the OSSL_LIB_CTX is associated with that thread. If the OSSL_LIB_CTX is freed before the thread has shut down, the thread dtor will access invalid memory. OpenSSL requires you to call `OPENSSL_thread_stop_ex` on _all_ threads before calling `OSSL_LIB_CTX_free` to unhook the context from the thread. This is generally not feasible for .NET. As a solution, we are going to not free the context, and re-use it for each provider. Every provider loaded with `SafeEvpPKeyHandle.OpenKeyFromProvider` will create a context and load that provider into it. The context and provider will remain alive for the duration of the process. The number of providers expected to be used in any application is generally expected to be low - likely two or three. 1. The provider and context are now cached, and kept in a heap-backed buffer. There is no resizing strategy or pre-allocated buffer. Opening a new provider results in re-sizing the array. This strategy is likely fine because there will rarely ever be more than a few providers, as already noted. The resizing is managed by a mutex to synchronize access to the array. We could use something like `pthread_rwlock_t` if we wanted to increase complexity. Given that contention on this mutex would only happen from `OpenKeyFromProvider`, I expect it to be rare. 2. Since the context and provider are now alive permanently, the "extra handle" bookkeeping gets simpler. We no longer need to pass it to destroy, and we no longer need to ref-count it. In fact we don't even need a struct at all anymore, the OSSL_LIB_CTX _is_ the extra handle now. 3. This reverts #129367 since the data dependency is resolved.

vcsjones · 2026-06-13T14:09:14Z

This adds an ActiveIssue to all functional members of OpenSslNamedKeysTests because they are very likely the source of memory corruption that is showing in #129339.

Disable the tests for now so that CI is stable while permanent fixes are investigated.

…cess

dotnet-policy-service · 2026-06-13T14:10:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates OpenSslNamedKeysTests by adding ActiveIssue annotations to skip many of the named key functional tests while issue #129339 (segfault/memory corruption in System.Security.Cryptography.Tests) is investigated, aiming to keep CI stable.

Changes:

Added [ActiveIssue("https://github.com/dotnet/runtime/issues/129339")] to most test methods in OpenSslNamedKeysTests.manual.cs to disable them.
Left some tests in the same class still runnable (e.g., argument/URI validation tests), despite the stated intent to disable the suite.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs	Adds `ActiveIssue` skips to many named key tests to mitigate suspected CI instability from #129339.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 2

…quire manually running

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

vcsjones · 2026-06-13T18:46:17Z

/ba-g timeout on unrelated platform; test only changes to disable some problematic tests.

Freeing an OSSL_LIB_CTX is a somewhat complicated task. It registers per-thread callbacks to mutate thread-local state. Other OpenSSL APIs, like random number generation, also have thread-local state. In the case of the random number generator, it registered a thread data destructor to clean up random state when the thread is shutting down. This, in turn, sees that the OSSL_LIB_CTX is associated with that thread. If the OSSL_LIB_CTX is freed before the thread has shut down, the thread dtor will access invalid memory. OpenSSL requires you to call `OPENSSL_thread_stop_ex` on _all_ threads before calling `OSSL_LIB_CTX_free` to unhook the context from the thread. This is generally not feasible for .NET. As a solution, we are going to not free the context, and re-use it for each provider. Every provider loaded with `SafeEvpPKeyHandle.OpenKeyFromProvider` will create a context and load that provider into it. The context and provider will remain alive for the duration of the process. The number of providers expected to be used in any application is generally expected to be low - likely two or three. 1. The provider and context are now cached, and kept in a heap-backed buffer. There is no resizing strategy or pre-allocated buffer. Opening a new provider results in re-sizing the array. This strategy is likely fine because there will rarely ever be more than a few providers, as already noted. The resizing is managed by a mutex to synchronize access to the array. We could use something like `pthread_rwlock_t` if we wanted to increase complexity. Given that contention on this mutex would only happen from `OpenKeyFromProvider`, I expect it to be rare. 2. Since the context and provider are now alive permanently, the "extra handle" bookkeeping gets simpler. We no longer need to pass it to destroy, and we no longer need to ref-count it. In fact we don't even need a struct at all anymore, the OSSL_LIB_CTX _is_ the extra handle now. 3. This reverts #129367 since the data dependency is resolved.

vcsjones · 2026-06-13T14:09:14Z

This adds an ActiveIssue to all functional members of OpenSslNamedKeysTests because they are very likely the source of memory corruption that is showing in #129339.

Disable the tests for now so that CI is stable while permanent fixes are investigated.

…cess

dotnet-policy-service · 2026-06-13T14:10:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates OpenSslNamedKeysTests by adding ActiveIssue annotations to skip many of the named key functional tests while issue #129339 (segfault/memory corruption in System.Security.Cryptography.Tests) is investigated, aiming to keep CI stable.

Changes:

Added [ActiveIssue("https://github.com/dotnet/runtime/issues/129339")] to most test methods in OpenSslNamedKeysTests.manual.cs to disable them.
Left some tests in the same class still runnable (e.g., argument/URI validation tests), despite the stated intent to disable the suite.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs	Adds `ActiveIssue` skips to many named key tests to mitigate suspected CI instability from #129339.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 2

…quire manually running

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

vcsjones · 2026-06-13T18:46:17Z

/ba-g timeout on unrelated platform; test only changes to disable some problematic tests.

Freeing an OSSL_LIB_CTX is a somewhat complicated task. It registers per-thread callbacks to mutate thread-local state. Other OpenSSL APIs, like random number generation, also have thread-local state. In the case of the random number generator, it registered a thread data destructor to clean up random state when the thread is shutting down. This, in turn, sees that the OSSL_LIB_CTX is associated with that thread. If the OSSL_LIB_CTX is freed before the thread has shut down, the thread dtor will access invalid memory. OpenSSL requires you to call `OPENSSL_thread_stop_ex` on _all_ threads before calling `OSSL_LIB_CTX_free` to unhook the context from the thread. This is generally not feasible for .NET. As a solution, we are going to not free the context, and re-use it for each provider. Every provider loaded with `SafeEvpPKeyHandle.OpenKeyFromProvider` will create a context and load that provider into it. The context and provider will remain alive for the duration of the process. The number of providers expected to be used in any application is generally expected to be low - likely two or three. 1. The provider and context are now cached, and kept in a heap-backed buffer. There is no resizing strategy or pre-allocated buffer. Opening a new provider results in re-sizing the array. This strategy is likely fine because there will rarely ever be more than a few providers, as already noted. The resizing is managed by a mutex to synchronize access to the array. We could use something like `pthread_rwlock_t` if we wanted to increase complexity. Given that contention on this mutex would only happen from `OpenKeyFromProvider`, I expect it to be rare. 2. Since the context and provider are now alive permanently, the "extra handle" bookkeeping gets simpler. We no longer need to pass it to destroy, and we no longer need to ref-count it. In fact we don't even need a struct at all anymore, the OSSL_LIB_CTX _is_ the extra handle now. 3. This reverts #129367 since the data dependency is resolved.

vcsjones · 2026-06-13T14:09:14Z

This adds an ActiveIssue to all functional members of OpenSslNamedKeysTests because they are very likely the source of memory corruption that is showing in #129339.

Disable the tests for now so that CI is stable while permanent fixes are investigated.

…cess

dotnet-policy-service · 2026-06-13T14:10:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates OpenSslNamedKeysTests by adding ActiveIssue annotations to skip many of the named key functional tests while issue #129339 (segfault/memory corruption in System.Security.Cryptography.Tests) is investigated, aiming to keep CI stable.

Changes:

Added [ActiveIssue("https://github.com/dotnet/runtime/issues/129339")] to most test methods in OpenSslNamedKeysTests.manual.cs to disable them.
Left some tests in the same class still runnable (e.g., argument/URI validation tests), despite the stated intent to disable the suite.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs	Adds `ActiveIssue` skips to many named key tests to mitigate suspected CI instability from #129339.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 2

…quire manually running

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

vcsjones · 2026-06-13T18:46:17Z

/ba-g timeout on unrelated platform; test only changes to disable some problematic tests.

Freeing an OSSL_LIB_CTX is a somewhat complicated task. It registers per-thread callbacks to mutate thread-local state. Other OpenSSL APIs, like random number generation, also have thread-local state. In the case of the random number generator, it registered a thread data destructor to clean up random state when the thread is shutting down. This, in turn, sees that the OSSL_LIB_CTX is associated with that thread. If the OSSL_LIB_CTX is freed before the thread has shut down, the thread dtor will access invalid memory. OpenSSL requires you to call `OPENSSL_thread_stop_ex` on _all_ threads before calling `OSSL_LIB_CTX_free` to unhook the context from the thread. This is generally not feasible for .NET. As a solution, we are going to not free the context, and re-use it for each provider. Every provider loaded with `SafeEvpPKeyHandle.OpenKeyFromProvider` will create a context and load that provider into it. The context and provider will remain alive for the duration of the process. The number of providers expected to be used in any application is generally expected to be low - likely two or three. 1. The provider and context are now cached, and kept in a heap-backed buffer. There is no resizing strategy or pre-allocated buffer. Opening a new provider results in re-sizing the array. This strategy is likely fine because there will rarely ever be more than a few providers, as already noted. The resizing is managed by a mutex to synchronize access to the array. We could use something like `pthread_rwlock_t` if we wanted to increase complexity. Given that contention on this mutex would only happen from `OpenKeyFromProvider`, I expect it to be rare. 2. Since the context and provider are now alive permanently, the "extra handle" bookkeeping gets simpler. We no longer need to pass it to destroy, and we no longer need to ref-count it. In fact we don't even need a struct at all anymore, the OSSL_LIB_CTX _is_ the extra handle now. 3. This reverts #129367 since the data dependency is resolved.

vcsjones · 2026-06-13T14:09:14Z

This adds an ActiveIssue to all functional members of OpenSslNamedKeysTests because they are very likely the source of memory corruption that is showing in #129339.

Disable the tests for now so that CI is stable while permanent fixes are investigated.

…cess

dotnet-policy-service · 2026-06-13T14:10:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates OpenSslNamedKeysTests by adding ActiveIssue annotations to skip many of the named key functional tests while issue #129339 (segfault/memory corruption in System.Security.Cryptography.Tests) is investigated, aiming to keep CI stable.

Changes:

Added [ActiveIssue("https://github.com/dotnet/runtime/issues/129339")] to most test methods in OpenSslNamedKeysTests.manual.cs to disable them.
Left some tests in the same class still runnable (e.g., argument/URI validation tests), despite the stated intent to disable the suite.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs	Adds `ActiveIssue` skips to many named key tests to mitigate suspected CI instability from #129339.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 2

…quire manually running

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

vcsjones · 2026-06-13T18:46:17Z

/ba-g timeout on unrelated platform; test only changes to disable some problematic tests.

Freeing an OSSL_LIB_CTX is a somewhat complicated task. It registers per-thread callbacks to mutate thread-local state. Other OpenSSL APIs, like random number generation, also have thread-local state. In the case of the random number generator, it registered a thread data destructor to clean up random state when the thread is shutting down. This, in turn, sees that the OSSL_LIB_CTX is associated with that thread. If the OSSL_LIB_CTX is freed before the thread has shut down, the thread dtor will access invalid memory. OpenSSL requires you to call `OPENSSL_thread_stop_ex` on _all_ threads before calling `OSSL_LIB_CTX_free` to unhook the context from the thread. This is generally not feasible for .NET. As a solution, we are going to not free the context, and re-use it for each provider. Every provider loaded with `SafeEvpPKeyHandle.OpenKeyFromProvider` will create a context and load that provider into it. The context and provider will remain alive for the duration of the process. The number of providers expected to be used in any application is generally expected to be low - likely two or three. 1. The provider and context are now cached, and kept in a heap-backed buffer. There is no resizing strategy or pre-allocated buffer. Opening a new provider results in re-sizing the array. This strategy is likely fine because there will rarely ever be more than a few providers, as already noted. The resizing is managed by a mutex to synchronize access to the array. We could use something like `pthread_rwlock_t` if we wanted to increase complexity. Given that contention on this mutex would only happen from `OpenKeyFromProvider`, I expect it to be rare. 2. Since the context and provider are now alive permanently, the "extra handle" bookkeeping gets simpler. We no longer need to pass it to destroy, and we no longer need to ref-count it. In fact we don't even need a struct at all anymore, the OSSL_LIB_CTX _is_ the extra handle now. 3. This reverts #129367 since the data dependency is resolved.

vcsjones · 2026-06-13T14:09:14Z

This adds an ActiveIssue to all functional members of OpenSslNamedKeysTests because they are very likely the source of memory corruption that is showing in #129339.

Disable the tests for now so that CI is stable while permanent fixes are investigated.

…cess

dotnet-policy-service · 2026-06-13T14:10:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates OpenSslNamedKeysTests by adding ActiveIssue annotations to skip many of the named key functional tests while issue #129339 (segfault/memory corruption in System.Security.Cryptography.Tests) is investigated, aiming to keep CI stable.

Changes:

Added [ActiveIssue("https://github.com/dotnet/runtime/issues/129339")] to most test methods in OpenSslNamedKeysTests.manual.cs to disable them.
Left some tests in the same class still runnable (e.g., argument/URI validation tests), despite the stated intent to disable the suite.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs	Adds `ActiveIssue` skips to many named key tests to mitigate suspected CI instability from #129339.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 2

…quire manually running

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

vcsjones · 2026-06-13T18:46:17Z

/ba-g timeout on unrelated platform; test only changes to disable some problematic tests.

Freeing an OSSL_LIB_CTX is a somewhat complicated task. It registers per-thread callbacks to mutate thread-local state. Other OpenSSL APIs, like random number generation, also have thread-local state. In the case of the random number generator, it registered a thread data destructor to clean up random state when the thread is shutting down. This, in turn, sees that the OSSL_LIB_CTX is associated with that thread. If the OSSL_LIB_CTX is freed before the thread has shut down, the thread dtor will access invalid memory. OpenSSL requires you to call `OPENSSL_thread_stop_ex` on _all_ threads before calling `OSSL_LIB_CTX_free` to unhook the context from the thread. This is generally not feasible for .NET. As a solution, we are going to not free the context, and re-use it for each provider. Every provider loaded with `SafeEvpPKeyHandle.OpenKeyFromProvider` will create a context and load that provider into it. The context and provider will remain alive for the duration of the process. The number of providers expected to be used in any application is generally expected to be low - likely two or three. 1. The provider and context are now cached, and kept in a heap-backed buffer. There is no resizing strategy or pre-allocated buffer. Opening a new provider results in re-sizing the array. This strategy is likely fine because there will rarely ever be more than a few providers, as already noted. The resizing is managed by a mutex to synchronize access to the array. We could use something like `pthread_rwlock_t` if we wanted to increase complexity. Given that contention on this mutex would only happen from `OpenKeyFromProvider`, I expect it to be rare. 2. Since the context and provider are now alive permanently, the "extra handle" bookkeeping gets simpler. We no longer need to pass it to destroy, and we no longer need to ref-count it. In fact we don't even need a struct at all anymore, the OSSL_LIB_CTX _is_ the extra handle now. 3. This reverts #129367 since the data dependency is resolved.

vcsjones · 2026-06-13T14:09:14Z

This adds an ActiveIssue to all functional members of OpenSslNamedKeysTests because they are very likely the source of memory corruption that is showing in #129339.

Disable the tests for now so that CI is stable while permanent fixes are investigated.

…cess

dotnet-policy-service · 2026-06-13T14:10:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates OpenSslNamedKeysTests by adding ActiveIssue annotations to skip many of the named key functional tests while issue #129339 (segfault/memory corruption in System.Security.Cryptography.Tests) is investigated, aiming to keep CI stable.

Changes:

Added [ActiveIssue("https://github.com/dotnet/runtime/issues/129339")] to most test methods in OpenSslNamedKeysTests.manual.cs to disable them.
Left some tests in the same class still runnable (e.g., argument/URI validation tests), despite the stated intent to disable the suite.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs	Adds `ActiveIssue` skips to many named key tests to mitigate suspected CI instability from #129339.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 2

…quire manually running

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

vcsjones · 2026-06-13T18:46:17Z

/ba-g timeout on unrelated platform; test only changes to disable some problematic tests.

Freeing an OSSL_LIB_CTX is a somewhat complicated task. It registers per-thread callbacks to mutate thread-local state. Other OpenSSL APIs, like random number generation, also have thread-local state. In the case of the random number generator, it registered a thread data destructor to clean up random state when the thread is shutting down. This, in turn, sees that the OSSL_LIB_CTX is associated with that thread. If the OSSL_LIB_CTX is freed before the thread has shut down, the thread dtor will access invalid memory. OpenSSL requires you to call `OPENSSL_thread_stop_ex` on _all_ threads before calling `OSSL_LIB_CTX_free` to unhook the context from the thread. This is generally not feasible for .NET. As a solution, we are going to not free the context, and re-use it for each provider. Every provider loaded with `SafeEvpPKeyHandle.OpenKeyFromProvider` will create a context and load that provider into it. The context and provider will remain alive for the duration of the process. The number of providers expected to be used in any application is generally expected to be low - likely two or three. 1. The provider and context are now cached, and kept in a heap-backed buffer. There is no resizing strategy or pre-allocated buffer. Opening a new provider results in re-sizing the array. This strategy is likely fine because there will rarely ever be more than a few providers, as already noted. The resizing is managed by a mutex to synchronize access to the array. We could use something like `pthread_rwlock_t` if we wanted to increase complexity. Given that contention on this mutex would only happen from `OpenKeyFromProvider`, I expect it to be rare. 2. Since the context and provider are now alive permanently, the "extra handle" bookkeeping gets simpler. We no longer need to pass it to destroy, and we no longer need to ref-count it. In fact we don't even need a struct at all anymore, the OSSL_LIB_CTX _is_ the extra handle now. 3. This reverts #129367 since the data dependency is resolved.

vcsjones · 2026-06-13T14:09:14Z

This adds an ActiveIssue to all functional members of OpenSslNamedKeysTests because they are very likely the source of memory corruption that is showing in #129339.

Disable the tests for now so that CI is stable while permanent fixes are investigated.

…cess

dotnet-policy-service · 2026-06-13T14:10:29Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates OpenSslNamedKeysTests by adding ActiveIssue annotations to skip many of the named key functional tests while issue #129339 (segfault/memory corruption in System.Security.Cryptography.Tests) is investigated, aiming to keep CI stable.

Changes:

Added [ActiveIssue("https://github.com/dotnet/runtime/issues/129339")] to most test methods in OpenSslNamedKeysTests.manual.cs to disable them.
Left some tests in the same class still runnable (e.g., argument/URI validation tests), despite the stated intent to disable the suite.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs	Adds `ActiveIssue` skips to many named key tests to mitigate suspected CI instability from #129339.

Copilot's findings

Files reviewed: 1/1 changed files
Comments generated: 2

…quire manually running

Copilot

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

vcsjones · 2026-06-13T18:46:17Z

/ba-g timeout on unrelated platform; test only changes to disable some problematic tests.

Freeing an OSSL_LIB_CTX is a somewhat complicated task. It registers per-thread callbacks to mutate thread-local state. Other OpenSSL APIs, like random number generation, also have thread-local state. In the case of the random number generator, it registered a thread data destructor to clean up random state when the thread is shutting down. This, in turn, sees that the OSSL_LIB_CTX is associated with that thread. If the OSSL_LIB_CTX is freed before the thread has shut down, the thread dtor will access invalid memory. OpenSSL requires you to call `OPENSSL_thread_stop_ex` on _all_ threads before calling `OSSL_LIB_CTX_free` to unhook the context from the thread. This is generally not feasible for .NET. As a solution, we are going to not free the context, and re-use it for each provider. Every provider loaded with `SafeEvpPKeyHandle.OpenKeyFromProvider` will create a context and load that provider into it. The context and provider will remain alive for the duration of the process. The number of providers expected to be used in any application is generally expected to be low - likely two or three. 1. The provider and context are now cached, and kept in a heap-backed buffer. There is no resizing strategy or pre-allocated buffer. Opening a new provider results in re-sizing the array. This strategy is likely fine because there will rarely ever be more than a few providers, as already noted. The resizing is managed by a mutex to synchronize access to the array. We could use something like `pthread_rwlock_t` if we wanted to increase complexity. Given that contention on this mutex would only happen from `OpenKeyFromProvider`, I expect it to be rare. 2. Since the context and provider are now alive permanently, the "extra handle" bookkeeping gets simpler. We no longer need to pass it to destroy, and we no longer need to ref-count it. In fact we don't even need a struct at all anymore, the OSSL_LIB_CTX _is_ the extra handle now. 3. This reverts #129367 since the data dependency is resolved.

Add ActiveIssue for all named key tests to mitigate invalid memory ac…
0328284
…cess

CopilotAI review requested due to automatic review settings June 13, 2026 14:09

github-actionsBot added the area-System.Security label Jun 13, 2026

dotnet-policy-serviceBot assigned vcsjones Jun 13, 2026

Copilotstarted reviewing on behalf of vcsjones June 13, 2026 14:09 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs
Comment threadsrc/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs

Do arg validations, too
77b39b6

vcsjones requested review from PranavSenthilnathan and bartonjs June 13, 2026 14:14

Do the ones in System.Net.Security as well even though they likely re…
cdaa171
…quire manually running

CopilotAI review requested due to automatic review settings June 13, 2026 14:19

Copilotstarted reviewing on behalf of vcsjones June 13, 2026 14:19 View session

CopilotAI reviewed Jun 13, 2026
View reviewed changes

Comment threadsrc/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs

jkotas reviewed Jun 13, 2026
View reviewed changes

Comment thread...libraries/System.Net.Security/tests/FunctionalTests/SslStreamOpenSslNamedKeysTests.manual.cs

jkotas approved these changes Jun 13, 2026
View reviewed changes

vcsjones enabled auto-merge (squash) June 13, 2026 17:06

PranavSenthilnathan approved these changes Jun 13, 2026
View reviewed changes

vcsjones merged commit 9405cac into dotnet:mainJun 13, 2026
92 of 95 checks passed

vcsjones deleted the active-issue-129339 branch June 13, 2026 18:46

build-analysisBot mentioned this pull request Jun 13, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
3 tasks

This was referenced Jun 13, 2026
Arm/Arm64: Segfault in System.Security.Cryptography.Tests#129339
Closed
Keep OSSL_LIB_CTX handles alive forever #129435
Merged

dotnet-milestone-botBot added this to the 11.0-preview6 milestone Jun 17, 2026

github-actionsBot locked and limited conversation to collaborators Jul 18, 2026