Uh oh!
There was an error while loading. Please reload this page.
[ci-scan-feedback] Strengthen dedup queries and block JIT/GC workarounds - #129461
Merged
kotlarmilos merged 3 commits intoJun 16, 2026
Conversation
Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Strengthen dedup queries and block JIT/GC workarounds[ci-scan-feedback] Strengthen dedup queries and block JIT/GC workaroundsJun 16, 2026
Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the agentic workflow instruction docs used by the CI Outer-Loop Failure Scanner/Fixer to (1) improve deduplication against recently-closed KBEs by broadening GitHub search query variations and (2) tighten guidance around JIT/GC/codegen failures to disallow “unrelated-code” workaround PRs.
Changes:
- Expanded “recently-closed KBE” dedup search guidance with additional query patterns (title + stem, and body assertion text).
- Clarified fix policy for JIT/GC/PGO (codegen) failures to require owner hand-off comments rather than workaround PRs in unrelated code.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/shared/create-kbe.instructions.md | Adds additional GitHub search query variations for finding recently-closed predecessors. |
.github/workflows/ci-failure-fix.md | Tightens fixer policy for codegen-related KBEs to block unrelated-code workarounds and require hand-off comments. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
vitek-karas
approved these changes
Jun 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
kotlarmilos
deleted the
copilot/ci-scan-feedback-strengthen-dedup-queries
branch
June 16, 2026 13:08
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
…nds (#129461) The CI Outer-Loop Failure Scanner's recently-closed KBE dedup search (2 queries) missed predecessors when titles were reworded or when the predecessor was integrity-filtered, and its JIT/GC fix policy didn't forbid sidestepping codegen bugs via unrelated-code workarounds. These gaps drove the wrong-closure rate to the 🔴 threshold (30.0%) and produced a rejected workaround PR. ### Changes - **`.github/workflows/shared/create-kbe.instructions.md`** — Expanded the recently-closed KBE search from 2 to 4 query variations: - Added a `[ci-scan]` title + **test-name-stem** search to catch a predecessor reworded across runs (e.g. `Runtime_105619` vs a differently-phrased earlier title). - Added a **distinctive-assertion-substring** body search; assertion text is more stable than titles across runs and survives integrity-filtered/cross-linked predecessors. - **`.github/workflows/ci-failure-fix.md`** — Clarified the JIT / GC / PGO (codegen) fix policy: workarounds in unrelated code (e.g. changing library buffer sizes or API call patterns to sidestep a codegen bug) are equally out of bounds — go straight to the loop-in comment instead of opening a workaround PR. These prose-only edits to the agentic-workflow instruction files aim to reduce the duplicate-closure rate and steer the fixer away from rejected workaround PRs for codegen KBEs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com> Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI Outer-Loop Failure Scanner's recently-closed KBE dedup search (2 queries) missed predecessors when titles were reworded or when the predecessor was integrity-filtered, and its JIT/GC fix policy didn't forbid sidestepping codegen bugs via unrelated-code workarounds. These gaps drove the wrong-closure rate to the 🔴 threshold (30.0%) and produced a rejected workaround PR.
Changes
.github/workflows/shared/create-kbe.instructions.md— Expanded the recently-closed KBE search from 2 to 4 query variations:[ci-scan]title + test-name-stem search to catch a predecessor reworded across runs (e.g.Runtime_105619vs a differently-phrased earlier title)..github/workflows/ci-failure-fix.md— Clarified the JIT / GC / PGO (codegen) fix policy: workarounds in unrelated code (e.g. changing library buffer sizes or API call patterns to sidestep a codegen bug) are equally out of bounds — go straight to the loop-in comment instead of opening a workaround PR.These prose-only edits to the agentic-workflow instruction files aim to reduce the duplicate-closure rate and steer the fixer away from rejected workaround PRs for codegen KBEs.