Uh oh!
There was an error while loading. Please reload this page.
Properly annotate CreateGeometricSequence - #129658
Merged
Merged
Conversation
Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
approved these changes
Jun 20, 2026
MihaZupan
commented
Jun 20, 2026
Member
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreCLR JIT hardware-intrinsic metadata so CreateGeometricSequence is treated as a special-import, no-codegen intrinsic (rather than an InvalidNodeId intrinsic). This allows the intrinsic to exist as a GenTreeHWIntrinsic node (when applicable) and be expanded/optimized by later phases instead of being categorically treated as “invalid node”.
Changes:
- Update xarch intrinsic list entries for
Vector128/256/512.CreateGeometricSequencetoHW_Flag_SpecialImport|HW_Flag_NoCodeGen(preserving AVX-only compatibility where relevant). - Update arm64 intrinsic list entries for
Vector64/128.CreateGeometricSequencetoHW_Flag_SpecialImport|HW_Flag_NoCodeGen.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/jit/hwintrinsiclistxarch.h | Marks Vector128/256/512 CreateGeometricSequence as `SpecialImport |
| src/coreclr/jit/hwintrinsiclistarm64.h | Marks Vector64/Vector128 CreateGeometricSequence as `SpecialImport |
hez2010
commented
Jun 20, 2026
ContributorAuthor
tannergooding
approved these changes
Jun 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
This is a leftover from #127690. We need to annotate `CreateGeometricSequence` as non-invalid node as it might be left as GenTree node to benefit from constant propagation. @tannergooding
ManickaP pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jul 22, 2026
This is a leftover from dotnet#127690. We need to annotate `CreateGeometricSequence` as non-invalid node as it might be left as GenTree node to benefit from constant propagation. @tannergooding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a leftover from #127690.
We need to annotate
CreateGeometricSequenceas non-invalid node as it might be left as GenTree node to benefit from constant propagation.@tannergooding