Delete debugger regdisplay by rcj1 · Pull Request #129671 · dotnet/runtime

rcj1 · 2026-06-21T17:01:00Z

This is not intended to be the final form; I intend to delete these platform-specific register readers altogether. This is just the first stage of a larger refactor, separated out such that we can remove the associated DacDbi API as well as remove the data structure from the API surface.

dotnet-policy-service · 2026-06-21T17:02:19Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR removes the DebuggerREGDISPLAY plumbing from the DacDbi surface area and migrates the right-side/debugger register and stack-walk codepaths to operate directly on DT_CONTEXT (including deleting multiple platform-specific regdisplay conversion helpers).

Changes:

Remove DebuggerREGDISPLAY from native and managed DacDbi APIs (Debugger_STRData no longer carries rd, and ConvertContextToDebuggerRegDisplay is deleted).
Delete platform-specific SetDebuggerREGDISPLAYFromREGDISPLAY helpers and update callers to use DT_CONTEXT-based accessors.
Refactor CordbRegisterSet/CordbNativeFrame to store and consume DT_CONTEXT directly, and adjust CORDbgGetSP to return CORDB_ADDRESS.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs	Updates managed interop definitions to match the removed regdisplay pointer/method.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs	Drops the regdisplay conversion method and updates frame enumeration commentary.
src/coreclr/inc/dacdbi.idl	Removes `DebuggerREGDISPLAY` forward decl and the regdisplay conversion method from the COM IDL.
src/coreclr/debug/shared/riscv64/primitives.cpp	Deletes RISCV64 regdisplay conversion helper.
src/coreclr/debug/shared/loongarch64/primitives.cpp	Deletes LoongArch64 regdisplay conversion helper.
src/coreclr/debug/shared/i386/primitives.cpp	Deletes x86 context/regdisplay conversion helpers.
src/coreclr/debug/shared/arm64/primitives.cpp	Deletes ARM64 regdisplay conversion helper.
src/coreclr/debug/shared/arm/primitives.cpp	Deletes ARM regdisplay conversion helpers.
src/coreclr/debug/shared/amd64/primitives.cpp	Deletes AMD64 context/regdisplay conversion helpers.
src/coreclr/debug/inc/riscv64/primitives.h	Changes `CORDbgGetSP` to return `CORDB_ADDRESS`.
src/coreclr/debug/inc/loongarch64/primitives.h	Changes `CORDbgGetSP` to return `CORDB_ADDRESS`.
src/coreclr/debug/inc/i386/primitives.h	Changes `CORDbgGetSP` to return `CORDB_ADDRESS`.
src/coreclr/debug/inc/dbgipcevents.h	Removes `DebuggerREGDISPLAY` struct and switches SP/FP address helpers to `DT_CONTEXT`.
src/coreclr/debug/inc/dacdbistructures.h	Removes the `DebuggerREGDISPLAY*` field from `Debugger_STRData`.
src/coreclr/debug/inc/dacdbiinterface.h	Removes `ConvertContextToDebuggerRegDisplay` from the native interface.
src/coreclr/debug/inc/common.h	Removes the `DebuggerREGDISPLAY` forward decl and related helper declaration.
src/coreclr/debug/inc/arm64/primitives.h	Changes `CORDbgGetSP` to return `CORDB_ADDRESS`.
src/coreclr/debug/inc/arm/primitives.h	Changes `CORDbgGetSP` to return `CORDB_ADDRESS`.
src/coreclr/debug/inc/amd64/primitives.h	Changes `CORDbgGetSP` to return `CORDB_ADDRESS`.
src/coreclr/debug/ee/i386/regdisplayhelper.cpp	Renames/rebrands helper file header comment to REGDISPLAY-to-REGDISPLAY transfer.
src/coreclr/debug/ee/debugger.h	Removes regdisplay helper declarations/macros no longer applicable.
src/coreclr/debug/ee/CMakeLists.txt	Updates source list to new helper filename.
src/coreclr/debug/ee/amd64/regdisplayhelper.cpp	Renames/rebrands helper file header comment to REGDISPLAY-to-REGDISPLAY transfer.
src/coreclr/debug/di/shimstackwalk.cpp	Adjusts stack pointer handling to the new `CORDbgGetSP` return type.
src/coreclr/debug/di/rsthread.cpp	Refactors register set + native frame code to use `DT_CONTEXT` instead of `DebuggerREGDISPLAY`.
src/coreclr/debug/di/rsstackwalk.cpp	Stops allocating/passing regdisplay buffers; passes only `DT_CONTEXT` through `Debugger_STRData`.
src/coreclr/debug/di/rsregsetcommon.cpp	Updates `CordbRegisterSet` to store a copied `DT_CONTEXT` and use `CORDbgCopyThreadContext`.
src/coreclr/debug/di/rspriv.h	Updates type members and constructor signatures to remove `DebuggerREGDISPLAY` usage.
src/coreclr/debug/di/riscv64/cordbregisterset.cpp	Removes the unused regdisplay-to-context helper (RISCV64 still NYI for GetRegisters).
src/coreclr/debug/di/loongarch64/cordbregisterset.cpp	Refactors register reads to use `DT_CONTEXT` and deduplicates mapping via a helper.
src/coreclr/debug/di/i386/cordbregisterset.cpp	Switches register reads from regdisplay fields to `DT_CONTEXT`.
src/coreclr/debug/di/arm64/cordbregisterset.cpp	Switches register reads from regdisplay fields to `DT_CONTEXT`.
src/coreclr/debug/di/arm/cordbregisterset.cpp	Switches register reads from regdisplay fields to `DT_CONTEXT`.
src/coreclr/debug/di/amd64/cordbregisterset.cpp	Switches register reads from regdisplay fields to `DT_CONTEXT`.
src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp	Deletes regdisplay conversion implementation and stops populating `Debugger_STRData::rd`.
src/coreclr/debug/daccess/dacdbiimpl.h	Removes the regdisplay conversion method declaration from the DAC implementation.

Copilot's findings

Files reviewed: 36/36 changed files
Comments generated: 4

Copilot

Copilot's findings

Files reviewed: 36/36 changed files
Comments generated: 2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 36/36 changed files
Comments generated: 2

max-charlamb

Seems reasonable to me, but @noahfalk may want to take a look.

Looks like there is a build break caused by these changes.

noahfalk

LGTM!

rcj1 · 2026-06-25T13:36:26Z

/ba-g x86 was down

am11 · 2026-06-25T18:21:23Z

+ HRESULT hr = S_OK;
+ EX_TRY
+ {
+ pThread->LoadFloatState();


This is not implemented on loomgarch64 and riscv64, synced them both in #129854

Follow-up on #129671.

This is not intended to be the final form; I intend to delete these platform-specific register readers altogether. This is just the first stage of a larger refactor, separated out such that we can remove the associated DacDbi API as well as remove the data structure from the API surface. --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Follow-up on #129671.

delete debugger regdisplay
d1f2acc

CopilotAI review requested due to automatic review settings June 21, 2026 17:01

github-actionsBot added the area-Diagnostics-coreclr label Jun 21, 2026

Copilotstarted reviewing on behalf of rcj1 June 21, 2026 17:01 View session

dotnet-policy-serviceBot assigned rcj1 Jun 21, 2026

CopilotAI reviewed Jun 21, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs
Comment threadsrc/coreclr/debug/di/rsregsetcommon.cpp
Comment threadsrc/coreclr/debug/di/rsstackwalk.cpp Outdated
Comment threadsrc/coreclr/debug/di/loongarch64/cordbregisterset.cpp

rcj1 added 2 commits June 21, 2026 10:15

code review
2bce9d0

fix build
fd221dc

CopilotAI review requested due to automatic review settings June 21, 2026 18:21

Copilotstarted reviewing on behalf of rcj1 June 21, 2026 18:22 View session

CopilotAI reviewed Jun 21, 2026
View reviewed changes

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs Outdated
Comment threadsrc/coreclr/debug/di/loongarch64/cordbregisterset.cpp

jkotas reviewed Jun 21, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/di/rspriv.h

Potential fix for pull request finding
79bc6f2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings June 22, 2026 05:56

Copilotstarted reviewing on behalf of rcj1 June 22, 2026 05:56 View session

CopilotAI reviewed Jun 22, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/di/rsthread.cpp
Comment threadsrc/coreclr/debug/di/loongarch64/cordbregisterset.cpp

rcj1 requested review from barosiak, max-charlamb and noahfalk June 22, 2026 16:44

max-charlamb approved these changes Jun 22, 2026
View reviewed changes

Comment threadsrc/coreclr/debug/inc/amd64/primitives.h

fix build
eacf48a

build-analysisBot mentioned this pull request Jun 22, 2026
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

noahfalk approved these changes Jun 25, 2026
View reviewed changes

rcj1 merged commit abaf96f into dotnet:mainJun 25, 2026
128 of 136 checks passed

rcj1 deleted the delete-DebuggerREGDISPLAY branch June 25, 2026 13:37

am11 mentioned this pull request Jun 25, 2026
Align RV64's cordbregisterset with LA64 and arm64 #129854
Merged

dotnet-maestroBot mentioned this pull request Jun 25, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7396
Merged

am11 reviewed Jun 25, 2026
View reviewed changes

dotnet-milestone-botBot added this to the 11.0-preview7 milestone Jun 26, 2026

jkotas pushed a commit that referenced this pull request Jul 3, 2026
Align RV64's cordbregisterset with LA64 and arm64 (#129854)
b3f860c
Follow-up on #129671.

eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
Align RV64's cordbregisterset with LA64 and arm64 (#129854)
2dc3ea8
Follow-up on #129671.

github-actionsBot locked and limited conversation to collaborators Jul 27, 2026

Uh oh!

Conversation

rcj1 commented Jun 21, 2026

Uh oh!

dotnet-policy-serviceBot commented Jun 21, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

noahfalk left a comment

Choose a reason for hiding this comment

Uh oh!

rcj1 commented Jun 25, 2026

Uh oh!

Uh oh!

am11Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants