Skip to content

Slim ThreadStressLogData and simplify GetStressMessages API - #129673

Merged
max-charlamb merged 2 commits into
dotnet:mainfrom
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Jul 6, 2026
Merged

Slim ThreadStressLogData and simplify GetStressMessages API#129673
max-charlamb merged 2 commits into
dotnet:mainfrom
max-charlamb:maxcharlamb/stresslog-slim-threaddata

Conversation

@max-charlamb

@max-charlambmax-charlamb commented Jun 21, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Follow-up based on #129272 (comment)

Summary

Reduce the public surface of ThreadStressLogData and simplify the GetStressMessages API signature.

Changes

  • ThreadStressLogData: Trimmed from 8 fields to 3: {Address, ThreadId, WriteHasWrapped}. The removed fields (NextPointer, CurrentPointer, ChunkListHead, ChunkListTail, CurrentWriteChunk) are internal traversal state only needed by the contract implementation.

  • GetStressMessages: Changed from GetStressMessages(ThreadStressLogData threadLog) to GetStressMessages(TargetPointer threadStressLogAddress). The contract re-reads the ThreadStressLog data internally from the address.

  • SOSDacImpl.GetStressLogMessageEnumerator: Simplified -- no longer needs to re-enumerate all threads to find the matching one. Passes the address directly to the contract.

Motivation

Feedback from PR #129272 review (noahfalk): the public ThreadStressLogData record exposed internal data structure implementation details (chunk pointers, write positions) that consumers don't need. Only ThreadId, WriteHasWrapped, and Address are used externally.

Related

CopilotAI review requested due to automatic review settings June 21, 2026 20:10
@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed Jun 21, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR narrows the stress log contract surface by slimming ThreadStressLogData down to essential fields and by changing IStressLog.GetStressMessages to accept a TargetPointer address (instead of a ThreadStressLogData value), updating SOS and tooling call sites accordingly.

Changes:

  • Reduce ThreadStressLogData to { Address, ThreadId, WriteHasWrapped } in the cDAC abstractions/design docs and adjust contract construction.
  • Change GetStressMessages signature to GetStressMessages(TargetPointer threadStressLogAddress) and re-read ThreadStressLog internally in the contract implementation.
  • Update consumers (SOSDacImpl bridge, dump tests, StressLogAnalyzer) to pass the thread log address.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
src/tools/StressLogAnalyzer/src/StressLogAnalyzer.csUpdates calls to GetStressMessages to pass log.Address.
src/native/managed/cdac/tests/DumpTests/StressLogDumpTests.csUpdates contract test to pass thread.Address into GetStressMessages.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.csSimplifies message enumerator creation by passing the thread log address directly to the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.csRefactors contract traversal to accept a thread log address and re-read ThreadStressLog data internally.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.csSlims ThreadStressLogData and updates GetStressMessages signature in the abstraction contract.
docs/design/datacontracts/StressLog.mdUpdates design documentation to reflect slimmer thread data and the new GetStressMessages signature.

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@max-charlamb
max-charlambforce-pushed the maxcharlamb/stresslog-slim-threaddata branch from 0c7050b to 210d5a8CompareJune 21, 2026 20:18
@max-charlamb
max-charlamb marked this pull request as ready for review June 21, 2026 22:33
CopilotAI reviewed Jun 21, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@jkotas

jkotas commented Jun 21, 2026

Copy link
Copy Markdown
Member

Are all fields listed in datadescriptor.inc still needed?

Max Charlamb
Slim ThreadStressLogData and simplify GetStressMessages API
af052a0
Reduce ThreadStressLogData public record from 8 fields to 3:
{Address, ThreadId, WriteHasWrapped}. The removed fields
(NextPointer, CurrentPointer, ChunkListHead, ChunkListTail,
CurrentWriteChunk) are internal traversal state that only the
contract implementation needs.
Change GetStressMessages to take a TargetPointer (the thread stress
log address) instead of the full record. The contract re-reads the
ThreadStressLog data internally from that address.
This also simplifies GetStressLogMessageEnumerator in SOSDacImpl --
it no longer needs to re-enumerate all threads to find the matching
one; it passes the address directly to the contract.
Remove unused StressLogChunk.Prev data descriptor and field (only
used at runtime for the write path, never during dump analysis).
Remove unused StressLogChunkMaxSize constant.
Fix pre-existing StressLogAnalyzer crash: contract version was
specified as numeric 2 instead of string "c2" in the hardcoded
contract descriptor JSON.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed the maxcharlamb/stresslog-slim-threaddata branch from 210d5a8 to af052a0CompareJune 22, 2026 17:45
@max-charlamb

max-charlamb commented Jun 22, 2026

Copy link
Copy Markdown
MemberAuthor

Are all fields listed in datadescriptor.inc still needed?

We don't use StressLogChunk.Prev, I removed that from the datadescriptor and IData type.

This was referenced Jun 22, 2026
Closed
Open
Open
noahfalk
noahfalk approved these changes Jun 25, 2026
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CopilotAI review requested due to automatic review settings July 6, 2026 14:48
CopilotAI reviewed Jul 6, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@build-analysisbuild-analysisBot mentioned this pull request Jul 6, 2026
Closed
rcj1
rcj1 approved these changes Jul 6, 2026
View reviewed changes
@max-charlamb

max-charlamb commented Jul 6, 2026

Copy link
Copy Markdown
MemberAuthor

/ba-g cDAC only change and runtime-diagnostics pipeline passes

@max-charlamb
max-charlamb merged commit 5bac025 into dotnet:mainJul 6, 2026
135 of 139 checks passed
@max-charlamb
max-charlamb deleted the maxcharlamb/stresslog-slim-threaddata branch July 6, 2026 19:37
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jul 7, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview7 milestone Jul 7, 2026
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@max-charlambMax Charlamb
@eiriktsarpalis
Slim ThreadStressLogData and simplify GetStressMessages API (#129673)
09ff047
Follow-up based on
#129272 (comment)
## Summary
Reduce the public surface of `ThreadStressLogData` and simplify the
`GetStressMessages` API signature.
## Changes
- **`ThreadStressLogData`**: Trimmed from 8 fields to 3: `{Address,
ThreadId, WriteHasWrapped}`. The removed fields (`NextPointer`,
`CurrentPointer`, `ChunkListHead`, `ChunkListTail`, `CurrentWriteChunk`)
are internal traversal state only needed by the contract implementation.
- **`GetStressMessages`**: Changed from
`GetStressMessages(ThreadStressLogData threadLog)` to
`GetStressMessages(TargetPointer threadStressLogAddress)`. The contract
re-reads the `ThreadStressLog` data internally from the address.
- **`SOSDacImpl.GetStressLogMessageEnumerator`**: Simplified -- no
longer needs to re-enumerate all threads to find the matching one.
Passes the address directly to the contract.
## Motivation
Feedback from PR #129272 review (noahfalk): the public
`ThreadStressLogData` record exposed internal data structure
implementation details (chunk pointers, write positions) that consumers
don't need. Only `ThreadId`, `WriteHasWrapped`, and `Address` are used
externally.
## Related
- Follow-up to #129272 (Add ISOSDacInterface17 for StressLog enumeration
via cDAC)
Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 7, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@max-charlamb@jkotas@noahfalk@rcj1
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Slim ThreadStressLogData and simplify GetStressMessages API by max-charlamb · Pull Request #129673 · dotnet/runtime · GitHub
Skip to content
Slim ThreadStressLogData and simplify GetStressMessages API - #129673
Merged
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Jul 6, 2026
Merged
Slim ThreadStressLogData and simplify GetStressMessages API#129673
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Jun 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Follow-up based on #129272 (comment)
Summary
Reduce the public surface of ThreadStressLogData and simplify the GetStressMessages API signature.
Changes
  • ThreadStressLogData: Trimmed from 8 fields to 3: {Address, ThreadId, WriteHasWrapped}. The removed fields (NextPointer, CurrentPointer, ChunkListHead, ChunkListTail, CurrentWriteChunk) are internal traversal state only needed by the contract implementation.
  • GetStressMessages: Changed from GetStressMessages(ThreadStressLogData threadLog) to GetStressMessages(TargetPointer threadStressLogAddress). The contract re-reads the ThreadStressLog data internally from the address.
  • SOSDacImpl.GetStressLogMessageEnumerator: Simplified -- no longer needs to re-enumerate all threads to find the matching one. Passes the address directly to the contract.
Motivation
Feedback from PR #129272 review (noahfalk): the public ThreadStressLogData record exposed internal data structure implementation details (chunk pointers, write positions) that consumers don't need. Only ThreadId, WriteHasWrapped, and Address are used externally.
Related
CopilotAI
review requested due to automatic review settings
June 21, 2026 20:10
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR narrows the stress log contract surface by slimming ThreadStressLogData down to essential fields and by changing IStressLog.GetStressMessages to accept a TargetPointer address (instead of a ThreadStressLogData value), updating SOS and tooling call sites accordingly.
Changes:
  • Reduce ThreadStressLogData to { Address, ThreadId, WriteHasWrapped } in the cDAC abstractions/design docs and adjust contract construction.
  • Change GetStressMessages signature to GetStressMessages(TargetPointer threadStressLogAddress) and re-read ThreadStressLog internally in the contract implementation.
  • Update consumers (SOSDacImpl bridge, dump tests, StressLogAnalyzer) to pass the thread log address.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/tools/StressLogAnalyzer/src/StressLogAnalyzer.csUpdates calls to GetStressMessages to pass log.Address.
src/native/managed/cdac/tests/DumpTests/StressLogDumpTests.csUpdates contract test to pass thread.Address into GetStressMessages.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.csSimplifies message enumerator creation by passing the thread log address directly to the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.csRefactors contract traversal to accept a thread log address and re-read ThreadStressLog data internally.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.csSlims ThreadStressLogData and updates GetStressMessages signature in the abstraction contract.
docs/design/datacontracts/StressLog.mdUpdates design documentation to reflect slimmer thread data and the new GetStressMessages signature.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
0c7050b to
210d5a8CompareJune 21, 2026 20:18
@max-charlamb
max-charlamb
marked this pull request as ready for review
June 21, 2026 22:33
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@jkotas
jkotas
commented
Jun 21, 2026

Copy link


Copy Markdown

Member
Are all fields listed in datadescriptor.inc still needed?
Max Charlamb
Slim ThreadStressLogData and simplify GetStressMessages API
af052a0
Reduce ThreadStressLogData public record from 8 fields to 3:
{Address, ThreadId, WriteHasWrapped}. The removed fields
(NextPointer, CurrentPointer, ChunkListHead, ChunkListTail,
CurrentWriteChunk) are internal traversal state that only the
contract implementation needs.
Change GetStressMessages to take a TargetPointer (the thread stress
log address) instead of the full record. The contract re-reads the
ThreadStressLog data internally from that address.
This also simplifies GetStressLogMessageEnumerator in SOSDacImpl --
it no longer needs to re-enumerate all threads to find the matching
one; it passes the address directly to the contract.
Remove unused StressLogChunk.Prev data descriptor and field (only
used at runtime for the write path, never during dump analysis).
Remove unused StressLogChunkMaxSize constant.
Fix pre-existing StressLogAnalyzer crash: contract version was
specified as numeric 2 instead of string "c2" in the hardcoded
contract descriptor JSON.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
210d5a8 to
af052a0CompareJune 22, 2026 17:45
@max-charlamb
max-charlamb
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
Are all fields listed in datadescriptor.inc still needed?
We don't use StressLogChunk.Prev, I removed that from the datadescriptor and IData type.

This was referenced Jun 22, 2026

Closed


Open


Open

noahfalk
noahfalk
approved these changes
Jun 25, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CopilotAI
review requested due to automatic review settings
July 6, 2026 14:48
CopilotAI
reviewed
Jul 6, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

rcj1
rcj1
approved these changes
Jul 6, 2026
View reviewed changes
@max-charlamb
max-charlamb
commented
Jul 6, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and runtime-diagnostics pipeline passes
@max-charlamb
max-charlamb
merged commit 5bac025
into
dotnet:mainJul 6, 2026

135 of 139 checks passed

@max-charlamb
max-charlamb
deleted the

maxcharlamb/stresslog-slim-threaddata

branch
July 6, 2026 19:37
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 7, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@max-charlambMax Charlamb
@eiriktsarpalis
Slim ThreadStressLogData and simplify GetStressMessages API (#129673)
09ff047
Follow-up based on
#129272 (comment)
## Summary
Reduce the public surface of `ThreadStressLogData` and simplify the
`GetStressMessages` API signature.
## Changes
- **`ThreadStressLogData`**: Trimmed from 8 fields to 3: `{Address,
ThreadId, WriteHasWrapped}`. The removed fields (`NextPointer`,
`CurrentPointer`, `ChunkListHead`, `ChunkListTail`, `CurrentWriteChunk`)
are internal traversal state only needed by the contract implementation.
- **`GetStressMessages`**: Changed from
`GetStressMessages(ThreadStressLogData threadLog)` to
`GetStressMessages(TargetPointer threadStressLogAddress)`. The contract
re-reads the `ThreadStressLog` data internally from the address.
- **`SOSDacImpl.GetStressLogMessageEnumerator`**: Simplified -- no
longer needs to re-enumerate all threads to find the matching one.
Passes the address directly to the contract.
## Motivation
Feedback from PR #129272 review (noahfalk): the public
`ThreadStressLogData` record exposed internal data structure
implementation details (chunk pointers, write positions) that consumers
don't need. Only `ThreadId`, `WriteHasWrapped`, and `Address` are used
externally.
## Related
- Follow-up to #129272 (Add ISOSDacInterface17 for StressLog enumeration
via cDAC)
Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 7, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@max-charlamb@jkotas@noahfalk@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Slim ThreadStressLogData and simplify GetStressMessages API by max-charlamb · Pull Request #129673 · dotnet/runtime · GitHub
Skip to content
Slim ThreadStressLogData and simplify GetStressMessages API - #129673
Merged
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Jul 6, 2026
Merged
Slim ThreadStressLogData and simplify GetStressMessages API#129673
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Jun 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Follow-up based on #129272 (comment)
Summary
Reduce the public surface of ThreadStressLogData and simplify the GetStressMessages API signature.
Changes
  • ThreadStressLogData: Trimmed from 8 fields to 3: {Address, ThreadId, WriteHasWrapped}. The removed fields (NextPointer, CurrentPointer, ChunkListHead, ChunkListTail, CurrentWriteChunk) are internal traversal state only needed by the contract implementation.
  • GetStressMessages: Changed from GetStressMessages(ThreadStressLogData threadLog) to GetStressMessages(TargetPointer threadStressLogAddress). The contract re-reads the ThreadStressLog data internally from the address.
  • SOSDacImpl.GetStressLogMessageEnumerator: Simplified -- no longer needs to re-enumerate all threads to find the matching one. Passes the address directly to the contract.
Motivation
Feedback from PR #129272 review (noahfalk): the public ThreadStressLogData record exposed internal data structure implementation details (chunk pointers, write positions) that consumers don't need. Only ThreadId, WriteHasWrapped, and Address are used externally.
Related
CopilotAI
review requested due to automatic review settings
June 21, 2026 20:10
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR narrows the stress log contract surface by slimming ThreadStressLogData down to essential fields and by changing IStressLog.GetStressMessages to accept a TargetPointer address (instead of a ThreadStressLogData value), updating SOS and tooling call sites accordingly.
Changes:
  • Reduce ThreadStressLogData to { Address, ThreadId, WriteHasWrapped } in the cDAC abstractions/design docs and adjust contract construction.
  • Change GetStressMessages signature to GetStressMessages(TargetPointer threadStressLogAddress) and re-read ThreadStressLog internally in the contract implementation.
  • Update consumers (SOSDacImpl bridge, dump tests, StressLogAnalyzer) to pass the thread log address.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/tools/StressLogAnalyzer/src/StressLogAnalyzer.csUpdates calls to GetStressMessages to pass log.Address.
src/native/managed/cdac/tests/DumpTests/StressLogDumpTests.csUpdates contract test to pass thread.Address into GetStressMessages.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.csSimplifies message enumerator creation by passing the thread log address directly to the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.csRefactors contract traversal to accept a thread log address and re-read ThreadStressLog data internally.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.csSlims ThreadStressLogData and updates GetStressMessages signature in the abstraction contract.
docs/design/datacontracts/StressLog.mdUpdates design documentation to reflect slimmer thread data and the new GetStressMessages signature.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
0c7050b to
210d5a8CompareJune 21, 2026 20:18
@max-charlamb
max-charlamb
marked this pull request as ready for review
June 21, 2026 22:33
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@jkotas
jkotas
commented
Jun 21, 2026

Copy link


Copy Markdown

Member
Are all fields listed in datadescriptor.inc still needed?
Max Charlamb
Slim ThreadStressLogData and simplify GetStressMessages API
af052a0
Reduce ThreadStressLogData public record from 8 fields to 3:
{Address, ThreadId, WriteHasWrapped}. The removed fields
(NextPointer, CurrentPointer, ChunkListHead, ChunkListTail,
CurrentWriteChunk) are internal traversal state that only the
contract implementation needs.
Change GetStressMessages to take a TargetPointer (the thread stress
log address) instead of the full record. The contract re-reads the
ThreadStressLog data internally from that address.
This also simplifies GetStressLogMessageEnumerator in SOSDacImpl --
it no longer needs to re-enumerate all threads to find the matching
one; it passes the address directly to the contract.
Remove unused StressLogChunk.Prev data descriptor and field (only
used at runtime for the write path, never during dump analysis).
Remove unused StressLogChunkMaxSize constant.
Fix pre-existing StressLogAnalyzer crash: contract version was
specified as numeric 2 instead of string "c2" in the hardcoded
contract descriptor JSON.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
210d5a8 to
af052a0CompareJune 22, 2026 17:45
@max-charlamb
max-charlamb
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
Are all fields listed in datadescriptor.inc still needed?
We don't use StressLogChunk.Prev, I removed that from the datadescriptor and IData type.

This was referenced Jun 22, 2026

Closed


Open


Open

noahfalk
noahfalk
approved these changes
Jun 25, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CopilotAI
review requested due to automatic review settings
July 6, 2026 14:48
CopilotAI
reviewed
Jul 6, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

rcj1
rcj1
approved these changes
Jul 6, 2026
View reviewed changes
@max-charlamb
max-charlamb
commented
Jul 6, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and runtime-diagnostics pipeline passes
@max-charlamb
max-charlamb
merged commit 5bac025
into
dotnet:mainJul 6, 2026

135 of 139 checks passed

@max-charlamb
max-charlamb
deleted the

maxcharlamb/stresslog-slim-threaddata

branch
July 6, 2026 19:37
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 7, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@max-charlambMax Charlamb
@eiriktsarpalis
Slim ThreadStressLogData and simplify GetStressMessages API (#129673)
09ff047
Follow-up based on
#129272 (comment)
## Summary
Reduce the public surface of `ThreadStressLogData` and simplify the
`GetStressMessages` API signature.
## Changes
- **`ThreadStressLogData`**: Trimmed from 8 fields to 3: `{Address,
ThreadId, WriteHasWrapped}`. The removed fields (`NextPointer`,
`CurrentPointer`, `ChunkListHead`, `ChunkListTail`, `CurrentWriteChunk`)
are internal traversal state only needed by the contract implementation.
- **`GetStressMessages`**: Changed from
`GetStressMessages(ThreadStressLogData threadLog)` to
`GetStressMessages(TargetPointer threadStressLogAddress)`. The contract
re-reads the `ThreadStressLog` data internally from the address.
- **`SOSDacImpl.GetStressLogMessageEnumerator`**: Simplified -- no
longer needs to re-enumerate all threads to find the matching one.
Passes the address directly to the contract.
## Motivation
Feedback from PR #129272 review (noahfalk): the public
`ThreadStressLogData` record exposed internal data structure
implementation details (chunk pointers, write positions) that consumers
don't need. Only `ThreadId`, `WriteHasWrapped`, and `Address` are used
externally.
## Related
- Follow-up to #129272 (Add ISOSDacInterface17 for StressLog enumeration
via cDAC)
Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 7, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@max-charlamb@jkotas@noahfalk@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Slim ThreadStressLogData and simplify GetStressMessages API by max-charlamb · Pull Request #129673 · dotnet/runtime · GitHub
Skip to content
Slim ThreadStressLogData and simplify GetStressMessages API - #129673
Merged
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Jul 6, 2026
Merged
Slim ThreadStressLogData and simplify GetStressMessages API#129673
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Jun 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Follow-up based on #129272 (comment)
Summary
Reduce the public surface of ThreadStressLogData and simplify the GetStressMessages API signature.
Changes
  • ThreadStressLogData: Trimmed from 8 fields to 3: {Address, ThreadId, WriteHasWrapped}. The removed fields (NextPointer, CurrentPointer, ChunkListHead, ChunkListTail, CurrentWriteChunk) are internal traversal state only needed by the contract implementation.
  • GetStressMessages: Changed from GetStressMessages(ThreadStressLogData threadLog) to GetStressMessages(TargetPointer threadStressLogAddress). The contract re-reads the ThreadStressLog data internally from the address.
  • SOSDacImpl.GetStressLogMessageEnumerator: Simplified -- no longer needs to re-enumerate all threads to find the matching one. Passes the address directly to the contract.
Motivation
Feedback from PR #129272 review (noahfalk): the public ThreadStressLogData record exposed internal data structure implementation details (chunk pointers, write positions) that consumers don't need. Only ThreadId, WriteHasWrapped, and Address are used externally.
Related
CopilotAI
review requested due to automatic review settings
June 21, 2026 20:10
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR narrows the stress log contract surface by slimming ThreadStressLogData down to essential fields and by changing IStressLog.GetStressMessages to accept a TargetPointer address (instead of a ThreadStressLogData value), updating SOS and tooling call sites accordingly.
Changes:
  • Reduce ThreadStressLogData to { Address, ThreadId, WriteHasWrapped } in the cDAC abstractions/design docs and adjust contract construction.
  • Change GetStressMessages signature to GetStressMessages(TargetPointer threadStressLogAddress) and re-read ThreadStressLog internally in the contract implementation.
  • Update consumers (SOSDacImpl bridge, dump tests, StressLogAnalyzer) to pass the thread log address.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/tools/StressLogAnalyzer/src/StressLogAnalyzer.csUpdates calls to GetStressMessages to pass log.Address.
src/native/managed/cdac/tests/DumpTests/StressLogDumpTests.csUpdates contract test to pass thread.Address into GetStressMessages.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.csSimplifies message enumerator creation by passing the thread log address directly to the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.csRefactors contract traversal to accept a thread log address and re-read ThreadStressLog data internally.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.csSlims ThreadStressLogData and updates GetStressMessages signature in the abstraction contract.
docs/design/datacontracts/StressLog.mdUpdates design documentation to reflect slimmer thread data and the new GetStressMessages signature.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
0c7050b to
210d5a8CompareJune 21, 2026 20:18
@max-charlamb
max-charlamb
marked this pull request as ready for review
June 21, 2026 22:33
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@jkotas
jkotas
commented
Jun 21, 2026

Copy link


Copy Markdown

Member
Are all fields listed in datadescriptor.inc still needed?
Max Charlamb
Slim ThreadStressLogData and simplify GetStressMessages API
af052a0
Reduce ThreadStressLogData public record from 8 fields to 3:
{Address, ThreadId, WriteHasWrapped}. The removed fields
(NextPointer, CurrentPointer, ChunkListHead, ChunkListTail,
CurrentWriteChunk) are internal traversal state that only the
contract implementation needs.
Change GetStressMessages to take a TargetPointer (the thread stress
log address) instead of the full record. The contract re-reads the
ThreadStressLog data internally from that address.
This also simplifies GetStressLogMessageEnumerator in SOSDacImpl --
it no longer needs to re-enumerate all threads to find the matching
one; it passes the address directly to the contract.
Remove unused StressLogChunk.Prev data descriptor and field (only
used at runtime for the write path, never during dump analysis).
Remove unused StressLogChunkMaxSize constant.
Fix pre-existing StressLogAnalyzer crash: contract version was
specified as numeric 2 instead of string "c2" in the hardcoded
contract descriptor JSON.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
210d5a8 to
af052a0CompareJune 22, 2026 17:45
@max-charlamb
max-charlamb
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
Are all fields listed in datadescriptor.inc still needed?
We don't use StressLogChunk.Prev, I removed that from the datadescriptor and IData type.

This was referenced Jun 22, 2026

Closed


Open


Open

noahfalk
noahfalk
approved these changes
Jun 25, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CopilotAI
review requested due to automatic review settings
July 6, 2026 14:48
CopilotAI
reviewed
Jul 6, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

rcj1
rcj1
approved these changes
Jul 6, 2026
View reviewed changes
@max-charlamb
max-charlamb
commented
Jul 6, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and runtime-diagnostics pipeline passes
@max-charlamb
max-charlamb
merged commit 5bac025
into
dotnet:mainJul 6, 2026

135 of 139 checks passed

@max-charlamb
max-charlamb
deleted the

maxcharlamb/stresslog-slim-threaddata

branch
July 6, 2026 19:37
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 7, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@max-charlambMax Charlamb
@eiriktsarpalis
Slim ThreadStressLogData and simplify GetStressMessages API (#129673)
09ff047
Follow-up based on
#129272 (comment)
## Summary
Reduce the public surface of `ThreadStressLogData` and simplify the
`GetStressMessages` API signature.
## Changes
- **`ThreadStressLogData`**: Trimmed from 8 fields to 3: `{Address,
ThreadId, WriteHasWrapped}`. The removed fields (`NextPointer`,
`CurrentPointer`, `ChunkListHead`, `ChunkListTail`, `CurrentWriteChunk`)
are internal traversal state only needed by the contract implementation.
- **`GetStressMessages`**: Changed from
`GetStressMessages(ThreadStressLogData threadLog)` to
`GetStressMessages(TargetPointer threadStressLogAddress)`. The contract
re-reads the `ThreadStressLog` data internally from the address.
- **`SOSDacImpl.GetStressLogMessageEnumerator`**: Simplified -- no
longer needs to re-enumerate all threads to find the matching one.
Passes the address directly to the contract.
## Motivation
Feedback from PR #129272 review (noahfalk): the public
`ThreadStressLogData` record exposed internal data structure
implementation details (chunk pointers, write positions) that consumers
don't need. Only `ThreadId`, `WriteHasWrapped`, and `Address` are used
externally.
## Related
- Follow-up to #129272 (Add ISOSDacInterface17 for StressLog enumeration
via cDAC)
Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 7, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@max-charlamb@jkotas@noahfalk@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Slim ThreadStressLogData and simplify GetStressMessages API by max-charlamb · Pull Request #129673 · dotnet/runtime · GitHub
Skip to content
Slim ThreadStressLogData and simplify GetStressMessages API - #129673
Merged
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Jul 6, 2026
Merged
Slim ThreadStressLogData and simplify GetStressMessages API#129673
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Jun 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Follow-up based on #129272 (comment)
Summary
Reduce the public surface of ThreadStressLogData and simplify the GetStressMessages API signature.
Changes
  • ThreadStressLogData: Trimmed from 8 fields to 3: {Address, ThreadId, WriteHasWrapped}. The removed fields (NextPointer, CurrentPointer, ChunkListHead, ChunkListTail, CurrentWriteChunk) are internal traversal state only needed by the contract implementation.
  • GetStressMessages: Changed from GetStressMessages(ThreadStressLogData threadLog) to GetStressMessages(TargetPointer threadStressLogAddress). The contract re-reads the ThreadStressLog data internally from the address.
  • SOSDacImpl.GetStressLogMessageEnumerator: Simplified -- no longer needs to re-enumerate all threads to find the matching one. Passes the address directly to the contract.
Motivation
Feedback from PR #129272 review (noahfalk): the public ThreadStressLogData record exposed internal data structure implementation details (chunk pointers, write positions) that consumers don't need. Only ThreadId, WriteHasWrapped, and Address are used externally.
Related
CopilotAI
review requested due to automatic review settings
June 21, 2026 20:10
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR narrows the stress log contract surface by slimming ThreadStressLogData down to essential fields and by changing IStressLog.GetStressMessages to accept a TargetPointer address (instead of a ThreadStressLogData value), updating SOS and tooling call sites accordingly.
Changes:
  • Reduce ThreadStressLogData to { Address, ThreadId, WriteHasWrapped } in the cDAC abstractions/design docs and adjust contract construction.
  • Change GetStressMessages signature to GetStressMessages(TargetPointer threadStressLogAddress) and re-read ThreadStressLog internally in the contract implementation.
  • Update consumers (SOSDacImpl bridge, dump tests, StressLogAnalyzer) to pass the thread log address.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/tools/StressLogAnalyzer/src/StressLogAnalyzer.csUpdates calls to GetStressMessages to pass log.Address.
src/native/managed/cdac/tests/DumpTests/StressLogDumpTests.csUpdates contract test to pass thread.Address into GetStressMessages.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.csSimplifies message enumerator creation by passing the thread log address directly to the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.csRefactors contract traversal to accept a thread log address and re-read ThreadStressLog data internally.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.csSlims ThreadStressLogData and updates GetStressMessages signature in the abstraction contract.
docs/design/datacontracts/StressLog.mdUpdates design documentation to reflect slimmer thread data and the new GetStressMessages signature.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
0c7050b to
210d5a8CompareJune 21, 2026 20:18
@max-charlamb
max-charlamb
marked this pull request as ready for review
June 21, 2026 22:33
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@jkotas
jkotas
commented
Jun 21, 2026

Copy link


Copy Markdown

Member
Are all fields listed in datadescriptor.inc still needed?
Max Charlamb
Slim ThreadStressLogData and simplify GetStressMessages API
af052a0
Reduce ThreadStressLogData public record from 8 fields to 3:
{Address, ThreadId, WriteHasWrapped}. The removed fields
(NextPointer, CurrentPointer, ChunkListHead, ChunkListTail,
CurrentWriteChunk) are internal traversal state that only the
contract implementation needs.
Change GetStressMessages to take a TargetPointer (the thread stress
log address) instead of the full record. The contract re-reads the
ThreadStressLog data internally from that address.
This also simplifies GetStressLogMessageEnumerator in SOSDacImpl --
it no longer needs to re-enumerate all threads to find the matching
one; it passes the address directly to the contract.
Remove unused StressLogChunk.Prev data descriptor and field (only
used at runtime for the write path, never during dump analysis).
Remove unused StressLogChunkMaxSize constant.
Fix pre-existing StressLogAnalyzer crash: contract version was
specified as numeric 2 instead of string "c2" in the hardcoded
contract descriptor JSON.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
210d5a8 to
af052a0CompareJune 22, 2026 17:45
@max-charlamb
max-charlamb
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
Are all fields listed in datadescriptor.inc still needed?
We don't use StressLogChunk.Prev, I removed that from the datadescriptor and IData type.

This was referenced Jun 22, 2026

Closed


Open


Open

noahfalk
noahfalk
approved these changes
Jun 25, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CopilotAI
review requested due to automatic review settings
July 6, 2026 14:48
CopilotAI
reviewed
Jul 6, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

rcj1
rcj1
approved these changes
Jul 6, 2026
View reviewed changes
@max-charlamb
max-charlamb
commented
Jul 6, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and runtime-diagnostics pipeline passes
@max-charlamb
max-charlamb
merged commit 5bac025
into
dotnet:mainJul 6, 2026

135 of 139 checks passed

@max-charlamb
max-charlamb
deleted the

maxcharlamb/stresslog-slim-threaddata

branch
July 6, 2026 19:37
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 7, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@max-charlambMax Charlamb
@eiriktsarpalis
Slim ThreadStressLogData and simplify GetStressMessages API (#129673)
09ff047
Follow-up based on
#129272 (comment)
## Summary
Reduce the public surface of `ThreadStressLogData` and simplify the
`GetStressMessages` API signature.
## Changes
- **`ThreadStressLogData`**: Trimmed from 8 fields to 3: `{Address,
ThreadId, WriteHasWrapped}`. The removed fields (`NextPointer`,
`CurrentPointer`, `ChunkListHead`, `ChunkListTail`, `CurrentWriteChunk`)
are internal traversal state only needed by the contract implementation.
- **`GetStressMessages`**: Changed from
`GetStressMessages(ThreadStressLogData threadLog)` to
`GetStressMessages(TargetPointer threadStressLogAddress)`. The contract
re-reads the `ThreadStressLog` data internally from the address.
- **`SOSDacImpl.GetStressLogMessageEnumerator`**: Simplified -- no
longer needs to re-enumerate all threads to find the matching one.
Passes the address directly to the contract.
## Motivation
Feedback from PR #129272 review (noahfalk): the public
`ThreadStressLogData` record exposed internal data structure
implementation details (chunk pointers, write positions) that consumers
don't need. Only `ThreadId`, `WriteHasWrapped`, and `Address` are used
externally.
## Related
- Follow-up to #129272 (Add ISOSDacInterface17 for StressLog enumeration
via cDAC)
Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 7, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@max-charlamb@jkotas@noahfalk@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Slim ThreadStressLogData and simplify GetStressMessages API by max-charlamb · Pull Request #129673 · dotnet/runtime · GitHub
Skip to content
Slim ThreadStressLogData and simplify GetStressMessages API - #129673
Merged
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Jul 6, 2026
Merged
Slim ThreadStressLogData and simplify GetStressMessages API#129673
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Jun 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Follow-up based on #129272 (comment)
Summary
Reduce the public surface of ThreadStressLogData and simplify the GetStressMessages API signature.
Changes
  • ThreadStressLogData: Trimmed from 8 fields to 3: {Address, ThreadId, WriteHasWrapped}. The removed fields (NextPointer, CurrentPointer, ChunkListHead, ChunkListTail, CurrentWriteChunk) are internal traversal state only needed by the contract implementation.
  • GetStressMessages: Changed from GetStressMessages(ThreadStressLogData threadLog) to GetStressMessages(TargetPointer threadStressLogAddress). The contract re-reads the ThreadStressLog data internally from the address.
  • SOSDacImpl.GetStressLogMessageEnumerator: Simplified -- no longer needs to re-enumerate all threads to find the matching one. Passes the address directly to the contract.
Motivation
Feedback from PR #129272 review (noahfalk): the public ThreadStressLogData record exposed internal data structure implementation details (chunk pointers, write positions) that consumers don't need. Only ThreadId, WriteHasWrapped, and Address are used externally.
Related
CopilotAI
review requested due to automatic review settings
June 21, 2026 20:10
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR narrows the stress log contract surface by slimming ThreadStressLogData down to essential fields and by changing IStressLog.GetStressMessages to accept a TargetPointer address (instead of a ThreadStressLogData value), updating SOS and tooling call sites accordingly.
Changes:
  • Reduce ThreadStressLogData to { Address, ThreadId, WriteHasWrapped } in the cDAC abstractions/design docs and adjust contract construction.
  • Change GetStressMessages signature to GetStressMessages(TargetPointer threadStressLogAddress) and re-read ThreadStressLog internally in the contract implementation.
  • Update consumers (SOSDacImpl bridge, dump tests, StressLogAnalyzer) to pass the thread log address.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/tools/StressLogAnalyzer/src/StressLogAnalyzer.csUpdates calls to GetStressMessages to pass log.Address.
src/native/managed/cdac/tests/DumpTests/StressLogDumpTests.csUpdates contract test to pass thread.Address into GetStressMessages.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.csSimplifies message enumerator creation by passing the thread log address directly to the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.csRefactors contract traversal to accept a thread log address and re-read ThreadStressLog data internally.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.csSlims ThreadStressLogData and updates GetStressMessages signature in the abstraction contract.
docs/design/datacontracts/StressLog.mdUpdates design documentation to reflect slimmer thread data and the new GetStressMessages signature.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
0c7050b to
210d5a8CompareJune 21, 2026 20:18
@max-charlamb
max-charlamb
marked this pull request as ready for review
June 21, 2026 22:33
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@jkotas
jkotas
commented
Jun 21, 2026

Copy link


Copy Markdown

Member
Are all fields listed in datadescriptor.inc still needed?
Max Charlamb
Slim ThreadStressLogData and simplify GetStressMessages API
af052a0
Reduce ThreadStressLogData public record from 8 fields to 3:
{Address, ThreadId, WriteHasWrapped}. The removed fields
(NextPointer, CurrentPointer, ChunkListHead, ChunkListTail,
CurrentWriteChunk) are internal traversal state that only the
contract implementation needs.
Change GetStressMessages to take a TargetPointer (the thread stress
log address) instead of the full record. The contract re-reads the
ThreadStressLog data internally from that address.
This also simplifies GetStressLogMessageEnumerator in SOSDacImpl --
it no longer needs to re-enumerate all threads to find the matching
one; it passes the address directly to the contract.
Remove unused StressLogChunk.Prev data descriptor and field (only
used at runtime for the write path, never during dump analysis).
Remove unused StressLogChunkMaxSize constant.
Fix pre-existing StressLogAnalyzer crash: contract version was
specified as numeric 2 instead of string "c2" in the hardcoded
contract descriptor JSON.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
210d5a8 to
af052a0CompareJune 22, 2026 17:45
@max-charlamb
max-charlamb
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
Are all fields listed in datadescriptor.inc still needed?
We don't use StressLogChunk.Prev, I removed that from the datadescriptor and IData type.

This was referenced Jun 22, 2026

Closed


Open


Open

noahfalk
noahfalk
approved these changes
Jun 25, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CopilotAI
review requested due to automatic review settings
July 6, 2026 14:48
CopilotAI
reviewed
Jul 6, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

rcj1
rcj1
approved these changes
Jul 6, 2026
View reviewed changes
@max-charlamb
max-charlamb
commented
Jul 6, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and runtime-diagnostics pipeline passes
@max-charlamb
max-charlamb
merged commit 5bac025
into
dotnet:mainJul 6, 2026

135 of 139 checks passed

@max-charlamb
max-charlamb
deleted the

maxcharlamb/stresslog-slim-threaddata

branch
July 6, 2026 19:37
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 7, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@max-charlambMax Charlamb
@eiriktsarpalis
Slim ThreadStressLogData and simplify GetStressMessages API (#129673)
09ff047
Follow-up based on
#129272 (comment)
## Summary
Reduce the public surface of `ThreadStressLogData` and simplify the
`GetStressMessages` API signature.
## Changes
- **`ThreadStressLogData`**: Trimmed from 8 fields to 3: `{Address,
ThreadId, WriteHasWrapped}`. The removed fields (`NextPointer`,
`CurrentPointer`, `ChunkListHead`, `ChunkListTail`, `CurrentWriteChunk`)
are internal traversal state only needed by the contract implementation.
- **`GetStressMessages`**: Changed from
`GetStressMessages(ThreadStressLogData threadLog)` to
`GetStressMessages(TargetPointer threadStressLogAddress)`. The contract
re-reads the `ThreadStressLog` data internally from the address.
- **`SOSDacImpl.GetStressLogMessageEnumerator`**: Simplified -- no
longer needs to re-enumerate all threads to find the matching one.
Passes the address directly to the contract.
## Motivation
Feedback from PR #129272 review (noahfalk): the public
`ThreadStressLogData` record exposed internal data structure
implementation details (chunk pointers, write positions) that consumers
don't need. Only `ThreadId`, `WriteHasWrapped`, and `Address` are used
externally.
## Related
- Follow-up to #129272 (Add ISOSDacInterface17 for StressLog enumeration
via cDAC)
Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 7, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@max-charlamb@jkotas@noahfalk@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Slim ThreadStressLogData and simplify GetStressMessages API by max-charlamb · Pull Request #129673 · dotnet/runtime · GitHub
Skip to content
Slim ThreadStressLogData and simplify GetStressMessages API - #129673
Merged
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Jul 6, 2026
Merged
Slim ThreadStressLogData and simplify GetStressMessages API#129673
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Jun 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Follow-up based on #129272 (comment)
Summary
Reduce the public surface of ThreadStressLogData and simplify the GetStressMessages API signature.
Changes
  • ThreadStressLogData: Trimmed from 8 fields to 3: {Address, ThreadId, WriteHasWrapped}. The removed fields (NextPointer, CurrentPointer, ChunkListHead, ChunkListTail, CurrentWriteChunk) are internal traversal state only needed by the contract implementation.
  • GetStressMessages: Changed from GetStressMessages(ThreadStressLogData threadLog) to GetStressMessages(TargetPointer threadStressLogAddress). The contract re-reads the ThreadStressLog data internally from the address.
  • SOSDacImpl.GetStressLogMessageEnumerator: Simplified -- no longer needs to re-enumerate all threads to find the matching one. Passes the address directly to the contract.
Motivation
Feedback from PR #129272 review (noahfalk): the public ThreadStressLogData record exposed internal data structure implementation details (chunk pointers, write positions) that consumers don't need. Only ThreadId, WriteHasWrapped, and Address are used externally.
Related
CopilotAI
review requested due to automatic review settings
June 21, 2026 20:10
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR narrows the stress log contract surface by slimming ThreadStressLogData down to essential fields and by changing IStressLog.GetStressMessages to accept a TargetPointer address (instead of a ThreadStressLogData value), updating SOS and tooling call sites accordingly.
Changes:
  • Reduce ThreadStressLogData to { Address, ThreadId, WriteHasWrapped } in the cDAC abstractions/design docs and adjust contract construction.
  • Change GetStressMessages signature to GetStressMessages(TargetPointer threadStressLogAddress) and re-read ThreadStressLog internally in the contract implementation.
  • Update consumers (SOSDacImpl bridge, dump tests, StressLogAnalyzer) to pass the thread log address.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/tools/StressLogAnalyzer/src/StressLogAnalyzer.csUpdates calls to GetStressMessages to pass log.Address.
src/native/managed/cdac/tests/DumpTests/StressLogDumpTests.csUpdates contract test to pass thread.Address into GetStressMessages.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.csSimplifies message enumerator creation by passing the thread log address directly to the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.csRefactors contract traversal to accept a thread log address and re-read ThreadStressLog data internally.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.csSlims ThreadStressLogData and updates GetStressMessages signature in the abstraction contract.
docs/design/datacontracts/StressLog.mdUpdates design documentation to reflect slimmer thread data and the new GetStressMessages signature.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
0c7050b to
210d5a8CompareJune 21, 2026 20:18
@max-charlamb
max-charlamb
marked this pull request as ready for review
June 21, 2026 22:33
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@jkotas
jkotas
commented
Jun 21, 2026

Copy link


Copy Markdown

Member
Are all fields listed in datadescriptor.inc still needed?
Max Charlamb
Slim ThreadStressLogData and simplify GetStressMessages API
af052a0
Reduce ThreadStressLogData public record from 8 fields to 3:
{Address, ThreadId, WriteHasWrapped}. The removed fields
(NextPointer, CurrentPointer, ChunkListHead, ChunkListTail,
CurrentWriteChunk) are internal traversal state that only the
contract implementation needs.
Change GetStressMessages to take a TargetPointer (the thread stress
log address) instead of the full record. The contract re-reads the
ThreadStressLog data internally from that address.
This also simplifies GetStressLogMessageEnumerator in SOSDacImpl --
it no longer needs to re-enumerate all threads to find the matching
one; it passes the address directly to the contract.
Remove unused StressLogChunk.Prev data descriptor and field (only
used at runtime for the write path, never during dump analysis).
Remove unused StressLogChunkMaxSize constant.
Fix pre-existing StressLogAnalyzer crash: contract version was
specified as numeric 2 instead of string "c2" in the hardcoded
contract descriptor JSON.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
210d5a8 to
af052a0CompareJune 22, 2026 17:45
@max-charlamb
max-charlamb
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
Are all fields listed in datadescriptor.inc still needed?
We don't use StressLogChunk.Prev, I removed that from the datadescriptor and IData type.

This was referenced Jun 22, 2026

Closed


Open


Open

noahfalk
noahfalk
approved these changes
Jun 25, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CopilotAI
review requested due to automatic review settings
July 6, 2026 14:48
CopilotAI
reviewed
Jul 6, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

rcj1
rcj1
approved these changes
Jul 6, 2026
View reviewed changes
@max-charlamb
max-charlamb
commented
Jul 6, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and runtime-diagnostics pipeline passes
@max-charlamb
max-charlamb
merged commit 5bac025
into
dotnet:mainJul 6, 2026

135 of 139 checks passed

@max-charlamb
max-charlamb
deleted the

maxcharlamb/stresslog-slim-threaddata

branch
July 6, 2026 19:37
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 7, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@max-charlambMax Charlamb
@eiriktsarpalis
Slim ThreadStressLogData and simplify GetStressMessages API (#129673)
09ff047
Follow-up based on
#129272 (comment)
## Summary
Reduce the public surface of `ThreadStressLogData` and simplify the
`GetStressMessages` API signature.
## Changes
- **`ThreadStressLogData`**: Trimmed from 8 fields to 3: `{Address,
ThreadId, WriteHasWrapped}`. The removed fields (`NextPointer`,
`CurrentPointer`, `ChunkListHead`, `ChunkListTail`, `CurrentWriteChunk`)
are internal traversal state only needed by the contract implementation.
- **`GetStressMessages`**: Changed from
`GetStressMessages(ThreadStressLogData threadLog)` to
`GetStressMessages(TargetPointer threadStressLogAddress)`. The contract
re-reads the `ThreadStressLog` data internally from the address.
- **`SOSDacImpl.GetStressLogMessageEnumerator`**: Simplified -- no
longer needs to re-enumerate all threads to find the matching one.
Passes the address directly to the contract.
## Motivation
Feedback from PR #129272 review (noahfalk): the public
`ThreadStressLogData` record exposed internal data structure
implementation details (chunk pointers, write positions) that consumers
don't need. Only `ThreadId`, `WriteHasWrapped`, and `Address` are used
externally.
## Related
- Follow-up to #129272 (Add ISOSDacInterface17 for StressLog enumeration
via cDAC)
Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 7, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@max-charlamb@jkotas@noahfalk@rcj1

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Slim ThreadStressLogData and simplify GetStressMessages API by max-charlamb · Pull Request #129673 · dotnet/runtime · GitHub
Skip to content
Slim ThreadStressLogData and simplify GetStressMessages API - #129673
Merged
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Jul 6, 2026
Merged
Slim ThreadStressLogData and simplify GetStressMessages API#129673
max-charlamb merged 2 commits into
dotnet:mainfrom 
max-charlamb:maxcharlamb/stresslog-slim-threaddata
Conversation
@max-charlamb
@max-charlambmax-charlamb
commented
Jun 21, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Follow-up based on #129272 (comment)
Summary
Reduce the public surface of ThreadStressLogData and simplify the GetStressMessages API signature.
Changes
  • ThreadStressLogData: Trimmed from 8 fields to 3: {Address, ThreadId, WriteHasWrapped}. The removed fields (NextPointer, CurrentPointer, ChunkListHead, ChunkListTail, CurrentWriteChunk) are internal traversal state only needed by the contract implementation.
  • GetStressMessages: Changed from GetStressMessages(ThreadStressLogData threadLog) to GetStressMessages(TargetPointer threadStressLogAddress). The contract re-reads the ThreadStressLog data internally from the address.
  • SOSDacImpl.GetStressLogMessageEnumerator: Simplified -- no longer needs to re-enumerate all threads to find the matching one. Passes the address directly to the contract.
Motivation
Feedback from PR #129272 review (noahfalk): the public ThreadStressLogData record exposed internal data structure implementation details (chunk pointers, write positions) that consumers don't need. Only ThreadId, WriteHasWrapped, and Address are used externally.
Related
CopilotAI
review requested due to automatic review settings
June 21, 2026 20:10
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 21, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag

See info in area-owners.md if you want to be subscribed.
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR narrows the stress log contract surface by slimming ThreadStressLogData down to essential fields and by changing IStressLog.GetStressMessages to accept a TargetPointer address (instead of a ThreadStressLogData value), updating SOS and tooling call sites accordingly.
Changes:
  • Reduce ThreadStressLogData to { Address, ThreadId, WriteHasWrapped } in the cDAC abstractions/design docs and adjust contract construction.
  • Change GetStressMessages signature to GetStressMessages(TargetPointer threadStressLogAddress) and re-read ThreadStressLog internally in the contract implementation.
  • Update consumers (SOSDacImpl bridge, dump tests, StressLogAnalyzer) to pass the thread log address.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
src/tools/StressLogAnalyzer/src/StressLogAnalyzer.csUpdates calls to GetStressMessages to pass log.Address.
src/native/managed/cdac/tests/DumpTests/StressLogDumpTests.csUpdates contract test to pass thread.Address into GetStressMessages.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.csSimplifies message enumerator creation by passing the thread log address directly to the contract.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.csRefactors contract traversal to accept a thread log address and re-read ThreadStressLog data internally.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.csSlims ThreadStressLogData and updates GetStressMessages signature in the abstraction contract.
docs/design/datacontracts/StressLog.mdUpdates design documentation to reflect slimmer thread data and the new GetStressMessages signature.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
0c7050b to
210d5a8CompareJune 21, 2026 20:18
@max-charlamb
max-charlamb
marked this pull request as ready for review
June 21, 2026 22:33
CopilotAI
reviewed
Jun 21, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comment threadsrc/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@jkotas
jkotas
commented
Jun 21, 2026

Copy link


Copy Markdown

Member
Are all fields listed in datadescriptor.inc still needed?
Max Charlamb
Slim ThreadStressLogData and simplify GetStressMessages API
af052a0
Reduce ThreadStressLogData public record from 8 fields to 3:
{Address, ThreadId, WriteHasWrapped}. The removed fields
(NextPointer, CurrentPointer, ChunkListHead, ChunkListTail,
CurrentWriteChunk) are internal traversal state that only the
contract implementation needs.
Change GetStressMessages to take a TargetPointer (the thread stress
log address) instead of the full record. The contract re-reads the
ThreadStressLog data internally from that address.
This also simplifies GetStressLogMessageEnumerator in SOSDacImpl --
it no longer needs to re-enumerate all threads to find the matching
one; it passes the address directly to the contract.
Remove unused StressLogChunk.Prev data descriptor and field (only
used at runtime for the write path, never during dump analysis).
Remove unused StressLogChunkMaxSize constant.
Fix pre-existing StressLogAnalyzer crash: contract version was
specified as numeric 2 instead of string "c2" in the hardcoded
contract descriptor JSON.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@max-charlamb
max-charlambforce-pushed
the
maxcharlamb/stresslog-slim-threaddata
branch
from
210d5a8 to
af052a0CompareJune 22, 2026 17:45
@max-charlamb
max-charlamb
commented
Jun 22, 2026

Copy link


Copy Markdown

MemberAuthor
Are all fields listed in datadescriptor.inc still needed?
We don't use StressLogChunk.Prev, I removed that from the datadescriptor and IData type.

This was referenced Jun 22, 2026

Closed


Open


Open

noahfalk
noahfalk
approved these changes
Jun 25, 2026
View reviewed changes
@noahfalknoahfalk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CopilotAI
review requested due to automatic review settings
July 6, 2026 14:48
CopilotAI
reviewed
Jul 6, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comment thread...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StressLog.cs
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

rcj1
rcj1
approved these changes
Jul 6, 2026
View reviewed changes
@max-charlamb
max-charlamb
commented
Jul 6, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g cDAC only change and runtime-diagnostics pipeline passes
@max-charlamb
max-charlamb
merged commit 5bac025
into
dotnet:mainJul 6, 2026

135 of 139 checks passed

@max-charlamb
max-charlamb
deleted the

maxcharlamb/stresslog-slim-threaddata

branch
July 6, 2026 19:37
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 7, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@max-charlambMax Charlamb
@eiriktsarpalis
Slim ThreadStressLogData and simplify GetStressMessages API (#129673)
09ff047
Follow-up based on
#129272 (comment)
## Summary
Reduce the public surface of `ThreadStressLogData` and simplify the
`GetStressMessages` API signature.
## Changes
- **`ThreadStressLogData`**: Trimmed from 8 fields to 3: `{Address,
ThreadId, WriteHasWrapped}`. The removed fields (`NextPointer`,
`CurrentPointer`, `ChunkListHead`, `ChunkListTail`, `CurrentWriteChunk`)
are internal traversal state only needed by the contract implementation.
- **`GetStressMessages`**: Changed from
`GetStressMessages(ThreadStressLogData threadLog)` to
`GetStressMessages(TargetPointer threadStressLogAddress)`. The contract
re-reads the `ThreadStressLog` data internally from the address.
- **`SOSDacImpl.GetStressLogMessageEnumerator`**: Simplified -- no
longer needs to re-enumerate all threads to find the matching one.
Passes the address directly to the contract.
## Motivation
Feedback from PR #129272 review (noahfalk): the public
`ThreadStressLogData` record exposed internal data structure
implementation details (chunk pointers, write positions) that consumers
don't need. Only `ThreadId`, `WriteHasWrapped`, and `Address` are used
externally.
## Related
- Follow-up to #129272 (Add ISOSDacInterface17 for StressLog enumeration
via cDAC)
Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 7, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@noahfalknoahfalknoahfalk approved these changes
@rcj1rcj1rcj1 approved these changes

Assignees

@max-charlambmax-charlamb

Labels

area-Diagnostics-cdac

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@max-charlamb@jkotas@noahfalk@rcj1