Skip to content

Fix ValueType.GetHashCode for nested generic field - #129728

Merged
jkotas merged 2 commits into
dotnet:mainfrom
huoyaoyuan:issue-129692
Jun 23, 2026
Merged

Fix ValueType.GetHashCode for nested generic field#129728
jkotas merged 2 commits into
dotnet:mainfrom
huoyaoyuan:issue-129692

Conversation

@huoyaoyuan

Copy link
Copy Markdown
Member

Fixes#129692.

Note: this is not totally a regression. It's an uncovered case while fixing incorrect behavior in #98754.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jun 23, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

@jkotas

Copy link
Copy Markdown
Member

/azp run runtime-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@huoyaoyuan

Copy link
Copy Markdown
MemberAuthor

The failures don't seem related (ARM intrinsic and interop with runtime async).

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas
jkotas merged commit e785632 into dotnet:mainJun 23, 2026
172 of 182 checks passed
@jkotas

Copy link
Copy Markdown
Member

/backport to release/10.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0 (link to workflow run)

@huoyaoyuan
huoyaoyuan deleted the issue-129692 branch June 23, 2026 13:30
steveisok pushed a commit that referenced this pull request Jun 23, 2026
…29744)
Backport of #129728 to release/10.0
/cc @jkotas@huoyaoyuan
## Customer Impact
- [x] Customer reported
- [ ] Found internally
Crash in default ValueType.GetHashCode implementation for value types
with generic type fields.
## Regression
- [x] Yes
- [ ] No
Introduced by #98754
## Testing
Targeted test
## Risk
Low
---------
Co-authored-by: Huo Yaoyuan <huoyaoyuan@hotmail.com>
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview6 milestone Jun 24, 2026
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
Fixes#129692.
Note: this is not totally a regression. It's an uncovered case while
fixing incorrect behavior in #98754.
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 24, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression with generics from .NET 8 To .Net 10

2 participants

@huoyaoyuan@jkotas