Skip to content

Add HttpMethod.Query to static method test data - #129790

Merged
MihaZupan merged 8 commits into
dotnet:mainfrom
NicoAvanzDev:httpmethod-query-test-data
Jun 26, 2026
Merged

Add HttpMethod.Query to static method test data#129790
MihaZupan merged 8 commits into
dotnet:mainfrom
NicoAvanzDev:httpmethod-query-test-data

Conversation

@NicoAvanzDev

@NicoAvanzDevNicoAvanzDev commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add HttpMethod.Query to the shared static HttpMethod test data.
  • Ensure the static-method hash-code coverage includes the QUERY singleton.

Testing

  • .\build.cmd -subset clr+libs -rc Release
  • .\dotnet.cmd test src\libraries\System.Net.Http\tests\FunctionalTests\System.Net.Http.Functional.Tests.csproj --filter FullyQualifiedName~HttpMethodTest

CopilotAI review requested due to automatic review settings June 24, 2026 07:44
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jun 24, 2026
@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed Jun 24, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the HttpMethodTest functional tests to include the HttpMethod.Query singleton in the shared static-method test data used by the hash-code theory, improving coverage consistency for built-in HttpMethod instances.

Changes:

  • Add HttpMethod.Query to the StaticHttpMethods test data set used by [MemberData].
  • Update the static-method list formatting to accommodate the new entry.

Comment threadsrc/libraries/System.Net.Http/tests/FunctionalTests/HttpMethodTest.cs Outdated
@NicoAvanzDevNicoAvanzDev mentioned this pull request Jun 24, 2026
Open
This was referenced Jun 24, 2026
Open
Closed
Open
Closed
CopilotAI mentioned this pull request Jun 24, 2026
Closed
@NicoAvanzDev
test: consolidate StaticHttpMethods and remove duplication
4e48697
Replace separate MemberData lists with a single canonical StaticHttpMethods
List<HttpMethod> containing all known HTTP methods (Connect, Delete, Get, Head,
Options, Patch, Post, Put, Query, Trace).
Convert GetHashCode_StaticMethods and Parse_KnownMethod tests from Theory
with MemberData to Fact with foreach loops over StaticHttpMethods. Remove
the Parse_UsesKnownInstances_MemberData helper and AddStaticHttpMethods
static initializer — the list is now declared directly as a field.
This eliminates the duplication of having the static methods list defined
in three different places.
@NicoAvanzDev
Merge branch 'httpmethod-query-test-data' ofhttps://github.com/NicoA…
c67ae79
…vanzDev/runtime into httpmethod-query-test-data
CopilotAI review requested due to automatic review settings June 25, 2026 12:13
@NicoAvanzDev

NicoAvanzDev commented Jun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

@dotnet-policy-service agree

CopilotAI reviewed Jun 25, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment threadsrc/libraries/System.Net.Http/tests/FunctionalTests/HttpMethodTest.cs Outdated
Comment threadsrc/libraries/System.Net.Http/tests/FunctionalTests/HttpMethodTest.cs Outdated
@NicoAvanzDev
test: restore data-driven theories for StaticHttpMethods tests
77d566c
Add a StaticHttpMethods_MemberData source derived from the StaticHttpMethods
list and use it to drive GetHashCode_StaticMethods and Parse_KnownMethod as
[Theory] cases again.
This keeps the single canonical StaticHttpMethods list while preserving
per-method failure granularity — each method runs as its own case rather
than being hidden behind a single [Fact] loop that exits on first failure.
@NicoAvanzDev
Merge branch 'httpmethod-query-test-data' ofhttps://github.com/NicoA…
458309b
…vanzDev/runtime into httpmethod-query-test-data
CopilotAI review requested due to automatic review settings June 25, 2026 12:28
CopilotAI reviewed Jun 25, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment threadsrc/libraries/System.Net.Http/tests/FunctionalTests/HttpMethodTest.cs Outdated
Comment threadsrc/libraries/System.Net.Http/tests/FunctionalTests/HttpMethodTest.cs Outdated
@NicoAvanzDev
test: encapsulate StaticHttpMethods and restore case-insensitivity co…
e86d897
…verage
- Make StaticHttpMethods private and immutable (IReadOnlyList backed by array)
to prevent accidental mutation and inter-test coupling
- Remove redundant ToUpperInvariant() call in Parse_KnownMethod test
- Add ToMixedCase() helper and restore meaningful case-insensitivity coverage
by testing lower-case and mixed-case variants alongside exact case
@MihaZupanMihaZupan added this to the 11.0.0 milestone Jun 26, 2026
@MihaZupan
MihaZupan enabled auto-merge (squash) June 26, 2026 20:08
@MihaZupan
MihaZupan merged commit ec7bc97 into dotnet:mainJun 26, 2026
87 of 89 checks passed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jun 27, 2026
Merged
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@NicoAvanzDev@eiriktsarpalis
Add HttpMethod.Query to static method test data (#129790)
627acae
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 29, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@MihaZupanMihaZupanMihaZupan approved these changes

Assignees

No one assigned

Labels

area-System.Net.Httpcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

3 participants

@NicoAvanzDev@MihaZupan