Avoid publishing interpreter frame with invalid IP by BrzVlad · Pull Request #129795 · dotnet/runtime

BrzVlad · 2026-06-24T11:41:33Z

When we need to obtain a new InterpMethodContextFrame for called method execution, we try to obtain a preallocated one from the list. If there is none, then we just allocate a new one with alloca and initialize the fields, including the ip to 0 initially. The problem is that the compiler is free to reorder this initialization in whichever way it considers optimal. If a stack overflow gets triggered at some point during execution (at a location that we don't normally expect), the unwinder might actually observe a pushed interp frame that has a non-null junk ip. We fix this by making sure the ip is properly zeroed before we publish the new interpreter frame on the list. Order is achieved just via compiler barriers.

Should fix stackoverflowtester on win-arm64.

"Assert failure(PID 46068 [0x0000b3f4], Thread: 46860 [0xb70c]): m_crawl.GetCodeInfo()->IsValid()"
CORECLR! StackFrameIterator::NextRaw + 0x764 (0x00007ff8`157b6e04)"
CORECLR! StackFrameIterator::Filter + 0xBD4 (0x00007ff8`157b57b4)"
CORECLR! StackFrameIterator::Init + 0x258 (0x00007ff8`157b60d8)"
CORECLR! Thread::StackWalkFramesEx + 0x178 (0x00007ff8`157b7e78)"
CORECLR! Thread::StackWalkFrames + 0x1A8 (0x00007ff8`157b7cd8)"
CORECLR! LogCallstackForLogWorker + 0x19C (0x00007ff8`1585139c)"
CORECLR! LogStackOverflowStackTraceThread + 0x10 (0x00007ff8`15851fe0)"
KERNEL32! BaseThreadInitThunk + 0x40 (0x00007ff8`8f128740)"
<no module>! <no symbol> + 0x0 (0x392cfff8`8fe64594)"
File: D:\a\_work\1\s\src\coreclr\vm\stackwalk.cpp:2306"
Image: C:\h\w\BD470A90\p\corerun.exe"

BrzVlad · 2026-06-24T11:41:50Z

/azp run runtime-interpreter

azure-pipelines · 2026-06-24T11:42:00Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-policy-service · 2026-06-24T11:42:56Z

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

BrzVlad · 2026-06-24T11:56:43Z

/azp run runtime-interpreter

azure-pipelines · 2026-06-24T11:56:55Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2026-06-24T15:12:00Z

@janvorli Miraculously, this actually fixed the failing test. It would be great if you could reproduce the failure and validate the theory, but I believe the fix is simplistic enough anyway and it doesn't impact any hot path.

BrzVlad · 2026-06-25T06:10:21Z

/azp run runtime-interpreter

azure-pipelines · 2026-06-25T06:10:32Z

Azure Pipelines successfully started running 1 pipeline(s).

janvorli

LGTM, thank you!

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

BrzVlad · 2026-06-25T18:12:11Z

/azp run runtime-interpreter

azure-pipelines · 2026-06-25T18:12:28Z

Azure Pipelines successfully started running 1 pipeline(s).

BrzVlad · 2026-06-25T18:13:53Z

@janvorli Had to move the definition from volatile.h, since it was breaking windows build due to some ASSERTE conflicts. Ended up defining the method only in interpexec.cpp for now. Your approval is now stale.

BrzVlad · 2026-06-26T05:39:53Z

/ba-g unrelated build timeouts

When we need to obtain a new `InterpMethodContextFrame` for called method execution, we try to obtain a preallocated one from the list. If there is none, then we just allocate a new one with `alloca` and initialize the fields, including the `ip` to 0 initially. The problem is that the compiler is free to reorder this initialization in whichever way it considers optimal. If a stack overflow gets triggered at some point during execution (at a location that we don't normally expect), the unwinder might actually observe a pushed interp frame that has a non-null junk ip. We fix this by making sure the ip is properly zeroed before we publish the new interpreter frame on the list. Order is achieved just via compiler barriers. Should fix `stackoverflowtester` on win-arm64. ``` "Assert failure(PID 46068 [0x0000b3f4], Thread: 46860 [0xb70c]): m_crawl.GetCodeInfo()->IsValid()" CORECLR! StackFrameIterator::NextRaw + 0x764 (0x00007ff8`157b6e04)" CORECLR! StackFrameIterator::Filter + 0xBD4 (0x00007ff8`157b57b4)" CORECLR! StackFrameIterator::Init + 0x258 (0x00007ff8`157b60d8)" CORECLR! Thread::StackWalkFramesEx + 0x178 (0x00007ff8`157b7e78)" CORECLR! Thread::StackWalkFrames + 0x1A8 (0x00007ff8`157b7cd8)" CORECLR! LogCallstackForLogWorker + 0x19C (0x00007ff8`1585139c)" CORECLR! LogStackOverflowStackTraceThread + 0x10 (0x00007ff8`15851fe0)" KERNEL32! BaseThreadInitThunk + 0x40 (0x00007ff8`8f128740)" <no module>! <no symbol> + 0x0 (0x392cfff8`8fe64594)" File: D:\a\_work\1\s\src\coreclr\vm\stackwalk.cpp:2306" Image: C:\h\w\BD470A90\p\corerun.exe" ```

Test stackoverflow fix
0fc8993

CopilotAI review requested due to automatic review settings June 24, 2026 11:41

github-actionsBot added the area-CodeGen-Interpreter-coreclr label Jun 24, 2026

Copilotstarted reviewing on behalf of BrzVlad June 24, 2026 11:41 View session

dotnet-policy-serviceBot assigned BrzVlad Jun 24, 2026

CopilotAI reviewed Jun 24, 2026

This was referenced Jun 24, 2026
slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883
Open
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

BrzVlad changed the title ~~Test stackoverflow fix~~Avoid publishing interpreter frame with invalid IPJun 24, 2026

This was referenced Jun 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed
Flaky timeout in CreateFileChangeToken_RootDeletedAndRecreated_TokenFiresWhenFileCreated #129691
Closed

BrzVlad marked this pull request as ready for review June 24, 2026 15:10

BrzVlad requested a review from janvorli as a code owner June 24, 2026 15:10

janvorli reviewed Jun 24, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/interpexec.cpp Outdated

Use std::atomic_signal_fence instead
ec79203

janvorli approved these changes Jun 25, 2026
View reviewed changes

build-analysisBot mentioned this pull request Jun 25, 2026
[ci-scan] Test failure: HandlerException assertion INTERPRETER_CODE_POISON in SetInterpreterCode #129465
Closed

Local scope for CompilerBarrier to interpexec.cpp
c7f83e5

CopilotAI review requested due to automatic review settings June 25, 2026 14:19

Copilotstarted reviewing on behalf of BrzVlad June 25, 2026 14:19 View session

CopilotAI reviewed Jun 25, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/interpexec.cpp

janvorli approved these changes Jun 25, 2026
View reviewed changes

BrzVlad merged commit 99eb16b into dotnet:mainJun 26, 2026
120 of 124 checks passed

dotnet-maestroBot mentioned this pull request Jun 27, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7441
Merged

dotnet-milestone-botBot added this to the 11.0-preview7 milestone Jun 28, 2026

github-actionsBot locked and limited conversation to collaborators Jul 29, 2026

Uh oh!

Conversation

BrzVlad commented Jun 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BrzVlad commented Jun 24, 2026

Uh oh!

azure-pipelinesBot commented Jun 24, 2026

Uh oh!

dotnet-policy-serviceBot commented Jun 24, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

BrzVlad commented Jun 24, 2026

Uh oh!

azure-pipelinesBot commented Jun 24, 2026

Uh oh!

BrzVlad commented Jun 24, 2026

Uh oh!

Uh oh!

BrzVlad commented Jun 25, 2026

Uh oh!

azure-pipelinesBot commented Jun 25, 2026

Uh oh!

janvorli left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

BrzVlad commented Jun 25, 2026

Uh oh!

azure-pipelinesBot commented Jun 25, 2026

Uh oh!

BrzVlad commented Jun 25, 2026

Uh oh!

BrzVlad commented Jun 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BrzVlad commented Jun 24, 2026•
edited
Loading