Skip to content

Add DacMode-based SOS test legs to runtime-diagnostics pipeline - #129859

Merged
max-charlamb merged 1 commit into
dotnet:mainfrom
max-charlamb:runtime-sos-cdac-legs
Jun 26, 2026
Merged

Add DacMode-based SOS test legs to runtime-diagnostics pipeline#129859
max-charlamb merged 1 commit into
dotnet:mainfrom
max-charlamb:runtime-sos-cdac-legs

Conversation

@max-charlamb

@max-charlambmax-charlamb commented Jun 25, 2026

Copy link
Copy Markdown
Member

Replaces the useCdac/noFallback booleans in the SOS test legs with a single dacMode parameter and adds a 4th leg. The shared windows_x64 build now uploads the freshly built cDAC (mscordaccore_universal) as a separate artifact for the cdac leg to consume.

SOS legs (windows_x64 Release, testInterpreter):

  • cDAC -- dacMode cdac -- standalone cDAC via SOS (downloads + overlays the built cDAC next to sos.dll)
  • cDAC_fallback -- dacMode cdacfallback -- in-box DAC hosts cDAC, with fallback
  • cDAC_verify -- dacMode cdacverify -- in-box DAC hosts cDAC, no fallback (verifies)
  • DAC -- dacMode dac -- legacy DAC only

Depends on the DacMode support added in dotnet/diagnostics#5901. To exercise it before that merges, queue runtime-diagnostics with diagnosticsBranch pointing at the diagnostics PR's merge ref.

Sample run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1481626&view=logs&j=d359ac0d-403b-5f4f-9a78-93671d33ea9d

Replace the useCdac/noFallback booleans with a single dacMode parameter and add
a 4th SOS leg. The shared windows_x64 build now uploads the freshly built cDAC
(mscordaccore_universal) as a separate artifact for the cdac leg to consume.
Legs (windows_x64 Release, testInterpreter):
cDAC dacMode cdac standalone cDAC via SOS (downloads+overlays the built cDAC)
cDAC_fallback dacMode cdacfallback in-box DAC hosts cDAC, with fallback
cDAC_verify dacMode cdacverify in-box DAC hosts cDAC, no fallback (verifies)
DAC dacMode dac legacy DAC only
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the runtime-diagnostics Azure DevOps pipeline SOS test legs to use a single dacMode selector (instead of useCdac/noFallback), adds an additional SOS leg, and wires up publishing/downloading the freshly-built standalone cDAC so the cdac leg can exercise the runtime-under-test’s own mscordaccore_universal.

Changes:

  • Replace useCdac/noFallback booleans with a single dacMode string parameter through the SOS leg templates.
  • Add a 4th SOS leg (cDAC_verify) and adjust existing leg naming/modes (cDAC_fallback, DAC).
  • Publish the built mscordaccore_universal output as a separate artifact and download it only for the dacMode: cdac leg.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
eng/pipelines/runtime-diagnostics.ymlAdds the 4th SOS leg, switches legs to dacMode, and uploads the built cDAC as a dedicated artifact.
eng/pipelines/diagnostics/sos-test-leg.ymlReplaces boolean toggles with dacMode and conditionally downloads the cDAC artifact for the cdac mode.
eng/pipelines/diagnostics/runtime-diag-job.ymlMaps dacMode to the corresponding -dacMode / -cdacPath arguments passed to the diagnostics build/test harness.

Comment threadeng/pipelines/runtime-diagnostics.yml
Comment threadeng/pipelines/runtime-diagnostics.yml
@hoyosjs

Copy link
Copy Markdown
Member

/azp run runtime-diagnostics

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@max-charlamb

Copy link
Copy Markdown
MemberAuthor

/ba-g cDAC pipeline Chang to sync with diagnostics

@max-charlamb
max-charlamb merged commit b37c180 into dotnet:mainJun 26, 2026
201 of 206 checks passed
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview7 milestone Jun 28, 2026
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 29, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@max-charlamb@hoyosjs