Uh oh!
There was an error while loading. Please reload this page.
Remove PAL oleauto.h shim and stale CoreCLR includes - #129874
Merged
Merged
Conversation
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Contributor
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy PAL oleauto.h shim header and cleans up a few now-stale CoreCLR include directives that referenced it, reducing unnecessary header dependencies.
Changes:
- Removed
#include <oleauto.h>from CoreCLR headers that no longer require it. - Deleted
src/coreclr/pal/inc/rt/oleauto.h(PAL-era shim) now that it has no remaining consumers. - Simplified metainfo tooling headers by dropping a
TARGET_UNIX-only include ofoleauto.h.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/comdatetime.h | Drops unused oleauto.h include from COM date/time helper header. |
| src/coreclr/tools/metainfo/mdinfo.h | Removes TARGET_UNIXoleauto.h include; winwrap.h/PAL types already cover needed declarations for non-COM paths. |
| src/coreclr/pal/inc/rt/oleauto.h | Deletes the unused PAL shim header (no remaining references under CoreCLR). |
| src/coreclr/inc/utilcode.h | Removes redundant oleauto.h include (keeps ole2.h). |
AaronRobinsonMSFT
approved these changes
Jun 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
`src/coreclr/pal/inc/rt/oleauto.h` was a PAL-era shim that is no longer needed for current CoreCLR builds. Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/coreclr/pal/inc/rt/oleauto.hwas a PAL-era shim that is no longer needed for current CoreCLR builds.