[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. - #129887

Merged
janvorli merged 10 commits into
dotnet:mainfrom
LuckyXu-HF:main-LA64
Jul 9, 2026
Merged

[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
janvorli merged 10 commits into
dotnet:mainfrom
LuckyXu-HF:main-LA64

Conversation

@LuckyXu-HF

@LuckyXu-HFLuckyXu-HF commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jun 26, 2026
shushanhf
shushanhf approved these changes Jun 26, 2026
View reviewed changes

@shushanhfshushanhf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@LuckyXu-HF

LuckyXu-HF commented Jun 26, 2026

Copy link
Copy Markdown
ContributorAuthor

LA64 also hit the same issue like #127860 :

root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
corerun: /runtime/src/coreclr/gcinfo/gcinfoencoder.cpp:723: void TGcInfoEncoder<InterpreterGcInfoEncoding>::SetStackBaseRegister(UINT32) [GcInfoEncoding = InterpreterGcInfoEncoding]: Assertion `regNum == 3 || 22 == regNum' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Interpreted App returned 134
System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests() in /runtime/src/tests/JIT/interpreter/InterpreterTester.cs:line 30
at __GeneratedMainWrapper.Main() in /runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/JIT/interpreter/InterpreterTester/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/SimpleRunner.g.cs:line 7
Expected: 100
Actual: 101
END EXECUTION - FAILED

Fixed:

InterpreterTester.sh PASS
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention2Rev: s = 1, 2
TestCallingConvention3Rev: v = 1, 2
TestCallingConvention4Rev: s = 1, 2, 3, 4, 5, 6
TestCallingConvention5Rev: s = 1, 2, 3, 4
TestCallingConvention6Rev: s = 1, 2, 3, 4
TestCallingConvention7Rev: s = 1, 2, 3, 4
TestCallingConvention8Rev: s = 1, 2, 3, 4
TestCallingConvention9Rev: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10Rev: a = 1, b = 2, c = 3
TestCallingConvention11Rev: s = 1, 2, 3
TestCallingConvention12Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention: s = 1
2
TestCallingConvention: s = 1
2
3
4
5
6
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
Sum
Mul4
TestSwitch
PowLoop
TestJitFields
TestFields
TestStructRefFields
TestSpecialFields
TestFloat
TestConvOvf
TestConvOvfUn
TestConvBoundaries
TestLocalloc
TestVirtual
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
TestBoxing
TestArray
TestXxObj
TestSizeof
TestLdtoken
TestMdArray
TestExceptionHandling
1
2
3
Object reference not set to an instance of an object.
4
6
7
TestStringCtor
TestSharedGenerics
Test calls to shared generics from non-generic code
Test calls to shared generics from generic code (unshared generics)
Test calls to shared generics from generic code (shared generics)
Test isinst with shared generics (string)
Test castclass with shared generics (string)
Expected InvalidCastException from casting object to string[]
Test unbox.any with shared generics
Expected InvalidCastException from casting object to string
Test box with shared generics
Test classic unbox instruction with shared generics
Test newarr
Test new MD arr
TestDelegate
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestIntrinsics
Vector128.IsHardwareAccelerated=
False
X86Base.IsSupported=
False
ArmBase.IsSupported=
False
TestCalli
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestStaticVirtualGeneric_CodePointerCase
TestPreciseInitCctors
TestThreading_Interlocked_CompareExchange
TestRuntimeHelpers_IsReferenceOrContainsReferences
TestMemoryMarshal_GetArrayDataReference
Empty string length: 0
BitConverter.IsLittleEndian: True
IntPtr.Zero: 0, UIntPtr.Zero: 0
TestPInvoke
Hello world from pinvoke.dll!writeToStdout
calling missingPInvoke
caught #1
calling missingPInvokeWithMarshaling
caught #2
All tests passed successfully!
Interpreted App returned 100
Expected: 100
Actual: 100
END EXECUTION - PASSED

LuckyXu-HF
LuckyXu-HF commented Jun 26, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp Outdated
@LuckyXu-HF

LuckyXu-HF commented Jun 30, 2026

Copy link
Copy Markdown
ContributorAuthor

@jkotas@janvorli Could you please review this PR? Thank you.

@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

am11
am11 reviewed Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp Outdated
am11
am11 reviewed Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp Outdated
am11
am11 reviewed Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp Outdated
LuckyXu-HFand others added 5 commits July 6, 2026 10:18
@LuckyXu-HF@am11
Apply suggestion from@am11
a9aff4e
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
8159821
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
c485cf3
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
45de322
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF
Merge branch 'main' into main-LA64
2205fba
@build-analysisbuild-analysisBot mentioned this pull request Jul 6, 2026
Closed
@am11
am11 requested review from janvorli and jkotasJuly 6, 2026 12:30
@am11

am11 commented Jul 6, 2026

Copy link
Copy Markdown
Member

@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:

--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);

It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):

runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203 in 22439c0

Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");

Are you sure LA64 doesn't need it?

If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)

@am11am11 added the arch-riscv Related to the RISC-V architecture label Jul 6, 2026
@LuckyXu-HF

LuckyXu-HF commented Jul 7, 2026

Copy link
Copy Markdown
ContributorAuthor

@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:

--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);

It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):

runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203 in 22439c0

Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");

Are you sure LA64 doesn't need it?

If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)

I will apply the patch here and check it on LA64, thanks!

@LuckyXu-HF@am11
apply the fix of RethrowResumeAfterCatchException() for Riscv64 and L…
239e3ca
…oongArch64.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
LuckyXu-HF
LuckyXu-HF commented Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/exceptionhandling.cpp Outdated
This was referenced Jul 7, 2026
Closed
Closed
Closed
janvorli
janvorli reviewed Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jul 9, 2026
Open
3 tasks
am11
am11 approved these changes Jul 9, 2026
View reviewed changes

@am11am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@am11
am11 requested a review from janvorliJuly 9, 2026 07:17
janvorli
janvorli approved these changes Jul 9, 2026
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli

janvorli commented Jul 9, 2026

Copy link
Copy Markdown
Member

/ba-g the failures are build timeouts unrelated to this change.

@janvorli
janvorli merged commit 0fa7a0f into dotnet:mainJul 9, 2026
117 of 125 checks passed
@LuckyXu-HF
LuckyXu-HF deleted the main-LA64 branch July 9, 2026 11:52
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jul 10, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview7 milestone Jul 10, 2026
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@LuckyXu-HF@am11
@janvorli@eiriktsarpalis
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. (#…
4f01697
…129887)
Align [PR#127919](#127919) to fix
the InterpreterTester.sh failed like
issue:#127860 on LA64.
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 10, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorlijanvorlijanvorli approved these changes
@jkotasjkotasAwaiting requested review from jkotas
+2 more reviewers
@shushanhfshushanhfshushanhf approved these changes
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-loongarch64arch-riscvRelated to the RISC-V architecturearea-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@LuckyXu-HF@am11@janvorli@shushanhf@jkotas
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. - #129887
Merged
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Jul 9, 2026
Merged
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Conversation
@LuckyXu-HF
@LuckyXu-HFLuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

Contributor
Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 26, 2026
shushanhf
shushanhf
approved these changes
Jun 26, 2026
View reviewed changes
@shushanhfshushanhf
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
@LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

ContributorAuthor
LA64 also hit the same issue like #127860 :
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
corerun: /runtime/src/coreclr/gcinfo/gcinfoencoder.cpp:723: void TGcInfoEncoder<InterpreterGcInfoEncoding>::SetStackBaseRegister(UINT32) [GcInfoEncoding = InterpreterGcInfoEncoding]: Assertion `regNum == 3 || 22 == regNum' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Interpreted App returned 134
System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests() in /runtime/src/tests/JIT/interpreter/InterpreterTester.cs:line 30
at __GeneratedMainWrapper.Main() in /runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/JIT/interpreter/InterpreterTester/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/SimpleRunner.g.cs:line 7
Expected: 100
Actual: 101
END EXECUTION - FAILED

Fixed:
InterpreterTester.sh PASS
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention2Rev: s = 1, 2
TestCallingConvention3Rev: v = 1, 2
TestCallingConvention4Rev: s = 1, 2, 3, 4, 5, 6
TestCallingConvention5Rev: s = 1, 2, 3, 4
TestCallingConvention6Rev: s = 1, 2, 3, 4
TestCallingConvention7Rev: s = 1, 2, 3, 4
TestCallingConvention8Rev: s = 1, 2, 3, 4
TestCallingConvention9Rev: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10Rev: a = 1, b = 2, c = 3
TestCallingConvention11Rev: s = 1, 2, 3
TestCallingConvention12Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention: s = 1
2
TestCallingConvention: s = 1
2
3
4
5
6
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
Sum
Mul4
TestSwitch
PowLoop
TestJitFields
TestFields
TestStructRefFields
TestSpecialFields
TestFloat
TestConvOvf
TestConvOvfUn
TestConvBoundaries
TestLocalloc
TestVirtual
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
TestBoxing
TestArray
TestXxObj
TestSizeof
TestLdtoken
TestMdArray
TestExceptionHandling
1
2
3
Object reference not set to an instance of an object.
4
6
7
TestStringCtor
TestSharedGenerics
Test calls to shared generics from non-generic code
Test calls to shared generics from generic code (unshared generics)
Test calls to shared generics from generic code (shared generics)
Test isinst with shared generics (string)
Test castclass with shared generics (string)
Expected InvalidCastException from casting object to string[]
Test unbox.any with shared generics
Expected InvalidCastException from casting object to string
Test box with shared generics
Test classic unbox instruction with shared generics
Test newarr
Test new MD arr
TestDelegate
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestIntrinsics
Vector128.IsHardwareAccelerated=
False
X86Base.IsSupported=
False
ArmBase.IsSupported=
False
TestCalli
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestStaticVirtualGeneric_CodePointerCase
TestPreciseInitCctors
TestThreading_Interlocked_CompareExchange
TestRuntimeHelpers_IsReferenceOrContainsReferences
TestMemoryMarshal_GetArrayDataReference
Empty string length: 0
BitConverter.IsLittleEndian: True
IntPtr.Zero: 0, UIntPtr.Zero: 0
TestPInvoke
Hello world from pinvoke.dll!writeToStdout
calling missingPInvoke
caught #1
calling missingPInvokeWithMarshaling
caught #2
All tests passed successfully!
Interpreted App returned 100
Expected: 100
Actual: 100
END EXECUTION - PASSED

LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@LuckyXu-HF
LuckyXu-HF
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas@janvorli Could you please review this PR? Thank you.
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg

See info in area-owners.md if you want to be subscribed.
am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

LuckyXu-HFand others
added 5 commits
July 6, 2026 10:18
@LuckyXu-HF@am11
Apply suggestion from@am11
a9aff4e
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
8159821
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
c485cf3
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
45de322
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF
Merge branch 'main' into main-LA64
2205fba
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

@am11
am11
requested review from
janvorli and jkotasJuly 6, 2026 12:30
@am11
am11
commented
Jul 6, 2026

Copy link


Copy Markdown

Member
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
@am11am11
added
the 
arch-riscv
Related to the RISC-V architecture
label
Jul 6, 2026
@LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026

Copy link


Copy Markdown

ContributorAuthor
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
I will apply the patch here and check it on LA64, thanks!
@LuckyXu-HF@am11
apply the fix of RethrowResumeAfterCatchException() for Riscv64 and L…
239e3ca
…oongArch64.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/exceptionhandling.cpp
Outdated


This was referenced Jul 7, 2026

Closed


Closed


Closed

janvorli
janvorli
reviewed
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 9, 2026

Open

3 tasks
am11
am11
approved these changes
Jul 9, 2026
View reviewed changes
@am11am11
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
@am11
am11
requested a review
from janvorliJuly 9, 2026 07:17
janvorli
janvorli
approved these changes
Jul 9, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
/ba-g the failures are build timeouts unrelated to this change.
@janvorli
janvorli
merged commit 0fa7a0f
into
dotnet:mainJul 9, 2026

117 of 125 checks passed

@LuckyXu-HF
LuckyXu-HF
deleted the

main-LA64

branch
July 9, 2026 11:52
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 10, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 10, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@LuckyXu-HF@am11
@janvorli@eiriktsarpalis
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. (#…
4f01697
…129887)
Align [PR#127919](#127919) to fix
the InterpreterTester.sh failed like
issue:#127860 on LA64.
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 10, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+2 more reviewers

@shushanhfshushanhfshushanhf approved these changes
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-loongarch64arch-riscvRelated to the RISC-V architecturearea-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@LuckyXu-HF@am11@janvorli@shushanhf@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. - #129887
Merged
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Jul 9, 2026
Merged
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Conversation
@LuckyXu-HF
@LuckyXu-HFLuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

Contributor
Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 26, 2026
shushanhf
shushanhf
approved these changes
Jun 26, 2026
View reviewed changes
@shushanhfshushanhf
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
@LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

ContributorAuthor
LA64 also hit the same issue like #127860 :
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
corerun: /runtime/src/coreclr/gcinfo/gcinfoencoder.cpp:723: void TGcInfoEncoder<InterpreterGcInfoEncoding>::SetStackBaseRegister(UINT32) [GcInfoEncoding = InterpreterGcInfoEncoding]: Assertion `regNum == 3 || 22 == regNum' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Interpreted App returned 134
System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests() in /runtime/src/tests/JIT/interpreter/InterpreterTester.cs:line 30
at __GeneratedMainWrapper.Main() in /runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/JIT/interpreter/InterpreterTester/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/SimpleRunner.g.cs:line 7
Expected: 100
Actual: 101
END EXECUTION - FAILED

Fixed:
InterpreterTester.sh PASS
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention2Rev: s = 1, 2
TestCallingConvention3Rev: v = 1, 2
TestCallingConvention4Rev: s = 1, 2, 3, 4, 5, 6
TestCallingConvention5Rev: s = 1, 2, 3, 4
TestCallingConvention6Rev: s = 1, 2, 3, 4
TestCallingConvention7Rev: s = 1, 2, 3, 4
TestCallingConvention8Rev: s = 1, 2, 3, 4
TestCallingConvention9Rev: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10Rev: a = 1, b = 2, c = 3
TestCallingConvention11Rev: s = 1, 2, 3
TestCallingConvention12Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention: s = 1
2
TestCallingConvention: s = 1
2
3
4
5
6
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
Sum
Mul4
TestSwitch
PowLoop
TestJitFields
TestFields
TestStructRefFields
TestSpecialFields
TestFloat
TestConvOvf
TestConvOvfUn
TestConvBoundaries
TestLocalloc
TestVirtual
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
TestBoxing
TestArray
TestXxObj
TestSizeof
TestLdtoken
TestMdArray
TestExceptionHandling
1
2
3
Object reference not set to an instance of an object.
4
6
7
TestStringCtor
TestSharedGenerics
Test calls to shared generics from non-generic code
Test calls to shared generics from generic code (unshared generics)
Test calls to shared generics from generic code (shared generics)
Test isinst with shared generics (string)
Test castclass with shared generics (string)
Expected InvalidCastException from casting object to string[]
Test unbox.any with shared generics
Expected InvalidCastException from casting object to string
Test box with shared generics
Test classic unbox instruction with shared generics
Test newarr
Test new MD arr
TestDelegate
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestIntrinsics
Vector128.IsHardwareAccelerated=
False
X86Base.IsSupported=
False
ArmBase.IsSupported=
False
TestCalli
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestStaticVirtualGeneric_CodePointerCase
TestPreciseInitCctors
TestThreading_Interlocked_CompareExchange
TestRuntimeHelpers_IsReferenceOrContainsReferences
TestMemoryMarshal_GetArrayDataReference
Empty string length: 0
BitConverter.IsLittleEndian: True
IntPtr.Zero: 0, UIntPtr.Zero: 0
TestPInvoke
Hello world from pinvoke.dll!writeToStdout
calling missingPInvoke
caught #1
calling missingPInvokeWithMarshaling
caught #2
All tests passed successfully!
Interpreted App returned 100
Expected: 100
Actual: 100
END EXECUTION - PASSED

LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@LuckyXu-HF
LuckyXu-HF
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas@janvorli Could you please review this PR? Thank you.
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg

See info in area-owners.md if you want to be subscribed.
am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

LuckyXu-HFand others
added 5 commits
July 6, 2026 10:18
@LuckyXu-HF@am11
Apply suggestion from@am11
a9aff4e
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
8159821
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
c485cf3
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
45de322
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF
Merge branch 'main' into main-LA64
2205fba
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

@am11
am11
requested review from
janvorli and jkotasJuly 6, 2026 12:30
@am11
am11
commented
Jul 6, 2026

Copy link


Copy Markdown

Member
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
@am11am11
added
the 
arch-riscv
Related to the RISC-V architecture
label
Jul 6, 2026
@LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026

Copy link


Copy Markdown

ContributorAuthor
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
I will apply the patch here and check it on LA64, thanks!
@LuckyXu-HF@am11
apply the fix of RethrowResumeAfterCatchException() for Riscv64 and L…
239e3ca
…oongArch64.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/exceptionhandling.cpp
Outdated


This was referenced Jul 7, 2026

Closed


Closed


Closed

janvorli
janvorli
reviewed
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 9, 2026

Open

3 tasks
am11
am11
approved these changes
Jul 9, 2026
View reviewed changes
@am11am11
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
@am11
am11
requested a review
from janvorliJuly 9, 2026 07:17
janvorli
janvorli
approved these changes
Jul 9, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
/ba-g the failures are build timeouts unrelated to this change.
@janvorli
janvorli
merged commit 0fa7a0f
into
dotnet:mainJul 9, 2026

117 of 125 checks passed

@LuckyXu-HF
LuckyXu-HF
deleted the

main-LA64

branch
July 9, 2026 11:52
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 10, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 10, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@LuckyXu-HF@am11
@janvorli@eiriktsarpalis
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. (#…
4f01697
…129887)
Align [PR#127919](#127919) to fix
the InterpreterTester.sh failed like
issue:#127860 on LA64.
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 10, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+2 more reviewers

@shushanhfshushanhfshushanhf approved these changes
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-loongarch64arch-riscvRelated to the RISC-V architecturearea-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@LuckyXu-HF@am11@janvorli@shushanhf@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. - #129887
Merged
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Jul 9, 2026
Merged
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Conversation
@LuckyXu-HF
@LuckyXu-HFLuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

Contributor
Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 26, 2026
shushanhf
shushanhf
approved these changes
Jun 26, 2026
View reviewed changes
@shushanhfshushanhf
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
@LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

ContributorAuthor
LA64 also hit the same issue like #127860 :
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
corerun: /runtime/src/coreclr/gcinfo/gcinfoencoder.cpp:723: void TGcInfoEncoder<InterpreterGcInfoEncoding>::SetStackBaseRegister(UINT32) [GcInfoEncoding = InterpreterGcInfoEncoding]: Assertion `regNum == 3 || 22 == regNum' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Interpreted App returned 134
System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests() in /runtime/src/tests/JIT/interpreter/InterpreterTester.cs:line 30
at __GeneratedMainWrapper.Main() in /runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/JIT/interpreter/InterpreterTester/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/SimpleRunner.g.cs:line 7
Expected: 100
Actual: 101
END EXECUTION - FAILED

Fixed:
InterpreterTester.sh PASS
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention2Rev: s = 1, 2
TestCallingConvention3Rev: v = 1, 2
TestCallingConvention4Rev: s = 1, 2, 3, 4, 5, 6
TestCallingConvention5Rev: s = 1, 2, 3, 4
TestCallingConvention6Rev: s = 1, 2, 3, 4
TestCallingConvention7Rev: s = 1, 2, 3, 4
TestCallingConvention8Rev: s = 1, 2, 3, 4
TestCallingConvention9Rev: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10Rev: a = 1, b = 2, c = 3
TestCallingConvention11Rev: s = 1, 2, 3
TestCallingConvention12Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention: s = 1
2
TestCallingConvention: s = 1
2
3
4
5
6
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
Sum
Mul4
TestSwitch
PowLoop
TestJitFields
TestFields
TestStructRefFields
TestSpecialFields
TestFloat
TestConvOvf
TestConvOvfUn
TestConvBoundaries
TestLocalloc
TestVirtual
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
TestBoxing
TestArray
TestXxObj
TestSizeof
TestLdtoken
TestMdArray
TestExceptionHandling
1
2
3
Object reference not set to an instance of an object.
4
6
7
TestStringCtor
TestSharedGenerics
Test calls to shared generics from non-generic code
Test calls to shared generics from generic code (unshared generics)
Test calls to shared generics from generic code (shared generics)
Test isinst with shared generics (string)
Test castclass with shared generics (string)
Expected InvalidCastException from casting object to string[]
Test unbox.any with shared generics
Expected InvalidCastException from casting object to string
Test box with shared generics
Test classic unbox instruction with shared generics
Test newarr
Test new MD arr
TestDelegate
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestIntrinsics
Vector128.IsHardwareAccelerated=
False
X86Base.IsSupported=
False
ArmBase.IsSupported=
False
TestCalli
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestStaticVirtualGeneric_CodePointerCase
TestPreciseInitCctors
TestThreading_Interlocked_CompareExchange
TestRuntimeHelpers_IsReferenceOrContainsReferences
TestMemoryMarshal_GetArrayDataReference
Empty string length: 0
BitConverter.IsLittleEndian: True
IntPtr.Zero: 0, UIntPtr.Zero: 0
TestPInvoke
Hello world from pinvoke.dll!writeToStdout
calling missingPInvoke
caught #1
calling missingPInvokeWithMarshaling
caught #2
All tests passed successfully!
Interpreted App returned 100
Expected: 100
Actual: 100
END EXECUTION - PASSED

LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@LuckyXu-HF
LuckyXu-HF
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas@janvorli Could you please review this PR? Thank you.
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg

See info in area-owners.md if you want to be subscribed.
am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

LuckyXu-HFand others
added 5 commits
July 6, 2026 10:18
@LuckyXu-HF@am11
Apply suggestion from@am11
a9aff4e
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
8159821
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
c485cf3
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
45de322
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF
Merge branch 'main' into main-LA64
2205fba
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

@am11
am11
requested review from
janvorli and jkotasJuly 6, 2026 12:30
@am11
am11
commented
Jul 6, 2026

Copy link


Copy Markdown

Member
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
@am11am11
added
the 
arch-riscv
Related to the RISC-V architecture
label
Jul 6, 2026
@LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026

Copy link


Copy Markdown

ContributorAuthor
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
I will apply the patch here and check it on LA64, thanks!
@LuckyXu-HF@am11
apply the fix of RethrowResumeAfterCatchException() for Riscv64 and L…
239e3ca
…oongArch64.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/exceptionhandling.cpp
Outdated


This was referenced Jul 7, 2026

Closed


Closed


Closed

janvorli
janvorli
reviewed
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 9, 2026

Open

3 tasks
am11
am11
approved these changes
Jul 9, 2026
View reviewed changes
@am11am11
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
@am11
am11
requested a review
from janvorliJuly 9, 2026 07:17
janvorli
janvorli
approved these changes
Jul 9, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
/ba-g the failures are build timeouts unrelated to this change.
@janvorli
janvorli
merged commit 0fa7a0f
into
dotnet:mainJul 9, 2026

117 of 125 checks passed

@LuckyXu-HF
LuckyXu-HF
deleted the

main-LA64

branch
July 9, 2026 11:52
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 10, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 10, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@LuckyXu-HF@am11
@janvorli@eiriktsarpalis
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. (#…
4f01697
…129887)
Align [PR#127919](#127919) to fix
the InterpreterTester.sh failed like
issue:#127860 on LA64.
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 10, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+2 more reviewers

@shushanhfshushanhfshushanhf approved these changes
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-loongarch64arch-riscvRelated to the RISC-V architecturearea-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@LuckyXu-HF@am11@janvorli@shushanhf@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. - #129887
Merged
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Jul 9, 2026
Merged
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Conversation
@LuckyXu-HF
@LuckyXu-HFLuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

Contributor
Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 26, 2026
shushanhf
shushanhf
approved these changes
Jun 26, 2026
View reviewed changes
@shushanhfshushanhf
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
@LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

ContributorAuthor
LA64 also hit the same issue like #127860 :
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
corerun: /runtime/src/coreclr/gcinfo/gcinfoencoder.cpp:723: void TGcInfoEncoder<InterpreterGcInfoEncoding>::SetStackBaseRegister(UINT32) [GcInfoEncoding = InterpreterGcInfoEncoding]: Assertion `regNum == 3 || 22 == regNum' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Interpreted App returned 134
System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests() in /runtime/src/tests/JIT/interpreter/InterpreterTester.cs:line 30
at __GeneratedMainWrapper.Main() in /runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/JIT/interpreter/InterpreterTester/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/SimpleRunner.g.cs:line 7
Expected: 100
Actual: 101
END EXECUTION - FAILED

Fixed:
InterpreterTester.sh PASS
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention2Rev: s = 1, 2
TestCallingConvention3Rev: v = 1, 2
TestCallingConvention4Rev: s = 1, 2, 3, 4, 5, 6
TestCallingConvention5Rev: s = 1, 2, 3, 4
TestCallingConvention6Rev: s = 1, 2, 3, 4
TestCallingConvention7Rev: s = 1, 2, 3, 4
TestCallingConvention8Rev: s = 1, 2, 3, 4
TestCallingConvention9Rev: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10Rev: a = 1, b = 2, c = 3
TestCallingConvention11Rev: s = 1, 2, 3
TestCallingConvention12Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention: s = 1
2
TestCallingConvention: s = 1
2
3
4
5
6
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
Sum
Mul4
TestSwitch
PowLoop
TestJitFields
TestFields
TestStructRefFields
TestSpecialFields
TestFloat
TestConvOvf
TestConvOvfUn
TestConvBoundaries
TestLocalloc
TestVirtual
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
TestBoxing
TestArray
TestXxObj
TestSizeof
TestLdtoken
TestMdArray
TestExceptionHandling
1
2
3
Object reference not set to an instance of an object.
4
6
7
TestStringCtor
TestSharedGenerics
Test calls to shared generics from non-generic code
Test calls to shared generics from generic code (unshared generics)
Test calls to shared generics from generic code (shared generics)
Test isinst with shared generics (string)
Test castclass with shared generics (string)
Expected InvalidCastException from casting object to string[]
Test unbox.any with shared generics
Expected InvalidCastException from casting object to string
Test box with shared generics
Test classic unbox instruction with shared generics
Test newarr
Test new MD arr
TestDelegate
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestIntrinsics
Vector128.IsHardwareAccelerated=
False
X86Base.IsSupported=
False
ArmBase.IsSupported=
False
TestCalli
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestStaticVirtualGeneric_CodePointerCase
TestPreciseInitCctors
TestThreading_Interlocked_CompareExchange
TestRuntimeHelpers_IsReferenceOrContainsReferences
TestMemoryMarshal_GetArrayDataReference
Empty string length: 0
BitConverter.IsLittleEndian: True
IntPtr.Zero: 0, UIntPtr.Zero: 0
TestPInvoke
Hello world from pinvoke.dll!writeToStdout
calling missingPInvoke
caught #1
calling missingPInvokeWithMarshaling
caught #2
All tests passed successfully!
Interpreted App returned 100
Expected: 100
Actual: 100
END EXECUTION - PASSED

LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@LuckyXu-HF
LuckyXu-HF
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas@janvorli Could you please review this PR? Thank you.
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg

See info in area-owners.md if you want to be subscribed.
am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

LuckyXu-HFand others
added 5 commits
July 6, 2026 10:18
@LuckyXu-HF@am11
Apply suggestion from@am11
a9aff4e
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
8159821
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
c485cf3
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
45de322
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF
Merge branch 'main' into main-LA64
2205fba
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

@am11
am11
requested review from
janvorli and jkotasJuly 6, 2026 12:30
@am11
am11
commented
Jul 6, 2026

Copy link


Copy Markdown

Member
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
@am11am11
added
the 
arch-riscv
Related to the RISC-V architecture
label
Jul 6, 2026
@LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026

Copy link


Copy Markdown

ContributorAuthor
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
I will apply the patch here and check it on LA64, thanks!
@LuckyXu-HF@am11
apply the fix of RethrowResumeAfterCatchException() for Riscv64 and L…
239e3ca
…oongArch64.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/exceptionhandling.cpp
Outdated


This was referenced Jul 7, 2026

Closed


Closed


Closed

janvorli
janvorli
reviewed
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 9, 2026

Open

3 tasks
am11
am11
approved these changes
Jul 9, 2026
View reviewed changes
@am11am11
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
@am11
am11
requested a review
from janvorliJuly 9, 2026 07:17
janvorli
janvorli
approved these changes
Jul 9, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
/ba-g the failures are build timeouts unrelated to this change.
@janvorli
janvorli
merged commit 0fa7a0f
into
dotnet:mainJul 9, 2026

117 of 125 checks passed

@LuckyXu-HF
LuckyXu-HF
deleted the

main-LA64

branch
July 9, 2026 11:52
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 10, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 10, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@LuckyXu-HF@am11
@janvorli@eiriktsarpalis
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. (#…
4f01697
…129887)
Align [PR#127919](#127919) to fix
the InterpreterTester.sh failed like
issue:#127860 on LA64.
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 10, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+2 more reviewers

@shushanhfshushanhfshushanhf approved these changes
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-loongarch64arch-riscvRelated to the RISC-V architecturearea-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@LuckyXu-HF@am11@janvorli@shushanhf@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. - #129887
Merged
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Jul 9, 2026
Merged
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Conversation
@LuckyXu-HF
@LuckyXu-HFLuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

Contributor
Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 26, 2026
shushanhf
shushanhf
approved these changes
Jun 26, 2026
View reviewed changes
@shushanhfshushanhf
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
@LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

ContributorAuthor
LA64 also hit the same issue like #127860 :
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
corerun: /runtime/src/coreclr/gcinfo/gcinfoencoder.cpp:723: void TGcInfoEncoder<InterpreterGcInfoEncoding>::SetStackBaseRegister(UINT32) [GcInfoEncoding = InterpreterGcInfoEncoding]: Assertion `regNum == 3 || 22 == regNum' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Interpreted App returned 134
System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests() in /runtime/src/tests/JIT/interpreter/InterpreterTester.cs:line 30
at __GeneratedMainWrapper.Main() in /runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/JIT/interpreter/InterpreterTester/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/SimpleRunner.g.cs:line 7
Expected: 100
Actual: 101
END EXECUTION - FAILED

Fixed:
InterpreterTester.sh PASS
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention2Rev: s = 1, 2
TestCallingConvention3Rev: v = 1, 2
TestCallingConvention4Rev: s = 1, 2, 3, 4, 5, 6
TestCallingConvention5Rev: s = 1, 2, 3, 4
TestCallingConvention6Rev: s = 1, 2, 3, 4
TestCallingConvention7Rev: s = 1, 2, 3, 4
TestCallingConvention8Rev: s = 1, 2, 3, 4
TestCallingConvention9Rev: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10Rev: a = 1, b = 2, c = 3
TestCallingConvention11Rev: s = 1, 2, 3
TestCallingConvention12Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention: s = 1
2
TestCallingConvention: s = 1
2
3
4
5
6
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
Sum
Mul4
TestSwitch
PowLoop
TestJitFields
TestFields
TestStructRefFields
TestSpecialFields
TestFloat
TestConvOvf
TestConvOvfUn
TestConvBoundaries
TestLocalloc
TestVirtual
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
TestBoxing
TestArray
TestXxObj
TestSizeof
TestLdtoken
TestMdArray
TestExceptionHandling
1
2
3
Object reference not set to an instance of an object.
4
6
7
TestStringCtor
TestSharedGenerics
Test calls to shared generics from non-generic code
Test calls to shared generics from generic code (unshared generics)
Test calls to shared generics from generic code (shared generics)
Test isinst with shared generics (string)
Test castclass with shared generics (string)
Expected InvalidCastException from casting object to string[]
Test unbox.any with shared generics
Expected InvalidCastException from casting object to string
Test box with shared generics
Test classic unbox instruction with shared generics
Test newarr
Test new MD arr
TestDelegate
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestIntrinsics
Vector128.IsHardwareAccelerated=
False
X86Base.IsSupported=
False
ArmBase.IsSupported=
False
TestCalli
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestStaticVirtualGeneric_CodePointerCase
TestPreciseInitCctors
TestThreading_Interlocked_CompareExchange
TestRuntimeHelpers_IsReferenceOrContainsReferences
TestMemoryMarshal_GetArrayDataReference
Empty string length: 0
BitConverter.IsLittleEndian: True
IntPtr.Zero: 0, UIntPtr.Zero: 0
TestPInvoke
Hello world from pinvoke.dll!writeToStdout
calling missingPInvoke
caught #1
calling missingPInvokeWithMarshaling
caught #2
All tests passed successfully!
Interpreted App returned 100
Expected: 100
Actual: 100
END EXECUTION - PASSED

LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@LuckyXu-HF
LuckyXu-HF
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas@janvorli Could you please review this PR? Thank you.
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg

See info in area-owners.md if you want to be subscribed.
am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

LuckyXu-HFand others
added 5 commits
July 6, 2026 10:18
@LuckyXu-HF@am11
Apply suggestion from@am11
a9aff4e
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
8159821
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
c485cf3
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
45de322
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF
Merge branch 'main' into main-LA64
2205fba
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

@am11
am11
requested review from
janvorli and jkotasJuly 6, 2026 12:30
@am11
am11
commented
Jul 6, 2026

Copy link


Copy Markdown

Member
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
@am11am11
added
the 
arch-riscv
Related to the RISC-V architecture
label
Jul 6, 2026
@LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026

Copy link


Copy Markdown

ContributorAuthor
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
I will apply the patch here and check it on LA64, thanks!
@LuckyXu-HF@am11
apply the fix of RethrowResumeAfterCatchException() for Riscv64 and L…
239e3ca
…oongArch64.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/exceptionhandling.cpp
Outdated


This was referenced Jul 7, 2026

Closed


Closed


Closed

janvorli
janvorli
reviewed
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 9, 2026

Open

3 tasks
am11
am11
approved these changes
Jul 9, 2026
View reviewed changes
@am11am11
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
@am11
am11
requested a review
from janvorliJuly 9, 2026 07:17
janvorli
janvorli
approved these changes
Jul 9, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
/ba-g the failures are build timeouts unrelated to this change.
@janvorli
janvorli
merged commit 0fa7a0f
into
dotnet:mainJul 9, 2026

117 of 125 checks passed

@LuckyXu-HF
LuckyXu-HF
deleted the

main-LA64

branch
July 9, 2026 11:52
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 10, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 10, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@LuckyXu-HF@am11
@janvorli@eiriktsarpalis
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. (#…
4f01697
…129887)
Align [PR#127919](#127919) to fix
the InterpreterTester.sh failed like
issue:#127860 on LA64.
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 10, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+2 more reviewers

@shushanhfshushanhfshushanhf approved these changes
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-loongarch64arch-riscvRelated to the RISC-V architecturearea-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@LuckyXu-HF@am11@janvorli@shushanhf@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. - #129887
Merged
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Jul 9, 2026
Merged
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Conversation
@LuckyXu-HF
@LuckyXu-HFLuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

Contributor
Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 26, 2026
shushanhf
shushanhf
approved these changes
Jun 26, 2026
View reviewed changes
@shushanhfshushanhf
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
@LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

ContributorAuthor
LA64 also hit the same issue like #127860 :
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
corerun: /runtime/src/coreclr/gcinfo/gcinfoencoder.cpp:723: void TGcInfoEncoder<InterpreterGcInfoEncoding>::SetStackBaseRegister(UINT32) [GcInfoEncoding = InterpreterGcInfoEncoding]: Assertion `regNum == 3 || 22 == regNum' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Interpreted App returned 134
System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests() in /runtime/src/tests/JIT/interpreter/InterpreterTester.cs:line 30
at __GeneratedMainWrapper.Main() in /runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/JIT/interpreter/InterpreterTester/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/SimpleRunner.g.cs:line 7
Expected: 100
Actual: 101
END EXECUTION - FAILED

Fixed:
InterpreterTester.sh PASS
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention2Rev: s = 1, 2
TestCallingConvention3Rev: v = 1, 2
TestCallingConvention4Rev: s = 1, 2, 3, 4, 5, 6
TestCallingConvention5Rev: s = 1, 2, 3, 4
TestCallingConvention6Rev: s = 1, 2, 3, 4
TestCallingConvention7Rev: s = 1, 2, 3, 4
TestCallingConvention8Rev: s = 1, 2, 3, 4
TestCallingConvention9Rev: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10Rev: a = 1, b = 2, c = 3
TestCallingConvention11Rev: s = 1, 2, 3
TestCallingConvention12Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention: s = 1
2
TestCallingConvention: s = 1
2
3
4
5
6
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
Sum
Mul4
TestSwitch
PowLoop
TestJitFields
TestFields
TestStructRefFields
TestSpecialFields
TestFloat
TestConvOvf
TestConvOvfUn
TestConvBoundaries
TestLocalloc
TestVirtual
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
TestBoxing
TestArray
TestXxObj
TestSizeof
TestLdtoken
TestMdArray
TestExceptionHandling
1
2
3
Object reference not set to an instance of an object.
4
6
7
TestStringCtor
TestSharedGenerics
Test calls to shared generics from non-generic code
Test calls to shared generics from generic code (unshared generics)
Test calls to shared generics from generic code (shared generics)
Test isinst with shared generics (string)
Test castclass with shared generics (string)
Expected InvalidCastException from casting object to string[]
Test unbox.any with shared generics
Expected InvalidCastException from casting object to string
Test box with shared generics
Test classic unbox instruction with shared generics
Test newarr
Test new MD arr
TestDelegate
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestIntrinsics
Vector128.IsHardwareAccelerated=
False
X86Base.IsSupported=
False
ArmBase.IsSupported=
False
TestCalli
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestStaticVirtualGeneric_CodePointerCase
TestPreciseInitCctors
TestThreading_Interlocked_CompareExchange
TestRuntimeHelpers_IsReferenceOrContainsReferences
TestMemoryMarshal_GetArrayDataReference
Empty string length: 0
BitConverter.IsLittleEndian: True
IntPtr.Zero: 0, UIntPtr.Zero: 0
TestPInvoke
Hello world from pinvoke.dll!writeToStdout
calling missingPInvoke
caught #1
calling missingPInvokeWithMarshaling
caught #2
All tests passed successfully!
Interpreted App returned 100
Expected: 100
Actual: 100
END EXECUTION - PASSED

LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@LuckyXu-HF
LuckyXu-HF
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas@janvorli Could you please review this PR? Thank you.
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg

See info in area-owners.md if you want to be subscribed.
am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

LuckyXu-HFand others
added 5 commits
July 6, 2026 10:18
@LuckyXu-HF@am11
Apply suggestion from@am11
a9aff4e
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
8159821
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
c485cf3
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
45de322
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF
Merge branch 'main' into main-LA64
2205fba
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

@am11
am11
requested review from
janvorli and jkotasJuly 6, 2026 12:30
@am11
am11
commented
Jul 6, 2026

Copy link


Copy Markdown

Member
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
@am11am11
added
the 
arch-riscv
Related to the RISC-V architecture
label
Jul 6, 2026
@LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026

Copy link


Copy Markdown

ContributorAuthor
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
I will apply the patch here and check it on LA64, thanks!
@LuckyXu-HF@am11
apply the fix of RethrowResumeAfterCatchException() for Riscv64 and L…
239e3ca
…oongArch64.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/exceptionhandling.cpp
Outdated


This was referenced Jul 7, 2026

Closed


Closed


Closed

janvorli
janvorli
reviewed
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 9, 2026

Open

3 tasks
am11
am11
approved these changes
Jul 9, 2026
View reviewed changes
@am11am11
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
@am11
am11
requested a review
from janvorliJuly 9, 2026 07:17
janvorli
janvorli
approved these changes
Jul 9, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
/ba-g the failures are build timeouts unrelated to this change.
@janvorli
janvorli
merged commit 0fa7a0f
into
dotnet:mainJul 9, 2026

117 of 125 checks passed

@LuckyXu-HF
LuckyXu-HF
deleted the

main-LA64

branch
July 9, 2026 11:52
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 10, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 10, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@LuckyXu-HF@am11
@janvorli@eiriktsarpalis
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. (#…
4f01697
…129887)
Align [PR#127919](#127919) to fix
the InterpreterTester.sh failed like
issue:#127860 on LA64.
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 10, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+2 more reviewers

@shushanhfshushanhfshushanhf approved these changes
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-loongarch64arch-riscvRelated to the RISC-V architecturearea-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@LuckyXu-HF@am11@janvorli@shushanhf@jkotas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. - #129887
Merged
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Jul 9, 2026
Merged
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64.#129887
janvorli merged 10 commits into
dotnet:mainfrom 
LuckyXu-HF:main-LA64
Conversation
@LuckyXu-HF
@LuckyXu-HFLuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

Contributor
Align PR#127919 to fix the InterpreterTester.sh failed like issue:#127860 on LA64.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jun 26, 2026
shushanhf
shushanhf
approved these changes
Jun 26, 2026
View reviewed changes
@shushanhfshushanhf
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks
@LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026

Copy link


Copy Markdown

ContributorAuthor
LA64 also hit the same issue like #127860 :
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root//corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
corerun: /runtime/src/coreclr/gcinfo/gcinfoencoder.cpp:723: void TGcInfoEncoder<InterpreterGcInfoEncoding>::SetStackBaseRegister(UINT32) [GcInfoEncoding = InterpreterGcInfoEncoding]: Assertion `regNum == 3 || 22 == regNum' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Interpreted App returned 134
System.Exception: Interpreted App failed execution
at InterpreterTester.RunTests() in /runtime/src/tests/JIT/interpreter/InterpreterTester.cs:line 30
at __GeneratedMainWrapper.Main() in /runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/JIT/interpreter/InterpreterTester/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/SimpleRunner.g.cs:line 7
Expected: 100
Actual: 101
END EXECUTION - FAILED

Fixed:
InterpreterTester.sh PASS
root@af0f9dca56cd:/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug# CORE_ROOT=$(pwd)/Tests/Core_Root DOTNET_TieredCompilation=0 ./JIT/interpreter/InterpreterTester/InterpreterTester.sh
BEGIN EXECUTION
/runtime/artifacts/tests/coreclr/linux.loongarch64.Debug/Tests/Core_Root/corerun -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true InterpreterTester.dll ''
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention11: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention2Rev: s = 1, 2
TestCallingConvention3Rev: v = 1, 2
TestCallingConvention4Rev: s = 1, 2, 3, 4, 5, 6
TestCallingConvention5Rev: s = 1, 2, 3, 4
TestCallingConvention6Rev: s = 1, 2, 3, 4
TestCallingConvention7Rev: s = 1, 2, 3, 4
TestCallingConvention8Rev: s = 1, 2, 3, 4
TestCallingConvention9Rev: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10Rev: a = 1, b = 2, c = 3
TestCallingConvention11Rev: s = 1, 2, 3
TestCallingConvention12Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13Rev: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
TestCallingConvention0: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention1: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6
TestCallingConvention: s = 1
2
TestCallingConvention: s = 1
2
3
4
5
6
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention: s = 1
2
3
4
TestCallingConvention9: a = 1, b = 2, c = 3, d = 4
TestCallingConvention10: a = 1, b = 2, c = 3
TestCallingConvention: s = 1
2
3
TestCallingConvention12: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, i = 9, j = a, k = 10, l = 11, m = 12
TestCallingConvention13: a = 1, b = 2, c = 3, d = 4, e = 5, f = 6, g = 7, h = 8, s = (9, 10, 11, 12)
Sum
Mul4
TestSwitch
PowLoop
TestJitFields
TestFields
TestStructRefFields
TestSpecialFields
TestFloat
TestConvOvf
TestConvOvfUn
TestConvBoundaries
TestLocalloc
TestVirtual
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
bc.NonVirtualMethod
bc.VirtualMethod
bc.GenericVirtualMethod<int>
bc.GenericVirtualMethod<string>
itest.VirtualMethod
itest.GenericVirtualMethod<int>
itest.GenericVirtualMethod<string>
TestBoxing
TestArray
TestXxObj
TestSizeof
TestLdtoken
TestMdArray
TestExceptionHandling
1
2
3
Object reference not set to an instance of an object.
4
6
7
TestStringCtor
TestSharedGenerics
Test calls to shared generics from non-generic code
Test calls to shared generics from generic code (unshared generics)
Test calls to shared generics from generic code (shared generics)
Test isinst with shared generics (string)
Test castclass with shared generics (string)
Expected InvalidCastException from casting object to string[]
Test unbox.any with shared generics
Expected InvalidCastException from casting object to string
Test box with shared generics
Test classic unbox instruction with shared generics
Test newarr
Test new MD arr
TestDelegate
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestIntrinsics
Vector128.IsHardwareAccelerated=
False
X86Base.IsSupported=
False
ArmBase.IsSupported=
False
TestCalli
CallingFunc first time
Return CallingFunc first time
CallingFunc second time
Return CallingFunc second time
TestStaticVirtualGeneric_CodePointerCase
TestPreciseInitCctors
TestThreading_Interlocked_CompareExchange
TestRuntimeHelpers_IsReferenceOrContainsReferences
TestMemoryMarshal_GetArrayDataReference
Empty string length: 0
BitConverter.IsLittleEndian: True
IntPtr.Zero: 0, UIntPtr.Zero: 0
TestPInvoke
Hello world from pinvoke.dll!writeToStdout
calling missingPInvoke
caught #1
calling missingPInvokeWithMarshaling
caught #2
All tests passed successfully!
Interpreted App returned 100
Expected: 100
Actual: 100
END EXECUTION - PASSED

LuckyXu-HF
LuckyXu-HF
commented
Jun 26, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@LuckyXu-HF
LuckyXu-HF
commented
Jun 30, 2026

Copy link


Copy Markdown

ContributorAuthor
@jkotas@janvorli Could you please review this PR? Thank you.
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 30, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli, @kg

See info in area-owners.md if you want to be subscribed.
am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

am11
am11
reviewed
Jul 3, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

LuckyXu-HFand others
added 5 commits
July 6, 2026 10:18
@LuckyXu-HF@am11
Apply suggestion from@am11
a9aff4e
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
8159821
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
c485cf3
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF@am11
Update src/coreclr/gcinfo/gcinfoencoder.cpp
45de322
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@LuckyXu-HF
Merge branch 'main' into main-LA64
2205fba
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 6, 2026

Closed

@am11
am11
requested review from
janvorli and jkotasJuly 6, 2026 12:30
@am11
am11
commented
Jul 6, 2026

Copy link


Copy Markdown

Member
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
@am11am11
added
the 
arch-riscv
Related to the RISC-V architecture
label
Jul 6, 2026
@LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026

Copy link


Copy Markdown

ContributorAuthor
@LuckyXu-HF, I had to apply an additional change to make interpreter tests pass on linux-riscv64:
--- a/src/coreclr/vm/exceptionhandling.cpp+++ b/src/coreclr/vm/exceptionhandling.cpp@@ -1664,7 +1664,7 @@ VOID DECLSPEC_NORETURN RethrowResumeAfterCatchException(const ResumeAfterCatchEx
REGDISPLAY rd = {};
T_CONTEXT context = {};
-#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64)+#if (defined(HOST_WINDOWS) && defined(HOST_AMD64)) || defined(TARGET_ARM64) || defined(TARGET_RISCV64)
constexpr BOOL updateFloats = TRUE;
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER | CONTEXT_FLOATING_POINT;
RtlCaptureContext(&context);
It was running into sigsegv in TestSharedGenerics before it prints Test unbox.any with shared generics (basically it wasn't continuing after catch because tp and a0 were null):
runtime/src/tests/JIT/interpreter/Interpreter.cs

Lines 2200 to 2203
in
22439c0
Console.WriteLine("Expected InvalidCastException from casting object to string[]");
}
Console.WriteLine("Test unbox.any with shared generics");
Are you sure LA64 doesn't need it?
If you could apply that patch here, that would be great, otherwise I will send a separate PR. (It took me a day and a half to figure this out 😅)
I will apply the patch here and check it on LA64, thanks!
@LuckyXu-HF@am11
apply the fix of RethrowResumeAfterCatchException() for Riscv64 and L…
239e3ca
…oongArch64.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
LuckyXu-HF
LuckyXu-HF
commented
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/vm/exceptionhandling.cpp
Outdated


This was referenced Jul 7, 2026

Closed


Closed


Closed

janvorli
janvorli
reviewed
Jul 7, 2026
View reviewed changes
Comment threadsrc/coreclr/gcinfo/gcinfoencoder.cpp
Outdated

@build-analysisbuild-analysisBot
mentioned this pull request
Jul 9, 2026

Open

3 tasks
am11
am11
approved these changes
Jul 9, 2026
View reviewed changes
@am11am11
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!
@am11
am11
requested a review
from janvorliJuly 9, 2026 07:17
janvorli
janvorli
approved these changes
Jul 9, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
commented
Jul 9, 2026

Copy link


Copy Markdown

Member
/ba-g the failures are build timeouts unrelated to this change.
@janvorli
janvorli
merged commit 0fa7a0f
into
dotnet:mainJul 9, 2026

117 of 125 checks passed

@LuckyXu-HF
LuckyXu-HF
deleted the

main-LA64

branch
July 9, 2026 11:52
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 10, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 10, 2026
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
@LuckyXu-HF@am11
@janvorli@eiriktsarpalis
[LoongArch64] Apply fixes for coreclr-interp on linux-loongarch64. (#…
4f01697
…129887)
Align [PR#127919](#127919) to fix
the InterpreterTester.sh failed like
issue:#127860 on LA64.
---------
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 10, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@jkotasjkotasAwaiting requested review from jkotas

+2 more reviewers

@shushanhfshushanhfshushanhf approved these changes
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

arch-loongarch64arch-riscvRelated to the RISC-V architecturearea-CodeGen-Interpreter-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@LuckyXu-HF@am11@janvorli@shushanhf@jkotas