Skip to content

Disable test based on #129 - #130

Merged
jashook merged 1 commit into
dotnet:masterfrom
jashook:disable_based_on_129
Nov 19, 2019
Merged

Disable test based on #129#130
jashook merged 1 commit into
dotnet:masterfrom
jashook:disable_based_on_129

Conversation

@jashook

@jashookjashook commented Nov 19, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Outerloop tests were just run, this does not need to be re-done as this is expensive.

@Dotnet-GitSync-BotDotnet-GitSync-Bot added the area-Infrastructure-coreclr Only use for closed issues label Nov 19, 2019
@jashookjashook added the disabled-test The test is disabled in source code against the issue label Nov 19, 2019
@jashook
jashook requested a review from trylekNovember 19, 2019 21:00
trylek
trylek approved these changes Nov 19, 2019
View reviewed changes

@trylektrylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jashook

jashook commented Nov 19, 2019

Copy link
Copy Markdown
ContributorAuthor

Merging to save machine cycles

@jashook
jashook merged commit 3a2dc0f into dotnet:masterNov 19, 2019
@jashook
jashook deleted the disable_based_on_129 branch November 19, 2019 21:17
stephentoub pushed a commit that referenced this pull request Jan 29, 2020
@kouvel
Revert "Disable test based on#129(#130)" (#2310)
427cd91
This reverts commit 3a2dc0f.
Fixed by #1457. Closes#129.
jkotas added a commit that referenced this pull request Feb 1, 2020
@jkotas
Revert "Improve call counting mechanism (#1457)" (#30105)
f954c6b
* Revert "Revert "Disable test based on #129 (#130)" (#2310)"
This reverts commit 427cd91.
* Revert "Fail FuncEval if slot backpatching lock is held by any thread (#2380)"
This reverts commit fc06054.
* Revert "Improve call counting mechanism (#1457)"
This reverts commit 3a457cb.
@karelzkarelz added this to the 5.0.0 milestone Aug 18, 2020
@ghostghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylektrylektrylek approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-coreclrOnly use for closed issuesdisabled-testThe test is disabled in source code against the issue

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jashook@trylek@karelz@Dotnet-GitSync-Bot