Skip to content

Align NativeAOT array element size limit - #130019

Merged
MichalStrehovsky merged 3 commits into
mainfrom
copilot/fix-array-type-size-limit
Jul 1, 2026
Merged

Align NativeAOT array element size limit#130019
MichalStrehovsky merged 3 commits into
mainfrom
copilot/fix-array-type-size-limit

Conversation

CopilotAI commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

NativeAOT rejected array element value types of exactly 65,535 bytes, while CoreCLR allows that boundary value. The validation now rejects only element sizes greater than ushort.MaxValue.

  • Updated NativeAOT compiler type validation:
    • >= ushort.MaxValue → > ushort.MaxValue
  • Added a focused InlineArray regression test:
    • Verifies [InlineArray(65535)] can be used as an array element type.
    • Covers NativeAOT compilation via IlcCompile.
vararray=newMaxSizedArrayElement[1];[InlineArray(65535)]structMaxSizedArrayElement{privatebyte_first;}

Test methodology

  • Built the NativeAOT compiler project.
  • Built and ran the new regression test on CoreCLR.
  • Built and ran the NativeAOT-compiled test binary.

Additional context

This keeps NativeAOT behavior consistent with CoreCLR at the maximum supported array element size boundary.

CopilotAI requested review from Copilot and removed request for CopilotJune 30, 2026 03:45
@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Fix NativeAOT max array element size validation
2a0c8a8
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
CopilotAI requested review from Copilot and removed request for CopilotJune 30, 2026 04:34
CopilotAI changed the title [WIP] Fix maximum allowed size of base type in arrays in NativeAOTAlign NativeAOT array element size limitJun 30, 2026
CopilotAI review requested due to automatic review settings June 30, 2026 04:39
@MichalStrehovsky
MichalStrehovsky marked this pull request as ready for review June 30, 2026 04:40
@MichalStrehovsky

MichalStrehovsky commented Jun 30, 2026

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop, runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Jun 30, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

CopilotAI reviewed Jun 30, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns NativeAOT’s array element-size validation with the runtime limit so that value-type array elements of exactly 65,535 bytes are accepted (matching CoreCLR behavior at the boundary). This avoids rejecting a size that still fits the GCDesc/component-size encodings used by the NativeAOT toolchain.

Changes:

  • Adjusted NativeAOT type loadability validation for arrays to reject only element sizes greater thanushort.MaxValue.
  • Added a new InlineArray-focused regression test project and test that exercises using an [InlineArray(65535)] struct as an array element type.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
src/coreclr/tools/Common/Compiler/CompilerTypeSystemContext.Validation.csUpdates array element-size check from >= ushort.MaxValue to > ushort.MaxValue, allowing the 65,535-byte boundary.
src/tests/Loader/classloader/InlineArray/MaxArrayElementSize.csprojAdds a new standalone test project for the regression scenario.
src/tests/Loader/classloader/InlineArray/MaxArrayElementSize.csAdds a test covering [InlineArray(65535)] as an array element type (size + successful array construction).

This was referenced Jun 30, 2026
Closed
Closed
@hez2010

hez2010 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Can this be backported to .NET 10 as well?

@jkotas

jkotas commented Jun 30, 2026

Copy link
Copy Markdown
Member

This does not meet the bar for backport.

@MichalStrehovsky

MichalStrehovsky commented Jul 1, 2026

Copy link
Copy Markdown
Member

/ba-g the alpine libatomic issue is known

@MichalStrehovsky
MichalStrehovsky enabled auto-merge (squash) July 1, 2026 00:17
@MichalStrehovsky
MichalStrehovsky merged commit 3880698 into mainJul 1, 2026
175 of 196 checks passed
@MichalStrehovsky
MichalStrehovsky deleted the copilot/fix-array-type-size-limit branch July 1, 2026 00:17
@MichalStrehovsky
MichalStrehovsky restored the copilot/fix-array-type-size-limit branch July 1, 2026 00:17
@MichalStrehovsky
MichalStrehovsky deleted the copilot/fix-array-type-size-limit branch July 1, 2026 00:17
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jul 1, 2026
Merged
@MichalStrehovskyMichalStrehovsky mentioned this pull request Jul 1, 2026
Closed
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview7 milestone Jul 1, 2026
eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
@MichalStrehovsky@eiriktsarpalis
Align NativeAOT array element size limit (#130019)
d5690c4
### Description
NativeAOT rejected array element value types of exactly 65,535 bytes,
while CoreCLR allows that boundary value. The validation now rejects
only element sizes greater than `ushort.MaxValue`.
- Updated NativeAOT compiler type validation:
- `>= ushort.MaxValue` → `> ushort.MaxValue`
- Added a focused InlineArray regression test:
- Verifies `[InlineArray(65535)]` can be used as an array element type.
- Covers NativeAOT compilation via `IlcCompile`.
```csharp
var array = new MaxSizedArrayElement[1];
[InlineArray(65535)]
struct MaxSizedArrayElement
{
private byte _first;
}
```
### Test methodology
- Built the NativeAOT compiler project.
- Built and ran the new regression test on CoreCLR.
- Built and ran the NativeAOT-compiled test binary.
### Additional context
This keeps NativeAOT behavior consistent with CoreCLR at the maximum
supported array element size boundary.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@LuckyXu-HFLuckyXu-HF mentioned this pull request Jul 17, 2026
Merged
jakobbotsch pushed a commit that referenced this pull request Jul 23, 2026
@LuckyXu-HF
[LoongArch64] Fix them_usComponentSizeload inRhpNewArrayFast. (#…
5b9d56d
…130958)
* Fix the SIGBUS error of Loader.sh hit by
[PR#130019's](#130019)
MaxArrayElementSize.
* Add dasm GC info print.
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 1, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkotasjkotasjkotas approved these changes
+1 more reviewer
@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@MichalStrehovskyMichalStrehovsky

Copilot code reviewCopilot

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

5 participants

@MichalStrehovsky@hez2010@jkotas