Uh oh!
There was an error while loading. Please reload this page.
Gate ILCompiler pack version update to explicit references - #130098
Merged
Conversation
Only update KnownILCompilerPack from the ILCompiler package targets when the project has an explicit Microsoft.DotNet.ILCompiler PackageReference. This preserves the SDK bundled version for implicit package references during design-time restore with stale assets. Assisted-by: GitHub Copilot CLI:gpt-5.5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes NativeAOT build integration so the Microsoft.DotNet.ILCompiler package’s imported .targets only updates KnownILCompilerPack when there is an explicitPackageReference to Microsoft.DotNet.ILCompiler, preventing implicit (SDK-generated) references from overriding the SDK-bundled pack version.
Changes:
- Replaces an evaluation-time
ItemGroupupdate ofKnownILCompilerPackwith a target that runsBeforeTargets="ProcessFrameworkReferences". - Adds a guard intended to apply the
KnownILCompilerPackversion update only whenMicrosoft.DotNet.ILCompileris explicitly referenced (non-implicitPackageReference).
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets | Gates updating KnownILCompilerPack to explicit Microsoft.DotNet.ILCompiler package references and moves the update to a pre-ProcessFrameworkReferences target. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Uh oh!
There was an error while loading. Please reload this page.
Compute explicit Microsoft.DotNet.ILCompiler package references into a helper item before updating KnownILCompilerPack. This keeps the update deterministic while preserving the explicit package reference behavior. Assisted-by: GitHub Copilot CLI:gpt-5.5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jkotas
commented
Jul 1, 2026
Member
Does #119166 (comment) still work with this change? |
sbomer
commented
Jul 2, 2026
MemberAuthor
Yes, I've confirmed that workaround still works. |
MichalStrehovsky
approved these changes
Jul 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
Fixes a stale restore/design-time restore interaction where imported Microsoft.DotNet.ILCompiler package targets could overwrite the SDK bundled KnownILCompilerPack version from an old assets file. The package targets still update KnownILCompilerPack for explicit Microsoft.DotNet.ILCompiler PackageReference entries, preserving the documented custom/daily ILC package scenario, but they no longer do so for SDK-generated implicit references. Validation: - Verified implicit PackageReference keeps the SDK bundled ILCompiler version while explicit PackageReference still updates KnownILCompilerPack to the package version. - Reproduced the SDK upgrade stale-assets scenario with SDK 10.0.100 -> 10.0.103 and verified CollectPackageReferences now reports Microsoft.DotNet.ILCompiler 10.0.3 instead of stale 10.0.0. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a stale restore/design-time restore interaction where imported Microsoft.DotNet.ILCompiler package targets could overwrite the SDK bundled KnownILCompilerPack version from an old assets file.
The package targets still update KnownILCompilerPack for explicit Microsoft.DotNet.ILCompiler PackageReference entries, preserving the documented custom/daily ILC package scenario, but they no longer do so for SDK-generated implicit references.
Validation: