Uh oh!
There was an error while loading. Please reload this page.
JIT: initialize emitCurIG at declaration - #130186
Merged
AndyAyersMS merged 1 commit intoJul 3, 2026
Merged
Conversation
The RISC-V emitter has cost-estimation calls into emitLoadImmediate from gtSetEvalOrder that hit the new emitGeneratingProlog check before codegen runs emitter::Init(), reading a poisoned emitCurIG and crashing. Fixesdotnet#130145.
Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the JIT emitter’s current instruction group pointer (emitCurIG) default-initialize to nullptr so that helper queries like emitGeneratingPrologOrFuncletProlog() behave safely before emitter::Init() runs.
Changes:
- Initialize
emitter::emitCurIGat declaration (= nullptr) to avoid reading an uninitialized/poisoned pointer prior toInit(). - Ensures early-phase callers that consult prolog/funclet state (via
emitGeneratingPrologOrFuncletProlog()) returnfalseinstead of dereferencing garbage.
AndyAyersMS
commented
Jul 3, 2026
MemberAuthor
@dotnet/jit-contrib PTAL -- tiny change |
tannergooding
approved these changes
Jul 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
eiriktsarpalis pushed a commit
that referenced
this pull request
Jul 15, 2026
The RISC-V emitter has cost-estimation calls into `emitLoadImmediate` from `gtSetEvalOrder` that hit the new `emitGeneratingPrologOrFuncletProlog` check before codegen runs `emitter::Init()`, reading a poisoned `emitCurIG` and crashing (SIGSEGV in `emitIGisInProlog(ig=0xdddddddddddddddd)`). Fixes#130145. Verified locally by reproducing the CI failure with an x64-host RISC-V cross-JIT on `ilc @ilc.ilc.rsp`: prior to this change, exits 139 with a coredump whose stack is `emitIGisInProlog(0xdddd...) <- emitGeneratingPrologOrFuncletProlog <- emitLoadImmediate<false> <- gtSetEvalOrder <- fgFindOperOrder <- compCompile` while JITing `System.DateTimeOffset:ToString()`. With this change, `ilc` produces the RISC-V `ilc.o` and exits 0. > [!NOTE] > AI-assisted PR created via GitHub Copilot CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RISC-V emitter has cost-estimation calls into
emitLoadImmediatefromgtSetEvalOrderthat hit the newemitGeneratingPrologOrFuncletPrologcheck before codegen runsemitter::Init(), reading a poisonedemitCurIGand crashing (SIGSEGV inemitIGisInProlog(ig=0xdddddddddddddddd)).Fixes#130145.
Verified locally by reproducing the CI failure with an x64-host RISC-V cross-JIT on
ilc @ilc.ilc.rsp: prior to this change, exits 139 with a coredump whose stack isemitIGisInProlog(0xdddd...) <- emitGeneratingPrologOrFuncletProlog <- emitLoadImmediate<false> <- gtSetEvalOrder <- fgFindOperOrder <- compCompilewhile JITingSystem.DateTimeOffset:ToString(). With this change,ilcproduces the RISC-Vilc.oand exits 0.Note
AI-assisted PR created via GitHub Copilot CLI.