Remove unused parameter in RestartGC - #130557

Merged
janvorli merged 9 commits into
dotnet:mainfrom
kant2002:kant/remove-unused-parameter
Aug 6, 2026
Merged

Remove unused parameter in RestartGC#130557
janvorli merged 9 commits into
dotnet:mainfrom
kant2002:kant/remove-unused-parameter

Conversation

@kant2002

@kant2002kant2002 commented Jul 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

I did touch public part which is used for standalone GC, and that would be a breaking change.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2026
@dotnet-policy-service

dotnet-policy-serviceBot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @anicka-net, @dotnet/gc
See info in area-owners.md if you want to be subscribed.

jkotas
jkotas reviewed Jul 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.ee.h Outdated
@github-actions

github-actionsBot commented Jul 19, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29681934604",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"review_id": 4730544514
}
]
}

github-actions[bot]
github-actionsBot reviewed Jul 19, 2026
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review

Motivation: RestartEE (both the GC↔EE interface method GCToEEInterface::RestartEE and the VM helper ThreadSuspend::RestartEE) carried a bFinishedGC boolean parameter that is no longer read anywhere in the implementation. Removing dead parameters is a reasonable cleanup that simplifies the many call sites and the standalone-GC interface contract.

Approach: The PR drops bFinishedGC from ThreadSuspend::RestartEE(BOOL SuspendSucceeded) and from GCToEEInterface::RestartEE(), updating the pure-virtual declaration in gcinterface.ee.h, the standalone shims (gctoeeinterface.standalone.inl, gcenv.ee.standalone.inl), the sample/NativeAOT implementations, and all call sites across src/coreclr/gc and src/coreclr/vm. I verified bFinishedGC is indeed unused in the ThreadSuspend::RestartEE body. Since this changes the public standalone-GC IGCToCLR v-table signature, it is an intentional breaking change to that interface, as the author notes.

Summary: The refactor is mechanically correct for the files it touches, but it is incomplete: one call site was missed and will break the CoreCLR build, and one doc comment is now stale. These must be fixed before merge.

Detailed Findings

1. Missed call site breaks the build (blocking).src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp:167 still calls the old two-argument overload:

ThreadSuspend::RestartEE (FALSE/* bFinishedGC */, TRUE/* SuspendSucceeded */);

This file is not part of the PR, so with the signature now RestartEE(BOOL SuspendSucceeded) this call will fail to compile (SuspendEE is called just above, so the intended argument is TRUE). It should be updated to ThreadSuspend::RestartEE (TRUE /* SuspendSucceeded */);. A repo-wide search for remaining multi-argument RestartEE(...) calls confirms this is the only missed site.

2. Stale doc comment. See the inline comment on src/coreclr/gc/gcinterface.ee.h — the comment still describes the removed boolean.

No other correctness, threading, or interface concerns were found; the argument substitutions at the updated call sites (mapping the old SuspendSucceeded/second argument through) all look correct.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 70.3 AIC · ⌖ 14.8 AIC · ⊞ 10K

Comment threadsrc/coreclr/gc/gcinterface.ee.h Outdated
This was referenced Jul 23, 2026
Open
Open
kkokosa
kkokosa reviewed Jul 31, 2026
View reviewed changes

@kkokosakkokosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to finalize this PR.

Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl Outdated
Comment threadsrc/coreclr/gc/gc.cpp Outdated
Comment threadsrc/coreclr/gc/gcenv.ee.standalone.inl Outdated
@kant2002

kant2002 commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

@kkokosa errors from the other issues, unrelated.

janvorli
janvorli reviewed Aug 5, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl Outdated
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl Outdated
@kant2002
kant2002force-pushed the kant/remove-unused-parameter branch from 5899efc to a0a2cafCompareAugust 5, 2026 19:48
janvorli
janvorli approved these changes Aug 5, 2026
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
janvorli merged commit 69bbf82 into dotnet:mainAug 6, 2026
111 checks passed
@dotnet-maestrodotnet-maestroBot mentioned this pull request Aug 7, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
@kant2002@jtschuster
Remove unused parameter in RestartGC (dotnet#130557)
7d0190e
I did touch public part which is used for standalone GC, and that would
be a breaking change.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotasjkotasjkotas left review comments
@kkokosakkokosakkokosa left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@janvorlijanvorlijanvorli approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

No one assigned

Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@jkotas@janvorli@kkokosa
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Remove unused parameter in RestartGC - #130557
Merged
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Aug 6, 2026
Merged
Remove unused parameter in RestartGC#130557
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Conversation
@kant2002
@kant2002kant2002
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
I did touch public part which is used for standalone GC, and that would be a breaking change.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jul 11, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @anicka-net, @dotnet/gc

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
reviewed
Jul 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated

@github-actions
github-actionsBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Workflow state for the Holistic Review Orchestrator.
{
"version": 5,
"last_dispatched_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29681934604",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"review_id": 4730544514
}
]
}
github-actions[bot]
github-actionsBot
reviewed
Jul 19, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review
Motivation: RestartEE (both the GC↔EE interface method GCToEEInterface::RestartEE and the VM helper ThreadSuspend::RestartEE) carried a bFinishedGC boolean parameter that is no longer read anywhere in the implementation. Removing dead parameters is a reasonable cleanup that simplifies the many call sites and the standalone-GC interface contract.
Approach: The PR drops bFinishedGC from ThreadSuspend::RestartEE(BOOL SuspendSucceeded) and from GCToEEInterface::RestartEE(), updating the pure-virtual declaration in gcinterface.ee.h, the standalone shims (gctoeeinterface.standalone.inl, gcenv.ee.standalone.inl), the sample/NativeAOT implementations, and all call sites across src/coreclr/gc and src/coreclr/vm. I verified bFinishedGC is indeed unused in the ThreadSuspend::RestartEE body. Since this changes the public standalone-GC IGCToCLR v-table signature, it is an intentional breaking change to that interface, as the author notes.
Summary: The refactor is mechanically correct for the files it touches, but it is incomplete: one call site was missed and will break the CoreCLR build, and one doc comment is now stale. These must be fixed before merge.
Detailed Findings
1. Missed call site breaks the build (blocking).src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp:167 still calls the old two-argument overload:
ThreadSuspend::RestartEE (FALSE/* bFinishedGC */, TRUE/* SuspendSucceeded */);
This file is not part of the PR, so with the signature now RestartEE(BOOL SuspendSucceeded) this call will fail to compile (SuspendEE is called just above, so the intended argument is TRUE). It should be updated to ThreadSuspend::RestartEE (TRUE /* SuspendSucceeded */);. A repo-wide search for remaining multi-argument RestartEE(...) calls confirms this is the only missed site.
2. Stale doc comment. See the inline comment on src/coreclr/gc/gcinterface.ee.h — the comment still describes the removed boolean.
No other correctness, threading, or interface concerns were found; the argument substitutions at the updated call sites (mapping the old SuspendSucceeded/second argument through) all look correct.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 70.3 AIC · ⌖ 14.8 AIC · ⊞ 10K
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated


This was referenced Jul 23, 2026

Open


Open

kkokosa
kkokosa
reviewed
Jul 31, 2026
View reviewed changes
@kkokosakkokosa
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to finalize this PR.
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/gc.cpp
Outdated

Comment threadsrc/coreclr/gc/gcenv.ee.standalone.inl
Outdated

@kant2002
kant2002
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@kkokosa errors from the other issues, unrelated.
janvorli
janvorli
reviewed
Aug 5, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

@kant2002
kant2002force-pushed
the
kant/remove-unused-parameter
branch
from
5899efc to
a0a2cafCompareAugust 5, 2026 19:48
janvorli
janvorli
approved these changes
Aug 5, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
merged commit 69bbf82
into
dotnet:mainAug 6, 2026

111 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 7, 2026
jtschuster pushed a commit
to jtschuster/runtime
that referenced
this pull request
Aug 11, 2026
@kant2002@jtschuster
Remove unused parameter in RestartGC (dotnet#130557)
7d0190e
I did touch public part which is used for standalone GC, and that would
be a breaking change.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkotasjkotasjkotas left review comments
@kkokosakkokosakkokosa left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@janvorlijanvorlijanvorli approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees


No one assigned


Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@jkotas@janvorli@kkokosa

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove unused parameter in RestartGC - #130557
Merged
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Aug 6, 2026
Merged
Remove unused parameter in RestartGC#130557
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Conversation
@kant2002
@kant2002kant2002
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
I did touch public part which is used for standalone GC, and that would be a breaking change.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jul 11, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @anicka-net, @dotnet/gc

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
reviewed
Jul 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated

@github-actions
github-actionsBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Workflow state for the Holistic Review Orchestrator.
{
"version": 5,
"last_dispatched_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29681934604",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"review_id": 4730544514
}
]
}
github-actions[bot]
github-actionsBot
reviewed
Jul 19, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review
Motivation: RestartEE (both the GC↔EE interface method GCToEEInterface::RestartEE and the VM helper ThreadSuspend::RestartEE) carried a bFinishedGC boolean parameter that is no longer read anywhere in the implementation. Removing dead parameters is a reasonable cleanup that simplifies the many call sites and the standalone-GC interface contract.
Approach: The PR drops bFinishedGC from ThreadSuspend::RestartEE(BOOL SuspendSucceeded) and from GCToEEInterface::RestartEE(), updating the pure-virtual declaration in gcinterface.ee.h, the standalone shims (gctoeeinterface.standalone.inl, gcenv.ee.standalone.inl), the sample/NativeAOT implementations, and all call sites across src/coreclr/gc and src/coreclr/vm. I verified bFinishedGC is indeed unused in the ThreadSuspend::RestartEE body. Since this changes the public standalone-GC IGCToCLR v-table signature, it is an intentional breaking change to that interface, as the author notes.
Summary: The refactor is mechanically correct for the files it touches, but it is incomplete: one call site was missed and will break the CoreCLR build, and one doc comment is now stale. These must be fixed before merge.
Detailed Findings
1. Missed call site breaks the build (blocking).src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp:167 still calls the old two-argument overload:
ThreadSuspend::RestartEE (FALSE/* bFinishedGC */, TRUE/* SuspendSucceeded */);
This file is not part of the PR, so with the signature now RestartEE(BOOL SuspendSucceeded) this call will fail to compile (SuspendEE is called just above, so the intended argument is TRUE). It should be updated to ThreadSuspend::RestartEE (TRUE /* SuspendSucceeded */);. A repo-wide search for remaining multi-argument RestartEE(...) calls confirms this is the only missed site.
2. Stale doc comment. See the inline comment on src/coreclr/gc/gcinterface.ee.h — the comment still describes the removed boolean.
No other correctness, threading, or interface concerns were found; the argument substitutions at the updated call sites (mapping the old SuspendSucceeded/second argument through) all look correct.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 70.3 AIC · ⌖ 14.8 AIC · ⊞ 10K
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated


This was referenced Jul 23, 2026

Open


Open

kkokosa
kkokosa
reviewed
Jul 31, 2026
View reviewed changes
@kkokosakkokosa
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to finalize this PR.
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/gc.cpp
Outdated

Comment threadsrc/coreclr/gc/gcenv.ee.standalone.inl
Outdated

@kant2002
kant2002
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@kkokosa errors from the other issues, unrelated.
janvorli
janvorli
reviewed
Aug 5, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

@kant2002
kant2002force-pushed
the
kant/remove-unused-parameter
branch
from
5899efc to
a0a2cafCompareAugust 5, 2026 19:48
janvorli
janvorli
approved these changes
Aug 5, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
merged commit 69bbf82
into
dotnet:mainAug 6, 2026

111 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 7, 2026
jtschuster pushed a commit
to jtschuster/runtime
that referenced
this pull request
Aug 11, 2026
@kant2002@jtschuster
Remove unused parameter in RestartGC (dotnet#130557)
7d0190e
I did touch public part which is used for standalone GC, and that would
be a breaking change.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkotasjkotasjkotas left review comments
@kkokosakkokosakkokosa left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@janvorlijanvorlijanvorli approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees


No one assigned


Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@jkotas@janvorli@kkokosa

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove unused parameter in RestartGC - #130557
Merged
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Aug 6, 2026
Merged
Remove unused parameter in RestartGC#130557
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Conversation
@kant2002
@kant2002kant2002
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
I did touch public part which is used for standalone GC, and that would be a breaking change.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jul 11, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @anicka-net, @dotnet/gc

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
reviewed
Jul 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated

@github-actions
github-actionsBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Workflow state for the Holistic Review Orchestrator.
{
"version": 5,
"last_dispatched_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29681934604",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"review_id": 4730544514
}
]
}
github-actions[bot]
github-actionsBot
reviewed
Jul 19, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review
Motivation: RestartEE (both the GC↔EE interface method GCToEEInterface::RestartEE and the VM helper ThreadSuspend::RestartEE) carried a bFinishedGC boolean parameter that is no longer read anywhere in the implementation. Removing dead parameters is a reasonable cleanup that simplifies the many call sites and the standalone-GC interface contract.
Approach: The PR drops bFinishedGC from ThreadSuspend::RestartEE(BOOL SuspendSucceeded) and from GCToEEInterface::RestartEE(), updating the pure-virtual declaration in gcinterface.ee.h, the standalone shims (gctoeeinterface.standalone.inl, gcenv.ee.standalone.inl), the sample/NativeAOT implementations, and all call sites across src/coreclr/gc and src/coreclr/vm. I verified bFinishedGC is indeed unused in the ThreadSuspend::RestartEE body. Since this changes the public standalone-GC IGCToCLR v-table signature, it is an intentional breaking change to that interface, as the author notes.
Summary: The refactor is mechanically correct for the files it touches, but it is incomplete: one call site was missed and will break the CoreCLR build, and one doc comment is now stale. These must be fixed before merge.
Detailed Findings
1. Missed call site breaks the build (blocking).src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp:167 still calls the old two-argument overload:
ThreadSuspend::RestartEE (FALSE/* bFinishedGC */, TRUE/* SuspendSucceeded */);
This file is not part of the PR, so with the signature now RestartEE(BOOL SuspendSucceeded) this call will fail to compile (SuspendEE is called just above, so the intended argument is TRUE). It should be updated to ThreadSuspend::RestartEE (TRUE /* SuspendSucceeded */);. A repo-wide search for remaining multi-argument RestartEE(...) calls confirms this is the only missed site.
2. Stale doc comment. See the inline comment on src/coreclr/gc/gcinterface.ee.h — the comment still describes the removed boolean.
No other correctness, threading, or interface concerns were found; the argument substitutions at the updated call sites (mapping the old SuspendSucceeded/second argument through) all look correct.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 70.3 AIC · ⌖ 14.8 AIC · ⊞ 10K
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated


This was referenced Jul 23, 2026

Open


Open

kkokosa
kkokosa
reviewed
Jul 31, 2026
View reviewed changes
@kkokosakkokosa
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to finalize this PR.
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/gc.cpp
Outdated

Comment threadsrc/coreclr/gc/gcenv.ee.standalone.inl
Outdated

@kant2002
kant2002
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@kkokosa errors from the other issues, unrelated.
janvorli
janvorli
reviewed
Aug 5, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

@kant2002
kant2002force-pushed
the
kant/remove-unused-parameter
branch
from
5899efc to
a0a2cafCompareAugust 5, 2026 19:48
janvorli
janvorli
approved these changes
Aug 5, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
merged commit 69bbf82
into
dotnet:mainAug 6, 2026

111 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 7, 2026
jtschuster pushed a commit
to jtschuster/runtime
that referenced
this pull request
Aug 11, 2026
@kant2002@jtschuster
Remove unused parameter in RestartGC (dotnet#130557)
7d0190e
I did touch public part which is used for standalone GC, and that would
be a breaking change.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkotasjkotasjkotas left review comments
@kkokosakkokosakkokosa left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@janvorlijanvorlijanvorli approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees


No one assigned


Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@jkotas@janvorli@kkokosa

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Remove unused parameter in RestartGC - #130557
Merged
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Aug 6, 2026
Merged
Remove unused parameter in RestartGC#130557
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Conversation
@kant2002
@kant2002kant2002
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
I did touch public part which is used for standalone GC, and that would be a breaking change.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jul 11, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @anicka-net, @dotnet/gc

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
reviewed
Jul 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated

@github-actions
github-actionsBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Workflow state for the Holistic Review Orchestrator.
{
"version": 5,
"last_dispatched_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29681934604",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"review_id": 4730544514
}
]
}
github-actions[bot]
github-actionsBot
reviewed
Jul 19, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review
Motivation: RestartEE (both the GC↔EE interface method GCToEEInterface::RestartEE and the VM helper ThreadSuspend::RestartEE) carried a bFinishedGC boolean parameter that is no longer read anywhere in the implementation. Removing dead parameters is a reasonable cleanup that simplifies the many call sites and the standalone-GC interface contract.
Approach: The PR drops bFinishedGC from ThreadSuspend::RestartEE(BOOL SuspendSucceeded) and from GCToEEInterface::RestartEE(), updating the pure-virtual declaration in gcinterface.ee.h, the standalone shims (gctoeeinterface.standalone.inl, gcenv.ee.standalone.inl), the sample/NativeAOT implementations, and all call sites across src/coreclr/gc and src/coreclr/vm. I verified bFinishedGC is indeed unused in the ThreadSuspend::RestartEE body. Since this changes the public standalone-GC IGCToCLR v-table signature, it is an intentional breaking change to that interface, as the author notes.
Summary: The refactor is mechanically correct for the files it touches, but it is incomplete: one call site was missed and will break the CoreCLR build, and one doc comment is now stale. These must be fixed before merge.
Detailed Findings
1. Missed call site breaks the build (blocking).src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp:167 still calls the old two-argument overload:
ThreadSuspend::RestartEE (FALSE/* bFinishedGC */, TRUE/* SuspendSucceeded */);
This file is not part of the PR, so with the signature now RestartEE(BOOL SuspendSucceeded) this call will fail to compile (SuspendEE is called just above, so the intended argument is TRUE). It should be updated to ThreadSuspend::RestartEE (TRUE /* SuspendSucceeded */);. A repo-wide search for remaining multi-argument RestartEE(...) calls confirms this is the only missed site.
2. Stale doc comment. See the inline comment on src/coreclr/gc/gcinterface.ee.h — the comment still describes the removed boolean.
No other correctness, threading, or interface concerns were found; the argument substitutions at the updated call sites (mapping the old SuspendSucceeded/second argument through) all look correct.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 70.3 AIC · ⌖ 14.8 AIC · ⊞ 10K
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated


This was referenced Jul 23, 2026

Open


Open

kkokosa
kkokosa
reviewed
Jul 31, 2026
View reviewed changes
@kkokosakkokosa
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to finalize this PR.
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/gc.cpp
Outdated

Comment threadsrc/coreclr/gc/gcenv.ee.standalone.inl
Outdated

@kant2002
kant2002
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@kkokosa errors from the other issues, unrelated.
janvorli
janvorli
reviewed
Aug 5, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

@kant2002
kant2002force-pushed
the
kant/remove-unused-parameter
branch
from
5899efc to
a0a2cafCompareAugust 5, 2026 19:48
janvorli
janvorli
approved these changes
Aug 5, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
merged commit 69bbf82
into
dotnet:mainAug 6, 2026

111 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 7, 2026
jtschuster pushed a commit
to jtschuster/runtime
that referenced
this pull request
Aug 11, 2026
@kant2002@jtschuster
Remove unused parameter in RestartGC (dotnet#130557)
7d0190e
I did touch public part which is used for standalone GC, and that would
be a breaking change.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkotasjkotasjkotas left review comments
@kkokosakkokosakkokosa left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@janvorlijanvorlijanvorli approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees


No one assigned


Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@jkotas@janvorli@kkokosa

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove unused parameter in RestartGC - #130557
Merged
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Aug 6, 2026
Merged
Remove unused parameter in RestartGC#130557
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Conversation
@kant2002
@kant2002kant2002
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
I did touch public part which is used for standalone GC, and that would be a breaking change.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jul 11, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @anicka-net, @dotnet/gc

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
reviewed
Jul 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated

@github-actions
github-actionsBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Workflow state for the Holistic Review Orchestrator.
{
"version": 5,
"last_dispatched_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29681934604",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"review_id": 4730544514
}
]
}
github-actions[bot]
github-actionsBot
reviewed
Jul 19, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review
Motivation: RestartEE (both the GC↔EE interface method GCToEEInterface::RestartEE and the VM helper ThreadSuspend::RestartEE) carried a bFinishedGC boolean parameter that is no longer read anywhere in the implementation. Removing dead parameters is a reasonable cleanup that simplifies the many call sites and the standalone-GC interface contract.
Approach: The PR drops bFinishedGC from ThreadSuspend::RestartEE(BOOL SuspendSucceeded) and from GCToEEInterface::RestartEE(), updating the pure-virtual declaration in gcinterface.ee.h, the standalone shims (gctoeeinterface.standalone.inl, gcenv.ee.standalone.inl), the sample/NativeAOT implementations, and all call sites across src/coreclr/gc and src/coreclr/vm. I verified bFinishedGC is indeed unused in the ThreadSuspend::RestartEE body. Since this changes the public standalone-GC IGCToCLR v-table signature, it is an intentional breaking change to that interface, as the author notes.
Summary: The refactor is mechanically correct for the files it touches, but it is incomplete: one call site was missed and will break the CoreCLR build, and one doc comment is now stale. These must be fixed before merge.
Detailed Findings
1. Missed call site breaks the build (blocking).src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp:167 still calls the old two-argument overload:
ThreadSuspend::RestartEE (FALSE/* bFinishedGC */, TRUE/* SuspendSucceeded */);
This file is not part of the PR, so with the signature now RestartEE(BOOL SuspendSucceeded) this call will fail to compile (SuspendEE is called just above, so the intended argument is TRUE). It should be updated to ThreadSuspend::RestartEE (TRUE /* SuspendSucceeded */);. A repo-wide search for remaining multi-argument RestartEE(...) calls confirms this is the only missed site.
2. Stale doc comment. See the inline comment on src/coreclr/gc/gcinterface.ee.h — the comment still describes the removed boolean.
No other correctness, threading, or interface concerns were found; the argument substitutions at the updated call sites (mapping the old SuspendSucceeded/second argument through) all look correct.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 70.3 AIC · ⌖ 14.8 AIC · ⊞ 10K
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated


This was referenced Jul 23, 2026

Open


Open

kkokosa
kkokosa
reviewed
Jul 31, 2026
View reviewed changes
@kkokosakkokosa
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to finalize this PR.
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/gc.cpp
Outdated

Comment threadsrc/coreclr/gc/gcenv.ee.standalone.inl
Outdated

@kant2002
kant2002
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@kkokosa errors from the other issues, unrelated.
janvorli
janvorli
reviewed
Aug 5, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

@kant2002
kant2002force-pushed
the
kant/remove-unused-parameter
branch
from
5899efc to
a0a2cafCompareAugust 5, 2026 19:48
janvorli
janvorli
approved these changes
Aug 5, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
merged commit 69bbf82
into
dotnet:mainAug 6, 2026

111 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 7, 2026
jtschuster pushed a commit
to jtschuster/runtime
that referenced
this pull request
Aug 11, 2026
@kant2002@jtschuster
Remove unused parameter in RestartGC (dotnet#130557)
7d0190e
I did touch public part which is used for standalone GC, and that would
be a breaking change.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkotasjkotasjkotas left review comments
@kkokosakkokosakkokosa left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@janvorlijanvorlijanvorli approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees


No one assigned


Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@jkotas@janvorli@kkokosa

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove unused parameter in RestartGC - #130557
Merged
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Aug 6, 2026
Merged
Remove unused parameter in RestartGC#130557
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Conversation
@kant2002
@kant2002kant2002
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
I did touch public part which is used for standalone GC, and that would be a breaking change.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jul 11, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @anicka-net, @dotnet/gc

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
reviewed
Jul 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated

@github-actions
github-actionsBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Workflow state for the Holistic Review Orchestrator.
{
"version": 5,
"last_dispatched_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29681934604",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"review_id": 4730544514
}
]
}
github-actions[bot]
github-actionsBot
reviewed
Jul 19, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review
Motivation: RestartEE (both the GC↔EE interface method GCToEEInterface::RestartEE and the VM helper ThreadSuspend::RestartEE) carried a bFinishedGC boolean parameter that is no longer read anywhere in the implementation. Removing dead parameters is a reasonable cleanup that simplifies the many call sites and the standalone-GC interface contract.
Approach: The PR drops bFinishedGC from ThreadSuspend::RestartEE(BOOL SuspendSucceeded) and from GCToEEInterface::RestartEE(), updating the pure-virtual declaration in gcinterface.ee.h, the standalone shims (gctoeeinterface.standalone.inl, gcenv.ee.standalone.inl), the sample/NativeAOT implementations, and all call sites across src/coreclr/gc and src/coreclr/vm. I verified bFinishedGC is indeed unused in the ThreadSuspend::RestartEE body. Since this changes the public standalone-GC IGCToCLR v-table signature, it is an intentional breaking change to that interface, as the author notes.
Summary: The refactor is mechanically correct for the files it touches, but it is incomplete: one call site was missed and will break the CoreCLR build, and one doc comment is now stale. These must be fixed before merge.
Detailed Findings
1. Missed call site breaks the build (blocking).src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp:167 still calls the old two-argument overload:
ThreadSuspend::RestartEE (FALSE/* bFinishedGC */, TRUE/* SuspendSucceeded */);
This file is not part of the PR, so with the signature now RestartEE(BOOL SuspendSucceeded) this call will fail to compile (SuspendEE is called just above, so the intended argument is TRUE). It should be updated to ThreadSuspend::RestartEE (TRUE /* SuspendSucceeded */);. A repo-wide search for remaining multi-argument RestartEE(...) calls confirms this is the only missed site.
2. Stale doc comment. See the inline comment on src/coreclr/gc/gcinterface.ee.h — the comment still describes the removed boolean.
No other correctness, threading, or interface concerns were found; the argument substitutions at the updated call sites (mapping the old SuspendSucceeded/second argument through) all look correct.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 70.3 AIC · ⌖ 14.8 AIC · ⊞ 10K
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated


This was referenced Jul 23, 2026

Open


Open

kkokosa
kkokosa
reviewed
Jul 31, 2026
View reviewed changes
@kkokosakkokosa
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to finalize this PR.
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/gc.cpp
Outdated

Comment threadsrc/coreclr/gc/gcenv.ee.standalone.inl
Outdated

@kant2002
kant2002
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@kkokosa errors from the other issues, unrelated.
janvorli
janvorli
reviewed
Aug 5, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

@kant2002
kant2002force-pushed
the
kant/remove-unused-parameter
branch
from
5899efc to
a0a2cafCompareAugust 5, 2026 19:48
janvorli
janvorli
approved these changes
Aug 5, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
merged commit 69bbf82
into
dotnet:mainAug 6, 2026

111 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 7, 2026
jtschuster pushed a commit
to jtschuster/runtime
that referenced
this pull request
Aug 11, 2026
@kant2002@jtschuster
Remove unused parameter in RestartGC (dotnet#130557)
7d0190e
I did touch public part which is used for standalone GC, and that would
be a breaking change.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkotasjkotasjkotas left review comments
@kkokosakkokosakkokosa left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@janvorlijanvorlijanvorli approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees


No one assigned


Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@jkotas@janvorli@kkokosa

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Remove unused parameter in RestartGC - #130557
Merged
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Aug 6, 2026
Merged
Remove unused parameter in RestartGC#130557
janvorli merged 9 commits into
dotnet:mainfrom 
kant2002:kant/remove-unused-parameter
Conversation
@kant2002
@kant2002kant2002
commented
Jul 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
I did touch public part which is used for standalone GC, and that would be a breaking change.
@dotnet-policy-servicedotnet-policy-serviceBot
added
the 
community-contribution
Indicates that the PR has been added by a community member
label
Jul 11, 2026
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2026

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @anicka-net, @dotnet/gc

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
reviewed
Jul 12, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated

@github-actions
github-actionsBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Workflow state for the Holistic Review Orchestrator.
{
"version": 5,
"last_dispatched_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29681934604",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "acd2f80989f1724937d2cde2ca0d582fa686874a",
"review_id": 4730544514
}
]
}
github-actions[bot]
github-actionsBot
reviewed
Jul 19, 2026
View reviewed changes
@github-actionsgithub-actionsBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review
Motivation: RestartEE (both the GC↔EE interface method GCToEEInterface::RestartEE and the VM helper ThreadSuspend::RestartEE) carried a bFinishedGC boolean parameter that is no longer read anywhere in the implementation. Removing dead parameters is a reasonable cleanup that simplifies the many call sites and the standalone-GC interface contract.
Approach: The PR drops bFinishedGC from ThreadSuspend::RestartEE(BOOL SuspendSucceeded) and from GCToEEInterface::RestartEE(), updating the pure-virtual declaration in gcinterface.ee.h, the standalone shims (gctoeeinterface.standalone.inl, gcenv.ee.standalone.inl), the sample/NativeAOT implementations, and all call sites across src/coreclr/gc and src/coreclr/vm. I verified bFinishedGC is indeed unused in the ThreadSuspend::RestartEE body. Since this changes the public standalone-GC IGCToCLR v-table signature, it is an intentional breaking change to that interface, as the author notes.
Summary: The refactor is mechanically correct for the files it touches, but it is incomplete: one call site was missed and will break the CoreCLR build, and one doc comment is now stale. These must be fixed before merge.
Detailed Findings
1. Missed call site breaks the build (blocking).src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.cpp:167 still calls the old two-argument overload:
ThreadSuspend::RestartEE (FALSE/* bFinishedGC */, TRUE/* SuspendSucceeded */);
This file is not part of the PR, so with the signature now RestartEE(BOOL SuspendSucceeded) this call will fail to compile (SuspendEE is called just above, so the intended argument is TRUE). It should be updated to ThreadSuspend::RestartEE (TRUE /* SuspendSucceeded */);. A repo-wide search for remaining multi-argument RestartEE(...) calls confirms this is the only missed site.
2. Stale doc comment. See the inline comment on src/coreclr/gc/gcinterface.ee.h — the comment still describes the removed boolean.
No other correctness, threading, or interface concerns were found; the argument substitutions at the updated call sites (mapping the old SuspendSucceeded/second argument through) all look correct.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 70.3 AIC · ⌖ 14.8 AIC · ⊞ 10K
Comment threadsrc/coreclr/gc/gcinterface.ee.h
Outdated


This was referenced Jul 23, 2026

Open


Open

kkokosa
kkokosa
reviewed
Jul 31, 2026
View reviewed changes
@kkokosakkokosa
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to finalize this PR.
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/gc.cpp
Outdated

Comment threadsrc/coreclr/gc/gcenv.ee.standalone.inl
Outdated

@kant2002
kant2002
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@kkokosa errors from the other issues, unrelated.
janvorli
janvorli
reviewed
Aug 5, 2026
View reviewed changes
Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

Comment threadsrc/coreclr/gc/env/gctoeeinterface.standalone.inl
Outdated

@kant2002
kant2002force-pushed
the
kant/remove-unused-parameter
branch
from
5899efc to
a0a2cafCompareAugust 5, 2026 19:48
janvorli
janvorli
approved these changes
Aug 5, 2026
View reviewed changes
@janvorlijanvorli
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
@janvorli
janvorli
merged commit 69bbf82
into
dotnet:mainAug 6, 2026

111 checks passed

@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 7, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 7, 2026
jtschuster pushed a commit
to jtschuster/runtime
that referenced
this pull request
Aug 11, 2026
@kant2002@jtschuster
Remove unused parameter in RestartGC (dotnet#130557)
7d0190e
I did touch public part which is used for standalone GC, and that would
be a breaking change.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jkotasjkotasjkotas left review comments
@kkokosakkokosakkokosa left review comments
@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@janvorlijanvorlijanvorli approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees


No one assigned


Labels

area-GC-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@jkotas@janvorli@kkokosa