Uh oh!
There was an error while loading. Please reload this page.
Wire up orphaned Runtime_129288 regression test - #130836
Merged
tannergooding merged 1 commit intoJul 18, 2026
Merged
Conversation
Runtime_129288.cs was added in dotnet#129348 as a merged-style xunit test but never referenced by any Regression_*.csproj, so CI never built or ran it. Add it to Regression_ro_2.csproj alongside its numeric neighbors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the JIT Regression “merged” test project to include a previously unlisted test source file, ensuring the test is compiled into the assembly and executed by the merged test runner.
Changes:
- Add
JitBlue\Runtime_129288\Runtime_129288.cstoRegression_ro_2.csproj’s explicit<Compile Include=...>list (numeric-positioned among nearby tests).
Show a summary per file
| File | Description |
|---|---|
src/tests/JIT/Regression/Regression_ro_2.csproj | Adds an explicit <Compile Include> entry so Runtime_129288 is built and run as part of the merged regression bucket. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
tannergooding
commented
Jul 16, 2026
MemberAuthor
CC. @AndyAyersMS this regression test was added but never actually hooked up. |
AndyAyersMS
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime_129288.cswas added in #129348 (JIT: don't claim rotates set ZF on xarch) as a merged-style xunit test ([Fact] public static int TestEntryPoint()), but it was never referenced by anyRegression_*.csproj. Since the SDK-style CLR test projects setEnableDefaultItems=false, an unreferenced.csis silently never built or run -- so CI has never exercised this test. This is the same class of bug fixed in #130832.Add it to
Regression_ro_2.csproj(anOptimize=Truebucket, correct for this lowering/codegen correctness test), inserted in numeric order alongside its neighbors.I also audited every other
.csundersrc/tests/JIT/Regression/for the same issue. The only genuine orphan wasRuntime_129288. Six other unreferenced.csfiles are intentionally uncompiled reference sources paired with a hand-written/generated.il+.ilproj(Runtime_70259,Runtime_70607,Runtime_73615,Runtime_80731,Runtime_40607,DevDiv_754566) and were left as-is.Note
This PR description and the change were generated with the assistance of GitHub Copilot.