Add DependencyAnalysisFramework tests from CoreRT repo

[MichalStrehovsky]

We forgot these in the CoreRT repo. DependencyAnalysisFramework originally moved here with crossgen2, but without the testing. First commit just copies file over, second commit hooks them up to the build.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Adds the missing ILCompiler.DependencyAnalysisFramework unit test project to the runtime repo and wires it into the CoreCLR tools test subset so it participates in CI/tool test runs.

Changes:

• Adds TestGraph test infrastructure for exercising static, conditional, and dynamic dependency marking.
• Adds xUnit tests validating dependency marking behavior across logging strategies and validating DGML output shape.
• Hooks the new test project into the +clr.toolstests+ subset build/test list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/TestGraph.cs	Adds a small test graph/node model used by the unit tests to drive the dependency analyzer.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/DependencyAnalysisFrameworkTests.cs	Adds xUnit tests for dependency marking and DGML output across different log strategies.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/ILCompiler.DependencyAnalysisFramework.Tests.csproj	Introduces the new test project and references the DependencyAnalysisFramework project + xUnit extensions.
eng/Subsets.props	Ensures the new test project runs as part of the clr.toolstests subset.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_reviewed_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_recorded_worker_run_id": "29684897252",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"review_id": 4730668815
}
]
}

[github-actions]

Holistic Review

Motivation: The ILCompiler.DependencyAnalysisFramework component was moved into dotnet/runtime alongside crossgen2, but its unit tests were left behind in the old CoreRT repository. This PR restores that lost test coverage for the dependency-analysis graph marking logic (full/first-mark/no-log strategies, static/conditional/dynamic rules, and DGML output).

Approach: The change copies the original TestGraph.cs helper and DependencyAnalysisFrameworkTests.cs xUnit tests verbatim, adds a new ILCompiler.DependencyAnalysisFramework.Tests.csproj that references the framework project and Microsoft.DotNet.XUnitExtensions, and wires the project into the clr.toolstests subset in eng/Subsets.props (guarded by Condition="'$(DotNetBuildSourceOnly)' != 'true'", consistent with the neighboring AOT test projects). The split into a copy commit followed by a build-hookup commit keeps the port easy to audit.

Summary: This is a low-risk, test-only addition that recovers previously-existing coverage. The csproj mirrors the conventions of sibling AOT test projects (TargetFramework=$(NetCoreAppToolCurrent), Configurations, TestRunnerAdditionalArguments, NU1701 suppression). The ported code uses older C# idioms (explicit Tuple<>, new T[0], out-var-free TryGetValue) rather than the repository's current conventions, but that is expected and appropriate for a faithful port and not worth churning. No functional runtime code is affected. LGTM.

Detailed Findings

No actionable issues found. Two non-blocking observations, neither warranting a change:

• TestGraph.cs and the test bodies retain legacy style (e.g. s_emptyDynamicList = new CombinedDependencyListEntry[0], explicit Tuple<> allocations, Assert.True(results.Count == N) instead of Assert.Equal(N, results.Count)). Preserving the original source verbatim is reasonable for a port; modernizing is optional.
• Unlike some sibling AOT test csproj files, this project omits EnableDefaultItems=false/CopyLocalLockFileAssemblies, which is correct here since it has no test-asset subprojects or generated content to exclude.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 52.6 AIC · ⌖ 10.2 AIC · ⊞ 10K

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 6
• Review effort level: Lite

[MichalStrehovsky]

We forgot these in the CoreRT repo. DependencyAnalysisFramework originally moved here with crossgen2, but without the testing. First commit just copies file over, second commit hooks them up to the build.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Adds the missing ILCompiler.DependencyAnalysisFramework unit test project to the runtime repo and wires it into the CoreCLR tools test subset so it participates in CI/tool test runs.

Changes:

• Adds TestGraph test infrastructure for exercising static, conditional, and dynamic dependency marking.
• Adds xUnit tests validating dependency marking behavior across logging strategies and validating DGML output shape.
• Hooks the new test project into the +clr.toolstests+ subset build/test list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/TestGraph.cs	Adds a small test graph/node model used by the unit tests to drive the dependency analyzer.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/DependencyAnalysisFrameworkTests.cs	Adds xUnit tests for dependency marking and DGML output across different log strategies.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/ILCompiler.DependencyAnalysisFramework.Tests.csproj	Introduces the new test project and references the DependencyAnalysisFramework project + xUnit extensions.
eng/Subsets.props	Ensures the new test project runs as part of the clr.toolstests subset.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_reviewed_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_recorded_worker_run_id": "29684897252",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"review_id": 4730668815
}
]
}

[github-actions]

Holistic Review

Motivation: The ILCompiler.DependencyAnalysisFramework component was moved into dotnet/runtime alongside crossgen2, but its unit tests were left behind in the old CoreRT repository. This PR restores that lost test coverage for the dependency-analysis graph marking logic (full/first-mark/no-log strategies, static/conditional/dynamic rules, and DGML output).

Approach: The change copies the original TestGraph.cs helper and DependencyAnalysisFrameworkTests.cs xUnit tests verbatim, adds a new ILCompiler.DependencyAnalysisFramework.Tests.csproj that references the framework project and Microsoft.DotNet.XUnitExtensions, and wires the project into the clr.toolstests subset in eng/Subsets.props (guarded by Condition="'$(DotNetBuildSourceOnly)' != 'true'", consistent with the neighboring AOT test projects). The split into a copy commit followed by a build-hookup commit keeps the port easy to audit.

Summary: This is a low-risk, test-only addition that recovers previously-existing coverage. The csproj mirrors the conventions of sibling AOT test projects (TargetFramework=$(NetCoreAppToolCurrent), Configurations, TestRunnerAdditionalArguments, NU1701 suppression). The ported code uses older C# idioms (explicit Tuple<>, new T[0], out-var-free TryGetValue) rather than the repository's current conventions, but that is expected and appropriate for a faithful port and not worth churning. No functional runtime code is affected. LGTM.

Detailed Findings

No actionable issues found. Two non-blocking observations, neither warranting a change:

• TestGraph.cs and the test bodies retain legacy style (e.g. s_emptyDynamicList = new CombinedDependencyListEntry[0], explicit Tuple<> allocations, Assert.True(results.Count == N) instead of Assert.Equal(N, results.Count)). Preserving the original source verbatim is reasonable for a port; modernizing is optional.
• Unlike some sibling AOT test csproj files, this project omits EnableDefaultItems=false/CopyLocalLockFileAssemblies, which is correct here since it has no test-asset subprojects or generated content to exclude.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 52.6 AIC · ⌖ 10.2 AIC · ⊞ 10K

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 6
• Review effort level: Lite

[MichalStrehovsky]

We forgot these in the CoreRT repo. DependencyAnalysisFramework originally moved here with crossgen2, but without the testing. First commit just copies file over, second commit hooks them up to the build.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Adds the missing ILCompiler.DependencyAnalysisFramework unit test project to the runtime repo and wires it into the CoreCLR tools test subset so it participates in CI/tool test runs.

Changes:

• Adds TestGraph test infrastructure for exercising static, conditional, and dynamic dependency marking.
• Adds xUnit tests validating dependency marking behavior across logging strategies and validating DGML output shape.
• Hooks the new test project into the +clr.toolstests+ subset build/test list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/TestGraph.cs	Adds a small test graph/node model used by the unit tests to drive the dependency analyzer.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/DependencyAnalysisFrameworkTests.cs	Adds xUnit tests for dependency marking and DGML output across different log strategies.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/ILCompiler.DependencyAnalysisFramework.Tests.csproj	Introduces the new test project and references the DependencyAnalysisFramework project + xUnit extensions.
eng/Subsets.props	Ensures the new test project runs as part of the clr.toolstests subset.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_reviewed_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_recorded_worker_run_id": "29684897252",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"review_id": 4730668815
}
]
}

[github-actions]

Holistic Review

Motivation: The ILCompiler.DependencyAnalysisFramework component was moved into dotnet/runtime alongside crossgen2, but its unit tests were left behind in the old CoreRT repository. This PR restores that lost test coverage for the dependency-analysis graph marking logic (full/first-mark/no-log strategies, static/conditional/dynamic rules, and DGML output).

Approach: The change copies the original TestGraph.cs helper and DependencyAnalysisFrameworkTests.cs xUnit tests verbatim, adds a new ILCompiler.DependencyAnalysisFramework.Tests.csproj that references the framework project and Microsoft.DotNet.XUnitExtensions, and wires the project into the clr.toolstests subset in eng/Subsets.props (guarded by Condition="'$(DotNetBuildSourceOnly)' != 'true'", consistent with the neighboring AOT test projects). The split into a copy commit followed by a build-hookup commit keeps the port easy to audit.

Summary: This is a low-risk, test-only addition that recovers previously-existing coverage. The csproj mirrors the conventions of sibling AOT test projects (TargetFramework=$(NetCoreAppToolCurrent), Configurations, TestRunnerAdditionalArguments, NU1701 suppression). The ported code uses older C# idioms (explicit Tuple<>, new T[0], out-var-free TryGetValue) rather than the repository's current conventions, but that is expected and appropriate for a faithful port and not worth churning. No functional runtime code is affected. LGTM.

Detailed Findings

No actionable issues found. Two non-blocking observations, neither warranting a change:

• TestGraph.cs and the test bodies retain legacy style (e.g. s_emptyDynamicList = new CombinedDependencyListEntry[0], explicit Tuple<> allocations, Assert.True(results.Count == N) instead of Assert.Equal(N, results.Count)). Preserving the original source verbatim is reasonable for a port; modernizing is optional.
• Unlike some sibling AOT test csproj files, this project omits EnableDefaultItems=false/CopyLocalLockFileAssemblies, which is correct here since it has no test-asset subprojects or generated content to exclude.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 52.6 AIC · ⌖ 10.2 AIC · ⊞ 10K

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 6
• Review effort level: Lite

[MichalStrehovsky]

We forgot these in the CoreRT repo. DependencyAnalysisFramework originally moved here with crossgen2, but without the testing. First commit just copies file over, second commit hooks them up to the build.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Adds the missing ILCompiler.DependencyAnalysisFramework unit test project to the runtime repo and wires it into the CoreCLR tools test subset so it participates in CI/tool test runs.

Changes:

• Adds TestGraph test infrastructure for exercising static, conditional, and dynamic dependency marking.
• Adds xUnit tests validating dependency marking behavior across logging strategies and validating DGML output shape.
• Hooks the new test project into the +clr.toolstests+ subset build/test list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/TestGraph.cs	Adds a small test graph/node model used by the unit tests to drive the dependency analyzer.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/DependencyAnalysisFrameworkTests.cs	Adds xUnit tests for dependency marking and DGML output across different log strategies.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/ILCompiler.DependencyAnalysisFramework.Tests.csproj	Introduces the new test project and references the DependencyAnalysisFramework project + xUnit extensions.
eng/Subsets.props	Ensures the new test project runs as part of the clr.toolstests subset.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_reviewed_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_recorded_worker_run_id": "29684897252",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"review_id": 4730668815
}
]
}

[github-actions]

Holistic Review

Motivation: The ILCompiler.DependencyAnalysisFramework component was moved into dotnet/runtime alongside crossgen2, but its unit tests were left behind in the old CoreRT repository. This PR restores that lost test coverage for the dependency-analysis graph marking logic (full/first-mark/no-log strategies, static/conditional/dynamic rules, and DGML output).

Approach: The change copies the original TestGraph.cs helper and DependencyAnalysisFrameworkTests.cs xUnit tests verbatim, adds a new ILCompiler.DependencyAnalysisFramework.Tests.csproj that references the framework project and Microsoft.DotNet.XUnitExtensions, and wires the project into the clr.toolstests subset in eng/Subsets.props (guarded by Condition="'$(DotNetBuildSourceOnly)' != 'true'", consistent with the neighboring AOT test projects). The split into a copy commit followed by a build-hookup commit keeps the port easy to audit.

Summary: This is a low-risk, test-only addition that recovers previously-existing coverage. The csproj mirrors the conventions of sibling AOT test projects (TargetFramework=$(NetCoreAppToolCurrent), Configurations, TestRunnerAdditionalArguments, NU1701 suppression). The ported code uses older C# idioms (explicit Tuple<>, new T[0], out-var-free TryGetValue) rather than the repository's current conventions, but that is expected and appropriate for a faithful port and not worth churning. No functional runtime code is affected. LGTM.

Detailed Findings

No actionable issues found. Two non-blocking observations, neither warranting a change:

• TestGraph.cs and the test bodies retain legacy style (e.g. s_emptyDynamicList = new CombinedDependencyListEntry[0], explicit Tuple<> allocations, Assert.True(results.Count == N) instead of Assert.Equal(N, results.Count)). Preserving the original source verbatim is reasonable for a port; modernizing is optional.
• Unlike some sibling AOT test csproj files, this project omits EnableDefaultItems=false/CopyLocalLockFileAssemblies, which is correct here since it has no test-asset subprojects or generated content to exclude.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 52.6 AIC · ⌖ 10.2 AIC · ⊞ 10K

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 6
• Review effort level: Lite

[MichalStrehovsky]

We forgot these in the CoreRT repo. DependencyAnalysisFramework originally moved here with crossgen2, but without the testing. First commit just copies file over, second commit hooks them up to the build.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Adds the missing ILCompiler.DependencyAnalysisFramework unit test project to the runtime repo and wires it into the CoreCLR tools test subset so it participates in CI/tool test runs.

Changes:

• Adds TestGraph test infrastructure for exercising static, conditional, and dynamic dependency marking.
• Adds xUnit tests validating dependency marking behavior across logging strategies and validating DGML output shape.
• Hooks the new test project into the +clr.toolstests+ subset build/test list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/TestGraph.cs	Adds a small test graph/node model used by the unit tests to drive the dependency analyzer.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/DependencyAnalysisFrameworkTests.cs	Adds xUnit tests for dependency marking and DGML output across different log strategies.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/ILCompiler.DependencyAnalysisFramework.Tests.csproj	Introduces the new test project and references the DependencyAnalysisFramework project + xUnit extensions.
eng/Subsets.props	Ensures the new test project runs as part of the clr.toolstests subset.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_reviewed_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_recorded_worker_run_id": "29684897252",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"review_id": 4730668815
}
]
}

[github-actions]

Holistic Review

Motivation: The ILCompiler.DependencyAnalysisFramework component was moved into dotnet/runtime alongside crossgen2, but its unit tests were left behind in the old CoreRT repository. This PR restores that lost test coverage for the dependency-analysis graph marking logic (full/first-mark/no-log strategies, static/conditional/dynamic rules, and DGML output).

Approach: The change copies the original TestGraph.cs helper and DependencyAnalysisFrameworkTests.cs xUnit tests verbatim, adds a new ILCompiler.DependencyAnalysisFramework.Tests.csproj that references the framework project and Microsoft.DotNet.XUnitExtensions, and wires the project into the clr.toolstests subset in eng/Subsets.props (guarded by Condition="'$(DotNetBuildSourceOnly)' != 'true'", consistent with the neighboring AOT test projects). The split into a copy commit followed by a build-hookup commit keeps the port easy to audit.

Summary: This is a low-risk, test-only addition that recovers previously-existing coverage. The csproj mirrors the conventions of sibling AOT test projects (TargetFramework=$(NetCoreAppToolCurrent), Configurations, TestRunnerAdditionalArguments, NU1701 suppression). The ported code uses older C# idioms (explicit Tuple<>, new T[0], out-var-free TryGetValue) rather than the repository's current conventions, but that is expected and appropriate for a faithful port and not worth churning. No functional runtime code is affected. LGTM.

Detailed Findings

No actionable issues found. Two non-blocking observations, neither warranting a change:

• TestGraph.cs and the test bodies retain legacy style (e.g. s_emptyDynamicList = new CombinedDependencyListEntry[0], explicit Tuple<> allocations, Assert.True(results.Count == N) instead of Assert.Equal(N, results.Count)). Preserving the original source verbatim is reasonable for a port; modernizing is optional.
• Unlike some sibling AOT test csproj files, this project omits EnableDefaultItems=false/CopyLocalLockFileAssemblies, which is correct here since it has no test-asset subprojects or generated content to exclude.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 52.6 AIC · ⌖ 10.2 AIC · ⊞ 10K

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 6
• Review effort level: Lite

[MichalStrehovsky]

We forgot these in the CoreRT repo. DependencyAnalysisFramework originally moved here with crossgen2, but without the testing. First commit just copies file over, second commit hooks them up to the build.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Adds the missing ILCompiler.DependencyAnalysisFramework unit test project to the runtime repo and wires it into the CoreCLR tools test subset so it participates in CI/tool test runs.

Changes:

• Adds TestGraph test infrastructure for exercising static, conditional, and dynamic dependency marking.
• Adds xUnit tests validating dependency marking behavior across logging strategies and validating DGML output shape.
• Hooks the new test project into the +clr.toolstests+ subset build/test list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/TestGraph.cs	Adds a small test graph/node model used by the unit tests to drive the dependency analyzer.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/DependencyAnalysisFrameworkTests.cs	Adds xUnit tests for dependency marking and DGML output across different log strategies.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/ILCompiler.DependencyAnalysisFramework.Tests.csproj	Introduces the new test project and references the DependencyAnalysisFramework project + xUnit extensions.
eng/Subsets.props	Ensures the new test project runs as part of the clr.toolstests subset.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_reviewed_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_recorded_worker_run_id": "29684897252",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"review_id": 4730668815
}
]
}

[github-actions]

Holistic Review

Motivation: The ILCompiler.DependencyAnalysisFramework component was moved into dotnet/runtime alongside crossgen2, but its unit tests were left behind in the old CoreRT repository. This PR restores that lost test coverage for the dependency-analysis graph marking logic (full/first-mark/no-log strategies, static/conditional/dynamic rules, and DGML output).

Approach: The change copies the original TestGraph.cs helper and DependencyAnalysisFrameworkTests.cs xUnit tests verbatim, adds a new ILCompiler.DependencyAnalysisFramework.Tests.csproj that references the framework project and Microsoft.DotNet.XUnitExtensions, and wires the project into the clr.toolstests subset in eng/Subsets.props (guarded by Condition="'$(DotNetBuildSourceOnly)' != 'true'", consistent with the neighboring AOT test projects). The split into a copy commit followed by a build-hookup commit keeps the port easy to audit.

Summary: This is a low-risk, test-only addition that recovers previously-existing coverage. The csproj mirrors the conventions of sibling AOT test projects (TargetFramework=$(NetCoreAppToolCurrent), Configurations, TestRunnerAdditionalArguments, NU1701 suppression). The ported code uses older C# idioms (explicit Tuple<>, new T[0], out-var-free TryGetValue) rather than the repository's current conventions, but that is expected and appropriate for a faithful port and not worth churning. No functional runtime code is affected. LGTM.

Detailed Findings

No actionable issues found. Two non-blocking observations, neither warranting a change:

• TestGraph.cs and the test bodies retain legacy style (e.g. s_emptyDynamicList = new CombinedDependencyListEntry[0], explicit Tuple<> allocations, Assert.True(results.Count == N) instead of Assert.Equal(N, results.Count)). Preserving the original source verbatim is reasonable for a port; modernizing is optional.
• Unlike some sibling AOT test csproj files, this project omits EnableDefaultItems=false/CopyLocalLockFileAssemblies, which is correct here since it has no test-asset subprojects or generated content to exclude.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 52.6 AIC · ⌖ 10.2 AIC · ⊞ 10K

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 6
• Review effort level: Lite

[MichalStrehovsky]

We forgot these in the CoreRT repo. DependencyAnalysisFramework originally moved here with crossgen2, but without the testing. First commit just copies file over, second commit hooks them up to the build.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Adds the missing ILCompiler.DependencyAnalysisFramework unit test project to the runtime repo and wires it into the CoreCLR tools test subset so it participates in CI/tool test runs.

Changes:

• Adds TestGraph test infrastructure for exercising static, conditional, and dynamic dependency marking.
• Adds xUnit tests validating dependency marking behavior across logging strategies and validating DGML output shape.
• Hooks the new test project into the +clr.toolstests+ subset build/test list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/TestGraph.cs	Adds a small test graph/node model used by the unit tests to drive the dependency analyzer.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/DependencyAnalysisFrameworkTests.cs	Adds xUnit tests for dependency marking and DGML output across different log strategies.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/ILCompiler.DependencyAnalysisFramework.Tests.csproj	Introduces the new test project and references the DependencyAnalysisFramework project + xUnit extensions.
eng/Subsets.props	Ensures the new test project runs as part of the clr.toolstests subset.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_reviewed_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_recorded_worker_run_id": "29684897252",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"review_id": 4730668815
}
]
}

[github-actions]

Holistic Review

Motivation: The ILCompiler.DependencyAnalysisFramework component was moved into dotnet/runtime alongside crossgen2, but its unit tests were left behind in the old CoreRT repository. This PR restores that lost test coverage for the dependency-analysis graph marking logic (full/first-mark/no-log strategies, static/conditional/dynamic rules, and DGML output).

Approach: The change copies the original TestGraph.cs helper and DependencyAnalysisFrameworkTests.cs xUnit tests verbatim, adds a new ILCompiler.DependencyAnalysisFramework.Tests.csproj that references the framework project and Microsoft.DotNet.XUnitExtensions, and wires the project into the clr.toolstests subset in eng/Subsets.props (guarded by Condition="'$(DotNetBuildSourceOnly)' != 'true'", consistent with the neighboring AOT test projects). The split into a copy commit followed by a build-hookup commit keeps the port easy to audit.

Summary: This is a low-risk, test-only addition that recovers previously-existing coverage. The csproj mirrors the conventions of sibling AOT test projects (TargetFramework=$(NetCoreAppToolCurrent), Configurations, TestRunnerAdditionalArguments, NU1701 suppression). The ported code uses older C# idioms (explicit Tuple<>, new T[0], out-var-free TryGetValue) rather than the repository's current conventions, but that is expected and appropriate for a faithful port and not worth churning. No functional runtime code is affected. LGTM.

Detailed Findings

No actionable issues found. Two non-blocking observations, neither warranting a change:

• TestGraph.cs and the test bodies retain legacy style (e.g. s_emptyDynamicList = new CombinedDependencyListEntry[0], explicit Tuple<> allocations, Assert.True(results.Count == N) instead of Assert.Equal(N, results.Count)). Preserving the original source verbatim is reasonable for a port; modernizing is optional.
• Unlike some sibling AOT test csproj files, this project omits EnableDefaultItems=false/CopyLocalLockFileAssemblies, which is correct here since it has no test-asset subprojects or generated content to exclude.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 52.6 AIC · ⌖ 10.2 AIC · ⊞ 10K

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 6
• Review effort level: Lite

[MichalStrehovsky]

We forgot these in the CoreRT repo. DependencyAnalysisFramework originally moved here with crossgen2, but without the testing. First commit just copies file over, second commit hooks them up to the build.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Adds the missing ILCompiler.DependencyAnalysisFramework unit test project to the runtime repo and wires it into the CoreCLR tools test subset so it participates in CI/tool test runs.

Changes:

• Adds TestGraph test infrastructure for exercising static, conditional, and dynamic dependency marking.
• Adds xUnit tests validating dependency marking behavior across logging strategies and validating DGML output shape.
• Hooks the new test project into the +clr.toolstests+ subset build/test list.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/TestGraph.cs	Adds a small test graph/node model used by the unit tests to drive the dependency analyzer.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/DependencyAnalysisFrameworkTests.cs	Adds xUnit tests for dependency marking and DGML output across different log strategies.
src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework.Tests/ILCompiler.DependencyAnalysisFramework.Tests.csproj	Introduces the new test project and references the DependencyAnalysisFramework project + xUnit extensions.
eng/Subsets.props	Ensures the new test project runs as part of the clr.toolstests subset.

[github-actions]

Workflow state for the Holistic Review Orchestrator.

{
"version": 5,
"last_dispatched_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_reviewed_commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ac90ce8e7a5c217d4ab9effb35c82e5b6596371f",
"last_recorded_worker_run_id": "29684897252",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "c9a00a5d86a6f3fd87458fcf3b342dad6a34f4a6",
"review_id": 4730668815
}
]
}

[github-actions]

Holistic Review

Motivation: The ILCompiler.DependencyAnalysisFramework component was moved into dotnet/runtime alongside crossgen2, but its unit tests were left behind in the old CoreRT repository. This PR restores that lost test coverage for the dependency-analysis graph marking logic (full/first-mark/no-log strategies, static/conditional/dynamic rules, and DGML output).

Approach: The change copies the original TestGraph.cs helper and DependencyAnalysisFrameworkTests.cs xUnit tests verbatim, adds a new ILCompiler.DependencyAnalysisFramework.Tests.csproj that references the framework project and Microsoft.DotNet.XUnitExtensions, and wires the project into the clr.toolstests subset in eng/Subsets.props (guarded by Condition="'$(DotNetBuildSourceOnly)' != 'true'", consistent with the neighboring AOT test projects). The split into a copy commit followed by a build-hookup commit keeps the port easy to audit.

Summary: This is a low-risk, test-only addition that recovers previously-existing coverage. The csproj mirrors the conventions of sibling AOT test projects (TargetFramework=$(NetCoreAppToolCurrent), Configurations, TestRunnerAdditionalArguments, NU1701 suppression). The ported code uses older C# idioms (explicit Tuple<>, new T[0], out-var-free TryGetValue) rather than the repository's current conventions, but that is expected and appropriate for a faithful port and not worth churning. No functional runtime code is affected. LGTM.

Detailed Findings

No actionable issues found. Two non-blocking observations, neither warranting a change:

• TestGraph.cs and the test bodies retain legacy style (e.g. s_emptyDynamicList = new CombinedDependencyListEntry[0], explicit Tuple<> allocations, Assert.True(results.Count == N) instead of Assert.Equal(N, results.Count)). Preserving the original source verbatim is reasonable for a port; modernizing is optional.
• Unlike some sibling AOT test csproj files, this project omits EnableDefaultItems=false/CopyLocalLockFileAssemblies, which is correct here since it has no test-asset subprojects or generated content to exclude.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 52.6 AIC · ⌖ 10.2 AIC · ⊞ 10K

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 6
• Review effort level: Lite