Clarify WASM shuffle/swizzle codegen comments by tannergooding · Pull Request #130934 · dotnet/runtime

tannergooding · 2026-07-17T00:04:50Z

Post-merge follow-up to #130850, addressing three review comments from @adamperlin.

hwintrinsiccodegenwasm.cpp: reword the contained-mask Swizzle->i8x16.shuffle remark. On Wasm genConsumeMultiOpOperands only updates liveness and doesn't touch the value stack, so the comment now says "prior codegen left the source on the value stack once" rather than attributing it to genConsumeMultiOpOperands.

gentree.cpp (TARGET_WASM Shuffle-lowering branch): add a lead-in comment describing the element->byte-index expansion -- each element-granular selector expands into elementSize consecutive byte indices for i8x16.swizzle, and an out-of-range selector becomes 0xFF bytes so swizzle's native index >= 16 -> 0 behavior zero-fills that element. Dropped the now-redundant inline else-block comment.

The third comment (lowerwasm.cpp, feeding a constant-zero second operand to i8x16.shuffle instead of the source twice) is addressed in the thread rather than in code: a local.get of the existing source is smaller than materializing a 16-byte v128.const zero, and it can't remove the special case since the Swizzle node is 2-operand (source, mask->immediate) with no second-vector slot.

Comment-only; no functional change.

Note

This PR description was drafted by Copilot on behalf of @tannergooding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-17T00:05:35Z

Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T00:06:14Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates explanatory comments in the WASM SIMD shuffle/swizzle code paths in the JIT, clarifying how masks map to i8x16.shuffle / i8x16.swizzle and removing redundant commentary.

Changes:

Reword the Swizzle-contained-mask comment in genHWIntrinsic (WASM codegen) to avoid attributing behavior to a specific helper.
Add a lead-in comment in gtNewSimdShuffleNode (WASM lowering branch) describing element-to-byte-index expansion for i8x16.swizzle, and remove a now-redundant inline comment.

Show a summary per file

File	Description
src/coreclr/jit/hwintrinsiccodegenwasm.cpp	Comment clarification for WASM `Swizzle` lowering to `i8x16.shuffle`.
src/coreclr/jit/gentree.cpp	Adds/cleans up comments documenting WASM shuffle-to-swizzle mask expansion semantics.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

adamperlin · 2026-07-17T17:38:30Z

/ba-g infra failures

tannergooding · 2026-07-17T00:04:50Z

Post-merge follow-up to #130850, addressing three review comments from @adamperlin.

hwintrinsiccodegenwasm.cpp: reword the contained-mask Swizzle->i8x16.shuffle remark. On Wasm genConsumeMultiOpOperands only updates liveness and doesn't touch the value stack, so the comment now says "prior codegen left the source on the value stack once" rather than attributing it to genConsumeMultiOpOperands.

gentree.cpp (TARGET_WASM Shuffle-lowering branch): add a lead-in comment describing the element->byte-index expansion -- each element-granular selector expands into elementSize consecutive byte indices for i8x16.swizzle, and an out-of-range selector becomes 0xFF bytes so swizzle's native index >= 16 -> 0 behavior zero-fills that element. Dropped the now-redundant inline else-block comment.

The third comment (lowerwasm.cpp, feeding a constant-zero second operand to i8x16.shuffle instead of the source twice) is addressed in the thread rather than in code: a local.get of the existing source is smaller than materializing a 16-byte v128.const zero, and it can't remove the special case since the Swizzle node is 2-operand (source, mask->immediate) with no second-vector slot.

Comment-only; no functional change.

Note

This PR description was drafted by Copilot on behalf of @tannergooding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-17T00:05:35Z

Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T00:06:14Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates explanatory comments in the WASM SIMD shuffle/swizzle code paths in the JIT, clarifying how masks map to i8x16.shuffle / i8x16.swizzle and removing redundant commentary.

Changes:

Reword the Swizzle-contained-mask comment in genHWIntrinsic (WASM codegen) to avoid attributing behavior to a specific helper.
Add a lead-in comment in gtNewSimdShuffleNode (WASM lowering branch) describing element-to-byte-index expansion for i8x16.swizzle, and remove a now-redundant inline comment.

Show a summary per file

File	Description
src/coreclr/jit/hwintrinsiccodegenwasm.cpp	Comment clarification for WASM `Swizzle` lowering to `i8x16.shuffle`.
src/coreclr/jit/gentree.cpp	Adds/cleans up comments documenting WASM shuffle-to-swizzle mask expansion semantics.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

adamperlin · 2026-07-17T17:38:30Z

/ba-g infra failures

tannergooding · 2026-07-17T00:04:50Z

Post-merge follow-up to #130850, addressing three review comments from @adamperlin.

hwintrinsiccodegenwasm.cpp: reword the contained-mask Swizzle->i8x16.shuffle remark. On Wasm genConsumeMultiOpOperands only updates liveness and doesn't touch the value stack, so the comment now says "prior codegen left the source on the value stack once" rather than attributing it to genConsumeMultiOpOperands.

gentree.cpp (TARGET_WASM Shuffle-lowering branch): add a lead-in comment describing the element->byte-index expansion -- each element-granular selector expands into elementSize consecutive byte indices for i8x16.swizzle, and an out-of-range selector becomes 0xFF bytes so swizzle's native index >= 16 -> 0 behavior zero-fills that element. Dropped the now-redundant inline else-block comment.

The third comment (lowerwasm.cpp, feeding a constant-zero second operand to i8x16.shuffle instead of the source twice) is addressed in the thread rather than in code: a local.get of the existing source is smaller than materializing a 16-byte v128.const zero, and it can't remove the special case since the Swizzle node is 2-operand (source, mask->immediate) with no second-vector slot.

Comment-only; no functional change.

Note

This PR description was drafted by Copilot on behalf of @tannergooding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-17T00:05:35Z

Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T00:06:14Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates explanatory comments in the WASM SIMD shuffle/swizzle code paths in the JIT, clarifying how masks map to i8x16.shuffle / i8x16.swizzle and removing redundant commentary.

Changes:

Reword the Swizzle-contained-mask comment in genHWIntrinsic (WASM codegen) to avoid attributing behavior to a specific helper.
Add a lead-in comment in gtNewSimdShuffleNode (WASM lowering branch) describing element-to-byte-index expansion for i8x16.swizzle, and remove a now-redundant inline comment.

Show a summary per file

File	Description
src/coreclr/jit/hwintrinsiccodegenwasm.cpp	Comment clarification for WASM `Swizzle` lowering to `i8x16.shuffle`.
src/coreclr/jit/gentree.cpp	Adds/cleans up comments documenting WASM shuffle-to-swizzle mask expansion semantics.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

adamperlin · 2026-07-17T17:38:30Z

/ba-g infra failures

tannergooding · 2026-07-17T00:04:50Z

Post-merge follow-up to #130850, addressing three review comments from @adamperlin.

hwintrinsiccodegenwasm.cpp: reword the contained-mask Swizzle->i8x16.shuffle remark. On Wasm genConsumeMultiOpOperands only updates liveness and doesn't touch the value stack, so the comment now says "prior codegen left the source on the value stack once" rather than attributing it to genConsumeMultiOpOperands.

gentree.cpp (TARGET_WASM Shuffle-lowering branch): add a lead-in comment describing the element->byte-index expansion -- each element-granular selector expands into elementSize consecutive byte indices for i8x16.swizzle, and an out-of-range selector becomes 0xFF bytes so swizzle's native index >= 16 -> 0 behavior zero-fills that element. Dropped the now-redundant inline else-block comment.

The third comment (lowerwasm.cpp, feeding a constant-zero second operand to i8x16.shuffle instead of the source twice) is addressed in the thread rather than in code: a local.get of the existing source is smaller than materializing a 16-byte v128.const zero, and it can't remove the special case since the Swizzle node is 2-operand (source, mask->immediate) with no second-vector slot.

Comment-only; no functional change.

Note

This PR description was drafted by Copilot on behalf of @tannergooding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-17T00:05:35Z

Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T00:06:14Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates explanatory comments in the WASM SIMD shuffle/swizzle code paths in the JIT, clarifying how masks map to i8x16.shuffle / i8x16.swizzle and removing redundant commentary.

Changes:

Reword the Swizzle-contained-mask comment in genHWIntrinsic (WASM codegen) to avoid attributing behavior to a specific helper.
Add a lead-in comment in gtNewSimdShuffleNode (WASM lowering branch) describing element-to-byte-index expansion for i8x16.swizzle, and remove a now-redundant inline comment.

Show a summary per file

File	Description
src/coreclr/jit/hwintrinsiccodegenwasm.cpp	Comment clarification for WASM `Swizzle` lowering to `i8x16.shuffle`.
src/coreclr/jit/gentree.cpp	Adds/cleans up comments documenting WASM shuffle-to-swizzle mask expansion semantics.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

adamperlin · 2026-07-17T17:38:30Z

/ba-g infra failures

tannergooding · 2026-07-17T00:04:50Z

Post-merge follow-up to #130850, addressing three review comments from @adamperlin.

hwintrinsiccodegenwasm.cpp: reword the contained-mask Swizzle->i8x16.shuffle remark. On Wasm genConsumeMultiOpOperands only updates liveness and doesn't touch the value stack, so the comment now says "prior codegen left the source on the value stack once" rather than attributing it to genConsumeMultiOpOperands.

gentree.cpp (TARGET_WASM Shuffle-lowering branch): add a lead-in comment describing the element->byte-index expansion -- each element-granular selector expands into elementSize consecutive byte indices for i8x16.swizzle, and an out-of-range selector becomes 0xFF bytes so swizzle's native index >= 16 -> 0 behavior zero-fills that element. Dropped the now-redundant inline else-block comment.

The third comment (lowerwasm.cpp, feeding a constant-zero second operand to i8x16.shuffle instead of the source twice) is addressed in the thread rather than in code: a local.get of the existing source is smaller than materializing a 16-byte v128.const zero, and it can't remove the special case since the Swizzle node is 2-operand (source, mask->immediate) with no second-vector slot.

Comment-only; no functional change.

Note

This PR description was drafted by Copilot on behalf of @tannergooding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-17T00:05:35Z

Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T00:06:14Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates explanatory comments in the WASM SIMD shuffle/swizzle code paths in the JIT, clarifying how masks map to i8x16.shuffle / i8x16.swizzle and removing redundant commentary.

Changes:

Reword the Swizzle-contained-mask comment in genHWIntrinsic (WASM codegen) to avoid attributing behavior to a specific helper.
Add a lead-in comment in gtNewSimdShuffleNode (WASM lowering branch) describing element-to-byte-index expansion for i8x16.swizzle, and remove a now-redundant inline comment.

Show a summary per file

File	Description
src/coreclr/jit/hwintrinsiccodegenwasm.cpp	Comment clarification for WASM `Swizzle` lowering to `i8x16.shuffle`.
src/coreclr/jit/gentree.cpp	Adds/cleans up comments documenting WASM shuffle-to-swizzle mask expansion semantics.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

adamperlin · 2026-07-17T17:38:30Z

/ba-g infra failures

tannergooding · 2026-07-17T00:04:50Z

Post-merge follow-up to #130850, addressing three review comments from @adamperlin.

hwintrinsiccodegenwasm.cpp: reword the contained-mask Swizzle->i8x16.shuffle remark. On Wasm genConsumeMultiOpOperands only updates liveness and doesn't touch the value stack, so the comment now says "prior codegen left the source on the value stack once" rather than attributing it to genConsumeMultiOpOperands.

gentree.cpp (TARGET_WASM Shuffle-lowering branch): add a lead-in comment describing the element->byte-index expansion -- each element-granular selector expands into elementSize consecutive byte indices for i8x16.swizzle, and an out-of-range selector becomes 0xFF bytes so swizzle's native index >= 16 -> 0 behavior zero-fills that element. Dropped the now-redundant inline else-block comment.

The third comment (lowerwasm.cpp, feeding a constant-zero second operand to i8x16.shuffle instead of the source twice) is addressed in the thread rather than in code: a local.get of the existing source is smaller than materializing a 16-byte v128.const zero, and it can't remove the special case since the Swizzle node is 2-operand (source, mask->immediate) with no second-vector slot.

Comment-only; no functional change.

Note

This PR description was drafted by Copilot on behalf of @tannergooding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-17T00:05:35Z

Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T00:06:14Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates explanatory comments in the WASM SIMD shuffle/swizzle code paths in the JIT, clarifying how masks map to i8x16.shuffle / i8x16.swizzle and removing redundant commentary.

Changes:

Reword the Swizzle-contained-mask comment in genHWIntrinsic (WASM codegen) to avoid attributing behavior to a specific helper.
Add a lead-in comment in gtNewSimdShuffleNode (WASM lowering branch) describing element-to-byte-index expansion for i8x16.swizzle, and remove a now-redundant inline comment.

Show a summary per file

File	Description
src/coreclr/jit/hwintrinsiccodegenwasm.cpp	Comment clarification for WASM `Swizzle` lowering to `i8x16.shuffle`.
src/coreclr/jit/gentree.cpp	Adds/cleans up comments documenting WASM shuffle-to-swizzle mask expansion semantics.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

adamperlin · 2026-07-17T17:38:30Z

/ba-g infra failures

tannergooding · 2026-07-17T00:04:50Z

Post-merge follow-up to #130850, addressing three review comments from @adamperlin.

hwintrinsiccodegenwasm.cpp: reword the contained-mask Swizzle->i8x16.shuffle remark. On Wasm genConsumeMultiOpOperands only updates liveness and doesn't touch the value stack, so the comment now says "prior codegen left the source on the value stack once" rather than attributing it to genConsumeMultiOpOperands.

gentree.cpp (TARGET_WASM Shuffle-lowering branch): add a lead-in comment describing the element->byte-index expansion -- each element-granular selector expands into elementSize consecutive byte indices for i8x16.swizzle, and an out-of-range selector becomes 0xFF bytes so swizzle's native index >= 16 -> 0 behavior zero-fills that element. Dropped the now-redundant inline else-block comment.

The third comment (lowerwasm.cpp, feeding a constant-zero second operand to i8x16.shuffle instead of the source twice) is addressed in the thread rather than in code: a local.get of the existing source is smaller than materializing a 16-byte v128.const zero, and it can't remove the special case since the Swizzle node is 2-operand (source, mask->immediate) with no second-vector slot.

Comment-only; no functional change.

Note

This PR description was drafted by Copilot on behalf of @tannergooding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-17T00:05:35Z

Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T00:06:14Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates explanatory comments in the WASM SIMD shuffle/swizzle code paths in the JIT, clarifying how masks map to i8x16.shuffle / i8x16.swizzle and removing redundant commentary.

Changes:

Reword the Swizzle-contained-mask comment in genHWIntrinsic (WASM codegen) to avoid attributing behavior to a specific helper.
Add a lead-in comment in gtNewSimdShuffleNode (WASM lowering branch) describing element-to-byte-index expansion for i8x16.swizzle, and remove a now-redundant inline comment.

Show a summary per file

File	Description
src/coreclr/jit/hwintrinsiccodegenwasm.cpp	Comment clarification for WASM `Swizzle` lowering to `i8x16.shuffle`.
src/coreclr/jit/gentree.cpp	Adds/cleans up comments documenting WASM shuffle-to-swizzle mask expansion semantics.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

adamperlin · 2026-07-17T17:38:30Z

/ba-g infra failures

tannergooding · 2026-07-17T00:04:50Z

Post-merge follow-up to #130850, addressing three review comments from @adamperlin.

hwintrinsiccodegenwasm.cpp: reword the contained-mask Swizzle->i8x16.shuffle remark. On Wasm genConsumeMultiOpOperands only updates liveness and doesn't touch the value stack, so the comment now says "prior codegen left the source on the value stack once" rather than attributing it to genConsumeMultiOpOperands.

gentree.cpp (TARGET_WASM Shuffle-lowering branch): add a lead-in comment describing the element->byte-index expansion -- each element-granular selector expands into elementSize consecutive byte indices for i8x16.swizzle, and an out-of-range selector becomes 0xFF bytes so swizzle's native index >= 16 -> 0 behavior zero-fills that element. Dropped the now-redundant inline else-block comment.

The third comment (lowerwasm.cpp, feeding a constant-zero second operand to i8x16.shuffle instead of the source twice) is addressed in the thread rather than in code: a local.get of the existing source is smaller than materializing a 16-byte v128.const zero, and it can't remove the special case since the Swizzle node is 2-operand (source, mask->immediate) with no second-vector slot.

Comment-only; no functional change.

Note

This PR description was drafted by Copilot on behalf of @tannergooding.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-17T00:05:35Z

Azure Pipelines: Successfully started running 5 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T00:06:14Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates explanatory comments in the WASM SIMD shuffle/swizzle code paths in the JIT, clarifying how masks map to i8x16.shuffle / i8x16.swizzle and removing redundant commentary.

Changes:

Reword the Swizzle-contained-mask comment in genHWIntrinsic (WASM codegen) to avoid attributing behavior to a specific helper.
Add a lead-in comment in gtNewSimdShuffleNode (WASM lowering branch) describing element-to-byte-index expansion for i8x16.swizzle, and remove a now-redundant inline comment.

Show a summary per file

File	Description
src/coreclr/jit/hwintrinsiccodegenwasm.cpp	Comment clarification for WASM `Swizzle` lowering to `i8x16.shuffle`.
src/coreclr/jit/gentree.cpp	Adds/cleans up comments documenting WASM shuffle-to-swizzle mask expansion semantics.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

adamperlin · 2026-07-17T17:38:30Z

/ba-g infra failures

Clarify WASM shuffle/swizzle codegen comments
a4afb58
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 17, 2026 00:04

github-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 17, 2026

dotnet-policy-serviceBot assigned tannergooding Jul 17, 2026

Copilotstarted reviewing on behalf of tannergooding July 17, 2026 00:05 View session

CopilotAI reviewed Jul 17, 2026
View reviewed changes

Comment threadsrc/coreclr/jit/hwintrinsiccodegenwasm.cpp

adamperlin approved these changes Jul 17, 2026
View reviewed changes

tannergooding enabled auto-merge (squash) July 17, 2026 01:31

build-analysisBot mentioned this pull request Jul 17, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
3 tasks

tannergooding merged commit e220bf0 into dotnet:mainJul 17, 2026
139 of 142 checks passed

tannergooding deleted the tannergooding-wasm-simd-shuffle-followup branch July 17, 2026 17:39

dotnet-maestroBot mentioned this pull request Jul 18, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7841
Merged

dotnet-milestone-botBot added this to the 11.0-preview7 milestone Jul 18, 2026

github-actionsBot locked and limited conversation to collaborators Aug 17, 2026