Skip to content

Fix build break in PackedSimdTests in outerloop - #130962

Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom
jakobbotsch:fix-outerloop
Jul 17, 2026
Merged

Fix build break in PackedSimdTests in outerloop#130962
jakobbotsch merged 1 commit into
dotnet:mainfrom
jakobbotsch:fix-outerloop

Conversation

@jakobbotsch

@jakobbotschjakobbotsch commented Jul 17, 2026

Copy link
Copy Markdown
Member

Fix break from #130850

@jakobbotsch
jakobbotsch requested review from Copilot and tannergooding and removed request for CopilotJuly 17, 2026 10:57
@jakobbotsch

jakobbotsch commented Jul 17, 2026

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@github-actionsgithub-actionsBot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 17, 2026
@azure-pipelines

azure-pipelinesBot commented Jul 17, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@azure-pipelines

azure-pipelinesBot commented Jul 17, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@jakobbotsch

jakobbotsch commented Jul 17, 2026

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 17, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@radekdoulik

radekdoulik commented Jul 17, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.

@github-actionsgithub-actionsBot mentioned this pull request Jul 17, 2026
Closed
@jakobbotsch

jakobbotsch commented Jul 17, 2026

Copy link
Copy Markdown
MemberAuthor

The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.

Looks like it. I am going to merge this, but @tannergooding can you please handle that fallout from #128604 ASAP?

@tannergooding

tannergooding commented Jul 17, 2026

Copy link
Copy Markdown
Member

Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.

but @tannergooding can you please handle that fallout from #128604 ASAP?

Yep. Looking now and I'll look at fixing the filter too

This was referenced Jul 17, 2026
Open
Open
@jakobbotsch

jakobbotsch commented Jul 17, 2026

Copy link
Copy Markdown
MemberAuthor

/ba-g Failures will be handle separately, this is fixing a build break

@jakobbotsch
jakobbotsch merged commit 19695f3 into dotnet:mainJul 17, 2026
130 of 154 checks passed
@radekdoulik

radekdoulik commented Jul 17, 2026

Copy link
Copy Markdown
Member

Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.

These tests are only in priority1, so they run only in outerloop and thus PRs CI run didn't catch them.

@jakobbotsch
jakobbotsch deleted the fix-outerloop branch July 17, 2026 14:09
This was referenced Jul 17, 2026
Merged
Merged
tannergooding added a commit that referenced this pull request Jul 17, 2026
@tannergooding
Add wasm HardwareIntrinsics PR pipeline (#130975)
7b037f1
The wasm `HardwareIntrinsics` tests
(`src/tests/JIT/HardwareIntrinsics/Wasm`) are gated by
`HWITestsWasmOnly` -> `CLRTestTargetUnsupported` unless
`TargetArchitecture == wasm` (plus an `EnableWasmHWIntrinsicsTests`
opt-in). As a result, none of the existing PR-triggered intrinsics
pipelines ever compile them:
- `runtime-coreclr hardware-intrinsics` (`src/coreclr/jit/**`,
x86/x64/arm/osx) passes without building the wasm tree.
- `hardware-intrinsics-arm64` (`src/coreclr/jit/*arm64*`) is skipped for
wasm-only changes.
So a break in the wasm intrinsic tests only surfaces in a
rolling/outerloop browser-wasm build, which is what required the #130962
follow-up to #130850.
----------
This adds a wasm counterpart mirroring `hardware-intrinsics-arm64.yml`:
- `eng/pipelines/coreclr/hardware-intrinsics-wasm.yml` -- PR-triggered,
filtered on `src/coreclr/jit/*wasm*` (covers `hwintrinsic*wasm*`,
`lowerwasm.cpp`, `regallocwasm.cpp`) plus
`src/tests/JIT/HardwareIntrinsics/Wasm/**`. Runs a `browser_wasm` leg
with `/p:EnableWasmHWIntrinsicsTests=true
-tree:JIT/HardwareIntrinsics/Wasm`.
- `eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml` --
modeled on the existing `wasi-wasm-coreclr-runtime-tests.yml`
(`global-build-job`, `runtimeFlavor: coreclr`, `-s clr+libs+packs`). It
is build-only (`sendToHelix: false`) since browser/V8 can''t execute
these tests yet -- enough to catch compile breaks like #130962.
Like `hardware-intrinsics-arm64.yml`, the new pipeline still needs an
Azure DevOps definition registered against the YAML to appear as a PR
check.
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding added a commit that referenced this pull request Jul 17, 2026
@tannergooding
Update outerloop convert tests for saturating float/double casts (#13…
1c124aa
…0974)
The saturating `float`/`double` -> small integral cast changes from
#128604 were not reflected in two outerloop tests, breaking CI (see
#130962 (comment)).
----------
`JIT/Regression/CLR-x86-JIT/V1-M10/b05617`: under saturation `conv.u1`
of `2.564783e7` now yields `255` (was `214`) and `conv.i1` of
`5246667200` yields `127` (was `-1`). Propagating through the stack, the
final `conv.u4` constant is updated `4294967086` -> `4294967043` so the
test still returns `100`. Mono still truncates, so the test is marked
unsupported on Mono, referencing the same tracking issue (#100368) used
by the JIT regression test in #128604.
----------
`JIT/IL_Conformance/Convert/TestConvertFromIntegral`: the two checked
`ushort.MaxValue -> short` via `Conv_I2` cases now saturate to
`short.MaxValue` on CoreCLR instead of truncating to `-1`. Since the
result is now runtime-divergent (Mono truncates), they are marked
`UnspecifiedBehaviour`, consistent with how every other
cross-runtime-divergent float->integral out-of-range case in this file
is already handled. This keeps the rest of the file running on Mono.
Verified locally against a checked runtime: `b05617` returns `100` and
`TestConvertFromIntegral` reports "All tests passed".
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-maestrodotnet-maestroBot mentioned this pull request Jul 18, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-preview7 milestone Jul 18, 2026
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 17, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@jakobbotsch@radekdoulik@tannergooding@EgorBo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix build break in PackedSimdTests in outerloop by jakobbotsch · Pull Request #130962 · dotnet/runtime · GitHub
Skip to content
Fix build break in PackedSimdTests in outerloop - #130962
Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Jul 17, 2026
Merged
Fix build break in PackedSimdTests in outerloop#130962
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Fix break from #130850
@jakobbotsch
jakobbotsch
requested review from
Copilot and tannergooding
and removed request for
CopilotJuly 17, 2026 10:57
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jul 17, 2026
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 4 pipeline(s).

11 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@radekdoulik
radekdoulik
commented
Jul 17, 2026•

edited

Loading

Copy link


Copy Markdown

Member
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 17, 2026

Closed

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
Looks like it. I am going to merge this, but @tannergooding can you please handle that fallout from #128604 ASAP?
@tannergooding
tannergooding
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
but @tannergooding can you please handle that fallout from #128604 ASAP?
Yep. Looking now and I'll look at fixing the filter too

This was referenced Jul 17, 2026

Open


Open

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g Failures will be handle separately, this is fixing a build break
@jakobbotsch
jakobbotsch
merged commit 19695f3
into
dotnet:mainJul 17, 2026

130 of 154 checks passed

@radekdoulik
radekdoulik
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
These tests are only in priority1, so they run only in outerloop and thus PRs CI run didn't catch them.
@jakobbotsch
jakobbotsch
deleted the

fix-outerloop

branch
July 17, 2026 14:09

This was referenced Jul 17, 2026
 Merged

 Merged

tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Add wasm HardwareIntrinsics PR pipeline (#130975)
7b037f1
The wasm `HardwareIntrinsics` tests
(`src/tests/JIT/HardwareIntrinsics/Wasm`) are gated by
`HWITestsWasmOnly` -> `CLRTestTargetUnsupported` unless
`TargetArchitecture == wasm` (plus an `EnableWasmHWIntrinsicsTests`
opt-in). As a result, none of the existing PR-triggered intrinsics
pipelines ever compile them:
- `runtime-coreclr hardware-intrinsics` (`src/coreclr/jit/**`,
x86/x64/arm/osx) passes without building the wasm tree.
- `hardware-intrinsics-arm64` (`src/coreclr/jit/*arm64*`) is skipped for
wasm-only changes.
So a break in the wasm intrinsic tests only surfaces in a
rolling/outerloop browser-wasm build, which is what required the #130962
follow-up to #130850.
----------
This adds a wasm counterpart mirroring `hardware-intrinsics-arm64.yml`:
- `eng/pipelines/coreclr/hardware-intrinsics-wasm.yml` -- PR-triggered,
filtered on `src/coreclr/jit/*wasm*` (covers `hwintrinsic*wasm*`,
`lowerwasm.cpp`, `regallocwasm.cpp`) plus
`src/tests/JIT/HardwareIntrinsics/Wasm/**`. Runs a `browser_wasm` leg
with `/p:EnableWasmHWIntrinsicsTests=true
-tree:JIT/HardwareIntrinsics/Wasm`.
- `eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml` --
modeled on the existing `wasi-wasm-coreclr-runtime-tests.yml`
(`global-build-job`, `runtimeFlavor: coreclr`, `-s clr+libs+packs`). It
is build-only (`sendToHelix: false`) since browser/V8 can''t execute
these tests yet -- enough to catch compile breaks like #130962.
Like `hardware-intrinsics-arm64.yml`, the new pipeline still needs an
Azure DevOps definition registered against the YAML to appear as a PR
check.
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Update outerloop convert tests for saturating float/double casts (#13…
1c124aa
…0974)
The saturating `float`/`double` -> small integral cast changes from
#128604 were not reflected in two outerloop tests, breaking CI (see
#130962 (comment)).
----------
`JIT/Regression/CLR-x86-JIT/V1-M10/b05617`: under saturation `conv.u1`
of `2.564783e7` now yields `255` (was `214`) and `conv.i1` of
`5246667200` yields `127` (was `-1`). Propagating through the stack, the
final `conv.u4` constant is updated `4294967086` -> `4294967043` so the
test still returns `100`. Mono still truncates, so the test is marked
unsupported on Mono, referencing the same tracking issue (#100368) used
by the JIT regression test in #128604.
----------
`JIT/IL_Conformance/Convert/TestConvertFromIntegral`: the two checked
`ushort.MaxValue -> short` via `Conv_I2` cases now saturate to
`short.MaxValue` on CoreCLR instead of truncating to `-1`. Since the
result is now runtime-divergent (Mono truncates), they are marked
`UnspecifiedBehaviour`, consistent with how every other
cross-runtime-divergent float->integral out-of-range case in this file
is already handled. This keeps the rest of the file running on Mono.
Verified locally against a checked runtime: `b05617` returns `100` and
`TestConvertFromIntegral` reports "All tests passed".
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 18, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 18, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 17, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@jakobbotsch@radekdoulik@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix build break in PackedSimdTests in outerloop by jakobbotsch · Pull Request #130962 · dotnet/runtime · GitHub
Skip to content
Fix build break in PackedSimdTests in outerloop - #130962
Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Jul 17, 2026
Merged
Fix build break in PackedSimdTests in outerloop#130962
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Fix break from #130850
@jakobbotsch
jakobbotsch
requested review from
Copilot and tannergooding
and removed request for
CopilotJuly 17, 2026 10:57
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jul 17, 2026
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 4 pipeline(s).

11 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@radekdoulik
radekdoulik
commented
Jul 17, 2026•

edited

Loading

Copy link


Copy Markdown

Member
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 17, 2026

Closed

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
Looks like it. I am going to merge this, but @tannergooding can you please handle that fallout from #128604 ASAP?
@tannergooding
tannergooding
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
but @tannergooding can you please handle that fallout from #128604 ASAP?
Yep. Looking now and I'll look at fixing the filter too

This was referenced Jul 17, 2026

Open


Open

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g Failures will be handle separately, this is fixing a build break
@jakobbotsch
jakobbotsch
merged commit 19695f3
into
dotnet:mainJul 17, 2026

130 of 154 checks passed

@radekdoulik
radekdoulik
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
These tests are only in priority1, so they run only in outerloop and thus PRs CI run didn't catch them.
@jakobbotsch
jakobbotsch
deleted the

fix-outerloop

branch
July 17, 2026 14:09

This was referenced Jul 17, 2026
 Merged

 Merged

tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Add wasm HardwareIntrinsics PR pipeline (#130975)
7b037f1
The wasm `HardwareIntrinsics` tests
(`src/tests/JIT/HardwareIntrinsics/Wasm`) are gated by
`HWITestsWasmOnly` -> `CLRTestTargetUnsupported` unless
`TargetArchitecture == wasm` (plus an `EnableWasmHWIntrinsicsTests`
opt-in). As a result, none of the existing PR-triggered intrinsics
pipelines ever compile them:
- `runtime-coreclr hardware-intrinsics` (`src/coreclr/jit/**`,
x86/x64/arm/osx) passes without building the wasm tree.
- `hardware-intrinsics-arm64` (`src/coreclr/jit/*arm64*`) is skipped for
wasm-only changes.
So a break in the wasm intrinsic tests only surfaces in a
rolling/outerloop browser-wasm build, which is what required the #130962
follow-up to #130850.
----------
This adds a wasm counterpart mirroring `hardware-intrinsics-arm64.yml`:
- `eng/pipelines/coreclr/hardware-intrinsics-wasm.yml` -- PR-triggered,
filtered on `src/coreclr/jit/*wasm*` (covers `hwintrinsic*wasm*`,
`lowerwasm.cpp`, `regallocwasm.cpp`) plus
`src/tests/JIT/HardwareIntrinsics/Wasm/**`. Runs a `browser_wasm` leg
with `/p:EnableWasmHWIntrinsicsTests=true
-tree:JIT/HardwareIntrinsics/Wasm`.
- `eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml` --
modeled on the existing `wasi-wasm-coreclr-runtime-tests.yml`
(`global-build-job`, `runtimeFlavor: coreclr`, `-s clr+libs+packs`). It
is build-only (`sendToHelix: false`) since browser/V8 can''t execute
these tests yet -- enough to catch compile breaks like #130962.
Like `hardware-intrinsics-arm64.yml`, the new pipeline still needs an
Azure DevOps definition registered against the YAML to appear as a PR
check.
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Update outerloop convert tests for saturating float/double casts (#13…
1c124aa
…0974)
The saturating `float`/`double` -> small integral cast changes from
#128604 were not reflected in two outerloop tests, breaking CI (see
#130962 (comment)).
----------
`JIT/Regression/CLR-x86-JIT/V1-M10/b05617`: under saturation `conv.u1`
of `2.564783e7` now yields `255` (was `214`) and `conv.i1` of
`5246667200` yields `127` (was `-1`). Propagating through the stack, the
final `conv.u4` constant is updated `4294967086` -> `4294967043` so the
test still returns `100`. Mono still truncates, so the test is marked
unsupported on Mono, referencing the same tracking issue (#100368) used
by the JIT regression test in #128604.
----------
`JIT/IL_Conformance/Convert/TestConvertFromIntegral`: the two checked
`ushort.MaxValue -> short` via `Conv_I2` cases now saturate to
`short.MaxValue` on CoreCLR instead of truncating to `-1`. Since the
result is now runtime-divergent (Mono truncates), they are marked
`UnspecifiedBehaviour`, consistent with how every other
cross-runtime-divergent float->integral out-of-range case in this file
is already handled. This keeps the rest of the file running on Mono.
Verified locally against a checked runtime: `b05617` returns `100` and
`TestConvertFromIntegral` reports "All tests passed".
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 18, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 18, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 17, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@jakobbotsch@radekdoulik@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix build break in PackedSimdTests in outerloop by jakobbotsch · Pull Request #130962 · dotnet/runtime · GitHub
Skip to content
Fix build break in PackedSimdTests in outerloop - #130962
Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Jul 17, 2026
Merged
Fix build break in PackedSimdTests in outerloop#130962
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Fix break from #130850
@jakobbotsch
jakobbotsch
requested review from
Copilot and tannergooding
and removed request for
CopilotJuly 17, 2026 10:57
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jul 17, 2026
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 4 pipeline(s).

11 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@radekdoulik
radekdoulik
commented
Jul 17, 2026•

edited

Loading

Copy link


Copy Markdown

Member
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 17, 2026

Closed

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
Looks like it. I am going to merge this, but @tannergooding can you please handle that fallout from #128604 ASAP?
@tannergooding
tannergooding
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
but @tannergooding can you please handle that fallout from #128604 ASAP?
Yep. Looking now and I'll look at fixing the filter too

This was referenced Jul 17, 2026

Open


Open

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g Failures will be handle separately, this is fixing a build break
@jakobbotsch
jakobbotsch
merged commit 19695f3
into
dotnet:mainJul 17, 2026

130 of 154 checks passed

@radekdoulik
radekdoulik
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
These tests are only in priority1, so they run only in outerloop and thus PRs CI run didn't catch them.
@jakobbotsch
jakobbotsch
deleted the

fix-outerloop

branch
July 17, 2026 14:09

This was referenced Jul 17, 2026
 Merged

 Merged

tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Add wasm HardwareIntrinsics PR pipeline (#130975)
7b037f1
The wasm `HardwareIntrinsics` tests
(`src/tests/JIT/HardwareIntrinsics/Wasm`) are gated by
`HWITestsWasmOnly` -> `CLRTestTargetUnsupported` unless
`TargetArchitecture == wasm` (plus an `EnableWasmHWIntrinsicsTests`
opt-in). As a result, none of the existing PR-triggered intrinsics
pipelines ever compile them:
- `runtime-coreclr hardware-intrinsics` (`src/coreclr/jit/**`,
x86/x64/arm/osx) passes without building the wasm tree.
- `hardware-intrinsics-arm64` (`src/coreclr/jit/*arm64*`) is skipped for
wasm-only changes.
So a break in the wasm intrinsic tests only surfaces in a
rolling/outerloop browser-wasm build, which is what required the #130962
follow-up to #130850.
----------
This adds a wasm counterpart mirroring `hardware-intrinsics-arm64.yml`:
- `eng/pipelines/coreclr/hardware-intrinsics-wasm.yml` -- PR-triggered,
filtered on `src/coreclr/jit/*wasm*` (covers `hwintrinsic*wasm*`,
`lowerwasm.cpp`, `regallocwasm.cpp`) plus
`src/tests/JIT/HardwareIntrinsics/Wasm/**`. Runs a `browser_wasm` leg
with `/p:EnableWasmHWIntrinsicsTests=true
-tree:JIT/HardwareIntrinsics/Wasm`.
- `eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml` --
modeled on the existing `wasi-wasm-coreclr-runtime-tests.yml`
(`global-build-job`, `runtimeFlavor: coreclr`, `-s clr+libs+packs`). It
is build-only (`sendToHelix: false`) since browser/V8 can''t execute
these tests yet -- enough to catch compile breaks like #130962.
Like `hardware-intrinsics-arm64.yml`, the new pipeline still needs an
Azure DevOps definition registered against the YAML to appear as a PR
check.
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Update outerloop convert tests for saturating float/double casts (#13…
1c124aa
…0974)
The saturating `float`/`double` -> small integral cast changes from
#128604 were not reflected in two outerloop tests, breaking CI (see
#130962 (comment)).
----------
`JIT/Regression/CLR-x86-JIT/V1-M10/b05617`: under saturation `conv.u1`
of `2.564783e7` now yields `255` (was `214`) and `conv.i1` of
`5246667200` yields `127` (was `-1`). Propagating through the stack, the
final `conv.u4` constant is updated `4294967086` -> `4294967043` so the
test still returns `100`. Mono still truncates, so the test is marked
unsupported on Mono, referencing the same tracking issue (#100368) used
by the JIT regression test in #128604.
----------
`JIT/IL_Conformance/Convert/TestConvertFromIntegral`: the two checked
`ushort.MaxValue -> short` via `Conv_I2` cases now saturate to
`short.MaxValue` on CoreCLR instead of truncating to `-1`. Since the
result is now runtime-divergent (Mono truncates), they are marked
`UnspecifiedBehaviour`, consistent with how every other
cross-runtime-divergent float->integral out-of-range case in this file
is already handled. This keeps the rest of the file running on Mono.
Verified locally against a checked runtime: `b05617` returns `100` and
`TestConvertFromIntegral` reports "All tests passed".
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 18, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 18, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 17, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@jakobbotsch@radekdoulik@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix build break in PackedSimdTests in outerloop by jakobbotsch · Pull Request #130962 · dotnet/runtime · GitHub
Skip to content
Fix build break in PackedSimdTests in outerloop - #130962
Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Jul 17, 2026
Merged
Fix build break in PackedSimdTests in outerloop#130962
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Fix break from #130850
@jakobbotsch
jakobbotsch
requested review from
Copilot and tannergooding
and removed request for
CopilotJuly 17, 2026 10:57
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jul 17, 2026
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 4 pipeline(s).

11 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@radekdoulik
radekdoulik
commented
Jul 17, 2026•

edited

Loading

Copy link


Copy Markdown

Member
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 17, 2026

Closed

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
Looks like it. I am going to merge this, but @tannergooding can you please handle that fallout from #128604 ASAP?
@tannergooding
tannergooding
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
but @tannergooding can you please handle that fallout from #128604 ASAP?
Yep. Looking now and I'll look at fixing the filter too

This was referenced Jul 17, 2026

Open


Open

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g Failures will be handle separately, this is fixing a build break
@jakobbotsch
jakobbotsch
merged commit 19695f3
into
dotnet:mainJul 17, 2026

130 of 154 checks passed

@radekdoulik
radekdoulik
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
These tests are only in priority1, so they run only in outerloop and thus PRs CI run didn't catch them.
@jakobbotsch
jakobbotsch
deleted the

fix-outerloop

branch
July 17, 2026 14:09

This was referenced Jul 17, 2026
 Merged

 Merged

tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Add wasm HardwareIntrinsics PR pipeline (#130975)
7b037f1
The wasm `HardwareIntrinsics` tests
(`src/tests/JIT/HardwareIntrinsics/Wasm`) are gated by
`HWITestsWasmOnly` -> `CLRTestTargetUnsupported` unless
`TargetArchitecture == wasm` (plus an `EnableWasmHWIntrinsicsTests`
opt-in). As a result, none of the existing PR-triggered intrinsics
pipelines ever compile them:
- `runtime-coreclr hardware-intrinsics` (`src/coreclr/jit/**`,
x86/x64/arm/osx) passes without building the wasm tree.
- `hardware-intrinsics-arm64` (`src/coreclr/jit/*arm64*`) is skipped for
wasm-only changes.
So a break in the wasm intrinsic tests only surfaces in a
rolling/outerloop browser-wasm build, which is what required the #130962
follow-up to #130850.
----------
This adds a wasm counterpart mirroring `hardware-intrinsics-arm64.yml`:
- `eng/pipelines/coreclr/hardware-intrinsics-wasm.yml` -- PR-triggered,
filtered on `src/coreclr/jit/*wasm*` (covers `hwintrinsic*wasm*`,
`lowerwasm.cpp`, `regallocwasm.cpp`) plus
`src/tests/JIT/HardwareIntrinsics/Wasm/**`. Runs a `browser_wasm` leg
with `/p:EnableWasmHWIntrinsicsTests=true
-tree:JIT/HardwareIntrinsics/Wasm`.
- `eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml` --
modeled on the existing `wasi-wasm-coreclr-runtime-tests.yml`
(`global-build-job`, `runtimeFlavor: coreclr`, `-s clr+libs+packs`). It
is build-only (`sendToHelix: false`) since browser/V8 can''t execute
these tests yet -- enough to catch compile breaks like #130962.
Like `hardware-intrinsics-arm64.yml`, the new pipeline still needs an
Azure DevOps definition registered against the YAML to appear as a PR
check.
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Update outerloop convert tests for saturating float/double casts (#13…
1c124aa
…0974)
The saturating `float`/`double` -> small integral cast changes from
#128604 were not reflected in two outerloop tests, breaking CI (see
#130962 (comment)).
----------
`JIT/Regression/CLR-x86-JIT/V1-M10/b05617`: under saturation `conv.u1`
of `2.564783e7` now yields `255` (was `214`) and `conv.i1` of
`5246667200` yields `127` (was `-1`). Propagating through the stack, the
final `conv.u4` constant is updated `4294967086` -> `4294967043` so the
test still returns `100`. Mono still truncates, so the test is marked
unsupported on Mono, referencing the same tracking issue (#100368) used
by the JIT regression test in #128604.
----------
`JIT/IL_Conformance/Convert/TestConvertFromIntegral`: the two checked
`ushort.MaxValue -> short` via `Conv_I2` cases now saturate to
`short.MaxValue` on CoreCLR instead of truncating to `-1`. Since the
result is now runtime-divergent (Mono truncates), they are marked
`UnspecifiedBehaviour`, consistent with how every other
cross-runtime-divergent float->integral out-of-range case in this file
is already handled. This keeps the rest of the file running on Mono.
Verified locally against a checked runtime: `b05617` returns `100` and
`TestConvertFromIntegral` reports "All tests passed".
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 18, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 18, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 17, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@jakobbotsch@radekdoulik@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix build break in PackedSimdTests in outerloop by jakobbotsch · Pull Request #130962 · dotnet/runtime · GitHub
Skip to content
Fix build break in PackedSimdTests in outerloop - #130962
Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Jul 17, 2026
Merged
Fix build break in PackedSimdTests in outerloop#130962
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Fix break from #130850
@jakobbotsch
jakobbotsch
requested review from
Copilot and tannergooding
and removed request for
CopilotJuly 17, 2026 10:57
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jul 17, 2026
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 4 pipeline(s).

11 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@radekdoulik
radekdoulik
commented
Jul 17, 2026•

edited

Loading

Copy link


Copy Markdown

Member
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 17, 2026

Closed

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
Looks like it. I am going to merge this, but @tannergooding can you please handle that fallout from #128604 ASAP?
@tannergooding
tannergooding
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
but @tannergooding can you please handle that fallout from #128604 ASAP?
Yep. Looking now and I'll look at fixing the filter too

This was referenced Jul 17, 2026

Open


Open

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g Failures will be handle separately, this is fixing a build break
@jakobbotsch
jakobbotsch
merged commit 19695f3
into
dotnet:mainJul 17, 2026

130 of 154 checks passed

@radekdoulik
radekdoulik
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
These tests are only in priority1, so they run only in outerloop and thus PRs CI run didn't catch them.
@jakobbotsch
jakobbotsch
deleted the

fix-outerloop

branch
July 17, 2026 14:09

This was referenced Jul 17, 2026
 Merged

 Merged

tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Add wasm HardwareIntrinsics PR pipeline (#130975)
7b037f1
The wasm `HardwareIntrinsics` tests
(`src/tests/JIT/HardwareIntrinsics/Wasm`) are gated by
`HWITestsWasmOnly` -> `CLRTestTargetUnsupported` unless
`TargetArchitecture == wasm` (plus an `EnableWasmHWIntrinsicsTests`
opt-in). As a result, none of the existing PR-triggered intrinsics
pipelines ever compile them:
- `runtime-coreclr hardware-intrinsics` (`src/coreclr/jit/**`,
x86/x64/arm/osx) passes without building the wasm tree.
- `hardware-intrinsics-arm64` (`src/coreclr/jit/*arm64*`) is skipped for
wasm-only changes.
So a break in the wasm intrinsic tests only surfaces in a
rolling/outerloop browser-wasm build, which is what required the #130962
follow-up to #130850.
----------
This adds a wasm counterpart mirroring `hardware-intrinsics-arm64.yml`:
- `eng/pipelines/coreclr/hardware-intrinsics-wasm.yml` -- PR-triggered,
filtered on `src/coreclr/jit/*wasm*` (covers `hwintrinsic*wasm*`,
`lowerwasm.cpp`, `regallocwasm.cpp`) plus
`src/tests/JIT/HardwareIntrinsics/Wasm/**`. Runs a `browser_wasm` leg
with `/p:EnableWasmHWIntrinsicsTests=true
-tree:JIT/HardwareIntrinsics/Wasm`.
- `eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml` --
modeled on the existing `wasi-wasm-coreclr-runtime-tests.yml`
(`global-build-job`, `runtimeFlavor: coreclr`, `-s clr+libs+packs`). It
is build-only (`sendToHelix: false`) since browser/V8 can''t execute
these tests yet -- enough to catch compile breaks like #130962.
Like `hardware-intrinsics-arm64.yml`, the new pipeline still needs an
Azure DevOps definition registered against the YAML to appear as a PR
check.
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Update outerloop convert tests for saturating float/double casts (#13…
1c124aa
…0974)
The saturating `float`/`double` -> small integral cast changes from
#128604 were not reflected in two outerloop tests, breaking CI (see
#130962 (comment)).
----------
`JIT/Regression/CLR-x86-JIT/V1-M10/b05617`: under saturation `conv.u1`
of `2.564783e7` now yields `255` (was `214`) and `conv.i1` of
`5246667200` yields `127` (was `-1`). Propagating through the stack, the
final `conv.u4` constant is updated `4294967086` -> `4294967043` so the
test still returns `100`. Mono still truncates, so the test is marked
unsupported on Mono, referencing the same tracking issue (#100368) used
by the JIT regression test in #128604.
----------
`JIT/IL_Conformance/Convert/TestConvertFromIntegral`: the two checked
`ushort.MaxValue -> short` via `Conv_I2` cases now saturate to
`short.MaxValue` on CoreCLR instead of truncating to `-1`. Since the
result is now runtime-divergent (Mono truncates), they are marked
`UnspecifiedBehaviour`, consistent with how every other
cross-runtime-divergent float->integral out-of-range case in this file
is already handled. This keeps the rest of the file running on Mono.
Verified locally against a checked runtime: `b05617` returns `100` and
`TestConvertFromIntegral` reports "All tests passed".
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 18, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 18, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 17, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@jakobbotsch@radekdoulik@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix build break in PackedSimdTests in outerloop by jakobbotsch · Pull Request #130962 · dotnet/runtime · GitHub
Skip to content
Fix build break in PackedSimdTests in outerloop - #130962
Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Jul 17, 2026
Merged
Fix build break in PackedSimdTests in outerloop#130962
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Fix break from #130850
@jakobbotsch
jakobbotsch
requested review from
Copilot and tannergooding
and removed request for
CopilotJuly 17, 2026 10:57
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jul 17, 2026
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 4 pipeline(s).

11 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@radekdoulik
radekdoulik
commented
Jul 17, 2026•

edited

Loading

Copy link


Copy Markdown

Member
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 17, 2026

Closed

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
Looks like it. I am going to merge this, but @tannergooding can you please handle that fallout from #128604 ASAP?
@tannergooding
tannergooding
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
but @tannergooding can you please handle that fallout from #128604 ASAP?
Yep. Looking now and I'll look at fixing the filter too

This was referenced Jul 17, 2026

Open


Open

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g Failures will be handle separately, this is fixing a build break
@jakobbotsch
jakobbotsch
merged commit 19695f3
into
dotnet:mainJul 17, 2026

130 of 154 checks passed

@radekdoulik
radekdoulik
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
These tests are only in priority1, so they run only in outerloop and thus PRs CI run didn't catch them.
@jakobbotsch
jakobbotsch
deleted the

fix-outerloop

branch
July 17, 2026 14:09

This was referenced Jul 17, 2026
 Merged

 Merged

tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Add wasm HardwareIntrinsics PR pipeline (#130975)
7b037f1
The wasm `HardwareIntrinsics` tests
(`src/tests/JIT/HardwareIntrinsics/Wasm`) are gated by
`HWITestsWasmOnly` -> `CLRTestTargetUnsupported` unless
`TargetArchitecture == wasm` (plus an `EnableWasmHWIntrinsicsTests`
opt-in). As a result, none of the existing PR-triggered intrinsics
pipelines ever compile them:
- `runtime-coreclr hardware-intrinsics` (`src/coreclr/jit/**`,
x86/x64/arm/osx) passes without building the wasm tree.
- `hardware-intrinsics-arm64` (`src/coreclr/jit/*arm64*`) is skipped for
wasm-only changes.
So a break in the wasm intrinsic tests only surfaces in a
rolling/outerloop browser-wasm build, which is what required the #130962
follow-up to #130850.
----------
This adds a wasm counterpart mirroring `hardware-intrinsics-arm64.yml`:
- `eng/pipelines/coreclr/hardware-intrinsics-wasm.yml` -- PR-triggered,
filtered on `src/coreclr/jit/*wasm*` (covers `hwintrinsic*wasm*`,
`lowerwasm.cpp`, `regallocwasm.cpp`) plus
`src/tests/JIT/HardwareIntrinsics/Wasm/**`. Runs a `browser_wasm` leg
with `/p:EnableWasmHWIntrinsicsTests=true
-tree:JIT/HardwareIntrinsics/Wasm`.
- `eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml` --
modeled on the existing `wasi-wasm-coreclr-runtime-tests.yml`
(`global-build-job`, `runtimeFlavor: coreclr`, `-s clr+libs+packs`). It
is build-only (`sendToHelix: false`) since browser/V8 can''t execute
these tests yet -- enough to catch compile breaks like #130962.
Like `hardware-intrinsics-arm64.yml`, the new pipeline still needs an
Azure DevOps definition registered against the YAML to appear as a PR
check.
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Update outerloop convert tests for saturating float/double casts (#13…
1c124aa
…0974)
The saturating `float`/`double` -> small integral cast changes from
#128604 were not reflected in two outerloop tests, breaking CI (see
#130962 (comment)).
----------
`JIT/Regression/CLR-x86-JIT/V1-M10/b05617`: under saturation `conv.u1`
of `2.564783e7` now yields `255` (was `214`) and `conv.i1` of
`5246667200` yields `127` (was `-1`). Propagating through the stack, the
final `conv.u4` constant is updated `4294967086` -> `4294967043` so the
test still returns `100`. Mono still truncates, so the test is marked
unsupported on Mono, referencing the same tracking issue (#100368) used
by the JIT regression test in #128604.
----------
`JIT/IL_Conformance/Convert/TestConvertFromIntegral`: the two checked
`ushort.MaxValue -> short` via `Conv_I2` cases now saturate to
`short.MaxValue` on CoreCLR instead of truncating to `-1`. Since the
result is now runtime-divergent (Mono truncates), they are marked
`UnspecifiedBehaviour`, consistent with how every other
cross-runtime-divergent float->integral out-of-range case in this file
is already handled. This keeps the rest of the file running on Mono.
Verified locally against a checked runtime: `b05617` returns `100` and
`TestConvertFromIntegral` reports "All tests passed".
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 18, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 18, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 17, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@jakobbotsch@radekdoulik@tannergooding@EgorBo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Fix build break in PackedSimdTests in outerloop by jakobbotsch · Pull Request #130962 · dotnet/runtime · GitHub
Skip to content
Fix build break in PackedSimdTests in outerloop - #130962
Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Jul 17, 2026
Merged
Fix build break in PackedSimdTests in outerloop#130962
jakobbotsch merged 1 commit into
dotnet:mainfrom 
jakobbotsch:fix-outerloop
Conversation
@jakobbotsch
@jakobbotschjakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Fix break from #130850
@jakobbotsch
jakobbotsch
requested review from
Copilot and tannergooding
and removed request for
CopilotJuly 17, 2026 10:57
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@github-actionsgithub-actionsBot
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jul 17, 2026
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 4 pipeline(s).

11 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Jul 17, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 1 pipeline(s).
@radekdoulik
radekdoulik
commented
Jul 17, 2026•

edited

Loading

Copy link


Copy Markdown

Member
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 17, 2026

Closed

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
The build is fixed, it now uncovers 2 new test failures. These tests were not updated for #128604 changes yet.
Looks like it. I am going to merge this, but @tannergooding can you please handle that fallout from #128604 ASAP?
@tannergooding
tannergooding
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
but @tannergooding can you please handle that fallout from #128604 ASAP?
Yep. Looking now and I'll look at fixing the filter too

This was referenced Jul 17, 2026

Open


Open

@jakobbotsch
jakobbotsch
commented
Jul 17, 2026

Copy link


Copy Markdown

MemberAuthor
/ba-g Failures will be handle separately, this is fixing a build break
@jakobbotsch
jakobbotsch
merged commit 19695f3
into
dotnet:mainJul 17, 2026

130 of 154 checks passed

@radekdoulik
radekdoulik
commented
Jul 17, 2026

Copy link


Copy Markdown

Member
Ah, sorry. I think this means we're missing the CI filter that triggers this job when the hwintrinsic* files are changed. Probably got missed when the new wasm files were added.
These tests are only in priority1, so they run only in outerloop and thus PRs CI run didn't catch them.
@jakobbotsch
jakobbotsch
deleted the

fix-outerloop

branch
July 17, 2026 14:09

This was referenced Jul 17, 2026
 Merged

 Merged

tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Add wasm HardwareIntrinsics PR pipeline (#130975)
7b037f1
The wasm `HardwareIntrinsics` tests
(`src/tests/JIT/HardwareIntrinsics/Wasm`) are gated by
`HWITestsWasmOnly` -> `CLRTestTargetUnsupported` unless
`TargetArchitecture == wasm` (plus an `EnableWasmHWIntrinsicsTests`
opt-in). As a result, none of the existing PR-triggered intrinsics
pipelines ever compile them:
- `runtime-coreclr hardware-intrinsics` (`src/coreclr/jit/**`,
x86/x64/arm/osx) passes without building the wasm tree.
- `hardware-intrinsics-arm64` (`src/coreclr/jit/*arm64*`) is skipped for
wasm-only changes.
So a break in the wasm intrinsic tests only surfaces in a
rolling/outerloop browser-wasm build, which is what required the #130962
follow-up to #130850.
----------
This adds a wasm counterpart mirroring `hardware-intrinsics-arm64.yml`:
- `eng/pipelines/coreclr/hardware-intrinsics-wasm.yml` -- PR-triggered,
filtered on `src/coreclr/jit/*wasm*` (covers `hwintrinsic*wasm*`,
`lowerwasm.cpp`, `regallocwasm.cpp`) plus
`src/tests/JIT/HardwareIntrinsics/Wasm/**`. Runs a `browser_wasm` leg
with `/p:EnableWasmHWIntrinsicsTests=true
-tree:JIT/HardwareIntrinsics/Wasm`.
- `eng/pipelines/coreclr/templates/jit-hardware-intrinsics-wasm.yml` --
modeled on the existing `wasi-wasm-coreclr-runtime-tests.yml`
(`global-build-job`, `runtimeFlavor: coreclr`, `-s clr+libs+packs`). It
is build-only (`sendToHelix: false`) since browser/V8 can''t execute
these tests yet -- enough to catch compile breaks like #130962.
Like `hardware-intrinsics-arm64.yml`, the new pipeline still needs an
Azure DevOps definition registered against the YAML to appear as a PR
check.
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
tannergooding added a commit
that referenced
this pull request
Jul 17, 2026
@tannergooding
Update outerloop convert tests for saturating float/double casts (#13…
1c124aa
…0974)
The saturating `float`/`double` -> small integral cast changes from
#128604 were not reflected in two outerloop tests, breaking CI (see
#130962 (comment)).
----------
`JIT/Regression/CLR-x86-JIT/V1-M10/b05617`: under saturation `conv.u1`
of `2.564783e7` now yields `255` (was `214`) and `conv.i1` of
`5246667200` yields `127` (was `-1`). Propagating through the stack, the
final `conv.u4` constant is updated `4294967086` -> `4294967043` so the
test still returns `100`. Mono still truncates, so the test is marked
unsupported on Mono, referencing the same tracking issue (#100368) used
by the JIT regression test in #128604.
----------
`JIT/IL_Conformance/Convert/TestConvertFromIntegral`: the two checked
`ushort.MaxValue -> short` via `Conv_I2` cases now saturate to
`short.MaxValue` on CoreCLR instead of truncating to `-1`. Since the
result is now runtime-divergent (Mono truncates), they are marked
`UnspecifiedBehaviour`, consistent with how every other
cross-runtime-divergent float->integral out-of-range case in this file
is already handled. This keeps the rest of the file running on Mono.
Verified locally against a checked runtime: `b05617` returns `100` and
`TestConvertFromIntegral` reports "All tests passed".
> [!NOTE]
> This PR description was drafted by Copilot.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Jul 18, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-preview7 milestone
Jul 18, 2026
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 17, 2026
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@EgorBoEgorBoEgorBo approved these changes
@radekdoulikradekdoulikradekdoulik approved these changes
@tannergoodingtannergoodingAwaiting requested review from tannergooding

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone

11.0-preview7

Development

Successfully merging this pull request may close these issues.

4 participants

@jakobbotsch@radekdoulik@tannergooding@EgorBo