Skip to content

Disable iOS LibraryMode tests by design, drop tracking-issue reference - #131208

Open
kotlarmilos with Copilot wants to merge 4 commits into
mainfrom
copilot/iosdevicelibrarymodetest
Open

Disable iOS LibraryMode tests by design, drop tracking-issue reference#131208
kotlarmilos with Copilot wants to merge 4 commits into
mainfrom
copilot/iosdevicelibrarymodetest

Conversation

CopilotAI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The iOS.Device/Simulator.LibraryMode.Test projects were excluded from Apple-mobile runs against a tracking issue that is now being closed. Per reviewer feedback, an exclusion should either be fixed, deleted, or marked "by design" without an ActiveIssue reference.

Changes

  • src/libraries/tests.proj: Replaced the <!-- Tracking issue: ... --> comment above the two LibraryModeProjectExclusions with a by-design comment, matching the convention used by other permanent exclusions in this file (e.g. <!-- PNSE -->).
<!-- Library mode is not supported on Apple mobile; excluded by design. Use RunDisablediOSTests=true to run locally. -->
<ProjectExclusionsInclude="$(RepoRoot)/src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj" />
<ProjectExclusionsInclude="$(RepoRoot)/src/tests/FunctionalTests/iOS/Simulator/LibraryMode/iOS.Simulator.LibraryMode.Test.csproj" />

Notes

  • The exclusion items are unchanged: tests remain off by default for Apple mobile and can still be run locally with RunDisablediOSTests=true.
  • This was the only genuine in-repo reference to the issue; the other grep hit (SlhDsaTestData.cs) is a coincidental hex substring in test-vector data.

CopilotAI review requested due to automatic review settings July 22, 2026 12:40

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
CopilotAI review requested due to automatic review settings July 22, 2026 12:46

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

CopilotAI changed the title [WIP] Fix returned code issue in iOS.Device.LibraryMode.TestDisable iOS LibraryMode tests by design, drop tracking-issue referenceJul 22, 2026
CopilotAI requested a review from kotlarmilosJuly 22, 2026 12:46
Comment threadsrc/libraries/tests.proj Outdated
CopilotAI review requested due to automatic review settings July 22, 2026 18:15

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment threadsrc/libraries/tests.proj
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

CopilotAI review requested due to automatic review settings July 28, 2026 14:05

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Comments suppressed due to low confidence (1)

src/libraries/tests.proj:317

  • The updated comment doesn't match the PR description (it omits both the explicit "excluded by design" rationale and the hint for running these tests locally). Consider updating the comment so the intent and local opt-in mechanism are clear and consistent with the PR narrative.
 <!-- Library mode is not supported on Apple mobile -->
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new

Comment on lines 318 to 319
<ProjectExclusions Include="$(RepoRoot)/src/tests/FunctionalTests/iOS/Device/LibraryMode/iOS.Device.LibraryMode.Test.csproj" />
<ProjectExclusions Include="$(RepoRoot)/src/tests/FunctionalTests/iOS/Simulator/LibraryMode/iOS.Simulator.LibraryMode.Test.csproj" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If LibraryMode is not supported and will not be supported, can we just delete the tests instead of carrying around always-disabled tests?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library mode for mobile is basically NativeAOT deployed as a shared library. I think it still has value for mobile targets, but I doubt we really need the functional tests.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what prevents us from fixing the tests so they actually work?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should delete them instead of disabling

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

iOS.Device/Simulator.LibraryMode.Test: failed to determine exit code - RETURN_CODE_NOT_SET

6 participants

@steveisok@akoeplinger@jkoritzinsky@kotlarmilos