[wasm] Fix R2R stackwalk for inline P/Invoke frames and composite-image RVA base by lewing · Pull Request #131243 · dotnet/runtime

lewing · 2026-07-22T23:45:26Z

Summary

Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load, GetExecutingAssembly, …).

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

An R2R inline P/Invoke InlinedCallFrame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP (this infrastructure — the sentinel assignment and InlinedCallFrame::UpdateRegDisplay_Impl — already exists on main). But StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame.

Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant moves from a helpers.cpp#define to a typed static constexpr in frames.h so the stack walker can reference it (existing helpers.cpp uses are unchanged semantically).

2. Composite R2R image RVA base (`codeman.inl`)

JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()), correct for both composite and standalone R2R.

Validation

WASI CoreCLR build (clr -os wasi -c Release): 0W/0E; stackwalk.cpp/helpers.cpp objects recompile clean.
Validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator.

Note

This PR was authored with the assistance of GitHub Copilot.

…ge RVA base Two wasm-only stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load): 1. Inline-P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp): An R2R inline P/Invoke frame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP. StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever. Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant is moved from a helpers.cpp #define into frames.h so the stack walker can reference it. 2. Composite R2R image RVA base (codeman.inl): JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()) so unwind-frame RVAs decode against the correct composite base. Verified: WASI CoreCLR build (clr -os wasi -c Release) 0W/0E; validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

azure-pipelines · 2026-07-22T23:46:05Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-22T23:46:43Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR makes two WebAssembly-only correctness fixes for ReadyToRun (R2R) stack walking: (1) properly handling the sentinel “return address” used by inline P/Invoke frames in R2R, and (2) using the correct image base when mapping unwind RVAs for composite R2R images.

Changes:

Resolve the wasm R2R inline-P/Invoke sentinel return address to a real virtual IP before calling ProcessIp during stack walking.
Move the sentinel constant to a typed static constexpr in frames.h so it’s accessible to stack-walk code.
Fix wasm JitTokenToModuleRVABase to use the R2R image base (not the IL module base) for RANGE_SECTION_VIRTUALIP sections.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Removes the local macro sentinel definition; continues using the sentinel for active inline P/Invoke frames.
src/coreclr/vm/stackwalk.cpp	Adds wasm-specific handling to translate the inline P/Invoke sentinel to a virtual IP prior to `ProcessIp`.
src/coreclr/vm/frames.h	Introduces a typed sentinel constant and declares `GetWasmVirtualIPFromStackPointer` for wasm.
src/coreclr/vm/codeman.inl	Updates wasm virtual-IP RVA base resolution to use the R2R image base address.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

azure-pipelines · 2026-07-23T01:14:11Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

lewing · 2026-07-23T19:52:45Z

/ba-g native-aot infra failures are not related

…ge RVA base (dotnet#131243) ## Summary Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, `GetCallersAssembly`, `Assembly.Load`, `GetExecutingAssembly`, …). ### 1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`) An R2R inline P/Invoke `InlinedCallFrame` carries the sentinel return address `INLINED_PINVOKE_FROM_R2R` (== 1) instead of a real native address; the real caller virtual IP is derived from `m_pCallSiteSP` (this infrastructure — the sentinel assignment and `InlinedCallFrame::UpdateRegDisplay_Impl` — already exists on `main`). But `StackFrameIterator::NextRaw` fed that sentinel straight to `ProcessIp`, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame. Resolve the sentinel to the caller virtual IP via `GetWasmVirtualIPFromStackPointer` before `ProcessIp`, failing the walk (`SWA_FAILED`) if the lookup returns null. The sentinel constant moves from a `helpers.cpp` `#define` to a typed `static constexpr` in `frames.h` so the stack walker can reference it (existing `helpers.cpp` uses are unchanged semantically). ### 2. Composite R2R image RVA base (`codeman.inl`) `JitTokenToModuleRVABase` resolved wasm virtual-IP ranges against the IL module base (`GetModuleBaseAddress()`), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (`ReadyToRunInfo()->GetImage()->GetBase()`), correct for both composite and standalone R2R. ## Validation - WASI CoreCLR build (`clr -os wasi -c Release`): 0W/0E; `stackwalk.cpp`/`helpers.cpp` objects recompile clean. - Validated end-to-end against minimal `Assembly.Load` / `GetExecutingAssembly` R2R repros that previously looped forever in `StackFrameIterator`. > [!NOTE] > This PR was authored with the assistance of GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

lewing · 2026-07-22T23:45:26Z

Summary

Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load, GetExecutingAssembly, …).

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

An R2R inline P/Invoke InlinedCallFrame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP (this infrastructure — the sentinel assignment and InlinedCallFrame::UpdateRegDisplay_Impl — already exists on main). But StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame.

Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant moves from a helpers.cpp#define to a typed static constexpr in frames.h so the stack walker can reference it (existing helpers.cpp uses are unchanged semantically).

2. Composite R2R image RVA base (`codeman.inl`)

JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()), correct for both composite and standalone R2R.

Validation

WASI CoreCLR build (clr -os wasi -c Release): 0W/0E; stackwalk.cpp/helpers.cpp objects recompile clean.
Validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator.

Note

This PR was authored with the assistance of GitHub Copilot.

…ge RVA base Two wasm-only stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load): 1. Inline-P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp): An R2R inline P/Invoke frame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP. StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever. Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant is moved from a helpers.cpp #define into frames.h so the stack walker can reference it. 2. Composite R2R image RVA base (codeman.inl): JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()) so unwind-frame RVAs decode against the correct composite base. Verified: WASI CoreCLR build (clr -os wasi -c Release) 0W/0E; validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

azure-pipelines · 2026-07-22T23:46:05Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-22T23:46:43Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR makes two WebAssembly-only correctness fixes for ReadyToRun (R2R) stack walking: (1) properly handling the sentinel “return address” used by inline P/Invoke frames in R2R, and (2) using the correct image base when mapping unwind RVAs for composite R2R images.

Changes:

Resolve the wasm R2R inline-P/Invoke sentinel return address to a real virtual IP before calling ProcessIp during stack walking.
Move the sentinel constant to a typed static constexpr in frames.h so it’s accessible to stack-walk code.
Fix wasm JitTokenToModuleRVABase to use the R2R image base (not the IL module base) for RANGE_SECTION_VIRTUALIP sections.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Removes the local macro sentinel definition; continues using the sentinel for active inline P/Invoke frames.
src/coreclr/vm/stackwalk.cpp	Adds wasm-specific handling to translate the inline P/Invoke sentinel to a virtual IP prior to `ProcessIp`.
src/coreclr/vm/frames.h	Introduces a typed sentinel constant and declares `GetWasmVirtualIPFromStackPointer` for wasm.
src/coreclr/vm/codeman.inl	Updates wasm virtual-IP RVA base resolution to use the R2R image base address.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

azure-pipelines · 2026-07-23T01:14:11Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

lewing · 2026-07-23T19:52:45Z

/ba-g native-aot infra failures are not related

…ge RVA base (dotnet#131243) ## Summary Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, `GetCallersAssembly`, `Assembly.Load`, `GetExecutingAssembly`, …). ### 1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`) An R2R inline P/Invoke `InlinedCallFrame` carries the sentinel return address `INLINED_PINVOKE_FROM_R2R` (== 1) instead of a real native address; the real caller virtual IP is derived from `m_pCallSiteSP` (this infrastructure — the sentinel assignment and `InlinedCallFrame::UpdateRegDisplay_Impl` — already exists on `main`). But `StackFrameIterator::NextRaw` fed that sentinel straight to `ProcessIp`, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame. Resolve the sentinel to the caller virtual IP via `GetWasmVirtualIPFromStackPointer` before `ProcessIp`, failing the walk (`SWA_FAILED`) if the lookup returns null. The sentinel constant moves from a `helpers.cpp` `#define` to a typed `static constexpr` in `frames.h` so the stack walker can reference it (existing `helpers.cpp` uses are unchanged semantically). ### 2. Composite R2R image RVA base (`codeman.inl`) `JitTokenToModuleRVABase` resolved wasm virtual-IP ranges against the IL module base (`GetModuleBaseAddress()`), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (`ReadyToRunInfo()->GetImage()->GetBase()`), correct for both composite and standalone R2R. ## Validation - WASI CoreCLR build (`clr -os wasi -c Release`): 0W/0E; `stackwalk.cpp`/`helpers.cpp` objects recompile clean. - Validated end-to-end against minimal `Assembly.Load` / `GetExecutingAssembly` R2R repros that previously looped forever in `StackFrameIterator`. > [!NOTE] > This PR was authored with the assistance of GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

lewing · 2026-07-22T23:45:26Z

Summary

Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load, GetExecutingAssembly, …).

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

An R2R inline P/Invoke InlinedCallFrame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP (this infrastructure — the sentinel assignment and InlinedCallFrame::UpdateRegDisplay_Impl — already exists on main). But StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame.

Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant moves from a helpers.cpp#define to a typed static constexpr in frames.h so the stack walker can reference it (existing helpers.cpp uses are unchanged semantically).

2. Composite R2R image RVA base (`codeman.inl`)

JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()), correct for both composite and standalone R2R.

Validation

WASI CoreCLR build (clr -os wasi -c Release): 0W/0E; stackwalk.cpp/helpers.cpp objects recompile clean.
Validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator.

Note

This PR was authored with the assistance of GitHub Copilot.

…ge RVA base Two wasm-only stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load): 1. Inline-P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp): An R2R inline P/Invoke frame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP. StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever. Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant is moved from a helpers.cpp #define into frames.h so the stack walker can reference it. 2. Composite R2R image RVA base (codeman.inl): JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()) so unwind-frame RVAs decode against the correct composite base. Verified: WASI CoreCLR build (clr -os wasi -c Release) 0W/0E; validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

azure-pipelines · 2026-07-22T23:46:05Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-22T23:46:43Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR makes two WebAssembly-only correctness fixes for ReadyToRun (R2R) stack walking: (1) properly handling the sentinel “return address” used by inline P/Invoke frames in R2R, and (2) using the correct image base when mapping unwind RVAs for composite R2R images.

Changes:

Resolve the wasm R2R inline-P/Invoke sentinel return address to a real virtual IP before calling ProcessIp during stack walking.
Move the sentinel constant to a typed static constexpr in frames.h so it’s accessible to stack-walk code.
Fix wasm JitTokenToModuleRVABase to use the R2R image base (not the IL module base) for RANGE_SECTION_VIRTUALIP sections.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Removes the local macro sentinel definition; continues using the sentinel for active inline P/Invoke frames.
src/coreclr/vm/stackwalk.cpp	Adds wasm-specific handling to translate the inline P/Invoke sentinel to a virtual IP prior to `ProcessIp`.
src/coreclr/vm/frames.h	Introduces a typed sentinel constant and declares `GetWasmVirtualIPFromStackPointer` for wasm.
src/coreclr/vm/codeman.inl	Updates wasm virtual-IP RVA base resolution to use the R2R image base address.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

azure-pipelines · 2026-07-23T01:14:11Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

lewing · 2026-07-23T19:52:45Z

/ba-g native-aot infra failures are not related

…ge RVA base (dotnet#131243) ## Summary Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, `GetCallersAssembly`, `Assembly.Load`, `GetExecutingAssembly`, …). ### 1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`) An R2R inline P/Invoke `InlinedCallFrame` carries the sentinel return address `INLINED_PINVOKE_FROM_R2R` (== 1) instead of a real native address; the real caller virtual IP is derived from `m_pCallSiteSP` (this infrastructure — the sentinel assignment and `InlinedCallFrame::UpdateRegDisplay_Impl` — already exists on `main`). But `StackFrameIterator::NextRaw` fed that sentinel straight to `ProcessIp`, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame. Resolve the sentinel to the caller virtual IP via `GetWasmVirtualIPFromStackPointer` before `ProcessIp`, failing the walk (`SWA_FAILED`) if the lookup returns null. The sentinel constant moves from a `helpers.cpp` `#define` to a typed `static constexpr` in `frames.h` so the stack walker can reference it (existing `helpers.cpp` uses are unchanged semantically). ### 2. Composite R2R image RVA base (`codeman.inl`) `JitTokenToModuleRVABase` resolved wasm virtual-IP ranges against the IL module base (`GetModuleBaseAddress()`), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (`ReadyToRunInfo()->GetImage()->GetBase()`), correct for both composite and standalone R2R. ## Validation - WASI CoreCLR build (`clr -os wasi -c Release`): 0W/0E; `stackwalk.cpp`/`helpers.cpp` objects recompile clean. - Validated end-to-end against minimal `Assembly.Load` / `GetExecutingAssembly` R2R repros that previously looped forever in `StackFrameIterator`. > [!NOTE] > This PR was authored with the assistance of GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

lewing · 2026-07-22T23:45:26Z

Summary

Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load, GetExecutingAssembly, …).

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

An R2R inline P/Invoke InlinedCallFrame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP (this infrastructure — the sentinel assignment and InlinedCallFrame::UpdateRegDisplay_Impl — already exists on main). But StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame.

Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant moves from a helpers.cpp#define to a typed static constexpr in frames.h so the stack walker can reference it (existing helpers.cpp uses are unchanged semantically).

2. Composite R2R image RVA base (`codeman.inl`)

JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()), correct for both composite and standalone R2R.

Validation

WASI CoreCLR build (clr -os wasi -c Release): 0W/0E; stackwalk.cpp/helpers.cpp objects recompile clean.
Validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator.

Note

This PR was authored with the assistance of GitHub Copilot.

…ge RVA base Two wasm-only stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load): 1. Inline-P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp): An R2R inline P/Invoke frame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP. StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever. Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant is moved from a helpers.cpp #define into frames.h so the stack walker can reference it. 2. Composite R2R image RVA base (codeman.inl): JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()) so unwind-frame RVAs decode against the correct composite base. Verified: WASI CoreCLR build (clr -os wasi -c Release) 0W/0E; validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

azure-pipelines · 2026-07-22T23:46:05Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-22T23:46:43Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR makes two WebAssembly-only correctness fixes for ReadyToRun (R2R) stack walking: (1) properly handling the sentinel “return address” used by inline P/Invoke frames in R2R, and (2) using the correct image base when mapping unwind RVAs for composite R2R images.

Changes:

Resolve the wasm R2R inline-P/Invoke sentinel return address to a real virtual IP before calling ProcessIp during stack walking.
Move the sentinel constant to a typed static constexpr in frames.h so it’s accessible to stack-walk code.
Fix wasm JitTokenToModuleRVABase to use the R2R image base (not the IL module base) for RANGE_SECTION_VIRTUALIP sections.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Removes the local macro sentinel definition; continues using the sentinel for active inline P/Invoke frames.
src/coreclr/vm/stackwalk.cpp	Adds wasm-specific handling to translate the inline P/Invoke sentinel to a virtual IP prior to `ProcessIp`.
src/coreclr/vm/frames.h	Introduces a typed sentinel constant and declares `GetWasmVirtualIPFromStackPointer` for wasm.
src/coreclr/vm/codeman.inl	Updates wasm virtual-IP RVA base resolution to use the R2R image base address.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

azure-pipelines · 2026-07-23T01:14:11Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

lewing · 2026-07-23T19:52:45Z

/ba-g native-aot infra failures are not related

…ge RVA base (dotnet#131243) ## Summary Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, `GetCallersAssembly`, `Assembly.Load`, `GetExecutingAssembly`, …). ### 1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`) An R2R inline P/Invoke `InlinedCallFrame` carries the sentinel return address `INLINED_PINVOKE_FROM_R2R` (== 1) instead of a real native address; the real caller virtual IP is derived from `m_pCallSiteSP` (this infrastructure — the sentinel assignment and `InlinedCallFrame::UpdateRegDisplay_Impl` — already exists on `main`). But `StackFrameIterator::NextRaw` fed that sentinel straight to `ProcessIp`, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame. Resolve the sentinel to the caller virtual IP via `GetWasmVirtualIPFromStackPointer` before `ProcessIp`, failing the walk (`SWA_FAILED`) if the lookup returns null. The sentinel constant moves from a `helpers.cpp` `#define` to a typed `static constexpr` in `frames.h` so the stack walker can reference it (existing `helpers.cpp` uses are unchanged semantically). ### 2. Composite R2R image RVA base (`codeman.inl`) `JitTokenToModuleRVABase` resolved wasm virtual-IP ranges against the IL module base (`GetModuleBaseAddress()`), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (`ReadyToRunInfo()->GetImage()->GetBase()`), correct for both composite and standalone R2R. ## Validation - WASI CoreCLR build (`clr -os wasi -c Release`): 0W/0E; `stackwalk.cpp`/`helpers.cpp` objects recompile clean. - Validated end-to-end against minimal `Assembly.Load` / `GetExecutingAssembly` R2R repros that previously looped forever in `StackFrameIterator`. > [!NOTE] > This PR was authored with the assistance of GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

lewing · 2026-07-22T23:45:26Z

Summary

Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load, GetExecutingAssembly, …).

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

An R2R inline P/Invoke InlinedCallFrame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP (this infrastructure — the sentinel assignment and InlinedCallFrame::UpdateRegDisplay_Impl — already exists on main). But StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame.

Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant moves from a helpers.cpp#define to a typed static constexpr in frames.h so the stack walker can reference it (existing helpers.cpp uses are unchanged semantically).

2. Composite R2R image RVA base (`codeman.inl`)

JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()), correct for both composite and standalone R2R.

Validation

WASI CoreCLR build (clr -os wasi -c Release): 0W/0E; stackwalk.cpp/helpers.cpp objects recompile clean.
Validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator.

Note

This PR was authored with the assistance of GitHub Copilot.

…ge RVA base Two wasm-only stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load): 1. Inline-P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp): An R2R inline P/Invoke frame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP. StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever. Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant is moved from a helpers.cpp #define into frames.h so the stack walker can reference it. 2. Composite R2R image RVA base (codeman.inl): JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()) so unwind-frame RVAs decode against the correct composite base. Verified: WASI CoreCLR build (clr -os wasi -c Release) 0W/0E; validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

azure-pipelines · 2026-07-22T23:46:05Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-22T23:46:43Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR makes two WebAssembly-only correctness fixes for ReadyToRun (R2R) stack walking: (1) properly handling the sentinel “return address” used by inline P/Invoke frames in R2R, and (2) using the correct image base when mapping unwind RVAs for composite R2R images.

Changes:

Resolve the wasm R2R inline-P/Invoke sentinel return address to a real virtual IP before calling ProcessIp during stack walking.
Move the sentinel constant to a typed static constexpr in frames.h so it’s accessible to stack-walk code.
Fix wasm JitTokenToModuleRVABase to use the R2R image base (not the IL module base) for RANGE_SECTION_VIRTUALIP sections.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Removes the local macro sentinel definition; continues using the sentinel for active inline P/Invoke frames.
src/coreclr/vm/stackwalk.cpp	Adds wasm-specific handling to translate the inline P/Invoke sentinel to a virtual IP prior to `ProcessIp`.
src/coreclr/vm/frames.h	Introduces a typed sentinel constant and declares `GetWasmVirtualIPFromStackPointer` for wasm.
src/coreclr/vm/codeman.inl	Updates wasm virtual-IP RVA base resolution to use the R2R image base address.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

azure-pipelines · 2026-07-23T01:14:11Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

lewing · 2026-07-23T19:52:45Z

/ba-g native-aot infra failures are not related

…ge RVA base (dotnet#131243) ## Summary Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, `GetCallersAssembly`, `Assembly.Load`, `GetExecutingAssembly`, …). ### 1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`) An R2R inline P/Invoke `InlinedCallFrame` carries the sentinel return address `INLINED_PINVOKE_FROM_R2R` (== 1) instead of a real native address; the real caller virtual IP is derived from `m_pCallSiteSP` (this infrastructure — the sentinel assignment and `InlinedCallFrame::UpdateRegDisplay_Impl` — already exists on `main`). But `StackFrameIterator::NextRaw` fed that sentinel straight to `ProcessIp`, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame. Resolve the sentinel to the caller virtual IP via `GetWasmVirtualIPFromStackPointer` before `ProcessIp`, failing the walk (`SWA_FAILED`) if the lookup returns null. The sentinel constant moves from a `helpers.cpp` `#define` to a typed `static constexpr` in `frames.h` so the stack walker can reference it (existing `helpers.cpp` uses are unchanged semantically). ### 2. Composite R2R image RVA base (`codeman.inl`) `JitTokenToModuleRVABase` resolved wasm virtual-IP ranges against the IL module base (`GetModuleBaseAddress()`), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (`ReadyToRunInfo()->GetImage()->GetBase()`), correct for both composite and standalone R2R. ## Validation - WASI CoreCLR build (`clr -os wasi -c Release`): 0W/0E; `stackwalk.cpp`/`helpers.cpp` objects recompile clean. - Validated end-to-end against minimal `Assembly.Load` / `GetExecutingAssembly` R2R repros that previously looped forever in `StackFrameIterator`. > [!NOTE] > This PR was authored with the assistance of GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

lewing · 2026-07-22T23:45:26Z

Summary

Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load, GetExecutingAssembly, …).

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

An R2R inline P/Invoke InlinedCallFrame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP (this infrastructure — the sentinel assignment and InlinedCallFrame::UpdateRegDisplay_Impl — already exists on main). But StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame.

Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant moves from a helpers.cpp#define to a typed static constexpr in frames.h so the stack walker can reference it (existing helpers.cpp uses are unchanged semantically).

2. Composite R2R image RVA base (`codeman.inl`)

JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()), correct for both composite and standalone R2R.

Validation

WASI CoreCLR build (clr -os wasi -c Release): 0W/0E; stackwalk.cpp/helpers.cpp objects recompile clean.
Validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator.

Note

This PR was authored with the assistance of GitHub Copilot.

…ge RVA base Two wasm-only stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load): 1. Inline-P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp): An R2R inline P/Invoke frame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP. StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever. Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant is moved from a helpers.cpp #define into frames.h so the stack walker can reference it. 2. Composite R2R image RVA base (codeman.inl): JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()) so unwind-frame RVAs decode against the correct composite base. Verified: WASI CoreCLR build (clr -os wasi -c Release) 0W/0E; validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

azure-pipelines · 2026-07-22T23:46:05Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-22T23:46:43Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR makes two WebAssembly-only correctness fixes for ReadyToRun (R2R) stack walking: (1) properly handling the sentinel “return address” used by inline P/Invoke frames in R2R, and (2) using the correct image base when mapping unwind RVAs for composite R2R images.

Changes:

Resolve the wasm R2R inline-P/Invoke sentinel return address to a real virtual IP before calling ProcessIp during stack walking.
Move the sentinel constant to a typed static constexpr in frames.h so it’s accessible to stack-walk code.
Fix wasm JitTokenToModuleRVABase to use the R2R image base (not the IL module base) for RANGE_SECTION_VIRTUALIP sections.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Removes the local macro sentinel definition; continues using the sentinel for active inline P/Invoke frames.
src/coreclr/vm/stackwalk.cpp	Adds wasm-specific handling to translate the inline P/Invoke sentinel to a virtual IP prior to `ProcessIp`.
src/coreclr/vm/frames.h	Introduces a typed sentinel constant and declares `GetWasmVirtualIPFromStackPointer` for wasm.
src/coreclr/vm/codeman.inl	Updates wasm virtual-IP RVA base resolution to use the R2R image base address.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

azure-pipelines · 2026-07-23T01:14:11Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

lewing · 2026-07-23T19:52:45Z

/ba-g native-aot infra failures are not related

…ge RVA base (dotnet#131243) ## Summary Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, `GetCallersAssembly`, `Assembly.Load`, `GetExecutingAssembly`, …). ### 1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`) An R2R inline P/Invoke `InlinedCallFrame` carries the sentinel return address `INLINED_PINVOKE_FROM_R2R` (== 1) instead of a real native address; the real caller virtual IP is derived from `m_pCallSiteSP` (this infrastructure — the sentinel assignment and `InlinedCallFrame::UpdateRegDisplay_Impl` — already exists on `main`). But `StackFrameIterator::NextRaw` fed that sentinel straight to `ProcessIp`, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame. Resolve the sentinel to the caller virtual IP via `GetWasmVirtualIPFromStackPointer` before `ProcessIp`, failing the walk (`SWA_FAILED`) if the lookup returns null. The sentinel constant moves from a `helpers.cpp` `#define` to a typed `static constexpr` in `frames.h` so the stack walker can reference it (existing `helpers.cpp` uses are unchanged semantically). ### 2. Composite R2R image RVA base (`codeman.inl`) `JitTokenToModuleRVABase` resolved wasm virtual-IP ranges against the IL module base (`GetModuleBaseAddress()`), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (`ReadyToRunInfo()->GetImage()->GetBase()`), correct for both composite and standalone R2R. ## Validation - WASI CoreCLR build (`clr -os wasi -c Release`): 0W/0E; `stackwalk.cpp`/`helpers.cpp` objects recompile clean. - Validated end-to-end against minimal `Assembly.Load` / `GetExecutingAssembly` R2R repros that previously looped forever in `StackFrameIterator`. > [!NOTE] > This PR was authored with the assistance of GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

lewing · 2026-07-22T23:45:26Z

Summary

Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load, GetExecutingAssembly, …).

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

An R2R inline P/Invoke InlinedCallFrame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP (this infrastructure — the sentinel assignment and InlinedCallFrame::UpdateRegDisplay_Impl — already exists on main). But StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame.

Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant moves from a helpers.cpp#define to a typed static constexpr in frames.h so the stack walker can reference it (existing helpers.cpp uses are unchanged semantically).

2. Composite R2R image RVA base (`codeman.inl`)

JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()), correct for both composite and standalone R2R.

Validation

WASI CoreCLR build (clr -os wasi -c Release): 0W/0E; stackwalk.cpp/helpers.cpp objects recompile clean.
Validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator.

Note

This PR was authored with the assistance of GitHub Copilot.

…ge RVA base Two wasm-only stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load): 1. Inline-P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp): An R2R inline P/Invoke frame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP. StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever. Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant is moved from a helpers.cpp #define into frames.h so the stack walker can reference it. 2. Composite R2R image RVA base (codeman.inl): JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()) so unwind-frame RVAs decode against the correct composite base. Verified: WASI CoreCLR build (clr -os wasi -c Release) 0W/0E; validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

azure-pipelines · 2026-07-22T23:46:05Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-22T23:46:43Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR makes two WebAssembly-only correctness fixes for ReadyToRun (R2R) stack walking: (1) properly handling the sentinel “return address” used by inline P/Invoke frames in R2R, and (2) using the correct image base when mapping unwind RVAs for composite R2R images.

Changes:

Resolve the wasm R2R inline-P/Invoke sentinel return address to a real virtual IP before calling ProcessIp during stack walking.
Move the sentinel constant to a typed static constexpr in frames.h so it’s accessible to stack-walk code.
Fix wasm JitTokenToModuleRVABase to use the R2R image base (not the IL module base) for RANGE_SECTION_VIRTUALIP sections.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Removes the local macro sentinel definition; continues using the sentinel for active inline P/Invoke frames.
src/coreclr/vm/stackwalk.cpp	Adds wasm-specific handling to translate the inline P/Invoke sentinel to a virtual IP prior to `ProcessIp`.
src/coreclr/vm/frames.h	Introduces a typed sentinel constant and declares `GetWasmVirtualIPFromStackPointer` for wasm.
src/coreclr/vm/codeman.inl	Updates wasm virtual-IP RVA base resolution to use the R2R image base address.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

azure-pipelines · 2026-07-23T01:14:11Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

lewing · 2026-07-23T19:52:45Z

/ba-g native-aot infra failures are not related

…ge RVA base (dotnet#131243) ## Summary Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, `GetCallersAssembly`, `Assembly.Load`, `GetExecutingAssembly`, …). ### 1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`) An R2R inline P/Invoke `InlinedCallFrame` carries the sentinel return address `INLINED_PINVOKE_FROM_R2R` (== 1) instead of a real native address; the real caller virtual IP is derived from `m_pCallSiteSP` (this infrastructure — the sentinel assignment and `InlinedCallFrame::UpdateRegDisplay_Impl` — already exists on `main`). But `StackFrameIterator::NextRaw` fed that sentinel straight to `ProcessIp`, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame. Resolve the sentinel to the caller virtual IP via `GetWasmVirtualIPFromStackPointer` before `ProcessIp`, failing the walk (`SWA_FAILED`) if the lookup returns null. The sentinel constant moves from a `helpers.cpp` `#define` to a typed `static constexpr` in `frames.h` so the stack walker can reference it (existing `helpers.cpp` uses are unchanged semantically). ### 2. Composite R2R image RVA base (`codeman.inl`) `JitTokenToModuleRVABase` resolved wasm virtual-IP ranges against the IL module base (`GetModuleBaseAddress()`), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (`ReadyToRunInfo()->GetImage()->GetBase()`), correct for both composite and standalone R2R. ## Validation - WASI CoreCLR build (`clr -os wasi -c Release`): 0W/0E; `stackwalk.cpp`/`helpers.cpp` objects recompile clean. - Validated end-to-end against minimal `Assembly.Load` / `GetExecutingAssembly` R2R repros that previously looped forever in `StackFrameIterator`. > [!NOTE] > This PR was authored with the assistance of GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

lewing · 2026-07-22T23:45:26Z

Summary

Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load, GetExecutingAssembly, …).

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

An R2R inline P/Invoke InlinedCallFrame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP (this infrastructure — the sentinel assignment and InlinedCallFrame::UpdateRegDisplay_Impl — already exists on main). But StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame.

Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant moves from a helpers.cpp#define to a typed static constexpr in frames.h so the stack walker can reference it (existing helpers.cpp uses are unchanged semantically).

2. Composite R2R image RVA base (`codeman.inl`)

JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()), correct for both composite and standalone R2R.

Validation

WASI CoreCLR build (clr -os wasi -c Release): 0W/0E; stackwalk.cpp/helpers.cpp objects recompile clean.
Validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator.

Note

This PR was authored with the assistance of GitHub Copilot.

…ge RVA base Two wasm-only stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, GetCallersAssembly, Assembly.Load): 1. Inline-P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp): An R2R inline P/Invoke frame carries the sentinel return address INLINED_PINVOKE_FROM_R2R (== 1) instead of a real native address; the real caller virtual IP is derived from m_pCallSiteSP. StackFrameIterator::NextRaw fed that sentinel straight to ProcessIp, which cannot recognize it as managed code, so the same active frame repeated forever. Resolve the sentinel to the caller virtual IP via GetWasmVirtualIPFromStackPointer before ProcessIp, failing the walk (SWA_FAILED) if the lookup returns null. The sentinel constant is moved from a helpers.cpp #define into frames.h so the stack walker can reference it. 2. Composite R2R image RVA base (codeman.inl): JitTokenToModuleRVABase resolved wasm virtual-IP ranges against the IL module base (GetModuleBaseAddress()), which is wrong for a composite R2R (WbIL) image. Use the R2R image base (ReadyToRunInfo()->GetImage()->GetBase()) so unwind-frame RVAs decode against the correct composite base. Verified: WASI CoreCLR build (clr -os wasi -c Release) 0W/0E; validated end-to-end against minimal Assembly.Load / GetExecutingAssembly R2R repros that previously looped forever in StackFrameIterator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

azure-pipelines · 2026-07-22T23:46:05Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-22T23:46:43Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR makes two WebAssembly-only correctness fixes for ReadyToRun (R2R) stack walking: (1) properly handling the sentinel “return address” used by inline P/Invoke frames in R2R, and (2) using the correct image base when mapping unwind RVAs for composite R2R images.

Changes:

Resolve the wasm R2R inline-P/Invoke sentinel return address to a real virtual IP before calling ProcessIp during stack walking.
Move the sentinel constant to a typed static constexpr in frames.h so it’s accessible to stack-walk code.
Fix wasm JitTokenToModuleRVABase to use the R2R image base (not the IL module base) for RANGE_SECTION_VIRTUALIP sections.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/vm/wasm/helpers.cpp	Removes the local macro sentinel definition; continues using the sentinel for active inline P/Invoke frames.
src/coreclr/vm/stackwalk.cpp	Adds wasm-specific handling to translate the inline P/Invoke sentinel to a virtual IP prior to `ProcessIp`.
src/coreclr/vm/frames.h	Introduces a typed sentinel constant and declares `GetWasmVirtualIPFromStackPointer` for wasm.
src/coreclr/vm/codeman.inl	Updates wasm virtual-IP RVA base resolution to use the R2R image base address.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

azure-pipelines · 2026-07-23T01:14:11Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

lewing · 2026-07-23T19:52:45Z

/ba-g native-aot infra failures are not related

…ge RVA base (dotnet#131243) ## Summary Two wasm-only R2R stackwalk correctness fixes, needed once R2R-compiled managed code participates in a stackwalk (exception unwind, `GetCallersAssembly`, `Assembly.Load`, `GetExecutingAssembly`, …). ### 1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`) An R2R inline P/Invoke `InlinedCallFrame` carries the sentinel return address `INLINED_PINVOKE_FROM_R2R` (== 1) instead of a real native address; the real caller virtual IP is derived from `m_pCallSiteSP` (this infrastructure — the sentinel assignment and `InlinedCallFrame::UpdateRegDisplay_Impl` — already exists on `main`). But `StackFrameIterator::NextRaw` fed that sentinel straight to `ProcessIp`, which cannot recognize it as managed code, so the same active frame repeated forever — an infinite loop in any stackwalk that crosses an R2R inline-P/Invoke frame. Resolve the sentinel to the caller virtual IP via `GetWasmVirtualIPFromStackPointer` before `ProcessIp`, failing the walk (`SWA_FAILED`) if the lookup returns null. The sentinel constant moves from a `helpers.cpp` `#define` to a typed `static constexpr` in `frames.h` so the stack walker can reference it (existing `helpers.cpp` uses are unchanged semantically). ### 2. Composite R2R image RVA base (`codeman.inl`) `JitTokenToModuleRVABase` resolved wasm virtual-IP ranges against the IL module base (`GetModuleBaseAddress()`), which is wrong for a composite R2R (WbIL) image — unwind-frame RVAs decoded against the wrong base. Use the R2R image base (`ReadyToRunInfo()->GetImage()->GetBase()`), correct for both composite and standalone R2R. ## Validation - WASI CoreCLR build (`clr -os wasi -c Release`): 0W/0E; `stackwalk.cpp`/`helpers.cpp` objects recompile clean. - Validated end-to-end against minimal `Assembly.Load` / `GetExecutingAssembly` R2R repros that previously looped forever in `StackFrameIterator`. > [!NOTE] > This PR was authored with the assistance of GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: 2902374a-f352-4c46-bcec-8a35c97733ae

CopilotAI review requested due to automatic review settings July 22, 2026 23:45

github-actionsBot added the area-VM-coreclr label Jul 22, 2026

dotnet-policy-serviceBot assigned lewing Jul 22, 2026

Copilotstarted reviewing on behalf of lewing July 22, 2026 23:45 View session

CopilotAI reviewed Jul 22, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp Outdated

Potential fix for pull request finding
93836f4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 23, 2026 00:02

Copilotstarted reviewing on behalf of lewing July 23, 2026 00:02 View session

lewing requested a review from davidwrighton July 23, 2026 00:03

CopilotAI reviewed Jul 23, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp

lewing requested a review from AndyAyersMS July 23, 2026 01:07

lewing marked this pull request as ready for review July 23, 2026 01:13

This was referenced Jul 23, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

Merge branch 'main' into wasi-r2r-stackwalk-rva
ba75095

CopilotAI review requested due to automatic review settings July 23, 2026 15:11

Copilotstarted reviewing on behalf of lewing July 23, 2026 15:11 View session

CopilotAI reviewed Jul 23, 2026
View reviewed changes

davidwrighton approved these changes Jul 23, 2026
View reviewed changes

lewing enabled auto-merge (squash) July 23, 2026 17:31

lewing merged commit 309ac56 into dotnet:mainJul 23, 2026
118 of 127 checks passed

dotnet-maestroBot mentioned this pull request Jul 24, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7872
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Jul 24, 2026

lewing mentioned this pull request Aug 2, 2026
Wasm: stop R2R stack walk at reverse-pinvoke frames #131668
Merged

github-actionsBot locked and limited conversation to collaborators Aug 23, 2026

CopilotAI review requested due to automatic review settings July 22, 2026 23:45

github-actionsBot added the area-VM-coreclr label Jul 22, 2026

dotnet-policy-serviceBot assigned lewing Jul 22, 2026

Copilotstarted reviewing on behalf of lewing July 22, 2026 23:45 View session

CopilotAI reviewed Jul 22, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp Outdated

Potential fix for pull request finding
93836f4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 23, 2026 00:02

Copilotstarted reviewing on behalf of lewing July 23, 2026 00:02 View session

lewing requested a review from davidwrighton July 23, 2026 00:03

CopilotAI reviewed Jul 23, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp

lewing requested a review from AndyAyersMS July 23, 2026 01:07

lewing marked this pull request as ready for review July 23, 2026 01:13

This was referenced Jul 23, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

Merge branch 'main' into wasi-r2r-stackwalk-rva
ba75095

CopilotAI review requested due to automatic review settings July 23, 2026 15:11

Copilotstarted reviewing on behalf of lewing July 23, 2026 15:11 View session

CopilotAI reviewed Jul 23, 2026
View reviewed changes

davidwrighton approved these changes Jul 23, 2026
View reviewed changes

lewing enabled auto-merge (squash) July 23, 2026 17:31

lewing merged commit 309ac56 into dotnet:mainJul 23, 2026
118 of 127 checks passed

dotnet-maestroBot mentioned this pull request Jul 24, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7872
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Jul 24, 2026

lewing mentioned this pull request Aug 2, 2026
Wasm: stop R2R stack walk at reverse-pinvoke frames #131668
Merged

github-actionsBot locked and limited conversation to collaborators Aug 23, 2026

CopilotAI review requested due to automatic review settings July 22, 2026 23:45

github-actionsBot added the area-VM-coreclr label Jul 22, 2026

dotnet-policy-serviceBot assigned lewing Jul 22, 2026

Copilotstarted reviewing on behalf of lewing July 22, 2026 23:45 View session

CopilotAI reviewed Jul 22, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp Outdated

Potential fix for pull request finding
93836f4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 23, 2026 00:02

Copilotstarted reviewing on behalf of lewing July 23, 2026 00:02 View session

lewing requested a review from davidwrighton July 23, 2026 00:03

CopilotAI reviewed Jul 23, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp

lewing requested a review from AndyAyersMS July 23, 2026 01:07

lewing marked this pull request as ready for review July 23, 2026 01:13

This was referenced Jul 23, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

Merge branch 'main' into wasi-r2r-stackwalk-rva
ba75095

CopilotAI review requested due to automatic review settings July 23, 2026 15:11

Copilotstarted reviewing on behalf of lewing July 23, 2026 15:11 View session

CopilotAI reviewed Jul 23, 2026
View reviewed changes

davidwrighton approved these changes Jul 23, 2026
View reviewed changes

lewing enabled auto-merge (squash) July 23, 2026 17:31

lewing merged commit 309ac56 into dotnet:mainJul 23, 2026
118 of 127 checks passed

dotnet-maestroBot mentioned this pull request Jul 24, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7872
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Jul 24, 2026

lewing mentioned this pull request Aug 2, 2026
Wasm: stop R2R stack walk at reverse-pinvoke frames #131668
Merged

github-actionsBot locked and limited conversation to collaborators Aug 23, 2026

CopilotAI review requested due to automatic review settings July 22, 2026 23:45

github-actionsBot added the area-VM-coreclr label Jul 22, 2026

dotnet-policy-serviceBot assigned lewing Jul 22, 2026

Copilotstarted reviewing on behalf of lewing July 22, 2026 23:45 View session

CopilotAI reviewed Jul 22, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp Outdated

Potential fix for pull request finding
93836f4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 23, 2026 00:02

Copilotstarted reviewing on behalf of lewing July 23, 2026 00:02 View session

lewing requested a review from davidwrighton July 23, 2026 00:03

CopilotAI reviewed Jul 23, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp

lewing requested a review from AndyAyersMS July 23, 2026 01:07

lewing marked this pull request as ready for review July 23, 2026 01:13

This was referenced Jul 23, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

Merge branch 'main' into wasi-r2r-stackwalk-rva
ba75095

CopilotAI review requested due to automatic review settings July 23, 2026 15:11

Copilotstarted reviewing on behalf of lewing July 23, 2026 15:11 View session

CopilotAI reviewed Jul 23, 2026
View reviewed changes

davidwrighton approved these changes Jul 23, 2026
View reviewed changes

lewing enabled auto-merge (squash) July 23, 2026 17:31

lewing merged commit 309ac56 into dotnet:mainJul 23, 2026
118 of 127 checks passed

dotnet-maestroBot mentioned this pull request Jul 24, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7872
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Jul 24, 2026

lewing mentioned this pull request Aug 2, 2026
Wasm: stop R2R stack walk at reverse-pinvoke frames #131668
Merged

github-actionsBot locked and limited conversation to collaborators Aug 23, 2026

CopilotAI review requested due to automatic review settings July 22, 2026 23:45

github-actionsBot added the area-VM-coreclr label Jul 22, 2026

dotnet-policy-serviceBot assigned lewing Jul 22, 2026

Copilotstarted reviewing on behalf of lewing July 22, 2026 23:45 View session

CopilotAI reviewed Jul 22, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp Outdated

Potential fix for pull request finding
93836f4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 23, 2026 00:02

Copilotstarted reviewing on behalf of lewing July 23, 2026 00:02 View session

lewing requested a review from davidwrighton July 23, 2026 00:03

CopilotAI reviewed Jul 23, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp

lewing requested a review from AndyAyersMS July 23, 2026 01:07

lewing marked this pull request as ready for review July 23, 2026 01:13

This was referenced Jul 23, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

Merge branch 'main' into wasi-r2r-stackwalk-rva
ba75095

CopilotAI review requested due to automatic review settings July 23, 2026 15:11

Copilotstarted reviewing on behalf of lewing July 23, 2026 15:11 View session

CopilotAI reviewed Jul 23, 2026
View reviewed changes

davidwrighton approved these changes Jul 23, 2026
View reviewed changes

lewing enabled auto-merge (squash) July 23, 2026 17:31

lewing merged commit 309ac56 into dotnet:mainJul 23, 2026
118 of 127 checks passed

dotnet-maestroBot mentioned this pull request Jul 24, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7872
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Jul 24, 2026

lewing mentioned this pull request Aug 2, 2026
Wasm: stop R2R stack walk at reverse-pinvoke frames #131668
Merged

github-actionsBot locked and limited conversation to collaborators Aug 23, 2026

CopilotAI review requested due to automatic review settings July 22, 2026 23:45

github-actionsBot added the area-VM-coreclr label Jul 22, 2026

dotnet-policy-serviceBot assigned lewing Jul 22, 2026

Copilotstarted reviewing on behalf of lewing July 22, 2026 23:45 View session

CopilotAI reviewed Jul 22, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp Outdated

Potential fix for pull request finding
93836f4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 23, 2026 00:02

Copilotstarted reviewing on behalf of lewing July 23, 2026 00:02 View session

lewing requested a review from davidwrighton July 23, 2026 00:03

CopilotAI reviewed Jul 23, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp

lewing requested a review from AndyAyersMS July 23, 2026 01:07

lewing marked this pull request as ready for review July 23, 2026 01:13

This was referenced Jul 23, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

Merge branch 'main' into wasi-r2r-stackwalk-rva
ba75095

CopilotAI review requested due to automatic review settings July 23, 2026 15:11

Copilotstarted reviewing on behalf of lewing July 23, 2026 15:11 View session

CopilotAI reviewed Jul 23, 2026
View reviewed changes

davidwrighton approved these changes Jul 23, 2026
View reviewed changes

lewing enabled auto-merge (squash) July 23, 2026 17:31

lewing merged commit 309ac56 into dotnet:mainJul 23, 2026
118 of 127 checks passed

dotnet-maestroBot mentioned this pull request Jul 24, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7872
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Jul 24, 2026

lewing mentioned this pull request Aug 2, 2026
Wasm: stop R2R stack walk at reverse-pinvoke frames #131668
Merged

github-actionsBot locked and limited conversation to collaborators Aug 23, 2026

CopilotAI review requested due to automatic review settings July 22, 2026 23:45

github-actionsBot added the area-VM-coreclr label Jul 22, 2026

dotnet-policy-serviceBot assigned lewing Jul 22, 2026

Copilotstarted reviewing on behalf of lewing July 22, 2026 23:45 View session

CopilotAI reviewed Jul 22, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp Outdated

Potential fix for pull request finding
93836f4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 23, 2026 00:02

Copilotstarted reviewing on behalf of lewing July 23, 2026 00:02 View session

lewing requested a review from davidwrighton July 23, 2026 00:03

CopilotAI reviewed Jul 23, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp

lewing requested a review from AndyAyersMS July 23, 2026 01:07

lewing marked this pull request as ready for review July 23, 2026 01:13

This was referenced Jul 23, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

Merge branch 'main' into wasi-r2r-stackwalk-rva
ba75095

CopilotAI review requested due to automatic review settings July 23, 2026 15:11

Copilotstarted reviewing on behalf of lewing July 23, 2026 15:11 View session

CopilotAI reviewed Jul 23, 2026
View reviewed changes

davidwrighton approved these changes Jul 23, 2026
View reviewed changes

lewing enabled auto-merge (squash) July 23, 2026 17:31

lewing merged commit 309ac56 into dotnet:mainJul 23, 2026
118 of 127 checks passed

dotnet-maestroBot mentioned this pull request Jul 24, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7872
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Jul 24, 2026

lewing mentioned this pull request Aug 2, 2026
Wasm: stop R2R stack walk at reverse-pinvoke frames #131668
Merged

github-actionsBot locked and limited conversation to collaborators Aug 23, 2026

CopilotAI review requested due to automatic review settings July 22, 2026 23:45

github-actionsBot added the area-VM-coreclr label Jul 22, 2026

dotnet-policy-serviceBot assigned lewing Jul 22, 2026

Copilotstarted reviewing on behalf of lewing July 22, 2026 23:45 View session

CopilotAI reviewed Jul 22, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp Outdated

Potential fix for pull request finding
93836f4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CopilotAI review requested due to automatic review settings July 23, 2026 00:02

Copilotstarted reviewing on behalf of lewing July 23, 2026 00:02 View session

lewing requested a review from davidwrighton July 23, 2026 00:03

CopilotAI reviewed Jul 23, 2026
View reviewed changes

Comment threadsrc/coreclr/vm/stackwalk.cpp

lewing requested a review from AndyAyersMS July 23, 2026 01:07

lewing marked this pull request as ready for review July 23, 2026 01:13

This was referenced Jul 23, 2026
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

Merge branch 'main' into wasi-r2r-stackwalk-rva
ba75095

CopilotAI review requested due to automatic review settings July 23, 2026 15:11

Copilotstarted reviewing on behalf of lewing July 23, 2026 15:11 View session

CopilotAI reviewed Jul 23, 2026
View reviewed changes

davidwrighton approved these changes Jul 23, 2026
View reviewed changes

lewing enabled auto-merge (squash) July 23, 2026 17:31

lewing merged commit 309ac56 into dotnet:mainJul 23, 2026
118 of 127 checks passed

dotnet-maestroBot mentioned this pull request Jul 24, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#7872
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Jul 24, 2026

lewing mentioned this pull request Aug 2, 2026
Wasm: stop R2R stack walk at reverse-pinvoke frames #131668
Merged

github-actionsBot locked and limited conversation to collaborators Aug 23, 2026

Uh oh!

Conversation

lewing commented Jul 22, 2026

Summary

1. Inline P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp)

2. Composite R2R image RVA base (codeman.inl)

Validation

Uh oh!

azure-pipelinesBot commented Jul 22, 2026

Uh oh!

dotnet-policy-serviceBot commented Jul 22, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

azure-pipelinesBot commented Jul 23, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

lewing commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lewing commented Jul 22, 2026

Summary

1. Inline P/Invoke sentinel resolution (stackwalk.cpp, frames.h, helpers.cpp)

2. Composite R2R image RVA base (codeman.inl)

Validation

Uh oh!

azure-pipelinesBot commented Jul 22, 2026

Uh oh!

dotnet-policy-serviceBot commented Jul 22, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

azure-pipelinesBot commented Jul 23, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

lewing commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

2. Composite R2R image RVA base (`codeman.inl`)

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

2. Composite R2R image RVA base (`codeman.inl`)

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

2. Composite R2R image RVA base (`codeman.inl`)

1. Inline P/Invoke sentinel resolution (`stackwalk.cpp`, `frames.h`, `helpers.cpp`)

2. Composite R2R image RVA base (`codeman.inl`)