Replace more strcpy with safe string copy by am11 · Pull Request #131308 · dotnet/runtime

am11 · 2026-07-24T09:43:29Z

Follow up #130547.

azure-pipelines · 2026-07-24T09:44:18Z

Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-24T09:44:57Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-07-24T09:51:42Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


What guarantees that parent_directory_end has enough space? This pattern is likely to trigger static analyzers.
(not commenting on all places with this issue)

It's same guarantees as before; none.

The PR title is "Replace more strcpy with safe string copy". Why is this safe string copy then?

strcpy -> memcpy/strcpy_s, because strcpy is being flagged by clang on OpenBSD warning: strcpy() is almost always misused, please use strlcpy().

I think Jan's point is that if we're changing this code at all, we should change it to something better, not to something that has the same problem and is somewhat harder to read than the original.

Not sure how it is harder to read than original given #130547 is merged?

I was fine with #130547 since it was an open-coded strdup, no length arithmetic, length is computed on one line and used a few lines later in a very straightforward way. In hindsight, I should have suggested to just use strdup instead of open coding it. We use strdup in number of other places. Could you please replace it with strdup as part of these changes?
This code is not a straightforward like that.
We have SafeStringCopy in pal_utilities.h to solve this problem. Can we promote it or some variant of it to be usable everywhere? Would it be possible to standardize on strcpy_s and polyfill strcpy_s when it is not available - do we build on any platforms like that?

am11 · 2026-07-24T15:50:37Z

BA failure is #131256.

Copilot

Pull request overview

This PR continues the effort to eliminate strcpy usage across CoreCLR, NativeAOT, and related tools by replacing it with length-aware copies (primarily memcpy) and minor refactors to compute/carry explicit buffer lengths.

Changes:

Replaced multiple strcpy call sites with memcpy (often using strlen(...) + 1) across VM/JIT/GC/NativeAOT/host/tooling code.
Introduced explicit length variables in a few places to make copy sizes clearer and avoid repeated strlen in allocation/copy sequences.
Added a couple of small robustness tweaks (e.g., guarding malloc results before copying in corerun.cpp).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/gdbjit.cpp	Replaces `strcpy` with `memcpy` in GDB JIT debug-info string materialization paths.
src/coreclr/utilcode/debug.cpp	Replaces `strcpy` with `memcpy` when building the assert expression+stacktrace display buffer.
src/coreclr/utilcode/check.cpp	Uses `memcpy` for copying dynamically allocated CHECK failure messages.
src/coreclr/nativeaot/Runtime/unix/PalUnix.cpp	Uses computed length + `memcpy` in `PalCopyTCharAsChar`.
src/coreclr/nativeaot/Runtime/unix/cgroupcpu.cpp	Reworks cgroup path construction to use explicit lengths and `memcpy` instead of `strcpy`/`strcat`.
src/coreclr/nativeaot/Runtime/RhConfig.cpp	Refactors env-var name construction and switches embedded string copies to `memcpy`.
src/coreclr/nativeaot/Runtime/clrgc.enabled.cpp	Replaces `strcpy` concatenation with length-based `memcpy` copies.
src/coreclr/jit/fgdiagnostic.cpp	Replaces `strcpy` with `memcpy` in escape-substitution copying.
src/coreclr/interpreter/methodset.cpp	Copies config string via `memcpy` instead of `strcpy`.
src/coreclr/inc/outstring.h	Updates `<string.h>` include comment (no longer calls out `strcpy`).
src/coreclr/ildasm/dres.cpp	Replaces `strcat`/`strcpy` usage with manual `memcpy` for indentation/string building in resource dumping.
src/coreclr/ilasm/method.hpp	Updates commented-out code to reference `strcpy_s`.
src/coreclr/hosts/corerun/corerun.cpp	Uses length-based `memcpy` and guards `malloc` before copying core paths.
src/coreclr/gc/unix/cgroup.cpp	Uses mount-length caching + `memcpy` for initial copy and replaces a `strcpy` with `memcpy`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

janvorli · 2026-07-24T14:07:14Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


Do we gain anything here when the source is a string constant?

am11 · 2026-07-24T09:43:29Z

Follow up #130547.

azure-pipelines · 2026-07-24T09:44:18Z

Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-24T09:44:57Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-07-24T09:51:42Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


What guarantees that parent_directory_end has enough space? This pattern is likely to trigger static analyzers.
(not commenting on all places with this issue)

It's same guarantees as before; none.

The PR title is "Replace more strcpy with safe string copy". Why is this safe string copy then?

strcpy -> memcpy/strcpy_s, because strcpy is being flagged by clang on OpenBSD warning: strcpy() is almost always misused, please use strlcpy().

I think Jan's point is that if we're changing this code at all, we should change it to something better, not to something that has the same problem and is somewhat harder to read than the original.

Not sure how it is harder to read than original given #130547 is merged?

I was fine with #130547 since it was an open-coded strdup, no length arithmetic, length is computed on one line and used a few lines later in a very straightforward way. In hindsight, I should have suggested to just use strdup instead of open coding it. We use strdup in number of other places. Could you please replace it with strdup as part of these changes?
This code is not a straightforward like that.
We have SafeStringCopy in pal_utilities.h to solve this problem. Can we promote it or some variant of it to be usable everywhere? Would it be possible to standardize on strcpy_s and polyfill strcpy_s when it is not available - do we build on any platforms like that?

am11 · 2026-07-24T15:50:37Z

BA failure is #131256.

Copilot

Pull request overview

This PR continues the effort to eliminate strcpy usage across CoreCLR, NativeAOT, and related tools by replacing it with length-aware copies (primarily memcpy) and minor refactors to compute/carry explicit buffer lengths.

Changes:

Replaced multiple strcpy call sites with memcpy (often using strlen(...) + 1) across VM/JIT/GC/NativeAOT/host/tooling code.
Introduced explicit length variables in a few places to make copy sizes clearer and avoid repeated strlen in allocation/copy sequences.
Added a couple of small robustness tweaks (e.g., guarding malloc results before copying in corerun.cpp).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/gdbjit.cpp	Replaces `strcpy` with `memcpy` in GDB JIT debug-info string materialization paths.
src/coreclr/utilcode/debug.cpp	Replaces `strcpy` with `memcpy` when building the assert expression+stacktrace display buffer.
src/coreclr/utilcode/check.cpp	Uses `memcpy` for copying dynamically allocated CHECK failure messages.
src/coreclr/nativeaot/Runtime/unix/PalUnix.cpp	Uses computed length + `memcpy` in `PalCopyTCharAsChar`.
src/coreclr/nativeaot/Runtime/unix/cgroupcpu.cpp	Reworks cgroup path construction to use explicit lengths and `memcpy` instead of `strcpy`/`strcat`.
src/coreclr/nativeaot/Runtime/RhConfig.cpp	Refactors env-var name construction and switches embedded string copies to `memcpy`.
src/coreclr/nativeaot/Runtime/clrgc.enabled.cpp	Replaces `strcpy` concatenation with length-based `memcpy` copies.
src/coreclr/jit/fgdiagnostic.cpp	Replaces `strcpy` with `memcpy` in escape-substitution copying.
src/coreclr/interpreter/methodset.cpp	Copies config string via `memcpy` instead of `strcpy`.
src/coreclr/inc/outstring.h	Updates `<string.h>` include comment (no longer calls out `strcpy`).
src/coreclr/ildasm/dres.cpp	Replaces `strcat`/`strcpy` usage with manual `memcpy` for indentation/string building in resource dumping.
src/coreclr/ilasm/method.hpp	Updates commented-out code to reference `strcpy_s`.
src/coreclr/hosts/corerun/corerun.cpp	Uses length-based `memcpy` and guards `malloc` before copying core paths.
src/coreclr/gc/unix/cgroup.cpp	Uses mount-length caching + `memcpy` for initial copy and replaces a `strcpy` with `memcpy`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

janvorli · 2026-07-24T14:07:14Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


Do we gain anything here when the source is a string constant?

am11 · 2026-07-24T09:43:29Z

Follow up #130547.

azure-pipelines · 2026-07-24T09:44:18Z

Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-24T09:44:57Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-07-24T09:51:42Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


What guarantees that parent_directory_end has enough space? This pattern is likely to trigger static analyzers.
(not commenting on all places with this issue)

It's same guarantees as before; none.

The PR title is "Replace more strcpy with safe string copy". Why is this safe string copy then?

strcpy -> memcpy/strcpy_s, because strcpy is being flagged by clang on OpenBSD warning: strcpy() is almost always misused, please use strlcpy().

I think Jan's point is that if we're changing this code at all, we should change it to something better, not to something that has the same problem and is somewhat harder to read than the original.

Not sure how it is harder to read than original given #130547 is merged?

I was fine with #130547 since it was an open-coded strdup, no length arithmetic, length is computed on one line and used a few lines later in a very straightforward way. In hindsight, I should have suggested to just use strdup instead of open coding it. We use strdup in number of other places. Could you please replace it with strdup as part of these changes?
This code is not a straightforward like that.
We have SafeStringCopy in pal_utilities.h to solve this problem. Can we promote it or some variant of it to be usable everywhere? Would it be possible to standardize on strcpy_s and polyfill strcpy_s when it is not available - do we build on any platforms like that?

am11 · 2026-07-24T15:50:37Z

BA failure is #131256.

Copilot

Pull request overview

This PR continues the effort to eliminate strcpy usage across CoreCLR, NativeAOT, and related tools by replacing it with length-aware copies (primarily memcpy) and minor refactors to compute/carry explicit buffer lengths.

Changes:

Replaced multiple strcpy call sites with memcpy (often using strlen(...) + 1) across VM/JIT/GC/NativeAOT/host/tooling code.
Introduced explicit length variables in a few places to make copy sizes clearer and avoid repeated strlen in allocation/copy sequences.
Added a couple of small robustness tweaks (e.g., guarding malloc results before copying in corerun.cpp).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/gdbjit.cpp	Replaces `strcpy` with `memcpy` in GDB JIT debug-info string materialization paths.
src/coreclr/utilcode/debug.cpp	Replaces `strcpy` with `memcpy` when building the assert expression+stacktrace display buffer.
src/coreclr/utilcode/check.cpp	Uses `memcpy` for copying dynamically allocated CHECK failure messages.
src/coreclr/nativeaot/Runtime/unix/PalUnix.cpp	Uses computed length + `memcpy` in `PalCopyTCharAsChar`.
src/coreclr/nativeaot/Runtime/unix/cgroupcpu.cpp	Reworks cgroup path construction to use explicit lengths and `memcpy` instead of `strcpy`/`strcat`.
src/coreclr/nativeaot/Runtime/RhConfig.cpp	Refactors env-var name construction and switches embedded string copies to `memcpy`.
src/coreclr/nativeaot/Runtime/clrgc.enabled.cpp	Replaces `strcpy` concatenation with length-based `memcpy` copies.
src/coreclr/jit/fgdiagnostic.cpp	Replaces `strcpy` with `memcpy` in escape-substitution copying.
src/coreclr/interpreter/methodset.cpp	Copies config string via `memcpy` instead of `strcpy`.
src/coreclr/inc/outstring.h	Updates `<string.h>` include comment (no longer calls out `strcpy`).
src/coreclr/ildasm/dres.cpp	Replaces `strcat`/`strcpy` usage with manual `memcpy` for indentation/string building in resource dumping.
src/coreclr/ilasm/method.hpp	Updates commented-out code to reference `strcpy_s`.
src/coreclr/hosts/corerun/corerun.cpp	Uses length-based `memcpy` and guards `malloc` before copying core paths.
src/coreclr/gc/unix/cgroup.cpp	Uses mount-length caching + `memcpy` for initial copy and replaces a `strcpy` with `memcpy`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

janvorli · 2026-07-24T14:07:14Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


Do we gain anything here when the source is a string constant?

am11 · 2026-07-24T09:43:29Z

Follow up #130547.

azure-pipelines · 2026-07-24T09:44:18Z

Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-24T09:44:57Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-07-24T09:51:42Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


What guarantees that parent_directory_end has enough space? This pattern is likely to trigger static analyzers.
(not commenting on all places with this issue)

It's same guarantees as before; none.

The PR title is "Replace more strcpy with safe string copy". Why is this safe string copy then?

strcpy -> memcpy/strcpy_s, because strcpy is being flagged by clang on OpenBSD warning: strcpy() is almost always misused, please use strlcpy().

I think Jan's point is that if we're changing this code at all, we should change it to something better, not to something that has the same problem and is somewhat harder to read than the original.

Not sure how it is harder to read than original given #130547 is merged?

I was fine with #130547 since it was an open-coded strdup, no length arithmetic, length is computed on one line and used a few lines later in a very straightforward way. In hindsight, I should have suggested to just use strdup instead of open coding it. We use strdup in number of other places. Could you please replace it with strdup as part of these changes?
This code is not a straightforward like that.
We have SafeStringCopy in pal_utilities.h to solve this problem. Can we promote it or some variant of it to be usable everywhere? Would it be possible to standardize on strcpy_s and polyfill strcpy_s when it is not available - do we build on any platforms like that?

am11 · 2026-07-24T15:50:37Z

BA failure is #131256.

Copilot

Pull request overview

This PR continues the effort to eliminate strcpy usage across CoreCLR, NativeAOT, and related tools by replacing it with length-aware copies (primarily memcpy) and minor refactors to compute/carry explicit buffer lengths.

Changes:

Replaced multiple strcpy call sites with memcpy (often using strlen(...) + 1) across VM/JIT/GC/NativeAOT/host/tooling code.
Introduced explicit length variables in a few places to make copy sizes clearer and avoid repeated strlen in allocation/copy sequences.
Added a couple of small robustness tweaks (e.g., guarding malloc results before copying in corerun.cpp).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/gdbjit.cpp	Replaces `strcpy` with `memcpy` in GDB JIT debug-info string materialization paths.
src/coreclr/utilcode/debug.cpp	Replaces `strcpy` with `memcpy` when building the assert expression+stacktrace display buffer.
src/coreclr/utilcode/check.cpp	Uses `memcpy` for copying dynamically allocated CHECK failure messages.
src/coreclr/nativeaot/Runtime/unix/PalUnix.cpp	Uses computed length + `memcpy` in `PalCopyTCharAsChar`.
src/coreclr/nativeaot/Runtime/unix/cgroupcpu.cpp	Reworks cgroup path construction to use explicit lengths and `memcpy` instead of `strcpy`/`strcat`.
src/coreclr/nativeaot/Runtime/RhConfig.cpp	Refactors env-var name construction and switches embedded string copies to `memcpy`.
src/coreclr/nativeaot/Runtime/clrgc.enabled.cpp	Replaces `strcpy` concatenation with length-based `memcpy` copies.
src/coreclr/jit/fgdiagnostic.cpp	Replaces `strcpy` with `memcpy` in escape-substitution copying.
src/coreclr/interpreter/methodset.cpp	Copies config string via `memcpy` instead of `strcpy`.
src/coreclr/inc/outstring.h	Updates `<string.h>` include comment (no longer calls out `strcpy`).
src/coreclr/ildasm/dres.cpp	Replaces `strcat`/`strcpy` usage with manual `memcpy` for indentation/string building in resource dumping.
src/coreclr/ilasm/method.hpp	Updates commented-out code to reference `strcpy_s`.
src/coreclr/hosts/corerun/corerun.cpp	Uses length-based `memcpy` and guards `malloc` before copying core paths.
src/coreclr/gc/unix/cgroup.cpp	Uses mount-length caching + `memcpy` for initial copy and replaces a `strcpy` with `memcpy`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

janvorli · 2026-07-24T14:07:14Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


Do we gain anything here when the source is a string constant?

am11 · 2026-07-24T09:43:29Z

Follow up #130547.

azure-pipelines · 2026-07-24T09:44:18Z

Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-24T09:44:57Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-07-24T09:51:42Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


What guarantees that parent_directory_end has enough space? This pattern is likely to trigger static analyzers.
(not commenting on all places with this issue)

It's same guarantees as before; none.

The PR title is "Replace more strcpy with safe string copy". Why is this safe string copy then?

strcpy -> memcpy/strcpy_s, because strcpy is being flagged by clang on OpenBSD warning: strcpy() is almost always misused, please use strlcpy().

I think Jan's point is that if we're changing this code at all, we should change it to something better, not to something that has the same problem and is somewhat harder to read than the original.

Not sure how it is harder to read than original given #130547 is merged?

I was fine with #130547 since it was an open-coded strdup, no length arithmetic, length is computed on one line and used a few lines later in a very straightforward way. In hindsight, I should have suggested to just use strdup instead of open coding it. We use strdup in number of other places. Could you please replace it with strdup as part of these changes?
This code is not a straightforward like that.
We have SafeStringCopy in pal_utilities.h to solve this problem. Can we promote it or some variant of it to be usable everywhere? Would it be possible to standardize on strcpy_s and polyfill strcpy_s when it is not available - do we build on any platforms like that?

am11 · 2026-07-24T15:50:37Z

BA failure is #131256.

Copilot

Pull request overview

This PR continues the effort to eliminate strcpy usage across CoreCLR, NativeAOT, and related tools by replacing it with length-aware copies (primarily memcpy) and minor refactors to compute/carry explicit buffer lengths.

Changes:

Replaced multiple strcpy call sites with memcpy (often using strlen(...) + 1) across VM/JIT/GC/NativeAOT/host/tooling code.
Introduced explicit length variables in a few places to make copy sizes clearer and avoid repeated strlen in allocation/copy sequences.
Added a couple of small robustness tweaks (e.g., guarding malloc results before copying in corerun.cpp).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/gdbjit.cpp	Replaces `strcpy` with `memcpy` in GDB JIT debug-info string materialization paths.
src/coreclr/utilcode/debug.cpp	Replaces `strcpy` with `memcpy` when building the assert expression+stacktrace display buffer.
src/coreclr/utilcode/check.cpp	Uses `memcpy` for copying dynamically allocated CHECK failure messages.
src/coreclr/nativeaot/Runtime/unix/PalUnix.cpp	Uses computed length + `memcpy` in `PalCopyTCharAsChar`.
src/coreclr/nativeaot/Runtime/unix/cgroupcpu.cpp	Reworks cgroup path construction to use explicit lengths and `memcpy` instead of `strcpy`/`strcat`.
src/coreclr/nativeaot/Runtime/RhConfig.cpp	Refactors env-var name construction and switches embedded string copies to `memcpy`.
src/coreclr/nativeaot/Runtime/clrgc.enabled.cpp	Replaces `strcpy` concatenation with length-based `memcpy` copies.
src/coreclr/jit/fgdiagnostic.cpp	Replaces `strcpy` with `memcpy` in escape-substitution copying.
src/coreclr/interpreter/methodset.cpp	Copies config string via `memcpy` instead of `strcpy`.
src/coreclr/inc/outstring.h	Updates `<string.h>` include comment (no longer calls out `strcpy`).
src/coreclr/ildasm/dres.cpp	Replaces `strcat`/`strcpy` usage with manual `memcpy` for indentation/string building in resource dumping.
src/coreclr/ilasm/method.hpp	Updates commented-out code to reference `strcpy_s`.
src/coreclr/hosts/corerun/corerun.cpp	Uses length-based `memcpy` and guards `malloc` before copying core paths.
src/coreclr/gc/unix/cgroup.cpp	Uses mount-length caching + `memcpy` for initial copy and replaces a `strcpy` with `memcpy`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

janvorli · 2026-07-24T14:07:14Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


Do we gain anything here when the source is a string constant?

am11 · 2026-07-24T09:43:29Z

Follow up #130547.

azure-pipelines · 2026-07-24T09:44:18Z

Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-24T09:44:57Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-07-24T09:51:42Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


What guarantees that parent_directory_end has enough space? This pattern is likely to trigger static analyzers.
(not commenting on all places with this issue)

It's same guarantees as before; none.

The PR title is "Replace more strcpy with safe string copy". Why is this safe string copy then?

strcpy -> memcpy/strcpy_s, because strcpy is being flagged by clang on OpenBSD warning: strcpy() is almost always misused, please use strlcpy().

I think Jan's point is that if we're changing this code at all, we should change it to something better, not to something that has the same problem and is somewhat harder to read than the original.

Not sure how it is harder to read than original given #130547 is merged?

I was fine with #130547 since it was an open-coded strdup, no length arithmetic, length is computed on one line and used a few lines later in a very straightforward way. In hindsight, I should have suggested to just use strdup instead of open coding it. We use strdup in number of other places. Could you please replace it with strdup as part of these changes?
This code is not a straightforward like that.
We have SafeStringCopy in pal_utilities.h to solve this problem. Can we promote it or some variant of it to be usable everywhere? Would it be possible to standardize on strcpy_s and polyfill strcpy_s when it is not available - do we build on any platforms like that?

am11 · 2026-07-24T15:50:37Z

BA failure is #131256.

Copilot

Pull request overview

This PR continues the effort to eliminate strcpy usage across CoreCLR, NativeAOT, and related tools by replacing it with length-aware copies (primarily memcpy) and minor refactors to compute/carry explicit buffer lengths.

Changes:

Replaced multiple strcpy call sites with memcpy (often using strlen(...) + 1) across VM/JIT/GC/NativeAOT/host/tooling code.
Introduced explicit length variables in a few places to make copy sizes clearer and avoid repeated strlen in allocation/copy sequences.
Added a couple of small robustness tweaks (e.g., guarding malloc results before copying in corerun.cpp).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/gdbjit.cpp	Replaces `strcpy` with `memcpy` in GDB JIT debug-info string materialization paths.
src/coreclr/utilcode/debug.cpp	Replaces `strcpy` with `memcpy` when building the assert expression+stacktrace display buffer.
src/coreclr/utilcode/check.cpp	Uses `memcpy` for copying dynamically allocated CHECK failure messages.
src/coreclr/nativeaot/Runtime/unix/PalUnix.cpp	Uses computed length + `memcpy` in `PalCopyTCharAsChar`.
src/coreclr/nativeaot/Runtime/unix/cgroupcpu.cpp	Reworks cgroup path construction to use explicit lengths and `memcpy` instead of `strcpy`/`strcat`.
src/coreclr/nativeaot/Runtime/RhConfig.cpp	Refactors env-var name construction and switches embedded string copies to `memcpy`.
src/coreclr/nativeaot/Runtime/clrgc.enabled.cpp	Replaces `strcpy` concatenation with length-based `memcpy` copies.
src/coreclr/jit/fgdiagnostic.cpp	Replaces `strcpy` with `memcpy` in escape-substitution copying.
src/coreclr/interpreter/methodset.cpp	Copies config string via `memcpy` instead of `strcpy`.
src/coreclr/inc/outstring.h	Updates `<string.h>` include comment (no longer calls out `strcpy`).
src/coreclr/ildasm/dres.cpp	Replaces `strcat`/`strcpy` usage with manual `memcpy` for indentation/string building in resource dumping.
src/coreclr/ilasm/method.hpp	Updates commented-out code to reference `strcpy_s`.
src/coreclr/hosts/corerun/corerun.cpp	Uses length-based `memcpy` and guards `malloc` before copying core paths.
src/coreclr/gc/unix/cgroup.cpp	Uses mount-length caching + `memcpy` for initial copy and replaces a `strcpy` with `memcpy`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

janvorli · 2026-07-24T14:07:14Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


Do we gain anything here when the source is a string constant?

am11 · 2026-07-24T09:43:29Z

Follow up #130547.

azure-pipelines · 2026-07-24T09:44:18Z

Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-24T09:44:57Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-07-24T09:51:42Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


What guarantees that parent_directory_end has enough space? This pattern is likely to trigger static analyzers.
(not commenting on all places with this issue)

It's same guarantees as before; none.

The PR title is "Replace more strcpy with safe string copy". Why is this safe string copy then?

strcpy -> memcpy/strcpy_s, because strcpy is being flagged by clang on OpenBSD warning: strcpy() is almost always misused, please use strlcpy().

I think Jan's point is that if we're changing this code at all, we should change it to something better, not to something that has the same problem and is somewhat harder to read than the original.

Not sure how it is harder to read than original given #130547 is merged?

I was fine with #130547 since it was an open-coded strdup, no length arithmetic, length is computed on one line and used a few lines later in a very straightforward way. In hindsight, I should have suggested to just use strdup instead of open coding it. We use strdup in number of other places. Could you please replace it with strdup as part of these changes?
This code is not a straightforward like that.
We have SafeStringCopy in pal_utilities.h to solve this problem. Can we promote it or some variant of it to be usable everywhere? Would it be possible to standardize on strcpy_s and polyfill strcpy_s when it is not available - do we build on any platforms like that?

am11 · 2026-07-24T15:50:37Z

BA failure is #131256.

Copilot

Pull request overview

This PR continues the effort to eliminate strcpy usage across CoreCLR, NativeAOT, and related tools by replacing it with length-aware copies (primarily memcpy) and minor refactors to compute/carry explicit buffer lengths.

Changes:

Replaced multiple strcpy call sites with memcpy (often using strlen(...) + 1) across VM/JIT/GC/NativeAOT/host/tooling code.
Introduced explicit length variables in a few places to make copy sizes clearer and avoid repeated strlen in allocation/copy sequences.
Added a couple of small robustness tweaks (e.g., guarding malloc results before copying in corerun.cpp).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/gdbjit.cpp	Replaces `strcpy` with `memcpy` in GDB JIT debug-info string materialization paths.
src/coreclr/utilcode/debug.cpp	Replaces `strcpy` with `memcpy` when building the assert expression+stacktrace display buffer.
src/coreclr/utilcode/check.cpp	Uses `memcpy` for copying dynamically allocated CHECK failure messages.
src/coreclr/nativeaot/Runtime/unix/PalUnix.cpp	Uses computed length + `memcpy` in `PalCopyTCharAsChar`.
src/coreclr/nativeaot/Runtime/unix/cgroupcpu.cpp	Reworks cgroup path construction to use explicit lengths and `memcpy` instead of `strcpy`/`strcat`.
src/coreclr/nativeaot/Runtime/RhConfig.cpp	Refactors env-var name construction and switches embedded string copies to `memcpy`.
src/coreclr/nativeaot/Runtime/clrgc.enabled.cpp	Replaces `strcpy` concatenation with length-based `memcpy` copies.
src/coreclr/jit/fgdiagnostic.cpp	Replaces `strcpy` with `memcpy` in escape-substitution copying.
src/coreclr/interpreter/methodset.cpp	Copies config string via `memcpy` instead of `strcpy`.
src/coreclr/inc/outstring.h	Updates `<string.h>` include comment (no longer calls out `strcpy`).
src/coreclr/ildasm/dres.cpp	Replaces `strcat`/`strcpy` usage with manual `memcpy` for indentation/string building in resource dumping.
src/coreclr/ilasm/method.hpp	Updates commented-out code to reference `strcpy_s`.
src/coreclr/hosts/corerun/corerun.cpp	Uses length-based `memcpy` and guards `malloc` before copying core paths.
src/coreclr/gc/unix/cgroup.cpp	Uses mount-length caching + `memcpy` for initial copy and replaces a `strcpy` with `memcpy`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

janvorli · 2026-07-24T14:07:14Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


Do we gain anything here when the source is a string constant?

am11 · 2026-07-24T09:43:29Z

Follow up #130547.

azure-pipelines · 2026-07-24T09:44:18Z

Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-24T09:44:57Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-07-24T09:51:42Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


What guarantees that parent_directory_end has enough space? This pattern is likely to trigger static analyzers.
(not commenting on all places with this issue)

It's same guarantees as before; none.

The PR title is "Replace more strcpy with safe string copy". Why is this safe string copy then?

strcpy -> memcpy/strcpy_s, because strcpy is being flagged by clang on OpenBSD warning: strcpy() is almost always misused, please use strlcpy().

I think Jan's point is that if we're changing this code at all, we should change it to something better, not to something that has the same problem and is somewhat harder to read than the original.

Not sure how it is harder to read than original given #130547 is merged?

I was fine with #130547 since it was an open-coded strdup, no length arithmetic, length is computed on one line and used a few lines later in a very straightforward way. In hindsight, I should have suggested to just use strdup instead of open coding it. We use strdup in number of other places. Could you please replace it with strdup as part of these changes?
This code is not a straightforward like that.
We have SafeStringCopy in pal_utilities.h to solve this problem. Can we promote it or some variant of it to be usable everywhere? Would it be possible to standardize on strcpy_s and polyfill strcpy_s when it is not available - do we build on any platforms like that?

am11 · 2026-07-24T15:50:37Z

BA failure is #131256.

Copilot

Pull request overview

This PR continues the effort to eliminate strcpy usage across CoreCLR, NativeAOT, and related tools by replacing it with length-aware copies (primarily memcpy) and minor refactors to compute/carry explicit buffer lengths.

Changes:

Replaced multiple strcpy call sites with memcpy (often using strlen(...) + 1) across VM/JIT/GC/NativeAOT/host/tooling code.
Introduced explicit length variables in a few places to make copy sizes clearer and avoid repeated strlen in allocation/copy sequences.
Added a couple of small robustness tweaks (e.g., guarding malloc results before copying in corerun.cpp).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/gdbjit.cpp	Replaces `strcpy` with `memcpy` in GDB JIT debug-info string materialization paths.
src/coreclr/utilcode/debug.cpp	Replaces `strcpy` with `memcpy` when building the assert expression+stacktrace display buffer.
src/coreclr/utilcode/check.cpp	Uses `memcpy` for copying dynamically allocated CHECK failure messages.
src/coreclr/nativeaot/Runtime/unix/PalUnix.cpp	Uses computed length + `memcpy` in `PalCopyTCharAsChar`.
src/coreclr/nativeaot/Runtime/unix/cgroupcpu.cpp	Reworks cgroup path construction to use explicit lengths and `memcpy` instead of `strcpy`/`strcat`.
src/coreclr/nativeaot/Runtime/RhConfig.cpp	Refactors env-var name construction and switches embedded string copies to `memcpy`.
src/coreclr/nativeaot/Runtime/clrgc.enabled.cpp	Replaces `strcpy` concatenation with length-based `memcpy` copies.
src/coreclr/jit/fgdiagnostic.cpp	Replaces `strcpy` with `memcpy` in escape-substitution copying.
src/coreclr/interpreter/methodset.cpp	Copies config string via `memcpy` instead of `strcpy`.
src/coreclr/inc/outstring.h	Updates `<string.h>` include comment (no longer calls out `strcpy`).
src/coreclr/ildasm/dres.cpp	Replaces `strcat`/`strcpy` usage with manual `memcpy` for indentation/string building in resource dumping.
src/coreclr/ilasm/method.hpp	Updates commented-out code to reference `strcpy_s`.
src/coreclr/hosts/corerun/corerun.cpp	Uses length-based `memcpy` and guards `malloc` before copying core paths.
src/coreclr/gc/unix/cgroup.cpp	Uses mount-length caching + `memcpy` for initial copy and replaces a `strcpy` with `memcpy`.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

janvorli · 2026-07-24T14:07:14Z

 cgroupPathLength = parent_directory_end - mem_limit_filename;

-strcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME);
+memcpy(parent_directory_end, CGROUP2_MEMORY_LIMIT_FILENAME, strlen(CGROUP2_MEMORY_LIMIT_FILENAME) + 1);


Do we gain anything here when the source is a string constant?

Replace more strcpy with safe string copy
d63b387

am11 requested review from BrzVlad, MichalStrehovsky and janvorli as code owners July 24, 2026 09:43

github-actionsBot added the area-VM-coreclr label Jul 24, 2026

am11 mentioned this pull request Jul 24, 2026
Support for OpenBSD #124911
Open

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2026

jkotas reviewed Jul 24, 2026
View reviewed changes

Comment threadsrc/coreclr/gc/unix/cgroup.cpp Outdated

jkotas reviewed Jul 24, 2026
View reviewed changes

am11 force-pushed the chore/mop-strcpy branch from 6a2d59d to c0f7062Compare July 24, 2026 11:29

Apply suggestion from CR
7ea1219

am11 force-pushed the chore/mop-strcpy branch from c0f7062 to 7ea1219Compare July 24, 2026 12:00

am11 added 2 commits July 24, 2026 15:01

Merge branch 'main' into chore/mop-strcpy
ba8a705

Merge branch 'main' into chore/mop-strcpy
b708120

am11 requested a review from jkoritzinsky July 24, 2026 15:50

build-analysisBot mentioned this pull request Jul 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed

jkotas requested a lite review from Copilot August 12, 2026 23:10

Copilotstarted reviewing on behalf of jkotas August 12, 2026 23:10 View session

CopilotAI reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/coreclr/utilcode/debug.cpp Outdated
Comment threadsrc/coreclr/ildasm/dres.cpp Outdated
Comment threadsrc/coreclr/interpreter/methodset.cpp

am11and others added 2 commits August 13, 2026 10:07

Apply suggestions from code review
a3d26be
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into chore/mop-strcpy
17f883f

janvorli reviewed Aug 17, 2026
View reviewed changes

Replace more strcpy with safe string copy
d63b387

am11 requested review from BrzVlad, MichalStrehovsky and janvorli as code owners July 24, 2026 09:43

github-actionsBot added the area-VM-coreclr label Jul 24, 2026

am11 mentioned this pull request Jul 24, 2026
Support for OpenBSD #124911
Open

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2026

jkotas reviewed Jul 24, 2026
View reviewed changes

Comment threadsrc/coreclr/gc/unix/cgroup.cpp Outdated

jkotas reviewed Jul 24, 2026
View reviewed changes

am11 force-pushed the chore/mop-strcpy branch from 6a2d59d to c0f7062Compare July 24, 2026 11:29

Apply suggestion from CR
7ea1219

am11 force-pushed the chore/mop-strcpy branch from c0f7062 to 7ea1219Compare July 24, 2026 12:00

am11 added 2 commits July 24, 2026 15:01

Merge branch 'main' into chore/mop-strcpy
ba8a705

Merge branch 'main' into chore/mop-strcpy
b708120

am11 requested a review from jkoritzinsky July 24, 2026 15:50

build-analysisBot mentioned this pull request Jul 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed

jkotas requested a lite review from Copilot August 12, 2026 23:10

Copilotstarted reviewing on behalf of jkotas August 12, 2026 23:10 View session

CopilotAI reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/coreclr/utilcode/debug.cpp Outdated
Comment threadsrc/coreclr/ildasm/dres.cpp Outdated
Comment threadsrc/coreclr/interpreter/methodset.cpp

am11and others added 2 commits August 13, 2026 10:07

Apply suggestions from code review
a3d26be
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into chore/mop-strcpy
17f883f

janvorli reviewed Aug 17, 2026
View reviewed changes

Replace more strcpy with safe string copy
d63b387

am11 requested review from BrzVlad, MichalStrehovsky and janvorli as code owners July 24, 2026 09:43

github-actionsBot added the area-VM-coreclr label Jul 24, 2026

am11 mentioned this pull request Jul 24, 2026
Support for OpenBSD #124911
Open

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2026

jkotas reviewed Jul 24, 2026
View reviewed changes

Comment threadsrc/coreclr/gc/unix/cgroup.cpp Outdated

jkotas reviewed Jul 24, 2026
View reviewed changes

am11 force-pushed the chore/mop-strcpy branch from 6a2d59d to c0f7062Compare July 24, 2026 11:29

Apply suggestion from CR
7ea1219

am11 force-pushed the chore/mop-strcpy branch from c0f7062 to 7ea1219Compare July 24, 2026 12:00

am11 added 2 commits July 24, 2026 15:01

Merge branch 'main' into chore/mop-strcpy
ba8a705

Merge branch 'main' into chore/mop-strcpy
b708120

am11 requested a review from jkoritzinsky July 24, 2026 15:50

build-analysisBot mentioned this pull request Jul 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed

jkotas requested a lite review from Copilot August 12, 2026 23:10

Copilotstarted reviewing on behalf of jkotas August 12, 2026 23:10 View session

CopilotAI reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/coreclr/utilcode/debug.cpp Outdated
Comment threadsrc/coreclr/ildasm/dres.cpp Outdated
Comment threadsrc/coreclr/interpreter/methodset.cpp

am11and others added 2 commits August 13, 2026 10:07

Apply suggestions from code review
a3d26be
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into chore/mop-strcpy
17f883f

janvorli reviewed Aug 17, 2026
View reviewed changes

Replace more strcpy with safe string copy
d63b387

am11 requested review from BrzVlad, MichalStrehovsky and janvorli as code owners July 24, 2026 09:43

github-actionsBot added the area-VM-coreclr label Jul 24, 2026

am11 mentioned this pull request Jul 24, 2026
Support for OpenBSD #124911
Open

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2026

jkotas reviewed Jul 24, 2026
View reviewed changes

Comment threadsrc/coreclr/gc/unix/cgroup.cpp Outdated

jkotas reviewed Jul 24, 2026
View reviewed changes

am11 force-pushed the chore/mop-strcpy branch from 6a2d59d to c0f7062Compare July 24, 2026 11:29

Apply suggestion from CR
7ea1219

am11 force-pushed the chore/mop-strcpy branch from c0f7062 to 7ea1219Compare July 24, 2026 12:00

am11 added 2 commits July 24, 2026 15:01

Merge branch 'main' into chore/mop-strcpy
ba8a705

Merge branch 'main' into chore/mop-strcpy
b708120

am11 requested a review from jkoritzinsky July 24, 2026 15:50

build-analysisBot mentioned this pull request Jul 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed

jkotas requested a lite review from Copilot August 12, 2026 23:10

Copilotstarted reviewing on behalf of jkotas August 12, 2026 23:10 View session

CopilotAI reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/coreclr/utilcode/debug.cpp Outdated
Comment threadsrc/coreclr/ildasm/dres.cpp Outdated
Comment threadsrc/coreclr/interpreter/methodset.cpp

am11and others added 2 commits August 13, 2026 10:07

Apply suggestions from code review
a3d26be
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into chore/mop-strcpy
17f883f

janvorli reviewed Aug 17, 2026
View reviewed changes

Replace more strcpy with safe string copy
d63b387

am11 requested review from BrzVlad, MichalStrehovsky and janvorli as code owners July 24, 2026 09:43

github-actionsBot added the area-VM-coreclr label Jul 24, 2026

am11 mentioned this pull request Jul 24, 2026
Support for OpenBSD #124911
Open

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2026

jkotas reviewed Jul 24, 2026
View reviewed changes

Comment threadsrc/coreclr/gc/unix/cgroup.cpp Outdated

jkotas reviewed Jul 24, 2026
View reviewed changes

am11 force-pushed the chore/mop-strcpy branch from 6a2d59d to c0f7062Compare July 24, 2026 11:29

Apply suggestion from CR
7ea1219

am11 force-pushed the chore/mop-strcpy branch from c0f7062 to 7ea1219Compare July 24, 2026 12:00

am11 added 2 commits July 24, 2026 15:01

Merge branch 'main' into chore/mop-strcpy
ba8a705

Merge branch 'main' into chore/mop-strcpy
b708120

am11 requested a review from jkoritzinsky July 24, 2026 15:50

build-analysisBot mentioned this pull request Jul 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed

jkotas requested a lite review from Copilot August 12, 2026 23:10

Copilotstarted reviewing on behalf of jkotas August 12, 2026 23:10 View session

CopilotAI reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/coreclr/utilcode/debug.cpp Outdated
Comment threadsrc/coreclr/ildasm/dres.cpp Outdated
Comment threadsrc/coreclr/interpreter/methodset.cpp

am11and others added 2 commits August 13, 2026 10:07

Apply suggestions from code review
a3d26be
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into chore/mop-strcpy
17f883f

janvorli reviewed Aug 17, 2026
View reviewed changes

Replace more strcpy with safe string copy
d63b387

am11 requested review from BrzVlad, MichalStrehovsky and janvorli as code owners July 24, 2026 09:43

github-actionsBot added the area-VM-coreclr label Jul 24, 2026

am11 mentioned this pull request Jul 24, 2026
Support for OpenBSD #124911
Open

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2026

jkotas reviewed Jul 24, 2026
View reviewed changes

Comment threadsrc/coreclr/gc/unix/cgroup.cpp Outdated

jkotas reviewed Jul 24, 2026
View reviewed changes

am11 force-pushed the chore/mop-strcpy branch from 6a2d59d to c0f7062Compare July 24, 2026 11:29

Apply suggestion from CR
7ea1219

am11 force-pushed the chore/mop-strcpy branch from c0f7062 to 7ea1219Compare July 24, 2026 12:00

am11 added 2 commits July 24, 2026 15:01

Merge branch 'main' into chore/mop-strcpy
ba8a705

Merge branch 'main' into chore/mop-strcpy
b708120

am11 requested a review from jkoritzinsky July 24, 2026 15:50

build-analysisBot mentioned this pull request Jul 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed

jkotas requested a lite review from Copilot August 12, 2026 23:10

Copilotstarted reviewing on behalf of jkotas August 12, 2026 23:10 View session

CopilotAI reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/coreclr/utilcode/debug.cpp Outdated
Comment threadsrc/coreclr/ildasm/dres.cpp Outdated
Comment threadsrc/coreclr/interpreter/methodset.cpp

am11and others added 2 commits August 13, 2026 10:07

Apply suggestions from code review
a3d26be
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into chore/mop-strcpy
17f883f

janvorli reviewed Aug 17, 2026
View reviewed changes

Replace more strcpy with safe string copy
d63b387

am11 requested review from BrzVlad, MichalStrehovsky and janvorli as code owners July 24, 2026 09:43

github-actionsBot added the area-VM-coreclr label Jul 24, 2026

am11 mentioned this pull request Jul 24, 2026
Support for OpenBSD #124911
Open

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2026

jkotas reviewed Jul 24, 2026
View reviewed changes

Comment threadsrc/coreclr/gc/unix/cgroup.cpp Outdated

jkotas reviewed Jul 24, 2026
View reviewed changes

am11 force-pushed the chore/mop-strcpy branch from 6a2d59d to c0f7062Compare July 24, 2026 11:29

Apply suggestion from CR
7ea1219

am11 force-pushed the chore/mop-strcpy branch from c0f7062 to 7ea1219Compare July 24, 2026 12:00

am11 added 2 commits July 24, 2026 15:01

Merge branch 'main' into chore/mop-strcpy
ba8a705

Merge branch 'main' into chore/mop-strcpy
b708120

am11 requested a review from jkoritzinsky July 24, 2026 15:50

build-analysisBot mentioned this pull request Jul 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed

jkotas requested a lite review from Copilot August 12, 2026 23:10

Copilotstarted reviewing on behalf of jkotas August 12, 2026 23:10 View session

CopilotAI reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/coreclr/utilcode/debug.cpp Outdated
Comment threadsrc/coreclr/ildasm/dres.cpp Outdated
Comment threadsrc/coreclr/interpreter/methodset.cpp

am11and others added 2 commits August 13, 2026 10:07

Apply suggestions from code review
a3d26be
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into chore/mop-strcpy
17f883f

janvorli reviewed Aug 17, 2026
View reviewed changes

Replace more strcpy with safe string copy
d63b387

am11 requested review from BrzVlad, MichalStrehovsky and janvorli as code owners July 24, 2026 09:43

github-actionsBot added the area-VM-coreclr label Jul 24, 2026

am11 mentioned this pull request Jul 24, 2026
Support for OpenBSD #124911
Open

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2026

jkotas reviewed Jul 24, 2026
View reviewed changes

Comment threadsrc/coreclr/gc/unix/cgroup.cpp Outdated

jkotas reviewed Jul 24, 2026
View reviewed changes

am11 force-pushed the chore/mop-strcpy branch from 6a2d59d to c0f7062Compare July 24, 2026 11:29

Apply suggestion from CR
7ea1219

am11 force-pushed the chore/mop-strcpy branch from c0f7062 to 7ea1219Compare July 24, 2026 12:00

am11 added 2 commits July 24, 2026 15:01

Merge branch 'main' into chore/mop-strcpy
ba8a705

Merge branch 'main' into chore/mop-strcpy
b708120

am11 requested a review from jkoritzinsky July 24, 2026 15:50

build-analysisBot mentioned this pull request Jul 24, 2026
Unable to pull image from mcr.microsoft.com #117164
Closed

jkotas requested a lite review from Copilot August 12, 2026 23:10

Copilotstarted reviewing on behalf of jkotas August 12, 2026 23:10 View session

CopilotAI reviewed Aug 12, 2026
View reviewed changes

Comment threadsrc/coreclr/utilcode/debug.cpp Outdated
Comment threadsrc/coreclr/ildasm/dres.cpp Outdated
Comment threadsrc/coreclr/interpreter/methodset.cpp

am11and others added 2 commits August 13, 2026 10:07

Apply suggestions from code review
a3d26be
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into chore/mop-strcpy
17f883f

janvorli reviewed Aug 17, 2026
View reviewed changes

Uh oh!

Conversation

am11 commented Jul 24, 2026

Uh oh!

azure-pipelinesBot commented Jul 24, 2026

Uh oh!

dotnet-policy-serviceBot commented Jul 24, 2026

Uh oh!

Uh oh!

jkotasJul 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

am11 commented Jul 24, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

am11 commented Jul 24, 2026

Uh oh!

azure-pipelinesBot commented Jul 24, 2026

Uh oh!

dotnet-policy-serviceBot commented Jul 24, 2026

Uh oh!

Uh oh!

jkotasJul 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

am11 commented Jul 24, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotasJul 24, 2026•
edited
Loading

jkotasJul 24, 2026•
edited
Loading

jkotasJul 24, 2026•
edited
Loading