[release/11.0-preview7] FileConfigurationProvider: Handle and forward IO exceptions to OnLoadException by mrek-msft · Pull Request #131427 · dotnet/runtime

mrek-msft · 2026-07-27T17:16:27Z

Backport of #126093 to release/11.0-preview7

Customer Impact

Long standing issue reported by customer

Customer reported
Found internally

Regression

Long standing issue.

Yes
No

Testing

6 tests were added.

Risk

Low. It is backport to Preview 7 version after branch were snapped but before code complete.

…Exception (dotnet#126093) Current behavior of FileConfigurationProvider on various types of failures at various times: | | First Load | OnChange Reload | |---|---|---| | data parsing failure | `OnLoadException` callback is called `AddJsonFile` throws | `OnLoadException` callback is called program continues no reload happen | | IO failure on file open | `AddJsonFile` throws | Silent program continues no reload happen possibly raises `UnobservedTaskException` later | This PR unifies it in a way that both types of failure behave same as _data parsing failure_. This brings some behavioral changes - `OnLoadException` callback is newly triggered if IO error happen on both types of events (first load, reload) - `UnobservedTaskException` can no longer be observed in scenario when user registers `OnLoadException` callback. It can however happen when no callback is registered, so XML comment on `OnLoadException` was updated. - `OnLoadException` callbacks now receives not only InvalidDataException, but also IOException (or any other exception which (possibly custom) implementation of IFileProvider can throw). If user cast to InvalidDataException, he may miss other exceptions or get cast exceptions. Based on follow up Copilot code reviews, I did few more behavior changes at edge cases, they do not relate directly to issue and can be reverted independently if not desired. - `OnReload()` now fires only when Data actually changed. Previously on first load, if a parse or IO error occurred and `OnLoadException` set `Ignore = true`, `OnReload()` was fired unconditionally even though Data was never modified. The new code fires `OnReload()` only when Data was successfully loaded or explicitly cleared (e.g., on reload or optional missing file). For consecutive reloads with parse errors, Data is cleared and `OnReload()` still fires. This change is independent on original fix and can be reverted independently if not desirable. Fixdotnet#113964 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-27T17:17:13Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

mrek-msft · 2026-07-27T20:56:48Z

/ba-g Only unrelated known iOS errors

mrek-msft · 2026-07-27T20:57:28Z

Adding servicing-approved. Based on discussion in tactics email, since it is not code complete yet, no servicing approval is needed.

mrek-msft · 2026-07-27T17:16:27Z

Backport of #126093 to release/11.0-preview7

Customer Impact

Long standing issue reported by customer

Customer reported
Found internally

Regression

Long standing issue.

Yes
No

Testing

6 tests were added.

Risk

Low. It is backport to Preview 7 version after branch were snapped but before code complete.

…Exception (dotnet#126093) Current behavior of FileConfigurationProvider on various types of failures at various times: | | First Load | OnChange Reload | |---|---|---| | data parsing failure | `OnLoadException` callback is called `AddJsonFile` throws | `OnLoadException` callback is called program continues no reload happen | | IO failure on file open | `AddJsonFile` throws | Silent program continues no reload happen possibly raises `UnobservedTaskException` later | This PR unifies it in a way that both types of failure behave same as _data parsing failure_. This brings some behavioral changes - `OnLoadException` callback is newly triggered if IO error happen on both types of events (first load, reload) - `UnobservedTaskException` can no longer be observed in scenario when user registers `OnLoadException` callback. It can however happen when no callback is registered, so XML comment on `OnLoadException` was updated. - `OnLoadException` callbacks now receives not only InvalidDataException, but also IOException (or any other exception which (possibly custom) implementation of IFileProvider can throw). If user cast to InvalidDataException, he may miss other exceptions or get cast exceptions. Based on follow up Copilot code reviews, I did few more behavior changes at edge cases, they do not relate directly to issue and can be reverted independently if not desired. - `OnReload()` now fires only when Data actually changed. Previously on first load, if a parse or IO error occurred and `OnLoadException` set `Ignore = true`, `OnReload()` was fired unconditionally even though Data was never modified. The new code fires `OnReload()` only when Data was successfully loaded or explicitly cleared (e.g., on reload or optional missing file). For consecutive reloads with parse errors, Data is cleared and `OnReload()` still fires. This change is independent on original fix and can be reverted independently if not desirable. Fixdotnet#113964 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-27T17:17:13Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

mrek-msft · 2026-07-27T20:56:48Z

/ba-g Only unrelated known iOS errors

mrek-msft · 2026-07-27T20:57:28Z

Adding servicing-approved. Based on discussion in tactics email, since it is not code complete yet, no servicing approval is needed.

mrek-msft · 2026-07-27T17:16:27Z

Backport of #126093 to release/11.0-preview7

Customer Impact

Long standing issue reported by customer

Customer reported
Found internally

Regression

Long standing issue.

Yes
No

Testing

6 tests were added.

Risk

Low. It is backport to Preview 7 version after branch were snapped but before code complete.

…Exception (dotnet#126093) Current behavior of FileConfigurationProvider on various types of failures at various times: | | First Load | OnChange Reload | |---|---|---| | data parsing failure | `OnLoadException` callback is called `AddJsonFile` throws | `OnLoadException` callback is called program continues no reload happen | | IO failure on file open | `AddJsonFile` throws | Silent program continues no reload happen possibly raises `UnobservedTaskException` later | This PR unifies it in a way that both types of failure behave same as _data parsing failure_. This brings some behavioral changes - `OnLoadException` callback is newly triggered if IO error happen on both types of events (first load, reload) - `UnobservedTaskException` can no longer be observed in scenario when user registers `OnLoadException` callback. It can however happen when no callback is registered, so XML comment on `OnLoadException` was updated. - `OnLoadException` callbacks now receives not only InvalidDataException, but also IOException (or any other exception which (possibly custom) implementation of IFileProvider can throw). If user cast to InvalidDataException, he may miss other exceptions or get cast exceptions. Based on follow up Copilot code reviews, I did few more behavior changes at edge cases, they do not relate directly to issue and can be reverted independently if not desired. - `OnReload()` now fires only when Data actually changed. Previously on first load, if a parse or IO error occurred and `OnLoadException` set `Ignore = true`, `OnReload()` was fired unconditionally even though Data was never modified. The new code fires `OnReload()` only when Data was successfully loaded or explicitly cleared (e.g., on reload or optional missing file). For consecutive reloads with parse errors, Data is cleared and `OnReload()` still fires. This change is independent on original fix and can be reverted independently if not desirable. Fixdotnet#113964 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-27T17:17:13Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

mrek-msft · 2026-07-27T20:56:48Z

/ba-g Only unrelated known iOS errors

mrek-msft · 2026-07-27T20:57:28Z

Adding servicing-approved. Based on discussion in tactics email, since it is not code complete yet, no servicing approval is needed.

mrek-msft · 2026-07-27T17:16:27Z

Backport of #126093 to release/11.0-preview7

Customer Impact

Long standing issue reported by customer

Customer reported
Found internally

Regression

Long standing issue.

Yes
No

Testing

6 tests were added.

Risk

Low. It is backport to Preview 7 version after branch were snapped but before code complete.

…Exception (dotnet#126093) Current behavior of FileConfigurationProvider on various types of failures at various times: | | First Load | OnChange Reload | |---|---|---| | data parsing failure | `OnLoadException` callback is called `AddJsonFile` throws | `OnLoadException` callback is called program continues no reload happen | | IO failure on file open | `AddJsonFile` throws | Silent program continues no reload happen possibly raises `UnobservedTaskException` later | This PR unifies it in a way that both types of failure behave same as _data parsing failure_. This brings some behavioral changes - `OnLoadException` callback is newly triggered if IO error happen on both types of events (first load, reload) - `UnobservedTaskException` can no longer be observed in scenario when user registers `OnLoadException` callback. It can however happen when no callback is registered, so XML comment on `OnLoadException` was updated. - `OnLoadException` callbacks now receives not only InvalidDataException, but also IOException (or any other exception which (possibly custom) implementation of IFileProvider can throw). If user cast to InvalidDataException, he may miss other exceptions or get cast exceptions. Based on follow up Copilot code reviews, I did few more behavior changes at edge cases, they do not relate directly to issue and can be reverted independently if not desired. - `OnReload()` now fires only when Data actually changed. Previously on first load, if a parse or IO error occurred and `OnLoadException` set `Ignore = true`, `OnReload()` was fired unconditionally even though Data was never modified. The new code fires `OnReload()` only when Data was successfully loaded or explicitly cleared (e.g., on reload or optional missing file). For consecutive reloads with parse errors, Data is cleared and `OnReload()` still fires. This change is independent on original fix and can be reverted independently if not desirable. Fixdotnet#113964 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-27T17:17:13Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

mrek-msft · 2026-07-27T20:56:48Z

/ba-g Only unrelated known iOS errors

mrek-msft · 2026-07-27T20:57:28Z

Adding servicing-approved. Based on discussion in tactics email, since it is not code complete yet, no servicing approval is needed.

mrek-msft · 2026-07-27T17:16:27Z

Backport of #126093 to release/11.0-preview7

Customer Impact

Long standing issue reported by customer

Customer reported
Found internally

Regression

Long standing issue.

Yes
No

Testing

6 tests were added.

Risk

Low. It is backport to Preview 7 version after branch were snapped but before code complete.

…Exception (dotnet#126093) Current behavior of FileConfigurationProvider on various types of failures at various times: | | First Load | OnChange Reload | |---|---|---| | data parsing failure | `OnLoadException` callback is called `AddJsonFile` throws | `OnLoadException` callback is called program continues no reload happen | | IO failure on file open | `AddJsonFile` throws | Silent program continues no reload happen possibly raises `UnobservedTaskException` later | This PR unifies it in a way that both types of failure behave same as _data parsing failure_. This brings some behavioral changes - `OnLoadException` callback is newly triggered if IO error happen on both types of events (first load, reload) - `UnobservedTaskException` can no longer be observed in scenario when user registers `OnLoadException` callback. It can however happen when no callback is registered, so XML comment on `OnLoadException` was updated. - `OnLoadException` callbacks now receives not only InvalidDataException, but also IOException (or any other exception which (possibly custom) implementation of IFileProvider can throw). If user cast to InvalidDataException, he may miss other exceptions or get cast exceptions. Based on follow up Copilot code reviews, I did few more behavior changes at edge cases, they do not relate directly to issue and can be reverted independently if not desired. - `OnReload()` now fires only when Data actually changed. Previously on first load, if a parse or IO error occurred and `OnLoadException` set `Ignore = true`, `OnReload()` was fired unconditionally even though Data was never modified. The new code fires `OnReload()` only when Data was successfully loaded or explicitly cleared (e.g., on reload or optional missing file). For consecutive reloads with parse errors, Data is cleared and `OnReload()` still fires. This change is independent on original fix and can be reverted independently if not desirable. Fixdotnet#113964 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-27T17:17:13Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

mrek-msft · 2026-07-27T20:56:48Z

/ba-g Only unrelated known iOS errors

mrek-msft · 2026-07-27T20:57:28Z

Adding servicing-approved. Based on discussion in tactics email, since it is not code complete yet, no servicing approval is needed.

mrek-msft · 2026-07-27T17:16:27Z

Backport of #126093 to release/11.0-preview7

Customer Impact

Long standing issue reported by customer

Customer reported
Found internally

Regression

Long standing issue.

Yes
No

Testing

6 tests were added.

Risk

Low. It is backport to Preview 7 version after branch were snapped but before code complete.

…Exception (dotnet#126093) Current behavior of FileConfigurationProvider on various types of failures at various times: | | First Load | OnChange Reload | |---|---|---| | data parsing failure | `OnLoadException` callback is called `AddJsonFile` throws | `OnLoadException` callback is called program continues no reload happen | | IO failure on file open | `AddJsonFile` throws | Silent program continues no reload happen possibly raises `UnobservedTaskException` later | This PR unifies it in a way that both types of failure behave same as _data parsing failure_. This brings some behavioral changes - `OnLoadException` callback is newly triggered if IO error happen on both types of events (first load, reload) - `UnobservedTaskException` can no longer be observed in scenario when user registers `OnLoadException` callback. It can however happen when no callback is registered, so XML comment on `OnLoadException` was updated. - `OnLoadException` callbacks now receives not only InvalidDataException, but also IOException (or any other exception which (possibly custom) implementation of IFileProvider can throw). If user cast to InvalidDataException, he may miss other exceptions or get cast exceptions. Based on follow up Copilot code reviews, I did few more behavior changes at edge cases, they do not relate directly to issue and can be reverted independently if not desired. - `OnReload()` now fires only when Data actually changed. Previously on first load, if a parse or IO error occurred and `OnLoadException` set `Ignore = true`, `OnReload()` was fired unconditionally even though Data was never modified. The new code fires `OnReload()` only when Data was successfully loaded or explicitly cleared (e.g., on reload or optional missing file). For consecutive reloads with parse errors, Data is cleared and `OnReload()` still fires. This change is independent on original fix and can be reverted independently if not desirable. Fixdotnet#113964 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-27T17:17:13Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

mrek-msft · 2026-07-27T20:56:48Z

/ba-g Only unrelated known iOS errors

mrek-msft · 2026-07-27T20:57:28Z

Adding servicing-approved. Based on discussion in tactics email, since it is not code complete yet, no servicing approval is needed.

mrek-msft · 2026-07-27T17:16:27Z

Backport of #126093 to release/11.0-preview7

Customer Impact

Long standing issue reported by customer

Customer reported
Found internally

Regression

Long standing issue.

Yes
No

Testing

6 tests were added.

Risk

Low. It is backport to Preview 7 version after branch were snapped but before code complete.

…Exception (dotnet#126093) Current behavior of FileConfigurationProvider on various types of failures at various times: | | First Load | OnChange Reload | |---|---|---| | data parsing failure | `OnLoadException` callback is called `AddJsonFile` throws | `OnLoadException` callback is called program continues no reload happen | | IO failure on file open | `AddJsonFile` throws | Silent program continues no reload happen possibly raises `UnobservedTaskException` later | This PR unifies it in a way that both types of failure behave same as _data parsing failure_. This brings some behavioral changes - `OnLoadException` callback is newly triggered if IO error happen on both types of events (first load, reload) - `UnobservedTaskException` can no longer be observed in scenario when user registers `OnLoadException` callback. It can however happen when no callback is registered, so XML comment on `OnLoadException` was updated. - `OnLoadException` callbacks now receives not only InvalidDataException, but also IOException (or any other exception which (possibly custom) implementation of IFileProvider can throw). If user cast to InvalidDataException, he may miss other exceptions or get cast exceptions. Based on follow up Copilot code reviews, I did few more behavior changes at edge cases, they do not relate directly to issue and can be reverted independently if not desired. - `OnReload()` now fires only when Data actually changed. Previously on first load, if a parse or IO error occurred and `OnLoadException` set `Ignore = true`, `OnReload()` was fired unconditionally even though Data was never modified. The new code fires `OnReload()` only when Data was successfully loaded or explicitly cleared (e.g., on reload or optional missing file). For consecutive reloads with parse errors, Data is cleared and `OnReload()` still fires. This change is independent on original fix and can be reverted independently if not desirable. Fixdotnet#113964 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-27T17:17:13Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

mrek-msft · 2026-07-27T20:56:48Z

/ba-g Only unrelated known iOS errors

mrek-msft · 2026-07-27T20:57:28Z

Adding servicing-approved. Based on discussion in tactics email, since it is not code complete yet, no servicing approval is needed.

mrek-msft · 2026-07-27T17:16:27Z

Backport of #126093 to release/11.0-preview7

Customer Impact

Long standing issue reported by customer

Customer reported
Found internally

Regression

Long standing issue.

Yes
No

Testing

6 tests were added.

Risk

Low. It is backport to Preview 7 version after branch were snapped but before code complete.

…Exception (dotnet#126093) Current behavior of FileConfigurationProvider on various types of failures at various times: | | First Load | OnChange Reload | |---|---|---| | data parsing failure | `OnLoadException` callback is called `AddJsonFile` throws | `OnLoadException` callback is called program continues no reload happen | | IO failure on file open | `AddJsonFile` throws | Silent program continues no reload happen possibly raises `UnobservedTaskException` later | This PR unifies it in a way that both types of failure behave same as _data parsing failure_. This brings some behavioral changes - `OnLoadException` callback is newly triggered if IO error happen on both types of events (first load, reload) - `UnobservedTaskException` can no longer be observed in scenario when user registers `OnLoadException` callback. It can however happen when no callback is registered, so XML comment on `OnLoadException` was updated. - `OnLoadException` callbacks now receives not only InvalidDataException, but also IOException (or any other exception which (possibly custom) implementation of IFileProvider can throw). If user cast to InvalidDataException, he may miss other exceptions or get cast exceptions. Based on follow up Copilot code reviews, I did few more behavior changes at edge cases, they do not relate directly to issue and can be reverted independently if not desired. - `OnReload()` now fires only when Data actually changed. Previously on first load, if a parse or IO error occurred and `OnLoadException` set `Ignore = true`, `OnReload()` was fired unconditionally even though Data was never modified. The new code fires `OnReload()` only when Data was successfully loaded or explicitly cleared (e.g., on reload or optional missing file). For consecutive reloads with parse errors, Data is cleared and `OnReload()` still fires. This change is independent on original fix and can be reverted independently if not desirable. Fixdotnet#113964 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2026-07-27T17:17:13Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

mrek-msft · 2026-07-27T20:56:48Z

/ba-g Only unrelated known iOS errors

mrek-msft · 2026-07-27T20:57:28Z

Adding servicing-approved. Based on discussion in tactics email, since it is not code complete yet, no servicing approval is needed.

mrek-msft requested review from Copilot and svick and removed request for Copilot July 27, 2026 17:16

github-actionsBot added the area-Extensions-Configuration label Jul 27, 2026

Copilotstarted reviewing on behalf of mrek-msft July 27, 2026 17:16 View session

cincuranet approved these changes Jul 27, 2026
View reviewed changes

mrek-msft added the Servicing-approved Approved for servicing release label Jul 27, 2026

mrek-msft merged commit 253bde0 into dotnet:release/11.0-preview7Jul 27, 2026
91 of 96 checks passed

build-analysisBot mentioned this pull request Jul 27, 2026
XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796
Open

dotnet-maestroBot mentioned this pull request Jul 27, 2026
[release/11.0.1xx-preview7] Source code updates from dotnet/runtime dotnet/dotnet#7992
Merged

dotnet-milestone-botBot added this to the 11.0-preview7 milestone Jul 27, 2026

svick mentioned this pull request Jul 28, 2026
Backport workflow should prefer the merged PR change over replaying intermediate commits dotnet/arcade#17205
Closed

mrek-msft mentioned this pull request Aug 3, 2026
[release-notes] Libraries in .NET 11 Preview 7 dotnet/core#10508
Merged

github-actionsBot locked and limited conversation to collaborators Aug 27, 2026