Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 5.6k
[wasm] Pass Int128, Decimal128 and wide vectors by value#131492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
02bf70b
[wasm] Pass Int128, Decimal128 and wide vectors by value
lewing 08b33d6
[wasm] Reject multi-slot types in interop signatures
lewing f1b38e6
Merge remote-tracking branch 'upstream/main' into int128-abi-merge
AndyAyersMS 3e02186
- Update clr-abi with updated abi information for vector and other sp…
davidwrighton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -87,6 +87,26 @@ ABIPassingInformation WasmClassifier::Classify(Compiler* comp, | ||
| else | ||
| { | ||
| abiType = ToJitType(wasmAbiType); | ||
| // A struct wider than the wasm value it lowers to is passed by value across several | ||
| // of them, matching the wasm C ABI: Int128 as 2 x i64, a 256-bit vector as 2 x v128, | ||
| // a 512-bit vector as 4 x v128. A struct can be narrower than its value (see the | ||
| // segment size below), so this must compare sizes rather than count slots. | ||
| unsigned segSize = genTypeSize(abiType); | ||
| if (structLayout->GetSize() > segSize) | ||
| { | ||
| unsigned numSegs = structLayout->GetSize() / segSize; | ||
| assert((numSegs * segSize) == structLayout->GetSize()); | ||
| ABIPassingInformation info(comp, numSegs); | ||
| for (unsigned i = 0; i < numSegs; i++) | ||
| { | ||
| regNumber reg = MakeWasmReg(m_localIndex++, abiType); | ||
| info.Segment(i) = ABIPassingSegment::InRegister(reg, i * segSize, segSize); | ||
| } | ||
| return info; | ||
| } | ||
davidwrighton marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| } | ||
| regNumber reg = MakeWasmReg(m_localIndex++, genActualType(abiType)); | ||
77 changes: 74 additions & 3 deletions
77 src/coreclr/tools/Common/Compiler/CompilerTypeSystemContext.Wasm.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.