Uh oh!
There was an error while loading. Please reload this page.
Validate experimental Helix queues - #131589
Draft
wfurt wants to merge 5 commits into
Draft
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional public Helix target queues (including new Experimental queues) to the CoreCLR and libraries pipeline queue-selection templates to enable A/B comparison of queue behavior across Linux and Windows.
Changes:
- Expanded Linux x64 public queue lists to include
AzureLinux.3.Amd64.Experimental.Openand container-mapped variants. - Expanded Windows x64 public queue lists to include
Windows.11.Amd64.Client.OpenandWindows.11.Amd64.Experimental.Open. - Adjusted the libraries template’s Linux x64 “general set” selection to include the experimental queue entries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/pipelines/libraries/helix-queues-setup.yml | Adds experimental (and container-mapped) Azure Linux x64 queues and adds Windows 11 client + experimental queues to the primary Windows x64 set. |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Adds experimental Azure Linux x64 queues (and container-mapped variants) and switches public Windows x64 to Windows 11 client + experimental queues. |
Comment on lines
+71
to
+75
| # Compare standard and experimental Azure Linux queues on both the VM and container paths. | ||
| - AzureLinux.3.Amd64.Open | ||
| - AzureLinux.3.Amd64.Experimental.Open | ||
| - (AzureLinux.3.0.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64@sha256:1608f79ebd2c4f6da701818047b3b02bb91429f1086a775644b0aab0a857aab4 | ||
| - (AzureLinux.3.0.Amd64.Open)AzureLinux.3.Amd64.Experimental.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64@sha256:1608f79ebd2c4f6da701818047b3b02bb91429f1086a775644b0aab0a857aab4 |
Comment on lines
133
to
+135
| - Windows.Server2025.Amd64.Open | ||
| - Windows.11.Amd64.Client.Open | ||
| - Windows.11.Amd64.Experimental.Open |
Comment on lines
129
to
+132
| - AzureLinux.3.Amd64.Open | ||
| - AzureLinux.3.Amd64.Experimental.Open | ||
| - (AzureLinux.3.0.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64@sha256:1608f79ebd2c4f6da701818047b3b02bb91429f1086a775644b0aab0a857aab4 | ||
| - (AzureLinux.3.0.Amd64.Open)AzureLinux.3.Amd64.Experimental.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64@sha256:1608f79ebd2c4f6da701818047b3b02bb91429f1086a775644b0aab0a857aab4 |
Comment on lines
+153
to
+154
| - Windows.11.Amd64.Client.Open | ||
| - Windows.11.Amd64.Experimental.Open |
wfurt
commented
Aug 1, 2026
MemberAuthor
/azp run runtime Note This pipeline rerun was requested with GitHub Copilot to collect fresh experimental-queue diagnostics. |
|
No pipelines are associated with this pull request. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/libraries/helix-queues-setup.yml:135
- Adding
Windows.11.Amd64.Client.Opento the primary Windows queue list makes rolling builds (andincludeAllPlatforms) run that same queue twice, because it's already included under "Additional Windows versions". This can create redundant Helix work and longer CI times.
# Primary Windows versions for all builds: newest server + Nano (distinct environment)
- Windows.Server2025.Amd64.Open
- Windows.11.Amd64.Client.Open
- Windows.11.Amd64.Experimental.Open
eng/pipelines/coreclr/templates/helix-queues-setup.yml:154
- This changes the default public
windows_x64CoreCLR runs fromWindows.10.Amd64.OpentoWindows.11.Amd64.Client.Open(and adds an experimental queue). If the intent is to validate the new queue behavior while keeping existing OS coverage, consider keeping the previous Windows 10 queue as well, or make the choice parameter-driven (e.g., oldest vs latest) so comparisons and coverage are explicit.
- ${{ if and(eq(variables['System.TeamProject'], 'public'), ne(parameters.jobParameters.helixQueueGroup, 'cet')) }}:
- Windows.11.Amd64.Client.Open
- Windows.11.Amd64.Experimental.Open
wfurt
commented
Aug 5, 2026
MemberAuthor
/azp run runtime Re-triggering after the 2026-08-05 helix-machines rollout (PR 63589) which shipped |
|
No pipelines are associated with this pull request. |
# Conflicts: # eng/pipelines/libraries/helix-queues-setup.yml
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (3)
eng/pipelines/libraries/helix-queues-setup.yml:137
- Adding
Windows.11.Amd64.Client.Opento the primary Windows queues causes it to be listed twice on rolling builds / includeAllPlatforms (it already exists under "Additional Windows versions"). This will duplicate Helix submissions for that queue.
- Windows.11.Amd64.Client.Open
- Windows.11.Amd64.Experimental.Open
eng/pipelines/libraries/helix-queues-setup.yml:137
- The comment describing the "Primary Windows versions" is now inaccurate after adding the Windows 11 standard/experimental queues, and it implies Nano always runs even though it's conditional on non-mono. Updating this comment will help avoid confusion about the intended baseline coverage.
# Primary Windows versions for all builds: newest server + Nano (distinct environment)
- Windows.Server2025.Amd64.Open
- Windows.11.Amd64.Client.Open
- Windows.11.Amd64.Experimental.Open
eng/pipelines/coreclr/templates/helix-queues-setup.yml:132
- The pinned digest for
mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64differs between the CoreCLR and libraries Helix queue templates (this file uses@sha256:1608…, whileeng/pipelines/libraries/helix-queues-setup.ymluses@sha256:2c63…). If the goal is an A/B comparison with an identical container payload, these should be kept consistent (ideally sourced from a single shared value) to avoid drifting to different images.
- AzureLinux.3.Amd64.Open
- AzureLinux.3.Amd64.Experimental.Open
- (AzureLinux.3.0.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64@sha256:1608f79ebd2c4f6da701818047b3b02bb91429f1086a775644b0aab0a857aab4
- (AzureLinux.3.0.Amd64.Open)AzureLinux.3.Amd64.Experimental.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64@sha256:1608f79ebd2c4f6da701818047b3b02bb91429f1086a775644b0aab0a857aab4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation-only change; not intended for submission or merge.
Runs public x64 CoreCLR and libraries test payloads on the new experimental Helix queues alongside their standard counterparts for A/B comparison:
AzureLinux.3.Amd64.OpenandAzureLinux.3.Amd64.Experimental.OpenWindows.11.Amd64.Client.OpenandWindows.11.Amd64.Experimental.OpenLinux coverage exercises both direct VM execution and the same pinned Azure Linux 3 container image on each host queue, keeping the payload constant while comparing queue behavior.
Validation performed locally:
azurelinux-3.0-helix-amd64image is publishedgit diff --checkNote
This pull request description was generated with GitHub Copilot.