Remove calli target tagging from CoreCLR interop stubs

[Copilot]

This change removes the (target << 1) | 1 encoding previously used for marshaling-required unmanaged calli paths. MethodDesc and unmanaged target handling now follow their actual storage semantics instead of relying on low-bit tagging.

Fixes#131606

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[azure-pipelines]

Azure Pipelines:
Successfully started running 6 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[azure-pipelines]

Azure Pipelines:
Successfully started running 7 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameHelpers.cs:402

• UsesInlinedCallFrameStackSizeSentinel() re-parses Constants.Globals.Architecture directly, duplicating RuntimeInfo_1.ReadArchitecture and bypassing the existing RuntimeInfo contract caching/normalization. FrameHelpers already depends on _target.Contracts.RuntimeInfo elsewhere (GetFirstArgRegisterName), so this can be simplified and made consistent by querying IRuntimeInfo instead of re-reading globals here.

 private bool UsesInlinedCallFrameStackSizeSentinel()
{
if (_target.PointerSize != sizeof(uint))
{
return false;
}
if (_target.TryReadGlobalString(Constants.Globals.Architecture, out string? arch)
&& Enum.TryParse(arch, ignoreCase: true, out RuntimeInfoArchitecture runtimeArchitecture))
{
return runtimeArchitecture == RuntimeInfoArchitecture.X86;
}
return false;

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[jkotas]

@copilot Fix cdac test failures

Generated cDAC usage documentation is stale: StackWalk.md.\nTo update it, run from the repository root:\n pwsh .\src\native\managed\cdac\tools\CdacUsageGraph\generate-docs.ps1\nReview and commit the generated changes. If the generated dependencies are incorrect, fix the usage-graph analysis or add a narrowly scoped entry to docs\design\datacontracts\data-descriptor-overrides.json.

[Copilot]

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

[Copilot]

@copilot Fix cdac test failures

Generated cDAC usage documentation is stale: StackWalk.md.\nTo update it, run from the repository root:\n pwsh .\src\native\managed\cdac\tools\CdacUsageGraph\genera...

Fixed in 7d87b30.

I regenerated the StackWalk cDAC docs and updated the source meaning for InlinedCallFrame.Datum, so the generated StackWalk.md is back in sync.

Note

This reply was generated by GitHub Copilot.

[janvorli]

LGTM, thank you!

[jkotas]

/ba-g build analysis stuck