Skip to content

Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips - #131844

Merged
jkotas merged 2 commits into
mainfrom
copilot/replace-condition-with-conditionalfact
Aug 5, 2026
Merged

Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips#131844
jkotas merged 2 commits into
mainfrom
copilot/replace-condition-with-conditionalfact

Conversation

CopilotAI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #131110:

  • Deleted src/coreclr/clr.featuremultithreading.props and folded its FeatureMultithreading property definition into src/coreclr/clr.featuredefines.props, removing the now-unneeded Import/_ClrFeatureMultithreadingPropsImported indirection (including the import in src/tests/Directory.Build.props).
  • Replaced all Condition="'$(FeatureMultithreading)' != 'true'" build-time skip conditions (on CLRTestTargetUnsupported/RequiresProcessIsolation) in test .csproj/.ilproj files with runtime checks:
    • Tests with [Fact] entry points now use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))].
    • Tests with explicit static int Main(...) entry points now perform an early runtime check (if (!PlatformDetection.IsMultithreadingSupported) { ...; return 100; }).
  • Added missing TestLibrary project references / using TestLibrary; where PlatformDetection is newly referenced.

Compile-time FeatureMultithreading conditions unrelated to test skipping (e.g. in System.Private.CoreLib.Shared.projitems, src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj, eng/native.wasm.targets) were left unchanged, since these select source files/compile constants rather than gate test execution.

Note

This PR description and changes were generated with AI assistance (GitHub Copilot).

@jkotas
Fold clr.featuremultithreading.props into clr.featuredefines.props; r…
0cd6e53
…eplace FeatureMultithreading build conditions with ConditionalFact/runtime checks
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI review requested due to automatic review settings August 5, 2026 01:26
@azure-pipelines

azure-pipelinesBot commented Aug 5, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

CopilotAI requested a review from jkotasAugust 5, 2026 01:30
CopilotAI reviewed Aug 5, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates CoreCLR multithreading feature definition into clr.featuredefines.props (removing the standalone props + test import) and shifts test gating from MSBuild-time FeatureMultithreading conditions to runtime checks (mostly via ConditionalFact / PlatformDetection.IsMultithreadingSupported, or early-return Main checks for explicit-entrypoint tests).

Changes:

  • Fold FeatureMultithreading MSBuild property definition into src/coreclr/clr.featuredefines.props and remove the now-redundant test import/deleted props file.
  • Replace CLRTestTargetUnsupported / RequiresProcessIsolation MSBuild conditions based on $(FeatureMultithreading) with runtime multithreading gating in affected tests (ConditionalFact or early-return skip).
  • Add TestLibrary references/usings where needed for PlatformDetection.

Reviewed changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.

Show a summary per file
FileDescription
src/coreclr/clr.featuremultithreading.propsDeleted; definition is now folded into clr.featuredefines.props.
src/coreclr/clr.featuredefines.propsAdds FeatureMultithreading property definition directly (removes indirection import).
src/tests/Directory.Build.propsRemoves import of the deleted clr.featuremultithreading.props.
src/tests/Regressions/coreclr/GitHub_12224/Test12224.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b426654/b426654.ilprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Methodical/cctor/misc/threads2.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_ro.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_r.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_do.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_d.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/GC/Scenarios/THDList/thdlist.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDList/thdlist.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/THDChaos/thdchaos.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDChaos/thdchaos.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtree.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtree.csAdds runtime multithreading skip early in Main.
src/tests/GC/API/NoGCRegion/Callback.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/API/NoGCRegion/Callback.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/beta2/437044.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/576463/576463.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csAdds runtime multithreading skip early in Main.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/RecursiveException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/MultipleException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.

Comment threadsrc/tests/GC/Scenarios/THDList/thdlist.csproj Outdated
Comment threadsrc/tests/GC/Scenarios/THDChaos/thdchaos.csproj Outdated
Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csproj Outdated
Comment threadsrc/tests/GC/Scenarios/BinTree/thdtree.csproj Outdated
Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreelivingobj.csproj Outdated
@jkotas

jkotas commented Aug 5, 2026

Copy link
Copy Markdown
Member

@copilot Apply all feedback above

@jkotas
jkotas marked this pull request as ready for review August 5, 2026 01:38
@jkotas
jkotas requested a review from radekdoulikAugust 5, 2026 01:38
@azure-pipelines

azure-pipelinesBot commented Aug 5, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actionsgithub-actionsBot added the area-Infrastructure-coreclr Only use for closed issues label Aug 5, 2026
@jkotas
Update GC scenario RequiresProcessIsolation comments
cdf6e5f
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI review requested due to automatic review settings August 5, 2026 01:41

CopilotAI commented Aug 5, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot Apply all feedback above

Applied in cdf6e5f: updated the affected GC scenario project comments so they no longer mention CLRTestTargetUnsupported.

CopilotAI reviewed Aug 5, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.

@jkotasjkotas mentioned this pull request Aug 5, 2026
Closed
@jkotas
jkotas merged commit 7548f91 into mainAug 5, 2026
116 of 118 checks passed
@jkotas
jkotas deleted the copilot/replace-condition-with-conditionalfact branch August 5, 2026 14:17
@dotnet-maestrodotnet-maestroBot mentioned this pull request Aug 6, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

@jkotasjkotas

Copilot code reviewCopilot

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

Runtime Infra
Status: Done

Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@jkoritzinsky
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips by Copilot · Pull Request #131844 · dotnet/runtime · GitHub
Skip to content
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips - #131844
Merged
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Aug 5, 2026
Merged
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips#131844
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Conversation
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
Summary
Follow-up to #131110:
  • Deleted src/coreclr/clr.featuremultithreading.props and folded its FeatureMultithreading property definition into src/coreclr/clr.featuredefines.props, removing the now-unneeded Import/_ClrFeatureMultithreadingPropsImported indirection (including the import in src/tests/Directory.Build.props).
  • Replaced all Condition="'$(FeatureMultithreading)' != 'true'" build-time skip conditions (on CLRTestTargetUnsupported/RequiresProcessIsolation) in test .csproj/.ilproj files with runtime checks:

    • Tests with [Fact] entry points now use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))].
    • Tests with explicit static int Main(...) entry points now perform an early runtime check (if (!PlatformDetection.IsMultithreadingSupported) { ...; return 100; }).
  • Added missing TestLibrary project references / using TestLibrary; where PlatformDetection is newly referenced.
Compile-time FeatureMultithreading conditions unrelated to test skipping (e.g. in System.Private.CoreLib.Shared.projitems, src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj, eng/native.wasm.targets) were left unchanged, since these select source files/compile constants rather than gate test execution.
Note
This PR description and changes were generated with AI assistance (GitHub Copilot).
@jkotas
Fold clr.featuremultithreading.props into clr.featuredefines.props; r…
0cd6e53
…eplace FeatureMultithreading build conditions with ConditionalFact/runtime checks
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:26
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
CopilotAI
requested a review
from jkotasAugust 5, 2026 01:30
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR consolidates CoreCLR multithreading feature definition into clr.featuredefines.props (removing the standalone props + test import) and shifts test gating from MSBuild-time FeatureMultithreading conditions to runtime checks (mostly via ConditionalFact / PlatformDetection.IsMultithreadingSupported, or early-return Main checks for explicit-entrypoint tests).
Changes:
  • Fold FeatureMultithreading MSBuild property definition into src/coreclr/clr.featuredefines.props and remove the now-redundant test import/deleted props file.
  • Replace CLRTestTargetUnsupported / RequiresProcessIsolation MSBuild conditions based on $(FeatureMultithreading) with runtime multithreading gating in affected tests (ConditionalFact or early-return skip).
  • Add TestLibrary references/usings where needed for PlatformDetection.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.
Show a summary per file
FileDescription
src/coreclr/clr.featuremultithreading.propsDeleted; definition is now folded into clr.featuredefines.props.
src/coreclr/clr.featuredefines.propsAdds FeatureMultithreading property definition directly (removes indirection import).
src/tests/Directory.Build.propsRemoves import of the deleted clr.featuremultithreading.props.
src/tests/Regressions/coreclr/GitHub_12224/Test12224.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b426654/b426654.ilprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Methodical/cctor/misc/threads2.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_ro.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_r.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_do.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_d.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/GC/Scenarios/THDList/thdlist.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDList/thdlist.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/THDChaos/thdchaos.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDChaos/thdchaos.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtree.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtree.csAdds runtime multithreading skip early in Main.
src/tests/GC/API/NoGCRegion/Callback.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/API/NoGCRegion/Callback.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/beta2/437044.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/576463/576463.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csAdds runtime multithreading skip early in Main.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/RecursiveException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/MultipleException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
Comment threadsrc/tests/GC/Scenarios/THDList/thdlist.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/THDChaos/thdchaos.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtree.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreelivingobj.csproj
Outdated

@jkotas
jkotas
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@copilot Apply all feedback above
@jkotas
jkotas
marked this pull request as ready for review
August 5, 2026 01:38
@jkotas
jkotas
requested a review
from radekdoulikAugust 5, 2026 01:38
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@github-actionsgithub-actionsBot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Aug 5, 2026
@jkotas
Update GC scenario RequiresProcessIsolation comments
cdf6e5f
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:41
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@copilot Apply all feedback above
Applied in cdf6e5f: updated the affected GC scenario project comments so they no longer mention CLRTestTargetUnsupported.
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
@jkotasjkotas
mentioned this pull request
Aug 5, 2026

Closed

@jkotas
jkotas
merged commit 7548f91
into
mainAug 5, 2026

116 of 118 checks passed

@jkotas
jkotas
deleted the

copilot/replace-condition-with-conditionalfact

branch
August 5, 2026 14:17
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 6, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

@jkotasjkotas
Copilot code reviewCopilot

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

Runtime Infra

Status: Done


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips by Copilot · Pull Request #131844 · dotnet/runtime · GitHub
Skip to content
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips - #131844
Merged
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Aug 5, 2026
Merged
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips#131844
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Conversation
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
Summary
Follow-up to #131110:
  • Deleted src/coreclr/clr.featuremultithreading.props and folded its FeatureMultithreading property definition into src/coreclr/clr.featuredefines.props, removing the now-unneeded Import/_ClrFeatureMultithreadingPropsImported indirection (including the import in src/tests/Directory.Build.props).
  • Replaced all Condition="'$(FeatureMultithreading)' != 'true'" build-time skip conditions (on CLRTestTargetUnsupported/RequiresProcessIsolation) in test .csproj/.ilproj files with runtime checks:

    • Tests with [Fact] entry points now use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))].
    • Tests with explicit static int Main(...) entry points now perform an early runtime check (if (!PlatformDetection.IsMultithreadingSupported) { ...; return 100; }).
  • Added missing TestLibrary project references / using TestLibrary; where PlatformDetection is newly referenced.
Compile-time FeatureMultithreading conditions unrelated to test skipping (e.g. in System.Private.CoreLib.Shared.projitems, src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj, eng/native.wasm.targets) were left unchanged, since these select source files/compile constants rather than gate test execution.
Note
This PR description and changes were generated with AI assistance (GitHub Copilot).
@jkotas
Fold clr.featuremultithreading.props into clr.featuredefines.props; r…
0cd6e53
…eplace FeatureMultithreading build conditions with ConditionalFact/runtime checks
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:26
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
CopilotAI
requested a review
from jkotasAugust 5, 2026 01:30
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR consolidates CoreCLR multithreading feature definition into clr.featuredefines.props (removing the standalone props + test import) and shifts test gating from MSBuild-time FeatureMultithreading conditions to runtime checks (mostly via ConditionalFact / PlatformDetection.IsMultithreadingSupported, or early-return Main checks for explicit-entrypoint tests).
Changes:
  • Fold FeatureMultithreading MSBuild property definition into src/coreclr/clr.featuredefines.props and remove the now-redundant test import/deleted props file.
  • Replace CLRTestTargetUnsupported / RequiresProcessIsolation MSBuild conditions based on $(FeatureMultithreading) with runtime multithreading gating in affected tests (ConditionalFact or early-return skip).
  • Add TestLibrary references/usings where needed for PlatformDetection.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.
Show a summary per file
FileDescription
src/coreclr/clr.featuremultithreading.propsDeleted; definition is now folded into clr.featuredefines.props.
src/coreclr/clr.featuredefines.propsAdds FeatureMultithreading property definition directly (removes indirection import).
src/tests/Directory.Build.propsRemoves import of the deleted clr.featuremultithreading.props.
src/tests/Regressions/coreclr/GitHub_12224/Test12224.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b426654/b426654.ilprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Methodical/cctor/misc/threads2.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_ro.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_r.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_do.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_d.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/GC/Scenarios/THDList/thdlist.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDList/thdlist.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/THDChaos/thdchaos.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDChaos/thdchaos.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtree.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtree.csAdds runtime multithreading skip early in Main.
src/tests/GC/API/NoGCRegion/Callback.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/API/NoGCRegion/Callback.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/beta2/437044.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/576463/576463.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csAdds runtime multithreading skip early in Main.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/RecursiveException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/MultipleException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
Comment threadsrc/tests/GC/Scenarios/THDList/thdlist.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/THDChaos/thdchaos.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtree.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreelivingobj.csproj
Outdated

@jkotas
jkotas
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@copilot Apply all feedback above
@jkotas
jkotas
marked this pull request as ready for review
August 5, 2026 01:38
@jkotas
jkotas
requested a review
from radekdoulikAugust 5, 2026 01:38
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@github-actionsgithub-actionsBot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Aug 5, 2026
@jkotas
Update GC scenario RequiresProcessIsolation comments
cdf6e5f
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:41
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@copilot Apply all feedback above
Applied in cdf6e5f: updated the affected GC scenario project comments so they no longer mention CLRTestTargetUnsupported.
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
@jkotasjkotas
mentioned this pull request
Aug 5, 2026

Closed

@jkotas
jkotas
merged commit 7548f91
into
mainAug 5, 2026

116 of 118 checks passed

@jkotas
jkotas
deleted the

copilot/replace-condition-with-conditionalfact

branch
August 5, 2026 14:17
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 6, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

@jkotasjkotas
Copilot code reviewCopilot

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

Runtime Infra

Status: Done


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips by Copilot · Pull Request #131844 · dotnet/runtime · GitHub
Skip to content
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips - #131844
Merged
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Aug 5, 2026
Merged
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips#131844
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Conversation
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
Summary
Follow-up to #131110:
  • Deleted src/coreclr/clr.featuremultithreading.props and folded its FeatureMultithreading property definition into src/coreclr/clr.featuredefines.props, removing the now-unneeded Import/_ClrFeatureMultithreadingPropsImported indirection (including the import in src/tests/Directory.Build.props).
  • Replaced all Condition="'$(FeatureMultithreading)' != 'true'" build-time skip conditions (on CLRTestTargetUnsupported/RequiresProcessIsolation) in test .csproj/.ilproj files with runtime checks:

    • Tests with [Fact] entry points now use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))].
    • Tests with explicit static int Main(...) entry points now perform an early runtime check (if (!PlatformDetection.IsMultithreadingSupported) { ...; return 100; }).
  • Added missing TestLibrary project references / using TestLibrary; where PlatformDetection is newly referenced.
Compile-time FeatureMultithreading conditions unrelated to test skipping (e.g. in System.Private.CoreLib.Shared.projitems, src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj, eng/native.wasm.targets) were left unchanged, since these select source files/compile constants rather than gate test execution.
Note
This PR description and changes were generated with AI assistance (GitHub Copilot).
@jkotas
Fold clr.featuremultithreading.props into clr.featuredefines.props; r…
0cd6e53
…eplace FeatureMultithreading build conditions with ConditionalFact/runtime checks
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:26
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
CopilotAI
requested a review
from jkotasAugust 5, 2026 01:30
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR consolidates CoreCLR multithreading feature definition into clr.featuredefines.props (removing the standalone props + test import) and shifts test gating from MSBuild-time FeatureMultithreading conditions to runtime checks (mostly via ConditionalFact / PlatformDetection.IsMultithreadingSupported, or early-return Main checks for explicit-entrypoint tests).
Changes:
  • Fold FeatureMultithreading MSBuild property definition into src/coreclr/clr.featuredefines.props and remove the now-redundant test import/deleted props file.
  • Replace CLRTestTargetUnsupported / RequiresProcessIsolation MSBuild conditions based on $(FeatureMultithreading) with runtime multithreading gating in affected tests (ConditionalFact or early-return skip).
  • Add TestLibrary references/usings where needed for PlatformDetection.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.
Show a summary per file
FileDescription
src/coreclr/clr.featuremultithreading.propsDeleted; definition is now folded into clr.featuredefines.props.
src/coreclr/clr.featuredefines.propsAdds FeatureMultithreading property definition directly (removes indirection import).
src/tests/Directory.Build.propsRemoves import of the deleted clr.featuremultithreading.props.
src/tests/Regressions/coreclr/GitHub_12224/Test12224.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b426654/b426654.ilprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Methodical/cctor/misc/threads2.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_ro.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_r.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_do.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_d.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/GC/Scenarios/THDList/thdlist.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDList/thdlist.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/THDChaos/thdchaos.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDChaos/thdchaos.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtree.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtree.csAdds runtime multithreading skip early in Main.
src/tests/GC/API/NoGCRegion/Callback.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/API/NoGCRegion/Callback.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/beta2/437044.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/576463/576463.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csAdds runtime multithreading skip early in Main.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/RecursiveException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/MultipleException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
Comment threadsrc/tests/GC/Scenarios/THDList/thdlist.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/THDChaos/thdchaos.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtree.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreelivingobj.csproj
Outdated

@jkotas
jkotas
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@copilot Apply all feedback above
@jkotas
jkotas
marked this pull request as ready for review
August 5, 2026 01:38
@jkotas
jkotas
requested a review
from radekdoulikAugust 5, 2026 01:38
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@github-actionsgithub-actionsBot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Aug 5, 2026
@jkotas
Update GC scenario RequiresProcessIsolation comments
cdf6e5f
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:41
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@copilot Apply all feedback above
Applied in cdf6e5f: updated the affected GC scenario project comments so they no longer mention CLRTestTargetUnsupported.
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
@jkotasjkotas
mentioned this pull request
Aug 5, 2026

Closed

@jkotas
jkotas
merged commit 7548f91
into
mainAug 5, 2026

116 of 118 checks passed

@jkotas
jkotas
deleted the

copilot/replace-condition-with-conditionalfact

branch
August 5, 2026 14:17
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 6, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

@jkotasjkotas
Copilot code reviewCopilot

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

Runtime Infra

Status: Done


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips by Copilot · Pull Request #131844 · dotnet/runtime · GitHub
Skip to content
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips - #131844
Merged
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Aug 5, 2026
Merged
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips#131844
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Conversation
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
Summary
Follow-up to #131110:
  • Deleted src/coreclr/clr.featuremultithreading.props and folded its FeatureMultithreading property definition into src/coreclr/clr.featuredefines.props, removing the now-unneeded Import/_ClrFeatureMultithreadingPropsImported indirection (including the import in src/tests/Directory.Build.props).
  • Replaced all Condition="'$(FeatureMultithreading)' != 'true'" build-time skip conditions (on CLRTestTargetUnsupported/RequiresProcessIsolation) in test .csproj/.ilproj files with runtime checks:

    • Tests with [Fact] entry points now use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))].
    • Tests with explicit static int Main(...) entry points now perform an early runtime check (if (!PlatformDetection.IsMultithreadingSupported) { ...; return 100; }).
  • Added missing TestLibrary project references / using TestLibrary; where PlatformDetection is newly referenced.
Compile-time FeatureMultithreading conditions unrelated to test skipping (e.g. in System.Private.CoreLib.Shared.projitems, src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj, eng/native.wasm.targets) were left unchanged, since these select source files/compile constants rather than gate test execution.
Note
This PR description and changes were generated with AI assistance (GitHub Copilot).
@jkotas
Fold clr.featuremultithreading.props into clr.featuredefines.props; r…
0cd6e53
…eplace FeatureMultithreading build conditions with ConditionalFact/runtime checks
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:26
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
CopilotAI
requested a review
from jkotasAugust 5, 2026 01:30
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR consolidates CoreCLR multithreading feature definition into clr.featuredefines.props (removing the standalone props + test import) and shifts test gating from MSBuild-time FeatureMultithreading conditions to runtime checks (mostly via ConditionalFact / PlatformDetection.IsMultithreadingSupported, or early-return Main checks for explicit-entrypoint tests).
Changes:
  • Fold FeatureMultithreading MSBuild property definition into src/coreclr/clr.featuredefines.props and remove the now-redundant test import/deleted props file.
  • Replace CLRTestTargetUnsupported / RequiresProcessIsolation MSBuild conditions based on $(FeatureMultithreading) with runtime multithreading gating in affected tests (ConditionalFact or early-return skip).
  • Add TestLibrary references/usings where needed for PlatformDetection.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.
Show a summary per file
FileDescription
src/coreclr/clr.featuremultithreading.propsDeleted; definition is now folded into clr.featuredefines.props.
src/coreclr/clr.featuredefines.propsAdds FeatureMultithreading property definition directly (removes indirection import).
src/tests/Directory.Build.propsRemoves import of the deleted clr.featuremultithreading.props.
src/tests/Regressions/coreclr/GitHub_12224/Test12224.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b426654/b426654.ilprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Methodical/cctor/misc/threads2.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_ro.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_r.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_do.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_d.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/GC/Scenarios/THDList/thdlist.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDList/thdlist.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/THDChaos/thdchaos.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDChaos/thdchaos.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtree.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtree.csAdds runtime multithreading skip early in Main.
src/tests/GC/API/NoGCRegion/Callback.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/API/NoGCRegion/Callback.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/beta2/437044.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/576463/576463.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csAdds runtime multithreading skip early in Main.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/RecursiveException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/MultipleException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
Comment threadsrc/tests/GC/Scenarios/THDList/thdlist.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/THDChaos/thdchaos.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtree.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreelivingobj.csproj
Outdated

@jkotas
jkotas
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@copilot Apply all feedback above
@jkotas
jkotas
marked this pull request as ready for review
August 5, 2026 01:38
@jkotas
jkotas
requested a review
from radekdoulikAugust 5, 2026 01:38
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@github-actionsgithub-actionsBot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Aug 5, 2026
@jkotas
Update GC scenario RequiresProcessIsolation comments
cdf6e5f
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:41
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@copilot Apply all feedback above
Applied in cdf6e5f: updated the affected GC scenario project comments so they no longer mention CLRTestTargetUnsupported.
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
@jkotasjkotas
mentioned this pull request
Aug 5, 2026

Closed

@jkotas
jkotas
merged commit 7548f91
into
mainAug 5, 2026

116 of 118 checks passed

@jkotas
jkotas
deleted the

copilot/replace-condition-with-conditionalfact

branch
August 5, 2026 14:17
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 6, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

@jkotasjkotas
Copilot code reviewCopilot

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

Runtime Infra

Status: Done


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips by Copilot · Pull Request #131844 · dotnet/runtime · GitHub
Skip to content
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips - #131844
Merged
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Aug 5, 2026
Merged
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips#131844
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Conversation
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
Summary
Follow-up to #131110:
  • Deleted src/coreclr/clr.featuremultithreading.props and folded its FeatureMultithreading property definition into src/coreclr/clr.featuredefines.props, removing the now-unneeded Import/_ClrFeatureMultithreadingPropsImported indirection (including the import in src/tests/Directory.Build.props).
  • Replaced all Condition="'$(FeatureMultithreading)' != 'true'" build-time skip conditions (on CLRTestTargetUnsupported/RequiresProcessIsolation) in test .csproj/.ilproj files with runtime checks:

    • Tests with [Fact] entry points now use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))].
    • Tests with explicit static int Main(...) entry points now perform an early runtime check (if (!PlatformDetection.IsMultithreadingSupported) { ...; return 100; }).
  • Added missing TestLibrary project references / using TestLibrary; where PlatformDetection is newly referenced.
Compile-time FeatureMultithreading conditions unrelated to test skipping (e.g. in System.Private.CoreLib.Shared.projitems, src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj, eng/native.wasm.targets) were left unchanged, since these select source files/compile constants rather than gate test execution.
Note
This PR description and changes were generated with AI assistance (GitHub Copilot).
@jkotas
Fold clr.featuremultithreading.props into clr.featuredefines.props; r…
0cd6e53
…eplace FeatureMultithreading build conditions with ConditionalFact/runtime checks
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:26
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
CopilotAI
requested a review
from jkotasAugust 5, 2026 01:30
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR consolidates CoreCLR multithreading feature definition into clr.featuredefines.props (removing the standalone props + test import) and shifts test gating from MSBuild-time FeatureMultithreading conditions to runtime checks (mostly via ConditionalFact / PlatformDetection.IsMultithreadingSupported, or early-return Main checks for explicit-entrypoint tests).
Changes:
  • Fold FeatureMultithreading MSBuild property definition into src/coreclr/clr.featuredefines.props and remove the now-redundant test import/deleted props file.
  • Replace CLRTestTargetUnsupported / RequiresProcessIsolation MSBuild conditions based on $(FeatureMultithreading) with runtime multithreading gating in affected tests (ConditionalFact or early-return skip).
  • Add TestLibrary references/usings where needed for PlatformDetection.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.
Show a summary per file
FileDescription
src/coreclr/clr.featuremultithreading.propsDeleted; definition is now folded into clr.featuredefines.props.
src/coreclr/clr.featuredefines.propsAdds FeatureMultithreading property definition directly (removes indirection import).
src/tests/Directory.Build.propsRemoves import of the deleted clr.featuremultithreading.props.
src/tests/Regressions/coreclr/GitHub_12224/Test12224.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b426654/b426654.ilprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Methodical/cctor/misc/threads2.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_ro.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_r.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_do.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_d.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/GC/Scenarios/THDList/thdlist.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDList/thdlist.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/THDChaos/thdchaos.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDChaos/thdchaos.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtree.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtree.csAdds runtime multithreading skip early in Main.
src/tests/GC/API/NoGCRegion/Callback.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/API/NoGCRegion/Callback.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/beta2/437044.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/576463/576463.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csAdds runtime multithreading skip early in Main.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/RecursiveException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/MultipleException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
Comment threadsrc/tests/GC/Scenarios/THDList/thdlist.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/THDChaos/thdchaos.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtree.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreelivingobj.csproj
Outdated

@jkotas
jkotas
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@copilot Apply all feedback above
@jkotas
jkotas
marked this pull request as ready for review
August 5, 2026 01:38
@jkotas
jkotas
requested a review
from radekdoulikAugust 5, 2026 01:38
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@github-actionsgithub-actionsBot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Aug 5, 2026
@jkotas
Update GC scenario RequiresProcessIsolation comments
cdf6e5f
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:41
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@copilot Apply all feedback above
Applied in cdf6e5f: updated the affected GC scenario project comments so they no longer mention CLRTestTargetUnsupported.
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
@jkotasjkotas
mentioned this pull request
Aug 5, 2026

Closed

@jkotas
jkotas
merged commit 7548f91
into
mainAug 5, 2026

116 of 118 checks passed

@jkotas
jkotas
deleted the

copilot/replace-condition-with-conditionalfact

branch
August 5, 2026 14:17
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 6, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

@jkotasjkotas
Copilot code reviewCopilot

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

Runtime Infra

Status: Done


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips by Copilot · Pull Request #131844 · dotnet/runtime · GitHub
Skip to content
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips - #131844
Merged
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Aug 5, 2026
Merged
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips#131844
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Conversation
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
Summary
Follow-up to #131110:
  • Deleted src/coreclr/clr.featuremultithreading.props and folded its FeatureMultithreading property definition into src/coreclr/clr.featuredefines.props, removing the now-unneeded Import/_ClrFeatureMultithreadingPropsImported indirection (including the import in src/tests/Directory.Build.props).
  • Replaced all Condition="'$(FeatureMultithreading)' != 'true'" build-time skip conditions (on CLRTestTargetUnsupported/RequiresProcessIsolation) in test .csproj/.ilproj files with runtime checks:

    • Tests with [Fact] entry points now use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))].
    • Tests with explicit static int Main(...) entry points now perform an early runtime check (if (!PlatformDetection.IsMultithreadingSupported) { ...; return 100; }).
  • Added missing TestLibrary project references / using TestLibrary; where PlatformDetection is newly referenced.
Compile-time FeatureMultithreading conditions unrelated to test skipping (e.g. in System.Private.CoreLib.Shared.projitems, src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj, eng/native.wasm.targets) were left unchanged, since these select source files/compile constants rather than gate test execution.
Note
This PR description and changes were generated with AI assistance (GitHub Copilot).
@jkotas
Fold clr.featuremultithreading.props into clr.featuredefines.props; r…
0cd6e53
…eplace FeatureMultithreading build conditions with ConditionalFact/runtime checks
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:26
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
CopilotAI
requested a review
from jkotasAugust 5, 2026 01:30
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR consolidates CoreCLR multithreading feature definition into clr.featuredefines.props (removing the standalone props + test import) and shifts test gating from MSBuild-time FeatureMultithreading conditions to runtime checks (mostly via ConditionalFact / PlatformDetection.IsMultithreadingSupported, or early-return Main checks for explicit-entrypoint tests).
Changes:
  • Fold FeatureMultithreading MSBuild property definition into src/coreclr/clr.featuredefines.props and remove the now-redundant test import/deleted props file.
  • Replace CLRTestTargetUnsupported / RequiresProcessIsolation MSBuild conditions based on $(FeatureMultithreading) with runtime multithreading gating in affected tests (ConditionalFact or early-return skip).
  • Add TestLibrary references/usings where needed for PlatformDetection.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.
Show a summary per file
FileDescription
src/coreclr/clr.featuremultithreading.propsDeleted; definition is now folded into clr.featuredefines.props.
src/coreclr/clr.featuredefines.propsAdds FeatureMultithreading property definition directly (removes indirection import).
src/tests/Directory.Build.propsRemoves import of the deleted clr.featuremultithreading.props.
src/tests/Regressions/coreclr/GitHub_12224/Test12224.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b426654/b426654.ilprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Methodical/cctor/misc/threads2.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_ro.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_r.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_do.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_d.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/GC/Scenarios/THDList/thdlist.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDList/thdlist.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/THDChaos/thdchaos.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDChaos/thdchaos.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtree.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtree.csAdds runtime multithreading skip early in Main.
src/tests/GC/API/NoGCRegion/Callback.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/API/NoGCRegion/Callback.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/beta2/437044.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/576463/576463.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csAdds runtime multithreading skip early in Main.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/RecursiveException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/MultipleException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
Comment threadsrc/tests/GC/Scenarios/THDList/thdlist.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/THDChaos/thdchaos.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtree.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreelivingobj.csproj
Outdated

@jkotas
jkotas
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@copilot Apply all feedback above
@jkotas
jkotas
marked this pull request as ready for review
August 5, 2026 01:38
@jkotas
jkotas
requested a review
from radekdoulikAugust 5, 2026 01:38
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@github-actionsgithub-actionsBot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Aug 5, 2026
@jkotas
Update GC scenario RequiresProcessIsolation comments
cdf6e5f
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:41
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@copilot Apply all feedback above
Applied in cdf6e5f: updated the affected GC scenario project comments so they no longer mention CLRTestTargetUnsupported.
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
@jkotasjkotas
mentioned this pull request
Aug 5, 2026

Closed

@jkotas
jkotas
merged commit 7548f91
into
mainAug 5, 2026

116 of 118 checks passed

@jkotas
jkotas
deleted the

copilot/replace-condition-with-conditionalfact

branch
August 5, 2026 14:17
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 6, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

@jkotasjkotas
Copilot code reviewCopilot

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

Runtime Infra

Status: Done


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@jkoritzinsky

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips by Copilot · Pull Request #131844 · dotnet/runtime · GitHub
Skip to content
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips - #131844
Merged
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Aug 5, 2026
Merged
Fold clr.featuremultithreading.props into clr.featuredefines.props; use ConditionalFact for FeatureMultithreading test skips#131844
jkotas merged 2 commits into
mainfrom 
copilot/replace-condition-with-conditionalfact
Conversation
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

Contributor
Summary
Follow-up to #131110:
  • Deleted src/coreclr/clr.featuremultithreading.props and folded its FeatureMultithreading property definition into src/coreclr/clr.featuredefines.props, removing the now-unneeded Import/_ClrFeatureMultithreadingPropsImported indirection (including the import in src/tests/Directory.Build.props).
  • Replaced all Condition="'$(FeatureMultithreading)' != 'true'" build-time skip conditions (on CLRTestTargetUnsupported/RequiresProcessIsolation) in test .csproj/.ilproj files with runtime checks:

    • Tests with [Fact] entry points now use [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))].
    • Tests with explicit static int Main(...) entry points now perform an early runtime check (if (!PlatformDetection.IsMultithreadingSupported) { ...; return 100; }).
  • Added missing TestLibrary project references / using TestLibrary; where PlatformDetection is newly referenced.
Compile-time FeatureMultithreading conditions unrelated to test skipping (e.g. in System.Private.CoreLib.Shared.projitems, src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj, eng/native.wasm.targets) were left unchanged, since these select source files/compile constants rather than gate test execution.
Note
This PR description and changes were generated with AI assistance (GitHub Copilot).
@jkotas
Fold clr.featuremultithreading.props into clr.featuredefines.props; r…
0cd6e53
…eplace FeatureMultithreading build conditions with ConditionalFact/runtime checks
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:26
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
CopilotAI
requested a review
from jkotasAugust 5, 2026 01:30
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR consolidates CoreCLR multithreading feature definition into clr.featuredefines.props (removing the standalone props + test import) and shifts test gating from MSBuild-time FeatureMultithreading conditions to runtime checks (mostly via ConditionalFact / PlatformDetection.IsMultithreadingSupported, or early-return Main checks for explicit-entrypoint tests).
Changes:
  • Fold FeatureMultithreading MSBuild property definition into src/coreclr/clr.featuredefines.props and remove the now-redundant test import/deleted props file.
  • Replace CLRTestTargetUnsupported / RequiresProcessIsolation MSBuild conditions based on $(FeatureMultithreading) with runtime multithreading gating in affected tests (ConditionalFact or early-return skip).
  • Add TestLibrary references/usings where needed for PlatformDetection.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.
Show a summary per file
FileDescription
src/coreclr/clr.featuremultithreading.propsDeleted; definition is now folded into clr.featuredefines.props.
src/coreclr/clr.featuredefines.propsAdds FeatureMultithreading property definition directly (removes indirection import).
src/tests/Directory.Build.propsRemoves import of the deleted clr.featuremultithreading.props.
src/tests/Regressions/coreclr/GitHub_12224/Test12224.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Regression/CLR-x86-JIT/V2.0-Beta2/b426654/b426654.ilprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/JIT/Methodical/cctor/misc/threads2.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_ro.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_r.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_do.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/JIT/Methodical/cctor/misc/threads2_cs_d.csprojRemoves MSBuild FeatureMultithreading gate; adds TestLibrary project reference.
src/tests/GC/Scenarios/THDList/thdlist.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDList/thdlist.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/THDChaos/thdchaos.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/THDChaos/thdchaos.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/GC/Scenarios/LeakGen/leakgenthrd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/DoublinkList/dlbigleakthd.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreelivingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csAdds runtime multithreading skip early in Main.
src/tests/GC/Scenarios/BinTree/thdtree.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/Scenarios/BinTree/thdtree.csAdds runtime multithreading skip early in Main.
src/tests/GC/API/NoGCRegion/Callback.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/GC/API/NoGCRegion/Callback.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/beta2/437044.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/threading/regressions/beta2/437017.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/threading/regressions/576463/576463.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating.
src/tests/baseservices/exceptions/UnhandledExceptionHandler/NoEffectInMainThread.csAdds runtime multithreading skip early in Main.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/RecursiveException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/NestedException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/MultipleException.csprojRemoves MSBuild FeatureMultithreading-based target-unsupported gating.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/V1/SEH/VJ/HandlerException.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csprojRemoves MSBuild FeatureMultithreading target-unsupported gating; adds TestLibrary project reference.
src/tests/baseservices/exceptions/regressions/Dev11/154243/dynamicmethodliveness.csSwitches to ConditionalFact using PlatformDetection.IsMultithreadingSupported.
Comment threadsrc/tests/GC/Scenarios/THDList/thdlist.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/THDChaos/thdchaos.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreegrowingobj.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtree.csproj
Outdated

Comment threadsrc/tests/GC/Scenarios/BinTree/thdtreelivingobj.csproj
Outdated

@jkotas
jkotas
commented
Aug 5, 2026

Copy link


Copy Markdown

Member
@copilot Apply all feedback above
@jkotas
jkotas
marked this pull request as ready for review
August 5, 2026 01:38
@jkotas
jkotas
requested a review
from radekdoulikAugust 5, 2026 01:38
@azure-pipelines
azure-pipelinesBot
commented
Aug 5, 2026

Copy link


Copy Markdown


Azure Pipelines:

Successfully started running 3 pipeline(s).

13 pipeline(s) were filtered out due to trigger conditions.

There may be pipelines that require an authorized user to comment /azp run to run.
@github-actionsgithub-actionsBot
added
the 
area-Infrastructure-coreclr
Only use for closed issues
label
Aug 5, 2026
@jkotas
Update GC scenario RequiresProcessIsolation comments
cdf6e5f
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
review requested due to automatic review settings
August 5, 2026 01:41
CopilotAI
commented
Aug 5, 2026

Copy link


Copy Markdown

ContributorAuthor
@copilot Apply all feedback above
Applied in cdf6e5f: updated the affected GC scenario project comments so they no longer mention CLRTestTargetUnsupported.
CopilotAI
reviewed
Aug 5, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated no new comments.
@jkotasjkotas
mentioned this pull request
Aug 5, 2026

Closed

@jkotas
jkotas
merged commit 7548f91
into
mainAug 5, 2026

116 of 118 checks passed

@jkotas
jkotas
deleted the

copilot/replace-condition-with-conditionalfact

branch
August 5, 2026 14:17
@dotnet-maestrodotnet-maestroBot
mentioned this pull request
Aug 6, 2026
 Merged

@dotnet-milestone-botdotnet-milestone-botBot
added this to the 11.0-rc1 milestone
Aug 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

@jkotasjkotas
Copilot code reviewCopilot

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

Runtime Infra

Status: Done


Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@jkoritzinsky