[cDAC] Add stackwalk DAC flags by rcj1 · Pull Request #131901 · dotnet/runtime

rcj1 · 2026-08-05T19:55:05Z

azure-pipelines · 2026-08-05T19:55:54Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-05T19:56:38Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the cDAC legacy IXCLRData stack-walk surface to accept flags for IXCLRDataTask.CreateStackWalk, and threads those flags through to ClrDataStackWalk to influence which frames are surfaced during enumeration.

Changes:

Change IXCLRDataTask.CreateStackWalk to take a new CLRDataStackWalkFlag enum instead of a raw uint.
Add CLRDataStackWalkFlag and plumb the flag type through ClrDataTask and ClrDataStackWalk.
Use the provided flags in ClrDataStackWalk to filter which StackWalkState values are considered “legacy visible”.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs	Updates the COM interface signature and introduces `CLRDataStackWalkFlag`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs	Propagates the new flag type through the task’s `CreateStackWalk` implementation (including legacy forwarding).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs	Stores the flags and applies them when deciding which frames to surface.

Copilot's findings

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs:86

This PR adds new flag-dependent behavior for IXCLRDataTask.CreateStackWalk, but the cDAC test suite does not currently exercise IXCLRDataStackWalk enumeration with non-zero flags (or validate that the filtered frame set stays in sync with the legacy DAC when _legacyImpl is present). Adding at least one unit/integration test covering the flag behavior would help prevent regressions.

 int IXCLRDataTask.CreateStackWalk(CLRDataStackWalkFlag flags, DacComNullableByRef<IXCLRDataStackWalk> stackWalk)
{
Contracts.ThreadData threadData = _target.Contracts.Thread.GetThreadData(_address);
if (threadData.State.HasFlag(Contracts.ThreadState.Unstarted))
return HResults.E_FAIL;
IXCLRDataStackWalk? legacyStackWalk = null;
if (_legacyImpl is not null)
{
DacComNullableByRef<IXCLRDataStackWalk> legacyStackWalkOut = new(isNullRef: false);
int hr = _legacyImpl.CreateStackWalk(flags, legacyStackWalkOut);
if (hr < 0)
return hr;
legacyStackWalk = legacyStackWalkOut.Interface;
}
stackWalk.Interface = new ClrDataStackWalk(_address, flags, _target, legacyStackWalk);
return HResults.S_OK;

Files reviewed: 3/3 changed files
Comments generated: 3

rcj1 · 2026-08-06T23:55:55Z

/ba-g #131956

Fixesdotnet#112366

rcj1 · 2026-08-05T19:55:05Z

Fixes#112366

azure-pipelines · 2026-08-05T19:55:54Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-05T19:56:38Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the cDAC legacy IXCLRData stack-walk surface to accept flags for IXCLRDataTask.CreateStackWalk, and threads those flags through to ClrDataStackWalk to influence which frames are surfaced during enumeration.

Changes:

Change IXCLRDataTask.CreateStackWalk to take a new CLRDataStackWalkFlag enum instead of a raw uint.
Add CLRDataStackWalkFlag and plumb the flag type through ClrDataTask and ClrDataStackWalk.
Use the provided flags in ClrDataStackWalk to filter which StackWalkState values are considered “legacy visible”.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs	Updates the COM interface signature and introduces `CLRDataStackWalkFlag`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs	Propagates the new flag type through the task’s `CreateStackWalk` implementation (including legacy forwarding).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs	Stores the flags and applies them when deciding which frames to surface.

Copilot's findings

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs:86

This PR adds new flag-dependent behavior for IXCLRDataTask.CreateStackWalk, but the cDAC test suite does not currently exercise IXCLRDataStackWalk enumeration with non-zero flags (or validate that the filtered frame set stays in sync with the legacy DAC when _legacyImpl is present). Adding at least one unit/integration test covering the flag behavior would help prevent regressions.

 int IXCLRDataTask.CreateStackWalk(CLRDataStackWalkFlag flags, DacComNullableByRef<IXCLRDataStackWalk> stackWalk)
{
Contracts.ThreadData threadData = _target.Contracts.Thread.GetThreadData(_address);
if (threadData.State.HasFlag(Contracts.ThreadState.Unstarted))
return HResults.E_FAIL;
IXCLRDataStackWalk? legacyStackWalk = null;
if (_legacyImpl is not null)
{
DacComNullableByRef<IXCLRDataStackWalk> legacyStackWalkOut = new(isNullRef: false);
int hr = _legacyImpl.CreateStackWalk(flags, legacyStackWalkOut);
if (hr < 0)
return hr;
legacyStackWalk = legacyStackWalkOut.Interface;
}
stackWalk.Interface = new ClrDataStackWalk(_address, flags, _target, legacyStackWalk);
return HResults.S_OK;

Files reviewed: 3/3 changed files
Comments generated: 3

rcj1 · 2026-08-06T23:55:55Z

/ba-g #131956

Fixesdotnet#112366

rcj1 · 2026-08-05T19:55:05Z

Fixes#112366

azure-pipelines · 2026-08-05T19:55:54Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-05T19:56:38Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the cDAC legacy IXCLRData stack-walk surface to accept flags for IXCLRDataTask.CreateStackWalk, and threads those flags through to ClrDataStackWalk to influence which frames are surfaced during enumeration.

Changes:

Change IXCLRDataTask.CreateStackWalk to take a new CLRDataStackWalkFlag enum instead of a raw uint.
Add CLRDataStackWalkFlag and plumb the flag type through ClrDataTask and ClrDataStackWalk.
Use the provided flags in ClrDataStackWalk to filter which StackWalkState values are considered “legacy visible”.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs	Updates the COM interface signature and introduces `CLRDataStackWalkFlag`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs	Propagates the new flag type through the task’s `CreateStackWalk` implementation (including legacy forwarding).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs	Stores the flags and applies them when deciding which frames to surface.

Copilot's findings

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs:86

This PR adds new flag-dependent behavior for IXCLRDataTask.CreateStackWalk, but the cDAC test suite does not currently exercise IXCLRDataStackWalk enumeration with non-zero flags (or validate that the filtered frame set stays in sync with the legacy DAC when _legacyImpl is present). Adding at least one unit/integration test covering the flag behavior would help prevent regressions.

 int IXCLRDataTask.CreateStackWalk(CLRDataStackWalkFlag flags, DacComNullableByRef<IXCLRDataStackWalk> stackWalk)
{
Contracts.ThreadData threadData = _target.Contracts.Thread.GetThreadData(_address);
if (threadData.State.HasFlag(Contracts.ThreadState.Unstarted))
return HResults.E_FAIL;
IXCLRDataStackWalk? legacyStackWalk = null;
if (_legacyImpl is not null)
{
DacComNullableByRef<IXCLRDataStackWalk> legacyStackWalkOut = new(isNullRef: false);
int hr = _legacyImpl.CreateStackWalk(flags, legacyStackWalkOut);
if (hr < 0)
return hr;
legacyStackWalk = legacyStackWalkOut.Interface;
}
stackWalk.Interface = new ClrDataStackWalk(_address, flags, _target, legacyStackWalk);
return HResults.S_OK;

Files reviewed: 3/3 changed files
Comments generated: 3

rcj1 · 2026-08-06T23:55:55Z

/ba-g #131956

Fixesdotnet#112366

rcj1 · 2026-08-05T19:55:05Z

Fixes#112366

azure-pipelines · 2026-08-05T19:55:54Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-05T19:56:38Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the cDAC legacy IXCLRData stack-walk surface to accept flags for IXCLRDataTask.CreateStackWalk, and threads those flags through to ClrDataStackWalk to influence which frames are surfaced during enumeration.

Changes:

Change IXCLRDataTask.CreateStackWalk to take a new CLRDataStackWalkFlag enum instead of a raw uint.
Add CLRDataStackWalkFlag and plumb the flag type through ClrDataTask and ClrDataStackWalk.
Use the provided flags in ClrDataStackWalk to filter which StackWalkState values are considered “legacy visible”.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs	Updates the COM interface signature and introduces `CLRDataStackWalkFlag`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs	Propagates the new flag type through the task’s `CreateStackWalk` implementation (including legacy forwarding).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs	Stores the flags and applies them when deciding which frames to surface.

Copilot's findings

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs:86

This PR adds new flag-dependent behavior for IXCLRDataTask.CreateStackWalk, but the cDAC test suite does not currently exercise IXCLRDataStackWalk enumeration with non-zero flags (or validate that the filtered frame set stays in sync with the legacy DAC when _legacyImpl is present). Adding at least one unit/integration test covering the flag behavior would help prevent regressions.

 int IXCLRDataTask.CreateStackWalk(CLRDataStackWalkFlag flags, DacComNullableByRef<IXCLRDataStackWalk> stackWalk)
{
Contracts.ThreadData threadData = _target.Contracts.Thread.GetThreadData(_address);
if (threadData.State.HasFlag(Contracts.ThreadState.Unstarted))
return HResults.E_FAIL;
IXCLRDataStackWalk? legacyStackWalk = null;
if (_legacyImpl is not null)
{
DacComNullableByRef<IXCLRDataStackWalk> legacyStackWalkOut = new(isNullRef: false);
int hr = _legacyImpl.CreateStackWalk(flags, legacyStackWalkOut);
if (hr < 0)
return hr;
legacyStackWalk = legacyStackWalkOut.Interface;
}
stackWalk.Interface = new ClrDataStackWalk(_address, flags, _target, legacyStackWalk);
return HResults.S_OK;

Files reviewed: 3/3 changed files
Comments generated: 3

rcj1 · 2026-08-06T23:55:55Z

/ba-g #131956

Fixesdotnet#112366

rcj1 · 2026-08-05T19:55:05Z

Fixes#112366

azure-pipelines · 2026-08-05T19:55:54Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-05T19:56:38Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the cDAC legacy IXCLRData stack-walk surface to accept flags for IXCLRDataTask.CreateStackWalk, and threads those flags through to ClrDataStackWalk to influence which frames are surfaced during enumeration.

Changes:

Change IXCLRDataTask.CreateStackWalk to take a new CLRDataStackWalkFlag enum instead of a raw uint.
Add CLRDataStackWalkFlag and plumb the flag type through ClrDataTask and ClrDataStackWalk.
Use the provided flags in ClrDataStackWalk to filter which StackWalkState values are considered “legacy visible”.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs	Updates the COM interface signature and introduces `CLRDataStackWalkFlag`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs	Propagates the new flag type through the task’s `CreateStackWalk` implementation (including legacy forwarding).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs	Stores the flags and applies them when deciding which frames to surface.

Copilot's findings

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs:86

This PR adds new flag-dependent behavior for IXCLRDataTask.CreateStackWalk, but the cDAC test suite does not currently exercise IXCLRDataStackWalk enumeration with non-zero flags (or validate that the filtered frame set stays in sync with the legacy DAC when _legacyImpl is present). Adding at least one unit/integration test covering the flag behavior would help prevent regressions.

 int IXCLRDataTask.CreateStackWalk(CLRDataStackWalkFlag flags, DacComNullableByRef<IXCLRDataStackWalk> stackWalk)
{
Contracts.ThreadData threadData = _target.Contracts.Thread.GetThreadData(_address);
if (threadData.State.HasFlag(Contracts.ThreadState.Unstarted))
return HResults.E_FAIL;
IXCLRDataStackWalk? legacyStackWalk = null;
if (_legacyImpl is not null)
{
DacComNullableByRef<IXCLRDataStackWalk> legacyStackWalkOut = new(isNullRef: false);
int hr = _legacyImpl.CreateStackWalk(flags, legacyStackWalkOut);
if (hr < 0)
return hr;
legacyStackWalk = legacyStackWalkOut.Interface;
}
stackWalk.Interface = new ClrDataStackWalk(_address, flags, _target, legacyStackWalk);
return HResults.S_OK;

Files reviewed: 3/3 changed files
Comments generated: 3

rcj1 · 2026-08-06T23:55:55Z

/ba-g #131956

Fixesdotnet#112366

rcj1 · 2026-08-05T19:55:05Z

Fixes#112366

azure-pipelines · 2026-08-05T19:55:54Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-05T19:56:38Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the cDAC legacy IXCLRData stack-walk surface to accept flags for IXCLRDataTask.CreateStackWalk, and threads those flags through to ClrDataStackWalk to influence which frames are surfaced during enumeration.

Changes:

Change IXCLRDataTask.CreateStackWalk to take a new CLRDataStackWalkFlag enum instead of a raw uint.
Add CLRDataStackWalkFlag and plumb the flag type through ClrDataTask and ClrDataStackWalk.
Use the provided flags in ClrDataStackWalk to filter which StackWalkState values are considered “legacy visible”.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs	Updates the COM interface signature and introduces `CLRDataStackWalkFlag`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs	Propagates the new flag type through the task’s `CreateStackWalk` implementation (including legacy forwarding).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs	Stores the flags and applies them when deciding which frames to surface.

Copilot's findings

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs:86

This PR adds new flag-dependent behavior for IXCLRDataTask.CreateStackWalk, but the cDAC test suite does not currently exercise IXCLRDataStackWalk enumeration with non-zero flags (or validate that the filtered frame set stays in sync with the legacy DAC when _legacyImpl is present). Adding at least one unit/integration test covering the flag behavior would help prevent regressions.

 int IXCLRDataTask.CreateStackWalk(CLRDataStackWalkFlag flags, DacComNullableByRef<IXCLRDataStackWalk> stackWalk)
{
Contracts.ThreadData threadData = _target.Contracts.Thread.GetThreadData(_address);
if (threadData.State.HasFlag(Contracts.ThreadState.Unstarted))
return HResults.E_FAIL;
IXCLRDataStackWalk? legacyStackWalk = null;
if (_legacyImpl is not null)
{
DacComNullableByRef<IXCLRDataStackWalk> legacyStackWalkOut = new(isNullRef: false);
int hr = _legacyImpl.CreateStackWalk(flags, legacyStackWalkOut);
if (hr < 0)
return hr;
legacyStackWalk = legacyStackWalkOut.Interface;
}
stackWalk.Interface = new ClrDataStackWalk(_address, flags, _target, legacyStackWalk);
return HResults.S_OK;

Files reviewed: 3/3 changed files
Comments generated: 3

rcj1 · 2026-08-06T23:55:55Z

/ba-g #131956

Fixesdotnet#112366

rcj1 · 2026-08-05T19:55:05Z

Fixes#112366

azure-pipelines · 2026-08-05T19:55:54Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-05T19:56:38Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the cDAC legacy IXCLRData stack-walk surface to accept flags for IXCLRDataTask.CreateStackWalk, and threads those flags through to ClrDataStackWalk to influence which frames are surfaced during enumeration.

Changes:

Change IXCLRDataTask.CreateStackWalk to take a new CLRDataStackWalkFlag enum instead of a raw uint.
Add CLRDataStackWalkFlag and plumb the flag type through ClrDataTask and ClrDataStackWalk.
Use the provided flags in ClrDataStackWalk to filter which StackWalkState values are considered “legacy visible”.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs	Updates the COM interface signature and introduces `CLRDataStackWalkFlag`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs	Propagates the new flag type through the task’s `CreateStackWalk` implementation (including legacy forwarding).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs	Stores the flags and applies them when deciding which frames to surface.

Copilot's findings

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs:86

This PR adds new flag-dependent behavior for IXCLRDataTask.CreateStackWalk, but the cDAC test suite does not currently exercise IXCLRDataStackWalk enumeration with non-zero flags (or validate that the filtered frame set stays in sync with the legacy DAC when _legacyImpl is present). Adding at least one unit/integration test covering the flag behavior would help prevent regressions.

 int IXCLRDataTask.CreateStackWalk(CLRDataStackWalkFlag flags, DacComNullableByRef<IXCLRDataStackWalk> stackWalk)
{
Contracts.ThreadData threadData = _target.Contracts.Thread.GetThreadData(_address);
if (threadData.State.HasFlag(Contracts.ThreadState.Unstarted))
return HResults.E_FAIL;
IXCLRDataStackWalk? legacyStackWalk = null;
if (_legacyImpl is not null)
{
DacComNullableByRef<IXCLRDataStackWalk> legacyStackWalkOut = new(isNullRef: false);
int hr = _legacyImpl.CreateStackWalk(flags, legacyStackWalkOut);
if (hr < 0)
return hr;
legacyStackWalk = legacyStackWalkOut.Interface;
}
stackWalk.Interface = new ClrDataStackWalk(_address, flags, _target, legacyStackWalk);
return HResults.S_OK;

Files reviewed: 3/3 changed files
Comments generated: 3

rcj1 · 2026-08-06T23:55:55Z

/ba-g #131956

Fixesdotnet#112366

rcj1 · 2026-08-05T19:55:05Z

Fixes#112366

azure-pipelines · 2026-08-05T19:55:54Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-05T19:56:38Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates the cDAC legacy IXCLRData stack-walk surface to accept flags for IXCLRDataTask.CreateStackWalk, and threads those flags through to ClrDataStackWalk to influence which frames are surfaced during enumeration.

Changes:

Change IXCLRDataTask.CreateStackWalk to take a new CLRDataStackWalkFlag enum instead of a raw uint.
Add CLRDataStackWalkFlag and plumb the flag type through ClrDataTask and ClrDataStackWalk.
Use the provided flags in ClrDataStackWalk to filter which StackWalkState values are considered “legacy visible”.

Show a summary per file

File	Description
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs	Updates the COM interface signature and introduces `CLRDataStackWalkFlag`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs	Propagates the new flag type through the task’s `CreateStackWalk` implementation (including legacy forwarding).
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs	Stores the flags and applies them when deciding which frames to surface.

Copilot's findings

Suppressed comments (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataTask.cs:86

This PR adds new flag-dependent behavior for IXCLRDataTask.CreateStackWalk, but the cDAC test suite does not currently exercise IXCLRDataStackWalk enumeration with non-zero flags (or validate that the filtered frame set stays in sync with the legacy DAC when _legacyImpl is present). Adding at least one unit/integration test covering the flag behavior would help prevent regressions.

 int IXCLRDataTask.CreateStackWalk(CLRDataStackWalkFlag flags, DacComNullableByRef<IXCLRDataStackWalk> stackWalk)
{
Contracts.ThreadData threadData = _target.Contracts.Thread.GetThreadData(_address);
if (threadData.State.HasFlag(Contracts.ThreadState.Unstarted))
return HResults.E_FAIL;
IXCLRDataStackWalk? legacyStackWalk = null;
if (_legacyImpl is not null)
{
DacComNullableByRef<IXCLRDataStackWalk> legacyStackWalkOut = new(isNullRef: false);
int hr = _legacyImpl.CreateStackWalk(flags, legacyStackWalkOut);
if (hr < 0)
return hr;
legacyStackWalk = legacyStackWalkOut.Interface;
}
stackWalk.Interface = new ClrDataStackWalk(_address, flags, _target, legacyStackWalk);
return HResults.S_OK;

Files reviewed: 3/3 changed files
Comments generated: 3

rcj1 · 2026-08-06T23:55:55Z

/ba-g #131956

Fixesdotnet#112366

add sw flags
714df81

CopilotAI review requested due to automatic review settings August 5, 2026 19:55

dotnet-policy-serviceBot assigned rcj1 Aug 5, 2026

github-actionsBot added the area-Diagnostics-cdac label Aug 5, 2026

Copilotstarted reviewing on behalf of rcj1 August 5, 2026 19:55 View session

CopilotAI reviewed Aug 5, 2026
View reviewed changes

max-charlamb approved these changes Aug 6, 2026
View reviewed changes

rcj1 merged commit 9bf3be3 into dotnet:mainAug 6, 2026
72 of 74 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8185
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
[cDAC] Add stackwalk DAC flags (dotnet#131901)
5d03a6a
Fixesdotnet#112366

add sw flags
714df81

CopilotAI review requested due to automatic review settings August 5, 2026 19:55

dotnet-policy-serviceBot assigned rcj1 Aug 5, 2026

github-actionsBot added the area-Diagnostics-cdac label Aug 5, 2026

Copilotstarted reviewing on behalf of rcj1 August 5, 2026 19:55 View session

CopilotAI reviewed Aug 5, 2026
View reviewed changes

max-charlamb approved these changes Aug 6, 2026
View reviewed changes

rcj1 merged commit 9bf3be3 into dotnet:mainAug 6, 2026
72 of 74 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8185
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
[cDAC] Add stackwalk DAC flags (dotnet#131901)
5d03a6a
Fixesdotnet#112366

add sw flags
714df81

CopilotAI review requested due to automatic review settings August 5, 2026 19:55

dotnet-policy-serviceBot assigned rcj1 Aug 5, 2026

github-actionsBot added the area-Diagnostics-cdac label Aug 5, 2026

Copilotstarted reviewing on behalf of rcj1 August 5, 2026 19:55 View session

CopilotAI reviewed Aug 5, 2026
View reviewed changes

max-charlamb approved these changes Aug 6, 2026
View reviewed changes

rcj1 merged commit 9bf3be3 into dotnet:mainAug 6, 2026
72 of 74 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8185
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
[cDAC] Add stackwalk DAC flags (dotnet#131901)
5d03a6a
Fixesdotnet#112366

add sw flags
714df81

CopilotAI review requested due to automatic review settings August 5, 2026 19:55

dotnet-policy-serviceBot assigned rcj1 Aug 5, 2026

github-actionsBot added the area-Diagnostics-cdac label Aug 5, 2026

Copilotstarted reviewing on behalf of rcj1 August 5, 2026 19:55 View session

CopilotAI reviewed Aug 5, 2026
View reviewed changes

max-charlamb approved these changes Aug 6, 2026
View reviewed changes

rcj1 merged commit 9bf3be3 into dotnet:mainAug 6, 2026
72 of 74 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8185
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
[cDAC] Add stackwalk DAC flags (dotnet#131901)
5d03a6a
Fixesdotnet#112366

add sw flags
714df81

CopilotAI review requested due to automatic review settings August 5, 2026 19:55

dotnet-policy-serviceBot assigned rcj1 Aug 5, 2026

github-actionsBot added the area-Diagnostics-cdac label Aug 5, 2026

Copilotstarted reviewing on behalf of rcj1 August 5, 2026 19:55 View session

CopilotAI reviewed Aug 5, 2026
View reviewed changes

max-charlamb approved these changes Aug 6, 2026
View reviewed changes

rcj1 merged commit 9bf3be3 into dotnet:mainAug 6, 2026
72 of 74 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8185
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
[cDAC] Add stackwalk DAC flags (dotnet#131901)
5d03a6a
Fixesdotnet#112366

add sw flags
714df81

CopilotAI review requested due to automatic review settings August 5, 2026 19:55

dotnet-policy-serviceBot assigned rcj1 Aug 5, 2026

github-actionsBot added the area-Diagnostics-cdac label Aug 5, 2026

Copilotstarted reviewing on behalf of rcj1 August 5, 2026 19:55 View session

CopilotAI reviewed Aug 5, 2026
View reviewed changes

max-charlamb approved these changes Aug 6, 2026
View reviewed changes

rcj1 merged commit 9bf3be3 into dotnet:mainAug 6, 2026
72 of 74 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8185
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
[cDAC] Add stackwalk DAC flags (dotnet#131901)
5d03a6a
Fixesdotnet#112366

add sw flags
714df81

CopilotAI review requested due to automatic review settings August 5, 2026 19:55

dotnet-policy-serviceBot assigned rcj1 Aug 5, 2026

github-actionsBot added the area-Diagnostics-cdac label Aug 5, 2026

Copilotstarted reviewing on behalf of rcj1 August 5, 2026 19:55 View session

CopilotAI reviewed Aug 5, 2026
View reviewed changes

max-charlamb approved these changes Aug 6, 2026
View reviewed changes

rcj1 merged commit 9bf3be3 into dotnet:mainAug 6, 2026
72 of 74 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8185
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
[cDAC] Add stackwalk DAC flags (dotnet#131901)
5d03a6a
Fixesdotnet#112366

add sw flags
714df81

CopilotAI review requested due to automatic review settings August 5, 2026 19:55

dotnet-policy-serviceBot assigned rcj1 Aug 5, 2026

github-actionsBot added the area-Diagnostics-cdac label Aug 5, 2026

Copilotstarted reviewing on behalf of rcj1 August 5, 2026 19:55 View session

CopilotAI reviewed Aug 5, 2026
View reviewed changes

max-charlamb approved these changes Aug 6, 2026
View reviewed changes

rcj1 merged commit 9bf3be3 into dotnet:mainAug 6, 2026
72 of 74 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8185
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
[cDAC] Add stackwalk DAC flags (dotnet#131901)
5d03a6a
Fixesdotnet#112366

Uh oh!

Conversation

rcj1 commented Aug 5, 2026

Uh oh!

azure-pipelinesBot commented Aug 5, 2026

Uh oh!

dotnet-policy-serviceBot commented Aug 5, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rcj1 commented Aug 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rcj1 commented Aug 5, 2026

Uh oh!

azure-pipelinesBot commented Aug 5, 2026

Uh oh!

dotnet-policy-serviceBot commented Aug 5, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rcj1 commented Aug 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rcj1 commented Aug 5, 2026

Uh oh!

azure-pipelinesBot commented Aug 5, 2026

Uh oh!

dotnet-policy-serviceBot commented Aug 5, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rcj1 commented Aug 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!