Improve TlsSession error diagnostics by rzikm · Pull Request #131943 · dotnet/runtime

rzikm · 2026-08-06T13:41:17Z

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

azure-pipelines · 2026-08-06T13:42:05Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-06T13:42:39Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refines OpenSSL/TlsSession error diagnostics by preserving errno across SSL_get_error in the native shims and switching TlsSession to build exceptions using the same inner-exception logic as SslStream (distinguishing EOF vs I/O error for SSL_ERROR_SYSCALL based on the raw SSL_* return value).

Changes:

Preserve errno across SSL_get_error for SSL_write, SSL_read, and SSL_do_handshake so SSL_ERROR_SYSCALL diagnostics remain accurate.
Make socket-replay BIO failures set deterministic errno values (and treat send() == 0 as retryable) to avoid surfacing stale errno.
Update TlsSession.OpenSsl to use Interop.OpenSsl.GetSslError(result, error) and pass raw SSL_* results; expose GetSslError as internal and enable SetLastError on SslDoHandshake.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/libs/System.Security.Cryptography.Native/pal_ssl.c	Preserve `errno` across `SSL_get_error` for read/write/handshake paths.
src/native/libs/System.Security.Cryptography.Native/pal_bio.c	Set deterministic `errno` for socket-replay BIO error cases; handle `send() == 0` as retry.
src/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs	Align exception creation with `SslStream` by using raw `SSL_*` result + `GetSslError`.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs	Enable `SetLastError` for `SslDoHandshake` so `errno` is observable from managed code.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs	Make `GetSslErrorinternal` for reuse by `TlsSession`.

wfurt

LGTM

rzikm · 2026-08-07T13:55:44Z

/ba-g QUIC test failure is unrelated

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

rzikm · 2026-08-06T13:41:17Z

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

azure-pipelines · 2026-08-06T13:42:05Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-06T13:42:39Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refines OpenSSL/TlsSession error diagnostics by preserving errno across SSL_get_error in the native shims and switching TlsSession to build exceptions using the same inner-exception logic as SslStream (distinguishing EOF vs I/O error for SSL_ERROR_SYSCALL based on the raw SSL_* return value).

Changes:

Preserve errno across SSL_get_error for SSL_write, SSL_read, and SSL_do_handshake so SSL_ERROR_SYSCALL diagnostics remain accurate.
Make socket-replay BIO failures set deterministic errno values (and treat send() == 0 as retryable) to avoid surfacing stale errno.
Update TlsSession.OpenSsl to use Interop.OpenSsl.GetSslError(result, error) and pass raw SSL_* results; expose GetSslError as internal and enable SetLastError on SslDoHandshake.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/libs/System.Security.Cryptography.Native/pal_ssl.c	Preserve `errno` across `SSL_get_error` for read/write/handshake paths.
src/native/libs/System.Security.Cryptography.Native/pal_bio.c	Set deterministic `errno` for socket-replay BIO error cases; handle `send() == 0` as retry.
src/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs	Align exception creation with `SslStream` by using raw `SSL_*` result + `GetSslError`.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs	Enable `SetLastError` for `SslDoHandshake` so `errno` is observable from managed code.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs	Make `GetSslErrorinternal` for reuse by `TlsSession`.

wfurt

LGTM

rzikm · 2026-08-07T13:55:44Z

/ba-g QUIC test failure is unrelated

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

rzikm · 2026-08-06T13:41:17Z

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

azure-pipelines · 2026-08-06T13:42:05Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-06T13:42:39Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refines OpenSSL/TlsSession error diagnostics by preserving errno across SSL_get_error in the native shims and switching TlsSession to build exceptions using the same inner-exception logic as SslStream (distinguishing EOF vs I/O error for SSL_ERROR_SYSCALL based on the raw SSL_* return value).

Changes:

Preserve errno across SSL_get_error for SSL_write, SSL_read, and SSL_do_handshake so SSL_ERROR_SYSCALL diagnostics remain accurate.
Make socket-replay BIO failures set deterministic errno values (and treat send() == 0 as retryable) to avoid surfacing stale errno.
Update TlsSession.OpenSsl to use Interop.OpenSsl.GetSslError(result, error) and pass raw SSL_* results; expose GetSslError as internal and enable SetLastError on SslDoHandshake.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/libs/System.Security.Cryptography.Native/pal_ssl.c	Preserve `errno` across `SSL_get_error` for read/write/handshake paths.
src/native/libs/System.Security.Cryptography.Native/pal_bio.c	Set deterministic `errno` for socket-replay BIO error cases; handle `send() == 0` as retry.
src/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs	Align exception creation with `SslStream` by using raw `SSL_*` result + `GetSslError`.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs	Enable `SetLastError` for `SslDoHandshake` so `errno` is observable from managed code.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs	Make `GetSslErrorinternal` for reuse by `TlsSession`.

wfurt

LGTM

rzikm · 2026-08-07T13:55:44Z

/ba-g QUIC test failure is unrelated

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

rzikm · 2026-08-06T13:41:17Z

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

azure-pipelines · 2026-08-06T13:42:05Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-06T13:42:39Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refines OpenSSL/TlsSession error diagnostics by preserving errno across SSL_get_error in the native shims and switching TlsSession to build exceptions using the same inner-exception logic as SslStream (distinguishing EOF vs I/O error for SSL_ERROR_SYSCALL based on the raw SSL_* return value).

Changes:

Preserve errno across SSL_get_error for SSL_write, SSL_read, and SSL_do_handshake so SSL_ERROR_SYSCALL diagnostics remain accurate.
Make socket-replay BIO failures set deterministic errno values (and treat send() == 0 as retryable) to avoid surfacing stale errno.
Update TlsSession.OpenSsl to use Interop.OpenSsl.GetSslError(result, error) and pass raw SSL_* results; expose GetSslError as internal and enable SetLastError on SslDoHandshake.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/libs/System.Security.Cryptography.Native/pal_ssl.c	Preserve `errno` across `SSL_get_error` for read/write/handshake paths.
src/native/libs/System.Security.Cryptography.Native/pal_bio.c	Set deterministic `errno` for socket-replay BIO error cases; handle `send() == 0` as retry.
src/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs	Align exception creation with `SslStream` by using raw `SSL_*` result + `GetSslError`.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs	Enable `SetLastError` for `SslDoHandshake` so `errno` is observable from managed code.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs	Make `GetSslErrorinternal` for reuse by `TlsSession`.

wfurt

LGTM

rzikm · 2026-08-07T13:55:44Z

/ba-g QUIC test failure is unrelated

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

rzikm · 2026-08-06T13:41:17Z

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

azure-pipelines · 2026-08-06T13:42:05Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-06T13:42:39Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refines OpenSSL/TlsSession error diagnostics by preserving errno across SSL_get_error in the native shims and switching TlsSession to build exceptions using the same inner-exception logic as SslStream (distinguishing EOF vs I/O error for SSL_ERROR_SYSCALL based on the raw SSL_* return value).

Changes:

Preserve errno across SSL_get_error for SSL_write, SSL_read, and SSL_do_handshake so SSL_ERROR_SYSCALL diagnostics remain accurate.
Make socket-replay BIO failures set deterministic errno values (and treat send() == 0 as retryable) to avoid surfacing stale errno.
Update TlsSession.OpenSsl to use Interop.OpenSsl.GetSslError(result, error) and pass raw SSL_* results; expose GetSslError as internal and enable SetLastError on SslDoHandshake.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/libs/System.Security.Cryptography.Native/pal_ssl.c	Preserve `errno` across `SSL_get_error` for read/write/handshake paths.
src/native/libs/System.Security.Cryptography.Native/pal_bio.c	Set deterministic `errno` for socket-replay BIO error cases; handle `send() == 0` as retry.
src/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs	Align exception creation with `SslStream` by using raw `SSL_*` result + `GetSslError`.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs	Enable `SetLastError` for `SslDoHandshake` so `errno` is observable from managed code.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs	Make `GetSslErrorinternal` for reuse by `TlsSession`.

wfurt

LGTM

rzikm · 2026-08-07T13:55:44Z

/ba-g QUIC test failure is unrelated

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

rzikm · 2026-08-06T13:41:17Z

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

azure-pipelines · 2026-08-06T13:42:05Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-06T13:42:39Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refines OpenSSL/TlsSession error diagnostics by preserving errno across SSL_get_error in the native shims and switching TlsSession to build exceptions using the same inner-exception logic as SslStream (distinguishing EOF vs I/O error for SSL_ERROR_SYSCALL based on the raw SSL_* return value).

Changes:

Preserve errno across SSL_get_error for SSL_write, SSL_read, and SSL_do_handshake so SSL_ERROR_SYSCALL diagnostics remain accurate.
Make socket-replay BIO failures set deterministic errno values (and treat send() == 0 as retryable) to avoid surfacing stale errno.
Update TlsSession.OpenSsl to use Interop.OpenSsl.GetSslError(result, error) and pass raw SSL_* results; expose GetSslError as internal and enable SetLastError on SslDoHandshake.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/libs/System.Security.Cryptography.Native/pal_ssl.c	Preserve `errno` across `SSL_get_error` for read/write/handshake paths.
src/native/libs/System.Security.Cryptography.Native/pal_bio.c	Set deterministic `errno` for socket-replay BIO error cases; handle `send() == 0` as retry.
src/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs	Align exception creation with `SslStream` by using raw `SSL_*` result + `GetSslError`.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs	Enable `SetLastError` for `SslDoHandshake` so `errno` is observable from managed code.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs	Make `GetSslErrorinternal` for reuse by `TlsSession`.

wfurt

LGTM

rzikm · 2026-08-07T13:55:44Z

/ba-g QUIC test failure is unrelated

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

rzikm · 2026-08-06T13:41:17Z

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

azure-pipelines · 2026-08-06T13:42:05Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-06T13:42:39Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refines OpenSSL/TlsSession error diagnostics by preserving errno across SSL_get_error in the native shims and switching TlsSession to build exceptions using the same inner-exception logic as SslStream (distinguishing EOF vs I/O error for SSL_ERROR_SYSCALL based on the raw SSL_* return value).

Changes:

Preserve errno across SSL_get_error for SSL_write, SSL_read, and SSL_do_handshake so SSL_ERROR_SYSCALL diagnostics remain accurate.
Make socket-replay BIO failures set deterministic errno values (and treat send() == 0 as retryable) to avoid surfacing stale errno.
Update TlsSession.OpenSsl to use Interop.OpenSsl.GetSslError(result, error) and pass raw SSL_* results; expose GetSslError as internal and enable SetLastError on SslDoHandshake.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/libs/System.Security.Cryptography.Native/pal_ssl.c	Preserve `errno` across `SSL_get_error` for read/write/handshake paths.
src/native/libs/System.Security.Cryptography.Native/pal_bio.c	Set deterministic `errno` for socket-replay BIO error cases; handle `send() == 0` as retry.
src/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs	Align exception creation with `SslStream` by using raw `SSL_*` result + `GetSslError`.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs	Enable `SetLastError` for `SslDoHandshake` so `errno` is observable from managed code.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs	Make `GetSslErrorinternal` for reuse by `TlsSession`.

wfurt

LGTM

rzikm · 2026-08-07T13:55:44Z

/ba-g QUIC test failure is unrelated

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

rzikm · 2026-08-06T13:41:17Z

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

azure-pipelines · 2026-08-06T13:42:05Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-08-06T13:42:39Z

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refines OpenSSL/TlsSession error diagnostics by preserving errno across SSL_get_error in the native shims and switching TlsSession to build exceptions using the same inner-exception logic as SslStream (distinguishing EOF vs I/O error for SSL_ERROR_SYSCALL based on the raw SSL_* return value).

Changes:

Preserve errno across SSL_get_error for SSL_write, SSL_read, and SSL_do_handshake so SSL_ERROR_SYSCALL diagnostics remain accurate.
Make socket-replay BIO failures set deterministic errno values (and treat send() == 0 as retryable) to avoid surfacing stale errno.
Update TlsSession.OpenSsl to use Interop.OpenSsl.GetSslError(result, error) and pass raw SSL_* results; expose GetSslError as internal and enable SetLastError on SslDoHandshake.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/libs/System.Security.Cryptography.Native/pal_ssl.c	Preserve `errno` across `SSL_get_error` for read/write/handshake paths.
src/native/libs/System.Security.Cryptography.Native/pal_bio.c	Set deterministic `errno` for socket-replay BIO error cases; handle `send() == 0` as retry.
src/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs	Align exception creation with `SslStream` by using raw `SSL_*` result + `GetSslError`.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs	Enable `SetLastError` for `SslDoHandshake` so `errno` is observable from managed code.
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs	Make `GetSslErrorinternal` for reuse by `TlsSession`.

wfurt

LGTM

rzikm · 2026-08-07T13:55:44Z

/ba-g QUIC test failure is unrelated

This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Improve TlsSession error diagnostics
c441ff4

CopilotAI review requested due to automatic review settings August 6, 2026 13:41

github-actionsBot added the area-System.Net.Security label Aug 6, 2026

dotnet-policy-serviceBot assigned rzikm Aug 6, 2026

Copilotstarted reviewing on behalf of rzikm August 6, 2026 13:41 View session

CopilotAI reviewed Aug 6, 2026
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Comment threadsrc/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs

wfurt approved these changes Aug 6, 2026
View reviewed changes

rzikm enabled auto-merge (squash) August 6, 2026 16:37

This was referenced Aug 6, 2026
Android WebSocket failure #121518
Open
Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825
Open

rzikm merged commit 183c954 into dotnet:mainAug 7, 2026
105 of 107 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8194
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
Improve TlsSession error diagnostics (dotnet#131943)
34c2fe7
This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Improve TlsSession error diagnostics
c441ff4

CopilotAI review requested due to automatic review settings August 6, 2026 13:41

github-actionsBot added the area-System.Net.Security label Aug 6, 2026

dotnet-policy-serviceBot assigned rzikm Aug 6, 2026

Copilotstarted reviewing on behalf of rzikm August 6, 2026 13:41 View session

CopilotAI reviewed Aug 6, 2026
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Comment threadsrc/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs

wfurt approved these changes Aug 6, 2026
View reviewed changes

rzikm enabled auto-merge (squash) August 6, 2026 16:37

This was referenced Aug 6, 2026
Android WebSocket failure #121518
Open
Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825
Open

rzikm merged commit 183c954 into dotnet:mainAug 7, 2026
105 of 107 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8194
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
Improve TlsSession error diagnostics (dotnet#131943)
34c2fe7
This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Improve TlsSession error diagnostics
c441ff4

CopilotAI review requested due to automatic review settings August 6, 2026 13:41

github-actionsBot added the area-System.Net.Security label Aug 6, 2026

dotnet-policy-serviceBot assigned rzikm Aug 6, 2026

Copilotstarted reviewing on behalf of rzikm August 6, 2026 13:41 View session

CopilotAI reviewed Aug 6, 2026
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Comment threadsrc/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs

wfurt approved these changes Aug 6, 2026
View reviewed changes

rzikm enabled auto-merge (squash) August 6, 2026 16:37

This was referenced Aug 6, 2026
Android WebSocket failure #121518
Open
Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825
Open

rzikm merged commit 183c954 into dotnet:mainAug 7, 2026
105 of 107 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8194
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
Improve TlsSession error diagnostics (dotnet#131943)
34c2fe7
This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Improve TlsSession error diagnostics
c441ff4

CopilotAI review requested due to automatic review settings August 6, 2026 13:41

github-actionsBot added the area-System.Net.Security label Aug 6, 2026

dotnet-policy-serviceBot assigned rzikm Aug 6, 2026

Copilotstarted reviewing on behalf of rzikm August 6, 2026 13:41 View session

CopilotAI reviewed Aug 6, 2026
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Comment threadsrc/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs

wfurt approved these changes Aug 6, 2026
View reviewed changes

rzikm enabled auto-merge (squash) August 6, 2026 16:37

This was referenced Aug 6, 2026
Android WebSocket failure #121518
Open
Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825
Open

rzikm merged commit 183c954 into dotnet:mainAug 7, 2026
105 of 107 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8194
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
Improve TlsSession error diagnostics (dotnet#131943)
34c2fe7
This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Improve TlsSession error diagnostics
c441ff4

CopilotAI review requested due to automatic review settings August 6, 2026 13:41

github-actionsBot added the area-System.Net.Security label Aug 6, 2026

dotnet-policy-serviceBot assigned rzikm Aug 6, 2026

Copilotstarted reviewing on behalf of rzikm August 6, 2026 13:41 View session

CopilotAI reviewed Aug 6, 2026
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Comment threadsrc/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs

wfurt approved these changes Aug 6, 2026
View reviewed changes

rzikm enabled auto-merge (squash) August 6, 2026 16:37

This was referenced Aug 6, 2026
Android WebSocket failure #121518
Open
Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825
Open

rzikm merged commit 183c954 into dotnet:mainAug 7, 2026
105 of 107 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8194
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
Improve TlsSession error diagnostics (dotnet#131943)
34c2fe7
This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Improve TlsSession error diagnostics
c441ff4

CopilotAI review requested due to automatic review settings August 6, 2026 13:41

github-actionsBot added the area-System.Net.Security label Aug 6, 2026

dotnet-policy-serviceBot assigned rzikm Aug 6, 2026

Copilotstarted reviewing on behalf of rzikm August 6, 2026 13:41 View session

CopilotAI reviewed Aug 6, 2026
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Comment threadsrc/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs

wfurt approved these changes Aug 6, 2026
View reviewed changes

rzikm enabled auto-merge (squash) August 6, 2026 16:37

This was referenced Aug 6, 2026
Android WebSocket failure #121518
Open
Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825
Open

rzikm merged commit 183c954 into dotnet:mainAug 7, 2026
105 of 107 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8194
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
Improve TlsSession error diagnostics (dotnet#131943)
34c2fe7
This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Improve TlsSession error diagnostics
c441ff4

CopilotAI review requested due to automatic review settings August 6, 2026 13:41

github-actionsBot added the area-System.Net.Security label Aug 6, 2026

dotnet-policy-serviceBot assigned rzikm Aug 6, 2026

Copilotstarted reviewing on behalf of rzikm August 6, 2026 13:41 View session

CopilotAI reviewed Aug 6, 2026
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Comment threadsrc/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs

wfurt approved these changes Aug 6, 2026
View reviewed changes

rzikm enabled auto-merge (squash) August 6, 2026 16:37

This was referenced Aug 6, 2026
Android WebSocket failure #121518
Open
Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825
Open

rzikm merged commit 183c954 into dotnet:mainAug 7, 2026
105 of 107 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8194
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
Improve TlsSession error diagnostics (dotnet#131943)
34c2fe7
This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Improve TlsSession error diagnostics
c441ff4

CopilotAI review requested due to automatic review settings August 6, 2026 13:41

github-actionsBot added the area-System.Net.Security label Aug 6, 2026

dotnet-policy-serviceBot assigned rzikm Aug 6, 2026

Copilotstarted reviewing on behalf of rzikm August 6, 2026 13:41 View session

CopilotAI reviewed Aug 6, 2026
View reviewed changes

Comment threadsrc/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Comment threadsrc/libraries/System.Net.Security/src/System/Net/Security/TlsSession.OpenSsl.cs

wfurt approved these changes Aug 6, 2026
View reviewed changes

rzikm enabled auto-merge (squash) August 6, 2026 16:37

This was referenced Aug 6, 2026
Android WebSocket failure #121518
Open
Assertion failure in ConnectAsync_WithBuffer_Succeeds on Android/MacCatalyst/tvOS (Mono/CoreCLR/NativeAOT) #125825
Open

rzikm merged commit 183c954 into dotnet:mainAug 7, 2026
105 of 107 checks passed

dotnet-maestroBot mentioned this pull request Aug 7, 2026
[main] Source code updates from dotnet/runtime dotnet/dotnet#8194
Merged

dotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 7, 2026

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
Improve TlsSession error diagnostics (dotnet#131943)
34c2fe7
This makes TlsSession use the same code for creating exceptions as in SslStream, so that it correctly reports all cases.

Uh oh!

Conversation

rzikm commented Aug 6, 2026

Uh oh!

azure-pipelinesBot commented Aug 6, 2026

Uh oh!

dotnet-policy-serviceBot commented Aug 6, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

rzikm commented Aug 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rzikm commented Aug 6, 2026

Uh oh!

azure-pipelinesBot commented Aug 6, 2026

Uh oh!

dotnet-policy-serviceBot commented Aug 6, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

rzikm commented Aug 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rzikm commented Aug 6, 2026

Uh oh!

azure-pipelinesBot commented Aug 6, 2026

Uh oh!

dotnet-policy-serviceBot commented Aug 6, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

rzikm commented Aug 7, 2026

Uh oh!

Uh oh!

Reviewers