Uh oh!
There was an error while loading. Please reload this page.
[QUIC] Timing fix and more logging - #132012
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Tagging subscribers to this area: @karelz, @dotnet/ncl |
There was a problem hiding this comment.
Pull request overview
This PR adjusts System.Net.Quic functional test timing and adds additional diagnostics to help investigate intermittent QUIC test failures (notably around stream-capacity/cancellation and connection-accept behavior).
Changes:
- Updates
GetStreamCapacity_OpenCloseStreamCanceledIntoNegative_CountsCorrectlyto wait for pending stream-open operations to observe cancellation before asserting capacity increments. - Tweaks test data structures (lists → arrays) in the same test to better reflect fixed-size usage.
- Adds server-side accept-task logging in
CreateConnectedQuicConnectionto aid debugging when connection setup fails.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs | Converts server accept to a Task and adds logging around accept completion/failure during connection setup exceptions. |
| src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs | Improves cancellation determinism in the stream-capacity test and adjusts how stream/task collections are materialized. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs:256
- This logging prints
failed withwhenserverTaskis canceled becauseTask.Exceptionis null for canceled tasks. Make the message handle the canceled case explicitly so failures are diagnosable.
if (serverTask.IsCompleted)
{
_output.WriteLine($"Server {(serverTask.IsCompletedSuccessfully ? "succeeded" : "failed with " + serverTask.Exception)}");
}
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs:435
- The local variable
oceis assigned but never used, which will produce a compiler warning (and in this repo warnings often fail the build). If the exception instance isn't needed, just await the assertion without storing it.
OperationCanceledException oce = await Assert.ThrowsAsync<OperationCanceledException>(() => Task.WhenAll(pendingClientStreams));
Uh oh!
There was an error while loading. Please reload this page.
Fixesdotnet#132000 Contributes to dotnet#131950
Fixes#132000
Contributes to #131950