') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Limit Helix job monitor to runtime pipeline by mmitche · Pull Request #132084 · dotnet/runtime · GitHub
Skip to content

Limit Helix job monitor to runtime pipeline - #132084

Merged
mmitche merged 1 commit into
dotnet:mainfrom
mmitche:dev/helix-job-monitor-runtime-only
Aug 11, 2026
Merged

Limit Helix job monitor to runtime pipeline#132084
mmitche merged 1 commit into
dotnet:mainfrom
mmitche:dev/helix-job-monitor-runtime-only

Conversation

@mmitche

@mmitchemmitche commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • default enableHelixJobMonitor to false in the shared pipeline variables
  • explicitly enable it in eng/pipelines/runtime.yml
  • preserve the standalone monitor job and fire-and-forget submissions only for the runtime pipeline

Motivation

The original rollout in #129690 intended to enable the Helix Job Monitor only for the runtime pipeline. However, the switch was set to true in the shared variables template imported by other pipelines.

This caused standalone pipelines such as runtime-coreclr superpmi-collect build 3043381 to configure Helix submissions for out-of-band monitoring without adding a monitor job. Those submissions returned after submission rather than waiting for completion.

Defaulting the shared switch off and opting in from runtime.yml keeps the complete feature scoped to its intended pipeline.

Validation

  • git diff --check
  • verified enableHelixJobMonitor is enabled only by eng/pipelines/runtime.yml

Note

This pull request description was generated with GitHub Copilot.

@mmitche
Limit Helix job monitor to runtime pipeline
aa832b6
Default the shared monitor switch to false and opt the runtime pipeline in explicitly.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0c07f370-3ea0-4352-8610-0ab0cf1f7b0a
CopilotAI lite review requested due to automatic review settings August 10, 2026 16:57
@azure-pipelines

azure-pipelinesBot commented Aug 10, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

dotnet-policy-serviceBot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

CopilotAI reviewed Aug 10, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Scopes the Helix Job Monitor feature to the main eng/pipelines/runtime.yml pipeline by disabling it by default in shared pipeline variables and explicitly opting in from the runtime pipeline definition.

Changes:

  • Default enableHelixJobMonitor to false in eng/pipelines/common/variables.yml.
  • Explicitly set enableHelixJobMonitor: true in eng/pipelines/runtime.yml so the runtime pipeline continues to include the monitor job and pass useHelixMonitor through its Helix template invocations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
eng/pipelines/runtime.ymlOpts the runtime pipeline into Helix Job Monitor explicitly via a local variable override.
eng/pipelines/common/variables.ymlChanges the shared default for enableHelixJobMonitor to false so other pipelines don’t implicitly enable monitoring behavior.

@matouskozak

matouskozak commented Aug 10, 2026

Copy link
Copy Markdown
Member

is there a plan to enable it back on other pipelines, e.g. runtime-extra-platforms? This is a heavy apple queue consumer and would help with the constrianed azdo resources.

@akoeplinger

akoeplinger commented Aug 10, 2026

Copy link
Copy Markdown
Member

we can opt in more pipelines step by step

This was referenced Aug 10, 2026
Closed
Closed
@mmitche
mmitche enabled auto-merge (squash) August 10, 2026 20:26
@build-analysisbuild-analysisBot mentioned this pull request Aug 10, 2026
Closed
@AndyAyersMS

AndyAyersMS commented Aug 10, 2026

Copy link
Copy Markdown
Member

@mmitche build monitor seems to be holding up this PR too (at least for the next hour or so, it seems to timeout after 6+ hours)

This was referenced Aug 11, 2026
Open
Closed
Closed
@jkoritzinsky

jkoritzinsky commented Aug 11, 2026

Copy link
Copy Markdown
Member

We should also enable it very soon in the JitStress pipelines that run a lot of scenarios. We've already taken a change that depends on the job monitor for those pipelines to not wait on jobs to finish before submitting more jobs.

@akoeplinger

akoeplinger commented Aug 11, 2026

Copy link
Copy Markdown
Member

/ba-g runtime and runtime-diagnostics pipeline failures are unrelated to this change

@mmitche
mmitche merged commit 643b896 into dotnet:mainAug 11, 2026
175 of 182 checks passed
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Aug 11, 2026
@mmitche@jtschuster
Limit Helix job monitor to runtime pipeline (dotnet#132084)
d6eadcc
## Summary
- default `enableHelixJobMonitor` to `false` in the shared pipeline
variables
- explicitly enable it in `eng/pipelines/runtime.yml`
- preserve the standalone monitor job and fire-and-forget submissions
only for the runtime pipeline
## Motivation
The original rollout in dotnet#129690 intended to enable the Helix Job Monitor
only for the runtime pipeline. However, the switch was set to `true` in
the shared variables template imported by other pipelines.
This caused standalone pipelines such as [`runtime-coreclr
superpmi-collect` build
3043381](https://dev.azure.com/dnceng/internal/_build/results?buildId=3043381&view=results)
to configure Helix submissions for out-of-band monitoring without adding
a monitor job. Those submissions returned after submission rather than
waiting for completion.
Defaulting the shared switch off and opting in from `runtime.yml` keeps
the complete feature scoped to its intended pipeline.
## Validation
- `git diff --check`
- verified `enableHelixJobMonitor` is enabled only by
`eng/pipelines/runtime.yml`
> [!NOTE]
> This pull request description was generated with GitHub Copilot.
Copilot-Session: 0c07f370-3ea0-4352-8610-0ab0cf1f7b0a
@akoeplingerakoeplinger mentioned this pull request Aug 11, 2026
Merged
@dotnet-maestrodotnet-maestroBot mentioned this pull request Aug 12, 2026
Merged
@dotnet-milestone-botdotnet-milestone-botBot added this to the 11.0-rc1 milestone Aug 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@akoeplingerakoeplingerakoeplinger approved these changes

Assignees

@mmitchemmitche

Labels

area-Infrastructure

Projects

None yet

Milestone

11.0-rc1

Development

Successfully merging this pull request may close these issues.

6 participants

@mmitche@matouskozak@akoeplinger@AndyAyersMS@jkoritzinsky