Report CoreCLR Write Barriers And Code-Heap Stubs In Traces

[brianrob]

Summary

Improve symbol coverage for executable code generated outside normal JIT methods. This is in response to an internal customer that is capturing traces where large percentages of symbols are unresolvable and don't resolve to a module. Upon investigation, these symbols should resolve to the copied write barrier or one of several different kinds of stubs.

Coverage

Executable range	Live ETW/EventPipe	Capture state and rundown	Live PerfMap	On-demand PerfMap
Copied write barriers	Existing: emitted before tracing-provider initialization. This PR: moves reporting after initialization and preserves individual names and explicit sizes.	This PR: reports individual ranges through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	This PR: reports individual named ranges.	This PR: replays individual named ranges.
EEJitManager jump/code-fragment blocks	This PR: reports blocks through MethodLoadVerbose.	This PR: reports blocks through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	Existing: reports blocks or individual allocations according to DOTNET_PerfMapStubGranularity.	This PR: replays blocks regardless of live block/individual granularity.
Individual symbols within EEJitManager blocks	Existing: no individual or block events. This PR: reports one event for the allocation block containing the stubs.	Existing: no individual or block replay. This PR: replays the allocation block containing the stubs.	Existing: reports individual symbols where instrumented. This PR: no change.	Existing: no replay. This PR: reports the allocation block because individual symbols cannot be reconstructed.

On-demand PerfMap generation uses blocks because individual allocations cannot be reconstructed during enumeration.

All ETW/EventPipe entries use JitHelperMethod metadata.

Implementation Notes

CodeHeapIterator now snapshots each heap’s end and uses per-heap lookahead to produce bounded, non-overlapping stub ranges. Jump-stub sizes use their existing allocation metadata; other code-fragment blocks use the bounded allocation extent.

Copied write-barrier reporting derives targets from the configured JIT helper table.

This does not change stub layout, allocation size, alignment, CodeHeader adjacency, DAC contracts, or jump reachability.

Note

This pull request description was created with GitHub Copilot.

[Copilot]

Pull request overview

This PR expands runtime symbol reporting for executable code that’s generated/allocated outside normal JITted methods, so tracing consumers can attribute those code ranges in ETW/EventPipe and PerfMap outputs. It does this by emitting helper-style method events for copied write barriers and code-heap stub/code-fragment blocks, and by improving CodeHeapIterator’s ability to surface bounded stub ranges during enumeration/rundown.

Changes:

• Add reporting/enumeration of copied write-barrier code ranges for ETW enumeration and PerfMap (including replay during method enumeration).
• Teach CodeHeapIterator to identify stub code blocks and provide bounded sizes + kinds for logging.
• Extend the EventPipe rundown validation test to generate VSD activity and validate helper events appear in live + rundown streams.

Show a summary per file

File	Description
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs	Generates VSD activity and validates helper-style stub/write-barrier events appear in live + rundown method events.
src/coreclr/vm/threads.h	Renames/init entrypoint and adds declarations for copied write-barrier reporting helpers.
src/coreclr/vm/threads.cpp	Implements enumeration/reporting of copied write barriers to PerfMap and ETW enumeration.
src/coreclr/vm/perfmap.cpp	Emits copied write barriers and stub-block ranges when generating an on-demand PerfMap.
src/coreclr/vm/eventtrace.cpp	Extends helper event emission to support different enumeration event types and reports stub blocks + copied write barriers during enumeration.
src/coreclr/vm/dynamicmethod.cpp	Ensures heap list entries for host code heaps carry a loader allocator pointer for filtered iteration.
src/coreclr/vm/codeman.h	Adds wide-string stub-kind names, stub-kind/size accessors on CodeHeapIterator, and moves small-block threshold to a shared constant.
src/coreclr/vm/codeman.cpp	Updates CodeHeapIterator to snapshot heap ends, identify stub code blocks, and report stub blocks via PerfMap + ETW helper events.
src/coreclr/vm/ceemain.cpp	Calls the new tracing-data initializer during startup.
src/coreclr/inc/eventtracebase.h	Updates/moves SendHelperEvent declaration to support passing enumeration options.

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 1
• Review effort level: Lite

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[brianrob]

/azp run runtime

Note

This rerun request was generated by GitHub Copilot after Build Analysis identified unrelated infrastructure timeouts and known test failures.

[azure-pipelines]

No pipelines are associated with this pull request.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Review details

Suppressed comments (1)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:111

• The test currently requires write-barrier helper events to be present and valid (ValidateHelperEvents(rundownWriteBarriers)), but copied write barriers are not necessarily enabled. In CoreCLR, write-barrier copying is gated by CLRConfig::UNSUPPORTED_UseGCWriteBarrierCopy and defaults to disabled (src/coreclr/vm/eeconfig.cpp:110 sets fIsWriteBarrierCopyEnabled = false; src/coreclr/vm/eeconfig.cpp:531 sets it based on the config switch). When the copy is disabled, ReportCopiedWriteBarriers* won’t emit any helper events, rundownWriteBarriers stays empty, and this test will fail on otherwise-correct builds.

Consider validating write-barrier helpers only when the events are actually present (or otherwise gating the expectation on a detectable condition).

 bool hasValidCoreClrHelpers =
!PlatformDetection.IsCoreCLR ||
!RuntimeFeature.IsDynamicCodeCompiled ||
(ValidateHelperEvents(liveStubBlocks) &&
ValidateHelperEvents(rundownStubBlocks) &&
ValidateHelperEvents(rundownWriteBarriers) &&
HaveMatchingStubBlocks(liveStubBlocks, rundownStubBlocks));

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[davidwrighton]

LGTM, but I want @hoyosjs to review as well before signoff.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

[brianrob]

/ba-g Current failures are unrelated known test failures: HttpListener timeout #132336 on both Windows checked legs, browser-Wasm bestfit-finalize #132107, and browser-Wasm ContextualReflection preemptive-GC assertion #131925. The affected tests and subsystems are outside this PR's ETW/stub changes.

Note

This Build Analysis override rationale was generated by GitHub Copilot.

[brianrob]

@hoyosjs this one should be ready for review again. Thanks.

[Copilot]

Review details

Suppressed comments (2)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:449

• The EventSource events are defined as JumpStubCollectionStart/JumpStubCollectionStop, but the trace parsing looks for "JumpStubCollection/Start" (task/opcode-style naming). Without explicitly setting EventOpcode and/or EventAttribute.Name, this comparison likely never matches, leaving collectionStart as NaN and causing the unload-range validation to fail.

 if (eventData.EventName == "JumpStubCollection/Start")
{
collectionStart = eventData.TimeStampRelativeMSec;
}

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:453

• Same issue as the Start event: the parser looks for "JumpStubCollection/Stop" but the EventSource event is JumpStubCollectionStop unless an explicit Stop opcode/name is set.

 else if (eventData.EventName == "JumpStubCollection/Stop")
{
collectionStop = eventData.TimeStampRelativeMSec;
}

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[hoyosjs]

Other than the test issue this seems good (assuming we are ok with the rundown event being an approximation, which seems fair for a trace/profiling effort - I don't see the tradeoff in storing this information elsewhere).

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:483

• If the JumpStubCollection Start/Stop markers are missing (e.g., due to EventName differences) or Stop precedes Start, collectionStart/collectionStop remain NaN/invalid and GetEventsInRange will silently return an empty set, causing a failure that’s hard to diagnose. Add an explicit validation of the marker timestamps before filtering unload events and log a clear error when they’re missing/invalid.

 List<HelperEvent> reclaimedJumpStubBlocks =
GetEventsInRange(unloadedJumpStubBlocks, collectionStart, collectionStop);
Logger.logger.Log("LCG jump-stub loads: " + loadedJumpStubBlocks.Count);
Logger.logger.Log("LCG jump-stub unloads: " + reclaimedJumpStubBlocks.Count);
return HaveMatchingLoadForEveryUnload(loadedJumpStubBlocks, reclaimedJumpStubBlocks)

[brianrob]

Summary

Improve symbol coverage for executable code generated outside normal JIT methods. This is in response to an internal customer that is capturing traces where large percentages of symbols are unresolvable and don't resolve to a module. Upon investigation, these symbols should resolve to the copied write barrier or one of several different kinds of stubs.

Coverage

Executable range	Live ETW/EventPipe	Capture state and rundown	Live PerfMap	On-demand PerfMap
Copied write barriers	Existing: emitted before tracing-provider initialization. This PR: moves reporting after initialization and preserves individual names and explicit sizes.	This PR: reports individual ranges through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	This PR: reports individual named ranges.	This PR: replays individual named ranges.
EEJitManager jump/code-fragment blocks	This PR: reports blocks through MethodLoadVerbose.	This PR: reports blocks through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	Existing: reports blocks or individual allocations according to DOTNET_PerfMapStubGranularity.	This PR: replays blocks regardless of live block/individual granularity.
Individual symbols within EEJitManager blocks	Existing: no individual or block events. This PR: reports one event for the allocation block containing the stubs.	Existing: no individual or block replay. This PR: replays the allocation block containing the stubs.	Existing: reports individual symbols where instrumented. This PR: no change.	Existing: no replay. This PR: reports the allocation block because individual symbols cannot be reconstructed.

On-demand PerfMap generation uses blocks because individual allocations cannot be reconstructed during enumeration.

All ETW/EventPipe entries use JitHelperMethod metadata.

Implementation Notes

CodeHeapIterator now snapshots each heap’s end and uses per-heap lookahead to produce bounded, non-overlapping stub ranges. Jump-stub sizes use their existing allocation metadata; other code-fragment blocks use the bounded allocation extent.

Copied write-barrier reporting derives targets from the configured JIT helper table.

This does not change stub layout, allocation size, alignment, CodeHeader adjacency, DAC contracts, or jump reachability.

Note

This pull request description was created with GitHub Copilot.

[Copilot]

Pull request overview

This PR expands runtime symbol reporting for executable code that’s generated/allocated outside normal JITted methods, so tracing consumers can attribute those code ranges in ETW/EventPipe and PerfMap outputs. It does this by emitting helper-style method events for copied write barriers and code-heap stub/code-fragment blocks, and by improving CodeHeapIterator’s ability to surface bounded stub ranges during enumeration/rundown.

Changes:

• Add reporting/enumeration of copied write-barrier code ranges for ETW enumeration and PerfMap (including replay during method enumeration).
• Teach CodeHeapIterator to identify stub code blocks and provide bounded sizes + kinds for logging.
• Extend the EventPipe rundown validation test to generate VSD activity and validate helper events appear in live + rundown streams.

Show a summary per file

File	Description
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs	Generates VSD activity and validates helper-style stub/write-barrier events appear in live + rundown method events.
src/coreclr/vm/threads.h	Renames/init entrypoint and adds declarations for copied write-barrier reporting helpers.
src/coreclr/vm/threads.cpp	Implements enumeration/reporting of copied write barriers to PerfMap and ETW enumeration.
src/coreclr/vm/perfmap.cpp	Emits copied write barriers and stub-block ranges when generating an on-demand PerfMap.
src/coreclr/vm/eventtrace.cpp	Extends helper event emission to support different enumeration event types and reports stub blocks + copied write barriers during enumeration.
src/coreclr/vm/dynamicmethod.cpp	Ensures heap list entries for host code heaps carry a loader allocator pointer for filtered iteration.
src/coreclr/vm/codeman.h	Adds wide-string stub-kind names, stub-kind/size accessors on CodeHeapIterator, and moves small-block threshold to a shared constant.
src/coreclr/vm/codeman.cpp	Updates CodeHeapIterator to snapshot heap ends, identify stub code blocks, and report stub blocks via PerfMap + ETW helper events.
src/coreclr/vm/ceemain.cpp	Calls the new tracing-data initializer during startup.
src/coreclr/inc/eventtracebase.h	Updates/moves SendHelperEvent declaration to support passing enumeration options.

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 1
• Review effort level: Lite

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[brianrob]

/azp run runtime

Note

This rerun request was generated by GitHub Copilot after Build Analysis identified unrelated infrastructure timeouts and known test failures.

[azure-pipelines]

No pipelines are associated with this pull request.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Review details

Suppressed comments (1)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:111

• The test currently requires write-barrier helper events to be present and valid (ValidateHelperEvents(rundownWriteBarriers)), but copied write barriers are not necessarily enabled. In CoreCLR, write-barrier copying is gated by CLRConfig::UNSUPPORTED_UseGCWriteBarrierCopy and defaults to disabled (src/coreclr/vm/eeconfig.cpp:110 sets fIsWriteBarrierCopyEnabled = false; src/coreclr/vm/eeconfig.cpp:531 sets it based on the config switch). When the copy is disabled, ReportCopiedWriteBarriers* won’t emit any helper events, rundownWriteBarriers stays empty, and this test will fail on otherwise-correct builds.

Consider validating write-barrier helpers only when the events are actually present (or otherwise gating the expectation on a detectable condition).

 bool hasValidCoreClrHelpers =
!PlatformDetection.IsCoreCLR ||
!RuntimeFeature.IsDynamicCodeCompiled ||
(ValidateHelperEvents(liveStubBlocks) &&
ValidateHelperEvents(rundownStubBlocks) &&
ValidateHelperEvents(rundownWriteBarriers) &&
HaveMatchingStubBlocks(liveStubBlocks, rundownStubBlocks));

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[davidwrighton]

LGTM, but I want @hoyosjs to review as well before signoff.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

[brianrob]

/ba-g Current failures are unrelated known test failures: HttpListener timeout #132336 on both Windows checked legs, browser-Wasm bestfit-finalize #132107, and browser-Wasm ContextualReflection preemptive-GC assertion #131925. The affected tests and subsystems are outside this PR's ETW/stub changes.

Note

This Build Analysis override rationale was generated by GitHub Copilot.

[brianrob]

@hoyosjs this one should be ready for review again. Thanks.

[Copilot]

Review details

Suppressed comments (2)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:449

• The EventSource events are defined as JumpStubCollectionStart/JumpStubCollectionStop, but the trace parsing looks for "JumpStubCollection/Start" (task/opcode-style naming). Without explicitly setting EventOpcode and/or EventAttribute.Name, this comparison likely never matches, leaving collectionStart as NaN and causing the unload-range validation to fail.

 if (eventData.EventName == "JumpStubCollection/Start")
{
collectionStart = eventData.TimeStampRelativeMSec;
}

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:453

• Same issue as the Start event: the parser looks for "JumpStubCollection/Stop" but the EventSource event is JumpStubCollectionStop unless an explicit Stop opcode/name is set.

 else if (eventData.EventName == "JumpStubCollection/Stop")
{
collectionStop = eventData.TimeStampRelativeMSec;
}

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[hoyosjs]

Other than the test issue this seems good (assuming we are ok with the rundown event being an approximation, which seems fair for a trace/profiling effort - I don't see the tradeoff in storing this information elsewhere).

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:483

• If the JumpStubCollection Start/Stop markers are missing (e.g., due to EventName differences) or Stop precedes Start, collectionStart/collectionStop remain NaN/invalid and GetEventsInRange will silently return an empty set, causing a failure that’s hard to diagnose. Add an explicit validation of the marker timestamps before filtering unload events and log a clear error when they’re missing/invalid.

 List<HelperEvent> reclaimedJumpStubBlocks =
GetEventsInRange(unloadedJumpStubBlocks, collectionStart, collectionStop);
Logger.logger.Log("LCG jump-stub loads: " + loadedJumpStubBlocks.Count);
Logger.logger.Log("LCG jump-stub unloads: " + reclaimedJumpStubBlocks.Count);
return HaveMatchingLoadForEveryUnload(loadedJumpStubBlocks, reclaimedJumpStubBlocks)

[brianrob]

Summary

Improve symbol coverage for executable code generated outside normal JIT methods. This is in response to an internal customer that is capturing traces where large percentages of symbols are unresolvable and don't resolve to a module. Upon investigation, these symbols should resolve to the copied write barrier or one of several different kinds of stubs.

Coverage

Executable range	Live ETW/EventPipe	Capture state and rundown	Live PerfMap	On-demand PerfMap
Copied write barriers	Existing: emitted before tracing-provider initialization. This PR: moves reporting after initialization and preserves individual names and explicit sizes.	This PR: reports individual ranges through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	This PR: reports individual named ranges.	This PR: replays individual named ranges.
EEJitManager jump/code-fragment blocks	This PR: reports blocks through MethodLoadVerbose.	This PR: reports blocks through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	Existing: reports blocks or individual allocations according to DOTNET_PerfMapStubGranularity.	This PR: replays blocks regardless of live block/individual granularity.
Individual symbols within EEJitManager blocks	Existing: no individual or block events. This PR: reports one event for the allocation block containing the stubs.	Existing: no individual or block replay. This PR: replays the allocation block containing the stubs.	Existing: reports individual symbols where instrumented. This PR: no change.	Existing: no replay. This PR: reports the allocation block because individual symbols cannot be reconstructed.

On-demand PerfMap generation uses blocks because individual allocations cannot be reconstructed during enumeration.

All ETW/EventPipe entries use JitHelperMethod metadata.

Implementation Notes

CodeHeapIterator now snapshots each heap’s end and uses per-heap lookahead to produce bounded, non-overlapping stub ranges. Jump-stub sizes use their existing allocation metadata; other code-fragment blocks use the bounded allocation extent.

Copied write-barrier reporting derives targets from the configured JIT helper table.

This does not change stub layout, allocation size, alignment, CodeHeader adjacency, DAC contracts, or jump reachability.

Note

This pull request description was created with GitHub Copilot.

[Copilot]

Pull request overview

This PR expands runtime symbol reporting for executable code that’s generated/allocated outside normal JITted methods, so tracing consumers can attribute those code ranges in ETW/EventPipe and PerfMap outputs. It does this by emitting helper-style method events for copied write barriers and code-heap stub/code-fragment blocks, and by improving CodeHeapIterator’s ability to surface bounded stub ranges during enumeration/rundown.

Changes:

• Add reporting/enumeration of copied write-barrier code ranges for ETW enumeration and PerfMap (including replay during method enumeration).
• Teach CodeHeapIterator to identify stub code blocks and provide bounded sizes + kinds for logging.
• Extend the EventPipe rundown validation test to generate VSD activity and validate helper events appear in live + rundown streams.

Show a summary per file

File	Description
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs	Generates VSD activity and validates helper-style stub/write-barrier events appear in live + rundown method events.
src/coreclr/vm/threads.h	Renames/init entrypoint and adds declarations for copied write-barrier reporting helpers.
src/coreclr/vm/threads.cpp	Implements enumeration/reporting of copied write barriers to PerfMap and ETW enumeration.
src/coreclr/vm/perfmap.cpp	Emits copied write barriers and stub-block ranges when generating an on-demand PerfMap.
src/coreclr/vm/eventtrace.cpp	Extends helper event emission to support different enumeration event types and reports stub blocks + copied write barriers during enumeration.
src/coreclr/vm/dynamicmethod.cpp	Ensures heap list entries for host code heaps carry a loader allocator pointer for filtered iteration.
src/coreclr/vm/codeman.h	Adds wide-string stub-kind names, stub-kind/size accessors on CodeHeapIterator, and moves small-block threshold to a shared constant.
src/coreclr/vm/codeman.cpp	Updates CodeHeapIterator to snapshot heap ends, identify stub code blocks, and report stub blocks via PerfMap + ETW helper events.
src/coreclr/vm/ceemain.cpp	Calls the new tracing-data initializer during startup.
src/coreclr/inc/eventtracebase.h	Updates/moves SendHelperEvent declaration to support passing enumeration options.

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 1
• Review effort level: Lite

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[brianrob]

/azp run runtime

Note

This rerun request was generated by GitHub Copilot after Build Analysis identified unrelated infrastructure timeouts and known test failures.

[azure-pipelines]

No pipelines are associated with this pull request.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Review details

Suppressed comments (1)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:111

• The test currently requires write-barrier helper events to be present and valid (ValidateHelperEvents(rundownWriteBarriers)), but copied write barriers are not necessarily enabled. In CoreCLR, write-barrier copying is gated by CLRConfig::UNSUPPORTED_UseGCWriteBarrierCopy and defaults to disabled (src/coreclr/vm/eeconfig.cpp:110 sets fIsWriteBarrierCopyEnabled = false; src/coreclr/vm/eeconfig.cpp:531 sets it based on the config switch). When the copy is disabled, ReportCopiedWriteBarriers* won’t emit any helper events, rundownWriteBarriers stays empty, and this test will fail on otherwise-correct builds.

Consider validating write-barrier helpers only when the events are actually present (or otherwise gating the expectation on a detectable condition).

 bool hasValidCoreClrHelpers =
!PlatformDetection.IsCoreCLR ||
!RuntimeFeature.IsDynamicCodeCompiled ||
(ValidateHelperEvents(liveStubBlocks) &&
ValidateHelperEvents(rundownStubBlocks) &&
ValidateHelperEvents(rundownWriteBarriers) &&
HaveMatchingStubBlocks(liveStubBlocks, rundownStubBlocks));

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[davidwrighton]

LGTM, but I want @hoyosjs to review as well before signoff.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

[brianrob]

/ba-g Current failures are unrelated known test failures: HttpListener timeout #132336 on both Windows checked legs, browser-Wasm bestfit-finalize #132107, and browser-Wasm ContextualReflection preemptive-GC assertion #131925. The affected tests and subsystems are outside this PR's ETW/stub changes.

Note

This Build Analysis override rationale was generated by GitHub Copilot.

[brianrob]

@hoyosjs this one should be ready for review again. Thanks.

[Copilot]

Review details

Suppressed comments (2)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:449

• The EventSource events are defined as JumpStubCollectionStart/JumpStubCollectionStop, but the trace parsing looks for "JumpStubCollection/Start" (task/opcode-style naming). Without explicitly setting EventOpcode and/or EventAttribute.Name, this comparison likely never matches, leaving collectionStart as NaN and causing the unload-range validation to fail.

 if (eventData.EventName == "JumpStubCollection/Start")
{
collectionStart = eventData.TimeStampRelativeMSec;
}

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:453

• Same issue as the Start event: the parser looks for "JumpStubCollection/Stop" but the EventSource event is JumpStubCollectionStop unless an explicit Stop opcode/name is set.

 else if (eventData.EventName == "JumpStubCollection/Stop")
{
collectionStop = eventData.TimeStampRelativeMSec;
}

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[hoyosjs]

Other than the test issue this seems good (assuming we are ok with the rundown event being an approximation, which seems fair for a trace/profiling effort - I don't see the tradeoff in storing this information elsewhere).

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:483

• If the JumpStubCollection Start/Stop markers are missing (e.g., due to EventName differences) or Stop precedes Start, collectionStart/collectionStop remain NaN/invalid and GetEventsInRange will silently return an empty set, causing a failure that’s hard to diagnose. Add an explicit validation of the marker timestamps before filtering unload events and log a clear error when they’re missing/invalid.

 List<HelperEvent> reclaimedJumpStubBlocks =
GetEventsInRange(unloadedJumpStubBlocks, collectionStart, collectionStop);
Logger.logger.Log("LCG jump-stub loads: " + loadedJumpStubBlocks.Count);
Logger.logger.Log("LCG jump-stub unloads: " + reclaimedJumpStubBlocks.Count);
return HaveMatchingLoadForEveryUnload(loadedJumpStubBlocks, reclaimedJumpStubBlocks)

[brianrob]

Summary

Improve symbol coverage for executable code generated outside normal JIT methods. This is in response to an internal customer that is capturing traces where large percentages of symbols are unresolvable and don't resolve to a module. Upon investigation, these symbols should resolve to the copied write barrier or one of several different kinds of stubs.

Coverage

Executable range	Live ETW/EventPipe	Capture state and rundown	Live PerfMap	On-demand PerfMap
Copied write barriers	Existing: emitted before tracing-provider initialization. This PR: moves reporting after initialization and preserves individual names and explicit sizes.	This PR: reports individual ranges through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	This PR: reports individual named ranges.	This PR: replays individual named ranges.
EEJitManager jump/code-fragment blocks	This PR: reports blocks through MethodLoadVerbose.	This PR: reports blocks through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	Existing: reports blocks or individual allocations according to DOTNET_PerfMapStubGranularity.	This PR: replays blocks regardless of live block/individual granularity.
Individual symbols within EEJitManager blocks	Existing: no individual or block events. This PR: reports one event for the allocation block containing the stubs.	Existing: no individual or block replay. This PR: replays the allocation block containing the stubs.	Existing: reports individual symbols where instrumented. This PR: no change.	Existing: no replay. This PR: reports the allocation block because individual symbols cannot be reconstructed.

On-demand PerfMap generation uses blocks because individual allocations cannot be reconstructed during enumeration.

All ETW/EventPipe entries use JitHelperMethod metadata.

Implementation Notes

CodeHeapIterator now snapshots each heap’s end and uses per-heap lookahead to produce bounded, non-overlapping stub ranges. Jump-stub sizes use their existing allocation metadata; other code-fragment blocks use the bounded allocation extent.

Copied write-barrier reporting derives targets from the configured JIT helper table.

This does not change stub layout, allocation size, alignment, CodeHeader adjacency, DAC contracts, or jump reachability.

Note

This pull request description was created with GitHub Copilot.

[Copilot]

Pull request overview

This PR expands runtime symbol reporting for executable code that’s generated/allocated outside normal JITted methods, so tracing consumers can attribute those code ranges in ETW/EventPipe and PerfMap outputs. It does this by emitting helper-style method events for copied write barriers and code-heap stub/code-fragment blocks, and by improving CodeHeapIterator’s ability to surface bounded stub ranges during enumeration/rundown.

Changes:

• Add reporting/enumeration of copied write-barrier code ranges for ETW enumeration and PerfMap (including replay during method enumeration).
• Teach CodeHeapIterator to identify stub code blocks and provide bounded sizes + kinds for logging.
• Extend the EventPipe rundown validation test to generate VSD activity and validate helper events appear in live + rundown streams.

Show a summary per file

File	Description
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs	Generates VSD activity and validates helper-style stub/write-barrier events appear in live + rundown method events.
src/coreclr/vm/threads.h	Renames/init entrypoint and adds declarations for copied write-barrier reporting helpers.
src/coreclr/vm/threads.cpp	Implements enumeration/reporting of copied write barriers to PerfMap and ETW enumeration.
src/coreclr/vm/perfmap.cpp	Emits copied write barriers and stub-block ranges when generating an on-demand PerfMap.
src/coreclr/vm/eventtrace.cpp	Extends helper event emission to support different enumeration event types and reports stub blocks + copied write barriers during enumeration.
src/coreclr/vm/dynamicmethod.cpp	Ensures heap list entries for host code heaps carry a loader allocator pointer for filtered iteration.
src/coreclr/vm/codeman.h	Adds wide-string stub-kind names, stub-kind/size accessors on CodeHeapIterator, and moves small-block threshold to a shared constant.
src/coreclr/vm/codeman.cpp	Updates CodeHeapIterator to snapshot heap ends, identify stub code blocks, and report stub blocks via PerfMap + ETW helper events.
src/coreclr/vm/ceemain.cpp	Calls the new tracing-data initializer during startup.
src/coreclr/inc/eventtracebase.h	Updates/moves SendHelperEvent declaration to support passing enumeration options.

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 1
• Review effort level: Lite

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[brianrob]

/azp run runtime

Note

This rerun request was generated by GitHub Copilot after Build Analysis identified unrelated infrastructure timeouts and known test failures.

[azure-pipelines]

No pipelines are associated with this pull request.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Review details

Suppressed comments (1)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:111

• The test currently requires write-barrier helper events to be present and valid (ValidateHelperEvents(rundownWriteBarriers)), but copied write barriers are not necessarily enabled. In CoreCLR, write-barrier copying is gated by CLRConfig::UNSUPPORTED_UseGCWriteBarrierCopy and defaults to disabled (src/coreclr/vm/eeconfig.cpp:110 sets fIsWriteBarrierCopyEnabled = false; src/coreclr/vm/eeconfig.cpp:531 sets it based on the config switch). When the copy is disabled, ReportCopiedWriteBarriers* won’t emit any helper events, rundownWriteBarriers stays empty, and this test will fail on otherwise-correct builds.

Consider validating write-barrier helpers only when the events are actually present (or otherwise gating the expectation on a detectable condition).

 bool hasValidCoreClrHelpers =
!PlatformDetection.IsCoreCLR ||
!RuntimeFeature.IsDynamicCodeCompiled ||
(ValidateHelperEvents(liveStubBlocks) &&
ValidateHelperEvents(rundownStubBlocks) &&
ValidateHelperEvents(rundownWriteBarriers) &&
HaveMatchingStubBlocks(liveStubBlocks, rundownStubBlocks));

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[davidwrighton]

LGTM, but I want @hoyosjs to review as well before signoff.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

[brianrob]

/ba-g Current failures are unrelated known test failures: HttpListener timeout #132336 on both Windows checked legs, browser-Wasm bestfit-finalize #132107, and browser-Wasm ContextualReflection preemptive-GC assertion #131925. The affected tests and subsystems are outside this PR's ETW/stub changes.

Note

This Build Analysis override rationale was generated by GitHub Copilot.

[brianrob]

@hoyosjs this one should be ready for review again. Thanks.

[Copilot]

Review details

Suppressed comments (2)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:449

• The EventSource events are defined as JumpStubCollectionStart/JumpStubCollectionStop, but the trace parsing looks for "JumpStubCollection/Start" (task/opcode-style naming). Without explicitly setting EventOpcode and/or EventAttribute.Name, this comparison likely never matches, leaving collectionStart as NaN and causing the unload-range validation to fail.

 if (eventData.EventName == "JumpStubCollection/Start")
{
collectionStart = eventData.TimeStampRelativeMSec;
}

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:453

• Same issue as the Start event: the parser looks for "JumpStubCollection/Stop" but the EventSource event is JumpStubCollectionStop unless an explicit Stop opcode/name is set.

 else if (eventData.EventName == "JumpStubCollection/Stop")
{
collectionStop = eventData.TimeStampRelativeMSec;
}

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[hoyosjs]

Other than the test issue this seems good (assuming we are ok with the rundown event being an approximation, which seems fair for a trace/profiling effort - I don't see the tradeoff in storing this information elsewhere).

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:483

• If the JumpStubCollection Start/Stop markers are missing (e.g., due to EventName differences) or Stop precedes Start, collectionStart/collectionStop remain NaN/invalid and GetEventsInRange will silently return an empty set, causing a failure that’s hard to diagnose. Add an explicit validation of the marker timestamps before filtering unload events and log a clear error when they’re missing/invalid.

 List<HelperEvent> reclaimedJumpStubBlocks =
GetEventsInRange(unloadedJumpStubBlocks, collectionStart, collectionStop);
Logger.logger.Log("LCG jump-stub loads: " + loadedJumpStubBlocks.Count);
Logger.logger.Log("LCG jump-stub unloads: " + reclaimedJumpStubBlocks.Count);
return HaveMatchingLoadForEveryUnload(loadedJumpStubBlocks, reclaimedJumpStubBlocks)

[brianrob]

Summary

Improve symbol coverage for executable code generated outside normal JIT methods. This is in response to an internal customer that is capturing traces where large percentages of symbols are unresolvable and don't resolve to a module. Upon investigation, these symbols should resolve to the copied write barrier or one of several different kinds of stubs.

Coverage

Executable range	Live ETW/EventPipe	Capture state and rundown	Live PerfMap	On-demand PerfMap
Copied write barriers	Existing: emitted before tracing-provider initialization. This PR: moves reporting after initialization and preserves individual names and explicit sizes.	This PR: reports individual ranges through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	This PR: reports individual named ranges.	This PR: replays individual named ranges.
EEJitManager jump/code-fragment blocks	This PR: reports blocks through MethodLoadVerbose.	This PR: reports blocks through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	Existing: reports blocks or individual allocations according to DOTNET_PerfMapStubGranularity.	This PR: replays blocks regardless of live block/individual granularity.
Individual symbols within EEJitManager blocks	Existing: no individual or block events. This PR: reports one event for the allocation block containing the stubs.	Existing: no individual or block replay. This PR: replays the allocation block containing the stubs.	Existing: reports individual symbols where instrumented. This PR: no change.	Existing: no replay. This PR: reports the allocation block because individual symbols cannot be reconstructed.

On-demand PerfMap generation uses blocks because individual allocations cannot be reconstructed during enumeration.

All ETW/EventPipe entries use JitHelperMethod metadata.

Implementation Notes

CodeHeapIterator now snapshots each heap’s end and uses per-heap lookahead to produce bounded, non-overlapping stub ranges. Jump-stub sizes use their existing allocation metadata; other code-fragment blocks use the bounded allocation extent.

Copied write-barrier reporting derives targets from the configured JIT helper table.

This does not change stub layout, allocation size, alignment, CodeHeader adjacency, DAC contracts, or jump reachability.

Note

This pull request description was created with GitHub Copilot.

[Copilot]

Pull request overview

This PR expands runtime symbol reporting for executable code that’s generated/allocated outside normal JITted methods, so tracing consumers can attribute those code ranges in ETW/EventPipe and PerfMap outputs. It does this by emitting helper-style method events for copied write barriers and code-heap stub/code-fragment blocks, and by improving CodeHeapIterator’s ability to surface bounded stub ranges during enumeration/rundown.

Changes:

• Add reporting/enumeration of copied write-barrier code ranges for ETW enumeration and PerfMap (including replay during method enumeration).
• Teach CodeHeapIterator to identify stub code blocks and provide bounded sizes + kinds for logging.
• Extend the EventPipe rundown validation test to generate VSD activity and validate helper events appear in live + rundown streams.

Show a summary per file

File	Description
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs	Generates VSD activity and validates helper-style stub/write-barrier events appear in live + rundown method events.
src/coreclr/vm/threads.h	Renames/init entrypoint and adds declarations for copied write-barrier reporting helpers.
src/coreclr/vm/threads.cpp	Implements enumeration/reporting of copied write barriers to PerfMap and ETW enumeration.
src/coreclr/vm/perfmap.cpp	Emits copied write barriers and stub-block ranges when generating an on-demand PerfMap.
src/coreclr/vm/eventtrace.cpp	Extends helper event emission to support different enumeration event types and reports stub blocks + copied write barriers during enumeration.
src/coreclr/vm/dynamicmethod.cpp	Ensures heap list entries for host code heaps carry a loader allocator pointer for filtered iteration.
src/coreclr/vm/codeman.h	Adds wide-string stub-kind names, stub-kind/size accessors on CodeHeapIterator, and moves small-block threshold to a shared constant.
src/coreclr/vm/codeman.cpp	Updates CodeHeapIterator to snapshot heap ends, identify stub code blocks, and report stub blocks via PerfMap + ETW helper events.
src/coreclr/vm/ceemain.cpp	Calls the new tracing-data initializer during startup.
src/coreclr/inc/eventtracebase.h	Updates/moves SendHelperEvent declaration to support passing enumeration options.

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 1
• Review effort level: Lite

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[brianrob]

/azp run runtime

Note

This rerun request was generated by GitHub Copilot after Build Analysis identified unrelated infrastructure timeouts and known test failures.

[azure-pipelines]

No pipelines are associated with this pull request.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Review details

Suppressed comments (1)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:111

• The test currently requires write-barrier helper events to be present and valid (ValidateHelperEvents(rundownWriteBarriers)), but copied write barriers are not necessarily enabled. In CoreCLR, write-barrier copying is gated by CLRConfig::UNSUPPORTED_UseGCWriteBarrierCopy and defaults to disabled (src/coreclr/vm/eeconfig.cpp:110 sets fIsWriteBarrierCopyEnabled = false; src/coreclr/vm/eeconfig.cpp:531 sets it based on the config switch). When the copy is disabled, ReportCopiedWriteBarriers* won’t emit any helper events, rundownWriteBarriers stays empty, and this test will fail on otherwise-correct builds.

Consider validating write-barrier helpers only when the events are actually present (or otherwise gating the expectation on a detectable condition).

 bool hasValidCoreClrHelpers =
!PlatformDetection.IsCoreCLR ||
!RuntimeFeature.IsDynamicCodeCompiled ||
(ValidateHelperEvents(liveStubBlocks) &&
ValidateHelperEvents(rundownStubBlocks) &&
ValidateHelperEvents(rundownWriteBarriers) &&
HaveMatchingStubBlocks(liveStubBlocks, rundownStubBlocks));

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[davidwrighton]

LGTM, but I want @hoyosjs to review as well before signoff.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

[brianrob]

/ba-g Current failures are unrelated known test failures: HttpListener timeout #132336 on both Windows checked legs, browser-Wasm bestfit-finalize #132107, and browser-Wasm ContextualReflection preemptive-GC assertion #131925. The affected tests and subsystems are outside this PR's ETW/stub changes.

Note

This Build Analysis override rationale was generated by GitHub Copilot.

[brianrob]

@hoyosjs this one should be ready for review again. Thanks.

[Copilot]

Review details

Suppressed comments (2)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:449

• The EventSource events are defined as JumpStubCollectionStart/JumpStubCollectionStop, but the trace parsing looks for "JumpStubCollection/Start" (task/opcode-style naming). Without explicitly setting EventOpcode and/or EventAttribute.Name, this comparison likely never matches, leaving collectionStart as NaN and causing the unload-range validation to fail.

 if (eventData.EventName == "JumpStubCollection/Start")
{
collectionStart = eventData.TimeStampRelativeMSec;
}

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:453

• Same issue as the Start event: the parser looks for "JumpStubCollection/Stop" but the EventSource event is JumpStubCollectionStop unless an explicit Stop opcode/name is set.

 else if (eventData.EventName == "JumpStubCollection/Stop")
{
collectionStop = eventData.TimeStampRelativeMSec;
}

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[hoyosjs]

Other than the test issue this seems good (assuming we are ok with the rundown event being an approximation, which seems fair for a trace/profiling effort - I don't see the tradeoff in storing this information elsewhere).

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:483

• If the JumpStubCollection Start/Stop markers are missing (e.g., due to EventName differences) or Stop precedes Start, collectionStart/collectionStop remain NaN/invalid and GetEventsInRange will silently return an empty set, causing a failure that’s hard to diagnose. Add an explicit validation of the marker timestamps before filtering unload events and log a clear error when they’re missing/invalid.

 List<HelperEvent> reclaimedJumpStubBlocks =
GetEventsInRange(unloadedJumpStubBlocks, collectionStart, collectionStop);
Logger.logger.Log("LCG jump-stub loads: " + loadedJumpStubBlocks.Count);
Logger.logger.Log("LCG jump-stub unloads: " + reclaimedJumpStubBlocks.Count);
return HaveMatchingLoadForEveryUnload(loadedJumpStubBlocks, reclaimedJumpStubBlocks)

[brianrob]

Summary

Improve symbol coverage for executable code generated outside normal JIT methods. This is in response to an internal customer that is capturing traces where large percentages of symbols are unresolvable and don't resolve to a module. Upon investigation, these symbols should resolve to the copied write barrier or one of several different kinds of stubs.

Coverage

Executable range	Live ETW/EventPipe	Capture state and rundown	Live PerfMap	On-demand PerfMap
Copied write barriers	Existing: emitted before tracing-provider initialization. This PR: moves reporting after initialization and preserves individual names and explicit sizes.	This PR: reports individual ranges through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	This PR: reports individual named ranges.	This PR: replays individual named ranges.
EEJitManager jump/code-fragment blocks	This PR: reports blocks through MethodLoadVerbose.	This PR: reports blocks through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	Existing: reports blocks or individual allocations according to DOTNET_PerfMapStubGranularity.	This PR: replays blocks regardless of live block/individual granularity.
Individual symbols within EEJitManager blocks	Existing: no individual or block events. This PR: reports one event for the allocation block containing the stubs.	Existing: no individual or block replay. This PR: replays the allocation block containing the stubs.	Existing: reports individual symbols where instrumented. This PR: no change.	Existing: no replay. This PR: reports the allocation block because individual symbols cannot be reconstructed.

On-demand PerfMap generation uses blocks because individual allocations cannot be reconstructed during enumeration.

All ETW/EventPipe entries use JitHelperMethod metadata.

Implementation Notes

CodeHeapIterator now snapshots each heap’s end and uses per-heap lookahead to produce bounded, non-overlapping stub ranges. Jump-stub sizes use their existing allocation metadata; other code-fragment blocks use the bounded allocation extent.

Copied write-barrier reporting derives targets from the configured JIT helper table.

This does not change stub layout, allocation size, alignment, CodeHeader adjacency, DAC contracts, or jump reachability.

Note

This pull request description was created with GitHub Copilot.

[Copilot]

Pull request overview

This PR expands runtime symbol reporting for executable code that’s generated/allocated outside normal JITted methods, so tracing consumers can attribute those code ranges in ETW/EventPipe and PerfMap outputs. It does this by emitting helper-style method events for copied write barriers and code-heap stub/code-fragment blocks, and by improving CodeHeapIterator’s ability to surface bounded stub ranges during enumeration/rundown.

Changes:

• Add reporting/enumeration of copied write-barrier code ranges for ETW enumeration and PerfMap (including replay during method enumeration).
• Teach CodeHeapIterator to identify stub code blocks and provide bounded sizes + kinds for logging.
• Extend the EventPipe rundown validation test to generate VSD activity and validate helper events appear in live + rundown streams.

Show a summary per file

File	Description
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs	Generates VSD activity and validates helper-style stub/write-barrier events appear in live + rundown method events.
src/coreclr/vm/threads.h	Renames/init entrypoint and adds declarations for copied write-barrier reporting helpers.
src/coreclr/vm/threads.cpp	Implements enumeration/reporting of copied write barriers to PerfMap and ETW enumeration.
src/coreclr/vm/perfmap.cpp	Emits copied write barriers and stub-block ranges when generating an on-demand PerfMap.
src/coreclr/vm/eventtrace.cpp	Extends helper event emission to support different enumeration event types and reports stub blocks + copied write barriers during enumeration.
src/coreclr/vm/dynamicmethod.cpp	Ensures heap list entries for host code heaps carry a loader allocator pointer for filtered iteration.
src/coreclr/vm/codeman.h	Adds wide-string stub-kind names, stub-kind/size accessors on CodeHeapIterator, and moves small-block threshold to a shared constant.
src/coreclr/vm/codeman.cpp	Updates CodeHeapIterator to snapshot heap ends, identify stub code blocks, and report stub blocks via PerfMap + ETW helper events.
src/coreclr/vm/ceemain.cpp	Calls the new tracing-data initializer during startup.
src/coreclr/inc/eventtracebase.h	Updates/moves SendHelperEvent declaration to support passing enumeration options.

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 1
• Review effort level: Lite

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[brianrob]

/azp run runtime

Note

This rerun request was generated by GitHub Copilot after Build Analysis identified unrelated infrastructure timeouts and known test failures.

[azure-pipelines]

No pipelines are associated with this pull request.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Review details

Suppressed comments (1)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:111

• The test currently requires write-barrier helper events to be present and valid (ValidateHelperEvents(rundownWriteBarriers)), but copied write barriers are not necessarily enabled. In CoreCLR, write-barrier copying is gated by CLRConfig::UNSUPPORTED_UseGCWriteBarrierCopy and defaults to disabled (src/coreclr/vm/eeconfig.cpp:110 sets fIsWriteBarrierCopyEnabled = false; src/coreclr/vm/eeconfig.cpp:531 sets it based on the config switch). When the copy is disabled, ReportCopiedWriteBarriers* won’t emit any helper events, rundownWriteBarriers stays empty, and this test will fail on otherwise-correct builds.

Consider validating write-barrier helpers only when the events are actually present (or otherwise gating the expectation on a detectable condition).

 bool hasValidCoreClrHelpers =
!PlatformDetection.IsCoreCLR ||
!RuntimeFeature.IsDynamicCodeCompiled ||
(ValidateHelperEvents(liveStubBlocks) &&
ValidateHelperEvents(rundownStubBlocks) &&
ValidateHelperEvents(rundownWriteBarriers) &&
HaveMatchingStubBlocks(liveStubBlocks, rundownStubBlocks));

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[davidwrighton]

LGTM, but I want @hoyosjs to review as well before signoff.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

[brianrob]

/ba-g Current failures are unrelated known test failures: HttpListener timeout #132336 on both Windows checked legs, browser-Wasm bestfit-finalize #132107, and browser-Wasm ContextualReflection preemptive-GC assertion #131925. The affected tests and subsystems are outside this PR's ETW/stub changes.

Note

This Build Analysis override rationale was generated by GitHub Copilot.

[brianrob]

@hoyosjs this one should be ready for review again. Thanks.

[Copilot]

Review details

Suppressed comments (2)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:449

• The EventSource events are defined as JumpStubCollectionStart/JumpStubCollectionStop, but the trace parsing looks for "JumpStubCollection/Start" (task/opcode-style naming). Without explicitly setting EventOpcode and/or EventAttribute.Name, this comparison likely never matches, leaving collectionStart as NaN and causing the unload-range validation to fail.

 if (eventData.EventName == "JumpStubCollection/Start")
{
collectionStart = eventData.TimeStampRelativeMSec;
}

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:453

• Same issue as the Start event: the parser looks for "JumpStubCollection/Stop" but the EventSource event is JumpStubCollectionStop unless an explicit Stop opcode/name is set.

 else if (eventData.EventName == "JumpStubCollection/Stop")
{
collectionStop = eventData.TimeStampRelativeMSec;
}

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[hoyosjs]

Other than the test issue this seems good (assuming we are ok with the rundown event being an approximation, which seems fair for a trace/profiling effort - I don't see the tradeoff in storing this information elsewhere).

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:483

• If the JumpStubCollection Start/Stop markers are missing (e.g., due to EventName differences) or Stop precedes Start, collectionStart/collectionStop remain NaN/invalid and GetEventsInRange will silently return an empty set, causing a failure that’s hard to diagnose. Add an explicit validation of the marker timestamps before filtering unload events and log a clear error when they’re missing/invalid.

 List<HelperEvent> reclaimedJumpStubBlocks =
GetEventsInRange(unloadedJumpStubBlocks, collectionStart, collectionStop);
Logger.logger.Log("LCG jump-stub loads: " + loadedJumpStubBlocks.Count);
Logger.logger.Log("LCG jump-stub unloads: " + reclaimedJumpStubBlocks.Count);
return HaveMatchingLoadForEveryUnload(loadedJumpStubBlocks, reclaimedJumpStubBlocks)

[brianrob]

Summary

Improve symbol coverage for executable code generated outside normal JIT methods. This is in response to an internal customer that is capturing traces where large percentages of symbols are unresolvable and don't resolve to a module. Upon investigation, these symbols should resolve to the copied write barrier or one of several different kinds of stubs.

Coverage

Executable range	Live ETW/EventPipe	Capture state and rundown	Live PerfMap	On-demand PerfMap
Copied write barriers	Existing: emitted before tracing-provider initialization. This PR: moves reporting after initialization and preserves individual names and explicit sizes.	This PR: reports individual ranges through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	This PR: reports individual named ranges.	This PR: replays individual named ranges.
EEJitManager jump/code-fragment blocks	This PR: reports blocks through MethodLoadVerbose.	This PR: reports blocks through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	Existing: reports blocks or individual allocations according to DOTNET_PerfMapStubGranularity.	This PR: replays blocks regardless of live block/individual granularity.
Individual symbols within EEJitManager blocks	Existing: no individual or block events. This PR: reports one event for the allocation block containing the stubs.	Existing: no individual or block replay. This PR: replays the allocation block containing the stubs.	Existing: reports individual symbols where instrumented. This PR: no change.	Existing: no replay. This PR: reports the allocation block because individual symbols cannot be reconstructed.

On-demand PerfMap generation uses blocks because individual allocations cannot be reconstructed during enumeration.

All ETW/EventPipe entries use JitHelperMethod metadata.

Implementation Notes

CodeHeapIterator now snapshots each heap’s end and uses per-heap lookahead to produce bounded, non-overlapping stub ranges. Jump-stub sizes use their existing allocation metadata; other code-fragment blocks use the bounded allocation extent.

Copied write-barrier reporting derives targets from the configured JIT helper table.

This does not change stub layout, allocation size, alignment, CodeHeader adjacency, DAC contracts, or jump reachability.

Note

This pull request description was created with GitHub Copilot.

[Copilot]

Pull request overview

This PR expands runtime symbol reporting for executable code that’s generated/allocated outside normal JITted methods, so tracing consumers can attribute those code ranges in ETW/EventPipe and PerfMap outputs. It does this by emitting helper-style method events for copied write barriers and code-heap stub/code-fragment blocks, and by improving CodeHeapIterator’s ability to surface bounded stub ranges during enumeration/rundown.

Changes:

• Add reporting/enumeration of copied write-barrier code ranges for ETW enumeration and PerfMap (including replay during method enumeration).
• Teach CodeHeapIterator to identify stub code blocks and provide bounded sizes + kinds for logging.
• Extend the EventPipe rundown validation test to generate VSD activity and validate helper events appear in live + rundown streams.

Show a summary per file

File	Description
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs	Generates VSD activity and validates helper-style stub/write-barrier events appear in live + rundown method events.
src/coreclr/vm/threads.h	Renames/init entrypoint and adds declarations for copied write-barrier reporting helpers.
src/coreclr/vm/threads.cpp	Implements enumeration/reporting of copied write barriers to PerfMap and ETW enumeration.
src/coreclr/vm/perfmap.cpp	Emits copied write barriers and stub-block ranges when generating an on-demand PerfMap.
src/coreclr/vm/eventtrace.cpp	Extends helper event emission to support different enumeration event types and reports stub blocks + copied write barriers during enumeration.
src/coreclr/vm/dynamicmethod.cpp	Ensures heap list entries for host code heaps carry a loader allocator pointer for filtered iteration.
src/coreclr/vm/codeman.h	Adds wide-string stub-kind names, stub-kind/size accessors on CodeHeapIterator, and moves small-block threshold to a shared constant.
src/coreclr/vm/codeman.cpp	Updates CodeHeapIterator to snapshot heap ends, identify stub code blocks, and report stub blocks via PerfMap + ETW helper events.
src/coreclr/vm/ceemain.cpp	Calls the new tracing-data initializer during startup.
src/coreclr/inc/eventtracebase.h	Updates/moves SendHelperEvent declaration to support passing enumeration options.

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 1
• Review effort level: Lite

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[brianrob]

/azp run runtime

Note

This rerun request was generated by GitHub Copilot after Build Analysis identified unrelated infrastructure timeouts and known test failures.

[azure-pipelines]

No pipelines are associated with this pull request.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Review details

Suppressed comments (1)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:111

• The test currently requires write-barrier helper events to be present and valid (ValidateHelperEvents(rundownWriteBarriers)), but copied write barriers are not necessarily enabled. In CoreCLR, write-barrier copying is gated by CLRConfig::UNSUPPORTED_UseGCWriteBarrierCopy and defaults to disabled (src/coreclr/vm/eeconfig.cpp:110 sets fIsWriteBarrierCopyEnabled = false; src/coreclr/vm/eeconfig.cpp:531 sets it based on the config switch). When the copy is disabled, ReportCopiedWriteBarriers* won’t emit any helper events, rundownWriteBarriers stays empty, and this test will fail on otherwise-correct builds.

Consider validating write-barrier helpers only when the events are actually present (or otherwise gating the expectation on a detectable condition).

 bool hasValidCoreClrHelpers =
!PlatformDetection.IsCoreCLR ||
!RuntimeFeature.IsDynamicCodeCompiled ||
(ValidateHelperEvents(liveStubBlocks) &&
ValidateHelperEvents(rundownStubBlocks) &&
ValidateHelperEvents(rundownWriteBarriers) &&
HaveMatchingStubBlocks(liveStubBlocks, rundownStubBlocks));

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[davidwrighton]

LGTM, but I want @hoyosjs to review as well before signoff.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

[brianrob]

/ba-g Current failures are unrelated known test failures: HttpListener timeout #132336 on both Windows checked legs, browser-Wasm bestfit-finalize #132107, and browser-Wasm ContextualReflection preemptive-GC assertion #131925. The affected tests and subsystems are outside this PR's ETW/stub changes.

Note

This Build Analysis override rationale was generated by GitHub Copilot.

[brianrob]

@hoyosjs this one should be ready for review again. Thanks.

[Copilot]

Review details

Suppressed comments (2)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:449

• The EventSource events are defined as JumpStubCollectionStart/JumpStubCollectionStop, but the trace parsing looks for "JumpStubCollection/Start" (task/opcode-style naming). Without explicitly setting EventOpcode and/or EventAttribute.Name, this comparison likely never matches, leaving collectionStart as NaN and causing the unload-range validation to fail.

 if (eventData.EventName == "JumpStubCollection/Start")
{
collectionStart = eventData.TimeStampRelativeMSec;
}

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:453

• Same issue as the Start event: the parser looks for "JumpStubCollection/Stop" but the EventSource event is JumpStubCollectionStop unless an explicit Stop opcode/name is set.

 else if (eventData.EventName == "JumpStubCollection/Stop")
{
collectionStop = eventData.TimeStampRelativeMSec;
}

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[hoyosjs]

Other than the test issue this seems good (assuming we are ok with the rundown event being an approximation, which seems fair for a trace/profiling effort - I don't see the tradeoff in storing this information elsewhere).

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:483

• If the JumpStubCollection Start/Stop markers are missing (e.g., due to EventName differences) or Stop precedes Start, collectionStart/collectionStop remain NaN/invalid and GetEventsInRange will silently return an empty set, causing a failure that’s hard to diagnose. Add an explicit validation of the marker timestamps before filtering unload events and log a clear error when they’re missing/invalid.

 List<HelperEvent> reclaimedJumpStubBlocks =
GetEventsInRange(unloadedJumpStubBlocks, collectionStart, collectionStop);
Logger.logger.Log("LCG jump-stub loads: " + loadedJumpStubBlocks.Count);
Logger.logger.Log("LCG jump-stub unloads: " + reclaimedJumpStubBlocks.Count);
return HaveMatchingLoadForEveryUnload(loadedJumpStubBlocks, reclaimedJumpStubBlocks)

[brianrob]

Summary

Improve symbol coverage for executable code generated outside normal JIT methods. This is in response to an internal customer that is capturing traces where large percentages of symbols are unresolvable and don't resolve to a module. Upon investigation, these symbols should resolve to the copied write barrier or one of several different kinds of stubs.

Coverage

Executable range	Live ETW/EventPipe	Capture state and rundown	Live PerfMap	On-demand PerfMap
Copied write barriers	Existing: emitted before tracing-provider initialization. This PR: moves reporting after initialization and preserves individual names and explicit sizes.	This PR: reports individual ranges through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	This PR: reports individual named ranges.	This PR: replays individual named ranges.
EEJitManager jump/code-fragment blocks	This PR: reports blocks through MethodLoadVerbose.	This PR: reports blocks through MethodUnloadVerbose, MethodDCStartVerbose, and MethodDCEndVerbose.	Existing: reports blocks or individual allocations according to DOTNET_PerfMapStubGranularity.	This PR: replays blocks regardless of live block/individual granularity.
Individual symbols within EEJitManager blocks	Existing: no individual or block events. This PR: reports one event for the allocation block containing the stubs.	Existing: no individual or block replay. This PR: replays the allocation block containing the stubs.	Existing: reports individual symbols where instrumented. This PR: no change.	Existing: no replay. This PR: reports the allocation block because individual symbols cannot be reconstructed.

On-demand PerfMap generation uses blocks because individual allocations cannot be reconstructed during enumeration.

All ETW/EventPipe entries use JitHelperMethod metadata.

Implementation Notes

CodeHeapIterator now snapshots each heap’s end and uses per-heap lookahead to produce bounded, non-overlapping stub ranges. Jump-stub sizes use their existing allocation metadata; other code-fragment blocks use the bounded allocation extent.

Copied write-barrier reporting derives targets from the configured JIT helper table.

This does not change stub layout, allocation size, alignment, CodeHeader adjacency, DAC contracts, or jump reachability.

Note

This pull request description was created with GitHub Copilot.

[Copilot]

Pull request overview

This PR expands runtime symbol reporting for executable code that’s generated/allocated outside normal JITted methods, so tracing consumers can attribute those code ranges in ETW/EventPipe and PerfMap outputs. It does this by emitting helper-style method events for copied write barriers and code-heap stub/code-fragment blocks, and by improving CodeHeapIterator’s ability to surface bounded stub ranges during enumeration/rundown.

Changes:

• Add reporting/enumeration of copied write-barrier code ranges for ETW enumeration and PerfMap (including replay during method enumeration).
• Teach CodeHeapIterator to identify stub code blocks and provide bounded sizes + kinds for logging.
• Extend the EventPipe rundown validation test to generate VSD activity and validate helper events appear in live + rundown streams.

Show a summary per file

File	Description
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs	Generates VSD activity and validates helper-style stub/write-barrier events appear in live + rundown method events.
src/coreclr/vm/threads.h	Renames/init entrypoint and adds declarations for copied write-barrier reporting helpers.
src/coreclr/vm/threads.cpp	Implements enumeration/reporting of copied write barriers to PerfMap and ETW enumeration.
src/coreclr/vm/perfmap.cpp	Emits copied write barriers and stub-block ranges when generating an on-demand PerfMap.
src/coreclr/vm/eventtrace.cpp	Extends helper event emission to support different enumeration event types and reports stub blocks + copied write barriers during enumeration.
src/coreclr/vm/dynamicmethod.cpp	Ensures heap list entries for host code heaps carry a loader allocator pointer for filtered iteration.
src/coreclr/vm/codeman.h	Adds wide-string stub-kind names, stub-kind/size accessors on CodeHeapIterator, and moves small-block threshold to a shared constant.
src/coreclr/vm/codeman.cpp	Updates CodeHeapIterator to snapshot heap ends, identify stub code blocks, and report stub blocks via PerfMap + ETW helper events.
src/coreclr/vm/ceemain.cpp	Calls the new tracing-data initializer during startup.
src/coreclr/inc/eventtracebase.h	Updates/moves SendHelperEvent declaration to support passing enumeration options.

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 10/10 changed files
• Comments generated: 1
• Review effort level: Lite

[dotnet-policy-service]

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[brianrob]

/azp run runtime

Note

This rerun request was generated by GitHub Copilot after Build Analysis identified unrelated infrastructure timeouts and known test failures.

[azure-pipelines]

No pipelines are associated with this pull request.

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Review details

Suppressed comments (1)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:111

• The test currently requires write-barrier helper events to be present and valid (ValidateHelperEvents(rundownWriteBarriers)), but copied write barriers are not necessarily enabled. In CoreCLR, write-barrier copying is gated by CLRConfig::UNSUPPORTED_UseGCWriteBarrierCopy and defaults to disabled (src/coreclr/vm/eeconfig.cpp:110 sets fIsWriteBarrierCopyEnabled = false; src/coreclr/vm/eeconfig.cpp:531 sets it based on the config switch). When the copy is disabled, ReportCopiedWriteBarriers* won’t emit any helper events, rundownWriteBarriers stays empty, and this test will fail on otherwise-correct builds.

Consider validating write-barrier helpers only when the events are actually present (or otherwise gating the expectation on a detectable condition).

 bool hasValidCoreClrHelpers =
!PlatformDetection.IsCoreCLR ||
!RuntimeFeature.IsDynamicCodeCompiled ||
(ValidateHelperEvents(liveStubBlocks) &&
ValidateHelperEvents(rundownStubBlocks) &&
ValidateHelperEvents(rundownWriteBarriers) &&
HaveMatchingStubBlocks(liveStubBlocks, rundownStubBlocks));

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[davidwrighton]

LGTM, but I want @hoyosjs to review as well before signoff.

[Copilot]

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

[brianrob]

/ba-g Current failures are unrelated known test failures: HttpListener timeout #132336 on both Windows checked legs, browser-Wasm bestfit-finalize #132107, and browser-Wasm ContextualReflection preemptive-GC assertion #131925. The affected tests and subsystems are outside this PR's ETW/stub changes.

Note

This Build Analysis override rationale was generated by GitHub Copilot.

[brianrob]

@hoyosjs this one should be ready for review again. Thanks.

[Copilot]

Review details

Suppressed comments (2)

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:449

• The EventSource events are defined as JumpStubCollectionStart/JumpStubCollectionStop, but the trace parsing looks for "JumpStubCollection/Start" (task/opcode-style naming). Without explicitly setting EventOpcode and/or EventAttribute.Name, this comparison likely never matches, leaving collectionStart as NaN and causing the unload-range validation to fail.

 if (eventData.EventName == "JumpStubCollection/Start")
{
collectionStart = eventData.TimeStampRelativeMSec;
}

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:453

• Same issue as the Start event: the parser looks for "JumpStubCollection/Stop" but the EventSource event is JumpStubCollectionStop unless an explicit Stop opcode/name is set.

 else if (eventData.EventName == "JumpStubCollection/Stop")
{
collectionStop = eventData.TimeStampRelativeMSec;
}

• Files reviewed: 11/11 changed files
• Comments generated: 0 new
• Review effort level: Lite

[hoyosjs]

Other than the test issue this seems good (assuming we are ok with the rundown event being an approximation, which seems fair for a trace/profiling effort - I don't see the tradeoff in storing this information elsewhere).

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs:483

• If the JumpStubCollection Start/Stop markers are missing (e.g., due to EventName differences) or Stop precedes Start, collectionStart/collectionStop remain NaN/invalid and GetEventsInRange will silently return an empty set, causing a failure that’s hard to diagnose. Add an explicit validation of the marker timestamps before filtering unload events and log a clear error when they’re missing/invalid.

 List<HelperEvent> reclaimedJumpStubBlocks =
GetEventsInRange(unloadedJumpStubBlocks, collectionStart, collectionStop);
Logger.logger.Log("LCG jump-stub loads: " + loadedJumpStubBlocks.Count);
Logger.logger.Log("LCG jump-stub unloads: " + reclaimedJumpStubBlocks.Count);
return HaveMatchingLoadForEveryUnload(loadedJumpStubBlocks, reclaimedJumpStubBlocks)