Don't require GDV targets to be inlineable

[EgorBo]

GDV used to bail out when the target wasn't inlineable. A direct call still beats a virtual one, so keep the candidate and just don't inline it. DOTNET_JitGuardedDevirtualizationRequireInlining=1 restores the old behavior. Class probes only.

I know it doesn't match Andy's numbers, but many things have changed since then (e.g. CET), also, I assume we never tested it on arm64. So far it's a pure improvement on most kinds of scenarious (interface, virtual calls, etc.), see benchmarks below. We still might want to avoid doing it for virtual calls (esp for large target methods where the cost of the type check + direct call is a noise anyway) only on CoreCLR, but I propose we do it for everything and watch dotnet/performance reports.

Should help NativeAOT the most, where getExactClasses gives exact devirtualization but targets often aren't inlineable (if at least one target of getExactClasses wasn't inlineable we used to bail on the whole thing).

CoreCLR, default env, all targets [NoInlining] (so baseline does no GDV at all). Columns = how often the guessed type hits, ratio = new/base, lower is better.

Benchmark	Mono	Hit90	Hit50	Hit33	Hit25
DirectControl (noise floor)	1.01	0.99	1.01	1.01	1.00
Interface	$\color{green}{0.72}$	$\color{green}{0.48}$	$\color{green}{0.45}$	$\color{green}{0.64}$	$\color{green}{0.56}$
InterfaceShared (__Canon)	$\color{green}{0.88}$	$\color{green}{0.50}$	$\color{green}{0.51}$	$\color{green}{0.62}$	$\color{green}{0.59}$
InterfaceCostlyTarget	$\color{green}{0.86}$	$\color{green}{0.58}$	$\color{green}{0.55}$	$\color{green}{0.65}$	$\color{green}{0.60}$
Virtual	$\color{green}{0.86}$	$\color{green}{0.78}$	$\color{green}{0.63}$	$\color{green}{0.64}$	$\color{green}{0.62}$
VirtualShared (__Canon)	$\color{red}{1.19}$	$\color{green}{0.55}$	$\color{green}{0.55}$	$\color{green}{0.52}$	$\color{green}{0.63}$
InterfaceHugeTarget (GDV in both)	1.10	1.10	1.03	1.01	1.00

Only regression is monomorphic shared-generic virtual - a well-predicted vtable call is already as cheap as compare+direct call.

rt-sz report: MichalStrehovsky/rt-sz#246
smoke-test benchmarks: EgorBot/Benchmarks#489 (comment)

[azure-pipelines]

Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts CoreCLR JIT guarded devirtualization (GDV) so that class-based GDV candidates can be kept and expanded even when the devirtualized target isn’t inlineable, preserving the direct-call benefit. It also adds a config switch to restore the legacy “require inlineability” behavior and tightens up candidate bookkeeping to support the new flow.

Changes:

• Add JitGuardedDevirtualizationRequireInlining config (default 0) to optionally restore legacy behavior of dropping non-inlineable GDV targets.
• Track per-candidate inlineability via InlineCandidateInfo::isInlineable and keep non-inlineable class-GDV candidates for devirtualization-only.
• Fix candidate bookkeeping (value-initialize InlineCandidateInfo and adjust spill-temp/enumerator-cloning mapping handling) to avoid relying on impCheckCanInline having run.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/jit/jitmetadatalist.h	Adds a new JIT metric counter (NoInlineGDV) for devirt-without-inlining cases.
src/coreclr/jit/jitconfigvalues.h	Introduces JitGuardedDevirtualizationRequireInlining config to gate legacy behavior.
src/coreclr/jit/inline.h	Adds InlineCandidateInfo::isInlineable to distinguish inline vs devirt-only GDV candidates.
src/coreclr/jit/indirectcalltransformer.cpp	Removes “must be inline-candidate” bail-out; expands GDV while conditionally re-marking inline candidates; fixes spill-temp and enumerator cloning map behavior.
src/coreclr/jit/importercalls.cpp	Keeps non-inlineable class-GDV candidates when legal; value-initializes candidate info; adjusts struct-return fixup deferral for GDV candidates.
src/coreclr/jit/compiler.h	Declares Compiler::canKeepNonInlineableGdvCandidate.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[MichalPetryka]

@MihuBot -nuget

[EgorBo]

@MihuBot -nuget

@MichalPetryka This change requires PGO data, MihuBot is basically just PrepareMethod

[EgorBo]

/azp run runtime-coreclr pgostress, runtime-coreclr libraries-pgo

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[EgorBo]

@EgorBot -linux_amd -osx_arm64 -windows_amd

usingSystem.Runtime.CompilerServices;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicinterfaceIOp{intDo(intx);}publicclassOpA:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+1;}publicclassOpB:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+2;}publicabstractclassBase{publicabstractintDo(intx);}publicclassDerA:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+1;}publicclassDerB:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+2;}publicclassBench{privateIOp[]_ifaces=newIOp[64];privateBase[]_virts=newBase[64];[GlobalSetup]publicvoidSetup(){for(inti=0;i<64;i++){// 75% A, 25% B_ifaces[i]=i%4==0?newOpB():newOpA();_virts[i]=i%4==0?newDerB():(Base)newDerA();}}[Benchmark]publicintInterfaceCall(){intsum=0;IOp[]ops=_ifaces;for(inti=0;i<ops.Length;i++)sum+=ops[i].Do(i);returnsum;}[Benchmark]publicintVirtualCall(){intsum=0;Base[]objs=_virts;for(inti=0;i<objs.Length;i++)sum+=objs[i].Do(i);returnsum;}}

[EgorBo]

PTAL @AndyAyersMS (see PR description), .NET 12.0 change cc @dotnet/jit-contrib.

[EgorBo]

cc @MichalStrehovsky I think you asked for it a while back for NAOT.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[EgorBo]

@AndyAyersMS addressed your feedback, it now needs re-approval 🙂

[EgorBo]

Ping @AndyAyersMS

[BrzVlad]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

[EgorBo]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

Yep, sorry, it's a bad last-minute feedback address change, I'll file a fix in a minute

[EgorBo]

#133014

Fixed.

[EgorBo]

GDV used to bail out when the target wasn't inlineable. A direct call still beats a virtual one, so keep the candidate and just don't inline it. DOTNET_JitGuardedDevirtualizationRequireInlining=1 restores the old behavior. Class probes only.

I know it doesn't match Andy's numbers, but many things have changed since then (e.g. CET), also, I assume we never tested it on arm64. So far it's a pure improvement on most kinds of scenarious (interface, virtual calls, etc.), see benchmarks below. We still might want to avoid doing it for virtual calls (esp for large target methods where the cost of the type check + direct call is a noise anyway) only on CoreCLR, but I propose we do it for everything and watch dotnet/performance reports.

Should help NativeAOT the most, where getExactClasses gives exact devirtualization but targets often aren't inlineable (if at least one target of getExactClasses wasn't inlineable we used to bail on the whole thing).

CoreCLR, default env, all targets [NoInlining] (so baseline does no GDV at all). Columns = how often the guessed type hits, ratio = new/base, lower is better.

Benchmark	Mono	Hit90	Hit50	Hit33	Hit25
DirectControl (noise floor)	1.01	0.99	1.01	1.01	1.00
Interface	$\color{green}{0.72}$	$\color{green}{0.48}$	$\color{green}{0.45}$	$\color{green}{0.64}$	$\color{green}{0.56}$
InterfaceShared (__Canon)	$\color{green}{0.88}$	$\color{green}{0.50}$	$\color{green}{0.51}$	$\color{green}{0.62}$	$\color{green}{0.59}$
InterfaceCostlyTarget	$\color{green}{0.86}$	$\color{green}{0.58}$	$\color{green}{0.55}$	$\color{green}{0.65}$	$\color{green}{0.60}$
Virtual	$\color{green}{0.86}$	$\color{green}{0.78}$	$\color{green}{0.63}$	$\color{green}{0.64}$	$\color{green}{0.62}$
VirtualShared (__Canon)	$\color{red}{1.19}$	$\color{green}{0.55}$	$\color{green}{0.55}$	$\color{green}{0.52}$	$\color{green}{0.63}$
InterfaceHugeTarget (GDV in both)	1.10	1.10	1.03	1.01	1.00

Only regression is monomorphic shared-generic virtual - a well-predicted vtable call is already as cheap as compare+direct call.

rt-sz report: MichalStrehovsky/rt-sz#246
smoke-test benchmarks: EgorBot/Benchmarks#489 (comment)

[azure-pipelines]

Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts CoreCLR JIT guarded devirtualization (GDV) so that class-based GDV candidates can be kept and expanded even when the devirtualized target isn’t inlineable, preserving the direct-call benefit. It also adds a config switch to restore the legacy “require inlineability” behavior and tightens up candidate bookkeeping to support the new flow.

Changes:

• Add JitGuardedDevirtualizationRequireInlining config (default 0) to optionally restore legacy behavior of dropping non-inlineable GDV targets.
• Track per-candidate inlineability via InlineCandidateInfo::isInlineable and keep non-inlineable class-GDV candidates for devirtualization-only.
• Fix candidate bookkeeping (value-initialize InlineCandidateInfo and adjust spill-temp/enumerator-cloning mapping handling) to avoid relying on impCheckCanInline having run.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/jit/jitmetadatalist.h	Adds a new JIT metric counter (NoInlineGDV) for devirt-without-inlining cases.
src/coreclr/jit/jitconfigvalues.h	Introduces JitGuardedDevirtualizationRequireInlining config to gate legacy behavior.
src/coreclr/jit/inline.h	Adds InlineCandidateInfo::isInlineable to distinguish inline vs devirt-only GDV candidates.
src/coreclr/jit/indirectcalltransformer.cpp	Removes “must be inline-candidate” bail-out; expands GDV while conditionally re-marking inline candidates; fixes spill-temp and enumerator cloning map behavior.
src/coreclr/jit/importercalls.cpp	Keeps non-inlineable class-GDV candidates when legal; value-initializes candidate info; adjusts struct-return fixup deferral for GDV candidates.
src/coreclr/jit/compiler.h	Declares Compiler::canKeepNonInlineableGdvCandidate.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[MichalPetryka]

@MihuBot -nuget

[EgorBo]

@MihuBot -nuget

@MichalPetryka This change requires PGO data, MihuBot is basically just PrepareMethod

[EgorBo]

/azp run runtime-coreclr pgostress, runtime-coreclr libraries-pgo

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[EgorBo]

@EgorBot -linux_amd -osx_arm64 -windows_amd

usingSystem.Runtime.CompilerServices;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicinterfaceIOp{intDo(intx);}publicclassOpA:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+1;}publicclassOpB:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+2;}publicabstractclassBase{publicabstractintDo(intx);}publicclassDerA:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+1;}publicclassDerB:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+2;}publicclassBench{privateIOp[]_ifaces=newIOp[64];privateBase[]_virts=newBase[64];[GlobalSetup]publicvoidSetup(){for(inti=0;i<64;i++){// 75% A, 25% B_ifaces[i]=i%4==0?newOpB():newOpA();_virts[i]=i%4==0?newDerB():(Base)newDerA();}}[Benchmark]publicintInterfaceCall(){intsum=0;IOp[]ops=_ifaces;for(inti=0;i<ops.Length;i++)sum+=ops[i].Do(i);returnsum;}[Benchmark]publicintVirtualCall(){intsum=0;Base[]objs=_virts;for(inti=0;i<objs.Length;i++)sum+=objs[i].Do(i);returnsum;}}

[EgorBo]

PTAL @AndyAyersMS (see PR description), .NET 12.0 change cc @dotnet/jit-contrib.

[EgorBo]

cc @MichalStrehovsky I think you asked for it a while back for NAOT.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[EgorBo]

@AndyAyersMS addressed your feedback, it now needs re-approval 🙂

[EgorBo]

Ping @AndyAyersMS

[BrzVlad]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

[EgorBo]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

Yep, sorry, it's a bad last-minute feedback address change, I'll file a fix in a minute

[EgorBo]

#133014

Fixed.

[EgorBo]

GDV used to bail out when the target wasn't inlineable. A direct call still beats a virtual one, so keep the candidate and just don't inline it. DOTNET_JitGuardedDevirtualizationRequireInlining=1 restores the old behavior. Class probes only.

I know it doesn't match Andy's numbers, but many things have changed since then (e.g. CET), also, I assume we never tested it on arm64. So far it's a pure improvement on most kinds of scenarious (interface, virtual calls, etc.), see benchmarks below. We still might want to avoid doing it for virtual calls (esp for large target methods where the cost of the type check + direct call is a noise anyway) only on CoreCLR, but I propose we do it for everything and watch dotnet/performance reports.

Should help NativeAOT the most, where getExactClasses gives exact devirtualization but targets often aren't inlineable (if at least one target of getExactClasses wasn't inlineable we used to bail on the whole thing).

CoreCLR, default env, all targets [NoInlining] (so baseline does no GDV at all). Columns = how often the guessed type hits, ratio = new/base, lower is better.

Benchmark	Mono	Hit90	Hit50	Hit33	Hit25
DirectControl (noise floor)	1.01	0.99	1.01	1.01	1.00
Interface	$\color{green}{0.72}$	$\color{green}{0.48}$	$\color{green}{0.45}$	$\color{green}{0.64}$	$\color{green}{0.56}$
InterfaceShared (__Canon)	$\color{green}{0.88}$	$\color{green}{0.50}$	$\color{green}{0.51}$	$\color{green}{0.62}$	$\color{green}{0.59}$
InterfaceCostlyTarget	$\color{green}{0.86}$	$\color{green}{0.58}$	$\color{green}{0.55}$	$\color{green}{0.65}$	$\color{green}{0.60}$
Virtual	$\color{green}{0.86}$	$\color{green}{0.78}$	$\color{green}{0.63}$	$\color{green}{0.64}$	$\color{green}{0.62}$
VirtualShared (__Canon)	$\color{red}{1.19}$	$\color{green}{0.55}$	$\color{green}{0.55}$	$\color{green}{0.52}$	$\color{green}{0.63}$
InterfaceHugeTarget (GDV in both)	1.10	1.10	1.03	1.01	1.00

Only regression is monomorphic shared-generic virtual - a well-predicted vtable call is already as cheap as compare+direct call.

rt-sz report: MichalStrehovsky/rt-sz#246
smoke-test benchmarks: EgorBot/Benchmarks#489 (comment)

[azure-pipelines]

Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts CoreCLR JIT guarded devirtualization (GDV) so that class-based GDV candidates can be kept and expanded even when the devirtualized target isn’t inlineable, preserving the direct-call benefit. It also adds a config switch to restore the legacy “require inlineability” behavior and tightens up candidate bookkeeping to support the new flow.

Changes:

• Add JitGuardedDevirtualizationRequireInlining config (default 0) to optionally restore legacy behavior of dropping non-inlineable GDV targets.
• Track per-candidate inlineability via InlineCandidateInfo::isInlineable and keep non-inlineable class-GDV candidates for devirtualization-only.
• Fix candidate bookkeeping (value-initialize InlineCandidateInfo and adjust spill-temp/enumerator-cloning mapping handling) to avoid relying on impCheckCanInline having run.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/jit/jitmetadatalist.h	Adds a new JIT metric counter (NoInlineGDV) for devirt-without-inlining cases.
src/coreclr/jit/jitconfigvalues.h	Introduces JitGuardedDevirtualizationRequireInlining config to gate legacy behavior.
src/coreclr/jit/inline.h	Adds InlineCandidateInfo::isInlineable to distinguish inline vs devirt-only GDV candidates.
src/coreclr/jit/indirectcalltransformer.cpp	Removes “must be inline-candidate” bail-out; expands GDV while conditionally re-marking inline candidates; fixes spill-temp and enumerator cloning map behavior.
src/coreclr/jit/importercalls.cpp	Keeps non-inlineable class-GDV candidates when legal; value-initializes candidate info; adjusts struct-return fixup deferral for GDV candidates.
src/coreclr/jit/compiler.h	Declares Compiler::canKeepNonInlineableGdvCandidate.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[MichalPetryka]

@MihuBot -nuget

[EgorBo]

@MihuBot -nuget

@MichalPetryka This change requires PGO data, MihuBot is basically just PrepareMethod

[EgorBo]

/azp run runtime-coreclr pgostress, runtime-coreclr libraries-pgo

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[EgorBo]

@EgorBot -linux_amd -osx_arm64 -windows_amd

usingSystem.Runtime.CompilerServices;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicinterfaceIOp{intDo(intx);}publicclassOpA:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+1;}publicclassOpB:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+2;}publicabstractclassBase{publicabstractintDo(intx);}publicclassDerA:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+1;}publicclassDerB:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+2;}publicclassBench{privateIOp[]_ifaces=newIOp[64];privateBase[]_virts=newBase[64];[GlobalSetup]publicvoidSetup(){for(inti=0;i<64;i++){// 75% A, 25% B_ifaces[i]=i%4==0?newOpB():newOpA();_virts[i]=i%4==0?newDerB():(Base)newDerA();}}[Benchmark]publicintInterfaceCall(){intsum=0;IOp[]ops=_ifaces;for(inti=0;i<ops.Length;i++)sum+=ops[i].Do(i);returnsum;}[Benchmark]publicintVirtualCall(){intsum=0;Base[]objs=_virts;for(inti=0;i<objs.Length;i++)sum+=objs[i].Do(i);returnsum;}}

[EgorBo]

PTAL @AndyAyersMS (see PR description), .NET 12.0 change cc @dotnet/jit-contrib.

[EgorBo]

cc @MichalStrehovsky I think you asked for it a while back for NAOT.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[EgorBo]

@AndyAyersMS addressed your feedback, it now needs re-approval 🙂

[EgorBo]

Ping @AndyAyersMS

[BrzVlad]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

[EgorBo]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

Yep, sorry, it's a bad last-minute feedback address change, I'll file a fix in a minute

[EgorBo]

#133014

Fixed.

[EgorBo]

GDV used to bail out when the target wasn't inlineable. A direct call still beats a virtual one, so keep the candidate and just don't inline it. DOTNET_JitGuardedDevirtualizationRequireInlining=1 restores the old behavior. Class probes only.

I know it doesn't match Andy's numbers, but many things have changed since then (e.g. CET), also, I assume we never tested it on arm64. So far it's a pure improvement on most kinds of scenarious (interface, virtual calls, etc.), see benchmarks below. We still might want to avoid doing it for virtual calls (esp for large target methods where the cost of the type check + direct call is a noise anyway) only on CoreCLR, but I propose we do it for everything and watch dotnet/performance reports.

Should help NativeAOT the most, where getExactClasses gives exact devirtualization but targets often aren't inlineable (if at least one target of getExactClasses wasn't inlineable we used to bail on the whole thing).

CoreCLR, default env, all targets [NoInlining] (so baseline does no GDV at all). Columns = how often the guessed type hits, ratio = new/base, lower is better.

Benchmark	Mono	Hit90	Hit50	Hit33	Hit25
DirectControl (noise floor)	1.01	0.99	1.01	1.01	1.00
Interface	$\color{green}{0.72}$	$\color{green}{0.48}$	$\color{green}{0.45}$	$\color{green}{0.64}$	$\color{green}{0.56}$
InterfaceShared (__Canon)	$\color{green}{0.88}$	$\color{green}{0.50}$	$\color{green}{0.51}$	$\color{green}{0.62}$	$\color{green}{0.59}$
InterfaceCostlyTarget	$\color{green}{0.86}$	$\color{green}{0.58}$	$\color{green}{0.55}$	$\color{green}{0.65}$	$\color{green}{0.60}$
Virtual	$\color{green}{0.86}$	$\color{green}{0.78}$	$\color{green}{0.63}$	$\color{green}{0.64}$	$\color{green}{0.62}$
VirtualShared (__Canon)	$\color{red}{1.19}$	$\color{green}{0.55}$	$\color{green}{0.55}$	$\color{green}{0.52}$	$\color{green}{0.63}$
InterfaceHugeTarget (GDV in both)	1.10	1.10	1.03	1.01	1.00

Only regression is monomorphic shared-generic virtual - a well-predicted vtable call is already as cheap as compare+direct call.

rt-sz report: MichalStrehovsky/rt-sz#246
smoke-test benchmarks: EgorBot/Benchmarks#489 (comment)

[azure-pipelines]

Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts CoreCLR JIT guarded devirtualization (GDV) so that class-based GDV candidates can be kept and expanded even when the devirtualized target isn’t inlineable, preserving the direct-call benefit. It also adds a config switch to restore the legacy “require inlineability” behavior and tightens up candidate bookkeeping to support the new flow.

Changes:

• Add JitGuardedDevirtualizationRequireInlining config (default 0) to optionally restore legacy behavior of dropping non-inlineable GDV targets.
• Track per-candidate inlineability via InlineCandidateInfo::isInlineable and keep non-inlineable class-GDV candidates for devirtualization-only.
• Fix candidate bookkeeping (value-initialize InlineCandidateInfo and adjust spill-temp/enumerator-cloning mapping handling) to avoid relying on impCheckCanInline having run.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/jit/jitmetadatalist.h	Adds a new JIT metric counter (NoInlineGDV) for devirt-without-inlining cases.
src/coreclr/jit/jitconfigvalues.h	Introduces JitGuardedDevirtualizationRequireInlining config to gate legacy behavior.
src/coreclr/jit/inline.h	Adds InlineCandidateInfo::isInlineable to distinguish inline vs devirt-only GDV candidates.
src/coreclr/jit/indirectcalltransformer.cpp	Removes “must be inline-candidate” bail-out; expands GDV while conditionally re-marking inline candidates; fixes spill-temp and enumerator cloning map behavior.
src/coreclr/jit/importercalls.cpp	Keeps non-inlineable class-GDV candidates when legal; value-initializes candidate info; adjusts struct-return fixup deferral for GDV candidates.
src/coreclr/jit/compiler.h	Declares Compiler::canKeepNonInlineableGdvCandidate.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[MichalPetryka]

@MihuBot -nuget

[EgorBo]

@MihuBot -nuget

@MichalPetryka This change requires PGO data, MihuBot is basically just PrepareMethod

[EgorBo]

/azp run runtime-coreclr pgostress, runtime-coreclr libraries-pgo

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[EgorBo]

@EgorBot -linux_amd -osx_arm64 -windows_amd

usingSystem.Runtime.CompilerServices;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicinterfaceIOp{intDo(intx);}publicclassOpA:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+1;}publicclassOpB:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+2;}publicabstractclassBase{publicabstractintDo(intx);}publicclassDerA:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+1;}publicclassDerB:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+2;}publicclassBench{privateIOp[]_ifaces=newIOp[64];privateBase[]_virts=newBase[64];[GlobalSetup]publicvoidSetup(){for(inti=0;i<64;i++){// 75% A, 25% B_ifaces[i]=i%4==0?newOpB():newOpA();_virts[i]=i%4==0?newDerB():(Base)newDerA();}}[Benchmark]publicintInterfaceCall(){intsum=0;IOp[]ops=_ifaces;for(inti=0;i<ops.Length;i++)sum+=ops[i].Do(i);returnsum;}[Benchmark]publicintVirtualCall(){intsum=0;Base[]objs=_virts;for(inti=0;i<objs.Length;i++)sum+=objs[i].Do(i);returnsum;}}

[EgorBo]

PTAL @AndyAyersMS (see PR description), .NET 12.0 change cc @dotnet/jit-contrib.

[EgorBo]

cc @MichalStrehovsky I think you asked for it a while back for NAOT.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[EgorBo]

@AndyAyersMS addressed your feedback, it now needs re-approval 🙂

[EgorBo]

Ping @AndyAyersMS

[BrzVlad]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

[EgorBo]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

Yep, sorry, it's a bad last-minute feedback address change, I'll file a fix in a minute

[EgorBo]

#133014

Fixed.

[EgorBo]

GDV used to bail out when the target wasn't inlineable. A direct call still beats a virtual one, so keep the candidate and just don't inline it. DOTNET_JitGuardedDevirtualizationRequireInlining=1 restores the old behavior. Class probes only.

I know it doesn't match Andy's numbers, but many things have changed since then (e.g. CET), also, I assume we never tested it on arm64. So far it's a pure improvement on most kinds of scenarious (interface, virtual calls, etc.), see benchmarks below. We still might want to avoid doing it for virtual calls (esp for large target methods where the cost of the type check + direct call is a noise anyway) only on CoreCLR, but I propose we do it for everything and watch dotnet/performance reports.

Should help NativeAOT the most, where getExactClasses gives exact devirtualization but targets often aren't inlineable (if at least one target of getExactClasses wasn't inlineable we used to bail on the whole thing).

CoreCLR, default env, all targets [NoInlining] (so baseline does no GDV at all). Columns = how often the guessed type hits, ratio = new/base, lower is better.

Benchmark	Mono	Hit90	Hit50	Hit33	Hit25
DirectControl (noise floor)	1.01	0.99	1.01	1.01	1.00
Interface	$\color{green}{0.72}$	$\color{green}{0.48}$	$\color{green}{0.45}$	$\color{green}{0.64}$	$\color{green}{0.56}$
InterfaceShared (__Canon)	$\color{green}{0.88}$	$\color{green}{0.50}$	$\color{green}{0.51}$	$\color{green}{0.62}$	$\color{green}{0.59}$
InterfaceCostlyTarget	$\color{green}{0.86}$	$\color{green}{0.58}$	$\color{green}{0.55}$	$\color{green}{0.65}$	$\color{green}{0.60}$
Virtual	$\color{green}{0.86}$	$\color{green}{0.78}$	$\color{green}{0.63}$	$\color{green}{0.64}$	$\color{green}{0.62}$
VirtualShared (__Canon)	$\color{red}{1.19}$	$\color{green}{0.55}$	$\color{green}{0.55}$	$\color{green}{0.52}$	$\color{green}{0.63}$
InterfaceHugeTarget (GDV in both)	1.10	1.10	1.03	1.01	1.00

Only regression is monomorphic shared-generic virtual - a well-predicted vtable call is already as cheap as compare+direct call.

rt-sz report: MichalStrehovsky/rt-sz#246
smoke-test benchmarks: EgorBot/Benchmarks#489 (comment)

[azure-pipelines]

Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts CoreCLR JIT guarded devirtualization (GDV) so that class-based GDV candidates can be kept and expanded even when the devirtualized target isn’t inlineable, preserving the direct-call benefit. It also adds a config switch to restore the legacy “require inlineability” behavior and tightens up candidate bookkeeping to support the new flow.

Changes:

• Add JitGuardedDevirtualizationRequireInlining config (default 0) to optionally restore legacy behavior of dropping non-inlineable GDV targets.
• Track per-candidate inlineability via InlineCandidateInfo::isInlineable and keep non-inlineable class-GDV candidates for devirtualization-only.
• Fix candidate bookkeeping (value-initialize InlineCandidateInfo and adjust spill-temp/enumerator-cloning mapping handling) to avoid relying on impCheckCanInline having run.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/jit/jitmetadatalist.h	Adds a new JIT metric counter (NoInlineGDV) for devirt-without-inlining cases.
src/coreclr/jit/jitconfigvalues.h	Introduces JitGuardedDevirtualizationRequireInlining config to gate legacy behavior.
src/coreclr/jit/inline.h	Adds InlineCandidateInfo::isInlineable to distinguish inline vs devirt-only GDV candidates.
src/coreclr/jit/indirectcalltransformer.cpp	Removes “must be inline-candidate” bail-out; expands GDV while conditionally re-marking inline candidates; fixes spill-temp and enumerator cloning map behavior.
src/coreclr/jit/importercalls.cpp	Keeps non-inlineable class-GDV candidates when legal; value-initializes candidate info; adjusts struct-return fixup deferral for GDV candidates.
src/coreclr/jit/compiler.h	Declares Compiler::canKeepNonInlineableGdvCandidate.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[MichalPetryka]

@MihuBot -nuget

[EgorBo]

@MihuBot -nuget

@MichalPetryka This change requires PGO data, MihuBot is basically just PrepareMethod

[EgorBo]

/azp run runtime-coreclr pgostress, runtime-coreclr libraries-pgo

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[EgorBo]

@EgorBot -linux_amd -osx_arm64 -windows_amd

usingSystem.Runtime.CompilerServices;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicinterfaceIOp{intDo(intx);}publicclassOpA:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+1;}publicclassOpB:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+2;}publicabstractclassBase{publicabstractintDo(intx);}publicclassDerA:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+1;}publicclassDerB:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+2;}publicclassBench{privateIOp[]_ifaces=newIOp[64];privateBase[]_virts=newBase[64];[GlobalSetup]publicvoidSetup(){for(inti=0;i<64;i++){// 75% A, 25% B_ifaces[i]=i%4==0?newOpB():newOpA();_virts[i]=i%4==0?newDerB():(Base)newDerA();}}[Benchmark]publicintInterfaceCall(){intsum=0;IOp[]ops=_ifaces;for(inti=0;i<ops.Length;i++)sum+=ops[i].Do(i);returnsum;}[Benchmark]publicintVirtualCall(){intsum=0;Base[]objs=_virts;for(inti=0;i<objs.Length;i++)sum+=objs[i].Do(i);returnsum;}}

[EgorBo]

PTAL @AndyAyersMS (see PR description), .NET 12.0 change cc @dotnet/jit-contrib.

[EgorBo]

cc @MichalStrehovsky I think you asked for it a while back for NAOT.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[EgorBo]

@AndyAyersMS addressed your feedback, it now needs re-approval 🙂

[EgorBo]

Ping @AndyAyersMS

[BrzVlad]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

[EgorBo]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

Yep, sorry, it's a bad last-minute feedback address change, I'll file a fix in a minute

[EgorBo]

#133014

Fixed.

[EgorBo]

GDV used to bail out when the target wasn't inlineable. A direct call still beats a virtual one, so keep the candidate and just don't inline it. DOTNET_JitGuardedDevirtualizationRequireInlining=1 restores the old behavior. Class probes only.

I know it doesn't match Andy's numbers, but many things have changed since then (e.g. CET), also, I assume we never tested it on arm64. So far it's a pure improvement on most kinds of scenarious (interface, virtual calls, etc.), see benchmarks below. We still might want to avoid doing it for virtual calls (esp for large target methods where the cost of the type check + direct call is a noise anyway) only on CoreCLR, but I propose we do it for everything and watch dotnet/performance reports.

Should help NativeAOT the most, where getExactClasses gives exact devirtualization but targets often aren't inlineable (if at least one target of getExactClasses wasn't inlineable we used to bail on the whole thing).

CoreCLR, default env, all targets [NoInlining] (so baseline does no GDV at all). Columns = how often the guessed type hits, ratio = new/base, lower is better.

Benchmark	Mono	Hit90	Hit50	Hit33	Hit25
DirectControl (noise floor)	1.01	0.99	1.01	1.01	1.00
Interface	$\color{green}{0.72}$	$\color{green}{0.48}$	$\color{green}{0.45}$	$\color{green}{0.64}$	$\color{green}{0.56}$
InterfaceShared (__Canon)	$\color{green}{0.88}$	$\color{green}{0.50}$	$\color{green}{0.51}$	$\color{green}{0.62}$	$\color{green}{0.59}$
InterfaceCostlyTarget	$\color{green}{0.86}$	$\color{green}{0.58}$	$\color{green}{0.55}$	$\color{green}{0.65}$	$\color{green}{0.60}$
Virtual	$\color{green}{0.86}$	$\color{green}{0.78}$	$\color{green}{0.63}$	$\color{green}{0.64}$	$\color{green}{0.62}$
VirtualShared (__Canon)	$\color{red}{1.19}$	$\color{green}{0.55}$	$\color{green}{0.55}$	$\color{green}{0.52}$	$\color{green}{0.63}$
InterfaceHugeTarget (GDV in both)	1.10	1.10	1.03	1.01	1.00

Only regression is monomorphic shared-generic virtual - a well-predicted vtable call is already as cheap as compare+direct call.

rt-sz report: MichalStrehovsky/rt-sz#246
smoke-test benchmarks: EgorBot/Benchmarks#489 (comment)

[azure-pipelines]

Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts CoreCLR JIT guarded devirtualization (GDV) so that class-based GDV candidates can be kept and expanded even when the devirtualized target isn’t inlineable, preserving the direct-call benefit. It also adds a config switch to restore the legacy “require inlineability” behavior and tightens up candidate bookkeeping to support the new flow.

Changes:

• Add JitGuardedDevirtualizationRequireInlining config (default 0) to optionally restore legacy behavior of dropping non-inlineable GDV targets.
• Track per-candidate inlineability via InlineCandidateInfo::isInlineable and keep non-inlineable class-GDV candidates for devirtualization-only.
• Fix candidate bookkeeping (value-initialize InlineCandidateInfo and adjust spill-temp/enumerator-cloning mapping handling) to avoid relying on impCheckCanInline having run.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/jit/jitmetadatalist.h	Adds a new JIT metric counter (NoInlineGDV) for devirt-without-inlining cases.
src/coreclr/jit/jitconfigvalues.h	Introduces JitGuardedDevirtualizationRequireInlining config to gate legacy behavior.
src/coreclr/jit/inline.h	Adds InlineCandidateInfo::isInlineable to distinguish inline vs devirt-only GDV candidates.
src/coreclr/jit/indirectcalltransformer.cpp	Removes “must be inline-candidate” bail-out; expands GDV while conditionally re-marking inline candidates; fixes spill-temp and enumerator cloning map behavior.
src/coreclr/jit/importercalls.cpp	Keeps non-inlineable class-GDV candidates when legal; value-initializes candidate info; adjusts struct-return fixup deferral for GDV candidates.
src/coreclr/jit/compiler.h	Declares Compiler::canKeepNonInlineableGdvCandidate.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[MichalPetryka]

@MihuBot -nuget

[EgorBo]

@MihuBot -nuget

@MichalPetryka This change requires PGO data, MihuBot is basically just PrepareMethod

[EgorBo]

/azp run runtime-coreclr pgostress, runtime-coreclr libraries-pgo

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[EgorBo]

@EgorBot -linux_amd -osx_arm64 -windows_amd

usingSystem.Runtime.CompilerServices;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicinterfaceIOp{intDo(intx);}publicclassOpA:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+1;}publicclassOpB:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+2;}publicabstractclassBase{publicabstractintDo(intx);}publicclassDerA:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+1;}publicclassDerB:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+2;}publicclassBench{privateIOp[]_ifaces=newIOp[64];privateBase[]_virts=newBase[64];[GlobalSetup]publicvoidSetup(){for(inti=0;i<64;i++){// 75% A, 25% B_ifaces[i]=i%4==0?newOpB():newOpA();_virts[i]=i%4==0?newDerB():(Base)newDerA();}}[Benchmark]publicintInterfaceCall(){intsum=0;IOp[]ops=_ifaces;for(inti=0;i<ops.Length;i++)sum+=ops[i].Do(i);returnsum;}[Benchmark]publicintVirtualCall(){intsum=0;Base[]objs=_virts;for(inti=0;i<objs.Length;i++)sum+=objs[i].Do(i);returnsum;}}

[EgorBo]

PTAL @AndyAyersMS (see PR description), .NET 12.0 change cc @dotnet/jit-contrib.

[EgorBo]

cc @MichalStrehovsky I think you asked for it a while back for NAOT.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[EgorBo]

@AndyAyersMS addressed your feedback, it now needs re-approval 🙂

[EgorBo]

Ping @AndyAyersMS

[BrzVlad]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

[EgorBo]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

Yep, sorry, it's a bad last-minute feedback address change, I'll file a fix in a minute

[EgorBo]

#133014

Fixed.

[EgorBo]

GDV used to bail out when the target wasn't inlineable. A direct call still beats a virtual one, so keep the candidate and just don't inline it. DOTNET_JitGuardedDevirtualizationRequireInlining=1 restores the old behavior. Class probes only.

I know it doesn't match Andy's numbers, but many things have changed since then (e.g. CET), also, I assume we never tested it on arm64. So far it's a pure improvement on most kinds of scenarious (interface, virtual calls, etc.), see benchmarks below. We still might want to avoid doing it for virtual calls (esp for large target methods where the cost of the type check + direct call is a noise anyway) only on CoreCLR, but I propose we do it for everything and watch dotnet/performance reports.

Should help NativeAOT the most, where getExactClasses gives exact devirtualization but targets often aren't inlineable (if at least one target of getExactClasses wasn't inlineable we used to bail on the whole thing).

CoreCLR, default env, all targets [NoInlining] (so baseline does no GDV at all). Columns = how often the guessed type hits, ratio = new/base, lower is better.

Benchmark	Mono	Hit90	Hit50	Hit33	Hit25
DirectControl (noise floor)	1.01	0.99	1.01	1.01	1.00
Interface	$\color{green}{0.72}$	$\color{green}{0.48}$	$\color{green}{0.45}$	$\color{green}{0.64}$	$\color{green}{0.56}$
InterfaceShared (__Canon)	$\color{green}{0.88}$	$\color{green}{0.50}$	$\color{green}{0.51}$	$\color{green}{0.62}$	$\color{green}{0.59}$
InterfaceCostlyTarget	$\color{green}{0.86}$	$\color{green}{0.58}$	$\color{green}{0.55}$	$\color{green}{0.65}$	$\color{green}{0.60}$
Virtual	$\color{green}{0.86}$	$\color{green}{0.78}$	$\color{green}{0.63}$	$\color{green}{0.64}$	$\color{green}{0.62}$
VirtualShared (__Canon)	$\color{red}{1.19}$	$\color{green}{0.55}$	$\color{green}{0.55}$	$\color{green}{0.52}$	$\color{green}{0.63}$
InterfaceHugeTarget (GDV in both)	1.10	1.10	1.03	1.01	1.00

Only regression is monomorphic shared-generic virtual - a well-predicted vtable call is already as cheap as compare+direct call.

rt-sz report: MichalStrehovsky/rt-sz#246
smoke-test benchmarks: EgorBot/Benchmarks#489 (comment)

[azure-pipelines]

Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts CoreCLR JIT guarded devirtualization (GDV) so that class-based GDV candidates can be kept and expanded even when the devirtualized target isn’t inlineable, preserving the direct-call benefit. It also adds a config switch to restore the legacy “require inlineability” behavior and tightens up candidate bookkeeping to support the new flow.

Changes:

• Add JitGuardedDevirtualizationRequireInlining config (default 0) to optionally restore legacy behavior of dropping non-inlineable GDV targets.
• Track per-candidate inlineability via InlineCandidateInfo::isInlineable and keep non-inlineable class-GDV candidates for devirtualization-only.
• Fix candidate bookkeeping (value-initialize InlineCandidateInfo and adjust spill-temp/enumerator-cloning mapping handling) to avoid relying on impCheckCanInline having run.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/jit/jitmetadatalist.h	Adds a new JIT metric counter (NoInlineGDV) for devirt-without-inlining cases.
src/coreclr/jit/jitconfigvalues.h	Introduces JitGuardedDevirtualizationRequireInlining config to gate legacy behavior.
src/coreclr/jit/inline.h	Adds InlineCandidateInfo::isInlineable to distinguish inline vs devirt-only GDV candidates.
src/coreclr/jit/indirectcalltransformer.cpp	Removes “must be inline-candidate” bail-out; expands GDV while conditionally re-marking inline candidates; fixes spill-temp and enumerator cloning map behavior.
src/coreclr/jit/importercalls.cpp	Keeps non-inlineable class-GDV candidates when legal; value-initializes candidate info; adjusts struct-return fixup deferral for GDV candidates.
src/coreclr/jit/compiler.h	Declares Compiler::canKeepNonInlineableGdvCandidate.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[MichalPetryka]

@MihuBot -nuget

[EgorBo]

@MihuBot -nuget

@MichalPetryka This change requires PGO data, MihuBot is basically just PrepareMethod

[EgorBo]

/azp run runtime-coreclr pgostress, runtime-coreclr libraries-pgo

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[EgorBo]

@EgorBot -linux_amd -osx_arm64 -windows_amd

usingSystem.Runtime.CompilerServices;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicinterfaceIOp{intDo(intx);}publicclassOpA:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+1;}publicclassOpB:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+2;}publicabstractclassBase{publicabstractintDo(intx);}publicclassDerA:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+1;}publicclassDerB:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+2;}publicclassBench{privateIOp[]_ifaces=newIOp[64];privateBase[]_virts=newBase[64];[GlobalSetup]publicvoidSetup(){for(inti=0;i<64;i++){// 75% A, 25% B_ifaces[i]=i%4==0?newOpB():newOpA();_virts[i]=i%4==0?newDerB():(Base)newDerA();}}[Benchmark]publicintInterfaceCall(){intsum=0;IOp[]ops=_ifaces;for(inti=0;i<ops.Length;i++)sum+=ops[i].Do(i);returnsum;}[Benchmark]publicintVirtualCall(){intsum=0;Base[]objs=_virts;for(inti=0;i<objs.Length;i++)sum+=objs[i].Do(i);returnsum;}}

[EgorBo]

PTAL @AndyAyersMS (see PR description), .NET 12.0 change cc @dotnet/jit-contrib.

[EgorBo]

cc @MichalStrehovsky I think you asked for it a while back for NAOT.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[EgorBo]

@AndyAyersMS addressed your feedback, it now needs re-approval 🙂

[EgorBo]

Ping @AndyAyersMS

[BrzVlad]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

[EgorBo]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

Yep, sorry, it's a bad last-minute feedback address change, I'll file a fix in a minute

[EgorBo]

#133014

Fixed.

[EgorBo]

GDV used to bail out when the target wasn't inlineable. A direct call still beats a virtual one, so keep the candidate and just don't inline it. DOTNET_JitGuardedDevirtualizationRequireInlining=1 restores the old behavior. Class probes only.

I know it doesn't match Andy's numbers, but many things have changed since then (e.g. CET), also, I assume we never tested it on arm64. So far it's a pure improvement on most kinds of scenarious (interface, virtual calls, etc.), see benchmarks below. We still might want to avoid doing it for virtual calls (esp for large target methods where the cost of the type check + direct call is a noise anyway) only on CoreCLR, but I propose we do it for everything and watch dotnet/performance reports.

Should help NativeAOT the most, where getExactClasses gives exact devirtualization but targets often aren't inlineable (if at least one target of getExactClasses wasn't inlineable we used to bail on the whole thing).

CoreCLR, default env, all targets [NoInlining] (so baseline does no GDV at all). Columns = how often the guessed type hits, ratio = new/base, lower is better.

Benchmark	Mono	Hit90	Hit50	Hit33	Hit25
DirectControl (noise floor)	1.01	0.99	1.01	1.01	1.00
Interface	$\color{green}{0.72}$	$\color{green}{0.48}$	$\color{green}{0.45}$	$\color{green}{0.64}$	$\color{green}{0.56}$
InterfaceShared (__Canon)	$\color{green}{0.88}$	$\color{green}{0.50}$	$\color{green}{0.51}$	$\color{green}{0.62}$	$\color{green}{0.59}$
InterfaceCostlyTarget	$\color{green}{0.86}$	$\color{green}{0.58}$	$\color{green}{0.55}$	$\color{green}{0.65}$	$\color{green}{0.60}$
Virtual	$\color{green}{0.86}$	$\color{green}{0.78}$	$\color{green}{0.63}$	$\color{green}{0.64}$	$\color{green}{0.62}$
VirtualShared (__Canon)	$\color{red}{1.19}$	$\color{green}{0.55}$	$\color{green}{0.55}$	$\color{green}{0.52}$	$\color{green}{0.63}$
InterfaceHugeTarget (GDV in both)	1.10	1.10	1.03	1.01	1.00

Only regression is monomorphic shared-generic virtual - a well-predicted vtable call is already as cheap as compare+direct call.

rt-sz report: MichalStrehovsky/rt-sz#246
smoke-test benchmarks: EgorBot/Benchmarks#489 (comment)

[azure-pipelines]

Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

This PR adjusts CoreCLR JIT guarded devirtualization (GDV) so that class-based GDV candidates can be kept and expanded even when the devirtualized target isn’t inlineable, preserving the direct-call benefit. It also adds a config switch to restore the legacy “require inlineability” behavior and tightens up candidate bookkeeping to support the new flow.

Changes:

• Add JitGuardedDevirtualizationRequireInlining config (default 0) to optionally restore legacy behavior of dropping non-inlineable GDV targets.
• Track per-candidate inlineability via InlineCandidateInfo::isInlineable and keep non-inlineable class-GDV candidates for devirtualization-only.
• Fix candidate bookkeeping (value-initialize InlineCandidateInfo and adjust spill-temp/enumerator-cloning mapping handling) to avoid relying on impCheckCanInline having run.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/jit/jitmetadatalist.h	Adds a new JIT metric counter (NoInlineGDV) for devirt-without-inlining cases.
src/coreclr/jit/jitconfigvalues.h	Introduces JitGuardedDevirtualizationRequireInlining config to gate legacy behavior.
src/coreclr/jit/inline.h	Adds InlineCandidateInfo::isInlineable to distinguish inline vs devirt-only GDV candidates.
src/coreclr/jit/indirectcalltransformer.cpp	Removes “must be inline-candidate” bail-out; expands GDV while conditionally re-marking inline candidates; fixes spill-temp and enumerator cloning map behavior.
src/coreclr/jit/importercalls.cpp	Keeps non-inlineable class-GDV candidates when legal; value-initializes candidate info; adjusts struct-return fixup deferral for GDV candidates.
src/coreclr/jit/compiler.h	Declares Compiler::canKeepNonInlineableGdvCandidate.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[MichalPetryka]

@MihuBot -nuget

[EgorBo]

@MihuBot -nuget

@MichalPetryka This change requires PGO data, MihuBot is basically just PrepareMethod

[EgorBo]

/azp run runtime-coreclr pgostress, runtime-coreclr libraries-pgo

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[EgorBo]

@EgorBot -linux_amd -osx_arm64 -windows_amd

usingSystem.Runtime.CompilerServices;usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);publicinterfaceIOp{intDo(intx);}publicclassOpA:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+1;}publicclassOpB:IOp{[MethodImpl(MethodImplOptions.NoInlining)]publicintDo(intx)=>x+2;}publicabstractclassBase{publicabstractintDo(intx);}publicclassDerA:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+1;}publicclassDerB:Base{[MethodImpl(MethodImplOptions.NoInlining)]publicoverrideintDo(intx)=>x+2;}publicclassBench{privateIOp[]_ifaces=newIOp[64];privateBase[]_virts=newBase[64];[GlobalSetup]publicvoidSetup(){for(inti=0;i<64;i++){// 75% A, 25% B_ifaces[i]=i%4==0?newOpB():newOpA();_virts[i]=i%4==0?newDerB():(Base)newDerA();}}[Benchmark]publicintInterfaceCall(){intsum=0;IOp[]ops=_ifaces;for(inti=0;i<ops.Length;i++)sum+=ops[i].Do(i);returnsum;}[Benchmark]publicintVirtualCall(){intsum=0;Base[]objs=_virts;for(inti=0;i<objs.Length;i++)sum+=objs[i].Do(i);returnsum;}}

[EgorBo]

PTAL @AndyAyersMS (see PR description), .NET 12.0 change cc @dotnet/jit-contrib.

[EgorBo]

cc @MichalStrehovsky I think you asked for it a while back for NAOT.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[EgorBo]

@AndyAyersMS addressed your feedback, it now needs re-approval 🙂

[EgorBo]

Ping @AndyAyersMS

[BrzVlad]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

[EgorBo]

@EgorBo I suspect this started causing crashes on my PR (#132787). Thoughts ?

 /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/x64/crossgen2/crossgen2 -o:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/System.Private.CoreLib.dll -r:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/*.dll --targetarch:x64 --obj-format:pe --targetos:linux --target-allows-runtime-code-generation:true -m:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/StandardOptimizationData.mibc --embed-pgo-data -O --verify-type-and-field-layout --enable-cached-interface-dispatch-support /__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/__w/1/s/artifacts/bin/coreclr/linux.x64.Checked/
/__w/1/s/src/coreclr/jit/fgdiagnostic.cpp:3416
Assertion failed 'block->HasFlag(BBF_RECURSIVE_TAILCALL)' in 'System.Type:GetTypeCodeImpl():int:this' during 'Morph - Inlining' (IL size 23; hash 0xf87e7a03; FullOpts)

Yep, sorry, it's a bad last-minute feedback address change, I'll file a fix in a minute

[EgorBo]

#133014

Fixed.