Uh oh!
There was an error while loading. Please reload this page.
Fix TypeMap failure in CI - #132549
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TypeMap interop test to validate proxy mappings using the same “source type → proxy type” direction that the TypeMapAssociation attributes encode, aligning this blob-only scenario with the established pattern used elsewhere in the TypeMap tests.
Changes:
- Adjusts the blob-only proxy-map assertion to query using the source type (
Lib5Type1) and expect the proxy type (Lib5Proxy1). - Uses
new Lib5Type1().GetType()for the lookup key, consistent with other proxy-map tests that rely on runtime type usage patterns.
Contributor
Tagging subscribers to this area: @dotnet/interop-contrib |
jkoritzinsky
approved these changes
Aug 20, 2026
jkoritzinsky
enabled auto-merge (squash)
August 20, 2026 04:19
AaronRobinsonMSFT
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like 00ecce5 is causing issues in CI.
Fix the blob-only TypeMap test to query its proxy mapping in the correct source -> proxy direction. Use
new Lib5Type1().GetType()so NativeAOT trimming retains the source entry.Investigated and fixed by Copilot.