Preserve information necessary to validate otherwise unused interface constraints in MakeGeneric

[Copilot]

The problem was that we didn't preserve information necessary to do the constraint check in MakeGeneric:

• Need to make sure we have metadata for the constraint (TypeMetadataNode change). Without this, the constraint could end up being an unresolvable TypeRef.
• Need to make sure interface constraints are tracked as interface type uses. This is done by a small overapproximation: we consider the interface type reflected on. I originally tracked it as InterfaceUse but that only works in modes without scanner since InterfaceUse is not propagated across scanning/compilation boundary. Reflected types are. rt-sz measurement says this doesn't matter. GenericTypeDefinitionNode needed to report interface use to complete the "reflected type" -> "interface use" implication. Other EEType node already did that. rt-sz says this doesn't matter either.

[azure-pipelines]

Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

[MichalStrehovsky]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

Updates the NativeAOT ILCompiler dependency analysis so generic-constraint information (metadata + interface-use tracking) is preserved when reflection-driven MakeGenericType / MakeGenericMethod flows require constraint validation.

Changes:

• Preserve metadata dependencies for generic parameter constraints when generating type metadata.
• Ensure reflection-visible generic interface definitions also contribute InterfaceUse so interface usage flows correctly across the scan/compile boundary.
• Add constraint-driven dependency rooting for MakeGenericType / MakeGenericMethod dataflow handling; update the regression test project to no longer depend on TestLibrary.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/TypeMetadataNode.cs	Adds metadata dependencies for generic parameter constraint types.
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/GenericDefinitionEETypeNode.cs	Ensures reflection-visible generic interface definitions also record InterfaceUse.
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/HandleCallAction.cs	Roots dependencies based on interface constraints when MakeGeneric* intrinsics are recognized.
src/tests/Loader/classloader/StaticVirtualMethods/Regression/GitHub_130545.csproj	Removes now-unneeded TestLibrary project reference.
src/tests/Loader/classloader/StaticVirtualMethods/Regression/GitHub_130545.cs	Removes TestLibrary usage and the ActiveIssue skip.

Suppressed comments (1)

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/HandleCallAction.cs:160

• Similarly for MakeGenericMethod: AddDependenciesFromConstraintUse runs before the arity check (inst.Length == methodInstantiated.Instantiation.Length). For malformed instantiation arrays that will fail at runtime, this still roots constraint interfaces. Consider moving it into the arity-match block to avoid unnecessary dependency growth.

 else if (!methodInstantiated.OwningType.IsGenericDefinition
&& TryGetMakeGenericInstantiation(_callingMethod, argumentValues[0], out Instantiation inst, out bool isExact))
{
AddDependenciesFromConstraintUse(_reflectionMarker, methodInstantiated.Instantiation);
if (inst.Length == methodInstantiated.Instantiation.Length)
{
methodInstantiated = methodInstantiated.MakeInstantiatedMethod(inst);