Uh oh!
There was an error while loading. Please reload this page.
Reactivate closed-issue Extensions tests - #132740
Open
svick wants to merge 3 commits into
Open
Conversation
Re-enable the previously closed-issue Extensions test cases so they run in CI validation for the cases from dotnet#131327. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The reactivated roslyn#52527 scenario fails locally with SYSLIB1015 before tests can run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
CI showed the Caching.Memory and DI.External assemblies and the encrypted XML test still fail on browser configurations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>.
svick
commented
Aug 25, 2026
MemberAuthor
CI run 1 (runtime build 1566711) showed that three reactivated browser scopes are still problematic, so commit
The linker and inner-loop pipelines passed. All runtime failures were accounted for by these reactivated scopes; no unrelated failure was found. Note This comment was generated with GitHub Copilot. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
svick
commented
Aug 27, 2026
MemberAuthor
/azp run runtime, runtime-dev-innerloop, dotnet-linker-tests |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This was referenced Aug 27, 2026
svick
commented
Aug 28, 2026
MemberAuthor
/azp run runtime, runtime-dev-innerloop, dotnet-linker-tests |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
svick
commented
Aug 28, 2026
MemberAuthor
/azp run runtime, runtime-dev-innerloop, dotnet-linker-tests |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
svick
commented
Aug 31, 2026
MemberAuthor
/azp run runtime-extra-platforms, runtime-wasm-libtests, runtime-libraries-coreclr outerloop |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This was referenced Aug 31, 2026
This was referenced Aug 31, 2026
svick
commented
Sep 1, 2026
MemberAuthor
There are no relevant build failures, so I think this is ready. |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Pull request overview
This PR re-enables a set of Microsoft.Extensions-related test cases by removing [ActiveIssue] skips that referenced now-closed issues, increasing the effective test coverage exercised by CI across supported configurations.
Changes:
- Removes
[ActiveIssue]attributes from multiple Microsoft.Extensions test cases (Options, Logging, Hosting, Http, Configuration, DependencyModel, DI) so they execute again. - Keeps existing platform guards where present (e.g.,
[ConditionalFact]/[SkipOnPlatform]) while removing issue-based disables. - Reorders attributes on one XML configuration encrypted-XML test so
[Fact]appears after the remaining[ActiveIssue]attributes.
File summaries
| File | Description |
|---|---|
| src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsFactoryTests.cs | Removes Android-only [ActiveIssue] disables from two OptionsFactory tests. |
| src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerTest.cs | Re-enables several scope-related tests previously skipped on Mono via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerMessageTest.cs | Re-enables LoggerMessage/Define* exception tests previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerFilterTest.cs | Re-enables a wildcard validation test previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerFactoryExtensionsTest.cs | Re-enables LoggerFactory extension tests previously skipped on Mono via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs | Removes Browser-only class-level [ActiveIssue] to re-enable generator parser tests. |
| src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorEmitterTests.cs | Removes Browser-only class-level [ActiveIssue] to re-enable generator emitter tests. |
| src/libraries/Microsoft.Extensions.Http/tests/Microsoft.Extensions.Http.Tests/HttpMessageHandlerBuilderTest.cs | Re-enables two pipeline validation tests previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Http/tests/Microsoft.Extensions.Http.Tests/DependencyInjection/HttpClientFactoryServiceCollectionExtensionsTest.cs | Re-enables one DI behavior test previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Http/tests/Microsoft.Extensions.Http.Tests/DefaultHttpMessageHandlerBuilderTest.cs | Re-enables three DefaultHttpMessageHandlerBuilder tests previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs | Re-enables CreateDefaultBuilder reload-behavior test by removing [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonReaderTest.cs | Re-enables two JSON reader tests previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderCompilationTest.cs | Re-enables compilation/limited stack test by removing Mono [ActiveIssue] skips. |
| src/libraries/Microsoft.Extensions.Configuration.Xml/tests/XmlConfigurationTest.cs | Retains remaining ActiveIssue guards but changes attribute ordering and keeps test enabled where applicable. |
| src/libraries/Microsoft.Extensions.Configuration.Ini/tests/IniConfigurationTest.cs | Re-enables missing-file test previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Configuration.Ini/tests/IniConfigurationExtensionsTest.cs | Re-enables null/empty path and missing-file extension tests previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Configuration.FileExtensions/tests/FileConfigurationProviderTest.cs | Re-enables invalid-data load test previously skipped on Android via [ActiveIssue]. |
| src/libraries/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.cs | Removes Browser-only class-level [ActiveIssue] to re-enable configuration binding generator tests. |
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.Tests kept disabled
LoggerMessageGeneratedCodeTests.MessageTests_SuppressWarning_WarnAsError_NoError(Diagnostics from Source Generators do not respect suppression roslyn#52527): reactivation caused 12SYSLIB1015build errors locally before the test could run, so the test body and its generator inputs remain disabled.Microsoft.Extensions.Caching.Memory.Testsassembly (Microsoft.Extensions.Caching.Memory.Tests hanging in Mono after test execution finishes #35970): the attempted reactivation exposed 19–25 browser failures per run across Mono and CoreCLR, including unsupported operations and assertion failures. The original Mono assembly skip,<IgnoreForCI>gate, and Browser project exclusion were restored.Microsoft.Extensions.DependencyInjection.ExternalContainers.Testsassembly on Browser (Blazor client developers can use Parallel.For in their applications to share more code with server #43411): 63 tests failed per browser run, primarily withPlatformNotSupportedException, so the assembly-wide Browser skip was restored.XmlConfigurationTest.LoadKeyValuePairsFromValidEncryptedXmlon Browser and aggressive trimming ([wasm] Enable crypto and related tests #37669, Annotate System.Security.Cryptography.Xml for trimming #73432): Browser failed because AES is unsupported there. The test was restored to its original state, including both conditions; the aggressive-trimming condition was not independently revalidated after the Browser failure.Validation
The libraries baseline build and affected desktop test projects passed with the cases above kept disabled. The retained reactivations then completed five full CI matrices without a related failure:
Additional coverage was run in CoreCLR library outer-loop build 1574778 and extra-platforms build 1574779. Their failures were unrelated to the reactivated tests.
Contributes to #131327
Note
This PR description was generated with GitHub Copilot.