Skip to content

Use rolling Windows queue for latest Windows tests - #132846

Merged
agocke merged 2 commits into
dotnet:mainfrom
agocke:agocke/windows-helix-latest-queue
Aug 29, 2026
Merged

Use rolling Windows queue for latest Windows tests#132846
agocke merged 2 commits into
dotnet:mainfrom
agocke:agocke/windows-helix-latest-queue

Conversation

@agocke

@agockeagocke commented Aug 27, 2026

Copy link
Copy Markdown
Member

Switch the latest public Windows x64 Helix alias from the version-pinned Windows 11 client queue to the rolling runtime queue. Update CoreCLR queue selection to consume the central latest aliases for Windows x64, CET, and ARM64, and route the primary generic libraries Windows x64 tests through the latest alias.

AliasPrevious queueNew queue
helix_windows_x64_latestWindows.11.Amd64.Client.OpenWindows.Amd64.Open.rt

Explicitly versioned Windows queues, including Windows 10, Windows Server, CET, ARM64, Nano, and the oldest aliases, remain unchanged.

Validation: git diff --check and queue-mapping assertions. The rolling queue was previously exercised by #132328.

Note

This pull request description was generated by GitHub Copilot.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b9f69037-9948-43a6-ab46-85ee954faa3b
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@agocke
agocke requested a review from steveisokAugust 27, 2026 18:25
@agockeagocke changed the title Use rolling Windows queue for latest CoreCLR testsUse rolling Windows queue for most helix testingAug 27, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b9f69037-9948-43a6-ab46-85ee954faa3b

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Lite
Findings: 1 Medium severity · 1 Low severity

New issues introduced by this change (2)
SeverityFinding
Low severityeng/​pipelines/​helix-platforms.yml — The comment header for the Windows x64 “Latest” section is now ambiguous: it implies the whole…
Medium severityeng/​pipelines/​coreclr/​templates/​helix-queues-setup.yml — This change switches the internal windows_x64 CoreCLR Helix queue from a Windows 10 queue…
What changed in this PR

This PR updates Helix queue aliasing for Windows to move the public “latest” Windows x64 queue from a version-pinned Windows 11 client queue to the rolling runtime Windows queue, and updates CoreCLR’s queue selection template to consume the centralized Windows queue variables (x64, CET, and ARM64).

Changes:

  • Update helix_windows_x64_latest to use Windows.Amd64.Open.rt (rolling runtime queue).
  • Update CoreCLR Helix queue selection to use $(helix_windows_x64_latest), $(helix_windows_x64_latest_cet), and $(helix_windows_arm64_latest*) variables instead of hard-coded queue names.
FileDescription
eng/​pipelines/​helix-platforms.ymlSwitch the public Windows x64 “latest” queue alias to the rolling runtime queue and adjust related commentary.
eng/​pipelines/​coreclr/​templates/​helix-queues-setup.ymlUse centralized helix-platform variables for Windows x64/CET and Windows ARM64 queue selection.

Comment threadeng/pipelines/helix-platforms.yml
Comment threadeng/pipelines/coreclr/templates/helix-queues-setup.yml
CopilotAI review requested due to automatic review settings August 27, 2026 18:30
@agockeagocke changed the title Use rolling Windows queue for most helix testingUse rolling Windows queue for latest Windows testsAug 27, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Lite
Findings: 2 Medium severity · 1 Low severity

New issues introduced by this change (1)
SeverityFinding
Medium severityeng/​pipelines/​libraries/​helix-queues-setup.yml — This change replaces the explicit primary Server2025 queue with $(helix_windows_x64_latest). That…
Pre-existing issues (2)
SeverityFinding
Medium severityeng/​pipelines/​coreclr/​templates/​helix-queues-setup.yml — This change switches the internal windows_x64 CoreCLR Helix queue from a Windows 10 queue… View comment
Low severityeng/​pipelines/​helix-platforms.yml — The comment header for the Windows x64 “Latest” section is now ambiguous: it implies the whole… View comment
Suppressed comments (1)

eng/pipelines/coreclr/templates/helix-queues-setup.yml:154

  • CoreCLR internal Windows x64 queue selection changes from the explicit Windows.10.Amd64 to $(helix_windows_x64_latest_internal) (currently Windows.11.Amd64). If the goal here is only to update public/"latest" routing, consider keeping the internal queue pinned to Windows 10 (e.g., $(helix_windows_x64_oldest_internal)) or update the PR description to call out the internal OS bump explicitly.
 - ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- $(helix_windows_x64_latest_internal)

Comment threadeng/pipelines/libraries/helix-queues-setup.yml
@agocke

Copy link
Copy Markdown
MemberAuthor

/ba-g failures are #132830

@agocke
agocke merged commit aa036af into dotnet:mainAug 29, 2026
173 of 179 checks passed
@agocke
agocke deleted the agocke/windows-helix-latest-queue branch August 29, 2026 22:20
@jkotas

jkotas commented Aug 30, 2026

Copy link
Copy Markdown
Member

Windows.Amd64.Open.rt does not have machines with AVX512. It runs on AMD EPYC (Dav4).

Do we have sufficient coverage for AVX512 codegen and AVX512-specific optimizations in libraries after this change? cc @dotnet/jit-contrib @tannergooding

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants

@agocke@jkotas@steveisok@jkoritzinsky