Uh oh!
There was an error while loading. Please reload this page.
Replace CoreCLR PAL wait subsystem - #132927
Draft
jkoritzinsky wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Tagging subscribers to this area: @agocke |
This was referenced Aug 29, 2026
jkotas
reviewed
Aug 30, 2026
| (void)alertable; | ||
| assert(count == 1); | ||
| assert(!waitAll); |
Member
There was a problem hiding this comment.
Can we delete these arguments instead?
| if (!allowReentrantWait) | ||
| { | ||
| return WaitForMultipleObjectsEx(handleCount, pHandles, FALSE, timeout, alertable); | ||
| return PAL_WaitForMultipleObjectsEx(handleCount, pHandles, false, timeout, alertable); |
Member
There was a problem hiding this comment.
This should not be routed through PAL_WaitForMultipleObjectsEx
| // | ||
| // CLR wrapper around events. This version directly uses Win32 events (there's no support for host | ||
| // interception). | ||
| // CLR wrapper around native events. This version does not support host interception. |
Member
There was a problem hiding this comment.
Suggested change
| // CLR wrapper around native events. This version does not support host interception. | |
| // CLR wrapper around native events. |
Host interception is not a thing anymore
| OBJECT | ||
| ${SOURCES} | ||
| ) | ||
| target_include_directories(coreclrminipal_objects PRIVATE ${CMAKE_BINARY_DIR}/shared_minipal) |
| #include "RuntimeEvent.h" | ||
| #include "synch.h" | ||
| void CLREventBase::CreateAutoEvent (BOOL bInitialState // If TRUE, initial state is signalled |
Member
There was a problem hiding this comment.
Can we make CLREventBase (renamed to RuntimeEvent or even minipal_event) to be the abstraction with platform-specific implementations to make this more type-safe and flatter? A lot of code in the runtime is coded against CLREvent already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreCLR's remaining Unix native waits are single-handle event waits, so the legacy PAL synchronization manager and its waitable handle infrastructure are no longer needed.
This change:
src/coreclr/runtimefor shared CoreCLR and NativeAOT use, with direct Windows forwarding and a pthread-based Unix implementation;PAL_Sleep, backed bySleepon Windows and EINTR-safenanosleepon Unix;Testing
./build.sh clr+libs+host./build.sh clr.native+clr.paltestsNote
This pull request description was created by GitHub Copilot.