Uh oh!
There was an error while loading. Please reload this page.
[perf][wasm] Stage Crossgen2 pack for CoreCLR R2R benchmarks - #133040
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4188acf-cdd7-467f-818f-5a43eaaf9e3e
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4188acf-cdd7-467f-818f-5a43eaaf9e3e
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to the CoreCLR browser-wasm perf pipeline and the updated conditions/staging logic are consistent with existing TargetsMobile semantics for TargetOS=browser.
Pull request overview
This PR updates the WASM performance build to produce and stage the host Crossgen2 pack alongside the CoreCLR browser-wasm performance artifact, enabling downstream R2R publishing on isolated machines using same-build assets.
Changes:
- Allow building the Crossgen2 host pack when
TargetOS=browserandBuildHostTools=true(even though browser setsTargetsMobile=true). - Add an optional pipeline step to copy the non-symbol
Microsoft.NETCore.App.Crossgen2.*.nupkginto the stagedbuilt-nugetsfeed and fail if none is present. - Enable
BuildHostTools=truefor the CoreCLR browser-wasm perf build job and turn on Crossgen2 pack staging for its artifact.
File summaries
| File | Description |
|---|---|
| eng/Subsets.props | Adjusts pack-building conditions so browser-wasm CoreCLR builds can produce the host Crossgen2 pack when opted in. |
| eng/pipelines/performance/templates/perf-wasm-prepare-artifacts-steps.yml | Adds an opt-in step to stage only non-symbol Crossgen2 nupkgs into the perf artifact’s local feed. |
| eng/pipelines/performance/templates/perf-wasm-build-jobs.yml | Opts the CoreCLR browser-wasm perf job into BuildHostTools and Crossgen2 pack staging. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
lewing
commented
Sep 2, 2026
dotnet/performance#5297 is the consuming side once this lands |
pavelsavara
commented
Sep 2, 2026
is @radekdoulik doing the same thing in #131877 ? |
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
lewing
commented
Sep 2, 2026
/ba-g failures are not related |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Stage the matching locally built, non-symbol
Microsoft.NETCore.App.Crossgen2package in theBrowserWasmCoreCLRperformance artifact understaging/built-nugets.This enables isolated Helix machines to resolve the same-build Crossgen2 pack when per-application browser-WASM benchmarks publish with
PublishReadyToRun=true. The CoreCLR performance build enablesBuildHostTools, and the pack subset permits browser builds with that explicit opt-in to runMicrosoft.NETCore.App.Crossgen2.Host.sfxproj. The package selection excludes*.symbols.nupkgand fails if no matching non-symbol package is available. These changes apply only toBrowserWasmCoreCLR; Mono artifact behavior is unchanged.End-to-end
runtime-wasm-perfvalidation depends on the companiondotnet/performancechange currently at commit17449e9826d0ecc224e92a3ad854796b0be41219.Validation
git diff --checkand commit checks.BuildHostTools=trueincludesMicrosoft.NETCore.App.Crossgen2.Host.sfxproj;BuildHostTools=true.Note
This pull request was generated with the assistance of GitHub Copilot.